[SCSI] libosd: Fix blk_put_request locking again
[safe/jmp/linux-2.6] / drivers / scsi / osd / osd_initiator.c
index c98153b..2422347 100644 (file)
@@ -73,7 +73,8 @@ static const char *_osd_ver_desc(struct osd_request *or)
 
 #define ATTR_DEF_RI(id, len) ATTR_DEF(OSD_APAGE_ROOT_INFORMATION, id, len)
 
-static int _osd_print_system_info(struct osd_dev *od, void *caps)
+static int _osd_get_print_system_info(struct osd_dev *od,
+       void *caps, struct osd_dev_info *odi)
 {
        struct osd_request *or;
        struct osd_attr get_attrs[] = {
@@ -137,8 +138,12 @@ static int _osd_print_system_info(struct osd_dev *od, void *caps)
        OSD_INFO("PRODUCT_SERIAL_NUMBER  [%s]\n",
                (char *)pFirst);
 
-       pFirst = get_attrs[a].val_ptr;
-       OSD_INFO("OSD_NAME               [%s]\n", (char *)pFirst);
+       odi->osdname_len = get_attrs[a].len;
+       /* Avoid NULL for memcmp optimization 0-length is good enough */
+       odi->osdname = kzalloc(odi->osdname_len + 1, GFP_KERNEL);
+       if (odi->osdname_len)
+               memcpy(odi->osdname, get_attrs[a].val_ptr, odi->osdname_len);
+       OSD_INFO("OSD_NAME               [%s]\n", odi->osdname);
        a++;
 
        pFirst = get_attrs[a++].val_ptr;
@@ -171,6 +176,14 @@ static int _osd_print_system_info(struct osd_dev *od, void *caps)
                                   sid_dump, sizeof(sid_dump), true);
                OSD_INFO("OSD_SYSTEM_ID(%d)\n"
                         "        [%s]\n", len, sid_dump);
+
+               if (unlikely(len > sizeof(odi->systemid))) {
+                       OSD_ERR("OSD Target error: OSD_SYSTEM_ID too long(%d). "
+                               "device idetification might not work\n", len);
+                       len = sizeof(odi->systemid);
+               }
+               odi->systemid_len = len;
+               memcpy(odi->systemid, get_attrs[a].val_ptr, len);
                a++;
        }
 out:
@@ -178,16 +191,17 @@ out:
        return ret;
 }
 
-int osd_auto_detect_ver(struct osd_dev *od, void *caps)
+int osd_auto_detect_ver(struct osd_dev *od,
+       void *caps, struct osd_dev_info *odi)
 {
        int ret;
 
        /* Auto-detect the osd version */
-       ret = _osd_print_system_info(od, caps);
+       ret = _osd_get_print_system_info(od, caps, odi);
        if (ret) {
                osd_dev_set_ver(od, OSD_VER1);
                OSD_DEBUG("converting to OSD1\n");
-               ret = _osd_print_system_info(od, caps);
+               ret = _osd_get_print_system_info(od, caps, odi);
        }
 
        return ret;
@@ -418,30 +432,23 @@ static void _osd_free_seg(struct osd_request *or __unused,
        seg->alloc_size = 0;
 }
 
-static void _put_request(struct request *rq , bool is_async)
+static void _put_request(struct request *rq)
 {
-       if (is_async) {
-               WARN_ON(rq->bio);
-               __blk_put_request(rq->q, rq);
-       } else {
-               /*
-                * If osd_finalize_request() was called but the request was not
-                * executed through the block layer, then we must release BIOs.
-                * TODO: Keep error code in or->async_error. Need to audit all
-                *       code paths.
-                */
-               if (unlikely(rq->bio))
-                       blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq));
-               else
-                       blk_put_request(rq);
-       }
+       /*
+        * If osd_finalize_request() was called but the request was not
+        * executed through the block layer, then we must release BIOs.
+        * TODO: Keep error code in or->async_error. Need to audit all
+        *       code paths.
+        */
+       if (unlikely(rq->bio))
+               blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq));
+       else
+               blk_put_request(rq);
 }
 
 void osd_end_request(struct osd_request *or)
 {
        struct request *rq = or->request;
-       /* IMPORTANT: make sure this agrees with osd_execute_request_async */
-       bool is_async = (or->request->end_io_data == or);
 
        _osd_free_seg(or, &or->set_attr);
        _osd_free_seg(or, &or->enc_get_attr);
@@ -449,19 +456,34 @@ void osd_end_request(struct osd_request *or)
 
        if (rq) {
                if (rq->next_rq) {
-                       _put_request(rq->next_rq, is_async);
+                       _put_request(rq->next_rq);
                        rq->next_rq = NULL;
                }
 
-               _put_request(rq, is_async);
+               _put_request(rq);
        }
        _osd_request_free(or);
 }
 EXPORT_SYMBOL(osd_end_request);
 
+static void _set_error_resid(struct osd_request *or, struct request *req,
+                            int error)
+{
+       or->async_error = error;
+       or->req_errors = req->errors ? : error;
+       or->sense_len = req->sense_len;
+       if (or->out.req)
+               or->out.residual = or->out.req->resid_len;
+       if (or->in.req)
+               or->in.residual = or->in.req->resid_len;
+}
+
 int osd_execute_request(struct osd_request *or)
 {
-       return blk_execute_rq(or->request->q, NULL, or->request, 0);
+       int error = blk_execute_rq(or->request->q, NULL, or->request, 0);
+
+       _set_error_resid(or, or->request, error);
+       return error;
 }
 EXPORT_SYMBOL(osd_execute_request);
 
@@ -469,10 +491,16 @@ static void osd_request_async_done(struct request *req, int error)
 {
        struct osd_request *or = req->end_io_data;
 
-       or->async_error = error;
+       _set_error_resid(or, req, error);
+       if (req->next_rq) {
+               __blk_put_request(req->q, req->next_rq);
+               req->next_rq = NULL;
+       }
 
-       if (error)
-               OSD_DEBUG("osd_request_async_done error recieved %d\n", error);
+       __blk_put_request(req->q, req);
+       or->request = NULL;
+       or->in.req = NULL;
+       or->out.req = NULL;
 
        if (or->async_done)
                or->async_done(or, or->async_private);
@@ -670,7 +698,7 @@ static int _osd_req_list_objects(struct osd_request *or,
        __be16 action, const struct osd_obj_id *obj, osd_id initial_id,
        struct osd_obj_id_list *list, unsigned nelem)
 {
-       struct request_queue *q = or->osd_dev->scsi_device->request_queue;
+       struct request_queue *q = osd_request_queue(or->osd_dev);
        u64 len = nelem * sizeof(osd_id) + sizeof(*list);
        struct bio *bio;
 
@@ -779,26 +807,28 @@ EXPORT_SYMBOL(osd_req_remove_object);
 */
 
 void osd_req_write(struct osd_request *or,
-       const struct osd_obj_id *obj, struct bio *bio, u64 offset)
+       const struct osd_obj_id *obj, u64 offset,
+       struct bio *bio, u64 len)
 {
-       _osd_req_encode_common(or, OSD_ACT_WRITE, obj, offset, bio->bi_size);
+       _osd_req_encode_common(or, OSD_ACT_WRITE, obj, offset, len);
        WARN_ON(or->out.bio || or->out.total_bytes);
-       bio->bi_rw |= (1 << BIO_RW);
+       WARN_ON(0 ==  bio_rw_flagged(bio, BIO_RW));
        or->out.bio = bio;
-       or->out.total_bytes = bio->bi_size;
+       or->out.total_bytes = len;
 }
 EXPORT_SYMBOL(osd_req_write);
 
 int osd_req_write_kern(struct osd_request *or,
        const struct osd_obj_id *obj, u64 offset, void* buff, u64 len)
 {
-       struct request_queue *req_q = or->osd_dev->scsi_device->request_queue;
+       struct request_queue *req_q = osd_request_queue(or->osd_dev);
        struct bio *bio = bio_map_kern(req_q, buff, len, GFP_KERNEL);
 
        if (IS_ERR(bio))
                return PTR_ERR(bio);
 
-       osd_req_write(or, obj, bio, offset);
+       bio->bi_rw |= (1 << BIO_RW); /* FIXME: bio_set_dir() */
+       osd_req_write(or, obj, offset, bio, len);
        return 0;
 }
 EXPORT_SYMBOL(osd_req_write_kern);
@@ -828,26 +858,27 @@ void osd_req_flush_object(struct osd_request *or,
 EXPORT_SYMBOL(osd_req_flush_object);
 
 void osd_req_read(struct osd_request *or,
-       const struct osd_obj_id *obj, struct bio *bio, u64 offset)
+       const struct osd_obj_id *obj, u64 offset,
+       struct bio *bio, u64 len)
 {
-       _osd_req_encode_common(or, OSD_ACT_READ, obj, offset, bio->bi_size);
+       _osd_req_encode_common(or, OSD_ACT_READ, obj, offset, len);
        WARN_ON(or->in.bio || or->in.total_bytes);
-       bio->bi_rw &= ~(1 << BIO_RW);
+       WARN_ON(1 == bio_rw_flagged(bio, BIO_RW));
        or->in.bio = bio;
-       or->in.total_bytes = bio->bi_size;
+       or->in.total_bytes = len;
 }
 EXPORT_SYMBOL(osd_req_read);
 
 int osd_req_read_kern(struct osd_request *or,
        const struct osd_obj_id *obj, u64 offset, void* buff, u64 len)
 {
-       struct request_queue *req_q = or->osd_dev->scsi_device->request_queue;
+       struct request_queue *req_q = osd_request_queue(or->osd_dev);
        struct bio *bio = bio_map_kern(req_q, buff, len, GFP_KERNEL);
 
        if (IS_ERR(bio))
                return PTR_ERR(bio);
 
-       osd_req_read(or, obj, bio, offset);
+       osd_req_read(or, obj, offset, bio, len);
        return 0;
 }
 EXPORT_SYMBOL(osd_req_read_kern);
@@ -918,26 +949,6 @@ int osd_req_add_set_attr_list(struct osd_request *or,
 }
 EXPORT_SYMBOL(osd_req_add_set_attr_list);
 
-static int _append_map_kern(struct request *req,
-       void *buff, unsigned len, gfp_t flags)
-{
-       struct bio *bio;
-       int ret;
-
-       bio = bio_map_kern(req->q, buff, len, flags);
-       if (IS_ERR(bio)) {
-               OSD_ERR("Failed bio_map_kern(%p, %d) => %ld\n", buff, len,
-                       PTR_ERR(bio));
-               return PTR_ERR(bio);
-       }
-       ret = blk_rq_append_bio(req->q, req, bio);
-       if (ret) {
-               OSD_ERR("Failed blk_rq_append_bio(%p) => %d\n", bio, ret);
-               bio_put(bio);
-       }
-       return ret;
-}
-
 static int _req_append_segment(struct osd_request *or,
        unsigned padding, struct _osd_req_data_segment *seg,
        struct _osd_req_data_segment *last_seg, struct _osd_io_info *io)
@@ -953,14 +964,14 @@ static int _req_append_segment(struct osd_request *or,
                else
                        pad_buff = io->pad_buff;
 
-               ret = _append_map_kern(io->req, pad_buff, padding,
+               ret = blk_rq_map_kern(io->req->q, io->req, pad_buff, padding,
                                       or->alloc_flags);
                if (ret)
                        return ret;
                io->total_bytes += padding;
        }
 
-       ret = _append_map_kern(io->req, seg->buff, seg->total_bytes,
+       ret = blk_rq_map_kern(io->req->q, io->req, seg->buff, seg->total_bytes,
                               or->alloc_flags);
        if (ret)
                return ret;
@@ -1170,6 +1181,7 @@ int osd_req_decode_get_attr_list(struct osd_request *or,
                                "c=%d r=%d n=%d\n",
                                cur_bytes, returned_bytes, n);
                        oa->val_ptr = NULL;
+                       cur_bytes = returned_bytes; /* break the caller loop */
                        break;
                }
 
@@ -1262,7 +1274,7 @@ static inline void osd_sec_parms_set_in_offset(bool is_v1,
 }
 
 static int _osd_req_finalize_data_integrity(struct osd_request *or,
-       bool has_in, bool has_out, const u8 *cap_key)
+       bool has_in, bool has_out, u64 out_data_bytes, const u8 *cap_key)
 {
        struct osd_security_parameters *sec_parms = _osd_req_sec_params(or);
        int ret;
@@ -1277,8 +1289,7 @@ static int _osd_req_finalize_data_integrity(struct osd_request *or,
                };
                unsigned pad;
 
-               or->out_data_integ.data_bytes = cpu_to_be64(
-                       or->out.bio ? or->out.bio->bi_size : 0);
+               or->out_data_integ.data_bytes = cpu_to_be64(out_data_bytes);
                or->out_data_integ.set_attributes_bytes = cpu_to_be64(
                        or->set_attr.total_bytes);
                or->out_data_integ.get_attributes_bytes = cpu_to_be64(
@@ -1322,6 +1333,21 @@ static int _osd_req_finalize_data_integrity(struct osd_request *or,
 /*
  * osd_finalize_request and helpers
  */
+static struct request *_make_request(struct request_queue *q, bool has_write,
+                             struct _osd_io_info *oii, gfp_t flags)
+{
+       if (oii->bio)
+               return blk_make_request(q, oii->bio, flags);
+       else {
+               struct request *req;
+
+               req = blk_get_request(q, has_write ? WRITE : READ, flags);
+               if (unlikely(!req))
+                       return ERR_PTR(-ENOMEM);
+
+               return req;
+       }
+}
 
 static int _init_blk_request(struct osd_request *or,
        bool has_in, bool has_out)
@@ -1330,14 +1356,18 @@ static int _init_blk_request(struct osd_request *or,
        struct scsi_device *scsi_device = or->osd_dev->scsi_device;
        struct request_queue *q = scsi_device->request_queue;
        struct request *req;
-       int ret = -ENOMEM;
+       int ret;
 
-       req = blk_get_request(q, has_out, flags);
-       if (!req)
+       req = _make_request(q, has_out, has_out ? &or->out : &or->in, flags);
+       if (IS_ERR(req)) {
+               ret = PTR_ERR(req);
                goto out;
+       }
 
        or->request = req;
        req->cmd_type = REQ_TYPE_BLOCK_PC;
+       req->cmd_flags |= REQ_QUIET;
+
        req->timeout = or->timeout;
        req->retries = or->retries;
        req->sense = or->sense;
@@ -1347,9 +1377,10 @@ static int _init_blk_request(struct osd_request *or,
                or->out.req = req;
                if (has_in) {
                        /* allocate bidi request */
-                       req = blk_get_request(q, READ, flags);
-                       if (!req) {
+                       req = _make_request(q, false, &or->in, flags);
+                       if (IS_ERR(req)) {
                                OSD_DEBUG("blk_get_request for bidi failed\n");
+                               ret = PTR_ERR(req);
                                goto out;
                        }
                        req->cmd_type = REQ_TYPE_BLOCK_PC;
@@ -1370,6 +1401,7 @@ int osd_finalize_request(struct osd_request *or,
 {
        struct osd_cdb_head *cdbh = osd_cdb_head(&or->cdb);
        bool has_in, has_out;
+       u64 out_data_bytes = or->out.total_bytes;
        int ret;
 
        if (options & OSD_REQ_FUA)
@@ -1393,26 +1425,6 @@ int osd_finalize_request(struct osd_request *or,
                return ret;
        }
 
-       if (or->out.bio) {
-               ret = blk_rq_append_bio(or->request->q, or->out.req,
-                                       or->out.bio);
-               if (ret) {
-                       OSD_DEBUG("blk_rq_append_bio out failed\n");
-                       return ret;
-               }
-               OSD_DEBUG("out bytes=%llu (bytes_req=%u)\n",
-                       _LLU(or->out.total_bytes), or->out.req->data_len);
-       }
-       if (or->in.bio) {
-               ret = blk_rq_append_bio(or->request->q, or->in.req, or->in.bio);
-               if (ret) {
-                       OSD_DEBUG("blk_rq_append_bio in failed\n");
-                       return ret;
-               }
-               OSD_DEBUG("in bytes=%llu (bytes_req=%u)\n",
-                       _LLU(or->in.total_bytes), or->in.req->data_len);
-       }
-
        or->out.pad_buff = sg_out_pad_buffer;
        or->in.pad_buff = sg_in_pad_buffer;
 
@@ -1439,7 +1451,8 @@ int osd_finalize_request(struct osd_request *or,
                }
        }
 
-       ret = _osd_req_finalize_data_integrity(or, has_in, has_out, cap_key);
+       ret = _osd_req_finalize_data_integrity(or, has_in, has_out,
+                                              out_data_bytes, cap_key);
        if (ret)
                return ret;
 
@@ -1452,6 +1465,15 @@ int osd_finalize_request(struct osd_request *or,
 }
 EXPORT_SYMBOL(osd_finalize_request);
 
+static bool _is_osd_security_code(int code)
+{
+       return  (code == osd_security_audit_value_frozen) ||
+               (code == osd_security_working_key_frozen) ||
+               (code == osd_nonce_not_unique) ||
+               (code == osd_nonce_timestamp_out_of_range) ||
+               (code == osd_invalid_dataout_buffer_integrity_check_value);
+}
+
 #define OSD_SENSE_PRINT1(fmt, a...) \
        do { \
                if (__cur_sense_need_output) \
@@ -1474,27 +1496,29 @@ int osd_req_decode_sense_full(struct osd_request *or,
 #else
        bool __cur_sense_need_output = !silent;
 #endif
+       int ret;
 
-       if (!or->request->errors)
+       if (likely(!or->req_errors))
                return 0;
 
-       ssdb = or->request->sense;
-       sense_len = or->request->sense_len;
+       osi = osi ? : &local_osi;
+       memset(osi, 0, sizeof(*osi));
+
+       ssdb = (typeof(ssdb))or->sense;
+       sense_len = or->sense_len;
        if ((sense_len < (int)sizeof(*ssdb) || !ssdb->sense_key)) {
                OSD_ERR("Block-layer returned error(0x%x) but "
                        "sense_len(%u) || key(%d) is empty\n",
-                       or->request->errors, sense_len, ssdb->sense_key);
-               return -EIO;
+                       or->req_errors, sense_len, ssdb->sense_key);
+               goto analyze;
        }
 
        if ((ssdb->response_code != 0x72) && (ssdb->response_code != 0x73)) {
                OSD_ERR("Unrecognized scsi sense: rcode=%x length=%d\n",
                        ssdb->response_code, sense_len);
-               return -EIO;
+               goto analyze;
        }
 
-       osi = osi ? : &local_osi;
-       memset(osi, 0, sizeof(*osi));
        osi->key = ssdb->sense_key;
        osi->additional_code = be16_to_cpu(ssdb->additional_sense_code);
        original_sense_len = ssdb->additional_sense_length + 8;
@@ -1504,9 +1528,10 @@ int osd_req_decode_sense_full(struct osd_request *or,
                __cur_sense_need_output = (osi->key > scsi_sk_recovered_error);
 #endif
        OSD_SENSE_PRINT1("Main Sense information key=0x%x length(%d, %d) "
-                       "additional_code=0x%x\n",
+                       "additional_code=0x%x async_error=%d errors=0x%x\n",
                        osi->key, original_sense_len, sense_len,
-                       osi->additional_code);
+                       osi->additional_code, or->async_error,
+                       or->req_errors);
 
        if (original_sense_len < sense_len)
                sense_len = original_sense_len;
@@ -1585,15 +1610,14 @@ int osd_req_decode_sense_full(struct osd_request *or,
                {
                        struct osd_sense_attributes_data_descriptor
                                *osadd = cur_descriptor;
-                       int len = min(cur_len, sense_len);
-                       int i = 0;
+                       unsigned len = min(cur_len, sense_len);
                        struct osd_sense_attr *pattr = osadd->sense_attrs;
 
-                       while (len < 0) {
+                       while (len >= sizeof(*pattr)) {
                                u32 attr_page = be32_to_cpu(pattr->attr_page);
                                u32 attr_id = be32_to_cpu(pattr->attr_id);
 
-                               if (i++ == 0) {
+                               if (!osi->attr.attr_page) {
                                        osi->attr.attr_page = attr_page;
                                        osi->attr.attr_id = attr_id;
                                }
@@ -1604,6 +1628,8 @@ int osd_req_decode_sense_full(struct osd_request *or,
                                        bad_attr_list++;
                                        max_attr--;
                                }
+
+                               len -= sizeof(*pattr);
                                OSD_SENSE_PRINT2(
                                        "osd_sense_attribute_identification"
                                        "attr_page=0x%x attr_id=0x%x\n",
@@ -1637,7 +1663,50 @@ int osd_req_decode_sense_full(struct osd_request *or,
                cur_descriptor += cur_len;
        }
 
-       return (osi->key > scsi_sk_recovered_error) ? -EIO : 0;
+analyze:
+       if (!osi->key) {
+               /* scsi sense is Empty, the request was never issued to target
+                * linux return code might tell us what happened.
+                */
+               if (or->async_error == -ENOMEM)
+                       osi->osd_err_pri = OSD_ERR_PRI_RESOURCE;
+               else
+                       osi->osd_err_pri = OSD_ERR_PRI_UNREACHABLE;
+               ret = or->async_error;
+       } else if (osi->key <= scsi_sk_recovered_error) {
+               osi->osd_err_pri = 0;
+               ret = 0;
+       } else if (osi->additional_code == scsi_invalid_field_in_cdb) {
+               if (osi->cdb_field_offset == OSD_CFO_STARTING_BYTE) {
+                       osi->osd_err_pri = OSD_ERR_PRI_CLEAR_PAGES;
+                       ret = -EFAULT; /* caller should recover from this */
+               } else if (osi->cdb_field_offset == OSD_CFO_OBJECT_ID) {
+                       osi->osd_err_pri = OSD_ERR_PRI_NOT_FOUND;
+                       ret = -ENOENT;
+               } else if (osi->cdb_field_offset == OSD_CFO_PERMISSIONS) {
+                       osi->osd_err_pri = OSD_ERR_PRI_NO_ACCESS;
+                       ret = -EACCES;
+               } else {
+                       osi->osd_err_pri = OSD_ERR_PRI_BAD_CRED;
+                       ret = -EINVAL;
+               }
+       } else if (osi->additional_code == osd_quota_error) {
+               osi->osd_err_pri = OSD_ERR_PRI_NO_SPACE;
+               ret = -ENOSPC;
+       } else if (_is_osd_security_code(osi->additional_code)) {
+               osi->osd_err_pri = OSD_ERR_PRI_BAD_CRED;
+               ret = -EINVAL;
+       } else {
+               osi->osd_err_pri = OSD_ERR_PRI_EIO;
+               ret = -EIO;
+       }
+
+       if (!or->out.residual)
+               or->out.residual = or->out.total_bytes;
+       if (!or->in.residual)
+               or->in.residual = or->in.total_bytes;
+
+       return ret;
 }
 EXPORT_SYMBOL(osd_req_decode_sense_full);