tree-wide: fix assorted typos all over the place
[safe/jmp/linux-2.6] / drivers / s390 / cio / cmf.c
index 49def26..2985eb4 100644 (file)
@@ -1,11 +1,12 @@
 /*
- * linux/drivers/s390/cio/cmf.c ($Revision: 1.16 $)
+ * linux/drivers/s390/cio/cmf.c
  *
  * Linux on zSeries Channel Measurement Facility support
  *
- * Copyright 2000,2003 IBM Corporation
+ * Copyright 2000,2006 IBM Corporation
  *
- * Author: Arnd Bergmann <arndb@de.ibm.com>
+ * Authors: Arnd Bergmann <arndb@de.ibm.com>
+ *         Cornelia Huck <cornelia.huck@de.ibm.com>
  *
  * original idea from Natarajan Krishnaswami <nkrishna@us.ibm.com>
  *
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
+#define KMSG_COMPONENT "cio"
+#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
+
 #include <linux/bootmem.h>
 #include <linux/device.h>
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/slab.h>
+#include <linux/timex.h>       /* get_clock() */
 
 #include <asm/ccwdev.h>
 #include <asm/cio.h>
 #include <asm/cmb.h>
+#include <asm/div64.h>
 
 #include "cio.h"
 #include "css.h"
@@ -41,7 +48,8 @@
 #include "ioasm.h"
 #include "chsc.h"
 
-/* parameter to enable cmf during boot, possible uses are:
+/*
+ * parameter to enable cmf during boot, possible uses are:
  *  "s390cmf" -- enable cmf and allocate 2 MB of ram so measuring can be
  *               used on any subchannel
  *  "s390cmf=<num>" -- enable cmf and allocate enough memory to measure
@@ -69,18 +77,20 @@ enum cmb_index {
  * enum cmb_format - types of supported measurement block formats
  *
  * @CMF_BASIC:      traditional channel measurement blocks supported
- *                 by all machines that we run on
+ *                 by all machines that we run on
  * @CMF_EXTENDED:   improved format that was introduced with the z990
- *                 machine
- * @CMF_AUTODETECT: default: use extended format when running on a z990
- *                  or later machine, otherwise fall back to basic format
- **/
+ *                 machine
+ * @CMF_AUTODETECT: default: use extended format when running on a machine
+ *                 supporting extended format, otherwise fall back to
+ *                 basic format
+ */
 enum cmb_format {
        CMF_BASIC,
        CMF_EXTENDED,
        CMF_AUTODETECT = -1,
 };
-/**
+
+/*
  * format - actual format for all measurement blocks
  *
  * The format module parameter can be set to a value of 0 (zero)
@@ -93,33 +103,45 @@ module_param(format, bool, 0444);
 /**
  * struct cmb_operations - functions to use depending on cmb_format
  *
- * all these functions operate on a struct cmf_device. There is only
- * one instance of struct cmb_operations because all cmf_device
- * objects are guaranteed to be of the same type.
+ * Most of these functions operate on a struct ccw_device. There is only
+ * one instance of struct cmb_operations because the format of the measurement
+ * data is guaranteed to be the same for every ccw_device.
  *
  * @alloc:     allocate memory for a channel measurement block,
  *             either with the help of a special pool or with kmalloc
  * @free:      free memory allocated with @alloc
  * @set:       enable or disable measurement
+ * @read:      read a measurement entry at an index
  * @readall:   read a measurement block in a common format
  * @reset:     clear the data in the associated measurement block and
  *             reset its time stamp
+ * @align:     align an allocated block so that the hardware can use it
  */
 struct cmb_operations {
-       int (*alloc)  (struct ccw_device*);
-       void(*free)   (struct ccw_device*);
-       int (*set)    (struct ccw_device*, u32);
-       u64 (*read)   (struct ccw_device*, int);
-       int (*readall)(struct ccw_device*, struct cmbdata *);
-       void (*reset) (struct ccw_device*);
-
+       int  (*alloc)  (struct ccw_device *);
+       void (*free)   (struct ccw_device *);
+       int  (*set)    (struct ccw_device *, u32);
+       u64  (*read)   (struct ccw_device *, int);
+       int  (*readall)(struct ccw_device *, struct cmbdata *);
+       void (*reset)  (struct ccw_device *);
+       void *(*align) (void *);
+/* private: */
        struct attribute_group *attr_group;
 };
 static struct cmb_operations *cmbops;
 
-/* our user interface is designed in terms of nanoseconds,
+struct cmb_data {
+       void *hw_block;   /* Pointer to block updated by hardware */
+       void *last_block; /* Last changed block copied from hardware block */
+       int size;         /* Size of hw_block and last_block */
+       unsigned long long last_update;  /* when last_block was updated */
+};
+
+/*
+ * Our user interface is designed in terms of nanoseconds,
  * while the hardware measures total times in its own
- * unit.*/
+ * unit.
+ */
 static inline u64 time_to_nsec(u32 value)
 {
        return ((u64)value) * 128000ull;
@@ -139,19 +161,20 @@ static inline u64 time_to_avg_nsec(u32 value, u32 count)
        if (count == 0)
                return 0;
 
-       /* value comes in units of 128 µsec */
+       /* value comes in units of 128 Âµsec */
        ret = time_to_nsec(value);
        do_div(ret, count);
 
        return ret;
 }
 
-/* activate or deactivate the channel monitor. When area is NULL,
+/*
+ * Activate or deactivate the channel monitor. When area is NULL,
  * the monitor is deactivated. The channel monitor needs to
  * be active in order to measure subchannels, which also need
- * to be enabled. */
-static inline void
-cmf_activate(void *area, unsigned int onoff)
+ * to be enabled.
+ */
+static inline void cmf_activate(void *area, unsigned int onoff)
 {
        register void * __gpr2 asm("2");
        register long __gpr1 asm("1");
@@ -162,59 +185,22 @@ cmf_activate(void *area, unsigned int onoff)
        asm("schm" : : "d" (__gpr2), "d" (__gpr1) );
 }
 
-static int
-set_schib(struct ccw_device *cdev, u32 mme, int mbfc, unsigned long address)
+static int set_schib(struct ccw_device *cdev, u32 mme, int mbfc,
+                    unsigned long address)
 {
-       int ret;
-       int retry;
        struct subchannel *sch;
-       struct schib *schib;
 
        sch = to_subchannel(cdev->dev.parent);
-       schib = &sch->schib;
-       /* msch can silently fail, so do it again if necessary */
-       for (retry = 0; retry < 3; retry++) {
-               /* prepare schib */
-               stsch(sch->irq, schib);
-               schib->pmcw.mme  = mme;
-               schib->pmcw.mbfc = mbfc;
-               /* address can be either a block address or a block index */
-               if (mbfc)
-                       schib->mba = address;
-               else
-                       schib->pmcw.mbi = address;
-
-               /* try to submit it */
-               switch(ret = msch_err(sch->irq, schib)) {
-                       case 0:
-                               break;
-                       case 1:
-                       case 2: /* in I/O or status pending */
-                               ret = -EBUSY;
-                               break;
-                       case 3: /* subchannel is no longer valid */
-                               ret = -ENODEV;
-                               break;
-                       default: /* msch caught an exception */
-                               ret = -EINVAL;
-                               break;
-               }
-               stsch(sch->irq, schib); /* restore the schib */
-
-               if (ret)
-                       break;
 
-               /* check if it worked */
-               if (schib->pmcw.mme  == mme &&
-                   schib->pmcw.mbfc == mbfc &&
-                   (mbfc ? (schib->mba == address)
-                         : (schib->pmcw.mbi == address)))
-                       return 0;
-
-               ret = -EINVAL;
-       }
+       sch->config.mme = mme;
+       sch->config.mbfc = mbfc;
+       /* address can be either a block address or a block index */
+       if (mbfc)
+               sch->config.mba = address;
+       else
+               sch->config.mbi = address;
 
-       return ret;
+       return cio_commit_config(sch);
 }
 
 struct set_schib_struct {
@@ -223,63 +209,229 @@ struct set_schib_struct {
        unsigned long address;
        wait_queue_head_t wait;
        int ret;
+       struct kref kref;
 };
 
+static void cmf_set_schib_release(struct kref *kref)
+{
+       struct set_schib_struct *set_data;
+
+       set_data = container_of(kref, struct set_schib_struct, kref);
+       kfree(set_data);
+}
+
+#define CMF_PENDING 1
+
 static int set_schib_wait(struct ccw_device *cdev, u32 mme,
                                int mbfc, unsigned long address)
 {
-       struct set_schib_struct s = {
-               .mme = mme,
-               .mbfc = mbfc,
-               .address = address,
-               .wait = __WAIT_QUEUE_HEAD_INITIALIZER(s.wait),
-       };
+       struct set_schib_struct *set_data;
+       int ret;
 
        spin_lock_irq(cdev->ccwlock);
-       s.ret = set_schib(cdev, mme, mbfc, address);
-       if (s.ret != -EBUSY) {
-               goto out_nowait;
+       if (!cdev->private->cmb) {
+               ret = -ENODEV;
+               goto out;
+       }
+       set_data = kzalloc(sizeof(struct set_schib_struct), GFP_ATOMIC);
+       if (!set_data) {
+               ret = -ENOMEM;
+               goto out;
        }
+       init_waitqueue_head(&set_data->wait);
+       kref_init(&set_data->kref);
+       set_data->mme = mme;
+       set_data->mbfc = mbfc;
+       set_data->address = address;
+
+       ret = set_schib(cdev, mme, mbfc, address);
+       if (ret != -EBUSY)
+               goto out_put;
 
        if (cdev->private->state != DEV_STATE_ONLINE) {
-               s.ret = -EBUSY;
                /* if the device is not online, don't even try again */
-               goto out_nowait;
+               ret = -EBUSY;
+               goto out_put;
        }
+
        cdev->private->state = DEV_STATE_CMFCHANGE;
-       cdev->private->cmb_wait = &s;
-       s.ret = 1;
+       set_data->ret = CMF_PENDING;
+       cdev->private->cmb_wait = set_data;
 
        spin_unlock_irq(cdev->ccwlock);
-       if (wait_event_interruptible(s.wait, s.ret != 1)) {
+       if (wait_event_interruptible(set_data->wait,
+                                    set_data->ret != CMF_PENDING)) {
                spin_lock_irq(cdev->ccwlock);
-               if (s.ret == 1) {
-                       s.ret = -ERESTARTSYS;
-                       cdev->private->cmb_wait = 0;
+               if (set_data->ret == CMF_PENDING) {
+                       set_data->ret = -ERESTARTSYS;
                        if (cdev->private->state == DEV_STATE_CMFCHANGE)
                                cdev->private->state = DEV_STATE_ONLINE;
                }
                spin_unlock_irq(cdev->ccwlock);
        }
-       return s.ret;
-
-out_nowait:
+       spin_lock_irq(cdev->ccwlock);
+       cdev->private->cmb_wait = NULL;
+       ret = set_data->ret;
+out_put:
+       kref_put(&set_data->kref, cmf_set_schib_release);
+out:
        spin_unlock_irq(cdev->ccwlock);
-       return s.ret;
+       return ret;
 }
 
 void retry_set_schib(struct ccw_device *cdev)
 {
-       struct set_schib_struct *s;
+       struct set_schib_struct *set_data;
 
-       s = cdev->private->cmb_wait;
-       cdev->private->cmb_wait = 0;
-       if (!s) {
+       set_data = cdev->private->cmb_wait;
+       if (!set_data) {
                WARN_ON(1);
                return;
        }
-       s->ret = set_schib(cdev, s->mme, s->mbfc, s->address);
-       wake_up(&s->wait);
+       kref_get(&set_data->kref);
+       set_data->ret = set_schib(cdev, set_data->mme, set_data->mbfc,
+                                 set_data->address);
+       wake_up(&set_data->wait);
+       kref_put(&set_data->kref, cmf_set_schib_release);
+}
+
+static int cmf_copy_block(struct ccw_device *cdev)
+{
+       struct subchannel *sch;
+       void *reference_buf;
+       void *hw_block;
+       struct cmb_data *cmb_data;
+
+       sch = to_subchannel(cdev->dev.parent);
+
+       if (cio_update_schib(sch))
+               return -ENODEV;
+
+       if (scsw_fctl(&sch->schib.scsw) & SCSW_FCTL_START_FUNC) {
+               /* Don't copy if a start function is in progress. */
+               if ((!(scsw_actl(&sch->schib.scsw) & SCSW_ACTL_SUSPENDED)) &&
+                   (scsw_actl(&sch->schib.scsw) &
+                    (SCSW_ACTL_DEVACT | SCSW_ACTL_SCHACT)) &&
+                   (!(scsw_stctl(&sch->schib.scsw) & SCSW_STCTL_SEC_STATUS)))
+                       return -EBUSY;
+       }
+       cmb_data = cdev->private->cmb;
+       hw_block = cmbops->align(cmb_data->hw_block);
+       if (!memcmp(cmb_data->last_block, hw_block, cmb_data->size))
+               /* No need to copy. */
+               return 0;
+       reference_buf = kzalloc(cmb_data->size, GFP_ATOMIC);
+       if (!reference_buf)
+               return -ENOMEM;
+       /* Ensure consistency of block copied from hardware. */
+       do {
+               memcpy(cmb_data->last_block, hw_block, cmb_data->size);
+               memcpy(reference_buf, hw_block, cmb_data->size);
+       } while (memcmp(cmb_data->last_block, reference_buf, cmb_data->size));
+       cmb_data->last_update = get_clock();
+       kfree(reference_buf);
+       return 0;
+}
+
+struct copy_block_struct {
+       wait_queue_head_t wait;
+       int ret;
+       struct kref kref;
+};
+
+static void cmf_copy_block_release(struct kref *kref)
+{
+       struct copy_block_struct *copy_block;
+
+       copy_block = container_of(kref, struct copy_block_struct, kref);
+       kfree(copy_block);
+}
+
+static int cmf_cmb_copy_wait(struct ccw_device *cdev)
+{
+       struct copy_block_struct *copy_block;
+       int ret;
+       unsigned long flags;
+
+       spin_lock_irqsave(cdev->ccwlock, flags);
+       if (!cdev->private->cmb) {
+               ret = -ENODEV;
+               goto out;
+       }
+       copy_block = kzalloc(sizeof(struct copy_block_struct), GFP_ATOMIC);
+       if (!copy_block) {
+               ret = -ENOMEM;
+               goto out;
+       }
+       init_waitqueue_head(&copy_block->wait);
+       kref_init(&copy_block->kref);
+
+       ret = cmf_copy_block(cdev);
+       if (ret != -EBUSY)
+               goto out_put;
+
+       if (cdev->private->state != DEV_STATE_ONLINE) {
+               ret = -EBUSY;
+               goto out_put;
+       }
+
+       cdev->private->state = DEV_STATE_CMFUPDATE;
+       copy_block->ret = CMF_PENDING;
+       cdev->private->cmb_wait = copy_block;
+
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       if (wait_event_interruptible(copy_block->wait,
+                                    copy_block->ret != CMF_PENDING)) {
+               spin_lock_irqsave(cdev->ccwlock, flags);
+               if (copy_block->ret == CMF_PENDING) {
+                       copy_block->ret = -ERESTARTSYS;
+                       if (cdev->private->state == DEV_STATE_CMFUPDATE)
+                               cdev->private->state = DEV_STATE_ONLINE;
+               }
+               spin_unlock_irqrestore(cdev->ccwlock, flags);
+       }
+       spin_lock_irqsave(cdev->ccwlock, flags);
+       cdev->private->cmb_wait = NULL;
+       ret = copy_block->ret;
+out_put:
+       kref_put(&copy_block->kref, cmf_copy_block_release);
+out:
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       return ret;
+}
+
+void cmf_retry_copy_block(struct ccw_device *cdev)
+{
+       struct copy_block_struct *copy_block;
+
+       copy_block = cdev->private->cmb_wait;
+       if (!copy_block) {
+               WARN_ON(1);
+               return;
+       }
+       kref_get(&copy_block->kref);
+       copy_block->ret = cmf_copy_block(cdev);
+       wake_up(&copy_block->wait);
+       kref_put(&copy_block->kref, cmf_copy_block_release);
+}
+
+static void cmf_generic_reset(struct ccw_device *cdev)
+{
+       struct cmb_data *cmb_data;
+
+       spin_lock_irq(cdev->ccwlock);
+       cmb_data = cdev->private->cmb;
+       if (cmb_data) {
+               memset(cmb_data->last_block, 0, cmb_data->size);
+               /*
+                * Need to reset hw block as well to make the hardware start
+                * from 0 again.
+                */
+               memset(cmbops->align(cmb_data->hw_block), 0, cmb_data->size);
+               cmb_data->last_update = 0;
+       }
+       cdev->private->cmb_start_time = get_clock();
+       spin_unlock_irq(cdev->ccwlock);
 }
 
 /**
@@ -287,6 +439,7 @@ void retry_set_schib(struct ccw_device *cdev)
  *
  * @mem:       pointer to CMBs (only in basic measurement mode)
  * @list:      contains a linked list of all subchannels
+ * @num_channels: number of channels to be measured
  * @lock:      protect concurrent access to @mem and @list
  */
 struct cmb_area {
@@ -297,33 +450,41 @@ struct cmb_area {
 };
 
 static struct cmb_area cmb_area = {
-       .lock = SPIN_LOCK_UNLOCKED,
+       .lock = __SPIN_LOCK_UNLOCKED(cmb_area.lock),
        .list = LIST_HEAD_INIT(cmb_area.list),
        .num_channels  = 1024,
 };
 
-\f
 /* ****** old style CMB handling ********/
 
-/** int maxchannels
- *
+/*
  * Basic channel measurement blocks are allocated in one contiguous
  * block of memory, which can not be moved as long as any channel
  * is active. Therefore, a maximum number of subchannels needs to
  * be defined somewhere. This is a module parameter, defaulting to
- * a resonable value of 1024, or 32 kb of memory.
+ * a reasonable value of 1024, or 32 kb of memory.
  * Current kernels don't allow kmalloc with more than 128kb, so the
- * maximum is 4096
+ * maximum is 4096.
  */
 
 module_param_named(maxchannels, cmb_area.num_channels, uint, 0444);
 
 /**
  * struct cmb - basic channel measurement block
+ * @ssch_rsch_count: number of ssch and rsch
+ * @sample_count: number of samples
+ * @device_connect_time: time of device connect
+ * @function_pending_time: time of function pending
+ * @device_disconnect_time: time of device disconnect
+ * @control_unit_queuing_time: time of control unit queuing
+ * @device_active_only_time: time of device active only
+ * @reserved: unused in basic measurement mode
+ *
+ * The measurement block as used by the hardware. The fields are described
+ * further in z/Architecture Principles of Operation, chapter 17.
  *
- * cmb as used by the hardware the fields are described in z/Architecture
- * Principles of Operation, chapter 17.
- * The area to be a contiguous array and may not be reallocated or freed.
+ * The cmb area made up from these blocks must be a contiguous array and may
+ * not be reallocated or freed.
  * Only one cmb area can be present in the system.
  */
 struct cmb {
@@ -337,11 +498,12 @@ struct cmb {
        u32 reserved[2];
 };
 
-/* insert a single device into the cmb_area list
- * called with cmb_area.lock held from alloc_cmb
+/*
+ * Insert a single device into the cmb_area list.
+ * Called with cmb_area.lock held from alloc_cmb.
  */
-static inline int
-alloc_cmb_single (struct ccw_device *cdev)
+static int alloc_cmb_single(struct ccw_device *cdev,
+                           struct cmb_data *cmb_data)
 {
        struct cmb *cmb;
        struct ccw_device_private *node;
@@ -353,12 +515,16 @@ alloc_cmb_single (struct ccw_device *cdev)
                goto out;
        }
 
-       /* find first unused cmb in cmb_area.mem.
-        * this is a little tricky: cmb_area.list
-        * remains sorted by ->cmb pointers */
+       /*
+        * Find first unused cmb in cmb_area.mem.
+        * This is a little tricky: cmb_area.list
+        * remains sorted by ->cmb->hw_data pointers.
+        */
        cmb = cmb_area.mem;
        list_for_each_entry(node, &cmb_area.list, cmb_list) {
-               if ((struct cmb*)node->cmb > cmb)
+               struct cmb_data *data;
+               data = node->cmb;
+               if ((struct cmb*)data->hw_block > cmb)
                        break;
                cmb++;
        }
@@ -369,20 +535,32 @@ alloc_cmb_single (struct ccw_device *cdev)
 
        /* insert new cmb */
        list_add_tail(&cdev->private->cmb_list, &node->cmb_list);
-       cdev->private->cmb = cmb;
+       cmb_data->hw_block = cmb;
+       cdev->private->cmb = cmb_data;
        ret = 0;
 out:
        spin_unlock_irq(cdev->ccwlock);
        return ret;
 }
 
-static int
-alloc_cmb (struct ccw_device *cdev)
+static int alloc_cmb(struct ccw_device *cdev)
 {
        int ret;
        struct cmb *mem;
        ssize_t size;
+       struct cmb_data *cmb_data;
 
+       /* Allocate private cmb_data. */
+       cmb_data = kzalloc(sizeof(struct cmb_data), GFP_KERNEL);
+       if (!cmb_data)
+               return -ENOMEM;
+
+       cmb_data->last_block = kzalloc(sizeof(struct cmb), GFP_KERNEL);
+       if (!cmb_data->last_block) {
+               kfree(cmb_data);
+               return -ENOMEM;
+       }
+       cmb_data->size = sizeof(struct cmb);
        spin_lock(&cmb_area.lock);
 
        if (!cmb_area.mem) {
@@ -411,29 +589,36 @@ alloc_cmb (struct ccw_device *cdev)
        }
 
        /* do the actual allocation */
-       ret = alloc_cmb_single(cdev);
+       ret = alloc_cmb_single(cdev, cmb_data);
 out:
        spin_unlock(&cmb_area.lock);
-
+       if (ret) {
+               kfree(cmb_data->last_block);
+               kfree(cmb_data);
+       }
        return ret;
 }
 
-static void
-free_cmb(struct ccw_device *cdev)
+static void free_cmb(struct ccw_device *cdev)
 {
        struct ccw_device_private *priv;
-
-       priv = cdev->private;
+       struct cmb_data *cmb_data;
 
        spin_lock(&cmb_area.lock);
        spin_lock_irq(cdev->ccwlock);
 
+       priv = cdev->private;
+
        if (list_empty(&priv->cmb_list)) {
                /* already freed */
                goto out;
        }
 
+       cmb_data = priv->cmb;
        priv->cmb = NULL;
+       if (cmb_data)
+               kfree(cmb_data->last_block);
+       kfree(cmb_data);
        list_del_init(&priv->cmb_list);
 
        if (list_empty(&cmb_area.list)) {
@@ -448,83 +633,97 @@ out:
        spin_unlock(&cmb_area.lock);
 }
 
-static int
-set_cmb(struct ccw_device *cdev, u32 mme)
+static int set_cmb(struct ccw_device *cdev, u32 mme)
 {
        u16 offset;
+       struct cmb_data *cmb_data;
+       unsigned long flags;
 
-       if (!cdev->private->cmb)
+       spin_lock_irqsave(cdev->ccwlock, flags);
+       if (!cdev->private->cmb) {
+               spin_unlock_irqrestore(cdev->ccwlock, flags);
                return -EINVAL;
-
-       offset = mme ? (struct cmb *)cdev->private->cmb - cmb_area.mem : 0;
+       }
+       cmb_data = cdev->private->cmb;
+       offset = mme ? (struct cmb *)cmb_data->hw_block - cmb_area.mem : 0;
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
 
        return set_schib_wait(cdev, mme, 0, offset);
 }
 
-static u64
-read_cmb (struct ccw_device *cdev, int index)
+static u64 read_cmb(struct ccw_device *cdev, int index)
 {
-       /* yes, we have to put it on the stack
-        * because the cmb must only be accessed
-        * atomically, e.g. with mvc */
-       struct cmb cmb;
-       unsigned long flags;
+       struct cmb *cmb;
        u32 val;
+       int ret;
+       unsigned long flags;
+
+       ret = cmf_cmb_copy_wait(cdev);
+       if (ret < 0)
+               return 0;
 
        spin_lock_irqsave(cdev->ccwlock, flags);
        if (!cdev->private->cmb) {
-               spin_unlock_irqrestore(cdev->ccwlock, flags);
-               return 0;
+               ret = 0;
+               goto out;
        }
-
-       cmb = *(struct cmb*)cdev->private->cmb;
-       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       cmb = ((struct cmb_data *)cdev->private->cmb)->last_block;
 
        switch (index) {
        case cmb_ssch_rsch_count:
-               return cmb.ssch_rsch_count;
+               ret = cmb->ssch_rsch_count;
+               goto out;
        case cmb_sample_count:
-               return cmb.sample_count;
+               ret = cmb->sample_count;
+               goto out;
        case cmb_device_connect_time:
-               val = cmb.device_connect_time;
+               val = cmb->device_connect_time;
                break;
        case cmb_function_pending_time:
-               val = cmb.function_pending_time;
+               val = cmb->function_pending_time;
                break;
        case cmb_device_disconnect_time:
-               val = cmb.device_disconnect_time;
+               val = cmb->device_disconnect_time;
                break;
        case cmb_control_unit_queuing_time:
-               val = cmb.control_unit_queuing_time;
+               val = cmb->control_unit_queuing_time;
                break;
        case cmb_device_active_only_time:
-               val = cmb.device_active_only_time;
+               val = cmb->device_active_only_time;
                break;
        default:
-               return 0;
+               ret = 0;
+               goto out;
        }
-       return time_to_avg_nsec(val, cmb.sample_count);
+       ret = time_to_avg_nsec(val, cmb->sample_count);
+out:
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       return ret;
 }
 
-static int
-readall_cmb (struct ccw_device *cdev, struct cmbdata *data)
+static int readall_cmb(struct ccw_device *cdev, struct cmbdata *data)
 {
-       /* yes, we have to put it on the stack
-        * because the cmb must only be accessed
-        * atomically, e.g. with mvc */
-       struct cmb cmb;
-       unsigned long flags;
+       struct cmb *cmb;
+       struct cmb_data *cmb_data;
        u64 time;
+       unsigned long flags;
+       int ret;
 
+       ret = cmf_cmb_copy_wait(cdev);
+       if (ret < 0)
+               return ret;
        spin_lock_irqsave(cdev->ccwlock, flags);
-       if (!cdev->private->cmb) {
-               spin_unlock_irqrestore(cdev->ccwlock, flags);
-               return -ENODEV;
+       cmb_data = cdev->private->cmb;
+       if (!cmb_data) {
+               ret = -ENODEV;
+               goto out;
        }
-
-       cmb = *(struct cmb*)cdev->private->cmb;
-       time = get_clock() - cdev->private->cmb_start_time;
-       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       if (cmb_data->last_update == 0) {
+               ret = -EAGAIN;
+               goto out;
+       }
+       cmb = cmb_data->last_block;
+       time = cmb_data->last_update - cdev->private->cmb_start_time;
 
        memset(data, 0, sizeof(struct cmbdata));
 
@@ -535,31 +734,32 @@ readall_cmb (struct ccw_device *cdev, struct cmbdata *data)
        data->elapsed_time = (time * 1000) >> 12;
 
        /* copy data to new structure */
-       data->ssch_rsch_count = cmb.ssch_rsch_count;
-       data->sample_count = cmb.sample_count;
+       data->ssch_rsch_count = cmb->ssch_rsch_count;
+       data->sample_count = cmb->sample_count;
 
        /* time fields are converted to nanoseconds while copying */
-       data->device_connect_time = time_to_nsec(cmb.device_connect_time);
-       data->function_pending_time = time_to_nsec(cmb.function_pending_time);
-       data->device_disconnect_time = time_to_nsec(cmb.device_disconnect_time);
+       data->device_connect_time = time_to_nsec(cmb->device_connect_time);
+       data->function_pending_time = time_to_nsec(cmb->function_pending_time);
+       data->device_disconnect_time =
+               time_to_nsec(cmb->device_disconnect_time);
        data->control_unit_queuing_time
-               = time_to_nsec(cmb.control_unit_queuing_time);
+               = time_to_nsec(cmb->control_unit_queuing_time);
        data->device_active_only_time
-               = time_to_nsec(cmb.device_active_only_time);
+               = time_to_nsec(cmb->device_active_only_time);
+       ret = 0;
+out:
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       return ret;
+}
 
-       return 0;
+static void reset_cmb(struct ccw_device *cdev)
+{
+       cmf_generic_reset(cdev);
 }
 
-static void
-reset_cmb(struct ccw_device *cdev)
+static void * align_cmb(void *area)
 {
-       struct cmb *cmb;
-       spin_lock_irq(cdev->ccwlock);
-       cmb = cdev->private->cmb;
-       if (cmb)
-               memset (cmb, 0, sizeof (*cmb));
-       cdev->private->cmb_start_time = get_clock();
-       spin_unlock_irq(cdev->ccwlock);
+       return area;
 }
 
 static struct attribute_group cmf_attr_group;
@@ -571,16 +771,28 @@ static struct cmb_operations cmbops_basic = {
        .read   = read_cmb,
        .readall    = readall_cmb,
        .reset      = reset_cmb,
+       .align      = align_cmb,
        .attr_group = &cmf_attr_group,
 };
-\f
+
 /* ******** extended cmb handling ********/
 
 /**
  * struct cmbe - extended channel measurement block
+ * @ssch_rsch_count: number of ssch and rsch
+ * @sample_count: number of samples
+ * @device_connect_time: time of device connect
+ * @function_pending_time: time of function pending
+ * @device_disconnect_time: time of device disconnect
+ * @control_unit_queuing_time: time of control unit queuing
+ * @device_active_only_time: time of device active only
+ * @device_busy_time: time of device busy
+ * @initial_command_response_time: initial command response time
+ * @reserved: unused
  *
- * cmb as used by the hardware, may be in any 64 bit physical location,
- * the fields are described in z/Architecture Principles of Operation,
+ * The measurement block as used by the hardware. May be in any 64 bit physical
+ * location.
+ * The fields are described further in z/Architecture Principles of Operation,
  * third edition, chapter 17.
  */
 struct cmbe {
@@ -596,10 +808,12 @@ struct cmbe {
        u32 reserved[7];
 };
 
-/* kmalloc only guarantees 8 byte alignment, but we need cmbe
+/*
+ * kmalloc only guarantees 8 byte alignment, but we need cmbe
  * pointers to be naturally aligned. Make sure to allocate
- * enough space for two cmbes */
-static inline struct cmbe* cmbe_align(struct cmbe *c)
+ * enough space for two cmbes.
+ */
+static inline struct cmbe *cmbe_align(struct cmbe *c)
 {
        unsigned long addr;
        addr = ((unsigned long)c + sizeof (struct cmbe) - sizeof(long)) &
@@ -607,22 +821,34 @@ static inline struct cmbe* cmbe_align(struct cmbe *c)
        return (struct cmbe*)addr;
 }
 
-static int
-alloc_cmbe (struct ccw_device *cdev)
+static int alloc_cmbe(struct ccw_device *cdev)
 {
        struct cmbe *cmbe;
-       cmbe = kmalloc (sizeof (*cmbe) * 2, GFP_KERNEL);
+       struct cmb_data *cmb_data;
+       int ret;
+
+       cmbe = kzalloc (sizeof (*cmbe) * 2, GFP_KERNEL);
        if (!cmbe)
                return -ENOMEM;
-
+       cmb_data = kzalloc(sizeof(struct cmb_data), GFP_KERNEL);
+       if (!cmb_data) {
+               ret = -ENOMEM;
+               goto out_free;
+       }
+       cmb_data->last_block = kzalloc(sizeof(struct cmbe), GFP_KERNEL);
+       if (!cmb_data->last_block) {
+               ret = -ENOMEM;
+               goto out_free;
+       }
+       cmb_data->size = sizeof(struct cmbe);
        spin_lock_irq(cdev->ccwlock);
        if (cdev->private->cmb) {
-               kfree(cmbe);
                spin_unlock_irq(cdev->ccwlock);
-               return -EBUSY;
+               ret = -EBUSY;
+               goto out_free;
        }
-
-       cdev->private->cmb = cmbe;
+       cmb_data->hw_block = cmbe;
+       cdev->private->cmb = cmb_data;
        spin_unlock_irq(cdev->ccwlock);
 
        /* activate global measurement if this is the first channel */
@@ -633,15 +859,24 @@ alloc_cmbe (struct ccw_device *cdev)
        spin_unlock(&cmb_area.lock);
 
        return 0;
+out_free:
+       if (cmb_data)
+               kfree(cmb_data->last_block);
+       kfree(cmb_data);
+       kfree(cmbe);
+       return ret;
 }
 
-static void
-free_cmbe (struct ccw_device *cdev)
+static void free_cmbe(struct ccw_device *cdev)
 {
+       struct cmb_data *cmb_data;
+
        spin_lock_irq(cdev->ccwlock);
-       if (cdev->private->cmb)
-               kfree(cdev->private->cmb);
+       cmb_data = cdev->private->cmb;
        cdev->private->cmb = NULL;
+       if (cmb_data)
+               kfree(cmb_data->last_block);
+       kfree(cmb_data);
        spin_unlock_irq(cdev->ccwlock);
 
        /* deactivate global measurement if this is the last channel */
@@ -652,89 +887,105 @@ free_cmbe (struct ccw_device *cdev)
        spin_unlock(&cmb_area.lock);
 }
 
-static int
-set_cmbe(struct ccw_device *cdev, u32 mme)
+static int set_cmbe(struct ccw_device *cdev, u32 mme)
 {
        unsigned long mba;
+       struct cmb_data *cmb_data;
+       unsigned long flags;
 
-       if (!cdev->private->cmb)
+       spin_lock_irqsave(cdev->ccwlock, flags);
+       if (!cdev->private->cmb) {
+               spin_unlock_irqrestore(cdev->ccwlock, flags);
                return -EINVAL;
-       mba = mme ? (unsigned long) cmbe_align(cdev->private->cmb) : 0;
+       }
+       cmb_data = cdev->private->cmb;
+       mba = mme ? (unsigned long) cmbe_align(cmb_data->hw_block) : 0;
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
 
        return set_schib_wait(cdev, mme, 1, mba);
 }
 
 
-u64
-read_cmbe (struct ccw_device *cdev, int index)
+static u64 read_cmbe(struct ccw_device *cdev, int index)
 {
-       /* yes, we have to put it on the stack
-        * because the cmb must only be accessed
-        * atomically, e.g. with mvc */
-       struct cmbe cmb;
-       unsigned long flags;
+       struct cmbe *cmb;
+       struct cmb_data *cmb_data;
        u32 val;
+       int ret;
+       unsigned long flags;
 
-       spin_lock_irqsave(cdev->ccwlock, flags);
-       if (!cdev->private->cmb) {
-               spin_unlock_irqrestore(cdev->ccwlock, flags);
+       ret = cmf_cmb_copy_wait(cdev);
+       if (ret < 0)
                return 0;
-       }
 
-       cmb = *cmbe_align(cdev->private->cmb);
-       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       spin_lock_irqsave(cdev->ccwlock, flags);
+       cmb_data = cdev->private->cmb;
+       if (!cmb_data) {
+               ret = 0;
+               goto out;
+       }
+       cmb = cmb_data->last_block;
 
        switch (index) {
        case cmb_ssch_rsch_count:
-               return cmb.ssch_rsch_count;
+               ret = cmb->ssch_rsch_count;
+               goto out;
        case cmb_sample_count:
-               return cmb.sample_count;
+               ret = cmb->sample_count;
+               goto out;
        case cmb_device_connect_time:
-               val = cmb.device_connect_time;
+               val = cmb->device_connect_time;
                break;
        case cmb_function_pending_time:
-               val = cmb.function_pending_time;
+               val = cmb->function_pending_time;
                break;
        case cmb_device_disconnect_time:
-               val = cmb.device_disconnect_time;
+               val = cmb->device_disconnect_time;
                break;
        case cmb_control_unit_queuing_time:
-               val = cmb.control_unit_queuing_time;
+               val = cmb->control_unit_queuing_time;
                break;
        case cmb_device_active_only_time:
-               val = cmb.device_active_only_time;
+               val = cmb->device_active_only_time;
                break;
        case cmb_device_busy_time:
-               val = cmb.device_busy_time;
+               val = cmb->device_busy_time;
                break;
        case cmb_initial_command_response_time:
-               val = cmb.initial_command_response_time;
+               val = cmb->initial_command_response_time;
                break;
        default:
-               return 0;
+               ret = 0;
+               goto out;
        }
-       return time_to_avg_nsec(val, cmb.sample_count);
+       ret = time_to_avg_nsec(val, cmb->sample_count);
+out:
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       return ret;
 }
 
-static int
-readall_cmbe (struct ccw_device *cdev, struct cmbdata *data)
+static int readall_cmbe(struct ccw_device *cdev, struct cmbdata *data)
 {
-       /* yes, we have to put it on the stack
-        * because the cmb must only be accessed
-        * atomically, e.g. with mvc */
-       struct cmbe cmb;
-       unsigned long flags;
+       struct cmbe *cmb;
+       struct cmb_data *cmb_data;
        u64 time;
+       unsigned long flags;
+       int ret;
 
+       ret = cmf_cmb_copy_wait(cdev);
+       if (ret < 0)
+               return ret;
        spin_lock_irqsave(cdev->ccwlock, flags);
-       if (!cdev->private->cmb) {
-               spin_unlock_irqrestore(cdev->ccwlock, flags);
-               return -ENODEV;
+       cmb_data = cdev->private->cmb;
+       if (!cmb_data) {
+               ret = -ENODEV;
+               goto out;
        }
-
-       cmb = *cmbe_align(cdev->private->cmb);
-       time = get_clock() - cdev->private->cmb_start_time;
-       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       if (cmb_data->last_update == 0) {
+               ret = -EAGAIN;
+               goto out;
+       }
+       time = cmb_data->last_update - cdev->private->cmb_start_time;
 
        memset (data, 0, sizeof(struct cmbdata));
 
@@ -744,35 +995,38 @@ readall_cmbe (struct ccw_device *cdev, struct cmbdata *data)
        /* conver to nanoseconds */
        data->elapsed_time = (time * 1000) >> 12;
 
+       cmb = cmb_data->last_block;
        /* copy data to new structure */
-       data->ssch_rsch_count = cmb.ssch_rsch_count;
-       data->sample_count = cmb.sample_count;
+       data->ssch_rsch_count = cmb->ssch_rsch_count;
+       data->sample_count = cmb->sample_count;
 
        /* time fields are converted to nanoseconds while copying */
-       data->device_connect_time = time_to_nsec(cmb.device_connect_time);
-       data->function_pending_time = time_to_nsec(cmb.function_pending_time);
-       data->device_disconnect_time = time_to_nsec(cmb.device_disconnect_time);
+       data->device_connect_time = time_to_nsec(cmb->device_connect_time);
+       data->function_pending_time = time_to_nsec(cmb->function_pending_time);
+       data->device_disconnect_time =
+               time_to_nsec(cmb->device_disconnect_time);
        data->control_unit_queuing_time
-               = time_to_nsec(cmb.control_unit_queuing_time);
+               = time_to_nsec(cmb->control_unit_queuing_time);
        data->device_active_only_time
-               = time_to_nsec(cmb.device_active_only_time);
-       data->device_busy_time = time_to_nsec(cmb.device_busy_time);
+               = time_to_nsec(cmb->device_active_only_time);
+       data->device_busy_time = time_to_nsec(cmb->device_busy_time);
        data->initial_command_response_time
-               = time_to_nsec(cmb.initial_command_response_time);
+               = time_to_nsec(cmb->initial_command_response_time);
 
-       return 0;
+       ret = 0;
+out:
+       spin_unlock_irqrestore(cdev->ccwlock, flags);
+       return ret;
 }
 
-static void
-reset_cmbe(struct ccw_device *cdev)
+static void reset_cmbe(struct ccw_device *cdev)
 {
-       struct cmbe *cmb;
-       spin_lock_irq(cdev->ccwlock);
-       cmb = cmbe_align(cdev->private->cmb);
-       if (cmb)
-               memset (cmb, 0, sizeof (*cmb));
-       cdev->private->cmb_start_time = get_clock();
-       spin_unlock_irq(cdev->ccwlock);
+       cmf_generic_reset(cdev);
+}
+
+static void * align_cmbe(void *area)
+{
+       return cmbe_align(area);
 }
 
 static struct attribute_group cmf_attr_group_ext;
@@ -784,36 +1038,43 @@ static struct cmb_operations cmbops_extended = {
        .read       = read_cmbe,
        .readall    = readall_cmbe,
        .reset      = reset_cmbe,
+       .align      = align_cmbe,
        .attr_group = &cmf_attr_group_ext,
 };
-\f
 
-static ssize_t
-cmb_show_attr(struct device *dev, char *buf, enum cmb_index idx)
+static ssize_t cmb_show_attr(struct device *dev, char *buf, enum cmb_index idx)
 {
        return sprintf(buf, "%lld\n",
                (unsigned long long) cmf_read(to_ccwdev(dev), idx));
 }
 
-static ssize_t
-cmb_show_avg_sample_interval(struct device *dev, char *buf)
+static ssize_t cmb_show_avg_sample_interval(struct device *dev,
+                                           struct device_attribute *attr,
+                                           char *buf)
 {
        struct ccw_device *cdev;
        long interval;
        unsigned long count;
+       struct cmb_data *cmb_data;
 
        cdev = to_ccwdev(dev);
-       interval  = get_clock() - cdev->private->cmb_start_time;
        count = cmf_read(cdev, cmb_sample_count);
-       if (count)
+       spin_lock_irq(cdev->ccwlock);
+       cmb_data = cdev->private->cmb;
+       if (count) {
+               interval = cmb_data->last_update -
+                       cdev->private->cmb_start_time;
+               interval = (interval * 1000) >> 12;
                interval /= count;
-       else
+       else
                interval = -1;
+       spin_unlock_irq(cdev->ccwlock);
        return sprintf(buf, "%ld\n", interval);
 }
 
-static ssize_t
-cmb_show_avg_utilization(struct device *dev, char *buf)
+static ssize_t cmb_show_avg_utilization(struct device *dev,
+                                       struct device_attribute *attr,
+                                       char *buf)
 {
        struct cmbdata data;
        u64 utilization;
@@ -821,7 +1082,10 @@ cmb_show_avg_utilization(struct device *dev, char *buf)
        int ret;
 
        ret = cmf_readall(to_ccwdev(dev), &data);
-       if (ret)
+       if (ret == -EAGAIN || ret == -ENODEV)
+               /* No data (yet/currently) available to use for calculation. */
+               return sprintf(buf, "n/a\n");
+       else if (ret)
                return ret;
 
        utilization = data.device_connect_time +
@@ -842,14 +1106,16 @@ cmb_show_avg_utilization(struct device *dev, char *buf)
 }
 
 #define cmf_attr(name) \
-static ssize_t show_ ## name (struct device * dev, char * buf) \
-{ return cmb_show_attr((dev), buf, cmb_ ## name); } \
-static DEVICE_ATTR(name, 0444, show_ ## name, NULL);
+static ssize_t show_##name(struct device *dev, \
+                          struct device_attribute *attr, char *buf)    \
+{ return cmb_show_attr((dev), buf, cmb_##name); } \
+static DEVICE_ATTR(name, 0444, show_##name, NULL);
 
 #define cmf_attr_avg(name) \
-static ssize_t show_avg_ ## name (struct device * dev, char * buf) \
-{ return cmb_show_attr((dev), buf, cmb_ ## name); } \
-static DEVICE_ATTR(avg_ ## name, 0444, show_avg_ ## name, NULL);
+static ssize_t show_avg_##name(struct device *dev, \
+                              struct device_attribute *attr, char *buf) \
+{ return cmb_show_attr((dev), buf, cmb_##name); } \
+static DEVICE_ATTR(avg_##name, 0444, show_avg_##name, NULL);
 
 cmf_attr(ssch_rsch_count);
 cmf_attr(sample_count);
@@ -861,7 +1127,8 @@ cmf_attr_avg(device_active_only_time);
 cmf_attr_avg(device_busy_time);
 cmf_attr_avg(initial_command_response_time);
 
-static DEVICE_ATTR(avg_sample_interval, 0444, cmb_show_avg_sample_interval, NULL);
+static DEVICE_ATTR(avg_sample_interval, 0444, cmb_show_avg_sample_interval,
+                  NULL);
 static DEVICE_ATTR(avg_utilization, 0444, cmb_show_avg_utilization, NULL);
 
 static struct attribute *cmf_attributes[] = {
@@ -874,7 +1141,7 @@ static struct attribute *cmf_attributes[] = {
        &dev_attr_avg_device_disconnect_time.attr,
        &dev_attr_avg_control_unit_queuing_time.attr,
        &dev_attr_avg_device_active_only_time.attr,
-       0,
+       NULL,
 };
 
 static struct attribute_group cmf_attr_group = {
@@ -894,7 +1161,7 @@ static struct attribute *cmf_attributes_ext[] = {
        &dev_attr_avg_device_active_only_time.attr,
        &dev_attr_avg_device_busy_time.attr,
        &dev_attr_avg_initial_command_response_time.attr,
-       0,
+       NULL,
 };
 
 static struct attribute_group cmf_attr_group_ext = {
@@ -902,28 +1169,33 @@ static struct attribute_group cmf_attr_group_ext = {
        .attrs = cmf_attributes_ext,
 };
 
-static ssize_t cmb_enable_show(struct device *dev, char *buf)
+static ssize_t cmb_enable_show(struct device *dev,
+                              struct device_attribute *attr,
+                              char *buf)
 {
        return sprintf(buf, "%d\n", to_ccwdev(dev)->private->cmb ? 1 : 0);
 }
 
-static ssize_t cmb_enable_store(struct device *dev, const char *buf, size_t c)
+static ssize_t cmb_enable_store(struct device *dev,
+                               struct device_attribute *attr, const char *buf,
+                               size_t c)
 {
        struct ccw_device *cdev;
        int ret;
+       unsigned long val;
+
+       ret = strict_strtoul(buf, 16, &val);
+       if (ret)
+               return ret;
 
        cdev = to_ccwdev(dev);
 
-       switch (buf[0]) {
-       case '0':
+       switch (val) {
+       case 0:
                ret = disable_cmf(cdev);
-               if (ret)
-                       printk(KERN_INFO "disable_cmf failed (%d)\n", ret);
                break;
-       case '1':
+       case 1:
                ret = enable_cmf(cdev);
-               if (ret && ret != -EBUSY)
-                       printk(KERN_INFO "enable_cmf failed (%d)\n", ret);
                break;
        }
 
@@ -932,9 +1204,21 @@ static ssize_t cmb_enable_store(struct device *dev, const char *buf, size_t c)
 
 DEVICE_ATTR(cmb_enable, 0644, cmb_enable_show, cmb_enable_store);
 
-/* enable_cmf/disable_cmf: module interface for cmf (de)activation */
-int
-enable_cmf(struct ccw_device *cdev)
+int ccw_set_cmf(struct ccw_device *cdev, int enable)
+{
+       return cmbops->set(cdev, enable ? 2 : 0);
+}
+
+/**
+ * enable_cmf() - switch on the channel measurement for a specific device
+ *  @cdev:     The ccw device to be enabled
+ *
+ *  Returns %0 for success or a negative error value.
+ *
+ *  Context:
+ *    non-atomic
+ */
+int enable_cmf(struct ccw_device *cdev)
 {
        int ret;
 
@@ -955,8 +1239,16 @@ enable_cmf(struct ccw_device *cdev)
        return ret;
 }
 
-int
-disable_cmf(struct ccw_device *cdev)
+/**
+ * disable_cmf() - switch off the channel measurement for a specific device
+ *  @cdev:     The ccw device to be disabled
+ *
+ *  Returns %0 for success or a negative error value.
+ *
+ *  Context:
+ *    non-atomic
+ */
+int disable_cmf(struct ccw_device *cdev)
 {
        int ret;
 
@@ -968,30 +1260,55 @@ disable_cmf(struct ccw_device *cdev)
        return ret;
 }
 
-u64
-cmf_read(struct ccw_device *cdev, int index)
+/**
+ * cmf_read() - read one value from the current channel measurement block
+ * @cdev:      the channel to be read
+ * @index:     the index of the value to be read
+ *
+ * Returns the value read or %0 if the value cannot be read.
+ *
+ *  Context:
+ *    any
+ */
+u64 cmf_read(struct ccw_device *cdev, int index)
 {
        return cmbops->read(cdev, index);
 }
 
-int
-cmf_readall(struct ccw_device *cdev, struct cmbdata *data)
+/**
+ * cmf_readall() - read the current channel measurement block
+ * @cdev:      the channel to be read
+ * @data:      a pointer to a data block that will be filled
+ *
+ * Returns %0 on success, a negative error value otherwise.
+ *
+ *  Context:
+ *    any
+ */
+int cmf_readall(struct ccw_device *cdev, struct cmbdata *data)
 {
        return cmbops->readall(cdev, data);
 }
 
-static int __init
-init_cmf(void)
+/* Reenable cmf when a disconnected device becomes available again. */
+int cmf_reenable(struct ccw_device *cdev)
+{
+       cmbops->reset(cdev);
+       return cmbops->set(cdev, 2);
+}
+
+static int __init init_cmf(void)
 {
        char *format_string;
        char *detect_string = "parameter";
 
-       /* We cannot really autoprobe this. If the user did not give a parameter,
-          see if we are running on z990 or up, otherwise fall back to basic mode. */
-
+       /*
+        * If the user did not give a parameter, see if we are running on a
+        * machine supporting extended measurement blocks, otherwise fall back
+        * to basic mode.
+        */
        if (format == CMF_AUTODETECT) {
-               if (!css_characteristics_avail ||
-                   !css_general_characteristics.ext_mb) {
+               if (!css_general_characteristics.ext_mb) {
                        format = CMF_BASIC;
                } else {
                        format = CMF_EXTENDED;
@@ -1005,26 +1322,16 @@ init_cmf(void)
        case CMF_BASIC:
                format_string = "basic";
                cmbops = &cmbops_basic;
-               if (cmb_area.num_channels > 4096 || cmb_area.num_channels < 1) {
-                       printk(KERN_ERR "Basic channel measurement facility"
-                                       " can only use 1 to 4096 devices\n"
-                              KERN_ERR "when the cmf driver is built"
-                                       " as a loadable module\n");
-                       return 1;
-               }
                break;
        case CMF_EXTENDED:
-               format_string = "extended";
+               format_string = "extended";
                cmbops = &cmbops_extended;
                break;
        default:
-               printk(KERN_ERR "Invalid format %d for channel "
-                       "measurement facility\n", format);
                return 1;
        }
-
-       printk(KERN_INFO "Channel measurement facility using %s format (%s)\n",
-               format_string, detect_string);
+       pr_info("Channel measurement facility initialized using format "
+               "%s (mode %s)\n", format_string, detect_string);
        return 0;
 }