const: constify remaining dev_pm_ops
[safe/jmp/linux-2.6] / drivers / power / wm97xx_battery.c
index 14ebd96..fa39e75 100644 (file)
@@ -22,6 +22,7 @@
 #include <linux/spinlock.h>
 #include <linux/interrupt.h>
 #include <linux/gpio.h>
+#include <linux/irq.h>
 
 static DEFINE_MUTEX(bat_lock);
 static struct work_struct bat_work;
@@ -35,7 +36,7 @@ static unsigned long wm97xx_read_bat(struct power_supply *bat_ps)
        struct wm97xx_pdata *wmdata = bat_ps->dev->parent->platform_data;
        struct wm97xx_batt_pdata *pdata = wmdata->batt_pdata;
 
-       return wm97xx_read_aux_adc(bat_ps->dev->parent->driver_data,
+       return wm97xx_read_aux_adc(dev_get_drvdata(bat_ps->dev->parent),
                                        pdata->batt_aux) * pdata->batt_mult /
                                        pdata->batt_div;
 }
@@ -45,7 +46,7 @@ static unsigned long wm97xx_read_temp(struct power_supply *bat_ps)
        struct wm97xx_pdata *wmdata = bat_ps->dev->parent->platform_data;
        struct wm97xx_batt_pdata *pdata = wmdata->batt_pdata;
 
-       return wm97xx_read_aux_adc(bat_ps->dev->parent->driver_data,
+       return wm97xx_read_aux_adc(dev_get_drvdata(bat_ps->dev->parent),
                                        pdata->temp_aux) * pdata->temp_mult /
                                        pdata->temp_div;
 }
@@ -137,21 +138,29 @@ static void wm97xx_bat_work(struct work_struct *work)
        wm97xx_bat_update(&bat_ps);
 }
 
+static irqreturn_t wm97xx_chrg_irq(int irq, void *data)
+{
+       schedule_work(&bat_work);
+       return IRQ_HANDLED;
+}
+
 #ifdef CONFIG_PM
-static int wm97xx_bat_suspend(struct platform_device *dev, pm_message_t state)
+static int wm97xx_bat_suspend(struct device *dev)
 {
        flush_scheduled_work();
        return 0;
 }
 
-static int wm97xx_bat_resume(struct platform_device *dev)
+static int wm97xx_bat_resume(struct device *dev)
 {
        schedule_work(&bat_work);
        return 0;
 }
-#else
-#define wm97xx_bat_suspend NULL
-#define wm97xx_bat_resume NULL
+
+static const struct dev_pm_ops wm97xx_bat_pm_ops = {
+       .suspend        = wm97xx_bat_suspend,
+       .resume         = wm97xx_bat_resume,
+};
 #endif
 
 static int __devinit wm97xx_bat_probe(struct platform_device *dev)
@@ -179,13 +188,18 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
                return -EINVAL;
        }
 
-       if (pdata->charge_gpio >= 0 && gpio_is_valid(pdata->charge_gpio)) {
+       if (gpio_is_valid(pdata->charge_gpio)) {
                ret = gpio_request(pdata->charge_gpio, "BATT CHRG");
                if (ret)
                        goto err;
                ret = gpio_direction_input(pdata->charge_gpio);
                if (ret)
                        goto err2;
+               ret = request_irq(gpio_to_irq(pdata->charge_gpio),
+                               wm97xx_chrg_irq, IRQF_DISABLED,
+                               "AC Detect", 0);
+               if (ret)
+                       goto err2;
                props++;        /* POWER_SUPPLY_PROP_STATUS */
        }
 
@@ -202,7 +216,7 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
 
        prop = kzalloc(props * sizeof(*prop), GFP_KERNEL);
        if (!prop)
-               goto err2;
+               goto err3;
 
        prop[i++] = POWER_SUPPLY_PROP_PRESENT;
        if (pdata->charge_gpio >= 0)
@@ -235,13 +249,17 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
        if (!ret)
                schedule_work(&bat_work);
        else
-               goto err3;
+               goto err4;
 
        return 0;
-err3:
+err4:
        kfree(prop);
+err3:
+       if (gpio_is_valid(pdata->charge_gpio))
+               free_irq(gpio_to_irq(pdata->charge_gpio), dev);
 err2:
-       gpio_free(pdata->charge_gpio);
+       if (gpio_is_valid(pdata->charge_gpio))
+               gpio_free(pdata->charge_gpio);
 err:
        return ret;
 }
@@ -251,8 +269,10 @@ static int __devexit wm97xx_bat_remove(struct platform_device *dev)
        struct wm97xx_pdata *wmdata = dev->dev.platform_data;
        struct wm97xx_batt_pdata *pdata = wmdata->batt_pdata;
 
-       if (pdata && pdata->charge_gpio && pdata->charge_gpio >= 0)
+       if (pdata && gpio_is_valid(pdata->charge_gpio)) {
+               free_irq(gpio_to_irq(pdata->charge_gpio), dev);
                gpio_free(pdata->charge_gpio);
+       }
        flush_scheduled_work();
        power_supply_unregister(&bat_ps);
        kfree(prop);
@@ -263,11 +283,12 @@ static struct platform_driver wm97xx_bat_driver = {
        .driver = {
                .name   = "wm97xx-battery",
                .owner  = THIS_MODULE,
+#ifdef CONFIG_PM
+               .pm     = &wm97xx_bat_pm_ops,
+#endif
        },
        .probe          = wm97xx_bat_probe,
        .remove         = __devexit_p(wm97xx_bat_remove),
-       .suspend        = wm97xx_bat_suspend,
-       .resume         = wm97xx_bat_resume,
 };
 
 static int __init wm97xx_bat_init(void)