Merge branch 'linus' into cont_syslog
[safe/jmp/linux-2.6] / drivers / net / macvlan.c
index 2056cfc..87e8d4c 100644 (file)
@@ -20,7 +20,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/list.h>
+#include <linux/rculist.h>
 #include <linux/notifier.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -29,6 +29,7 @@
 #include <linux/if_link.h>
 #include <linux/if_macvlan.h>
 #include <net/rtnetlink.h>
+#include <net/xfrm.h>
 
 #define MACVLAN_HASH_SIZE      (1 << BITS_PER_BYTE)
 
@@ -38,15 +39,6 @@ struct macvlan_port {
        struct list_head        vlans;
 };
 
-struct macvlan_dev {
-       struct net_device       *dev;
-       struct list_head        list;
-       struct hlist_node       hlist;
-       struct macvlan_port     *port;
-       struct net_device       *lowerdev;
-};
-
-
 static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
                                               const unsigned char *addr)
 {
@@ -54,63 +46,134 @@ static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
        struct hlist_node *n;
 
        hlist_for_each_entry_rcu(vlan, n, &port->vlan_hash[addr[5]], hlist) {
-               if (!compare_ether_addr(vlan->dev->dev_addr, addr))
+               if (!compare_ether_addr_64bits(vlan->dev->dev_addr, addr))
                        return vlan;
        }
        return NULL;
 }
 
+static void macvlan_hash_add(struct macvlan_dev *vlan)
+{
+       struct macvlan_port *port = vlan->port;
+       const unsigned char *addr = vlan->dev->dev_addr;
+
+       hlist_add_head_rcu(&vlan->hlist, &port->vlan_hash[addr[5]]);
+}
+
+static void macvlan_hash_del(struct macvlan_dev *vlan)
+{
+       hlist_del_rcu(&vlan->hlist);
+       synchronize_rcu();
+}
+
+static void macvlan_hash_change_addr(struct macvlan_dev *vlan,
+                                       const unsigned char *addr)
+{
+       macvlan_hash_del(vlan);
+       /* Now that we are unhashed it is safe to change the device
+        * address without confusing packet delivery.
+        */
+       memcpy(vlan->dev->dev_addr, addr, ETH_ALEN);
+       macvlan_hash_add(vlan);
+}
+
+static int macvlan_addr_busy(const struct macvlan_port *port,
+                               const unsigned char *addr)
+{
+       /* Test to see if the specified multicast address is
+        * currently in use by the underlying device or
+        * another macvlan.
+        */
+       if (!compare_ether_addr_64bits(port->dev->dev_addr, addr))
+               return 1;
+
+       if (macvlan_hash_lookup(port, addr))
+               return 1;
+
+       return 0;
+}
+
+
+static int macvlan_broadcast_one(struct sk_buff *skb,
+                                const struct macvlan_dev *vlan,
+                                const struct ethhdr *eth, bool local)
+{
+       struct net_device *dev = vlan->dev;
+       if (!skb)
+               return NET_RX_DROP;
+
+       if (local)
+               return vlan->forward(dev, skb);
+
+       skb->dev = dev;
+       if (!compare_ether_addr_64bits(eth->h_dest,
+                                      dev->broadcast))
+               skb->pkt_type = PACKET_BROADCAST;
+       else
+               skb->pkt_type = PACKET_MULTICAST;
+
+       return vlan->receive(skb);
+}
+
 static void macvlan_broadcast(struct sk_buff *skb,
-                             const struct macvlan_port *port)
+                             const struct macvlan_port *port,
+                             struct net_device *src,
+                             enum macvlan_mode mode)
 {
        const struct ethhdr *eth = eth_hdr(skb);
        const struct macvlan_dev *vlan;
        struct hlist_node *n;
-       struct net_device *dev;
        struct sk_buff *nskb;
        unsigned int i;
+       int err;
+
+       if (skb->protocol == htons(ETH_P_PAUSE))
+               return;
 
        for (i = 0; i < MACVLAN_HASH_SIZE; i++) {
                hlist_for_each_entry_rcu(vlan, n, &port->vlan_hash[i], hlist) {
-                       dev = vlan->dev;
-
-                       nskb = skb_clone(skb, GFP_ATOMIC);
-                       if (nskb == NULL) {
-                               dev->stats.rx_errors++;
-                               dev->stats.rx_dropped++;
+                       if (vlan->dev == src || !(vlan->mode & mode))
                                continue;
-                       }
-
-                       dev->stats.rx_bytes += skb->len + ETH_HLEN;
-                       dev->stats.rx_packets++;
-                       dev->stats.multicast++;
-                       dev->last_rx = jiffies;
-
-                       nskb->dev = dev;
-                       if (!compare_ether_addr(eth->h_dest, dev->broadcast))
-                               nskb->pkt_type = PACKET_BROADCAST;
-                       else
-                               nskb->pkt_type = PACKET_MULTICAST;
 
-                       netif_rx(nskb);
+                       nskb = skb_clone(skb, GFP_ATOMIC);
+                       err = macvlan_broadcast_one(nskb, vlan, eth,
+                                        mode == MACVLAN_MODE_BRIDGE);
+                       macvlan_count_rx(vlan, skb->len + ETH_HLEN,
+                                        err == NET_RX_SUCCESS, 1);
                }
        }
 }
 
 /* called under rcu_read_lock() from netif_receive_skb */
-static struct sk_buff *macvlan_handle_frame(struct sk_buff *skb)
+static struct sk_buff *macvlan_handle_frame(struct macvlan_port *port,
+                                           struct sk_buff *skb)
 {
        const struct ethhdr *eth = eth_hdr(skb);
-       const struct macvlan_port *port;
        const struct macvlan_dev *vlan;
+       const struct macvlan_dev *src;
        struct net_device *dev;
-
-       port = rcu_dereference(skb->dev->macvlan_port);
-       if (port == NULL)
-               return skb;
+       unsigned int len;
 
        if (is_multicast_ether_addr(eth->h_dest)) {
-               macvlan_broadcast(skb, port);
+               src = macvlan_hash_lookup(port, eth->h_source);
+               if (!src)
+                       /* frame comes from an external address */
+                       macvlan_broadcast(skb, port, NULL,
+                                         MACVLAN_MODE_PRIVATE |
+                                         MACVLAN_MODE_VEPA    |
+                                         MACVLAN_MODE_BRIDGE);
+               else if (src->mode == MACVLAN_MODE_VEPA)
+                       /* flood to everyone except source */
+                       macvlan_broadcast(skb, port, src->dev,
+                                         MACVLAN_MODE_VEPA |
+                                         MACVLAN_MODE_BRIDGE);
+               else if (src->mode == MACVLAN_MODE_BRIDGE)
+                       /*
+                        * flood only to VEPA ports, bridge ports
+                        * already saw the frame on the way out.
+                        */
+                       macvlan_broadcast(skb, port, src->dev,
+                                         MACVLAN_MODE_VEPA);
                return skb;
        }
 
@@ -123,43 +186,68 @@ static struct sk_buff *macvlan_handle_frame(struct sk_buff *skb)
                kfree_skb(skb);
                return NULL;
        }
-
+       len = skb->len + ETH_HLEN;
        skb = skb_share_check(skb, GFP_ATOMIC);
-       if (skb == NULL) {
-               dev->stats.rx_errors++;
-               dev->stats.rx_dropped++;
+       macvlan_count_rx(vlan, len, skb != NULL, 0);
+       if (!skb)
                return NULL;
-       }
-
-       dev->stats.rx_bytes += skb->len + ETH_HLEN;
-       dev->stats.rx_packets++;
-       dev->last_rx = jiffies;
 
        skb->dev = dev;
        skb->pkt_type = PACKET_HOST;
 
-       netif_rx(skb);
+       vlan->receive(skb);
        return NULL;
 }
 
-static int macvlan_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
+static int macvlan_queue_xmit(struct sk_buff *skb, struct net_device *dev)
 {
        const struct macvlan_dev *vlan = netdev_priv(dev);
+       const struct macvlan_port *port = vlan->port;
+       const struct macvlan_dev *dest;
+
+       if (vlan->mode == MACVLAN_MODE_BRIDGE) {
+               const struct ethhdr *eth = (void *)skb->data;
+
+               /* send to other bridge ports directly */
+               if (is_multicast_ether_addr(eth->h_dest)) {
+                       macvlan_broadcast(skb, port, dev, MACVLAN_MODE_BRIDGE);
+                       goto xmit_world;
+               }
+
+               dest = macvlan_hash_lookup(port, eth->h_dest);
+               if (dest && dest->mode == MACVLAN_MODE_BRIDGE) {
+                       unsigned int length = skb->len + ETH_HLEN;
+                       int ret = dest->forward(dest->dev, skb);
+                       macvlan_count_rx(dest, length,
+                                        ret == NET_RX_SUCCESS, 0);
+
+                       return NET_XMIT_SUCCESS;
+               }
+       }
+
+xmit_world:
+       skb_set_dev(skb, vlan->lowerdev);
+       return dev_queue_xmit(skb);
+}
+
+netdev_tx_t macvlan_start_xmit(struct sk_buff *skb,
+                              struct net_device *dev)
+{
+       int i = skb_get_queue_mapping(skb);
+       struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
        unsigned int len = skb->len;
        int ret;
 
-       skb->dev = vlan->lowerdev;
-       ret = dev_queue_xmit(skb);
+       ret = macvlan_queue_xmit(skb, dev);
+       if (likely(ret == NET_XMIT_SUCCESS || ret == NET_XMIT_CN)) {
+               txq->tx_packets++;
+               txq->tx_bytes += len;
+       } else
+               txq->tx_dropped++;
 
-       if (likely(ret == NET_XMIT_SUCCESS)) {
-               dev->stats.tx_packets++;
-               dev->stats.tx_bytes += len;
-       } else {
-               dev->stats.tx_errors++;
-               dev->stats.tx_aborted_errors++;
-       }
-       return NETDEV_TX_OK;
+       return ret;
 }
+EXPORT_SYMBOL_GPL(macvlan_start_xmit);
 
 static int macvlan_hard_header(struct sk_buff *skb, struct net_device *dev,
                               unsigned short type, const void *daddr,
@@ -183,18 +271,28 @@ static const struct header_ops macvlan_hard_header_ops = {
 static int macvlan_open(struct net_device *dev)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
-       struct macvlan_port *port = vlan->port;
        struct net_device *lowerdev = vlan->lowerdev;
        int err;
 
-       err = dev_unicast_add(lowerdev, dev->dev_addr, ETH_ALEN);
-       if (err < 0)
-               return err;
-       if (dev->flags & IFF_ALLMULTI)
-               dev_set_allmulti(lowerdev, 1);
+       err = -EBUSY;
+       if (macvlan_addr_busy(vlan->port, dev->dev_addr))
+               goto out;
 
-       hlist_add_head_rcu(&vlan->hlist, &port->vlan_hash[dev->dev_addr[5]]);
+       err = dev_uc_add(lowerdev, dev->dev_addr);
+       if (err < 0)
+               goto out;
+       if (dev->flags & IFF_ALLMULTI) {
+               err = dev_set_allmulti(lowerdev, 1);
+               if (err < 0)
+                       goto del_unicast;
+       }
+       macvlan_hash_add(vlan);
        return 0;
+
+del_unicast:
+       dev_uc_del(lowerdev, dev->dev_addr);
+out:
+       return err;
 }
 
 static int macvlan_stop(struct net_device *dev)
@@ -206,10 +304,9 @@ static int macvlan_stop(struct net_device *dev)
        if (dev->flags & IFF_ALLMULTI)
                dev_set_allmulti(lowerdev, -1);
 
-       dev_unicast_delete(lowerdev, dev->dev_addr, ETH_ALEN);
+       dev_uc_del(lowerdev, dev->dev_addr);
 
-       hlist_del_rcu(&vlan->hlist);
-       synchronize_rcu();
+       macvlan_hash_del(vlan);
        return 0;
 }
 
@@ -223,16 +320,22 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
        if (!is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
 
-       if (!(dev->flags & IFF_UP))
-               goto out;
+       if (!(dev->flags & IFF_UP)) {
+               /* Just copy in the new address */
+               memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+       } else {
+               /* Rehash and update the device filters */
+               if (macvlan_addr_busy(vlan->port, addr->sa_data))
+                       return -EBUSY;
 
-       err = dev_unicast_add(lowerdev, addr->sa_data, ETH_ALEN);
-       if (err < 0)
-               return err;
-       dev_unicast_delete(lowerdev, dev->dev_addr, ETH_ALEN);
+               err = dev_uc_add(lowerdev, addr->sa_data);
+               if (err)
+                       return err;
 
-out:
-       memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+               dev_uc_del(lowerdev, dev->dev_addr);
+
+               macvlan_hash_change_addr(vlan, addr->sa_data);
+       }
        return 0;
 }
 
@@ -268,15 +371,31 @@ static int macvlan_change_mtu(struct net_device *dev, int new_mtu)
  * separate class since they always nest.
  */
 static struct lock_class_key macvlan_netdev_xmit_lock_key;
+static struct lock_class_key macvlan_netdev_addr_lock_key;
 
 #define MACVLAN_FEATURES \
        (NETIF_F_SG | NETIF_F_ALL_CSUM | NETIF_F_HIGHDMA | NETIF_F_FRAGLIST | \
         NETIF_F_GSO | NETIF_F_TSO | NETIF_F_UFO | NETIF_F_GSO_ROBUST | \
-        NETIF_F_TSO_ECN | NETIF_F_TSO6)
+        NETIF_F_TSO_ECN | NETIF_F_TSO6 | NETIF_F_GRO)
 
 #define MACVLAN_STATE_MASK \
        ((1<<__LINK_STATE_NOCARRIER) | (1<<__LINK_STATE_DORMANT))
 
+static void macvlan_set_lockdep_class_one(struct net_device *dev,
+                                         struct netdev_queue *txq,
+                                         void *_unused)
+{
+       lockdep_set_class(&txq->_xmit_lock,
+                         &macvlan_netdev_xmit_lock_key);
+}
+
+static void macvlan_set_lockdep_class(struct net_device *dev)
+{
+       lockdep_set_class(&dev->addr_list_lock,
+                         &macvlan_netdev_addr_lock_key);
+       netdev_for_each_tx_queue(dev, macvlan_set_lockdep_class_one, NULL);
+}
+
 static int macvlan_init(struct net_device *dev)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
@@ -285,12 +404,53 @@ static int macvlan_init(struct net_device *dev)
        dev->state              = (dev->state & ~MACVLAN_STATE_MASK) |
                                  (lowerdev->state & MACVLAN_STATE_MASK);
        dev->features           = lowerdev->features & MACVLAN_FEATURES;
+       dev->gso_max_size       = lowerdev->gso_max_size;
        dev->iflink             = lowerdev->ifindex;
+       dev->hard_header_len    = lowerdev->hard_header_len;
+
+       macvlan_set_lockdep_class(dev);
+
+       vlan->rx_stats = alloc_percpu(struct macvlan_rx_stats);
+       if (!vlan->rx_stats)
+               return -ENOMEM;
 
-       lockdep_set_class(&dev->_xmit_lock, &macvlan_netdev_xmit_lock_key);
        return 0;
 }
 
+static void macvlan_uninit(struct net_device *dev)
+{
+       struct macvlan_dev *vlan = netdev_priv(dev);
+
+       free_percpu(vlan->rx_stats);
+}
+
+static struct net_device_stats *macvlan_dev_get_stats(struct net_device *dev)
+{
+       struct net_device_stats *stats = &dev->stats;
+       struct macvlan_dev *vlan = netdev_priv(dev);
+
+       dev_txq_stats_fold(dev, stats);
+
+       if (vlan->rx_stats) {
+               struct macvlan_rx_stats *p, rx = {0};
+               int i;
+
+               for_each_possible_cpu(i) {
+                       p = per_cpu_ptr(vlan->rx_stats, i);
+                       rx.rx_packets += p->rx_packets;
+                       rx.rx_bytes   += p->rx_bytes;
+                       rx.rx_errors  += p->rx_errors;
+                       rx.multicast  += p->multicast;
+               }
+               stats->rx_packets = rx.rx_packets;
+               stats->rx_bytes   = rx.rx_bytes;
+               stats->rx_errors  = rx.rx_errors;
+               stats->rx_dropped = rx.rx_errors;
+               stats->multicast  = rx.multicast;
+       }
+       return stats;
+}
+
 static void macvlan_ethtool_get_drvinfo(struct net_device *dev,
                                        struct ethtool_drvinfo *drvinfo)
 {
@@ -301,31 +461,50 @@ static void macvlan_ethtool_get_drvinfo(struct net_device *dev,
 static u32 macvlan_ethtool_get_rx_csum(struct net_device *dev)
 {
        const struct macvlan_dev *vlan = netdev_priv(dev);
-       struct net_device *lowerdev = vlan->lowerdev;
+       return dev_ethtool_get_rx_csum(vlan->lowerdev);
+}
 
-       if (lowerdev->ethtool_ops->get_rx_csum == NULL)
-               return 0;
-       return lowerdev->ethtool_ops->get_rx_csum(lowerdev);
+static int macvlan_ethtool_get_settings(struct net_device *dev,
+                                       struct ethtool_cmd *cmd)
+{
+       const struct macvlan_dev *vlan = netdev_priv(dev);
+       return dev_ethtool_get_settings(vlan->lowerdev, cmd);
+}
+
+static u32 macvlan_ethtool_get_flags(struct net_device *dev)
+{
+       const struct macvlan_dev *vlan = netdev_priv(dev);
+       return dev_ethtool_get_flags(vlan->lowerdev);
 }
 
 static const struct ethtool_ops macvlan_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
+       .get_settings           = macvlan_ethtool_get_settings,
        .get_rx_csum            = macvlan_ethtool_get_rx_csum,
        .get_drvinfo            = macvlan_ethtool_get_drvinfo,
+       .get_flags              = macvlan_ethtool_get_flags,
+};
+
+static const struct net_device_ops macvlan_netdev_ops = {
+       .ndo_init               = macvlan_init,
+       .ndo_uninit             = macvlan_uninit,
+       .ndo_open               = macvlan_open,
+       .ndo_stop               = macvlan_stop,
+       .ndo_start_xmit         = macvlan_start_xmit,
+       .ndo_change_mtu         = macvlan_change_mtu,
+       .ndo_change_rx_flags    = macvlan_change_rx_flags,
+       .ndo_set_mac_address    = macvlan_set_mac_address,
+       .ndo_set_multicast_list = macvlan_set_multicast_list,
+       .ndo_get_stats          = macvlan_dev_get_stats,
+       .ndo_validate_addr      = eth_validate_addr,
 };
 
 static void macvlan_setup(struct net_device *dev)
 {
        ether_setup(dev);
 
-       dev->init               = macvlan_init;
-       dev->open               = macvlan_open;
-       dev->stop               = macvlan_stop;
-       dev->change_mtu         = macvlan_change_mtu;
-       dev->change_rx_flags    = macvlan_change_rx_flags;
-       dev->set_mac_address    = macvlan_set_mac_address;
-       dev->set_multicast_list = macvlan_set_multicast_list;
-       dev->hard_start_xmit    = macvlan_hard_start_xmit;
+       dev->priv_flags        &= ~IFF_XMIT_DST_RELEASE;
+       dev->netdev_ops         = &macvlan_netdev_ops;
        dev->destructor         = free_netdev;
        dev->header_ops         = &macvlan_hard_header_ops,
        dev->ethtool_ops        = &macvlan_ethtool_ops;
@@ -361,25 +540,6 @@ static void macvlan_port_destroy(struct net_device *dev)
        kfree(port);
 }
 
-static void macvlan_transfer_operstate(struct net_device *dev)
-{
-       struct macvlan_dev *vlan = netdev_priv(dev);
-       const struct net_device *lowerdev = vlan->lowerdev;
-
-       if (lowerdev->operstate == IF_OPER_DORMANT)
-               netif_dormant_on(dev);
-       else
-               netif_dormant_off(dev);
-
-       if (netif_carrier_ok(lowerdev)) {
-               if (!netif_carrier_ok(dev))
-                       netif_carrier_on(dev);
-       } else {
-               if (netif_carrier_ok(dev))
-                       netif_carrier_off(dev);
-       }
-}
-
 static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[])
 {
        if (tb[IFLA_ADDRESS]) {
@@ -388,11 +548,44 @@ static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[])
                if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS])))
                        return -EADDRNOTAVAIL;
        }
+
+       if (data && data[IFLA_MACVLAN_MODE]) {
+               switch (nla_get_u32(data[IFLA_MACVLAN_MODE])) {
+               case MACVLAN_MODE_PRIVATE:
+               case MACVLAN_MODE_VEPA:
+               case MACVLAN_MODE_BRIDGE:
+                       break;
+               default:
+                       return -EINVAL;
+               }
+       }
        return 0;
 }
 
-static int macvlan_newlink(struct net_device *dev,
-                          struct nlattr *tb[], struct nlattr *data[])
+static int macvlan_get_tx_queues(struct net *net,
+                                struct nlattr *tb[],
+                                unsigned int *num_tx_queues,
+                                unsigned int *real_num_tx_queues)
+{
+       struct net_device *real_dev;
+
+       if (!tb[IFLA_LINK])
+               return -EINVAL;
+
+       real_dev = __dev_get_by_index(net, nla_get_u32(tb[IFLA_LINK]));
+       if (!real_dev)
+               return -ENODEV;
+
+       *num_tx_queues      = real_dev->num_tx_queues;
+       *real_num_tx_queues = real_dev->real_num_tx_queues;
+       return 0;
+}
+
+int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
+                          struct nlattr *tb[], struct nlattr *data[],
+                          int (*receive)(struct sk_buff *skb),
+                          int (*forward)(struct net_device *dev,
+                                         struct sk_buff *skb))
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
        struct macvlan_port *port;
@@ -402,16 +595,17 @@ static int macvlan_newlink(struct net_device *dev,
        if (!tb[IFLA_LINK])
                return -EINVAL;
 
-       lowerdev = __dev_get_by_index(dev_net(dev), nla_get_u32(tb[IFLA_LINK]));
+       lowerdev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK]));
        if (lowerdev == NULL)
                return -ENODEV;
 
-       /* Don't allow macvlans on top of other macvlans - its not really
-        * wrong, but lockdep can't handle it and its not useful for anything
-        * you couldn't do directly on top of the real device.
+       /* When creating macvlans on top of other macvlans - use
+        * the real device as the lowerdev.
         */
-       if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops)
-               return -ENODEV;
+       if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops) {
+               struct macvlan_dev *lowervlan = netdev_priv(lowerdev);
+               lowerdev = lowervlan->lowerdev;
+       }
 
        if (!tb[IFLA_MTU])
                dev->mtu = lowerdev->mtu;
@@ -431,33 +625,100 @@ static int macvlan_newlink(struct net_device *dev,
        vlan->lowerdev = lowerdev;
        vlan->dev      = dev;
        vlan->port     = port;
+       vlan->receive  = receive;
+       vlan->forward  = forward;
+
+       vlan->mode     = MACVLAN_MODE_VEPA;
+       if (data && data[IFLA_MACVLAN_MODE])
+               vlan->mode = nla_get_u32(data[IFLA_MACVLAN_MODE]);
 
        err = register_netdevice(dev);
        if (err < 0)
-               return err;
+               goto destroy_port;
 
        list_add_tail(&vlan->list, &port->vlans);
-       macvlan_transfer_operstate(dev);
+       netif_stacked_transfer_operstate(lowerdev, dev);
+
        return 0;
+
+destroy_port:
+       if (list_empty(&port->vlans))
+               macvlan_port_destroy(lowerdev);
+
+       return err;
+}
+EXPORT_SYMBOL_GPL(macvlan_common_newlink);
+
+static int macvlan_newlink(struct net *src_net, struct net_device *dev,
+                          struct nlattr *tb[], struct nlattr *data[])
+{
+       return macvlan_common_newlink(src_net, dev, tb, data,
+                                     netif_rx,
+                                     dev_forward_skb);
 }
 
-static void macvlan_dellink(struct net_device *dev)
+void macvlan_dellink(struct net_device *dev, struct list_head *head)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
        struct macvlan_port *port = vlan->port;
 
        list_del(&vlan->list);
-       unregister_netdevice(dev);
+       unregister_netdevice_queue(dev, head);
 
        if (list_empty(&port->vlans))
-               macvlan_port_destroy(dev);
+               macvlan_port_destroy(port->dev);
+}
+EXPORT_SYMBOL_GPL(macvlan_dellink);
+
+static int macvlan_changelink(struct net_device *dev,
+               struct nlattr *tb[], struct nlattr *data[])
+{
+       struct macvlan_dev *vlan = netdev_priv(dev);
+       if (data && data[IFLA_MACVLAN_MODE])
+               vlan->mode = nla_get_u32(data[IFLA_MACVLAN_MODE]);
+       return 0;
 }
 
-static struct rtnl_link_ops macvlan_link_ops __read_mostly = {
+static size_t macvlan_get_size(const struct net_device *dev)
+{
+       return nla_total_size(4);
+}
+
+static int macvlan_fill_info(struct sk_buff *skb,
+                               const struct net_device *dev)
+{
+       struct macvlan_dev *vlan = netdev_priv(dev);
+
+       NLA_PUT_U32(skb, IFLA_MACVLAN_MODE, vlan->mode);
+       return 0;
+
+nla_put_failure:
+       return -EMSGSIZE;
+}
+
+static const struct nla_policy macvlan_policy[IFLA_MACVLAN_MAX + 1] = {
+       [IFLA_MACVLAN_MODE] = { .type = NLA_U32 },
+};
+
+int macvlan_link_register(struct rtnl_link_ops *ops)
+{
+       /* common fields */
+       ops->priv_size          = sizeof(struct macvlan_dev);
+       ops->get_tx_queues      = macvlan_get_tx_queues;
+       ops->setup              = macvlan_setup;
+       ops->validate           = macvlan_validate;
+       ops->maxtype            = IFLA_MACVLAN_MAX;
+       ops->policy             = macvlan_policy;
+       ops->changelink         = macvlan_changelink;
+       ops->get_size           = macvlan_get_size;
+       ops->fill_info          = macvlan_fill_info;
+
+       return rtnl_link_register(ops);
+};
+EXPORT_SYMBOL_GPL(macvlan_link_register);
+
+static struct rtnl_link_ops macvlan_link_ops = {
        .kind           = "macvlan",
-       .priv_size      = sizeof(struct macvlan_dev),
-       .setup          = macvlan_setup,
-       .validate       = macvlan_validate,
        .newlink        = macvlan_newlink,
        .dellink        = macvlan_dellink,
 };
@@ -476,18 +737,23 @@ static int macvlan_device_event(struct notifier_block *unused,
        switch (event) {
        case NETDEV_CHANGE:
                list_for_each_entry(vlan, &port->vlans, list)
-                       macvlan_transfer_operstate(vlan->dev);
+                       netif_stacked_transfer_operstate(vlan->lowerdev,
+                                                        vlan->dev);
                break;
        case NETDEV_FEAT_CHANGE:
                list_for_each_entry(vlan, &port->vlans, list) {
                        vlan->dev->features = dev->features & MACVLAN_FEATURES;
+                       vlan->dev->gso_max_size = dev->gso_max_size;
                        netdev_features_change(vlan->dev);
                }
                break;
        case NETDEV_UNREGISTER:
                list_for_each_entry_safe(vlan, next, &port->vlans, list)
-                       macvlan_dellink(vlan->dev);
+                       vlan->dev->rtnl_link_ops->dellink(vlan->dev, NULL);
                break;
+       case NETDEV_PRE_TYPE_CHANGE:
+               /* Forbid underlaying device to change its type. */
+               return NOTIFY_BAD;
        }
        return NOTIFY_DONE;
 }
@@ -503,7 +769,7 @@ static int __init macvlan_init_module(void)
        register_netdevice_notifier(&macvlan_notifier_block);
        macvlan_handle_frame_hook = macvlan_handle_frame;
 
-       err = rtnl_link_register(&macvlan_link_ops);
+       err = macvlan_link_register(&macvlan_link_ops);
        if (err < 0)
                goto err1;
        return 0;