macvlan: cleanup rx statistics
[safe/jmp/linux-2.6] / drivers / net / macvlan.c
index 2056cfc..1e7faf9 100644 (file)
@@ -20,7 +20,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/list.h>
+#include <linux/rculist.h>
 #include <linux/notifier.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -38,12 +38,27 @@ struct macvlan_port {
        struct list_head        vlans;
 };
 
+/**
+ *     struct macvlan_rx_stats - MACVLAN percpu rx stats
+ *     @rx_packets: number of received packets
+ *     @rx_bytes: number of received bytes
+ *     @multicast: number of received multicast packets
+ *     @rx_errors: number of errors
+ */
+struct macvlan_rx_stats {
+       unsigned long rx_packets;
+       unsigned long rx_bytes;
+       unsigned long multicast;
+       unsigned long rx_errors;
+};
+
 struct macvlan_dev {
        struct net_device       *dev;
        struct list_head        list;
        struct hlist_node       hlist;
        struct macvlan_port     *port;
        struct net_device       *lowerdev;
+       struct macvlan_rx_stats *rx_stats;
 };
 
 
@@ -54,45 +69,105 @@ static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
        struct hlist_node *n;
 
        hlist_for_each_entry_rcu(vlan, n, &port->vlan_hash[addr[5]], hlist) {
-               if (!compare_ether_addr(vlan->dev->dev_addr, addr))
+               if (!compare_ether_addr_64bits(vlan->dev->dev_addr, addr))
                        return vlan;
        }
        return NULL;
 }
 
+static void macvlan_hash_add(struct macvlan_dev *vlan)
+{
+       struct macvlan_port *port = vlan->port;
+       const unsigned char *addr = vlan->dev->dev_addr;
+
+       hlist_add_head_rcu(&vlan->hlist, &port->vlan_hash[addr[5]]);
+}
+
+static void macvlan_hash_del(struct macvlan_dev *vlan)
+{
+       hlist_del_rcu(&vlan->hlist);
+       synchronize_rcu();
+}
+
+static void macvlan_hash_change_addr(struct macvlan_dev *vlan,
+                                       const unsigned char *addr)
+{
+       macvlan_hash_del(vlan);
+       /* Now that we are unhashed it is safe to change the device
+        * address without confusing packet delivery.
+        */
+       memcpy(vlan->dev->dev_addr, addr, ETH_ALEN);
+       macvlan_hash_add(vlan);
+}
+
+static int macvlan_addr_busy(const struct macvlan_port *port,
+                               const unsigned char *addr)
+{
+       /* Test to see if the specified multicast address is
+        * currently in use by the underlying device or
+        * another macvlan.
+        */
+       if (!compare_ether_addr_64bits(port->dev->dev_addr, addr))
+               return 1;
+
+       if (macvlan_hash_lookup(port, addr))
+               return 1;
+
+       return 0;
+}
+
+static inline void macvlan_count_rx(const struct macvlan_dev *vlan,
+                                   unsigned int len, bool success,
+                                   bool multicast)
+{
+       struct macvlan_rx_stats *rx_stats;
+
+       rx_stats = per_cpu_ptr(vlan->rx_stats, smp_processor_id());
+       if (likely(success)) {
+               rx_stats->rx_packets++;;
+               rx_stats->rx_bytes += len;
+               if (multicast)
+                       rx_stats->multicast++;
+       } else {
+               rx_stats->rx_errors++;
+       }
+}
+
+static int macvlan_broadcast_one(struct sk_buff *skb, struct net_device *dev,
+                                const struct ethhdr *eth)
+{
+       if (!skb)
+               return NET_RX_DROP;
+
+       skb->dev = dev;
+       if (!compare_ether_addr_64bits(eth->h_dest,
+                                      dev->broadcast))
+               skb->pkt_type = PACKET_BROADCAST;
+       else
+               skb->pkt_type = PACKET_MULTICAST;
+
+       return netif_rx(skb);
+}
+
 static void macvlan_broadcast(struct sk_buff *skb,
                              const struct macvlan_port *port)
 {
        const struct ethhdr *eth = eth_hdr(skb);
        const struct macvlan_dev *vlan;
        struct hlist_node *n;
-       struct net_device *dev;
        struct sk_buff *nskb;
        unsigned int i;
+       int err;
+
+       if (skb->protocol == htons(ETH_P_PAUSE))
+               return;
 
        for (i = 0; i < MACVLAN_HASH_SIZE; i++) {
                hlist_for_each_entry_rcu(vlan, n, &port->vlan_hash[i], hlist) {
-                       dev = vlan->dev;
-
                        nskb = skb_clone(skb, GFP_ATOMIC);
-                       if (nskb == NULL) {
-                               dev->stats.rx_errors++;
-                               dev->stats.rx_dropped++;
-                               continue;
-                       }
-
-                       dev->stats.rx_bytes += skb->len + ETH_HLEN;
-                       dev->stats.rx_packets++;
-                       dev->stats.multicast++;
-                       dev->last_rx = jiffies;
-
-                       nskb->dev = dev;
-                       if (!compare_ether_addr(eth->h_dest, dev->broadcast))
-                               nskb->pkt_type = PACKET_BROADCAST;
-                       else
-                               nskb->pkt_type = PACKET_MULTICAST;
-
-                       netif_rx(nskb);
+                       err = macvlan_broadcast_one(nskb, vlan->dev, eth);
+                       macvlan_count_rx(vlan, skb->len + ETH_HLEN,
+                                        err == NET_RX_SUCCESS, 1);
                }
        }
 }
@@ -104,6 +179,7 @@ static struct sk_buff *macvlan_handle_frame(struct sk_buff *skb)
        const struct macvlan_port *port;
        const struct macvlan_dev *vlan;
        struct net_device *dev;
+       unsigned int len;
 
        port = rcu_dereference(skb->dev->macvlan_port);
        if (port == NULL)
@@ -123,17 +199,11 @@ static struct sk_buff *macvlan_handle_frame(struct sk_buff *skb)
                kfree_skb(skb);
                return NULL;
        }
-
+       len = skb->len + ETH_HLEN;
        skb = skb_share_check(skb, GFP_ATOMIC);
-       if (skb == NULL) {
-               dev->stats.rx_errors++;
-               dev->stats.rx_dropped++;
+       macvlan_count_rx(vlan, len, skb != NULL, 0);
+       if (!skb)
                return NULL;
-       }
-
-       dev->stats.rx_bytes += skb->len + ETH_HLEN;
-       dev->stats.rx_packets++;
-       dev->last_rx = jiffies;
 
        skb->dev = dev;
        skb->pkt_type = PACKET_HOST;
@@ -142,8 +212,11 @@ static struct sk_buff *macvlan_handle_frame(struct sk_buff *skb)
        return NULL;
 }
 
-static int macvlan_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
+static netdev_tx_t macvlan_start_xmit(struct sk_buff *skb,
+                                     struct net_device *dev)
 {
+       int i = skb_get_queue_mapping(skb);
+       struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
        const struct macvlan_dev *vlan = netdev_priv(dev);
        unsigned int len = skb->len;
        int ret;
@@ -152,13 +225,12 @@ static int macvlan_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        ret = dev_queue_xmit(skb);
 
        if (likely(ret == NET_XMIT_SUCCESS)) {
-               dev->stats.tx_packets++;
-               dev->stats.tx_bytes += len;
-       } else {
-               dev->stats.tx_errors++;
-               dev->stats.tx_aborted_errors++;
-       }
-       return NETDEV_TX_OK;
+               txq->tx_packets++;
+               txq->tx_bytes += len;
+       } else
+               txq->tx_dropped++;
+
+       return ret;
 }
 
 static int macvlan_hard_header(struct sk_buff *skb, struct net_device *dev,
@@ -183,18 +255,28 @@ static const struct header_ops macvlan_hard_header_ops = {
 static int macvlan_open(struct net_device *dev)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
-       struct macvlan_port *port = vlan->port;
        struct net_device *lowerdev = vlan->lowerdev;
        int err;
 
-       err = dev_unicast_add(lowerdev, dev->dev_addr, ETH_ALEN);
-       if (err < 0)
-               return err;
-       if (dev->flags & IFF_ALLMULTI)
-               dev_set_allmulti(lowerdev, 1);
+       err = -EBUSY;
+       if (macvlan_addr_busy(vlan->port, dev->dev_addr))
+               goto out;
 
-       hlist_add_head_rcu(&vlan->hlist, &port->vlan_hash[dev->dev_addr[5]]);
+       err = dev_unicast_add(lowerdev, dev->dev_addr);
+       if (err < 0)
+               goto out;
+       if (dev->flags & IFF_ALLMULTI) {
+               err = dev_set_allmulti(lowerdev, 1);
+               if (err < 0)
+                       goto del_unicast;
+       }
+       macvlan_hash_add(vlan);
        return 0;
+
+del_unicast:
+       dev_unicast_delete(lowerdev, dev->dev_addr);
+out:
+       return err;
 }
 
 static int macvlan_stop(struct net_device *dev)
@@ -206,10 +288,9 @@ static int macvlan_stop(struct net_device *dev)
        if (dev->flags & IFF_ALLMULTI)
                dev_set_allmulti(lowerdev, -1);
 
-       dev_unicast_delete(lowerdev, dev->dev_addr, ETH_ALEN);
+       dev_unicast_delete(lowerdev, dev->dev_addr);
 
-       hlist_del_rcu(&vlan->hlist);
-       synchronize_rcu();
+       macvlan_hash_del(vlan);
        return 0;
 }
 
@@ -223,16 +304,22 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
        if (!is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
 
-       if (!(dev->flags & IFF_UP))
-               goto out;
+       if (!(dev->flags & IFF_UP)) {
+               /* Just copy in the new address */
+               memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+       } else {
+               /* Rehash and update the device filters */
+               if (macvlan_addr_busy(vlan->port, addr->sa_data))
+                       return -EBUSY;
 
-       err = dev_unicast_add(lowerdev, addr->sa_data, ETH_ALEN);
-       if (err < 0)
-               return err;
-       dev_unicast_delete(lowerdev, dev->dev_addr, ETH_ALEN);
+               err = dev_unicast_add(lowerdev, addr->sa_data);
+               if (err)
+                       return err;
 
-out:
-       memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+               dev_unicast_delete(lowerdev, dev->dev_addr);
+
+               macvlan_hash_change_addr(vlan, addr->sa_data);
+       }
        return 0;
 }
 
@@ -268,6 +355,7 @@ static int macvlan_change_mtu(struct net_device *dev, int new_mtu)
  * separate class since they always nest.
  */
 static struct lock_class_key macvlan_netdev_xmit_lock_key;
+static struct lock_class_key macvlan_netdev_addr_lock_key;
 
 #define MACVLAN_FEATURES \
        (NETIF_F_SG | NETIF_F_ALL_CSUM | NETIF_F_HIGHDMA | NETIF_F_FRAGLIST | \
@@ -277,6 +365,21 @@ static struct lock_class_key macvlan_netdev_xmit_lock_key;
 #define MACVLAN_STATE_MASK \
        ((1<<__LINK_STATE_NOCARRIER) | (1<<__LINK_STATE_DORMANT))
 
+static void macvlan_set_lockdep_class_one(struct net_device *dev,
+                                         struct netdev_queue *txq,
+                                         void *_unused)
+{
+       lockdep_set_class(&txq->_xmit_lock,
+                         &macvlan_netdev_xmit_lock_key);
+}
+
+static void macvlan_set_lockdep_class(struct net_device *dev)
+{
+       lockdep_set_class(&dev->addr_list_lock,
+                         &macvlan_netdev_addr_lock_key);
+       netdev_for_each_tx_queue(dev, macvlan_set_lockdep_class_one, NULL);
+}
+
 static int macvlan_init(struct net_device *dev)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
@@ -286,11 +389,51 @@ static int macvlan_init(struct net_device *dev)
                                  (lowerdev->state & MACVLAN_STATE_MASK);
        dev->features           = lowerdev->features & MACVLAN_FEATURES;
        dev->iflink             = lowerdev->ifindex;
+       dev->hard_header_len    = lowerdev->hard_header_len;
+
+       macvlan_set_lockdep_class(dev);
+
+       vlan->rx_stats = alloc_percpu(struct macvlan_rx_stats);
+       if (!vlan->rx_stats)
+               return -ENOMEM;
 
-       lockdep_set_class(&dev->_xmit_lock, &macvlan_netdev_xmit_lock_key);
        return 0;
 }
 
+static void macvlan_uninit(struct net_device *dev)
+{
+       struct macvlan_dev *vlan = netdev_priv(dev);
+
+       free_percpu(vlan->rx_stats);
+}
+
+static struct net_device_stats *macvlan_dev_get_stats(struct net_device *dev)
+{
+       struct net_device_stats *stats = &dev->stats;
+       struct macvlan_dev *vlan = netdev_priv(dev);
+
+       dev_txq_stats_fold(dev, stats);
+
+       if (vlan->rx_stats) {
+               struct macvlan_rx_stats *p, rx = {0};
+               int i;
+
+               for_each_possible_cpu(i) {
+                       p = per_cpu_ptr(vlan->rx_stats, i);
+                       rx.rx_packets += p->rx_packets;
+                       rx.rx_bytes   += p->rx_bytes;
+                       rx.rx_errors  += p->rx_errors;
+                       rx.multicast  += p->multicast;
+               }
+               stats->rx_packets = rx.rx_packets;
+               stats->rx_bytes   = rx.rx_bytes;
+               stats->rx_errors  = rx.rx_errors;
+               stats->rx_dropped = rx.rx_errors;
+               stats->multicast  = rx.multicast;
+       }
+       return stats;
+}
+
 static void macvlan_ethtool_get_drvinfo(struct net_device *dev,
                                        struct ethtool_drvinfo *drvinfo)
 {
@@ -301,31 +444,50 @@ static void macvlan_ethtool_get_drvinfo(struct net_device *dev,
 static u32 macvlan_ethtool_get_rx_csum(struct net_device *dev)
 {
        const struct macvlan_dev *vlan = netdev_priv(dev);
-       struct net_device *lowerdev = vlan->lowerdev;
+       return dev_ethtool_get_rx_csum(vlan->lowerdev);
+}
 
-       if (lowerdev->ethtool_ops->get_rx_csum == NULL)
-               return 0;
-       return lowerdev->ethtool_ops->get_rx_csum(lowerdev);
+static int macvlan_ethtool_get_settings(struct net_device *dev,
+                                       struct ethtool_cmd *cmd)
+{
+       const struct macvlan_dev *vlan = netdev_priv(dev);
+       return dev_ethtool_get_settings(vlan->lowerdev, cmd);
+}
+
+static u32 macvlan_ethtool_get_flags(struct net_device *dev)
+{
+       const struct macvlan_dev *vlan = netdev_priv(dev);
+       return dev_ethtool_get_flags(vlan->lowerdev);
 }
 
 static const struct ethtool_ops macvlan_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
+       .get_settings           = macvlan_ethtool_get_settings,
        .get_rx_csum            = macvlan_ethtool_get_rx_csum,
        .get_drvinfo            = macvlan_ethtool_get_drvinfo,
+       .get_flags              = macvlan_ethtool_get_flags,
+};
+
+static const struct net_device_ops macvlan_netdev_ops = {
+       .ndo_init               = macvlan_init,
+       .ndo_uninit             = macvlan_uninit,
+       .ndo_open               = macvlan_open,
+       .ndo_stop               = macvlan_stop,
+       .ndo_start_xmit         = macvlan_start_xmit,
+       .ndo_change_mtu         = macvlan_change_mtu,
+       .ndo_change_rx_flags    = macvlan_change_rx_flags,
+       .ndo_set_mac_address    = macvlan_set_mac_address,
+       .ndo_set_multicast_list = macvlan_set_multicast_list,
+       .ndo_get_stats          = macvlan_dev_get_stats,
+       .ndo_validate_addr      = eth_validate_addr,
 };
 
 static void macvlan_setup(struct net_device *dev)
 {
        ether_setup(dev);
 
-       dev->init               = macvlan_init;
-       dev->open               = macvlan_open;
-       dev->stop               = macvlan_stop;
-       dev->change_mtu         = macvlan_change_mtu;
-       dev->change_rx_flags    = macvlan_change_rx_flags;
-       dev->set_mac_address    = macvlan_set_mac_address;
-       dev->set_multicast_list = macvlan_set_multicast_list;
-       dev->hard_start_xmit    = macvlan_hard_start_xmit;
+       dev->priv_flags        &= ~IFF_XMIT_DST_RELEASE;
+       dev->netdev_ops         = &macvlan_netdev_ops;
        dev->destructor         = free_netdev;
        dev->header_ops         = &macvlan_hard_header_ops,
        dev->ethtool_ops        = &macvlan_ethtool_ops;
@@ -391,7 +553,26 @@ static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[])
        return 0;
 }
 
-static int macvlan_newlink(struct net_device *dev,
+static int macvlan_get_tx_queues(struct net *net,
+                                struct nlattr *tb[],
+                                unsigned int *num_tx_queues,
+                                unsigned int *real_num_tx_queues)
+{
+       struct net_device *real_dev;
+
+       if (!tb[IFLA_LINK])
+               return -EINVAL;
+
+       real_dev = __dev_get_by_index(net, nla_get_u32(tb[IFLA_LINK]));
+       if (!real_dev)
+               return -ENODEV;
+
+       *num_tx_queues      = real_dev->num_tx_queues;
+       *real_num_tx_queues = real_dev->real_num_tx_queues;
+       return 0;
+}
+
+static int macvlan_newlink(struct net *src_net, struct net_device *dev,
                           struct nlattr *tb[], struct nlattr *data[])
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
@@ -402,16 +583,17 @@ static int macvlan_newlink(struct net_device *dev,
        if (!tb[IFLA_LINK])
                return -EINVAL;
 
-       lowerdev = __dev_get_by_index(dev_net(dev), nla_get_u32(tb[IFLA_LINK]));
+       lowerdev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK]));
        if (lowerdev == NULL)
                return -ENODEV;
 
-       /* Don't allow macvlans on top of other macvlans - its not really
-        * wrong, but lockdep can't handle it and its not useful for anything
-        * you couldn't do directly on top of the real device.
+       /* When creating macvlans on top of other macvlans - use
+        * the real device as the lowerdev.
         */
-       if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops)
-               return -ENODEV;
+       if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops) {
+               struct macvlan_dev *lowervlan = netdev_priv(lowerdev);
+               lowerdev = lowervlan->lowerdev;
+       }
 
        if (!tb[IFLA_MTU])
                dev->mtu = lowerdev->mtu;
@@ -441,21 +623,22 @@ static int macvlan_newlink(struct net_device *dev,
        return 0;
 }
 
-static void macvlan_dellink(struct net_device *dev)
+static void macvlan_dellink(struct net_device *dev, struct list_head *head)
 {
        struct macvlan_dev *vlan = netdev_priv(dev);
        struct macvlan_port *port = vlan->port;
 
        list_del(&vlan->list);
-       unregister_netdevice(dev);
+       unregister_netdevice_queue(dev, head);
 
        if (list_empty(&port->vlans))
-               macvlan_port_destroy(dev);
+               macvlan_port_destroy(port->dev);
 }
 
 static struct rtnl_link_ops macvlan_link_ops __read_mostly = {
        .kind           = "macvlan",
        .priv_size      = sizeof(struct macvlan_dev),
+       .get_tx_queues  = macvlan_get_tx_queues,
        .setup          = macvlan_setup,
        .validate       = macvlan_validate,
        .newlink        = macvlan_newlink,
@@ -486,7 +669,7 @@ static int macvlan_device_event(struct notifier_block *unused,
                break;
        case NETDEV_UNREGISTER:
                list_for_each_entry_safe(vlan, next, &port->vlans, list)
-                       macvlan_dellink(vlan->dev);
+                       macvlan_dellink(vlan->dev, NULL);
                break;
        }
        return NOTIFY_DONE;