Merge branch 'topic/core-cleanup' into for-linus
[safe/jmp/linux-2.6] / drivers / net / arm / ep93xx_eth.c
index 2fc8b2a..cd17d09 100644 (file)
@@ -9,6 +9,8 @@
  * (at your option) any later version.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
+
 #include <linux/dma-mapping.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/moduleparam.h>
 #include <linux/platform_device.h>
 #include <linux/delay.h>
-#include <asm/arch/ep93xx-regs.h>
-#include <asm/arch/platform.h>
-#include <asm/io.h>
+#include <linux/io.h>
+#include <linux/slab.h>
+
+#include <mach/hardware.h>
 
 #define DRV_MODULE_NAME                "ep93xx-eth"
 #define DRV_MODULE_VERSION     "0.1"
@@ -153,7 +156,7 @@ struct ep93xx_descs
 struct ep93xx_priv
 {
        struct resource         *res;
-       void                    *base_addr;
+       void __iomem            *base_addr;
        int                     irq;
 
        struct ep93xx_descs     *descs;
@@ -169,6 +172,9 @@ struct ep93xx_priv
        spinlock_t              tx_pending_lock;
        unsigned int            tx_pending;
 
+       struct net_device       *dev;
+       struct napi_struct      napi;
+
        struct net_device_stats stats;
 
        struct mii_if_info      mii;
@@ -182,7 +188,47 @@ struct ep93xx_priv
 #define wrw(ep, off, val)      __raw_writew((val), (ep)->base_addr + (off))
 #define wrl(ep, off, val)      __raw_writel((val), (ep)->base_addr + (off))
 
-static int ep93xx_mdio_read(struct net_device *dev, int phy_id, int reg);
+static int ep93xx_mdio_read(struct net_device *dev, int phy_id, int reg)
+{
+       struct ep93xx_priv *ep = netdev_priv(dev);
+       int data;
+       int i;
+
+       wrl(ep, REG_MIICMD, REG_MIICMD_READ | (phy_id << 5) | reg);
+
+       for (i = 0; i < 10; i++) {
+               if ((rdl(ep, REG_MIISTS) & REG_MIISTS_BUSY) == 0)
+                       break;
+               msleep(1);
+       }
+
+       if (i == 10) {
+               pr_info("mdio read timed out\n");
+               data = 0xffff;
+       } else {
+               data = rdl(ep, REG_MIIDATA);
+       }
+
+       return data;
+}
+
+static void ep93xx_mdio_write(struct net_device *dev, int phy_id, int reg, int data)
+{
+       struct ep93xx_priv *ep = netdev_priv(dev);
+       int i;
+
+       wrl(ep, REG_MIIDATA, data);
+       wrl(ep, REG_MIICMD, REG_MIICMD_WRITE | (phy_id << 5) | reg);
+
+       for (i = 0; i < 10; i++) {
+               if ((rdl(ep, REG_MIISTS) & REG_MIISTS_BUSY) == 0)
+                       break;
+               msleep(1);
+       }
+
+       if (i == 10)
+               pr_info("mdio write timed out\n");
+}
 
 static struct net_device_stats *ep93xx_get_stats(struct net_device *dev)
 {
@@ -190,15 +236,11 @@ static struct net_device_stats *ep93xx_get_stats(struct net_device *dev)
        return &(ep->stats);
 }
 
-static int ep93xx_rx(struct net_device *dev, int *budget)
+static int ep93xx_rx(struct net_device *dev, int processed, int budget)
 {
        struct ep93xx_priv *ep = netdev_priv(dev);
-       int rx_done;
-       int processed;
 
-       rx_done = 0;
-       processed = 0;
-       while (*budget > 0) {
+       while (processed < budget) {
                int entry;
                struct ep93xx_rstat *rstat;
                u32 rstat0;
@@ -211,28 +253,20 @@ static int ep93xx_rx(struct net_device *dev, int *budget)
 
                rstat0 = rstat->rstat0;
                rstat1 = rstat->rstat1;
-               if (!(rstat0 & RSTAT0_RFP) || !(rstat1 & RSTAT1_RFP)) {
-                       rx_done = 1;
+               if (!(rstat0 & RSTAT0_RFP) || !(rstat1 & RSTAT1_RFP))
                        break;
-               }
 
                rstat->rstat0 = 0;
                rstat->rstat1 = 0;
 
                if (!(rstat0 & RSTAT0_EOF))
-                       printk(KERN_CRIT "ep93xx_rx: not end-of-frame "
-                                        " %.8x %.8x\n", rstat0, rstat1);
+                       pr_crit("not end-of-frame %.8x %.8x\n", rstat0, rstat1);
                if (!(rstat0 & RSTAT0_EOB))
-                       printk(KERN_CRIT "ep93xx_rx: not end-of-buffer "
-                                        " %.8x %.8x\n", rstat0, rstat1);
+                       pr_crit("not end-of-buffer %.8x %.8x\n", rstat0, rstat1);
                if ((rstat1 & RSTAT1_BUFFER_INDEX) >> 16 != entry)
-                       printk(KERN_CRIT "ep93xx_rx: entry mismatch "
-                                        " %.8x %.8x\n", rstat0, rstat1);
+                       pr_crit("entry mismatch %.8x %.8x\n", rstat0, rstat1);
 
                if (!(rstat0 & RSTAT0_RWE)) {
-                       printk(KERN_NOTICE "ep93xx_rx: receive error "
-                                        " %.8x %.8x\n", rstat0, rstat1);
-
                        ep->stats.rx_errors++;
                        if (rstat0 & RSTAT0_OE)
                                ep->stats.rx_fifo_errors++;
@@ -247,8 +281,7 @@ static int ep93xx_rx(struct net_device *dev, int *budget)
 
                length = rstat1 & RSTAT1_FRAME_LENGTH;
                if (length > MAX_PKT_SIZE) {
-                       printk(KERN_NOTICE "ep93xx_rx: invalid length "
-                                        " %.8x %.8x\n", rstat0, rstat1);
+                       pr_notice("invalid length %.8x %.8x\n", rstat0, rstat1);
                        goto err;
                }
 
@@ -258,16 +291,13 @@ static int ep93xx_rx(struct net_device *dev, int *budget)
 
                skb = dev_alloc_skb(length + 2);
                if (likely(skb != NULL)) {
-                       skb->dev = dev;
                        skb_reserve(skb, 2);
-                       dma_sync_single(NULL, ep->descs->rdesc[entry].buf_addr,
+                       dma_sync_single_for_cpu(NULL, ep->descs->rdesc[entry].buf_addr,
                                                length, DMA_FROM_DEVICE);
-                       eth_copy_and_sum(skb, ep->rx_buf[entry], length, 0);
+                       skb_copy_to_linear_data(skb, ep->rx_buf[entry], length);
                        skb_put(skb, length);
                        skb->protocol = eth_type_trans(skb, dev);
 
-                       dev->last_rx = jiffies;
-
                        netif_receive_skb(skb);
 
                        ep->stats.rx_packets++;
@@ -279,16 +309,9 @@ static int ep93xx_rx(struct net_device *dev, int *budget)
 err:
                ep->rx_pointer = (entry + 1) & (RX_QUEUE_ENTRIES - 1);
                processed++;
-               dev->quota--;
-               (*budget)--;
        }
 
-       if (processed) {
-               wrw(ep, REG_RXDENQ, processed);
-               wrw(ep, REG_RXSTSENQ, processed);
-       }
-
-       return !rx_done;
+       return processed;
 }
 
 static int ep93xx_have_more_rx(struct ep93xx_priv *ep)
@@ -297,36 +320,37 @@ static int ep93xx_have_more_rx(struct ep93xx_priv *ep)
        return !!((rstat->rstat0 & RSTAT0_RFP) && (rstat->rstat1 & RSTAT1_RFP));
 }
 
-static int ep93xx_poll(struct net_device *dev, int *budget)
+static int ep93xx_poll(struct napi_struct *napi, int budget)
 {
-       struct ep93xx_priv *ep = netdev_priv(dev);
-
-       /*
-        * @@@ Have to stop polling if device is downed while we
-        * are polling.
-        */
+       struct ep93xx_priv *ep = container_of(napi, struct ep93xx_priv, napi);
+       struct net_device *dev = ep->dev;
+       int rx = 0;
 
 poll_some_more:
-       if (ep93xx_rx(dev, budget))
-               return 1;
-
-       netif_rx_complete(dev);
-
-       spin_lock_irq(&ep->rx_lock);
-       wrl(ep, REG_INTEN, REG_INTEN_TX | REG_INTEN_RX);
-       if (ep93xx_have_more_rx(ep)) {
-               wrl(ep, REG_INTEN, REG_INTEN_TX);
-               wrl(ep, REG_INTSTSP, REG_INTSTS_RX);
+       rx = ep93xx_rx(dev, rx, budget);
+       if (rx < budget) {
+               int more = 0;
+
+               spin_lock_irq(&ep->rx_lock);
+               __napi_complete(napi);
+               wrl(ep, REG_INTEN, REG_INTEN_TX | REG_INTEN_RX);
+               if (ep93xx_have_more_rx(ep)) {
+                       wrl(ep, REG_INTEN, REG_INTEN_TX);
+                       wrl(ep, REG_INTSTSP, REG_INTSTS_RX);
+                       more = 1;
+               }
                spin_unlock_irq(&ep->rx_lock);
 
-               if (netif_rx_reschedule(dev, 0))
+               if (more && napi_reschedule(napi))
                        goto poll_some_more;
+       }
 
-               return 0;
+       if (rx) {
+               wrw(ep, REG_RXDENQ, rx);
+               wrw(ep, REG_RXSTSENQ, rx);
        }
-       spin_unlock_irq(&ep->rx_lock);
 
-       return 0;
+       return rx;
 }
 
 static int ep93xx_xmit(struct sk_buff *skb, struct net_device *dev)
@@ -334,7 +358,7 @@ static int ep93xx_xmit(struct sk_buff *skb, struct net_device *dev)
        struct ep93xx_priv *ep = netdev_priv(dev);
        int entry;
 
-       if (unlikely(skb->len) > MAX_PKT_SIZE) {
+       if (unlikely(skb->len > MAX_PKT_SIZE)) {
                ep->stats.tx_dropped++;
                dev_kfree_skb(skb);
                return NETDEV_TX_OK;
@@ -346,7 +370,7 @@ static int ep93xx_xmit(struct sk_buff *skb, struct net_device *dev)
        ep->descs->tdesc[entry].tdesc1 =
                TDESC1_EOF | (entry << 16) | (skb->len & 0xfff);
        skb_copy_and_csum_dev(skb, ep->tx_buf[entry]);
-       dma_sync_single(NULL, ep->descs->tdesc[entry].buf_addr,
+       dma_sync_single_for_cpu(NULL, ep->descs->tdesc[entry].buf_addr,
                                skb->len, DMA_TO_DEVICE);
        dev_kfree_skb(skb);
 
@@ -386,11 +410,9 @@ static void ep93xx_tx_complete(struct net_device *dev)
                tstat->tstat0 = 0;
 
                if (tstat0 & TSTAT0_FA)
-                       printk(KERN_CRIT "ep93xx_tx_complete: frame aborted "
-                                        " %.8x\n", tstat0);
+                       pr_crit("frame aborted %.8x\n", tstat0);
                if ((tstat0 & TSTAT0_BUFFER_INDEX) != entry)
-                       printk(KERN_CRIT "ep93xx_tx_complete: entry mismatch "
-                                        " %.8x\n", tstat0);
+                       pr_crit("entry mismatch %.8x\n", tstat0);
 
                if (tstat0 & TSTAT0_TXWE) {
                        int length = ep->descs->tdesc[entry].tdesc1 & 0xfff;
@@ -430,9 +452,9 @@ static irqreturn_t ep93xx_irq(int irq, void *dev_id)
 
        if (status & REG_INTSTS_RX) {
                spin_lock(&ep->rx_lock);
-               if (likely(__netif_rx_schedule_prep(dev))) {
+               if (likely(napi_schedule_prep(&ep->napi))) {
                        wrl(ep, REG_INTEN, REG_INTEN_TX);
-                       __netif_rx_schedule(dev);
+                       __napi_schedule(&ep->napi);
                }
                spin_unlock(&ep->rx_lock);
        }
@@ -495,7 +517,7 @@ static int ep93xx_alloc_buffers(struct ep93xx_priv *ep)
                        goto err;
 
                d = dma_map_single(NULL, page, PAGE_SIZE, DMA_FROM_DEVICE);
-               if (dma_mapping_error(d)) {
+               if (dma_mapping_error(NULL, d)) {
                        free_page((unsigned long)page);
                        goto err;
                }
@@ -518,7 +540,7 @@ static int ep93xx_alloc_buffers(struct ep93xx_priv *ep)
                        goto err;
 
                d = dma_map_single(NULL, page, PAGE_SIZE, DMA_TO_DEVICE);
-               if (dma_mapping_error(d)) {
+               if (dma_mapping_error(NULL, d)) {
                        free_page((unsigned long)page);
                        goto err;
                }
@@ -551,7 +573,7 @@ static int ep93xx_start_hw(struct net_device *dev)
        }
 
        if (i == 10) {
-               printk(KERN_CRIT DRV_MODULE_NAME ": hw failed to reset\n");
+               pr_crit("hw failed to reset\n");
                return 1;
        }
 
@@ -596,7 +618,7 @@ static int ep93xx_start_hw(struct net_device *dev)
        }
 
        if (i == 10) {
-               printk(KERN_CRIT DRV_MODULE_NAME ": hw failed to start\n");
+               pr_crit("hw failed to start\n");
                return 1;
        }
 
@@ -632,7 +654,7 @@ static void ep93xx_stop_hw(struct net_device *dev)
        }
 
        if (i == 10)
-               printk(KERN_CRIT DRV_MODULE_NAME ": hw failed to reset\n");
+               pr_crit("hw failed to reset\n");
 }
 
 static int ep93xx_open(struct net_device *dev)
@@ -643,16 +665,10 @@ static int ep93xx_open(struct net_device *dev)
        if (ep93xx_alloc_buffers(ep))
                return -ENOMEM;
 
-       if (is_zero_ether_addr(dev->dev_addr)) {
-               random_ether_addr(dev->dev_addr);
-               printk(KERN_INFO "%s: generated random MAC address "
-                       "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x.\n", dev->name,
-                       dev->dev_addr[0], dev->dev_addr[1],
-                       dev->dev_addr[2], dev->dev_addr[3],
-                       dev->dev_addr[4], dev->dev_addr[5]);
-       }
+       napi_enable(&ep->napi);
 
        if (ep93xx_start_hw(dev)) {
+               napi_disable(&ep->napi);
                ep93xx_free_buffers(ep);
                return -EIO;
        }
@@ -666,6 +682,7 @@ static int ep93xx_open(struct net_device *dev)
 
        err = request_irq(ep->irq, ep93xx_irq, IRQF_SHARED, dev->name, dev);
        if (err) {
+               napi_disable(&ep->napi);
                ep93xx_stop_hw(dev);
                ep93xx_free_buffers(ep);
                return err;
@@ -682,6 +699,7 @@ static int ep93xx_close(struct net_device *dev)
 {
        struct ep93xx_priv *ep = netdev_priv(dev);
 
+       napi_disable(&ep->napi);
        netif_stop_queue(dev);
 
        wrl(ep, REG_GIINTMSK, 0);
@@ -700,48 +718,6 @@ static int ep93xx_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        return generic_mii_ioctl(&ep->mii, data, cmd, NULL);
 }
 
-static int ep93xx_mdio_read(struct net_device *dev, int phy_id, int reg)
-{
-       struct ep93xx_priv *ep = netdev_priv(dev);
-       int data;
-       int i;
-
-       wrl(ep, REG_MIICMD, REG_MIICMD_READ | (phy_id << 5) | reg);
-
-       for (i = 0; i < 10; i++) {
-               if ((rdl(ep, REG_MIISTS) & REG_MIISTS_BUSY) == 0)
-                       break;
-               msleep(1);
-       }
-
-       if (i == 10) {
-               printk(KERN_INFO DRV_MODULE_NAME ": mdio read timed out\n");
-               data = 0xffff;
-       } else {
-               data = rdl(ep, REG_MIIDATA);
-       }
-
-       return data;
-}
-
-static void ep93xx_mdio_write(struct net_device *dev, int phy_id, int reg, int data)
-{
-       struct ep93xx_priv *ep = netdev_priv(dev);
-       int i;
-
-       wrl(ep, REG_MIIDATA, data);
-       wrl(ep, REG_MIICMD, REG_MIICMD_WRITE | (phy_id << 5) | reg);
-
-       for (i = 0; i < 10; i++) {
-               if ((rdl(ep, REG_MIISTS) & REG_MIISTS_BUSY) == 0)
-                       break;
-               msleep(1);
-       }
-
-       if (i == 10)
-               printk(KERN_INFO DRV_MODULE_NAME ": mdio write timed out\n");
-}
-
 static void ep93xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
        strcpy(info->driver, DRV_MODULE_NAME);
@@ -772,7 +748,7 @@ static u32 ep93xx_get_link(struct net_device *dev)
        return mii_link_ok(&ep->mii);
 }
 
-static struct ethtool_ops ep93xx_ethtool_ops = {
+static const struct ethtool_ops ep93xx_ethtool_ops = {
        .get_drvinfo            = ep93xx_get_drvinfo,
        .get_settings           = ep93xx_get_settings,
        .set_settings           = ep93xx_set_settings,
@@ -780,28 +756,31 @@ static struct ethtool_ops ep93xx_ethtool_ops = {
        .get_link               = ep93xx_get_link,
 };
 
-struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data)
+static const struct net_device_ops ep93xx_netdev_ops = {
+       .ndo_open               = ep93xx_open,
+       .ndo_stop               = ep93xx_close,
+       .ndo_start_xmit         = ep93xx_xmit,
+       .ndo_get_stats          = ep93xx_get_stats,
+       .ndo_do_ioctl           = ep93xx_ioctl,
+       .ndo_validate_addr      = eth_validate_addr,
+       .ndo_change_mtu         = eth_change_mtu,
+       .ndo_set_mac_address    = eth_mac_addr,
+};
+
+static struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data)
 {
        struct net_device *dev;
-       struct ep93xx_priv *ep;
 
        dev = alloc_etherdev(sizeof(struct ep93xx_priv));
        if (dev == NULL)
                return NULL;
-       ep = netdev_priv(dev);
 
        memcpy(dev->dev_addr, data->dev_addr, ETH_ALEN);
 
-       dev->get_stats = ep93xx_get_stats;
        dev->ethtool_ops = &ep93xx_ethtool_ops;
-       dev->poll = ep93xx_poll;
-       dev->hard_start_xmit = ep93xx_xmit;
-       dev->open = ep93xx_open;
-       dev->stop = ep93xx_close;
-       dev->do_ioctl = ep93xx_ioctl;
+       dev->netdev_ops = &ep93xx_netdev_ops;
 
        dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
-       dev->weight = 64;
 
        return dev;
 }
@@ -841,11 +820,18 @@ static int ep93xx_eth_probe(struct platform_device *pdev)
        struct ep93xx_eth_data *data;
        struct net_device *dev;
        struct ep93xx_priv *ep;
+       struct resource *mem;
+       int irq;
        int err;
 
-       data = pdev->dev.platform_data;
        if (pdev == NULL)
                return -ENODEV;
+       data = pdev->dev.platform_data;
+
+       mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       irq = platform_get_irq(pdev, 0);
+       if (!mem || irq < 0)
+               return -ENXIO;
 
        dev = ep93xx_dev_alloc(data);
        if (dev == NULL) {
@@ -853,26 +839,26 @@ static int ep93xx_eth_probe(struct platform_device *pdev)
                goto err_out;
        }
        ep = netdev_priv(dev);
+       ep->dev = dev;
+       netif_napi_add(dev, &ep->napi, ep93xx_poll, 64);
 
        platform_set_drvdata(pdev, dev);
 
-       ep->res = request_mem_region(pdev->resource[0].start,
-                       pdev->resource[0].end - pdev->resource[0].start + 1,
-                       pdev->dev.bus_id);
+       ep->res = request_mem_region(mem->start, resource_size(mem),
+                                    dev_name(&pdev->dev));
        if (ep->res == NULL) {
                dev_err(&pdev->dev, "Could not reserve memory region\n");
                err = -ENOMEM;
                goto err_out;
        }
 
-       ep->base_addr = ioremap(pdev->resource[0].start,
-                       pdev->resource[0].end - pdev->resource[0].start);
+       ep->base_addr = ioremap(mem->start, resource_size(mem));
        if (ep->base_addr == NULL) {
                dev_err(&pdev->dev, "Failed to ioremap ethernet registers\n");
                err = -EIO;
                goto err_out;
        }
-       ep->irq = pdev->resource[1].start;
+       ep->irq = irq;
 
        ep->mii.phy_id = data->phy_id;
        ep->mii.phy_id_mask = 0x1f;
@@ -882,17 +868,17 @@ static int ep93xx_eth_probe(struct platform_device *pdev)
        ep->mii.mdio_write = ep93xx_mdio_write;
        ep->mdc_divisor = 40;   /* Max HCLK 100 MHz, min MDIO clk 2.5 MHz.  */
 
+       if (is_zero_ether_addr(dev->dev_addr))
+               random_ether_addr(dev->dev_addr);
+
        err = register_netdev(dev);
        if (err) {
                dev_err(&pdev->dev, "Failed to register netdev\n");
                goto err_out;
        }
 
-       printk(KERN_INFO "%s: ep93xx on-chip ethernet, IRQ %d, "
-                        "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x.\n", dev->name,
-                       ep->irq, data->dev_addr[0], data->dev_addr[1],
-                       data->dev_addr[2], data->dev_addr[3],
-                       data->dev_addr[4], data->dev_addr[5]);
+       printk(KERN_INFO "%s: ep93xx on-chip ethernet, IRQ %d, %pM\n",
+                       dev->name, ep->irq, dev->dev_addr);
 
        return 0;
 
@@ -907,6 +893,7 @@ static struct platform_driver ep93xx_eth_driver = {
        .remove         = ep93xx_eth_remove,
        .driver         = {
                .name   = "ep93xx-eth",
+               .owner  = THIS_MODULE,
        },
 };
 
@@ -924,3 +911,4 @@ static void __exit ep93xx_eth_cleanup_module(void)
 module_init(ep93xx_eth_init_module);
 module_exit(ep93xx_eth_cleanup_module);
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:ep93xx-eth");