include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit...
[safe/jmp/linux-2.6] / drivers / media / video / msp3400-kthreads.c
index 972f2c8..d5a69c5 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA.
  */
 
 
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/slab.h>
 #include <linux/i2c.h>
-#include <linux/videodev.h>
+#include <linux/freezer.h>
 #include <linux/videodev2.h>
 #include <media/v4l2-common.h>
+#include <media/msp3400.h>
 #include <linux/kthread.h>
 #include <linux/suspend.h>
-#include "msp3400.h"
+#include "msp3400-driver.h"
 
 /* this one uses the automatic sound standard detection of newer msp34xx
    chip versions */
@@ -44,11 +45,13 @@ static struct {
        { 0x0004, MSP_CARRIER(6.5), MSP_CARRIER(6.2578125), "6.5/6.25  D/K1 Dual FM-Stereo" },
        { 0x0005, MSP_CARRIER(6.5), MSP_CARRIER(6.7421875), "6.5/6.74  D/K2 Dual FM-Stereo" },
        { 0x0006, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  D/K FM-Mono (HDEV3)" },
+       { 0x0007, MSP_CARRIER(6.5), MSP_CARRIER(5.7421875), "6.5/5.74  D/K3 Dual FM-Stereo" },
        { 0x0008, MSP_CARRIER(5.5), MSP_CARRIER(5.85), "5.5/5.85  B/G NICAM FM" },
        { 0x0009, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  L NICAM AM" },
        { 0x000a, MSP_CARRIER(6.0), MSP_CARRIER(6.55), "6.0/6.55  I NICAM FM" },
        { 0x000b, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM" },
        { 0x000c, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV2)" },
+       { 0x000d, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV3)" },
        { 0x0020, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Stereo" },
        { 0x0021, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Mono + SAP" },
        { 0x0030, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M EIA-J Japan Stereo" },
@@ -74,37 +77,37 @@ static struct msp3400c_init_data_dem {
                {75, 19, 36, 35, 39, 40},
                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
                0x00d0, 0x0500, 0x0020, 0x3000
-       },    /* AM (for carrier detect / msp3410) */
+       }, {    /* AM (for carrier detect / msp3410) */
                {-1, -1, -8, 2, 59, 126},
                {-1, -1, -8, 2, 59, 126},
                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
                0x00d0, 0x0100, 0x0020, 0x3000
-       },    /* FM Radio */
+       }, {    /* FM Radio */
                {-8, -8, 4, 6, 78, 107},
                {-8, -8, 4, 6, 78, 107},
                MSP_CARRIER(10.7), MSP_CARRIER(10.7),
                0x00d0, 0x0480, 0x0020, 0x3000
-       },    /* Terrestial FM-mono + FM-stereo */
+       }, {    /* Terrestial FM-mono + FM-stereo */
                {3, 18, 27, 48, 66, 72},
                {3, 18, 27, 48, 66, 72},
                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
                0x00d0, 0x0480, 0x0030, 0x3000
-       },    /* Sat FM-mono */
+       }, {    /* Sat FM-mono */
                { 1, 9, 14, 24, 33, 37},
                { 3, 18, 27, 48, 66, 72},
                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
                0x00c6, 0x0480, 0x0000, 0x3000
-       },    /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
+       }, {    /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
                {-2, -8, -10, 10, 50, 86},
                {3, 18, 27, 48, 66, 72},
                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
                0x00d0, 0x0040, 0x0120, 0x3000
-       },    /* NICAM/FM -- I (6.0/6.552) */
+       }, {    /* NICAM/FM -- I (6.0/6.552) */
                {2, 4, -6, -4, 40, 94},
                {3, 18, 27, 48, 66, 72},
                MSP_CARRIER(6.0), MSP_CARRIER(6.0),
                0x00d0, 0x0040, 0x0120, 0x3000
-       },    /* NICAM/AM -- L (6.5/5.85) */
+       }, {    /* NICAM/AM -- L (6.5/5.85) */
                {-2, -8, -10, 10, 50, 86},
                {-4, -12, -9, 23, 79, 126},
                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
@@ -155,7 +158,7 @@ const char *msp_standard_std_name(int std)
 
 static void msp_set_source(struct i2c_client *client, u16 src)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
 
        if (msp_dolby) {
                msp_write_dsp(client, 0x0008, 0x0520); /* I2S1 */
@@ -167,7 +170,7 @@ static void msp_set_source(struct i2c_client *client, u16 src)
        msp_write_dsp(client, 0x000a, src);
        msp_write_dsp(client, 0x000b, src);
        msp_write_dsp(client, 0x000c, src);
-       if (state->has_scart23_in_scart2_out)
+       if (state->has_scart2_out)
                msp_write_dsp(client, 0x0041, src);
 }
 
@@ -182,15 +185,16 @@ void msp3400c_set_carrier(struct i2c_client *client, int cdo1, int cdo2)
 
 void msp3400c_set_mode(struct i2c_client *client, int mode)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
        struct msp3400c_init_data_dem *data = &msp3400c_init_data[mode];
+       int tuner = (state->route_in >> 3) & 1;
        int i;
 
        v4l_dbg(1, msp_debug, client, "set_mode: %d\n", mode);
        state->mode = mode;
        state->rxsubchans = V4L2_TUNER_SUB_MONO;
 
-       msp_write_dem(client, 0x00bb, data->ad_cv);
+       msp_write_dem(client, 0x00bb, data->ad_cv | (tuner ? 0x100 : 0));
 
        for (i = 5; i >= 0; i--)               /* fir 1 */
                msp_write_dem(client, 0x0001, data->fir1[i]);
@@ -206,23 +210,27 @@ void msp3400c_set_mode(struct i2c_client *client, int mode)
        msp3400c_set_carrier(client, data->cdo1, data->cdo2);
 
        msp_set_source(client, data->dsp_src);
-       msp_write_dsp(client, 0x000e, data->dsp_matrix);
+       /* set prescales */
 
-       if (state->has_nicam) {
-               /* nicam prescale */
-               msp_write_dsp(client, 0x0010, 0x5a00); /* was: 0x3000 */
-       }
+       /* volume prescale for SCART (AM mono input) */
+       msp_write_dsp(client, 0x000d, 0x1900);
+       msp_write_dsp(client, 0x000e, data->dsp_matrix);
+       if (state->has_nicam) /* nicam prescale */
+               msp_write_dsp(client, 0x0010, 0x5a00);
 }
 
 /* Set audio mode. Note that the pre-'G' models do not support BTSC+SAP,
    nor do they support stereo BTSC. */
 static void msp3400c_set_audmode(struct i2c_client *client)
 {
-       static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
-       struct msp_state *state = i2c_get_clientdata(client);
-       char *modestr = (state->audmode >= 0 && state->audmode < 4) ?
+       static char *strmode[] = {
+               "mono", "stereo", "lang2", "lang1", "lang1+lang2"
+       };
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       char *modestr = (state->audmode >= 0 && state->audmode < 5) ?
                strmode[state->audmode] : "unknown";
        int src = 0;    /* channel source: FM/AM, nicam or SCART */
+       int audmode = state->audmode;
 
        if (state->opmode == OPMODE_AUTOSELECT) {
                /* this method would break everything, let's make sure
@@ -234,28 +242,50 @@ static void msp3400c_set_audmode(struct i2c_client *client)
                return;
        }
 
+       /* Note: for the C and D revs no NTSC stereo + SAP is possible as
+          the hardware does not support SAP. So the rxsubchans combination
+          of STEREO | LANG2 does not occur. */
+
+       if (state->mode != MSP_MODE_EXTERN) {
+               /* switch to mono if only mono is available */
+               if (state->rxsubchans == V4L2_TUNER_SUB_MONO)
+                       audmode = V4L2_TUNER_MODE_MONO;
+               /* if bilingual */
+               else if (state->rxsubchans & V4L2_TUNER_SUB_LANG2) {
+                       /* and mono or stereo, then fallback to lang1 */
+                       if (audmode == V4L2_TUNER_MODE_MONO ||
+                           audmode == V4L2_TUNER_MODE_STEREO)
+                               audmode = V4L2_TUNER_MODE_LANG1;
+               }
+               /* if stereo, and audmode is not mono, then switch to stereo */
+               else if (audmode != V4L2_TUNER_MODE_MONO)
+                       audmode = V4L2_TUNER_MODE_STEREO;
+       }
+
        /* switch demodulator */
        switch (state->mode) {
        case MSP_MODE_FM_TERRA:
                v4l_dbg(1, msp_debug, client, "FM set_audmode: %s\n", modestr);
-               switch (state->audmode) {
+               switch (audmode) {
                case V4L2_TUNER_MODE_STEREO:
                        msp_write_dsp(client, 0x000e, 0x3001);
                        break;
                case V4L2_TUNER_MODE_MONO:
                case V4L2_TUNER_MODE_LANG1:
                case V4L2_TUNER_MODE_LANG2:
+               case V4L2_TUNER_MODE_LANG1_LANG2:
                        msp_write_dsp(client, 0x000e, 0x3000);
                        break;
                }
                break;
        case MSP_MODE_FM_SAT:
                v4l_dbg(1, msp_debug, client, "SAT set_audmode: %s\n", modestr);
-               switch (state->audmode) {
+               switch (audmode) {
                case V4L2_TUNER_MODE_MONO:
                        msp3400c_set_carrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
                        break;
                case V4L2_TUNER_MODE_STEREO:
+               case V4L2_TUNER_MODE_LANG1_LANG2:
                        msp3400c_set_carrier(client, MSP_CARRIER(7.2), MSP_CARRIER(7.02));
                        break;
                case V4L2_TUNER_MODE_LANG1:
@@ -269,20 +299,23 @@ static void msp3400c_set_audmode(struct i2c_client *client)
        case MSP_MODE_FM_NICAM1:
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
-               v4l_dbg(1, msp_debug, client, "NICAM set_audmode: %s\n",modestr);
-               msp3400c_set_carrier(client, state->second, state->main);
+               v4l_dbg(1, msp_debug, client,
+                       "NICAM set_audmode: %s\n", modestr);
                if (state->nicam_on)
                        src = 0x0100;  /* NICAM */
                break;
        case MSP_MODE_BTSC:
-               v4l_dbg(1, msp_debug, client, "BTSC set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client,
+                       "BTSC set_audmode: %s\n", modestr);
                break;
        case MSP_MODE_EXTERN:
-               v4l_dbg(1, msp_debug, client, "extern set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client,
+                       "extern set_audmode: %s\n", modestr);
                src = 0x0200;  /* SCART */
                break;
        case MSP_MODE_FM_RADIO:
-               v4l_dbg(1, msp_debug, client, "FM-Radio set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client,
+                       "FM-Radio set_audmode: %s\n", modestr);
                break;
        default:
                v4l_dbg(1, msp_debug, client, "mono set_audmode\n");
@@ -290,8 +323,10 @@ static void msp3400c_set_audmode(struct i2c_client *client)
        }
 
        /* switch audio */
-       switch (state->audmode) {
+       v4l_dbg(1, msp_debug, client, "set audmode %d\n", audmode);
+       switch (audmode) {
        case V4L2_TUNER_MODE_STEREO:
+       case V4L2_TUNER_MODE_LANG1_LANG2:
                src |= 0x0020;
                break;
        case V4L2_TUNER_MODE_MONO:
@@ -307,40 +342,41 @@ static void msp3400c_set_audmode(struct i2c_client *client)
                        src = 0x0030;
                break;
        case V4L2_TUNER_MODE_LANG1:
-               /* switch to stereo for stereo transmission, otherwise
-                  keep first language */
-               if (state->rxsubchans & V4L2_TUNER_SUB_STEREO)
-                       src |= 0x0020;
                break;
        case V4L2_TUNER_MODE_LANG2:
                src |= 0x0010;
                break;
        }
-       v4l_dbg(1, msp_debug, client, "set_audmode final source/matrix = 0x%x\n", src);
+       v4l_dbg(1, msp_debug, client,
+               "set_audmode final source/matrix = 0x%x\n", src);
 
        msp_set_source(client, src);
 }
 
 static void msp3400c_print_mode(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
 
-       if (state->main == state->second) {
-               v4l_dbg(1, msp_debug, client, "mono sound carrier: %d.%03d MHz\n",
-                      state->main / 910000, (state->main / 910) % 1000);
-       } else {
-               v4l_dbg(1, msp_debug, client, "main sound carrier: %d.%03d MHz\n",
-                      state->main / 910000, (state->main / 910) % 1000);
-       }
+       if (state->main == state->second)
+               v4l_dbg(1, msp_debug, client,
+                       "mono sound carrier: %d.%03d MHz\n",
+                       state->main / 910000, (state->main / 910) % 1000);
+       else
+               v4l_dbg(1, msp_debug, client,
+                       "main sound carrier: %d.%03d MHz\n",
+                       state->main / 910000, (state->main / 910) % 1000);
        if (state->mode == MSP_MODE_FM_NICAM1 || state->mode == MSP_MODE_FM_NICAM2)
-               v4l_dbg(1, msp_debug, client, "NICAM/FM carrier  : %d.%03d MHz\n",
-                      state->second / 910000, (state->second/910) % 1000);
+               v4l_dbg(1, msp_debug, client,
+                       "NICAM/FM carrier  : %d.%03d MHz\n",
+                       state->second / 910000, (state->second/910) % 1000);
        if (state->mode == MSP_MODE_AM_NICAM)
-               v4l_dbg(1, msp_debug, client, "NICAM/AM carrier  : %d.%03d MHz\n",
-                      state->second / 910000, (state->second / 910) % 1000);
+               v4l_dbg(1, msp_debug, client,
+                       "NICAM/AM carrier  : %d.%03d MHz\n",
+                       state->second / 910000, (state->second / 910) % 1000);
        if (state->mode == MSP_MODE_FM_TERRA && state->main != state->second) {
-               v4l_dbg(1, msp_debug, client, "FM-stereo carrier : %d.%03d MHz\n",
-                      state->second / 910000, (state->second / 910) % 1000);
+               v4l_dbg(1, msp_debug, client,
+                       "FM-stereo carrier : %d.%03d MHz\n",
+                       state->second / 910000, (state->second / 910) % 1000);
        }
 }
 
@@ -348,7 +384,7 @@ static void msp3400c_print_mode(struct i2c_client *client)
 
 static int msp3400c_detect_stereo(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
        int val;
        int rxsubchans = state->rxsubchans;
        int newnicam = state->nicam_on;
@@ -359,8 +395,9 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
                val = msp_read_dsp(client, 0x18);
                if (val > 32767)
                        val -= 65536;
-               v4l_dbg(2, msp_debug, client, "stereo detect register: %d\n", val);
-               if (val > 4096) {
+               v4l_dbg(2, msp_debug, client,
+                       "stereo detect register: %d\n", val);
+               if (val > 8192) {
                        rxsubchans = V4L2_TUNER_SUB_STEREO;
                } else if (val < -4096) {
                        rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
@@ -404,7 +441,8 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
        }
        if (rxsubchans != state->rxsubchans) {
                update = 1;
-               v4l_dbg(1, msp_debug, client, "watch: rxsubchans %02x => %02x\n",
+               v4l_dbg(1, msp_debug, client,
+                       "watch: rxsubchans %02x => %02x\n",
                        state->rxsubchans, rxsubchans);
                state->rxsubchans = rxsubchans;
        }
@@ -424,11 +462,10 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
 /* stereo/multilang monitoring */
 static void watch_stereo(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
 
-       if (msp3400c_detect_stereo(client)) {
-               msp3400c_set_audmode(client);
-       }
+       if (msp_detect_stereo(client))
+               msp_set_audmode(client);
 
        if (msp_once)
                state->watch_stereo = 0;
@@ -437,18 +474,18 @@ static void watch_stereo(struct i2c_client *client)
 int msp3400c_thread(void *data)
 {
        struct i2c_client *client = data;
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
        struct msp3400c_carrier_detect *cd;
-       int count, max1, max2, val1, val2, val, this;
-
+       int count, max1, max2, val1, val2, val, i;
 
        v4l_dbg(1, msp_debug, client, "msp3400 daemon started\n");
+       set_freezable();
        for (;;) {
                v4l_dbg(2, msp_debug, client, "msp3400 thread: sleep\n");
                msp_sleep(state, -1);
                v4l_dbg(2, msp_debug, client, "msp3400 thread: wakeup\n");
 
-       restart:
+restart:
                v4l_dbg(2, msp_debug, client, "thread: restart scan\n");
                state->restart = 0;
                if (kthread_should_stop())
@@ -456,20 +493,24 @@ int msp3400c_thread(void *data)
 
                if (state->radio || MSP_MODE_EXTERN == state->mode) {
                        /* no carrier scan, just unmute */
-                       v4l_dbg(1, msp_debug, client, "thread: no carrier scan\n");
+                       v4l_dbg(1, msp_debug, client,
+                               "thread: no carrier scan\n");
+                       state->scan_in_progress = 0;
                        msp_set_audio(client);
                        continue;
                }
 
-               /* mute */
-               msp_set_mute(client);
-               msp3400c_set_mode(client, MSP_MODE_AM_DETECT /* +1 */ );
+               /* mute audio */
+               state->scan_in_progress = 1;
+               msp_set_audio(client);
+
+               msp3400c_set_mode(client, MSP_MODE_AM_DETECT);
                val1 = val2 = 0;
                max1 = max2 = -1;
                state->watch_stereo = 0;
                state->nicam_on = 0;
 
-               /* some time for the tuner to sync */
+               /* wait for tuner to settle down after a channel change */
                if (msp_sleep(state, 200))
                        goto restart;
 
@@ -484,16 +525,17 @@ int msp3400c_thread(void *data)
                        v4l_dbg(1, msp_debug, client, "AM sound override\n");
                }
 
-               for (this = 0; this < count; this++) {
-                       msp3400c_set_carrier(client, cd[this].cdo, cd[this].cdo);
-                       if (msp_sleep(state,100))
+               for (i = 0; i < count; i++) {
+                       msp3400c_set_carrier(client, cd[i].cdo, cd[i].cdo);
+                       if (msp_sleep(state, 100))
                                goto restart;
                        val = msp_read_dsp(client, 0x1b);
                        if (val > 32767)
                                val -= 65536;
                        if (val1 < val)
-                               val1 = val, max1 = this;
-                       v4l_dbg(1, msp_debug, client, "carrier1 val: %5d / %s\n", val,cd[this].name);
+                               val1 = val, max1 = i;
+                       v4l_dbg(1, msp_debug, client,
+                               "carrier1 val: %5d / %s\n", val, cd[i].name);
                }
 
                /* carrier detect pass #2 -- second (stereo) carrier */
@@ -520,16 +562,17 @@ int msp3400c_thread(void *data)
                        count = 0;
                        max2 = 0;
                }
-               for (this = 0; this < count; this++) {
-                       msp3400c_set_carrier(client, cd[this].cdo, cd[this].cdo);
-                       if (msp_sleep(state,100))
+               for (i = 0; i < count; i++) {
+                       msp3400c_set_carrier(client, cd[i].cdo, cd[i].cdo);
+                       if (msp_sleep(state, 100))
                                goto restart;
                        val = msp_read_dsp(client, 0x1b);
                        if (val > 32767)
                                val -= 65536;
                        if (val2 < val)
-                               val2 = val, max2 = this;
-                       v4l_dbg(1, msp_debug, client, "carrier2 val: %5d / %s\n", val,cd[this].name);
+                               val2 = val, max2 = i;
+                       v4l_dbg(1, msp_debug, client,
+                               "carrier2 val: %5d / %s\n", val, cd[i].name);
                }
 
                /* program the msp3400 according to the results */
@@ -545,7 +588,6 @@ int msp3400c_thread(void *data)
                                /* B/G NICAM */
                                state->second = msp3400c_carrier_detect_55[max2].cdo;
                                msp3400c_set_mode(client, MSP_MODE_FM_NICAM1);
-                               msp3400c_set_carrier(client, state->second, state->main);
                                state->nicam_on = 1;
                                state->watch_stereo = 1;
                        } else {
@@ -556,7 +598,6 @@ int msp3400c_thread(void *data)
                        /* PAL I NICAM */
                        state->second = MSP_CARRIER(6.552);
                        msp3400c_set_mode(client, MSP_MODE_FM_NICAM2);
-                       msp3400c_set_carrier(client, state->second, state->main);
                        state->nicam_on = 1;
                        state->watch_stereo = 1;
                        break;
@@ -570,15 +611,11 @@ int msp3400c_thread(void *data)
                                /* L NICAM or AM-mono */
                                state->second = msp3400c_carrier_detect_65[max2].cdo;
                                msp3400c_set_mode(client, MSP_MODE_AM_NICAM);
-                               msp3400c_set_carrier(client, state->second, state->main);
-                               /* volume prescale for SCART (AM mono input) */
-                               msp_write_dsp(client, 0x000d, 0x1900);
                                state->watch_stereo = 1;
                        } else if (max2 == 0 && state->has_nicam) {
                                /* D/K NICAM */
                                state->second = msp3400c_carrier_detect_65[max2].cdo;
                                msp3400c_set_mode(client, MSP_MODE_FM_NICAM1);
-                               msp3400c_set_carrier(client, state->second, state->main);
                                state->nicam_on = 1;
                                state->watch_stereo = 1;
                        } else {
@@ -587,28 +624,29 @@ int msp3400c_thread(void *data)
                        break;
                case 0: /* 4.5 */
                default:
-               no_second:
+no_second:
                        state->second = msp3400c_carrier_detect_main[max1].cdo;
                        msp3400c_set_mode(client, MSP_MODE_FM_TERRA);
-                       msp3400c_set_carrier(client, state->second, state->main);
-                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
                        break;
                }
+               msp3400c_set_carrier(client, state->second, state->main);
 
                /* unmute */
-               msp_set_audio(client);
+               state->scan_in_progress = 0;
                msp3400c_set_audmode(client);
+               msp_set_audio(client);
 
                if (msp_debug)
                        msp3400c_print_mode(client);
 
                /* monitor tv audio mode, the first time don't wait
                   so long to get a quick stereo/bilingual result */
-               if (msp_sleep(state, 1000))
-                       goto restart;
+               count = 3;
                while (state->watch_stereo) {
-                       if (msp_sleep(state, 5000))
+                       if (msp_sleep(state, count ? 1000 : 5000))
                                goto restart;
+                       if (count)
+                               count--;
                        watch_stereo(client);
                }
        }
@@ -620,17 +658,17 @@ int msp3400c_thread(void *data)
 int msp3410d_thread(void *data)
 {
        struct i2c_client *client = data;
-       struct msp_state *state = i2c_get_clientdata(client);
-       int val, i, std;
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       int val, i, std, count;
 
        v4l_dbg(1, msp_debug, client, "msp3410 daemon started\n");
-
+       set_freezable();
        for (;;) {
                v4l_dbg(2, msp_debug, client, "msp3410 thread: sleep\n");
-               msp_sleep(state,-1);
+               msp_sleep(state, -1);
                v4l_dbg(2, msp_debug, client, "msp3410 thread: wakeup\n");
 
-       restart:
+restart:
                v4l_dbg(2, msp_debug, client, "thread: restart scan\n");
                state->restart = 0;
                if (kthread_should_stop())
@@ -638,19 +676,20 @@ int msp3410d_thread(void *data)
 
                if (state->mode == MSP_MODE_EXTERN) {
                        /* no carrier scan needed, just unmute */
-                       v4l_dbg(1, msp_debug, client, "thread: no carrier scan\n");
+                       v4l_dbg(1, msp_debug, client,
+                               "thread: no carrier scan\n");
+                       state->scan_in_progress = 0;
                        msp_set_audio(client);
                        continue;
                }
 
-               /* put into sane state (and mute) */
-               msp_reset(client);
-
-               /* some time for the tuner to sync */
-               if (msp_sleep(state,200))
-                       goto restart;
+               /* mute audio */
+               state->scan_in_progress = 1;
+               msp_set_audio(client);
 
-               /* start autodetect */
+               /* start autodetect. Note: autodetect is not supported for
+                  NTSC-M and radio, hence we force the standard in those
+                  cases. */
                if (state->radio)
                        std = 0x40;
                else
@@ -658,9 +697,14 @@ int msp3410d_thread(void *data)
                state->watch_stereo = 0;
                state->nicam_on = 0;
 
+               /* wait for tuner to settle down after a channel change */
+               if (msp_sleep(state, 200))
+                       goto restart;
+
                if (msp_debug)
-                       v4l_dbg(2, msp_debug, client, "setting standard: %s (0x%04x)\n",
-                              msp_standard_std_name(std), std);
+                       v4l_dbg(2, msp_debug, client,
+                               "setting standard: %s (0x%04x)\n",
+                               msp_standard_std_name(std), std);
 
                if (std != 1) {
                        /* programmed some specific mode */
@@ -676,7 +720,8 @@ int msp3410d_thread(void *data)
                                val = msp_read_dem(client, 0x7e);
                                if (val < 0x07ff)
                                        break;
-                               v4l_dbg(2, msp_debug, client, "detection still in progress\n");
+                               v4l_dbg(2, msp_debug, client,
+                                       "detection still in progress\n");
                        }
                }
                for (i = 0; msp_stdlist[i].name != NULL; i++)
@@ -687,45 +732,40 @@ int msp3410d_thread(void *data)
                state->main   = msp_stdlist[i].main;
                state->second = msp_stdlist[i].second;
                state->std = val;
+               state->rxsubchans = V4L2_TUNER_SUB_MONO;
 
-               if (msp_amsound && !state->radio && (state->v4l2_std & V4L2_STD_SECAM) &&
-                               (val != 0x0009)) {
+               if (msp_amsound && !state->radio &&
+                   (state->v4l2_std & V4L2_STD_SECAM) && (val != 0x0009)) {
                        /* autodetection has failed, let backup */
                        v4l_dbg(1, msp_debug, client, "autodetection failed,"
                                " switching to backup standard: %s (0x%04x)\n",
-                               msp_stdlist[8].name ? msp_stdlist[8].name : "unknown",val);
-                       val = 0x0009;
+                               msp_stdlist[8].name ?
+                                       msp_stdlist[8].name : "unknown", val);
+                       state->std = val = 0x0009;
                        msp_write_dem(client, 0x20, val);
                }
 
-               /* set various prescales */
-               msp_write_dsp(client, 0x0d, 0x1900); /* scart */
-               msp_write_dsp(client, 0x0e, 0x2403); /* FM */
-               msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
-
                /* set stereo */
                switch (val) {
                case 0x0008: /* B/G NICAM */
                case 0x000a: /* I NICAM */
-                       if (val == 0x0008)
-                               state->mode = MSP_MODE_FM_NICAM1;
-                       else
+               case 0x000b: /* D/K NICAM */
+                       if (val == 0x000a)
                                state->mode = MSP_MODE_FM_NICAM2;
+                       else
+                               state->mode = MSP_MODE_FM_NICAM1;
                        /* just turn on stereo */
-                       state->rxsubchans = V4L2_TUNER_SUB_STEREO;
                        state->nicam_on = 1;
                        state->watch_stereo = 1;
                        break;
                case 0x0009:
                        state->mode = MSP_MODE_AM_NICAM;
-                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
                        state->nicam_on = 1;
                        state->watch_stereo = 1;
                        break;
                case 0x0020: /* BTSC */
                        /* The pre-'G' models only have BTSC-mono */
                        state->mode = MSP_MODE_BTSC;
-                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
                        break;
                case 0x0040: /* FM radio */
                        state->mode = MSP_MODE_FM_RADIO;
@@ -735,34 +775,39 @@ int msp3410d_thread(void *data)
                        msp3400c_set_mode(client, MSP_MODE_FM_RADIO);
                        msp3400c_set_carrier(client, MSP_CARRIER(10.7),
                                            MSP_CARRIER(10.7));
-                       /* scart routing (this doesn't belong here I think) */
-                       msp_set_scart(client,SCART_IN2,0);
                        break;
+               case 0x0002:
                case 0x0003:
                case 0x0004:
                case 0x0005:
                        state->mode = MSP_MODE_FM_TERRA;
-                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
                        state->watch_stereo = 1;
                        break;
                }
 
-               /* unmute, restore misc registers */
-               msp_set_audio(client);
-               msp_write_dsp(client, 0x13, state->acb);
+               /* set various prescales */
+               msp_write_dsp(client, 0x0d, 0x1900); /* scart */
+               msp_write_dsp(client, 0x0e, 0x3000); /* FM */
+               if (state->has_nicam)
+                       msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
+
                if (state->has_i2s_conf)
                        msp_write_dem(client, 0x40, state->i2s_mode);
 
+               /* unmute */
                msp3400c_set_audmode(client);
+               state->scan_in_progress = 0;
+               msp_set_audio(client);
 
                /* monitor tv audio mode, the first time don't wait
                   so long to get a quick stereo/bilingual result */
-               if (msp_sleep(state, 1000))
-                       goto restart;
+               count = 3;
                while (state->watch_stereo) {
-                       watch_stereo(client);
-                       if (msp_sleep(state, 5000))
+                       if (msp_sleep(state, count ? 1000 : 5000))
                                goto restart;
+                       if (count)
+                               count--;
+                       watch_stereo(client);
                }
        }
        v4l_dbg(1, msp_debug, client, "thread: exit\n");
@@ -771,54 +816,20 @@ int msp3410d_thread(void *data)
 
 /* ----------------------------------------------------------------------- */
 
-/* msp34xxG + (autoselect no-thread)                                       */
-/* this one uses both automatic standard detection and automatic sound     */
-/* select which are available in the newer G versions                      */
-/* struct msp: only norm, acb and source are really used in this mode      */
-
-/* set the same 'source' for the loudspeaker, scart and quasi-peak detector
- * the value for source is the same as bit 15:8 of DSP registers 0x08,
- * 0x0a and 0x0c: 0=mono, 1=stereo or A|B, 2=SCART, 3=stereo or A, 4=stereo or B
- *
- * this function replaces msp3400c_set_audmode
+/* msp34xxG + (autoselect no-thread)
+ * this one uses both automatic standard detection and automatic sound
+ * select which are available in the newer G versions
+ * struct msp: only norm, acb and source are really used in this mode
  */
-static void msp34xxg_set_source(struct i2c_client *client, int source)
-{
-       struct msp_state *state = i2c_get_clientdata(client);
-
-       /* fix matrix mode to stereo and let the msp choose what
-        * to output according to 'source', as recommended
-        * for MONO (source==0) downmixing set bit[7:0] to 0x30
-        */
-       int value = (source & 0x07) << 8 | (source == 0 ? 0x30 : 0x20);
-
-       v4l_dbg(1, msp_debug, client, "set source to %d (0x%x)\n", source, value);
-       msp_set_source(client, value);
-       /*
-        * set identification threshold. Personally, I
-        * I set it to a higher value that the default
-        * of 0x190 to ignore noisy stereo signals.
-        * this needs tuning. (recommended range 0x00a0-0x03c0)
-        * 0x7f0 = forced mono mode
-        */
-       /* a2 threshold for stereo/bilingual */
-       msp_write_dem(client, 0x22, msp_stereo_thresh);
-       state->source = source;
-}
 
 static int msp34xxg_modus(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
 
        if (state->radio) {
                v4l_dbg(1, msp_debug, client, "selected radio modus\n");
                return 0x0001;
        }
-
-       if (state->v4l2_std & V4L2_STD_PAL) {
-               v4l_dbg(1, msp_debug, client, "selected PAL modus\n");
-               return 0x7001;
-       }
        if (state->v4l2_std == V4L2_STD_NTSC_M_JP) {
                v4l_dbg(1, msp_debug, client, "selected M (EIA-J) modus\n");
                return 0x4001;
@@ -827,92 +838,158 @@ static int msp34xxg_modus(struct i2c_client *client)
                v4l_dbg(1, msp_debug, client, "selected M (A2) modus\n");
                return 0x0001;
        }
+       if (state->v4l2_std == V4L2_STD_SECAM_L) {
+               v4l_dbg(1, msp_debug, client, "selected SECAM-L modus\n");
+               return 0x6001;
+       }
        if (state->v4l2_std & V4L2_STD_MN) {
                v4l_dbg(1, msp_debug, client, "selected M (BTSC) modus\n");
                return 0x2001;
        }
-       if (state->v4l2_std & V4L2_STD_SECAM) {
-               v4l_dbg(1, msp_debug, client, "selected SECAM modus\n");
-               return 0x6001;
+       return 0x7001;
+}
+
+static void msp34xxg_set_source(struct i2c_client *client, u16 reg, int in)
+ {
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       int source, matrix;
+
+       switch (state->audmode) {
+       case V4L2_TUNER_MODE_MONO:
+               source = 0; /* mono only */
+               matrix = 0x30;
+               break;
+       case V4L2_TUNER_MODE_LANG2:
+               source = 4; /* stereo or B */
+               matrix = 0x10;
+               break;
+       case V4L2_TUNER_MODE_LANG1_LANG2:
+               source = 1; /* stereo or A|B */
+               matrix = 0x20;
+               break;
+       case V4L2_TUNER_MODE_LANG1:
+               source = 3; /* stereo or A */
+               matrix = 0x00;
+               break;
+       case V4L2_TUNER_MODE_STEREO:
+       default:
+               source = 3; /* stereo or A */
+               matrix = 0x20;
+               break;
        }
-       return 0x0001;
+
+       if (in == MSP_DSP_IN_TUNER)
+               source = (source << 8) | 0x20;
+       /* the msp34x2g puts the MAIN_AVC, MAIN and AUX sources in 12, 13, 14
+          instead of 11, 12, 13. So we add one for that msp version. */
+       else if (in >= MSP_DSP_IN_MAIN_AVC && state->has_dolby_pro_logic)
+               source = ((in + 1) << 8) | matrix;
+       else
+               source = (in << 8) | matrix;
+
+       v4l_dbg(1, msp_debug, client,
+               "set source to %d (0x%x) for output %02x\n", in, source, reg);
+       msp_write_dsp(client, reg, source);
 }
 
-/* (re-)initialize the msp34xxg, according to the current norm in state->norm
- * return 0 if it worked, -1 if it failed
- */
-static int msp34xxg_reset(struct i2c_client *client)
+static void msp34xxg_set_sources(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
-       int modus, std;
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       u32 in = state->route_in;
+
+       msp34xxg_set_source(client, 0x0008, (in >> 4) & 0xf);
+       /* quasi-peak detector is set to same input as the loudspeaker (MAIN) */
+       msp34xxg_set_source(client, 0x000c, (in >> 4) & 0xf);
+       msp34xxg_set_source(client, 0x0009, (in >> 8) & 0xf);
+       msp34xxg_set_source(client, 0x000a, (in >> 12) & 0xf);
+       if (state->has_scart2_out)
+               msp34xxg_set_source(client, 0x0041, (in >> 16) & 0xf);
+       msp34xxg_set_source(client, 0x000b, (in >> 20) & 0xf);
+}
+
+/* (re-)initialize the msp34xxg */
+static void msp34xxg_reset(struct i2c_client *client)
+{
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       int tuner = (state->route_in >> 3) & 1;
+       int modus;
 
-       if (msp_reset(client))
-               return -1;
+       /* initialize std to 1 (autodetect) to signal that no standard is
+          selected yet. */
+       state->std = 1;
 
-       /* make sure that input/output is muted (paranoid mode) */
-       /* ACB, mute DSP input, mute SCART 1 */
-       if (msp_write_dsp(client, 0x13, 0x0f20))
-               return -1;
+       msp_reset(client);
 
        if (state->has_i2s_conf)
                msp_write_dem(client, 0x40, state->i2s_mode);
 
        /* step-by-step initialisation, as described in the manual */
        modus = msp34xxg_modus(client);
-       if (state->radio)
-               std = 0x40;
-       else
-               std = (state->v4l2_std & V4L2_STD_NTSC) ? 0x20 : 1;
-       modus &= ~0x03; /* STATUS_CHANGE = 0 */
-       modus |= 0x01;  /* AUTOMATIC_SOUND_DETECTION = 1 */
-       if (msp_write_dem(client, 0x30, modus))
-               return -1;
-       if (msp_write_dem(client, 0x20, std))
-               return -1;
+       modus |= tuner ? 0x100 : 0;
+       msp_write_dem(client, 0x30, modus);
 
        /* write the dsps that may have an influence on
           standard/audio autodetection right now */
-       msp34xxg_set_source(client, state->source);
-
-       /* AM/FM Prescale [15:8] 75khz deviation */
-       if (msp_write_dsp(client, 0x0e, 0x3000))
-               return -1;
+       msp34xxg_set_sources(client);
 
-       /* NICAM Prescale 9db gain (as recommended) */
-       if (msp_write_dsp(client, 0x10, 0x5a00))
-               return -1;
+       msp_write_dsp(client, 0x0d, 0x1900); /* scart */
+       msp_write_dsp(client, 0x0e, 0x3000); /* FM */
+       if (state->has_nicam)
+               msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
 
-       return 0;
+       /* set identification threshold. Personally, I
+        * I set it to a higher value than the default
+        * of 0x190 to ignore noisy stereo signals.
+        * this needs tuning. (recommended range 0x00a0-0x03c0)
+        * 0x7f0 = forced mono mode
+        *
+        * a2 threshold for stereo/bilingual.
+        * Note: this register is part of the Manual/Compatibility mode.
+        * It is supported by all 'G'-family chips.
+        */
+       msp_write_dem(client, 0x22, msp_stereo_thresh);
 }
 
 int msp34xxg_thread(void *data)
 {
        struct i2c_client *client = data;
-       struct msp_state *state = i2c_get_clientdata(client);
-       int val, std, i;
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+       int val, i;
 
        v4l_dbg(1, msp_debug, client, "msp34xxg daemon started\n");
-
-       state->source = 1; /* default */
+       set_freezable();
        for (;;) {
                v4l_dbg(2, msp_debug, client, "msp34xxg thread: sleep\n");
                msp_sleep(state, -1);
                v4l_dbg(2, msp_debug, client, "msp34xxg thread: wakeup\n");
 
-       restart:
+restart:
                v4l_dbg(1, msp_debug, client, "thread: restart scan\n");
                state->restart = 0;
                if (kthread_should_stop())
                        break;
 
+               if (state->mode == MSP_MODE_EXTERN) {
+                       /* no carrier scan needed, just unmute */
+                       v4l_dbg(1, msp_debug, client,
+                               "thread: no carrier scan\n");
+                       state->scan_in_progress = 0;
+                       msp_set_audio(client);
+                       continue;
+               }
+
                /* setup the chip*/
                msp34xxg_reset(client);
-               std = msp_standard;
-               if (std != 0x01)
+               state->std = state->radio ? 0x40 :
+                       (state->force_btsc && msp_standard == 1) ? 32 : msp_standard;
+               msp_write_dem(client, 0x20, state->std);
+               /* start autodetect */
+               if (state->std != 1)
                        goto unmute;
 
                /* watch autodetect */
-               v4l_dbg(1, msp_debug, client, "triggered autodetect, waiting for result\n");
+               v4l_dbg(1, msp_debug, client,
+                       "started autodetect, waiting for result\n");
                for (i = 0; i < 10; i++) {
                        if (msp_sleep(state, 100))
                                goto restart;
@@ -920,20 +997,27 @@ int msp34xxg_thread(void *data)
                        /* check results */
                        val = msp_read_dem(client, 0x7e);
                        if (val < 0x07ff) {
-                               std = val;
+                               state->std = val;
                                break;
                        }
-                       v4l_dbg(2, msp_debug, client, "detection still in progress\n");
+                       v4l_dbg(2, msp_debug, client,
+                               "detection still in progress\n");
                }
-               if (std == 1) {
-                       v4l_dbg(1, msp_debug, client, "detection still in progress after 10 tries. giving up.\n");
+               if (state->std == 1) {
+                       v4l_dbg(1, msp_debug, client,
+                               "detection still in progress after 10 tries. giving up.\n");
                        continue;
                }
 
-       unmute:
-               state->std = std;
-               v4l_dbg(1, msp_debug, client, "current standard: %s (0x%04x)\n",
-                       msp_standard_std_name(std), std);
+unmute:
+               v4l_dbg(1, msp_debug, client,
+                       "detected standard: %s (0x%04x)\n",
+                       msp_standard_std_name(state->std), state->std);
+
+               if (state->std == 9) {
+                       /* AM NICAM mode */
+                       msp_write_dsp(client, 0x0e, 0x7c00);
+               }
 
                /* unmute: dispatch sound to scart output, set scart volume */
                msp_set_audio(client);
@@ -942,20 +1026,36 @@ int msp34xxg_thread(void *data)
                if (msp_write_dsp(client, 0x13, state->acb))
                        return -1;
 
-               if (state->has_i2s_conf)
-                       msp_write_dem(client, 0x40, state->i2s_mode);
+               /* the periodic stereo/SAP check is only relevant for
+                  the 0x20 standard (BTSC) */
+               if (state->std != 0x20)
+                       continue;
+
+               state->watch_stereo = 1;
+
+               /* monitor tv audio mode, the first time don't wait
+                  in order to get a quick stereo/SAP update */
+               watch_stereo(client);
+               while (state->watch_stereo) {
+                       watch_stereo(client);
+                       if (msp_sleep(state, 5000))
+                               goto restart;
+               }
        }
        v4l_dbg(1, msp_debug, client, "thread: exit\n");
        return 0;
 }
 
-static void msp34xxg_detect_stereo(struct i2c_client *client)
+static int msp34xxg_detect_stereo(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
-
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
        int status = msp_read_dem(client, 0x0200);
        int is_bilingual = status & 0x100;
        int is_stereo = status & 0x40;
+       int oldrx = state->rxsubchans;
+
+       if (state->mode == MSP_MODE_EXTERN)
+               return 0;
 
        state->rxsubchans = 0;
        if (is_stereo)
@@ -963,52 +1063,42 @@ static void msp34xxg_detect_stereo(struct i2c_client *client)
        else
                state->rxsubchans = V4L2_TUNER_SUB_MONO;
        if (is_bilingual) {
-               state->rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
-               /* I'm supposed to check whether it's SAP or not
-                * and set only LANG2/SAP in this case. Yet, the MSP
-                * does a lot of work to hide this and handle everything
-                * the same way. I don't want to work around it so unless
-                * this is a problem, I'll handle SAP just like lang1/lang2.
-                */
+               if (state->std == 0x20)
+                       state->rxsubchans |= V4L2_TUNER_SUB_SAP;
+               else
+                       state->rxsubchans =
+                               V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
        }
-       v4l_dbg(1, msp_debug, client, "status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
+       v4l_dbg(1, msp_debug, client,
+               "status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
                status, is_stereo, is_bilingual, state->rxsubchans);
+       return (oldrx != state->rxsubchans);
 }
 
 static void msp34xxg_set_audmode(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
-       int source;
-
-       switch (state->audmode) {
-       case V4L2_TUNER_MODE_MONO:
-               source = 0; /* mono only */
-               break;
-       case V4L2_TUNER_MODE_STEREO:
-               source = 1; /* stereo or A|B, see comment in msp34xxg_get_v4l2_stereo() */
-               /* problem: that could also mean 2 (scart input) */
-               break;
-       case V4L2_TUNER_MODE_LANG1:
-               source = 3; /* stereo or A */
-               break;
-       case V4L2_TUNER_MODE_LANG2:
-               source = 4; /* stereo or B */
-               break;
-       default:
-               source  = 1;
-               break;
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
+
+       if (state->std == 0x20) {
+              if ((state->rxsubchans & V4L2_TUNER_SUB_SAP) &&
+                  (state->audmode == V4L2_TUNER_MODE_LANG1_LANG2 ||
+                   state->audmode == V4L2_TUNER_MODE_LANG2)) {
+                       msp_write_dem(client, 0x20, 0x21);
+              } else {
+                       msp_write_dem(client, 0x20, 0x20);
+              }
        }
-       msp34xxg_set_source(client, source);
+
+       msp34xxg_set_sources(client);
 }
 
 void msp_set_audmode(struct i2c_client *client)
 {
-       struct msp_state *state = i2c_get_clientdata(client);
+       struct msp_state *state = to_state(i2c_get_clientdata(client));
 
        switch (state->opmode) {
        case OPMODE_MANUAL:
        case OPMODE_AUTODETECT:
-               state->watch_stereo = 0;
                msp3400c_set_audmode(client);
                break;
        case OPMODE_AUTOSELECT:
@@ -1017,18 +1107,17 @@ void msp_set_audmode(struct i2c_client *client)
        }
 }
 
-void msp_detect_stereo(struct i2c_client *client)
+int msp_detect_stereo(struct i2c_client *client)
 {
-       struct msp_state *state  = i2c_get_clientdata(client);
+       struct msp_state *state  = to_state(i2c_get_clientdata(client));
 
        switch (state->opmode) {
        case OPMODE_MANUAL:
        case OPMODE_AUTODETECT:
-               msp3400c_detect_stereo(client);
-               break;
+               return msp3400c_detect_stereo(client);
        case OPMODE_AUTOSELECT:
-               msp34xxg_detect_stereo(client);
-               break;
+               return msp34xxg_detect_stereo(client);
        }
+       return 0;
 }