headers: remove sched.h from poll.h
[safe/jmp/linux-2.6] / drivers / media / dvb / dvb-core / dvb_demux.c
index 3d18d3e..91c537b 100644 (file)
@@ -21,6 +21,7 @@
  *
  */
 
+#include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 */
 // #define DVB_DEMUX_SECTION_LOSS_LOG
 
+static int dvb_demux_tscheck;
+module_param(dvb_demux_tscheck, int, 0644);
+MODULE_PARM_DESC(dvb_demux_tscheck,
+               "enable transport stream continuity and TEI check");
 
-static LIST_HEAD(dmx_muxs);
-
-
-static int dmx_register_demux(struct dmx_demux *demux)
-{
-       demux->users = 0;
-       list_add(&demux->reg_list, &dmx_muxs);
-       return 0;
-}
-
-static int dmx_unregister_demux(struct dmx_demux* demux)
-{
-       struct list_head *pos, *n, *head=&dmx_muxs;
-
-       list_for_each_safe (pos, n, head) {
-               if (DMX_DIR_ENTRY(pos) == demux) {
-                       if (demux->users>0)
-                               return -EINVAL;
-                       list_del(pos);
-                       return 0;
-               }
-       }
-
-       return -ENODEV;
-}
-
+#define dprintk_tscheck(x...) do {                              \
+               if (dvb_demux_tscheck && printk_ratelimit())    \
+                       printk(x);                              \
+       } while (0)
 
 /******************************************************************************
  * static inlined helper functions
  ******************************************************************************/
 
-
 static inline u16 section_length(const u8 *buf)
 {
-       return 3+((buf[1]&0x0f)<<8)+buf[2];
+       return 3 + ((buf[1] & 0x0f) << 8) + buf[2];
 }
 
-
 static inline u16 ts_pid(const u8 *buf)
 {
-       return ((buf[1]&0x1f)<<8)+buf[2];
+       return ((buf[1] & 0x1f) << 8) + buf[2];
 }
 
-
 static inline u8 payload(const u8 *tsp)
 {
-       if (!(tsp[3] & 0x10)) // no payload?
+       if (!(tsp[3] & 0x10))   // no payload?
                return 0;
-       if (tsp[3] & 0x20) {  // adaptation field?
-               if (tsp[4] > 183)    // corrupted data?
+
+       if (tsp[3] & 0x20) {    // adaptation field?
+               if (tsp[4] > 183)       // corrupted data?
                        return 0;
                else
-                       return 184-1-tsp[4];
+                       return 184 - 1 - tsp[4];
        }
+
        return 184;
 }
 
-
-static u32 dvb_dmx_crc32 (struct dvb_demux_feed *f, const u8 *src, size_t len)
+static u32 dvb_dmx_crc32(struct dvb_demux_feed *f, const u8 *src, size_t len)
 {
-       return (f->feed.sec.crc_val = crc32_be (f->feed.sec.crc_val, src, len));
+       return (f->feed.sec.crc_val = crc32_be(f->feed.sec.crc_val, src, len));
 }
 
-
-static void dvb_dmx_memcopy (struct dvb_demux_feed *f, u8 *d, const u8 *s, size_t len)
+static void dvb_dmx_memcopy(struct dvb_demux_feed *f, u8 *d, const u8 *s,
+                           size_t len)
 {
-       memcpy (d, s, len);
+       memcpy(d, s, len);
 }
 
-
 /******************************************************************************
  * Software filter functions
  ******************************************************************************/
 
-static inline int dvb_dmx_swfilter_payload (struct dvb_demux_feed *feed, const u8 *buf)
+static inline int dvb_dmx_swfilter_payload(struct dvb_demux_feed *feed,
+                                          const u8 *buf)
 {
        int count = payload(buf);
        int p;
@@ -123,32 +104,31 @@ static inline int dvb_dmx_swfilter_payload (struct dvb_demux_feed *feed, const u
        if (count == 0)
                return -1;
 
-       p = 188-count;
+       p = 188 - count;
 
        /*
-       cc=buf[3]&0x0f;
-       ccok=((dvbdmxfeed->cc+1)&0x0f)==cc ? 1 : 0;
-       dvbdmxfeed->cc=cc;
+       cc = buf[3] & 0x0f;
+       ccok = ((feed->cc + 1) & 0x0f) == cc;
+       feed->cc = cc;
        if (!ccok)
                printk("missed packet!\n");
        */
 
-       if (buf[1] & 0x40)  // PUSI ?
+       if (buf[1] & 0x40)      // PUSI ?
                feed->peslen = 0xfffa;
 
        feed->peslen += count;
 
-       return feed->cb.ts (&buf[p], count, NULL, 0, &feed->feed.ts, DMX_OK);
+       return feed->cb.ts(&buf[p], count, NULL, 0, &feed->feed.ts, DMX_OK);
 }
 
-
-static int dvb_dmx_swfilter_sectionfilter (struct dvb_demux_feed *feed,
-                                   struct dvb_demux_filter *f)
+static int dvb_dmx_swfilter_sectionfilter(struct dvb_demux_feed *feed,
+                                         struct dvb_demux_filter *f)
 {
        u8 neq = 0;
        int i;
 
-       for (i=0; i<DVB_DEMUX_MASK_MAX; i++) {
+       for (i = 0; i < DVB_DEMUX_MASK_MAX; i++) {
                u8 xor = f->filter.filter_value[i] ^ feed->feed.sec.secbuf[i];
 
                if (f->maskandmode[i] & xor)
@@ -160,12 +140,11 @@ static int dvb_dmx_swfilter_sectionfilter (struct dvb_demux_feed *feed,
        if (f->doneq && !neq)
                return 0;
 
-       return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen,
-                            NULL, 0, &f->filter, DMX_OK);
+       return feed->cb.sec(feed->feed.sec.secbuf, feed->feed.sec.seclen,
+                           NULL, 0, &f->filter, DMX_OK);
 }
 
-
-static inline int dvb_dmx_swfilter_section_feed (struct dvb_demux_feed *feed)
+static inline int dvb_dmx_swfilter_section_feed(struct dvb_demux_feed *feed)
 {
        struct dvb_demux *demux = feed->demux;
        struct dvb_demux_filter *f = feed->filter;
@@ -195,26 +174,24 @@ static inline int dvb_dmx_swfilter_section_feed (struct dvb_demux_feed *feed)
        return 0;
 }
 
-
 static void dvb_dmx_swfilter_section_new(struct dvb_demux_feed *feed)
 {
        struct dmx_section_feed *sec = &feed->feed.sec;
 
 #ifdef DVB_DEMUX_SECTION_LOSS_LOG
-       if(sec->secbufp < sec->tsfeedp)
-       {
+       if (sec->secbufp < sec->tsfeedp) {
                int i, n = sec->tsfeedp - sec->secbufp;
 
-               /* section padding is done with 0xff bytes entirely.
-               ** due to speed reasons, we won't check all of them
-               ** but just first and last
-               */
-               if(sec->secbuf[0] != 0xff || sec->secbuf[n-1] != 0xff)
-               {
+               /*
+                * Section padding is done with 0xff bytes entirely.
+                * Due to speed reasons, we won't check all of them
+                * but just first and last.
+                */
+               if (sec->secbuf[0] != 0xff || sec->secbuf[n - 1] != 0xff) {
                        printk("dvb_demux.c section ts padding loss: %d/%d\n",
                               n, sec->tsfeedp);
                        printk("dvb_demux.c pad data:");
-                       for(i = 0; i < n; i++)
+                       for (i = 0; i < n; i++)
                                printk(" %02x", sec->secbuf[i]);
                        printk("\n");
                }
@@ -226,82 +203,81 @@ static void dvb_dmx_swfilter_section_new(struct dvb_demux_feed *feed)
 }
 
 /*
-** Losless Section Demux 1.4.1 by Emard
-** Valsecchi Patrick:
-**  - middle of section A  (no PUSI)
-**  - end of section A and start of section B
-**    (with PUSI pointing to the start of the second section)
-**
-**  In this case, without feed->pusi_seen you'll receive a garbage section
-**  consisting of the end of section A. Basically because tsfeedp
-**  is incemented and the use=0 condition is not raised
-**  when the second packet arrives.
-**
-** Fix:
-** when demux is started, let feed->pusi_seen = 0 to
-** prevent initial feeding of garbage from the end of
-** previous section. When you for the first time see PUSI=1
-** then set feed->pusi_seen = 1
-*/
-static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed, const u8 *buf, u8 len)
+ * Losless Section Demux 1.4.1 by Emard
+ * Valsecchi Patrick:
+ *  - middle of section A  (no PUSI)
+ *  - end of section A and start of section B
+ *    (with PUSI pointing to the start of the second section)
+ *
+ *  In this case, without feed->pusi_seen you'll receive a garbage section
+ *  consisting of the end of section A. Basically because tsfeedp
+ *  is incemented and the use=0 condition is not raised
+ *  when the second packet arrives.
+ *
+ * Fix:
+ * when demux is started, let feed->pusi_seen = 0 to
+ * prevent initial feeding of garbage from the end of
+ * previous section. When you for the first time see PUSI=1
+ * then set feed->pusi_seen = 1
+ */
+static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,
+                                             const u8 *buf, u8 len)
 {
        struct dvb_demux *demux = feed->demux;
        struct dmx_section_feed *sec = &feed->feed.sec;
        u16 limit, seclen, n;
 
-       if(sec->tsfeedp >= DMX_MAX_SECFEED_SIZE)
+       if (sec->tsfeedp >= DMX_MAX_SECFEED_SIZE)
                return 0;
 
-       if(sec->tsfeedp + len > DMX_MAX_SECFEED_SIZE)
-       {
+       if (sec->tsfeedp + len > DMX_MAX_SECFEED_SIZE) {
 #ifdef DVB_DEMUX_SECTION_LOSS_LOG
                printk("dvb_demux.c section buffer full loss: %d/%d\n",
-                      sec->tsfeedp + len - DMX_MAX_SECFEED_SIZE, DMX_MAX_SECFEED_SIZE);
+                      sec->tsfeedp + len - DMX_MAX_SECFEED_SIZE,
+                      DMX_MAX_SECFEED_SIZE);
 #endif
                len = DMX_MAX_SECFEED_SIZE - sec->tsfeedp;
        }
 
-       if(len <= 0)
+       if (len <= 0)
                return 0;
 
        demux->memcopy(feed, sec->secbuf_base + sec->tsfeedp, buf, len);
        sec->tsfeedp += len;
 
-       /* -----------------------------------------------------
-       ** Dump all the sections we can find in the data (Emard)
-       */
-
+       /*
+        * Dump all the sections we can find in the data (Emard)
+        */
        limit = sec->tsfeedp;
-       if(limit > DMX_MAX_SECFEED_SIZE)
-               return -1; /* internal error should never happen */
+       if (limit > DMX_MAX_SECFEED_SIZE)
+               return -1;      /* internal error should never happen */
 
        /* to be sure always set secbuf */
        sec->secbuf = sec->secbuf_base + sec->secbufp;
 
-       for(n = 0; sec->secbufp + 2 < limit; n++)
-       {
+       for (n = 0; sec->secbufp + 2 < limit; n++) {
                seclen = section_length(sec->secbuf);
-               if(seclen <= 0 || seclen > DMX_MAX_SECFEED_SIZE
-                  || seclen + sec->secbufp > limit)
+               if (seclen <= 0 || seclen > DMX_MAX_SECTION_SIZE
+                   || seclen + sec->secbufp > limit)
                        return 0;
                sec->seclen = seclen;
                sec->crc_val = ~0;
                /* dump [secbuf .. secbuf+seclen) */
-               if(feed->pusi_seen)
+               if (feed->pusi_seen)
                        dvb_dmx_swfilter_section_feed(feed);
 #ifdef DVB_DEMUX_SECTION_LOSS_LOG
                else
                        printk("dvb_demux.c pusi not seen, discarding section data\n");
 #endif
-               sec->secbufp += seclen; /* secbufp and secbuf moving together is */
-               sec->secbuf += seclen; /* redundand but saves pointer arithmetic */
+               sec->secbufp += seclen; /* secbufp and secbuf moving together is */
+               sec->secbuf += seclen;  /* redundant but saves pointer arithmetic */
        }
 
        return 0;
 }
 
-
-static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed, const u8 *buf)
+static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed,
+                                          const u8 *buf)
 {
        u8 p, count;
        int ccok, dc_i = 0;
@@ -309,10 +285,10 @@ static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed, const u8
 
        count = payload(buf);
 
-       if (count == 0)  /* count == 0 if no payload or out of range */
+       if (count == 0)         /* count == 0 if no payload or out of range */
                return -1;
 
-       p = 188 - count; /* payload start */
+       p = 188 - count;        /* payload start */
 
        cc = buf[3] & 0x0f;
        ccok = ((feed->cc + 1) & 0x0f) == cc;
@@ -326,51 +302,53 @@ static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed, const u8
 
        if (!ccok || dc_i) {
 #ifdef DVB_DEMUX_SECTION_LOSS_LOG
-               printk("dvb_demux.c discontinuity detected %d bytes lost\n", count);
-               /* those bytes under sume circumstances will again be reported
-               ** in the following dvb_dmx_swfilter_section_new
-               */
+               printk("dvb_demux.c discontinuity detected %d bytes lost\n",
+                      count);
+               /*
+                * those bytes under sume circumstances will again be reported
+                * in the following dvb_dmx_swfilter_section_new
+                */
 #endif
-               /* Discontinuity detected. Reset pusi_seen = 0 to
-               ** stop feeding of suspicious data until next PUSI=1 arrives
-               */
+               /*
+                * Discontinuity detected. Reset pusi_seen = 0 to
+                * stop feeding of suspicious data until next PUSI=1 arrives
+                */
                feed->pusi_seen = 0;
                dvb_dmx_swfilter_section_new(feed);
        }
 
        if (buf[1] & 0x40) {
-               // PUSI=1 (is set), section boundary is here
+               /* PUSI=1 (is set), section boundary is here */
                if (count > 1 && buf[p] < count) {
-                       const u8 *before = buf+p+1;
+                       const u8 *before = &buf[p + 1];
                        u8 before_len = buf[p];
-                       const u8 *after = before+before_len;
-                       u8 after_len = count-1-before_len;
+                       const u8 *after = &before[before_len];
+                       u8 after_len = count - 1 - before_len;
 
-                       dvb_dmx_swfilter_section_copy_dump(feed, before, before_len);
+                       dvb_dmx_swfilter_section_copy_dump(feed, before,
+                                                          before_len);
                        /* before start of new section, set pusi_seen = 1 */
                        feed->pusi_seen = 1;
                        dvb_dmx_swfilter_section_new(feed);
-                       dvb_dmx_swfilter_section_copy_dump(feed, after, after_len);
+                       dvb_dmx_swfilter_section_copy_dump(feed, after,
+                                                          after_len);
                }
 #ifdef DVB_DEMUX_SECTION_LOSS_LOG
-               else
-                       if (count > 0)
-                               printk("dvb_demux.c PUSI=1 but %d bytes lost\n", count);
+               else if (count > 0)
+                       printk("dvb_demux.c PUSI=1 but %d bytes lost\n", count);
 #endif
        } else {
-               // PUSI=0 (is not set), no section boundary
-               const u8 *entire = buf+p;
-               u8 entire_len = count;
-
-               dvb_dmx_swfilter_section_copy_dump(feed, entire, entire_len);
+               /* PUSI=0 (is not set), no section boundary */
+               dvb_dmx_swfilter_section_copy_dump(feed, &buf[p], count);
        }
+
        return 0;
 }
 
-
-static inline void dvb_dmx_swfilter_packet_type(struct dvb_demux_feed *feed, const u8 *buf)
+static inline void dvb_dmx_swfilter_packet_type(struct dvb_demux_feed *feed,
+                                               const u8 *buf)
 {
-       switch(feed->type) {
+       switch (feed->type) {
        case DMX_TYPE_TS:
                if (!feed->feed.ts.is_filtering)
                        break;
@@ -378,7 +356,8 @@ static inline void dvb_dmx_swfilter_packet_type(struct dvb_demux_feed *feed, con
                        if (feed->ts_type & TS_PAYLOAD_ONLY)
                                dvb_dmx_swfilter_payload(feed, buf);
                        else
-                               feed->cb.ts(buf, 188, NULL, 0, &feed->feed.ts, DMX_OK);
+                               feed->cb.ts(buf, 188, NULL, 0, &feed->feed.ts,
+                                           DMX_OK);
                }
                if (feed->ts_type & TS_DECODER)
                        if (feed->demux->write_to_decoder)
@@ -389,7 +368,7 @@ static inline void dvb_dmx_swfilter_packet_type(struct dvb_demux_feed *feed, con
                if (!feed->feed.sec.is_filtering)
                        break;
                if (dvb_dmx_swfilter_section_packet(feed, buf) < 0)
-                       feed->feed.sec.seclen = feed->feed.sec.secbufp=0;
+                       feed->feed.sec.seclen = feed->feed.sec.secbufp = 0;
                break;
 
        default:
@@ -400,18 +379,45 @@ static inline void dvb_dmx_swfilter_packet_type(struct dvb_demux_feed *feed, con
 #define DVR_FEED(f)                                                    \
        (((f)->type == DMX_TYPE_TS) &&                                  \
        ((f)->feed.ts.is_filtering) &&                                  \
-       (((f)->ts_type & (TS_PACKET|TS_PAYLOAD_ONLY)) == TS_PACKET))
+       (((f)->ts_type & (TS_PACKET | TS_DEMUX)) == TS_PACKET))
 
 static void dvb_dmx_swfilter_packet(struct dvb_demux *demux, const u8 *buf)
 {
        struct dvb_demux_feed *feed;
-       struct list_head *pos, *head=&demux->feed_list;
        u16 pid = ts_pid(buf);
        int dvr_done = 0;
 
-       list_for_each(pos, head) {
-               feed = list_entry(pos, struct dvb_demux_feed, list_head);
+       if (dvb_demux_tscheck) {
+               if (!demux->cnt_storage)
+                       demux->cnt_storage = vmalloc(MAX_PID + 1);
 
+               if (!demux->cnt_storage) {
+                       printk(KERN_WARNING "Couldn't allocate memory for TS/TEI check. Disabling it\n");
+                       dvb_demux_tscheck = 0;
+                       goto no_dvb_demux_tscheck;
+               }
+
+               /* check pkt counter */
+               if (pid < MAX_PID) {
+                       if (buf[1] & 0x80)
+                               dprintk_tscheck("TEI detected. "
+                                               "PID=0x%x data1=0x%x\n",
+                                               pid, buf[1]);
+
+                       if ((buf[3] & 0xf) != demux->cnt_storage[pid])
+                               dprintk_tscheck("TS packet counter mismatch. "
+                                               "PID=0x%x expected 0x%x "
+                                               "got 0x%x\n",
+                                               pid, demux->cnt_storage[pid],
+                                               buf[3] & 0xf);
+
+                       demux->cnt_storage[pid] = ((buf[3] & 0xf) + 1)&0xf;
+               };
+               /* end check */
+       };
+no_dvb_demux_tscheck:
+
+       list_for_each_entry(feed, &demux->feed_list, list_head) {
                if ((feed->pid != pid) && (feed->pid != 0x2000))
                        continue;
 
@@ -420,32 +426,28 @@ static void dvb_dmx_swfilter_packet(struct dvb_demux *demux, const u8 *buf)
                if ((DVR_FEED(feed)) && (dvr_done++))
                        continue;
 
-               if (feed->pid == pid) {
+               if (feed->pid == pid)
                        dvb_dmx_swfilter_packet_type(feed, buf);
-                       if (DVR_FEED(feed))
-                               continue;
-               }
-
-               if (feed->pid == 0x2000)
+               else if (feed->pid == 0x2000)
                        feed->cb.ts(buf, 188, NULL, 0, &feed->feed.ts, DMX_OK);
        }
 }
 
-void dvb_dmx_swfilter_packets(struct dvb_demux *demux, const u8 *buf, size_t count)
+void dvb_dmx_swfilter_packets(struct dvb_demux *demux, const u8 *buf,
+                             size_t count)
 {
        spin_lock(&demux->lock);
 
        while (count--) {
-               if(buf[0] == 0x47) {
-                       dvb_dmx_swfilter_packet(demux, buf);
-               }
+               if (buf[0] == 0x47)
+                       dvb_dmx_swfilter_packet(demux, buf);
                buf += 188;
        }
 
        spin_unlock(&demux->lock);
 }
-EXPORT_SYMBOL(dvb_dmx_swfilter_packets);
 
+EXPORT_SYMBOL(dvb_dmx_swfilter_packets);
 
 void dvb_dmx_swfilter(struct dvb_demux *demux, const u8 *buf, size_t count)
 {
@@ -453,8 +455,10 @@ void dvb_dmx_swfilter(struct dvb_demux *demux, const u8 *buf, size_t count)
 
        spin_lock(&demux->lock);
 
-       if ((i = demux->tsbufp)) {
-               if (count < (j=188-i)) {
+       if (demux->tsbufp) {
+               i = demux->tsbufp;
+               j = 188 - i;
+               if (count < j) {
                        memcpy(&demux->tsbuf[i], buf, count);
                        demux->tsbufp += count;
                        goto bailout;
@@ -468,13 +472,13 @@ void dvb_dmx_swfilter(struct dvb_demux *demux, const u8 *buf, size_t count)
 
        while (p < count) {
                if (buf[p] == 0x47) {
-                       if (count-p >= 188) {
-                               dvb_dmx_swfilter_packet(demux, buf+p);
+                       if (count - p >= 188) {
+                               dvb_dmx_swfilter_packet(demux, &buf[p]);
                                p += 188;
                        } else {
-                               i = count-p;
-                               memcpy(demux->tsbuf, buf+p, i);
-                               demux->tsbufp=i;
+                               i = count - p;
+                               memcpy(demux->tsbuf, &buf[p], i);
+                               demux->tsbufp = i;
                                goto bailout;
                        }
                } else
@@ -484,24 +488,29 @@ void dvb_dmx_swfilter(struct dvb_demux *demux, const u8 *buf, size_t count)
 bailout:
        spin_unlock(&demux->lock);
 }
+
 EXPORT_SYMBOL(dvb_dmx_swfilter);
 
 void dvb_dmx_swfilter_204(struct dvb_demux *demux, const u8 *buf, size_t count)
 {
-       int p = 0,i, j;
+       int p = 0, i, j;
        u8 tmppack[188];
+
        spin_lock(&demux->lock);
 
-       if ((i = demux->tsbufp)) {
-               if (count < (j=204-i)) {
+       if (demux->tsbufp) {
+               i = demux->tsbufp;
+               j = 204 - i;
+               if (count < j) {
                        memcpy(&demux->tsbuf[i], buf, count);
                        demux->tsbufp += count;
                        goto bailout;
                }
                memcpy(&demux->tsbuf[i], buf, j);
-               if ((demux->tsbuf[0] == 0x47)|(demux->tsbuf[0]==0xB8))  {
+               if ((demux->tsbuf[0] == 0x47) || (demux->tsbuf[0] == 0xB8)) {
                        memcpy(tmppack, demux->tsbuf, 188);
-                       if (tmppack[0] == 0xB8) tmppack[0] = 0x47;
+                       if (tmppack[0] == 0xB8)
+                               tmppack[0] = 0x47;
                        dvb_dmx_swfilter_packet(demux, tmppack);
                }
                demux->tsbufp = 0;
@@ -509,16 +518,17 @@ void dvb_dmx_swfilter_204(struct dvb_demux *demux, const u8 *buf, size_t count)
        }
 
        while (p < count) {
-               if ((buf[p] == 0x47)|(buf[p] == 0xB8)) {
-                       if (count-p >= 204) {
-                               memcpy(tmppack, buf+p, 188);
-                               if (tmppack[0] == 0xB8) tmppack[0] = 0x47;
+               if ((buf[p] == 0x47) || (buf[p] == 0xB8)) {
+                       if (count - p >= 204) {
+                               memcpy(tmppack, &buf[p], 188);
+                               if (tmppack[0] == 0xB8)
+                                       tmppack[0] = 0x47;
                                dvb_dmx_swfilter_packet(demux, tmppack);
                                p += 204;
                        } else {
-                               i = count-p;
-                               memcpy(demux->tsbuf, buf+p, i);
-                               demux->tsbufp=i;
+                               i = count - p;
+                               memcpy(demux->tsbuf, &buf[p], i);
+                               demux->tsbufp = i;
                                goto bailout;
                        }
                } else {
@@ -529,14 +539,14 @@ void dvb_dmx_swfilter_204(struct dvb_demux *demux, const u8 *buf, size_t count)
 bailout:
        spin_unlock(&demux->lock);
 }
-EXPORT_SYMBOL(dvb_dmx_swfilter_204);
 
+EXPORT_SYMBOL(dvb_dmx_swfilter_204);
 
-static struct dvb_demux_filter * dvb_dmx_filter_alloc(struct dvb_demux *demux)
+static struct dvb_demux_filter *dvb_dmx_filter_alloc(struct dvb_demux *demux)
 {
        int i;
 
-       for (i=0; i<demux->filternum; i++)
+       for (i = 0; i < demux->filternum; i++)
                if (demux->filter[i].state == DMX_STATE_FREE)
                        break;
 
@@ -548,11 +558,11 @@ static struct dvb_demux_filter * dvb_dmx_filter_alloc(struct dvb_demux *demux)
        return &demux->filter[i];
 }
 
-static struct dvb_demux_feed * dvb_dmx_feed_alloc(struct dvb_demux *demux)
+static struct dvb_demux_feed *dvb_dmx_feed_alloc(struct dvb_demux *demux)
 {
        int i;
 
-       for (i=0; i<demux->feednum; i++)
+       for (i = 0; i < demux->feednum; i++)
                if (demux->feed[i].state == DMX_STATE_FREE)
                        break;
 
@@ -580,7 +590,7 @@ static void dvb_demux_feed_add(struct dvb_demux_feed *feed)
        spin_lock_irq(&feed->demux->lock);
        if (dvb_demux_feed_find(feed)) {
                printk(KERN_ERR "%s: feed already in list (type=%x state=%x pid=%x)\n",
-                               __FUNCTION__, feed->type, feed->state, feed->pid);
+                      __func__, feed->type, feed->state, feed->pid);
                goto out;
        }
 
@@ -594,7 +604,7 @@ static void dvb_demux_feed_del(struct dvb_demux_feed *feed)
        spin_lock_irq(&feed->demux->lock);
        if (!(dvb_demux_feed_find(feed))) {
                printk(KERN_ERR "%s: feed not in list (type=%x state=%x pid=%x)\n",
-                               __FUNCTION__, feed->type, feed->state, feed->pid);
+                      __func__, feed->type, feed->state, feed->pid);
                goto out;
        }
 
@@ -603,29 +613,28 @@ out:
        spin_unlock_irq(&feed->demux->lock);
 }
 
-static int dmx_ts_feed_set (struct dmx_ts_feed* ts_feed, u16 pid, int ts_type,
-                    enum dmx_ts_pes pes_type, size_t callback_length,
-                    size_t circular_buffer_size, int descramble,
-                    struct timespec timeout)
+static int dmx_ts_feed_set(struct dmx_ts_feed *ts_feed, u16 pid, int ts_type,
+                          enum dmx_ts_pes pes_type,
+                          size_t circular_buffer_size, struct timespec timeout)
 {
-       struct dvb_demux_feed *feed = (struct dvb_demux_feed *) ts_feed;
+       struct dvb_demux_feed *feed = (struct dvb_demux_feed *)ts_feed;
        struct dvb_demux *demux = feed->demux;
 
        if (pid > DMX_MAX_PID)
                return -EINVAL;
 
-       if (down_interruptible (&demux->mutex))
+       if (mutex_lock_interruptible(&demux->mutex))
                return -ERESTARTSYS;
 
        if (ts_type & TS_DECODER) {
                if (pes_type >= DMX_TS_PES_OTHER) {
-                       up(&demux->mutex);
+                       mutex_unlock(&demux->mutex);
                        return -EINVAL;
                }
 
                if (demux->pesfilter[pes_type] &&
                    demux->pesfilter[pes_type] != feed) {
-                       up(&demux->mutex);
+                       mutex_unlock(&demux->mutex);
                        return -EINVAL;
                }
 
@@ -637,57 +646,49 @@ static int dmx_ts_feed_set (struct dmx_ts_feed* ts_feed, u16 pid, int ts_type,
 
        feed->pid = pid;
        feed->buffer_size = circular_buffer_size;
-       feed->descramble = descramble;
        feed->timeout = timeout;
-       feed->cb_length = callback_length;
        feed->ts_type = ts_type;
        feed->pes_type = pes_type;
 
-       if (feed->descramble) {
-               up(&demux->mutex);
-               return -ENOSYS;
-       }
-
        if (feed->buffer_size) {
 #ifdef NOBUFS
-               feed->buffer=NULL;
+               feed->buffer = NULL;
 #else
                feed->buffer = vmalloc(feed->buffer_size);
                if (!feed->buffer) {
-                       up(&demux->mutex);
+                       mutex_unlock(&demux->mutex);
                        return -ENOMEM;
                }
 #endif
        }
 
        feed->state = DMX_STATE_READY;
-       up(&demux->mutex);
+       mutex_unlock(&demux->mutex);
 
        return 0;
 }
 
-
-static int dmx_ts_feed_start_filtering(struct dmx_ts_feed* ts_feed)
+static int dmx_ts_feed_start_filtering(struct dmx_ts_feed *ts_feed)
 {
-       struct dvb_demux_feed *feed = (struct dvb_demux_feed *) ts_feed;
+       struct dvb_demux_feed *feed = (struct dvb_demux_feed *)ts_feed;
        struct dvb_demux *demux = feed->demux;
        int ret;
 
-       if (down_interruptible (&demux->mutex))
+       if (mutex_lock_interruptible(&demux->mutex))
                return -ERESTARTSYS;
 
        if (feed->state != DMX_STATE_READY || feed->type != DMX_TYPE_TS) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -EINVAL;
        }
 
        if (!demux->start_feed) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -ENODEV;
        }
 
        if ((ret = demux->start_feed(feed)) < 0) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return ret;
        }
 
@@ -695,27 +696,26 @@ static int dmx_ts_feed_start_filtering(struct dmx_ts_feed* ts_feed)
        ts_feed->is_filtering = 1;
        feed->state = DMX_STATE_GO;
        spin_unlock_irq(&demux->lock);
-       up(&demux->mutex);
+       mutex_unlock(&demux->mutex);
 
        return 0;
 }
 
-static int dmx_ts_feed_stop_filtering(struct dmx_ts_feedts_feed)
+static int dmx_ts_feed_stop_filtering(struct dmx_ts_feed *ts_feed)
 {
-       struct dvb_demux_feed *feed = (struct dvb_demux_feed *) ts_feed;
+       struct dvb_demux_feed *feed = (struct dvb_demux_feed *)ts_feed;
        struct dvb_demux *demux = feed->demux;
        int ret;
 
-       if (down_interruptible (&demux->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&demux->mutex);
 
        if (feed->state < DMX_STATE_GO) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -EINVAL;
        }
 
        if (!demux->stop_feed) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -ENODEV;
        }
 
@@ -725,22 +725,23 @@ static int dmx_ts_feed_stop_filtering(struct dmx_ts_feed* ts_feed)
        ts_feed->is_filtering = 0;
        feed->state = DMX_STATE_ALLOCATED;
        spin_unlock_irq(&demux->lock);
-       up(&demux->mutex);
+       mutex_unlock(&demux->mutex);
 
        return ret;
 }
 
-static int dvbdmx_allocate_ts_feed (struct dmx_demux *dmx, struct dmx_ts_feed **ts_feed,
-                            dmx_ts_cb callback)
+static int dvbdmx_allocate_ts_feed(struct dmx_demux *dmx,
+                                  struct dmx_ts_feed **ts_feed,
+                                  dmx_ts_cb callback)
 {
-       struct dvb_demux *demux = (struct dvb_demux *) dmx;
+       struct dvb_demux *demux = (struct dvb_demux *)dmx;
        struct dvb_demux_feed *feed;
 
-       if (down_interruptible (&demux->mutex))
+       if (mutex_lock_interruptible(&demux->mutex))
                return -ERESTARTSYS;
 
        if (!(feed = dvb_dmx_feed_alloc(demux))) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -EBUSY;
        }
 
@@ -759,10 +760,9 @@ static int dvbdmx_allocate_ts_feed (struct dmx_demux *dmx, struct dmx_ts_feed **
        (*ts_feed)->stop_filtering = dmx_ts_feed_stop_filtering;
        (*ts_feed)->set = dmx_ts_feed_set;
 
-
        if (!(feed->filter = dvb_dmx_filter_alloc(demux))) {
                feed->state = DMX_STATE_FREE;
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -EBUSY;
        }
 
@@ -770,27 +770,26 @@ static int dvbdmx_allocate_ts_feed (struct dmx_demux *dmx, struct dmx_ts_feed **
        feed->filter->feed = feed;
        feed->filter->state = DMX_STATE_READY;
 
-       up(&demux->mutex);
+       mutex_unlock(&demux->mutex);
 
        return 0;
 }
 
-static int dvbdmx_release_ts_feed(struct dmx_demux *dmx, struct dmx_ts_feed *ts_feed)
+static int dvbdmx_release_ts_feed(struct dmx_demux *dmx,
+                                 struct dmx_ts_feed *ts_feed)
 {
-       struct dvb_demux *demux = (struct dvb_demux *) dmx;
-       struct dvb_demux_feed *feed = (struct dvb_demux_feed *) ts_feed;
+       struct dvb_demux *demux = (struct dvb_demux *)dmx;
+       struct dvb_demux_feed *feed = (struct dvb_demux_feed *)ts_feed;
 
-       if (down_interruptible (&demux->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&demux->mutex);
 
        if (feed->state == DMX_STATE_FREE) {
-               up(&demux->mutex);
+               mutex_unlock(&demux->mutex);
                return -EINVAL;
        }
-
 #ifndef NOBUFS
        vfree(feed->buffer);
-       feed->buffer=0;
+       feed->buffer = NULL;
 #endif
 
        feed->state = DMX_STATE_FREE;
@@ -803,28 +802,27 @@ static int dvbdmx_release_ts_feed(struct dmx_demux *dmx, struct dmx_ts_feed *ts_
        if (feed->ts_type & TS_DECODER && feed->pes_type < DMX_TS_PES_OTHER)
                demux->pesfilter[feed->pes_type] = NULL;
 
-       up(&demux->mutex);
+       mutex_unlock(&demux->mutex);
        return 0;
 }
 
-
 /******************************************************************************
  * dmx_section_feed API calls
  ******************************************************************************/
 
-static int dmx_section_feed_allocate_filter(struct dmx_section_feedfeed,
-                                    struct dmx_section_filter** filter)
+static int dmx_section_feed_allocate_filter(struct dmx_section_feed *feed,
+                                           struct dmx_section_filter **filter)
 {
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
        struct dvb_demux *dvbdemux = dvbdmxfeed->demux;
        struct dvb_demux_filter *dvbdmxfilter;
 
-       if (down_interruptible (&dvbdemux->mutex))
+       if (mutex_lock_interruptible(&dvbdemux->mutex))
                return -ERESTARTSYS;
 
        dvbdmxfilter = dvb_dmx_filter_alloc(dvbdemux);
        if (!dvbdmxfilter) {
-               up(&dvbdemux->mutex);
+               mutex_unlock(&dvbdemux->mutex);
                return -EBUSY;
        }
 
@@ -839,52 +837,44 @@ static int dmx_section_feed_allocate_filter(struct dmx_section_feed* feed,
        dvbdmxfeed->filter = dvbdmxfilter;
        spin_unlock_irq(&dvbdemux->lock);
 
-       up(&dvbdemux->mutex);
+       mutex_unlock(&dvbdemux->mutex);
        return 0;
 }
 
-
-static int dmx_section_feed_set(struct dmx_section_feed* feed,
-                        u16 pid, size_t circular_buffer_size,
-                        int descramble, int check_crc)
+static int dmx_section_feed_set(struct dmx_section_feed *feed,
+                               u16 pid, size_t circular_buffer_size,
+                               int check_crc)
 {
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
        struct dvb_demux *dvbdmx = dvbdmxfeed->demux;
 
        if (pid > 0x1fff)
                return -EINVAL;
 
-       if (down_interruptible (&dvbdmx->mutex))
+       if (mutex_lock_interruptible(&dvbdmx->mutex))
                return -ERESTARTSYS;
 
        dvb_demux_feed_add(dvbdmxfeed);
 
        dvbdmxfeed->pid = pid;
        dvbdmxfeed->buffer_size = circular_buffer_size;
-       dvbdmxfeed->descramble = descramble;
-       if (dvbdmxfeed->descramble) {
-               up(&dvbdmx->mutex);
-               return -ENOSYS;
-       }
-
        dvbdmxfeed->feed.sec.check_crc = check_crc;
 
 #ifdef NOBUFS
        dvbdmxfeed->buffer = NULL;
 #else
-       dvbdmxfeed->buffer=vmalloc(dvbdmxfeed->buffer_size);
+       dvbdmxfeed->buffer = vmalloc(dvbdmxfeed->buffer_size);
        if (!dvbdmxfeed->buffer) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -ENOMEM;
        }
 #endif
 
        dvbdmxfeed->state = DMX_STATE_READY;
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return 0;
 }
 
-
 static void prepare_secfilters(struct dvb_demux_feed *dvbdmxfeed)
 {
        int i;
@@ -892,12 +882,12 @@ static void prepare_secfilters(struct dvb_demux_feed *dvbdmxfeed)
        struct dmx_section_filter *sf;
        u8 mask, mode, doneq;
 
-       if (!(f=dvbdmxfeed->filter))
+       if (!(f = dvbdmxfeed->filter))
                return;
        do {
                sf = &f->filter;
                doneq = 0;
-               for (i=0; i<DVB_DEMUX_MASK_MAX; i++) {
+               for (i = 0; i < DVB_DEMUX_MASK_MAX; i++) {
                        mode = sf->filter_mode[i];
                        mask = sf->filter_mask[i];
                        f->maskandmode[i] = mask & mode;
@@ -907,23 +897,22 @@ static void prepare_secfilters(struct dvb_demux_feed *dvbdmxfeed)
        } while ((f = f->next));
 }
 
-
 static int dmx_section_feed_start_filtering(struct dmx_section_feed *feed)
 {
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
        struct dvb_demux *dvbdmx = dvbdmxfeed->demux;
        int ret;
 
-       if (down_interruptible (&dvbdmx->mutex))
+       if (mutex_lock_interruptible(&dvbdmx->mutex))
                return -ERESTARTSYS;
 
        if (feed->is_filtering) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -EBUSY;
        }
 
        if (!dvbdmxfeed->filter) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -EINVAL;
        }
 
@@ -933,14 +922,14 @@ static int dmx_section_feed_start_filtering(struct dmx_section_feed *feed)
        dvbdmxfeed->feed.sec.seclen = 0;
 
        if (!dvbdmx->start_feed) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -ENODEV;
        }
 
        prepare_secfilters(dvbdmxfeed);
 
        if ((ret = dvbdmx->start_feed(dvbdmxfeed)) < 0) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return ret;
        }
 
@@ -949,22 +938,20 @@ static int dmx_section_feed_start_filtering(struct dmx_section_feed *feed)
        dvbdmxfeed->state = DMX_STATE_GO;
        spin_unlock_irq(&dvbdmx->lock);
 
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return 0;
 }
 
-
-static int dmx_section_feed_stop_filtering(struct dmx_section_feed* feed)
+static int dmx_section_feed_stop_filtering(struct dmx_section_feed *feed)
 {
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
        struct dvb_demux *dvbdmx = dvbdmxfeed->demux;
        int ret;
 
-       if (down_interruptible (&dvbdmx->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&dvbdmx->mutex);
 
        if (!dvbdmx->stop_feed) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -ENODEV;
        }
 
@@ -975,23 +962,21 @@ static int dmx_section_feed_stop_filtering(struct dmx_section_feed* feed)
        feed->is_filtering = 0;
        spin_unlock_irq(&dvbdmx->lock);
 
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return ret;
 }
 
-
 static int dmx_section_feed_release_filter(struct dmx_section_feed *feed,
-                               struct dmx_section_filter* filter)
+                                          struct dmx_section_filter *filter)
 {
-       struct dvb_demux_filter *dvbdmxfilter = (struct dvb_demux_filter *) filter, *f;
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
+       struct dvb_demux_filter *dvbdmxfilter = (struct dvb_demux_filter *)filter, *f;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
        struct dvb_demux *dvbdmx = dvbdmxfeed->demux;
 
-       if (down_interruptible (&dvbdmx->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&dvbdmx->mutex);
 
        if (dvbdmxfilter->feed != dvbdmxfeed) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -EINVAL;
        }
 
@@ -1004,14 +989,14 @@ static int dmx_section_feed_release_filter(struct dmx_section_feed *feed,
        if (f == dvbdmxfilter) {
                dvbdmxfeed->filter = dvbdmxfilter->next;
        } else {
-               while(f->next != dvbdmxfilter)
+               while (f->next != dvbdmxfilter)
                        f = f->next;
                f->next = f->next->next;
        }
 
        dvbdmxfilter->state = DMX_STATE_FREE;
        spin_unlock_irq(&dvbdmx->lock);
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return 0;
 }
 
@@ -1019,14 +1004,14 @@ static int dvbdmx_allocate_section_feed(struct dmx_demux *demux,
                                        struct dmx_section_feed **feed,
                                        dmx_section_cb callback)
 {
-       struct dvb_demux *dvbdmx = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdmx = (struct dvb_demux *)demux;
        struct dvb_demux_feed *dvbdmxfeed;
 
-       if (down_interruptible (&dvbdmx->mutex))
+       if (mutex_lock_interruptible(&dvbdmx->mutex))
                return -ERESTARTSYS;
 
        if (!(dvbdmxfeed = dvb_dmx_feed_alloc(dvbdmx))) {
-               up(&dvbdmx->mutex);
+               mutex_unlock(&dvbdmx->mutex);
                return -EBUSY;
        }
 
@@ -1040,7 +1025,7 @@ static int dvbdmx_allocate_section_feed(struct dmx_demux *demux,
        dvbdmxfeed->filter = NULL;
        dvbdmxfeed->buffer = NULL;
 
-       (*feed)=&dvbdmxfeed->feed.sec;
+       (*feed) = &dvbdmxfeed->feed.sec;
        (*feed)->is_filtering = 0;
        (*feed)->parent = demux;
        (*feed)->priv = NULL;
@@ -1051,45 +1036,43 @@ static int dvbdmx_allocate_section_feed(struct dmx_demux *demux,
        (*feed)->stop_filtering = dmx_section_feed_stop_filtering;
        (*feed)->release_filter = dmx_section_feed_release_filter;
 
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return 0;
 }
 
 static int dvbdmx_release_section_feed(struct dmx_demux *demux,
                                       struct dmx_section_feed *feed)
 {
-       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) feed;
-       struct dvb_demux *dvbdmx = (struct dvb_demux *) demux;
+       struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)feed;
+       struct dvb_demux *dvbdmx = (struct dvb_demux *)demux;
 
-       if (down_interruptible (&dvbdmx->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&dvbdmx->mutex);
 
-       if (dvbdmxfeed->state==DMX_STATE_FREE) {
-               up(&dvbdmx->mutex);
+       if (dvbdmxfeed->state == DMX_STATE_FREE) {
+               mutex_unlock(&dvbdmx->mutex);
                return -EINVAL;
        }
 #ifndef NOBUFS
        vfree(dvbdmxfeed->buffer);
-       dvbdmxfeed->buffer=0;
+       dvbdmxfeed->buffer = NULL;
 #endif
-       dvbdmxfeed->state=DMX_STATE_FREE;
+       dvbdmxfeed->state = DMX_STATE_FREE;
 
        dvb_demux_feed_del(dvbdmxfeed);
 
        dvbdmxfeed->pid = 0xffff;
 
-       up(&dvbdmx->mutex);
+       mutex_unlock(&dvbdmx->mutex);
        return 0;
 }
 
-
 /******************************************************************************
  * dvb_demux kernel data API calls
  ******************************************************************************/
 
 static int dvbdmx_open(struct dmx_demux *demux)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
        if (dvbdemux->users >= MAX_DVB_DEMUX_USERS)
                return -EUSERS;
@@ -1098,10 +1081,9 @@ static int dvbdmx_open(struct dmx_demux *demux)
        return 0;
 }
 
-
 static int dvbdmx_close(struct dmx_demux *demux)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
        if (dvbdemux->users == 0)
                return -ENODEV;
@@ -1111,28 +1093,38 @@ static int dvbdmx_close(struct dmx_demux *demux)
        return 0;
 }
 
-
-static int dvbdmx_write(struct dmx_demux *demux, const char *buf, size_t count)
+static int dvbdmx_write(struct dmx_demux *demux, const char __user *buf, size_t count)
 {
-       struct dvb_demux *dvbdemux=(struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
+       void *p;
 
        if ((!demux->frontend) || (demux->frontend->source != DMX_MEMORY_FE))
                return -EINVAL;
 
-       if (down_interruptible (&dvbdemux->mutex))
+       p = kmalloc(count, GFP_USER);
+       if (!p)
+               return -ENOMEM;
+       if (copy_from_user(p, buf, count)) {
+               kfree(p);
+               return -EFAULT;
+       }
+       if (mutex_lock_interruptible(&dvbdemux->mutex)) {
+               kfree(p);
                return -ERESTARTSYS;
-       dvb_dmx_swfilter(dvbdemux, buf, count);
-       up(&dvbdemux->mutex);
+       }
+       dvb_dmx_swfilter(dvbdemux, p, count);
+       kfree(p);
+       mutex_unlock(&dvbdemux->mutex);
 
        if (signal_pending(current))
                return -EINTR;
        return count;
 }
 
-
-static int dvbdmx_add_frontend(struct dmx_demux *demux, struct dmx_frontend *frontend)
+static int dvbdmx_add_frontend(struct dmx_demux *demux,
+                              struct dmx_frontend *frontend)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
        struct list_head *head = &dvbdemux->frontend_list;
 
        list_add(&(frontend->connectivity_list), head);
@@ -1140,13 +1132,13 @@ static int dvbdmx_add_frontend(struct dmx_demux *demux, struct dmx_frontend *fro
        return 0;
 }
 
-
-static int dvbdmx_remove_frontend(struct dmx_demux *demux, struct dmx_frontend *frontend)
+static int dvbdmx_remove_frontend(struct dmx_demux *demux,
+                                 struct dmx_frontend *frontend)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
        struct list_head *pos, *n, *head = &dvbdemux->frontend_list;
 
-       list_for_each_safe (pos, n, head) {
+       list_for_each_safe(pos, n, head) {
                if (DMX_FE_ENTRY(pos) == frontend) {
                        list_del(pos);
                        return 0;
@@ -1156,83 +1148,79 @@ static int dvbdmx_remove_frontend(struct dmx_demux *demux, struct dmx_frontend *
        return -ENODEV;
 }
 
-
-static struct list_head * dvbdmx_get_frontends(struct dmx_demux *demux)
+static struct list_head *dvbdmx_get_frontends(struct dmx_demux *demux)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
        if (list_empty(&dvbdemux->frontend_list))
                return NULL;
+
        return &dvbdemux->frontend_list;
 }
 
-
-static int dvbdmx_connect_frontend(struct dmx_demux *demux, struct dmx_frontend *frontend)
+static int dvbdmx_connect_frontend(struct dmx_demux *demux,
+                                  struct dmx_frontend *frontend)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
        if (demux->frontend)
                return -EINVAL;
 
-       if (down_interruptible (&dvbdemux->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&dvbdemux->mutex);
 
        demux->frontend = frontend;
-       up(&dvbdemux->mutex);
+       mutex_unlock(&dvbdemux->mutex);
        return 0;
 }
 
-
 static int dvbdmx_disconnect_frontend(struct dmx_demux *demux)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
-       if (down_interruptible (&dvbdemux->mutex))
-               return -ERESTARTSYS;
+       mutex_lock(&dvbdemux->mutex);
 
        demux->frontend = NULL;
-       up(&dvbdemux->mutex);
+       mutex_unlock(&dvbdemux->mutex);
        return 0;
 }
 
-
-static int dvbdmx_get_pes_pids(struct dmx_demux *demux, u16 *pids)
+static int dvbdmx_get_pes_pids(struct dmx_demux *demux, u16 * pids)
 {
-       struct dvb_demux *dvbdemux = (struct dvb_demux *) demux;
+       struct dvb_demux *dvbdemux = (struct dvb_demux *)demux;
 
-       memcpy(pids, dvbdemux->pids, 5*sizeof(u16));
+       memcpy(pids, dvbdemux->pids, 5 * sizeof(u16));
        return 0;
 }
 
-
 int dvb_dmx_init(struct dvb_demux *dvbdemux)
 {
-       int i, err;
+       int i;
        struct dmx_demux *dmx = &dvbdemux->dmx;
 
+       dvbdemux->cnt_storage = NULL;
        dvbdemux->users = 0;
-       dvbdemux->filter = vmalloc(dvbdemux->filternum*sizeof(struct dvb_demux_filter));
+       dvbdemux->filter = vmalloc(dvbdemux->filternum * sizeof(struct dvb_demux_filter));
 
        if (!dvbdemux->filter)
                return -ENOMEM;
 
-       dvbdemux->feed = vmalloc(dvbdemux->feednum*sizeof(struct dvb_demux_feed));
+       dvbdemux->feed = vmalloc(dvbdemux->feednum * sizeof(struct dvb_demux_feed));
        if (!dvbdemux->feed) {
                vfree(dvbdemux->filter);
                return -ENOMEM;
        }
-       for (i=0; i<dvbdemux->filternum; i++) {
+       for (i = 0; i < dvbdemux->filternum; i++) {
                dvbdemux->filter[i].state = DMX_STATE_FREE;
                dvbdemux->filter[i].index = i;
        }
-       for (i=0; i<dvbdemux->feednum; i++) {
+       for (i = 0; i < dvbdemux->feednum; i++) {
                dvbdemux->feed[i].state = DMX_STATE_FREE;
                dvbdemux->feed[i].index = i;
        }
-       dvbdemux->frontend_list.next=
-         dvbdemux->frontend_list.prev=
-           &dvbdemux->frontend_list;
-       for (i=0; i<DMX_TS_PES_OTHER; i++) {
+
+       INIT_LIST_HEAD(&dvbdemux->frontend_list);
+
+       for (i = 0; i < DMX_TS_PES_OTHER; i++) {
                dvbdemux->pesfilter[i] = NULL;
                dvbdemux->pids[i] = 0xffff;
        }
@@ -1246,12 +1234,11 @@ int dvb_dmx_init(struct dvb_demux *dvbdemux)
        if (!dvbdemux->check_crc32)
                dvbdemux->check_crc32 = dvb_dmx_crc32;
 
-        if (!dvbdemux->memcopy)
-                dvbdemux->memcopy = dvb_dmx_memcopy;
+       if (!dvbdemux->memcopy)
+               dvbdemux->memcopy = dvb_dmx_memcopy;
 
        dmx->frontend = NULL;
-       dmx->reg_list.prev = dmx->reg_list.next = &dmx->reg_list;
-       dmx->priv = (void *) dvbdemux;
+       dmx->priv = dvbdemux;
        dmx->open = dvbdmx_open;
        dmx->close = dvbdmx_close;
        dmx->write = dvbdmx_write;
@@ -1260,9 +1247,6 @@ int dvb_dmx_init(struct dvb_demux *dvbdemux)
        dmx->allocate_section_feed = dvbdmx_allocate_section_feed;
        dmx->release_section_feed = dvbdmx_release_section_feed;
 
-       dmx->descramble_mac_address = NULL;
-       dmx->descramble_section_payload = NULL;
-
        dmx->add_frontend = dvbdmx_add_frontend;
        dmx->remove_frontend = dvbdmx_remove_frontend;
        dmx->get_frontends = dvbdmx_get_frontends;
@@ -1270,24 +1254,19 @@ int dvb_dmx_init(struct dvb_demux *dvbdemux)
        dmx->disconnect_frontend = dvbdmx_disconnect_frontend;
        dmx->get_pes_pids = dvbdmx_get_pes_pids;
 
-       sema_init(&dvbdemux->mutex, 1);
+       mutex_init(&dvbdemux->mutex);
        spin_lock_init(&dvbdemux->lock);
 
-       if ((err = dmx_register_demux(dmx)) < 0)
-               return err;
-
        return 0;
 }
-EXPORT_SYMBOL(dvb_dmx_init);
 
+EXPORT_SYMBOL(dvb_dmx_init);
 
-int dvb_dmx_release(struct dvb_demux *dvbdemux)
+void dvb_dmx_release(struct dvb_demux *dvbdemux)
 {
-       struct dmx_demux *dmx = &dvbdemux->dmx;
-
-       dmx_unregister_demux(dmx);
+       vfree(dvbdemux->cnt_storage);
        vfree(dvbdemux->filter);
        vfree(dvbdemux->feed);
-       return 0;
 }
+
 EXPORT_SYMBOL(dvb_dmx_release);