of: add 'of_' prefix to machine_is_compatible()
[safe/jmp/linux-2.6] / drivers / macintosh / windfarm_lm75_sensor.c
index 906d3ec..d8257d3 100644 (file)
@@ -15,7 +15,6 @@
 #include <linux/init.h>
 #include <linux/wait.h>
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 #include <asm/prom.h>
 #include <asm/machdep.h>
 #include <asm/io.h>
@@ -25,7 +24,7 @@
 
 #include "windfarm.h"
 
-#define VERSION "0.1"
+#define VERSION "0.2"
 
 #undef DEBUG
 
 struct wf_lm75_sensor {
        int                     ds1775 : 1;
        int                     inited : 1;
-       struct  i2c_client      i2c;
+       struct  i2c_client      *i2c;
        struct  wf_sensor       sens;
 };
 #define wf_to_lm75(c) container_of(c, struct wf_lm75_sensor, sens)
-#define i2c_to_lm75(c) container_of(c, struct wf_lm75_sensor, i2c)
-
-static int wf_lm75_attach(struct i2c_adapter *adapter);
-static int wf_lm75_detach(struct i2c_client *client);
-
-static struct i2c_driver wf_lm75_driver = {
-       .driver = {
-               .name   = "wf_lm75",
-       },
-       .attach_adapter = wf_lm75_attach,
-       .detach_client  = wf_lm75_detach,
-};
 
 static int wf_lm75_get(struct wf_sensor *sr, s32 *value)
 {
        struct wf_lm75_sensor *lm = wf_to_lm75(sr);
        s32 data;
 
-       if (lm->i2c.adapter == NULL)
+       if (lm->i2c == NULL)
                return -ENODEV;
 
        /* Init chip if necessary */
        if (!lm->inited) {
-               u8 cfg_new, cfg = (u8)i2c_smbus_read_byte_data(&lm->i2c, 1);
+               u8 cfg_new, cfg = (u8)i2c_smbus_read_byte_data(lm->i2c, 1);
 
                DBG("wf_lm75: Initializing %s, cfg was: %02x\n",
                    sr->name, cfg);
@@ -74,7 +61,7 @@ static int wf_lm75_get(struct wf_sensor *sr, s32 *value)
                 * the firmware for now
                 */
                cfg_new = cfg & ~0x01;
-               i2c_smbus_write_byte_data(&lm->i2c, 1, cfg_new);
+               i2c_smbus_write_byte_data(lm->i2c, 1, cfg_new);
                lm->inited = 1;
 
                /* If we just powered it up, let's wait 200 ms */
@@ -82,7 +69,7 @@ static int wf_lm75_get(struct wf_sensor *sr, s32 *value)
        }
 
        /* Read temperature register */
-       data = (s32)le16_to_cpu(i2c_smbus_read_word_data(&lm->i2c, 0));
+       data = (s32)le16_to_cpu(i2c_smbus_read_word_data(lm->i2c, 0));
        data <<= 8;
        *value = data;
 
@@ -93,12 +80,6 @@ static void wf_lm75_release(struct wf_sensor *sr)
 {
        struct wf_lm75_sensor *lm = wf_to_lm75(sr);
 
-       /* check if client is registered and detach from i2c */
-       if (lm->i2c.adapter) {
-               i2c_detach_client(&lm->i2c);
-               lm->i2c.adapter = NULL;
-       }
-
        kfree(lm);
 }
 
@@ -108,51 +89,79 @@ static struct wf_sensor_ops wf_lm75_ops = {
        .owner          = THIS_MODULE,
 };
 
-static struct wf_lm75_sensor *wf_lm75_create(struct i2c_adapter *adapter,
+static int wf_lm75_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+       struct wf_lm75_sensor *lm;
+       int rc;
+
+       lm = kzalloc(sizeof(struct wf_lm75_sensor), GFP_KERNEL);
+       if (lm == NULL)
+               return -ENODEV;
+
+       lm->inited = 0;
+       lm->ds1775 = id->driver_data;
+       lm->i2c = client;
+       lm->sens.name = client->dev.platform_data;
+       lm->sens.ops = &wf_lm75_ops;
+       i2c_set_clientdata(client, lm);
+
+       rc = wf_register_sensor(&lm->sens);
+       if (rc) {
+               i2c_set_clientdata(client, NULL);
+               kfree(lm);
+       }
+
+       return rc;
+}
+
+static struct i2c_driver wf_lm75_driver;
+
+static struct i2c_client *wf_lm75_create(struct i2c_adapter *adapter,
                                             u8 addr, int ds1775,
                                             const char *loc)
 {
-       struct wf_lm75_sensor *lm;
+       struct i2c_board_info info;
+       struct i2c_client *client;
+       char *name;
 
        DBG("wf_lm75: creating  %s device at address 0x%02x\n",
            ds1775 ? "ds1775" : "lm75", addr);
 
-       lm = kmalloc(sizeof(struct wf_lm75_sensor), GFP_KERNEL);
-       if (lm == NULL)
-               return NULL;
-       memset(lm, 0, sizeof(struct wf_lm75_sensor));
-
        /* Usual rant about sensor names not beeing very consistent in
         * the device-tree, oh well ...
         * Add more entries below as you deal with more setups
         */
        if (!strcmp(loc, "Hard drive") || !strcmp(loc, "DRIVE BAY"))
-               lm->sens.name = "hd-temp";
+               name = "hd-temp";
+       else if (!strcmp(loc, "Incoming Air Temp"))
+               name = "incoming-air-temp";
+       else if (!strcmp(loc, "ODD Temp"))
+               name = "optical-drive-temp";
+       else if (!strcmp(loc, "HD Temp"))
+               name = "hard-drive-temp";
        else
                goto fail;
 
-       lm->inited = 0;
-       lm->sens.ops = &wf_lm75_ops;
-       lm->ds1775 = ds1775;
-       lm->i2c.addr = (addr >> 1) & 0x7f;
-       lm->i2c.adapter = adapter;
-       lm->i2c.driver = &wf_lm75_driver;
-       strncpy(lm->i2c.name, lm->sens.name, I2C_NAME_SIZE-1);
+       memset(&info, 0, sizeof(struct i2c_board_info));
+       info.addr = (addr >> 1) & 0x7f;
+       info.platform_data = name;
+       strlcpy(info.type, ds1775 ? "wf_ds1775" : "wf_lm75", I2C_NAME_SIZE);
 
-       if (i2c_attach_client(&lm->i2c)) {
+       client = i2c_new_device(adapter, &info);
+       if (client == NULL) {
                printk(KERN_ERR "windfarm: failed to attach %s %s to i2c\n",
-                      ds1775 ? "ds1775" : "lm75", lm->i2c.name);
-               goto fail;
-       }
-
-       if (wf_register_sensor(&lm->sens)) {
-               i2c_detach_client(&lm->i2c);
+                      ds1775 ? "ds1775" : "lm75", name);
                goto fail;
        }
 
-       return lm;
+       /*
+        * Let i2c-core delete that device on driver removal.
+        * This is safe because i2c-core holds the core_lock mutex for us.
+        */
+       list_add_tail(&client->detected, &wf_lm75_driver.clients);
+       return client;
  fail:
-       kfree(lm);
        return NULL;
 }
 
@@ -174,38 +183,66 @@ static int wf_lm75_attach(struct i2c_adapter *adapter)
        for (dev = NULL;
             (dev = of_get_next_child(busnode, dev)) != NULL;) {
                const char *loc =
-                       get_property(dev, "hwsensor-location", NULL);
-               u32 *reg = (u32 *)get_property(dev, "reg", NULL);
-               DBG(" dev: %s... (loc: %p, reg: %p)\n", dev->name, loc, reg);
-               if (loc == NULL || reg == NULL)
+                       of_get_property(dev, "hwsensor-location", NULL);
+               u8 addr;
+
+               /* We must re-match the adapter in order to properly check
+                * the channel on multibus setups
+                */
+               if (!pmac_i2c_match_adapter(dev, adapter))
+                       continue;
+               addr = pmac_i2c_get_dev_addr(dev);
+               if (loc == NULL || addr == 0)
                        continue;
                /* real lm75 */
-               if (device_is_compatible(dev, "lm75"))
-                       wf_lm75_create(adapter, *reg, 0, loc);
+               if (of_device_is_compatible(dev, "lm75"))
+                       wf_lm75_create(adapter, addr, 0, loc);
                /* ds1775 (compatible, better resolution */
-               else if (device_is_compatible(dev, "ds1775"))
-                       wf_lm75_create(adapter, *reg, 1, loc);
+               else if (of_device_is_compatible(dev, "ds1775"))
+                       wf_lm75_create(adapter, addr, 1, loc);
        }
        return 0;
 }
 
-static int wf_lm75_detach(struct i2c_client *client)
+static int wf_lm75_remove(struct i2c_client *client)
 {
-       struct wf_lm75_sensor *lm = i2c_to_lm75(client);
+       struct wf_lm75_sensor *lm = i2c_get_clientdata(client);
 
        DBG("wf_lm75: i2c detatch called for %s\n", lm->sens.name);
 
        /* Mark client detached */
-       lm->i2c.adapter = NULL;
+       lm->i2c = NULL;
 
        /* release sensor */
        wf_unregister_sensor(&lm->sens);
 
+       i2c_set_clientdata(client, NULL);
        return 0;
 }
 
+static const struct i2c_device_id wf_lm75_id[] = {
+       { "wf_lm75", 0 },
+       { "wf_ds1775", 1 },
+       { }
+};
+
+static struct i2c_driver wf_lm75_driver = {
+       .driver = {
+               .name   = "wf_lm75",
+       },
+       .attach_adapter = wf_lm75_attach,
+       .probe          = wf_lm75_probe,
+       .remove         = wf_lm75_remove,
+       .id_table       = wf_lm75_id,
+};
+
 static int __init wf_lm75_sensor_init(void)
 {
+       /* Don't register on old machines that use therm_pm72 for now */
+       if (of_machine_is_compatible("PowerMac7,2") ||
+           of_machine_is_compatible("PowerMac7,3") ||
+           of_machine_is_compatible("RackMac3,1"))
+               return -ENODEV;
        return i2c_add_driver(&wf_lm75_driver);
 }