include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit...
[safe/jmp/linux-2.6] / drivers / ieee1394 / sbp2.c
index becd98d..4565cb5 100644 (file)
  * driver. It also registers as a SCSI lower-level driver in order to accept
  * SCSI commands for transport using SBP-2.
  *
- * You may access any attached SBP-2 storage devices as if they were SCSI
- * devices (e.g. mount /dev/sda1,  fdisk, mkfs, etc.).
+ * You may access any attached SBP-2 (usually storage devices) as regular
+ * SCSI devices. E.g. mount /dev/sda1, fdisk, mkfs, etc..
  *
- * Current Issues:
+ * See http://www.t10.org/drafts.htm#sbp2 for the final draft of the SBP-2
+ * specification and for where to purchase the official standard.
  *
- *     - Error Handling: SCSI aborts and bus reset requests are handled somewhat
- *       but the code needs additional debugging.
+ * TODO:
+ *   - look into possible improvements of the SCSI error handlers
+ *   - handle Unit_Characteristics.mgt_ORB_timeout and .ORB_size
+ *   - handle Logical_Unit_Number.ordered
+ *   - handle src == 1 in status blocks
+ *   - reimplement the DMA mapping in absence of physical DMA so that
+ *     bus_to_virt is no longer required
+ *   - debug the handling of absent physical DMA
+ *   - replace CONFIG_IEEE1394_SBP2_PHYS_DMA by automatic detection
+ *     (this is easy but depends on the previous two TODO items)
+ *   - make the parameter serialize_io configurable per device
+ *   - move all requests to fetch agent registers into non-atomic context,
+ *     replace all usages of sbp2util_node_write_no_wait by true transactions
+ * Grep for inline FIXME comments below.
  */
 
 #include <linux/blkdev.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
-#include <linux/gfp.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
+#include <linux/mm.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
-#include <linux/pci.h>
+#include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/stat.h>
 #include <linux/stringify.h>
 #include <linux/types.h>
 #include <linux/wait.h>
+#include <linux/workqueue.h>
+#include <linux/scatterlist.h>
 
 #include <asm/byteorder.h>
 #include <asm/errno.h>
 #include <asm/param.h>
-#include <asm/scatterlist.h>
 #include <asm/system.h>
 #include <asm/types.h>
 
  * (probably due to PCI latency/throughput issues with the part). You can
  * bump down the speed if you are running into problems.
  */
-static int max_speed = IEEE1394_SPEED_MAX;
-module_param(max_speed, int, 0644);
-MODULE_PARM_DESC(max_speed, "Force max speed (3 = 800mb, 2 = 400mb, 1 = 200mb, 0 = 100mb)");
+static int sbp2_max_speed = IEEE1394_SPEED_MAX;
+module_param_named(max_speed, sbp2_max_speed, int, 0644);
+MODULE_PARM_DESC(max_speed, "Limit data transfer speed (5 <= 3200, "
+                "4 <= 1600, 3 <= 800, 2 <= 400, 1 <= 200, 0 = 100 Mb/s)");
 
 /*
- * Set serialize_io to 1 if you'd like only one scsi command sent
- * down to us at a time (debugging). This might be necessary for very
- * badly behaved sbp2 devices.
- *
- * TODO: Make this configurable per device.
+ * Set serialize_io to 0 or N to use dynamically appended lists of command ORBs.
+ * This is and always has been buggy in multiple subtle ways. See above TODOs.
  */
-static int serialize_io = 1;
-module_param(serialize_io, int, 0444);
-MODULE_PARM_DESC(serialize_io, "Serialize I/O coming from scsi drivers (default = 1, faster = 0)");
+static int sbp2_serialize_io = 1;
+module_param_named(serialize_io, sbp2_serialize_io, bool, 0444);
+MODULE_PARM_DESC(serialize_io, "Serialize requests coming from SCSI drivers "
+                "(default = Y, faster but buggy = N)");
 
 /*
- * Bump up max_sectors if you'd like to support very large sized
- * transfers. Please note that some older sbp2 bridge chips are broken for
- * transfers greater or equal to 128KB.  Default is a value of 255
- * sectors, or just under 128KB (at 512 byte sector size). I can note that
- * the Oxsemi sbp2 chipsets have no problems supporting very large
- * transfer sizes.
+ * Adjust max_sectors if you'd like to influence how many sectors each SCSI
+ * command can transfer at most. Please note that some older SBP-2 bridge
+ * chips are broken for transfers greater or equal to 128KB, therefore
+ * max_sectors used to be a safe 255 sectors for many years. We now have a
+ * default of 0 here which means that we let the SCSI stack choose a limit.
+ *
+ * The SBP2_WORKAROUND_128K_MAX_TRANS flag, if set either in the workarounds
+ * module parameter or in the sbp2_workarounds_table[], will override the
+ * value of max_sectors. We should use sbp2_workarounds_table[] to cover any
+ * bridge chip which becomes known to need the 255 sectors limit.
  */
-static int max_sectors = SBP2_MAX_SECTORS;
-module_param(max_sectors, int, 0444);
-MODULE_PARM_DESC(max_sectors, "Change max sectors per I/O supported (default = "
-                __stringify(SBP2_MAX_SECTORS) ")");
+static int sbp2_max_sectors;
+module_param_named(max_sectors, sbp2_max_sectors, int, 0444);
+MODULE_PARM_DESC(max_sectors, "Change max sectors per I/O supported "
+                "(default = 0 = use SCSI stack's default)");
 
 /*
  * Exclusive login to sbp2 device? In most cases, the sbp2 driver should
@@ -139,9 +156,10 @@ MODULE_PARM_DESC(max_sectors, "Change max sectors per I/O supported (default = "
  * concurrent logins. Depending on firmware, four or two concurrent logins
  * are possible on OXFW911 and newer Oxsemi bridges.
  */
-static int exclusive_login = 1;
-module_param(exclusive_login, int, 0644);
-MODULE_PARM_DESC(exclusive_login, "Exclusive login to sbp2 device (default = 1)");
+static int sbp2_exclusive_login = 1;
+module_param_named(exclusive_login, sbp2_exclusive_login, bool, 0644);
+MODULE_PARM_DESC(exclusive_login, "Exclusive login to sbp2 device "
+                "(default = Y, use N for concurrent initiators)");
 
 /*
  * If any of the following workarounds is required for your device to work,
@@ -164,6 +182,14 @@ MODULE_PARM_DESC(exclusive_login, "Exclusive login to sbp2 device (default = 1)"
  *   Avoids access beyond actual disk limits on devices with an off-by-one bug.
  *   Don't use this with devices which don't have this bug.
  *
+ * - delay inquiry
+ *   Wait extra SBP2_INQUIRY_DELAY seconds after login before SCSI inquiry.
+ *
+ * - power condition
+ *   Set the power condition field in the START STOP UNIT commands sent by
+ *   sd_mod on suspend, resume, and shutdown (if manage_start_stop is on).
+ *   Some disks need this to spin down or to resume properly.
+ *
  * - override internal blacklist
  *   Instead of adding to the built-in blacklist, use only the workarounds
  *   specified in the module load parameter.
@@ -176,126 +202,153 @@ MODULE_PARM_DESC(workarounds, "Work around device bugs (default = 0"
        ", 36 byte inquiry = "    __stringify(SBP2_WORKAROUND_INQUIRY_36)
        ", skip mode page 8 = "   __stringify(SBP2_WORKAROUND_MODE_SENSE_8)
        ", fix capacity = "       __stringify(SBP2_WORKAROUND_FIX_CAPACITY)
+       ", delay inquiry = "      __stringify(SBP2_WORKAROUND_DELAY_INQUIRY)
+       ", set power condition in start stop unit = "
+                                 __stringify(SBP2_WORKAROUND_POWER_CONDITION)
        ", override internal blacklist = " __stringify(SBP2_WORKAROUND_OVERRIDE)
        ", or a combination)");
 
 /*
- * Export information about protocols/devices supported by this driver.
- */
-static struct ieee1394_device_id sbp2_id_table[] = {
-       {
-        .match_flags = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
-        .specifier_id = SBP2_UNIT_SPEC_ID_ENTRY & 0xffffff,
-        .version = SBP2_SW_VERSION_ENTRY & 0xffffff},
-       {}
-};
-
-MODULE_DEVICE_TABLE(ieee1394, sbp2_id_table);
-
-/*
- * Debug levels, configured via kernel config, or enable here.
+ * This influences the format of the sysfs attribute
+ * /sys/bus/scsi/devices/.../ieee1394_id.
+ *
+ * The default format is like in older kernels:  %016Lx:%d:%d
+ * It contains the target's EUI-64, a number given to the logical unit by
+ * the ieee1394 driver's nodemgr (starting at 0), and the LUN.
+ *
+ * The long format is:  %016Lx:%06x:%04x
+ * It contains the target's EUI-64, the unit directory's directory_ID as per
+ * IEEE 1212 clause 7.7.19, and the LUN.  This format comes closest to the
+ * format of SBP(-3) target port and logical unit identifier as per SAM (SCSI
+ * Architecture Model) rev.2 to 4 annex A.  Therefore and because it is
+ * independent of the implementation of the ieee1394 nodemgr, the longer format
+ * is recommended for future use.
  */
+static int sbp2_long_sysfs_ieee1394_id;
+module_param_named(long_ieee1394_id, sbp2_long_sysfs_ieee1394_id, bool, 0644);
+MODULE_PARM_DESC(long_ieee1394_id, "8+3+2 bytes format of ieee1394_id in sysfs "
+                "(default = backwards-compatible = N, SAM-conforming = Y)");
 
-#define CONFIG_IEEE1394_SBP2_DEBUG 0
-/* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
-/* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
-
-#ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
-#define SBP2_ORB_DEBUG(fmt, args...)   HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args)
-static u32 global_outstanding_command_orbs = 0;
-#define outstanding_orb_incr global_outstanding_command_orbs++
-#define outstanding_orb_decr global_outstanding_command_orbs--
-#else
-#define SBP2_ORB_DEBUG(fmt, args...)   do {} while (0)
-#define outstanding_orb_incr           do {} while (0)
-#define outstanding_orb_decr           do {} while (0)
-#endif
 
-#ifdef CONFIG_IEEE1394_SBP2_DEBUG_DMA
-#define SBP2_DMA_ALLOC(fmt, args...) \
-       HPSB_ERR("sbp2(%s)alloc(%d): "fmt, __FUNCTION__, \
-                ++global_outstanding_dmas, ## args)
-#define SBP2_DMA_FREE(fmt, args...) \
-       HPSB_ERR("sbp2(%s)free(%d): "fmt, __FUNCTION__, \
-                --global_outstanding_dmas, ## args)
-static u32 global_outstanding_dmas = 0;
-#else
-#define SBP2_DMA_ALLOC(fmt, args...)   do {} while (0)
-#define SBP2_DMA_FREE(fmt, args...)    do {} while (0)
-#endif
-
-#if CONFIG_IEEE1394_SBP2_DEBUG >= 2
-#define SBP2_DEBUG(fmt, args...)       HPSB_ERR("sbp2: "fmt, ## args)
-#define SBP2_INFO(fmt, args...)                HPSB_ERR("sbp2: "fmt, ## args)
-#define SBP2_NOTICE(fmt, args...)      HPSB_ERR("sbp2: "fmt, ## args)
-#define SBP2_WARN(fmt, args...)                HPSB_ERR("sbp2: "fmt, ## args)
-#elif CONFIG_IEEE1394_SBP2_DEBUG == 1
-#define SBP2_DEBUG(fmt, args...)       HPSB_DEBUG("sbp2: "fmt, ## args)
-#define SBP2_INFO(fmt, args...)                HPSB_INFO("sbp2: "fmt, ## args)
-#define SBP2_NOTICE(fmt, args...)      HPSB_NOTICE("sbp2: "fmt, ## args)
-#define SBP2_WARN(fmt, args...)                HPSB_WARN("sbp2: "fmt, ## args)
-#else
-#define SBP2_DEBUG(fmt, args...)       do {} while (0)
-#define SBP2_INFO(fmt, args...)                HPSB_INFO("sbp2: "fmt, ## args)
-#define SBP2_NOTICE(fmt, args...)       HPSB_NOTICE("sbp2: "fmt, ## args)
-#define SBP2_WARN(fmt, args...)         HPSB_WARN("sbp2: "fmt, ## args)
-#endif
-
-#define SBP2_ERR(fmt, args...)         HPSB_ERR("sbp2: "fmt, ## args)
-#define SBP2_DEBUG_ENTER()             SBP2_DEBUG("%s", __FUNCTION__)
+#define SBP2_INFO(fmt, args...)        HPSB_INFO("sbp2: "fmt, ## args)
+#define SBP2_ERR(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
 
 /*
  * Globals
  */
-
-static void sbp2scsi_complete_all_commands(struct scsi_id_instance_data *scsi_id,
-                                          u32 status);
-
-static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id,
-                                     u32 scsi_status, struct scsi_cmnd *SCpnt,
-                                     void (*done)(struct scsi_cmnd *));
-
-static struct scsi_host_template scsi_driver_template;
-
-static const u8 sbp2_speedto_max_payload[] = { 0x7, 0x8, 0x9, 0xA, 0xB, 0xC };
-
-static void sbp2_host_reset(struct hpsb_host *host);
-
-static int sbp2_probe(struct device *dev);
-static int sbp2_remove(struct device *dev);
-static int sbp2_update(struct unit_directory *ud);
+static void sbp2scsi_complete_all_commands(struct sbp2_lu *, u32);
+static void sbp2scsi_complete_command(struct sbp2_lu *, u32, struct scsi_cmnd *,
+                                     void (*)(struct scsi_cmnd *));
+static struct sbp2_lu *sbp2_alloc_device(struct unit_directory *);
+static int sbp2_start_device(struct sbp2_lu *);
+static void sbp2_remove_device(struct sbp2_lu *);
+static int sbp2_login_device(struct sbp2_lu *);
+static int sbp2_reconnect_device(struct sbp2_lu *);
+static int sbp2_logout_device(struct sbp2_lu *);
+static void sbp2_host_reset(struct hpsb_host *);
+static int sbp2_handle_status_write(struct hpsb_host *, int, int, quadlet_t *,
+                                   u64, size_t, u16);
+static int sbp2_agent_reset(struct sbp2_lu *, int);
+static void sbp2_parse_unit_directory(struct sbp2_lu *,
+                                     struct unit_directory *);
+static int sbp2_set_busy_timeout(struct sbp2_lu *);
+static int sbp2_max_speed_and_size(struct sbp2_lu *);
+
+
+static const u8 sbp2_speedto_max_payload[] = { 0x7, 0x8, 0x9, 0xa, 0xa, 0xa };
+
+static DEFINE_RWLOCK(sbp2_hi_logical_units_lock);
 
 static struct hpsb_highlevel sbp2_highlevel = {
-       .name =         SBP2_DEVICE_NAME,
-       .host_reset =   sbp2_host_reset,
+       .name           = SBP2_DEVICE_NAME,
+       .host_reset     = sbp2_host_reset,
 };
 
-static struct hpsb_address_ops sbp2_ops = {
-       .write = sbp2_handle_status_write
+static const struct hpsb_address_ops sbp2_ops = {
+       .write          = sbp2_handle_status_write
 };
 
 #ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA
-static struct hpsb_address_ops sbp2_physdma_ops = {
-       .read = sbp2_handle_physdma_read,
-       .write = sbp2_handle_physdma_write,
+static int sbp2_handle_physdma_write(struct hpsb_host *, int, int, quadlet_t *,
+                                    u64, size_t, u16);
+static int sbp2_handle_physdma_read(struct hpsb_host *, int, quadlet_t *, u64,
+                                   size_t, u16);
+
+static const struct hpsb_address_ops sbp2_physdma_ops = {
+       .read           = sbp2_handle_physdma_read,
+       .write          = sbp2_handle_physdma_write,
 };
 #endif
 
+
+/*
+ * Interface to driver core and IEEE 1394 core
+ */
+static const struct ieee1394_device_id sbp2_id_table[] = {
+       {
+        .match_flags   = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
+        .specifier_id  = SBP2_UNIT_SPEC_ID_ENTRY & 0xffffff,
+        .version       = SBP2_SW_VERSION_ENTRY & 0xffffff},
+       {}
+};
+MODULE_DEVICE_TABLE(ieee1394, sbp2_id_table);
+
+static int sbp2_probe(struct device *);
+static int sbp2_remove(struct device *);
+static int sbp2_update(struct unit_directory *);
+
 static struct hpsb_protocol_driver sbp2_driver = {
-       .name           = "SBP2 Driver",
+       .name           = SBP2_DEVICE_NAME,
        .id_table       = sbp2_id_table,
        .update         = sbp2_update,
        .driver         = {
-               .name           = SBP2_DEVICE_NAME,
-               .bus            = &ieee1394_bus_type,
                .probe          = sbp2_probe,
                .remove         = sbp2_remove,
        },
 };
 
+
+/*
+ * Interface to SCSI core
+ */
+static int sbp2scsi_queuecommand(struct scsi_cmnd *,
+                                void (*)(struct scsi_cmnd *));
+static int sbp2scsi_abort(struct scsi_cmnd *);
+static int sbp2scsi_reset(struct scsi_cmnd *);
+static int sbp2scsi_slave_alloc(struct scsi_device *);
+static int sbp2scsi_slave_configure(struct scsi_device *);
+static void sbp2scsi_slave_destroy(struct scsi_device *);
+static ssize_t sbp2_sysfs_ieee1394_id_show(struct device *,
+                                          struct device_attribute *, char *);
+
+static DEVICE_ATTR(ieee1394_id, S_IRUGO, sbp2_sysfs_ieee1394_id_show, NULL);
+
+static struct device_attribute *sbp2_sysfs_sdev_attrs[] = {
+       &dev_attr_ieee1394_id,
+       NULL
+};
+
+static struct scsi_host_template sbp2_shost_template = {
+       .module                  = THIS_MODULE,
+       .name                    = "SBP-2 IEEE-1394",
+       .proc_name               = SBP2_DEVICE_NAME,
+       .queuecommand            = sbp2scsi_queuecommand,
+       .eh_abort_handler        = sbp2scsi_abort,
+       .eh_device_reset_handler = sbp2scsi_reset,
+       .slave_alloc             = sbp2scsi_slave_alloc,
+       .slave_configure         = sbp2scsi_slave_configure,
+       .slave_destroy           = sbp2scsi_slave_destroy,
+       .this_id                 = -1,
+       .sg_tablesize            = SG_ALL,
+       .use_clustering          = ENABLE_CLUSTERING,
+       .cmd_per_lun             = SBP2_MAX_CMDS,
+       .can_queue               = SBP2_MAX_CMDS,
+       .sdev_attrs              = sbp2_sysfs_sdev_attrs,
+};
+
+#define SBP2_ROM_VALUE_WILDCARD ~0         /* match all */
+#define SBP2_ROM_VALUE_MISSING  0xff000000 /* not present in the unit dir. */
+
 /*
  * List of devices with known bugs.
  *
@@ -305,46 +358,69 @@ static struct hpsb_protocol_driver sbp2_driver = {
  */
 static const struct {
        u32 firmware_revision;
-       u32 model_id;
+       u32 model;
        unsigned workarounds;
 } sbp2_workarounds_table[] = {
        /* DViCO Momobay CX-1 with TSB42AA9 bridge */ {
                .firmware_revision      = 0x002800,
-               .model_id               = 0x001010,
+               .model                  = 0x001010,
                .workarounds            = SBP2_WORKAROUND_INQUIRY_36 |
-                                         SBP2_WORKAROUND_MODE_SENSE_8,
+                                         SBP2_WORKAROUND_MODE_SENSE_8 |
+                                         SBP2_WORKAROUND_POWER_CONDITION,
+       },
+       /* DViCO Momobay FX-3A with TSB42AA9A bridge */ {
+               .firmware_revision      = 0x002800,
+               .model                  = 0x000000,
+               .workarounds            = SBP2_WORKAROUND_POWER_CONDITION,
        },
        /* Initio bridges, actually only needed for some older ones */ {
                .firmware_revision      = 0x000200,
+               .model                  = SBP2_ROM_VALUE_WILDCARD,
                .workarounds            = SBP2_WORKAROUND_INQUIRY_36,
        },
+       /* PL-3507 bridge with Prolific firmware */ {
+               .firmware_revision      = 0x012800,
+               .model                  = SBP2_ROM_VALUE_WILDCARD,
+               .workarounds            = SBP2_WORKAROUND_POWER_CONDITION,
+       },
        /* Symbios bridge */ {
                .firmware_revision      = 0xa0b800,
+               .model                  = SBP2_ROM_VALUE_WILDCARD,
+               .workarounds            = SBP2_WORKAROUND_128K_MAX_TRANS,
+       },
+       /* Datafab MD2-FW2 with Symbios/LSILogic SYM13FW500 bridge */ {
+               .firmware_revision      = 0x002600,
+               .model                  = SBP2_ROM_VALUE_WILDCARD,
                .workarounds            = SBP2_WORKAROUND_128K_MAX_TRANS,
        },
        /*
-        * Note about the following Apple iPod blacklist entries:
-        *
-        * There are iPods (2nd gen, 3rd gen) with model_id==0.  Since our
-        * matching logic treats 0 as a wildcard, we cannot match this ID
-        * without rewriting the matching routine.  Fortunately these iPods
-        * do not feature the read_capacity bug according to one report.
-        * Read_capacity behaviour as well as model_id could change due to
-        * Apple-supplied firmware updates though.
+        * iPod 2nd generation: needs 128k max transfer size workaround
+        * iPod 3rd generation: needs fix capacity workaround
         */
+       {
+               .firmware_revision      = 0x0a2700,
+               .model                  = 0x000000,
+               .workarounds            = SBP2_WORKAROUND_128K_MAX_TRANS |
+                                         SBP2_WORKAROUND_FIX_CAPACITY,
+       },
        /* iPod 4th generation */ {
                .firmware_revision      = 0x0a2700,
-               .model_id               = 0x000021,
+               .model                  = 0x000021,
                .workarounds            = SBP2_WORKAROUND_FIX_CAPACITY,
        },
        /* iPod mini */ {
                .firmware_revision      = 0x0a2700,
-               .model_id               = 0x000023,
+               .model                  = 0x000022,
+               .workarounds            = SBP2_WORKAROUND_FIX_CAPACITY,
+       },
+       /* iPod mini */ {
+               .firmware_revision      = 0x0a2700,
+               .model                  = 0x000023,
                .workarounds            = SBP2_WORKAROUND_FIX_CAPACITY,
        },
        /* iPod Photo */ {
                .firmware_revision      = 0x0a2700,
-               .model_id               = 0x00007e,
+               .model                  = 0x00007e,
                .workarounds            = SBP2_WORKAROUND_FIX_CAPACITY,
        }
 };
@@ -363,8 +439,6 @@ static inline void sbp2util_be32_to_cpu_buffer(void *buffer, int length)
 
        for (length = (length >> 2); length--; )
                temp[length] = be32_to_cpu(temp[length]);
-
-       return;
 }
 
 /*
@@ -376,8 +450,6 @@ static inline void sbp2util_cpu_to_be32_buffer(void *buffer, int length)
 
        for (length = (length >> 2); length--; )
                temp[length] = cpu_to_be32(temp[length]);
-
-       return;
 }
 #else /* BIG_ENDIAN */
 /* Why waste the cpu cycles? */
@@ -385,344 +457,242 @@ static inline void sbp2util_cpu_to_be32_buffer(void *buffer, int length)
 #define sbp2util_cpu_to_be32_buffer(x,y) do {} while (0)
 #endif
 
-#ifdef CONFIG_IEEE1394_SBP2_PACKET_DUMP
-/*
- * Debug packet dump routine. Length is in bytes.
- */
-static void sbp2util_packet_dump(void *buffer, int length, char *dump_name,
-                                u32 dump_phys_addr)
-{
-       int i;
-       unsigned char *dump = buffer;
-
-       if (!dump || !length || !dump_name)
-               return;
-
-       if (dump_phys_addr)
-               printk("[%s, 0x%x]", dump_name, dump_phys_addr);
-       else
-               printk("[%s]", dump_name);
-       for (i = 0; i < length; i++) {
-               if (i > 0x3f) {
-                       printk("\n   ...");
-                       break;
-               }
-               if ((i & 0x3) == 0)
-                       printk("  ");
-               if ((i & 0xf) == 0)
-                       printk("\n   ");
-               printk("%02x ", (int)dump[i]);
-       }
-       printk("\n");
-
-       return;
-}
-#else
-#define sbp2util_packet_dump(w,x,y,z) do {} while (0)
-#endif
-
-static DECLARE_WAIT_QUEUE_HEAD(access_wq);
+static DECLARE_WAIT_QUEUE_HEAD(sbp2_access_wq);
 
 /*
  * Waits for completion of an SBP-2 access request.
  * Returns nonzero if timed out or prematurely interrupted.
  */
-static int sbp2util_access_timeout(struct scsi_id_instance_data *scsi_id,
-                                  int timeout)
+static int sbp2util_access_timeout(struct sbp2_lu *lu, int timeout)
 {
-       long leftover = wait_event_interruptible_timeout(
-                               access_wq, scsi_id->access_complete, timeout);
+       long leftover;
 
-       scsi_id->access_complete = 0;
+       leftover = wait_event_interruptible_timeout(
+                       sbp2_access_wq, lu->access_complete, timeout);
+       lu->access_complete = 0;
        return leftover <= 0;
 }
 
-/* Frees an allocated packet */
-static void sbp2_free_packet(struct hpsb_packet *packet)
+static void sbp2_free_packet(void *packet)
 {
        hpsb_free_tlabel(packet);
        hpsb_free_packet(packet);
 }
 
-/* This is much like hpsb_node_write(), except it ignores the response
- * subaction and returns immediately. Can be used from interrupts.
+/*
+ * This is much like hpsb_node_write(), except it ignores the response
+ * subaction and returns immediately. Can be used from atomic context.
  */
 static int sbp2util_node_write_no_wait(struct node_entry *ne, u64 addr,
-                                      quadlet_t *buffer, size_t length)
+                                      quadlet_t *buf, size_t len)
 {
        struct hpsb_packet *packet;
 
-       packet = hpsb_make_writepacket(ne->host, ne->nodeid,
-                                      addr, buffer, length);
+       packet = hpsb_make_writepacket(ne->host, ne->nodeid, addr, buf, len);
        if (!packet)
                return -ENOMEM;
 
-       hpsb_set_packet_complete_task(packet,
-                                     (void (*)(void *))sbp2_free_packet,
-                                     packet);
-
+       hpsb_set_packet_complete_task(packet, sbp2_free_packet, packet);
        hpsb_node_fill_packet(ne, packet);
-
        if (hpsb_send_packet(packet) < 0) {
                sbp2_free_packet(packet);
                return -EIO;
        }
-
        return 0;
 }
 
-static void sbp2util_notify_fetch_agent(struct scsi_id_instance_data *scsi_id,
-                                       u64 offset, quadlet_t *data, size_t len)
+static void sbp2util_notify_fetch_agent(struct sbp2_lu *lu, u64 offset,
+                                       quadlet_t *data, size_t len)
 {
-       /*
-        * There is a small window after a bus reset within which the node
-        * entry's generation is current but the reconnect wasn't completed.
-        */
-       if (unlikely(atomic_read(&scsi_id->state) == SBP2LU_STATE_IN_RESET))
+       /* There is a small window after a bus reset within which the node
+        * entry's generation is current but the reconnect wasn't completed. */
+       if (unlikely(atomic_read(&lu->state) == SBP2LU_STATE_IN_RESET))
                return;
 
-       if (hpsb_node_write(scsi_id->ne,
-                           scsi_id->sbp2_command_block_agent_addr + offset,
+       if (hpsb_node_write(lu->ne, lu->command_block_agent_addr + offset,
                            data, len))
                SBP2_ERR("sbp2util_notify_fetch_agent failed.");
-       /*
-        * Now accept new SCSI commands, unless a bus reset happended during
-        * hpsb_node_write.
-        */
-       if (likely(atomic_read(&scsi_id->state) != SBP2LU_STATE_IN_RESET))
-               scsi_unblock_requests(scsi_id->scsi_host);
+
+       /* Now accept new SCSI commands, unless a bus reset happended during
+        * hpsb_node_write. */
+       if (likely(atomic_read(&lu->state) != SBP2LU_STATE_IN_RESET))
+               scsi_unblock_requests(lu->shost);
 }
 
 static void sbp2util_write_orb_pointer(struct work_struct *work)
 {
-       struct scsi_id_instance_data *scsi_id =
-               container_of(work, struct scsi_id_instance_data,
-                            protocol_work.work);
+       struct sbp2_lu *lu = container_of(work, struct sbp2_lu, protocol_work);
        quadlet_t data[2];
 
-       data[0] = ORB_SET_NODE_ID(scsi_id->hi->host->node_id);
-       data[1] = scsi_id->last_orb_dma;
+       data[0] = ORB_SET_NODE_ID(lu->hi->host->node_id);
+       data[1] = lu->last_orb_dma;
        sbp2util_cpu_to_be32_buffer(data, 8);
-       sbp2util_notify_fetch_agent(scsi_id, SBP2_ORB_POINTER_OFFSET, data, 8);
+       sbp2util_notify_fetch_agent(lu, SBP2_ORB_POINTER_OFFSET, data, 8);
 }
 
 static void sbp2util_write_doorbell(struct work_struct *work)
 {
-       struct scsi_id_instance_data *scsi_id =
-               container_of(work, struct scsi_id_instance_data,
-                            protocol_work.work);
-       sbp2util_notify_fetch_agent(scsi_id, SBP2_DOORBELL_OFFSET, NULL, 4);
+       struct sbp2_lu *lu = container_of(work, struct sbp2_lu, protocol_work);
+
+       sbp2util_notify_fetch_agent(lu, SBP2_DOORBELL_OFFSET, NULL, 4);
 }
 
-/*
- * This function is called to create a pool of command orbs used for
- * command processing. It is called when a new sbp2 device is detected.
- */
-static int sbp2util_create_command_orb_pool(struct scsi_id_instance_data *scsi_id)
+static int sbp2util_create_command_orb_pool(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
-       int i;
-       unsigned long flags, orbs;
-       struct sbp2_command_info *command;
-
-       orbs = serialize_io ? 2 : SBP2_MAX_CMDS;
+       struct sbp2_command_info *cmd;
+       struct device *dmadev = lu->hi->host->device.parent;
+       int i, orbs = sbp2_serialize_io ? 2 : SBP2_MAX_CMDS;
 
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
        for (i = 0; i < orbs; i++) {
-               command = kzalloc(sizeof(*command), GFP_ATOMIC);
-               if (!command) {
-                       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock,
-                                              flags);
-                       return -ENOMEM;
-               }
-               command->command_orb_dma =
-                   pci_map_single(hi->host->pdev, &command->command_orb,
+               cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+               if (!cmd)
+                       goto failed_alloc;
+
+               cmd->command_orb_dma =
+                   dma_map_single(dmadev, &cmd->command_orb,
                                   sizeof(struct sbp2_command_orb),
-                                  PCI_DMA_TODEVICE);
-               SBP2_DMA_ALLOC("single command orb DMA");
-               command->sge_dma =
-                   pci_map_single(hi->host->pdev,
-                                  &command->scatter_gather_element,
-                                  sizeof(command->scatter_gather_element),
-                                  PCI_DMA_BIDIRECTIONAL);
-               SBP2_DMA_ALLOC("scatter_gather_element");
-               INIT_LIST_HEAD(&command->list);
-               list_add_tail(&command->list, &scsi_id->sbp2_command_orb_completed);
+                                  DMA_TO_DEVICE);
+               if (dma_mapping_error(dmadev, cmd->command_orb_dma))
+                       goto failed_orb;
+
+               cmd->sge_dma =
+                   dma_map_single(dmadev, &cmd->scatter_gather_element,
+                                  sizeof(cmd->scatter_gather_element),
+                                  DMA_TO_DEVICE);
+               if (dma_mapping_error(dmadev, cmd->sge_dma))
+                       goto failed_sge;
+
+               INIT_LIST_HEAD(&cmd->list);
+               list_add_tail(&cmd->list, &lu->cmd_orb_completed);
        }
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
        return 0;
+
+failed_sge:
+       dma_unmap_single(dmadev, cmd->command_orb_dma,
+                        sizeof(struct sbp2_command_orb), DMA_TO_DEVICE);
+failed_orb:
+       kfree(cmd);
+failed_alloc:
+       return -ENOMEM;
 }
 
-/*
- * This function is called to delete a pool of command orbs.
- */
-static void sbp2util_remove_command_orb_pool(struct scsi_id_instance_data *scsi_id)
+static void sbp2util_remove_command_orb_pool(struct sbp2_lu *lu,
+                                            struct hpsb_host *host)
 {
-       struct hpsb_host *host = scsi_id->hi->host;
        struct list_head *lh, *next;
-       struct sbp2_command_info *command;
+       struct sbp2_command_info *cmd;
        unsigned long flags;
 
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       if (!list_empty(&scsi_id->sbp2_command_orb_completed)) {
-               list_for_each_safe(lh, next, &scsi_id->sbp2_command_orb_completed) {
-                       command = list_entry(lh, struct sbp2_command_info, list);
-
-                       /* Release our generic DMA's */
-                       pci_unmap_single(host->pdev, command->command_orb_dma,
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       if (!list_empty(&lu->cmd_orb_completed))
+               list_for_each_safe(lh, next, &lu->cmd_orb_completed) {
+                       cmd = list_entry(lh, struct sbp2_command_info, list);
+                       dma_unmap_single(host->device.parent,
+                                        cmd->command_orb_dma,
                                         sizeof(struct sbp2_command_orb),
-                                        PCI_DMA_TODEVICE);
-                       SBP2_DMA_FREE("single command orb DMA");
-                       pci_unmap_single(host->pdev, command->sge_dma,
-                                        sizeof(command->scatter_gather_element),
-                                        PCI_DMA_BIDIRECTIONAL);
-                       SBP2_DMA_FREE("scatter_gather_element");
-
-                       kfree(command);
+                                        DMA_TO_DEVICE);
+                       dma_unmap_single(host->device.parent, cmd->sge_dma,
+                                        sizeof(cmd->scatter_gather_element),
+                                        DMA_TO_DEVICE);
+                       kfree(cmd);
                }
-       }
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
        return;
 }
 
 /*
- * This function finds the sbp2_command for a given outstanding command
- * orb.Only looks at the inuse list.
+ * Finds the sbp2_command for a given outstanding command ORB.
+ * Only looks at the in-use list.
  */
 static struct sbp2_command_info *sbp2util_find_command_for_orb(
-               struct scsi_id_instance_data *scsi_id, dma_addr_t orb)
+                               struct sbp2_lu *lu, dma_addr_t orb)
 {
-       struct sbp2_command_info *command;
+       struct sbp2_command_info *cmd;
        unsigned long flags;
 
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       if (!list_empty(&scsi_id->sbp2_command_orb_inuse)) {
-               list_for_each_entry(command, &scsi_id->sbp2_command_orb_inuse, list) {
-                       if (command->command_orb_dma == orb) {
-                               spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
-                               return command;
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       if (!list_empty(&lu->cmd_orb_inuse))
+               list_for_each_entry(cmd, &lu->cmd_orb_inuse, list)
+                       if (cmd->command_orb_dma == orb) {
+                               spin_unlock_irqrestore(
+                                               &lu->cmd_orb_lock, flags);
+                               return cmd;
                        }
-               }
-       }
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
-
-       SBP2_ORB_DEBUG("could not match command orb %x", (unsigned int)orb);
-
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
        return NULL;
 }
 
 /*
- * This function finds the sbp2_command for a given outstanding SCpnt.
- * Only looks at the inuse list.
- * Must be called with scsi_id->sbp2_command_orb_lock held.
+ * Finds the sbp2_command for a given outstanding SCpnt.
+ * Only looks at the in-use list.
+ * Must be called with lu->cmd_orb_lock held.
  */
 static struct sbp2_command_info *sbp2util_find_command_for_SCpnt(
-               struct scsi_id_instance_data *scsi_id, void *SCpnt)
+                               struct sbp2_lu *lu, void *SCpnt)
 {
-       struct sbp2_command_info *command;
+       struct sbp2_command_info *cmd;
 
-       if (!list_empty(&scsi_id->sbp2_command_orb_inuse))
-               list_for_each_entry(command, &scsi_id->sbp2_command_orb_inuse, list)
-                       if (command->Current_SCpnt == SCpnt)
-                               return command;
+       if (!list_empty(&lu->cmd_orb_inuse))
+               list_for_each_entry(cmd, &lu->cmd_orb_inuse, list)
+                       if (cmd->Current_SCpnt == SCpnt)
+                               return cmd;
        return NULL;
 }
 
-/*
- * This function allocates a command orb used to send a scsi command.
- */
 static struct sbp2_command_info *sbp2util_allocate_command_orb(
-               struct scsi_id_instance_data *scsi_id,
-               struct scsi_cmnd *Current_SCpnt,
-               void (*Current_done)(struct scsi_cmnd *))
+                               struct sbp2_lu *lu,
+                               struct scsi_cmnd *Current_SCpnt,
+                               void (*Current_done)(struct scsi_cmnd *))
 {
        struct list_head *lh;
-       struct sbp2_command_info *command = NULL;
+       struct sbp2_command_info *cmd = NULL;
        unsigned long flags;
 
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       if (!list_empty(&scsi_id->sbp2_command_orb_completed)) {
-               lh = scsi_id->sbp2_command_orb_completed.next;
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       if (!list_empty(&lu->cmd_orb_completed)) {
+               lh = lu->cmd_orb_completed.next;
                list_del(lh);
-               command = list_entry(lh, struct sbp2_command_info, list);
-               command->Current_done = Current_done;
-               command->Current_SCpnt = Current_SCpnt;
-               list_add_tail(&command->list, &scsi_id->sbp2_command_orb_inuse);
-       } else {
-               SBP2_ERR("%s: no orbs available", __FUNCTION__);
-       }
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
-       return command;
-}
-
-/* Free our DMA's */
-static void sbp2util_free_command_dma(struct sbp2_command_info *command)
-{
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)command->Current_SCpnt->device->host->hostdata[0];
-       struct hpsb_host *host;
-
-       if (!scsi_id) {
-               SBP2_ERR("%s: scsi_id == NULL", __FUNCTION__);
-               return;
-       }
-
-       host = scsi_id->ud->ne->host;
-
-       if (command->cmd_dma) {
-               if (command->dma_type == CMD_DMA_SINGLE) {
-                       pci_unmap_single(host->pdev, command->cmd_dma,
-                                        command->dma_size, command->dma_dir);
-                       SBP2_DMA_FREE("single bulk");
-               } else if (command->dma_type == CMD_DMA_PAGE) {
-                       pci_unmap_page(host->pdev, command->cmd_dma,
-                                      command->dma_size, command->dma_dir);
-                       SBP2_DMA_FREE("single page");
-               } /* XXX: Check for CMD_DMA_NONE bug */
-               command->dma_type = CMD_DMA_NONE;
-               command->cmd_dma = 0;
-       }
-
-       if (command->sge_buffer) {
-               pci_unmap_sg(host->pdev, command->sge_buffer,
-                            command->dma_size, command->dma_dir);
-               SBP2_DMA_FREE("scatter list");
-               command->sge_buffer = NULL;
-       }
+               cmd = list_entry(lh, struct sbp2_command_info, list);
+               cmd->Current_done = Current_done;
+               cmd->Current_SCpnt = Current_SCpnt;
+               list_add_tail(&cmd->list, &lu->cmd_orb_inuse);
+       } else
+               SBP2_ERR("%s: no orbs available", __func__);
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
+       return cmd;
 }
 
 /*
- * This function moves a command to the completed orb list.
- * Must be called with scsi_id->sbp2_command_orb_lock held.
+ * Unmaps the DMAs of a command and moves the command to the completed ORB list.
+ * Must be called with lu->cmd_orb_lock held.
  */
-static void sbp2util_mark_command_completed(
-               struct scsi_id_instance_data *scsi_id,
-               struct sbp2_command_info *command)
+static void sbp2util_mark_command_completed(struct sbp2_lu *lu,
+                                           struct sbp2_command_info *cmd)
 {
-       list_del(&command->list);
-       sbp2util_free_command_dma(command);
-       list_add_tail(&command->list, &scsi_id->sbp2_command_orb_completed);
+       if (scsi_sg_count(cmd->Current_SCpnt))
+               dma_unmap_sg(lu->ud->ne->host->device.parent,
+                            scsi_sglist(cmd->Current_SCpnt),
+                            scsi_sg_count(cmd->Current_SCpnt),
+                            cmd->Current_SCpnt->sc_data_direction);
+       list_move_tail(&cmd->list, &lu->cmd_orb_completed);
 }
 
 /*
- * Is scsi_id valid? Is the 1394 node still present?
+ * Is lu valid? Is the 1394 node still present?
  */
-static inline int sbp2util_node_is_available(struct scsi_id_instance_data *scsi_id)
+static inline int sbp2util_node_is_available(struct sbp2_lu *lu)
 {
-       return scsi_id && scsi_id->ne && !scsi_id->ne->in_limbo;
+       return lu && lu->ne && !lu->ne->in_limbo;
 }
 
 /*********************************************
  * IEEE-1394 core driver stack related section
  *********************************************/
-static struct scsi_id_instance_data *sbp2_alloc_device(struct unit_directory *ud);
 
 static int sbp2_probe(struct device *dev)
 {
        struct unit_directory *ud;
-       struct scsi_id_instance_data *scsi_id;
-
-       SBP2_DEBUG_ENTER();
+       struct sbp2_lu *lu;
 
        ud = container_of(dev, struct unit_directory, device);
 
@@ -731,137 +701,130 @@ static int sbp2_probe(struct device *dev)
        if (ud->flags & UNIT_DIRECTORY_HAS_LUN_DIRECTORY)
                return -ENODEV;
 
-       scsi_id = sbp2_alloc_device(ud);
-
-       if (!scsi_id)
+       lu = sbp2_alloc_device(ud);
+       if (!lu)
                return -ENOMEM;
 
-       sbp2_parse_unit_directory(scsi_id, ud);
-
-       return sbp2_start_device(scsi_id);
+       sbp2_parse_unit_directory(lu, ud);
+       return sbp2_start_device(lu);
 }
 
 static int sbp2_remove(struct device *dev)
 {
        struct unit_directory *ud;
-       struct scsi_id_instance_data *scsi_id;
+       struct sbp2_lu *lu;
        struct scsi_device *sdev;
 
-       SBP2_DEBUG_ENTER();
-
        ud = container_of(dev, struct unit_directory, device);
-       scsi_id = ud->device.driver_data;
-       if (!scsi_id)
+       lu = dev_get_drvdata(&ud->device);
+       if (!lu)
                return 0;
 
-       if (scsi_id->scsi_host) {
+       if (lu->shost) {
                /* Get rid of enqueued commands if there is no chance to
                 * send them. */
-               if (!sbp2util_node_is_available(scsi_id))
-                       sbp2scsi_complete_all_commands(scsi_id, DID_NO_CONNECT);
-               /* scsi_remove_device() will trigger shutdown functions of SCSI
+               if (!sbp2util_node_is_available(lu))
+                       sbp2scsi_complete_all_commands(lu, DID_NO_CONNECT);
+               /* scsi_remove_device() may trigger shutdown functions of SCSI
                 * highlevel drivers which would deadlock if blocked. */
-               atomic_set(&scsi_id->state, SBP2LU_STATE_IN_SHUTDOWN);
-               scsi_unblock_requests(scsi_id->scsi_host);
+               atomic_set(&lu->state, SBP2LU_STATE_IN_SHUTDOWN);
+               scsi_unblock_requests(lu->shost);
        }
-       sdev = scsi_id->sdev;
+       sdev = lu->sdev;
        if (sdev) {
-               scsi_id->sdev = NULL;
+               lu->sdev = NULL;
                scsi_remove_device(sdev);
        }
 
-       sbp2_logout_device(scsi_id);
-       sbp2_remove_device(scsi_id);
+       sbp2_logout_device(lu);
+       sbp2_remove_device(lu);
 
        return 0;
 }
 
 static int sbp2_update(struct unit_directory *ud)
 {
-       struct scsi_id_instance_data *scsi_id = ud->device.driver_data;
-
-       SBP2_DEBUG_ENTER();
-
-       if (sbp2_reconnect_device(scsi_id)) {
+       struct sbp2_lu *lu = dev_get_drvdata(&ud->device);
 
+       if (sbp2_reconnect_device(lu) != 0) {
+               /*
+                * Reconnect failed.  If another bus reset happened,
+                * let nodemgr proceed and call sbp2_update again later
+                * (or sbp2_remove if this node went away).
+                */
+               if (!hpsb_node_entry_valid(lu->ne))
+                       return 0;
                /*
-                * Ok, reconnect has failed. Perhaps we didn't
-                * reconnect fast enough. Try doing a regular login, but
-                * first do a logout just in case of any weirdness.
+                * Or the target rejected the reconnect because we weren't
+                * fast enough.  Try a regular login, but first log out
+                * just in case of any weirdness.
                 */
-               sbp2_logout_device(scsi_id);
+               sbp2_logout_device(lu);
 
-               if (sbp2_login_device(scsi_id)) {
-                       /* Login failed too, just fail, and the backend
-                        * will call our sbp2_remove for us */
+               if (sbp2_login_device(lu) != 0) {
+                       if (!hpsb_node_entry_valid(lu->ne))
+                               return 0;
+
+                       /* Maybe another initiator won the login. */
                        SBP2_ERR("Failed to reconnect to sbp2 device!");
                        return -EBUSY;
                }
        }
 
-       /* Set max retries to something large on the device. */
-       sbp2_set_busy_timeout(scsi_id);
-
-       /* Do a SBP-2 fetch agent reset. */
-       sbp2_agent_reset(scsi_id, 1);
-
-       /* Get the max speed and packet size that we can use. */
-       sbp2_max_speed_and_size(scsi_id);
+       sbp2_set_busy_timeout(lu);
+       sbp2_agent_reset(lu, 1);
+       sbp2_max_speed_and_size(lu);
 
-       /* Complete any pending commands with busy (so they get
-        * retried) and remove them from our queue
-        */
-       sbp2scsi_complete_all_commands(scsi_id, DID_BUS_BUSY);
+       /* Complete any pending commands with busy (so they get retried)
+        * and remove them from our queue. */
+       sbp2scsi_complete_all_commands(lu, DID_BUS_BUSY);
 
        /* Accept new commands unless there was another bus reset in the
         * meantime. */
-       if (hpsb_node_entry_valid(scsi_id->ne)) {
-               atomic_set(&scsi_id->state, SBP2LU_STATE_RUNNING);
-               scsi_unblock_requests(scsi_id->scsi_host);
+       if (hpsb_node_entry_valid(lu->ne)) {
+               atomic_set(&lu->state, SBP2LU_STATE_RUNNING);
+               scsi_unblock_requests(lu->shost);
        }
        return 0;
 }
 
-/* This functions is called by the sbp2_probe, for each new device. We now
- * allocate one scsi host for each scsi_id (unit directory). */
-static struct scsi_id_instance_data *sbp2_alloc_device(struct unit_directory *ud)
+static struct sbp2_lu *sbp2_alloc_device(struct unit_directory *ud)
 {
-       struct sbp2scsi_host_info *hi;
-       struct Scsi_Host *scsi_host = NULL;
-       struct scsi_id_instance_data *scsi_id = NULL;
-
-       SBP2_DEBUG_ENTER();
+       struct sbp2_fwhost_info *hi;
+       struct Scsi_Host *shost = NULL;
+       struct sbp2_lu *lu = NULL;
+       unsigned long flags;
 
-       scsi_id = kzalloc(sizeof(*scsi_id), GFP_KERNEL);
-       if (!scsi_id) {
-               SBP2_ERR("failed to create scsi_id");
+       lu = kzalloc(sizeof(*lu), GFP_KERNEL);
+       if (!lu) {
+               SBP2_ERR("failed to create lu");
                goto failed_alloc;
        }
 
-       scsi_id->ne = ud->ne;
-       scsi_id->ud = ud;
-       scsi_id->speed_code = IEEE1394_SPEED_100;
-       scsi_id->max_payload_size = sbp2_speedto_max_payload[IEEE1394_SPEED_100];
-       scsi_id->status_fifo_addr = CSR1212_INVALID_ADDR_SPACE;
-       INIT_LIST_HEAD(&scsi_id->sbp2_command_orb_inuse);
-       INIT_LIST_HEAD(&scsi_id->sbp2_command_orb_completed);
-       INIT_LIST_HEAD(&scsi_id->scsi_list);
-       spin_lock_init(&scsi_id->sbp2_command_orb_lock);
-       atomic_set(&scsi_id->state, SBP2LU_STATE_RUNNING);
-       INIT_DELAYED_WORK(&scsi_id->protocol_work, NULL);
+       lu->ne = ud->ne;
+       lu->ud = ud;
+       lu->speed_code = IEEE1394_SPEED_100;
+       lu->max_payload_size = sbp2_speedto_max_payload[IEEE1394_SPEED_100];
+       lu->status_fifo_addr = CSR1212_INVALID_ADDR_SPACE;
+       INIT_LIST_HEAD(&lu->cmd_orb_inuse);
+       INIT_LIST_HEAD(&lu->cmd_orb_completed);
+       INIT_LIST_HEAD(&lu->lu_list);
+       spin_lock_init(&lu->cmd_orb_lock);
+       atomic_set(&lu->state, SBP2LU_STATE_RUNNING);
+       INIT_WORK(&lu->protocol_work, NULL);
 
-       ud->device.driver_data = scsi_id;
+       dev_set_drvdata(&ud->device, lu);
 
        hi = hpsb_get_hostinfo(&sbp2_highlevel, ud->ne->host);
        if (!hi) {
-               hi = hpsb_create_hostinfo(&sbp2_highlevel, ud->ne->host, sizeof(*hi));
+               hi = hpsb_create_hostinfo(&sbp2_highlevel, ud->ne->host,
+                                         sizeof(*hi));
                if (!hi) {
                        SBP2_ERR("failed to allocate hostinfo");
                        goto failed_alloc;
                }
-               SBP2_DEBUG("sbp2_alloc_device: allocated hostinfo");
                hi->host = ud->ne->host;
-               INIT_LIST_HEAD(&hi->scsi_ids);
+               INIT_LIST_HEAD(&hi->logical_units);
 
 #ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA
                /* Handle data movement if physical dma is not
@@ -875,15 +838,21 @@ static struct scsi_id_instance_data *sbp2_alloc_device(struct unit_directory *ud
 #endif
        }
 
+       if (dma_get_max_seg_size(hi->host->device.parent) > SBP2_MAX_SEG_SIZE)
+               BUG_ON(dma_set_max_seg_size(hi->host->device.parent,
+                                           SBP2_MAX_SEG_SIZE));
+
        /* Prevent unloading of the 1394 host */
        if (!try_module_get(hi->host->driver->owner)) {
                SBP2_ERR("failed to get a reference on 1394 host driver");
                goto failed_alloc;
        }
 
-       scsi_id->hi = hi;
+       lu->hi = hi;
 
-       list_add_tail(&scsi_id->scsi_list, &hi->scsi_ids);
+       write_lock_irqsave(&sbp2_hi_logical_units_lock, flags);
+       list_add_tail(&lu->lu_list, &hi->logical_units);
+       write_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags);
 
        /* Register the status FIFO address range. We could use the same FIFO
         * for targets at different nodes. However we need different FIFOs per
@@ -893,302 +862,223 @@ static struct scsi_id_instance_data *sbp2_alloc_device(struct unit_directory *ud
         * then be performed as unified transactions. This slightly reduces
         * bandwidth usage, and some Prolific based devices seem to require it.
         */
-       scsi_id->status_fifo_addr = hpsb_allocate_and_register_addrspace(
+       lu->status_fifo_addr = hpsb_allocate_and_register_addrspace(
                        &sbp2_highlevel, ud->ne->host, &sbp2_ops,
                        sizeof(struct sbp2_status_block), sizeof(quadlet_t),
                        ud->ne->host->low_addr_space, CSR1212_ALL_SPACE_END);
-       if (scsi_id->status_fifo_addr == CSR1212_INVALID_ADDR_SPACE) {
+       if (lu->status_fifo_addr == CSR1212_INVALID_ADDR_SPACE) {
                SBP2_ERR("failed to allocate status FIFO address range");
                goto failed_alloc;
        }
 
-       /* Register our host with the SCSI stack. */
-       scsi_host = scsi_host_alloc(&scsi_driver_template,
-                                   sizeof(unsigned long));
-       if (!scsi_host) {
+       shost = scsi_host_alloc(&sbp2_shost_template, sizeof(unsigned long));
+       if (!shost) {
                SBP2_ERR("failed to register scsi host");
                goto failed_alloc;
        }
 
-       scsi_host->hostdata[0] = (unsigned long)scsi_id;
+       shost->hostdata[0] = (unsigned long)lu;
+       shost->max_cmd_len = SBP2_MAX_CDB_SIZE;
 
-       if (!scsi_add_host(scsi_host, &ud->device)) {
-               scsi_id->scsi_host = scsi_host;
-               return scsi_id;
+       if (!scsi_add_host(shost, &ud->device)) {
+               lu->shost = shost;
+               return lu;
        }
 
        SBP2_ERR("failed to add scsi host");
-       scsi_host_put(scsi_host);
+       scsi_host_put(shost);
 
 failed_alloc:
-       sbp2_remove_device(scsi_id);
+       sbp2_remove_device(lu);
        return NULL;
 }
 
 static void sbp2_host_reset(struct hpsb_host *host)
 {
-       struct sbp2scsi_host_info *hi;
-       struct scsi_id_instance_data *scsi_id;
+       struct sbp2_fwhost_info *hi;
+       struct sbp2_lu *lu;
+       unsigned long flags;
 
        hi = hpsb_get_hostinfo(&sbp2_highlevel, host);
        if (!hi)
                return;
-       list_for_each_entry(scsi_id, &hi->scsi_ids, scsi_list)
-               if (likely(atomic_read(&scsi_id->state) !=
-                          SBP2LU_STATE_IN_SHUTDOWN)) {
-                       atomic_set(&scsi_id->state, SBP2LU_STATE_IN_RESET);
-                       scsi_block_requests(scsi_id->scsi_host);
-               }
+
+       read_lock_irqsave(&sbp2_hi_logical_units_lock, flags);
+
+       list_for_each_entry(lu, &hi->logical_units, lu_list)
+               if (atomic_cmpxchg(&lu->state,
+                                  SBP2LU_STATE_RUNNING, SBP2LU_STATE_IN_RESET)
+                   == SBP2LU_STATE_RUNNING)
+                       scsi_block_requests(lu->shost);
+
+       read_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags);
 }
 
-/*
- * This function is where we first pull the node unique ids, and then
- * allocate memory and register a SBP-2 device.
- */
-static int sbp2_start_device(struct scsi_id_instance_data *scsi_id)
+static int sbp2_start_device(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        int error;
 
-       SBP2_DEBUG_ENTER();
-
-       /* Login FIFO DMA */
-       scsi_id->login_response =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->login_response = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_login_response),
-                                    &scsi_id->login_response_dma);
-       if (!scsi_id->login_response)
+                                    &lu->login_response_dma, GFP_KERNEL);
+       if (!lu->login_response)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for login FIFO");
 
-       /* Query logins ORB DMA */
-       scsi_id->query_logins_orb =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->query_logins_orb = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_query_logins_orb),
-                                    &scsi_id->query_logins_orb_dma);
-       if (!scsi_id->query_logins_orb)
+                                    &lu->query_logins_orb_dma, GFP_KERNEL);
+       if (!lu->query_logins_orb)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for query logins ORB");
 
-       /* Query logins response DMA */
-       scsi_id->query_logins_response =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->query_logins_response = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_query_logins_response),
-                                    &scsi_id->query_logins_response_dma);
-       if (!scsi_id->query_logins_response)
+                                    &lu->query_logins_response_dma, GFP_KERNEL);
+       if (!lu->query_logins_response)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for query logins response");
 
-       /* Reconnect ORB DMA */
-       scsi_id->reconnect_orb =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->reconnect_orb = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_reconnect_orb),
-                                    &scsi_id->reconnect_orb_dma);
-       if (!scsi_id->reconnect_orb)
+                                    &lu->reconnect_orb_dma, GFP_KERNEL);
+       if (!lu->reconnect_orb)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for reconnect ORB");
 
-       /* Logout ORB DMA */
-       scsi_id->logout_orb =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->logout_orb = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_logout_orb),
-                                    &scsi_id->logout_orb_dma);
-       if (!scsi_id->logout_orb)
+                                    &lu->logout_orb_dma, GFP_KERNEL);
+       if (!lu->logout_orb)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for logout ORB");
 
-       /* Login ORB DMA */
-       scsi_id->login_orb =
-               pci_alloc_consistent(hi->host->pdev,
+       lu->login_orb = dma_alloc_coherent(hi->host->device.parent,
                                     sizeof(struct sbp2_login_orb),
-                                    &scsi_id->login_orb_dma);
-       if (!scsi_id->login_orb)
+                                    &lu->login_orb_dma, GFP_KERNEL);
+       if (!lu->login_orb)
                goto alloc_fail;
-       SBP2_DMA_ALLOC("consistent DMA region for login ORB");
 
-       SBP2_DEBUG("New SBP-2 device inserted, SCSI ID = %x", scsi_id->ud->id);
-
-       /*
-        * Create our command orb pool
-        */
-       if (sbp2util_create_command_orb_pool(scsi_id)) {
-               SBP2_ERR("sbp2util_create_command_orb_pool failed!");
-               sbp2_remove_device(scsi_id);
-               return -ENOMEM;
-       }
+       if (sbp2util_create_command_orb_pool(lu))
+               goto alloc_fail;
 
-       /* Schedule a timeout here. The reason is that we may be so close
-        * to a bus reset, that the device is not available for logins.
-        * This can happen when the bus reset is caused by the host
-        * connected to the sbp2 device being removed. That host would
-        * have a certain amount of time to relogin before the sbp2 device
-        * allows someone else to login instead. One second makes sense. */
+       /* Wait a second before trying to log in. Previously logged in
+        * initiators need a chance to reconnect. */
        if (msleep_interruptible(1000)) {
-               sbp2_remove_device(scsi_id);
+               sbp2_remove_device(lu);
                return -EINTR;
        }
 
-       /*
-        * Login to the sbp-2 device
-        */
-       if (sbp2_login_device(scsi_id)) {
-               /* Login failed, just remove the device. */
-               sbp2_remove_device(scsi_id);
+       if (sbp2_login_device(lu)) {
+               sbp2_remove_device(lu);
                return -EBUSY;
        }
 
-       /*
-        * Set max retries to something large on the device
-        */
-       sbp2_set_busy_timeout(scsi_id);
+       sbp2_set_busy_timeout(lu);
+       sbp2_agent_reset(lu, 1);
+       sbp2_max_speed_and_size(lu);
 
-       /*
-        * Do a SBP-2 fetch agent reset
-        */
-       sbp2_agent_reset(scsi_id, 1);
-
-       /*
-        * Get the max speed and packet size that we can use
-        */
-       sbp2_max_speed_and_size(scsi_id);
+       if (lu->workarounds & SBP2_WORKAROUND_DELAY_INQUIRY)
+               ssleep(SBP2_INQUIRY_DELAY);
 
-       /* Add this device to the scsi layer now */
-       error = scsi_add_device(scsi_id->scsi_host, 0, scsi_id->ud->id, 0);
+       error = scsi_add_device(lu->shost, 0, lu->ud->id, 0);
        if (error) {
                SBP2_ERR("scsi_add_device failed");
-               sbp2_logout_device(scsi_id);
-               sbp2_remove_device(scsi_id);
+               sbp2_logout_device(lu);
+               sbp2_remove_device(lu);
                return error;
        }
 
        return 0;
 
 alloc_fail:
-       SBP2_ERR("Could not allocate memory for scsi_id");
-       sbp2_remove_device(scsi_id);
+       SBP2_ERR("Could not allocate memory for lu");
+       sbp2_remove_device(lu);
        return -ENOMEM;
 }
 
-/*
- * This function removes an sbp2 device from the sbp2scsi_host_info struct.
- */
-static void sbp2_remove_device(struct scsi_id_instance_data *scsi_id)
+static void sbp2_remove_device(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi;
-
-       SBP2_DEBUG_ENTER();
+       struct sbp2_fwhost_info *hi;
+       unsigned long flags;
 
-       if (!scsi_id)
+       if (!lu)
                return;
+       hi = lu->hi;
+       if (!hi)
+               goto no_hi;
 
-       hi = scsi_id->hi;
-
-       /* This will remove our scsi device aswell */
-       if (scsi_id->scsi_host) {
-               scsi_remove_host(scsi_id->scsi_host);
-               scsi_host_put(scsi_id->scsi_host);
+       if (lu->shost) {
+               scsi_remove_host(lu->shost);
+               scsi_host_put(lu->shost);
        }
        flush_scheduled_work();
-       sbp2util_remove_command_orb_pool(scsi_id);
+       sbp2util_remove_command_orb_pool(lu, hi->host);
 
-       list_del(&scsi_id->scsi_list);
+       write_lock_irqsave(&sbp2_hi_logical_units_lock, flags);
+       list_del(&lu->lu_list);
+       write_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags);
 
-       if (scsi_id->login_response) {
-               pci_free_consistent(hi->host->pdev,
+       if (lu->login_response)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_login_response),
-                                   scsi_id->login_response,
-                                   scsi_id->login_response_dma);
-               SBP2_DMA_FREE("single login FIFO");
-       }
-
-       if (scsi_id->login_orb) {
-               pci_free_consistent(hi->host->pdev,
+                                   lu->login_response,
+                                   lu->login_response_dma);
+       if (lu->login_orb)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_login_orb),
-                                   scsi_id->login_orb,
-                                   scsi_id->login_orb_dma);
-               SBP2_DMA_FREE("single login ORB");
-       }
-
-       if (scsi_id->reconnect_orb) {
-               pci_free_consistent(hi->host->pdev,
+                                   lu->login_orb,
+                                   lu->login_orb_dma);
+       if (lu->reconnect_orb)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_reconnect_orb),
-                                   scsi_id->reconnect_orb,
-                                   scsi_id->reconnect_orb_dma);
-               SBP2_DMA_FREE("single reconnect orb");
-       }
-
-       if (scsi_id->logout_orb) {
-               pci_free_consistent(hi->host->pdev,
+                                   lu->reconnect_orb,
+                                   lu->reconnect_orb_dma);
+       if (lu->logout_orb)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_logout_orb),
-                                   scsi_id->logout_orb,
-                                   scsi_id->logout_orb_dma);
-               SBP2_DMA_FREE("single logout orb");
-       }
-
-       if (scsi_id->query_logins_orb) {
-               pci_free_consistent(hi->host->pdev,
+                                   lu->logout_orb,
+                                   lu->logout_orb_dma);
+       if (lu->query_logins_orb)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_query_logins_orb),
-                                   scsi_id->query_logins_orb,
-                                   scsi_id->query_logins_orb_dma);
-               SBP2_DMA_FREE("single query logins orb");
-       }
-
-       if (scsi_id->query_logins_response) {
-               pci_free_consistent(hi->host->pdev,
+                                   lu->query_logins_orb,
+                                   lu->query_logins_orb_dma);
+       if (lu->query_logins_response)
+               dma_free_coherent(hi->host->device.parent,
                                    sizeof(struct sbp2_query_logins_response),
-                                   scsi_id->query_logins_response,
-                                   scsi_id->query_logins_response_dma);
-               SBP2_DMA_FREE("single query logins data");
-       }
+                                   lu->query_logins_response,
+                                   lu->query_logins_response_dma);
 
-       if (scsi_id->status_fifo_addr != CSR1212_INVALID_ADDR_SPACE)
+       if (lu->status_fifo_addr != CSR1212_INVALID_ADDR_SPACE)
                hpsb_unregister_addrspace(&sbp2_highlevel, hi->host,
-                                         scsi_id->status_fifo_addr);
+                                         lu->status_fifo_addr);
 
-       scsi_id->ud->device.driver_data = NULL;
+       dev_set_drvdata(&lu->ud->device, NULL);
 
-       if (hi)
-               module_put(hi->host->driver->owner);
-
-       SBP2_DEBUG("SBP-2 device removed, SCSI ID = %d", scsi_id->ud->id);
-
-       kfree(scsi_id);
+       module_put(hi->host->driver->owner);
+no_hi:
+       kfree(lu);
 }
 
 #ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA
 /*
- * This function deals with physical dma write requests (for adapters that do not support
- * physical dma in hardware). Mostly just here for debugging...
+ * Deal with write requests on adapters which do not support physical DMA or
+ * have it switched off.
  */
 static int sbp2_handle_physdma_write(struct hpsb_host *host, int nodeid,
                                     int destid, quadlet_t *data, u64 addr,
                                     size_t length, u16 flags)
 {
-
-       /*
-        * Manually put the data in the right place.
-        */
        memcpy(bus_to_virt((u32) addr), data, length);
-       sbp2util_packet_dump(data, length, "sbp2 phys dma write by device",
-                            (u32) addr);
        return RCODE_COMPLETE;
 }
 
 /*
- * This function deals with physical dma read requests (for adapters that do not support
- * physical dma in hardware). Mostly just here for debugging...
+ * Deal with read requests on adapters which do not support physical DMA or
+ * have it switched off.
  */
 static int sbp2_handle_physdma_read(struct hpsb_host *host, int nodeid,
                                    quadlet_t *data, u64 addr, size_t length,
                                    u16 flags)
 {
-
-       /*
-        * Grab data from memory and send a read response.
-        */
        memcpy(data, bus_to_virt((u32) addr), length);
-       sbp2util_packet_dump(data, length, "sbp2 phys dma read by device",
-                            (u32) addr);
        return RCODE_COMPLETE;
 }
 #endif
@@ -1197,74 +1087,69 @@ static int sbp2_handle_physdma_read(struct hpsb_host *host, int nodeid,
  * SBP-2 protocol related section
  **************************************/
 
-/*
- * This function queries the device for the maximum concurrent logins it
- * supports.
- */
-static int sbp2_query_logins(struct scsi_id_instance_data *scsi_id)
+static int sbp2_query_logins(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        quadlet_t data[2];
        int max_logins;
        int active_logins;
 
-       SBP2_DEBUG_ENTER();
-
-       scsi_id->query_logins_orb->reserved1 = 0x0;
-       scsi_id->query_logins_orb->reserved2 = 0x0;
-
-       scsi_id->query_logins_orb->query_response_lo = scsi_id->query_logins_response_dma;
-       scsi_id->query_logins_orb->query_response_hi = ORB_SET_NODE_ID(hi->host->node_id);
+       lu->query_logins_orb->reserved1 = 0x0;
+       lu->query_logins_orb->reserved2 = 0x0;
 
-       scsi_id->query_logins_orb->lun_misc = ORB_SET_FUNCTION(SBP2_QUERY_LOGINS_REQUEST);
-       scsi_id->query_logins_orb->lun_misc |= ORB_SET_NOTIFY(1);
-       scsi_id->query_logins_orb->lun_misc |= ORB_SET_LUN(scsi_id->sbp2_lun);
+       lu->query_logins_orb->query_response_lo = lu->query_logins_response_dma;
+       lu->query_logins_orb->query_response_hi =
+                       ORB_SET_NODE_ID(hi->host->node_id);
+       lu->query_logins_orb->lun_misc =
+                       ORB_SET_FUNCTION(SBP2_QUERY_LOGINS_REQUEST);
+       lu->query_logins_orb->lun_misc |= ORB_SET_NOTIFY(1);
+       lu->query_logins_orb->lun_misc |= ORB_SET_LUN(lu->lun);
 
-       scsi_id->query_logins_orb->reserved_resp_length =
-               ORB_SET_QUERY_LOGINS_RESP_LENGTH(sizeof(struct sbp2_query_logins_response));
+       lu->query_logins_orb->reserved_resp_length =
+               ORB_SET_QUERY_LOGINS_RESP_LENGTH(
+                       sizeof(struct sbp2_query_logins_response));
 
-       scsi_id->query_logins_orb->status_fifo_hi =
-               ORB_SET_STATUS_FIFO_HI(scsi_id->status_fifo_addr, hi->host->node_id);
-       scsi_id->query_logins_orb->status_fifo_lo =
-               ORB_SET_STATUS_FIFO_LO(scsi_id->status_fifo_addr);
+       lu->query_logins_orb->status_fifo_hi =
+               ORB_SET_STATUS_FIFO_HI(lu->status_fifo_addr, hi->host->node_id);
+       lu->query_logins_orb->status_fifo_lo =
+               ORB_SET_STATUS_FIFO_LO(lu->status_fifo_addr);
 
-       sbp2util_cpu_to_be32_buffer(scsi_id->query_logins_orb, sizeof(struct sbp2_query_logins_orb));
+       sbp2util_cpu_to_be32_buffer(lu->query_logins_orb,
+                                   sizeof(struct sbp2_query_logins_orb));
 
-       sbp2util_packet_dump(scsi_id->query_logins_orb, sizeof(struct sbp2_query_logins_orb),
-                            "sbp2 query logins orb", scsi_id->query_logins_orb_dma);
-
-       memset(scsi_id->query_logins_response, 0, sizeof(struct sbp2_query_logins_response));
+       memset(lu->query_logins_response, 0,
+              sizeof(struct sbp2_query_logins_response));
 
        data[0] = ORB_SET_NODE_ID(hi->host->node_id);
-       data[1] = scsi_id->query_logins_orb_dma;
+       data[1] = lu->query_logins_orb_dma;
        sbp2util_cpu_to_be32_buffer(data, 8);
 
-       hpsb_node_write(scsi_id->ne, scsi_id->sbp2_management_agent_addr, data, 8);
+       hpsb_node_write(lu->ne, lu->management_agent_addr, data, 8);
 
-       if (sbp2util_access_timeout(scsi_id, 2*HZ)) {
+       if (sbp2util_access_timeout(lu, 2*HZ)) {
                SBP2_INFO("Error querying logins to SBP-2 device - timed out");
                return -EIO;
        }
 
-       if (scsi_id->status_block.ORB_offset_lo != scsi_id->query_logins_orb_dma) {
+       if (lu->status_block.ORB_offset_lo != lu->query_logins_orb_dma) {
                SBP2_INFO("Error querying logins to SBP-2 device - timed out");
                return -EIO;
        }
 
-       if (STATUS_TEST_RDS(scsi_id->status_block.ORB_offset_hi_misc)) {
+       if (STATUS_TEST_RDS(lu->status_block.ORB_offset_hi_misc)) {
                SBP2_INFO("Error querying logins to SBP-2 device - failed");
                return -EIO;
        }
 
-       sbp2util_cpu_to_be32_buffer(scsi_id->query_logins_response, sizeof(struct sbp2_query_logins_response));
-
-       SBP2_DEBUG("length_max_logins = %x",
-                  (unsigned int)scsi_id->query_logins_response->length_max_logins);
+       sbp2util_cpu_to_be32_buffer(lu->query_logins_response,
+                                   sizeof(struct sbp2_query_logins_response));
 
-       max_logins = RESPONSE_GET_MAX_LOGINS(scsi_id->query_logins_response->length_max_logins);
+       max_logins = RESPONSE_GET_MAX_LOGINS(
+                       lu->query_logins_response->length_max_logins);
        SBP2_INFO("Maximum concurrent logins supported: %d", max_logins);
 
-       active_logins = RESPONSE_GET_ACTIVE_LOGINS(scsi_id->query_logins_response->length_max_logins);
+       active_logins = RESPONSE_GET_ACTIVE_LOGINS(
+                       lu->query_logins_response->length_max_logins);
        SBP2_INFO("Number of active logins: %d", active_logins);
 
        if (active_logins >= max_logins) {
@@ -1274,332 +1159,233 @@ static int sbp2_query_logins(struct scsi_id_instance_data *scsi_id)
        return 0;
 }
 
-/*
- * This function is called in order to login to a particular SBP-2 device,
- * after a bus reset.
- */
-static int sbp2_login_device(struct scsi_id_instance_data *scsi_id)
+static int sbp2_login_device(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        quadlet_t data[2];
 
-       SBP2_DEBUG_ENTER();
-
-       if (!scsi_id->login_orb) {
-               SBP2_DEBUG("%s: login_orb not alloc'd!", __FUNCTION__);
+       if (!lu->login_orb)
                return -EIO;
-       }
 
-       if (!exclusive_login) {
-               if (sbp2_query_logins(scsi_id)) {
-                       SBP2_INFO("Device does not support any more concurrent logins");
-                       return -EIO;
-               }
+       if (!sbp2_exclusive_login && sbp2_query_logins(lu)) {
+               SBP2_INFO("Device does not support any more concurrent logins");
+               return -EIO;
        }
 
-       /* Set-up login ORB, assume no password */
-       scsi_id->login_orb->password_hi = 0;
-       scsi_id->login_orb->password_lo = 0;
+       /* assume no password */
+       lu->login_orb->password_hi = 0;
+       lu->login_orb->password_lo = 0;
 
-       scsi_id->login_orb->login_response_lo = scsi_id->login_response_dma;
-       scsi_id->login_orb->login_response_hi = ORB_SET_NODE_ID(hi->host->node_id);
+       lu->login_orb->login_response_lo = lu->login_response_dma;
+       lu->login_orb->login_response_hi = ORB_SET_NODE_ID(hi->host->node_id);
+       lu->login_orb->lun_misc = ORB_SET_FUNCTION(SBP2_LOGIN_REQUEST);
 
-       scsi_id->login_orb->lun_misc = ORB_SET_FUNCTION(SBP2_LOGIN_REQUEST);
-       scsi_id->login_orb->lun_misc |= ORB_SET_RECONNECT(0);   /* One second reconnect time */
-       scsi_id->login_orb->lun_misc |= ORB_SET_EXCLUSIVE(exclusive_login);     /* Exclusive access to device */
-       scsi_id->login_orb->lun_misc |= ORB_SET_NOTIFY(1);      /* Notify us of login complete */
-       scsi_id->login_orb->lun_misc |= ORB_SET_LUN(scsi_id->sbp2_lun);
+       /* one second reconnect time */
+       lu->login_orb->lun_misc |= ORB_SET_RECONNECT(0);
+       lu->login_orb->lun_misc |= ORB_SET_EXCLUSIVE(sbp2_exclusive_login);
+       lu->login_orb->lun_misc |= ORB_SET_NOTIFY(1);
+       lu->login_orb->lun_misc |= ORB_SET_LUN(lu->lun);
 
-       scsi_id->login_orb->passwd_resp_lengths =
+       lu->login_orb->passwd_resp_lengths =
                ORB_SET_LOGIN_RESP_LENGTH(sizeof(struct sbp2_login_response));
 
-       scsi_id->login_orb->status_fifo_hi =
-               ORB_SET_STATUS_FIFO_HI(scsi_id->status_fifo_addr, hi->host->node_id);
-       scsi_id->login_orb->status_fifo_lo =
-               ORB_SET_STATUS_FIFO_LO(scsi_id->status_fifo_addr);
-
-       sbp2util_cpu_to_be32_buffer(scsi_id->login_orb, sizeof(struct sbp2_login_orb));
+       lu->login_orb->status_fifo_hi =
+               ORB_SET_STATUS_FIFO_HI(lu->status_fifo_addr, hi->host->node_id);
+       lu->login_orb->status_fifo_lo =
+               ORB_SET_STATUS_FIFO_LO(lu->status_fifo_addr);
 
-       sbp2util_packet_dump(scsi_id->login_orb, sizeof(struct sbp2_login_orb),
-                            "sbp2 login orb", scsi_id->login_orb_dma);
+       sbp2util_cpu_to_be32_buffer(lu->login_orb,
+                                   sizeof(struct sbp2_login_orb));
 
-       memset(scsi_id->login_response, 0, sizeof(struct sbp2_login_response));
+       memset(lu->login_response, 0, sizeof(struct sbp2_login_response));
 
        data[0] = ORB_SET_NODE_ID(hi->host->node_id);
-       data[1] = scsi_id->login_orb_dma;
+       data[1] = lu->login_orb_dma;
        sbp2util_cpu_to_be32_buffer(data, 8);
 
-       hpsb_node_write(scsi_id->ne, scsi_id->sbp2_management_agent_addr, data, 8);
+       hpsb_node_write(lu->ne, lu->management_agent_addr, data, 8);
 
-       /*
-        * Wait for login status (up to 20 seconds)...
-        */
-       if (sbp2util_access_timeout(scsi_id, 20*HZ)) {
+       /* wait up to 20 seconds for login status */
+       if (sbp2util_access_timeout(lu, 20*HZ)) {
                SBP2_ERR("Error logging into SBP-2 device - timed out");
                return -EIO;
        }
 
-       /*
-        * Sanity. Make sure status returned matches login orb.
-        */
-       if (scsi_id->status_block.ORB_offset_lo != scsi_id->login_orb_dma) {
+       /* make sure that the returned status matches the login ORB */
+       if (lu->status_block.ORB_offset_lo != lu->login_orb_dma) {
                SBP2_ERR("Error logging into SBP-2 device - timed out");
                return -EIO;
        }
 
-       if (STATUS_TEST_RDS(scsi_id->status_block.ORB_offset_hi_misc)) {
+       if (STATUS_TEST_RDS(lu->status_block.ORB_offset_hi_misc)) {
                SBP2_ERR("Error logging into SBP-2 device - failed");
                return -EIO;
        }
 
-       /*
-        * Byte swap the login response, for use when reconnecting or
-        * logging out.
-        */
-       sbp2util_cpu_to_be32_buffer(scsi_id->login_response, sizeof(struct sbp2_login_response));
-
-       /*
-        * Grab our command block agent address from the login response.
-        */
-       SBP2_DEBUG("command_block_agent_hi = %x",
-                  (unsigned int)scsi_id->login_response->command_block_agent_hi);
-       SBP2_DEBUG("command_block_agent_lo = %x",
-                  (unsigned int)scsi_id->login_response->command_block_agent_lo);
-
-       scsi_id->sbp2_command_block_agent_addr =
-               ((u64)scsi_id->login_response->command_block_agent_hi) << 32;
-       scsi_id->sbp2_command_block_agent_addr |= ((u64)scsi_id->login_response->command_block_agent_lo);
-       scsi_id->sbp2_command_block_agent_addr &= 0x0000ffffffffffffULL;
+       sbp2util_cpu_to_be32_buffer(lu->login_response,
+                                   sizeof(struct sbp2_login_response));
+       lu->command_block_agent_addr =
+                       ((u64)lu->login_response->command_block_agent_hi) << 32;
+       lu->command_block_agent_addr |=
+                       ((u64)lu->login_response->command_block_agent_lo);
+       lu->command_block_agent_addr &= 0x0000ffffffffffffULL;
 
        SBP2_INFO("Logged into SBP-2 device");
        return 0;
 }
 
-/*
- * This function is called in order to logout from a particular SBP-2
- * device, usually called during driver unload.
- */
-static int sbp2_logout_device(struct scsi_id_instance_data *scsi_id)
+static int sbp2_logout_device(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        quadlet_t data[2];
        int error;
 
-       SBP2_DEBUG_ENTER();
+       lu->logout_orb->reserved1 = 0x0;
+       lu->logout_orb->reserved2 = 0x0;
+       lu->logout_orb->reserved3 = 0x0;
+       lu->logout_orb->reserved4 = 0x0;
 
-       /*
-        * Set-up logout ORB
-        */
-       scsi_id->logout_orb->reserved1 = 0x0;
-       scsi_id->logout_orb->reserved2 = 0x0;
-       scsi_id->logout_orb->reserved3 = 0x0;
-       scsi_id->logout_orb->reserved4 = 0x0;
-
-       scsi_id->logout_orb->login_ID_misc = ORB_SET_FUNCTION(SBP2_LOGOUT_REQUEST);
-       scsi_id->logout_orb->login_ID_misc |= ORB_SET_LOGIN_ID(scsi_id->login_response->length_login_ID);
-
-       /* Notify us when complete */
-       scsi_id->logout_orb->login_ID_misc |= ORB_SET_NOTIFY(1);
+       lu->logout_orb->login_ID_misc = ORB_SET_FUNCTION(SBP2_LOGOUT_REQUEST);
+       lu->logout_orb->login_ID_misc |=
+                       ORB_SET_LOGIN_ID(lu->login_response->length_login_ID);
+       lu->logout_orb->login_ID_misc |= ORB_SET_NOTIFY(1);
 
-       scsi_id->logout_orb->reserved5 = 0x0;
-       scsi_id->logout_orb->status_fifo_hi =
-               ORB_SET_STATUS_FIFO_HI(scsi_id->status_fifo_addr, hi->host->node_id);
-       scsi_id->logout_orb->status_fifo_lo =
-               ORB_SET_STATUS_FIFO_LO(scsi_id->status_fifo_addr);
-
-       /*
-        * Byte swap ORB if necessary
-        */
-       sbp2util_cpu_to_be32_buffer(scsi_id->logout_orb, sizeof(struct sbp2_logout_orb));
+       lu->logout_orb->reserved5 = 0x0;
+       lu->logout_orb->status_fifo_hi =
+               ORB_SET_STATUS_FIFO_HI(lu->status_fifo_addr, hi->host->node_id);
+       lu->logout_orb->status_fifo_lo =
+               ORB_SET_STATUS_FIFO_LO(lu->status_fifo_addr);
 
-       sbp2util_packet_dump(scsi_id->logout_orb, sizeof(struct sbp2_logout_orb),
-                            "sbp2 logout orb", scsi_id->logout_orb_dma);
+       sbp2util_cpu_to_be32_buffer(lu->logout_orb,
+                                   sizeof(struct sbp2_logout_orb));
 
-       /*
-        * Ok, let's write to the target's management agent register
-        */
        data[0] = ORB_SET_NODE_ID(hi->host->node_id);
-       data[1] = scsi_id->logout_orb_dma;
+       data[1] = lu->logout_orb_dma;
        sbp2util_cpu_to_be32_buffer(data, 8);
 
-       error = hpsb_node_write(scsi_id->ne,
-                               scsi_id->sbp2_management_agent_addr, data, 8);
+       error = hpsb_node_write(lu->ne, lu->management_agent_addr, data, 8);
        if (error)
                return error;
 
-       /* Wait for device to logout...1 second. */
-       if (sbp2util_access_timeout(scsi_id, HZ))
+       /* wait up to 1 second for the device to complete logout */
+       if (sbp2util_access_timeout(lu, HZ))
                return -EIO;
 
        SBP2_INFO("Logged out of SBP-2 device");
        return 0;
 }
 
-/*
- * This function is called in order to reconnect to a particular SBP-2
- * device, after a bus reset.
- */
-static int sbp2_reconnect_device(struct scsi_id_instance_data *scsi_id)
+static int sbp2_reconnect_device(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        quadlet_t data[2];
        int error;
 
-       SBP2_DEBUG_ENTER();
-
-       /*
-        * Set-up reconnect ORB
-        */
-       scsi_id->reconnect_orb->reserved1 = 0x0;
-       scsi_id->reconnect_orb->reserved2 = 0x0;
-       scsi_id->reconnect_orb->reserved3 = 0x0;
-       scsi_id->reconnect_orb->reserved4 = 0x0;
-
-       scsi_id->reconnect_orb->login_ID_misc = ORB_SET_FUNCTION(SBP2_RECONNECT_REQUEST);
-       scsi_id->reconnect_orb->login_ID_misc |=
-               ORB_SET_LOGIN_ID(scsi_id->login_response->length_login_ID);
+       lu->reconnect_orb->reserved1 = 0x0;
+       lu->reconnect_orb->reserved2 = 0x0;
+       lu->reconnect_orb->reserved3 = 0x0;
+       lu->reconnect_orb->reserved4 = 0x0;
 
-       /* Notify us when complete */
-       scsi_id->reconnect_orb->login_ID_misc |= ORB_SET_NOTIFY(1);
+       lu->reconnect_orb->login_ID_misc =
+                       ORB_SET_FUNCTION(SBP2_RECONNECT_REQUEST);
+       lu->reconnect_orb->login_ID_misc |=
+                       ORB_SET_LOGIN_ID(lu->login_response->length_login_ID);
+       lu->reconnect_orb->login_ID_misc |= ORB_SET_NOTIFY(1);
 
-       scsi_id->reconnect_orb->reserved5 = 0x0;
-       scsi_id->reconnect_orb->status_fifo_hi =
-               ORB_SET_STATUS_FIFO_HI(scsi_id->status_fifo_addr, hi->host->node_id);
-       scsi_id->reconnect_orb->status_fifo_lo =
-               ORB_SET_STATUS_FIFO_LO(scsi_id->status_fifo_addr);
+       lu->reconnect_orb->reserved5 = 0x0;
+       lu->reconnect_orb->status_fifo_hi =
+               ORB_SET_STATUS_FIFO_HI(lu->status_fifo_addr, hi->host->node_id);
+       lu->reconnect_orb->status_fifo_lo =
+               ORB_SET_STATUS_FIFO_LO(lu->status_fifo_addr);
 
-       /*
-        * Byte swap ORB if necessary
-        */
-       sbp2util_cpu_to_be32_buffer(scsi_id->reconnect_orb, sizeof(struct sbp2_reconnect_orb));
-
-       sbp2util_packet_dump(scsi_id->reconnect_orb, sizeof(struct sbp2_reconnect_orb),
-                            "sbp2 reconnect orb", scsi_id->reconnect_orb_dma);
+       sbp2util_cpu_to_be32_buffer(lu->reconnect_orb,
+                                   sizeof(struct sbp2_reconnect_orb));
 
        data[0] = ORB_SET_NODE_ID(hi->host->node_id);
-       data[1] = scsi_id->reconnect_orb_dma;
+       data[1] = lu->reconnect_orb_dma;
        sbp2util_cpu_to_be32_buffer(data, 8);
 
-       error = hpsb_node_write(scsi_id->ne,
-                               scsi_id->sbp2_management_agent_addr, data, 8);
+       error = hpsb_node_write(lu->ne, lu->management_agent_addr, data, 8);
        if (error)
                return error;
 
-       /*
-        * Wait for reconnect status (up to 1 second)...
-        */
-       if (sbp2util_access_timeout(scsi_id, HZ)) {
+       /* wait up to 1 second for reconnect status */
+       if (sbp2util_access_timeout(lu, HZ)) {
                SBP2_ERR("Error reconnecting to SBP-2 device - timed out");
                return -EIO;
        }
 
-       /*
-        * Sanity. Make sure status returned matches reconnect orb.
-        */
-       if (scsi_id->status_block.ORB_offset_lo != scsi_id->reconnect_orb_dma) {
+       /* make sure that the returned status matches the reconnect ORB */
+       if (lu->status_block.ORB_offset_lo != lu->reconnect_orb_dma) {
                SBP2_ERR("Error reconnecting to SBP-2 device - timed out");
                return -EIO;
        }
 
-       if (STATUS_TEST_RDS(scsi_id->status_block.ORB_offset_hi_misc)) {
+       if (STATUS_TEST_RDS(lu->status_block.ORB_offset_hi_misc)) {
                SBP2_ERR("Error reconnecting to SBP-2 device - failed");
                return -EIO;
        }
 
-       HPSB_DEBUG("Reconnected to SBP-2 device");
+       SBP2_INFO("Reconnected to SBP-2 device");
        return 0;
 }
 
 /*
- * This function is called in order to set the busy timeout (number of
- * retries to attempt) on the sbp2 device.
+ * Set the target node's Single Phase Retry limit. Affects the target's retry
+ * behaviour if our node is too busy to accept requests.
  */
-static int sbp2_set_busy_timeout(struct scsi_id_instance_data *scsi_id)
+static int sbp2_set_busy_timeout(struct sbp2_lu *lu)
 {
        quadlet_t data;
 
-       SBP2_DEBUG_ENTER();
-
        data = cpu_to_be32(SBP2_BUSY_TIMEOUT_VALUE);
-       if (hpsb_node_write(scsi_id->ne, SBP2_BUSY_TIMEOUT_ADDRESS, &data, 4))
-               SBP2_ERR("%s error", __FUNCTION__);
+       if (hpsb_node_write(lu->ne, SBP2_BUSY_TIMEOUT_ADDRESS, &data, 4))
+               SBP2_ERR("%s error", __func__);
        return 0;
 }
 
-/*
- * This function is called to parse sbp2 device's config rom unit
- * directory. Used to determine things like sbp2 management agent offset,
- * and command set used (SCSI or RBC).
- */
-static void sbp2_parse_unit_directory(struct scsi_id_instance_data *scsi_id,
+static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
                                      struct unit_directory *ud)
 {
        struct csr1212_keyval *kv;
        struct csr1212_dentry *dentry;
        u64 management_agent_addr;
-       u32 command_set_spec_id, command_set, unit_characteristics,
-           firmware_revision;
+       u32 unit_characteristics, firmware_revision, model;
        unsigned workarounds;
        int i;
 
-       SBP2_DEBUG_ENTER();
-
-       management_agent_addr = 0x0;
-       command_set_spec_id = 0x0;
-       command_set = 0x0;
-       unit_characteristics = 0x0;
-       firmware_revision = 0x0;
+       management_agent_addr = 0;
+       unit_characteristics = 0;
+       firmware_revision = SBP2_ROM_VALUE_MISSING;
+       model = ud->flags & UNIT_DIRECTORY_MODEL_ID ?
+                               ud->model_id : SBP2_ROM_VALUE_MISSING;
 
-       /* Handle different fields in the unit directory, based on keys */
        csr1212_for_each_dir_entry(ud->ne->csr, kv, ud->ud_kv, dentry) {
                switch (kv->key.id) {
                case CSR1212_KV_ID_DEPENDENT_INFO:
-                       if (kv->key.type == CSR1212_KV_TYPE_CSR_OFFSET) {
-                               /* Save off the management agent address */
+                       if (kv->key.type == CSR1212_KV_TYPE_CSR_OFFSET)
                                management_agent_addr =
                                    CSR1212_REGISTER_SPACE_BASE +
                                    (kv->value.csr_offset << 2);
 
-                               SBP2_DEBUG("sbp2_management_agent_addr = %x",
-                                          (unsigned int)management_agent_addr);
-                       } else if (kv->key.type == CSR1212_KV_TYPE_IMMEDIATE) {
-                               scsi_id->sbp2_lun =
-                                   ORB_SET_LUN(kv->value.immediate);
-                       }
-                       break;
-
-               case SBP2_COMMAND_SET_SPEC_ID_KEY:
-                       /* Command spec organization */
-                       command_set_spec_id = kv->value.immediate;
-                       SBP2_DEBUG("sbp2_command_set_spec_id = %x",
-                                  (unsigned int)command_set_spec_id);
-                       break;
-
-               case SBP2_COMMAND_SET_KEY:
-                       /* Command set used by sbp2 device */
-                       command_set = kv->value.immediate;
-                       SBP2_DEBUG("sbp2_command_set = %x",
-                                  (unsigned int)command_set);
+                       else if (kv->key.type == CSR1212_KV_TYPE_IMMEDIATE)
+                               lu->lun = ORB_SET_LUN(kv->value.immediate);
                        break;
 
                case SBP2_UNIT_CHARACTERISTICS_KEY:
-                       /*
-                        * Unit characterisitcs (orb related stuff
-                        * that I'm not yet paying attention to)
-                        */
+                       /* FIXME: This is ignored so far.
+                        * See SBP-2 clause 7.4.8. */
                        unit_characteristics = kv->value.immediate;
-                       SBP2_DEBUG("sbp2_unit_characteristics = %x",
-                                  (unsigned int)unit_characteristics);
                        break;
 
                case SBP2_FIRMWARE_REVISION_KEY:
-                       /* Firmware revision */
                        firmware_revision = kv->value.immediate;
-                       SBP2_DEBUG("sbp2_firmware_revision = %x",
-                                  (unsigned int)firmware_revision);
                        break;
 
                default:
+                       /* FIXME: Check for SBP2_DEVICE_TYPE_AND_LUN_KEY.
+                        * Its "ordered" bit has consequences for command ORB
+                        * list handling. See SBP-2 clauses 4.6, 7.4.11, 10.2 */
                        break;
                }
        }
@@ -1608,12 +1394,14 @@ static void sbp2_parse_unit_directory(struct scsi_id_instance_data *scsi_id,
 
        if (!(workarounds & SBP2_WORKAROUND_OVERRIDE))
                for (i = 0; i < ARRAY_SIZE(sbp2_workarounds_table); i++) {
-                       if (sbp2_workarounds_table[i].firmware_revision &&
+                       if (sbp2_workarounds_table[i].firmware_revision !=
+                           SBP2_ROM_VALUE_WILDCARD &&
                            sbp2_workarounds_table[i].firmware_revision !=
                            (firmware_revision & 0xffff00))
                                continue;
-                       if (sbp2_workarounds_table[i].model_id &&
-                           sbp2_workarounds_table[i].model_id != ud->model_id)
+                       if (sbp2_workarounds_table[i].model !=
+                           SBP2_ROM_VALUE_WILDCARD &&
+                           sbp2_workarounds_table[i].model != model)
                                continue;
                        workarounds |= sbp2_workarounds_table[i].workarounds;
                        break;
@@ -1624,35 +1412,30 @@ static void sbp2_parse_unit_directory(struct scsi_id_instance_data *scsi_id,
                          "(firmware_revision 0x%06x, vendor_id 0x%06x,"
                          " model_id 0x%06x)",
                          NODE_BUS_ARGS(ud->ne->host, ud->ne->nodeid),
-                         workarounds, firmware_revision,
-                         ud->vendor_id ? ud->vendor_id : ud->ne->vendor_id,
-                         ud->model_id);
+                         workarounds, firmware_revision, ud->vendor_id,
+                         model);
 
        /* We would need one SCSI host template for each target to adjust
         * max_sectors on the fly, therefore warn only. */
        if (workarounds & SBP2_WORKAROUND_128K_MAX_TRANS &&
-           (max_sectors * 512) > (128 * 1024))
-               SBP2_WARN("Node " NODE_BUS_FMT ": Bridge only supports 128KB "
+           (sbp2_max_sectors * 512) > (128 * 1024))
+               SBP2_INFO("Node " NODE_BUS_FMT ": Bridge only supports 128KB "
                          "max transfer size. WARNING: Current max_sectors "
                          "setting is larger than 128KB (%d sectors)",
                          NODE_BUS_ARGS(ud->ne->host, ud->ne->nodeid),
-                         max_sectors);
+                         sbp2_max_sectors);
 
        /* If this is a logical unit directory entry, process the parent
         * to get the values. */
        if (ud->flags & UNIT_DIRECTORY_LUN_DIRECTORY) {
-               struct unit_directory *parent_ud =
-                       container_of(ud->device.parent, struct unit_directory, device);
-               sbp2_parse_unit_directory(scsi_id, parent_ud);
+               struct unit_directory *parent_ud = container_of(
+                       ud->device.parent, struct unit_directory, device);
+               sbp2_parse_unit_directory(lu, parent_ud);
        } else {
-               scsi_id->sbp2_management_agent_addr = management_agent_addr;
-               scsi_id->sbp2_command_set_spec_id = command_set_spec_id;
-               scsi_id->sbp2_command_set = command_set;
-               scsi_id->sbp2_unit_characteristics = unit_characteristics;
-               scsi_id->sbp2_firmware_revision = firmware_revision;
-               scsi_id->workarounds = workarounds;
+               lu->management_agent_addr = management_agent_addr;
+               lu->workarounds = workarounds;
                if (ud->flags & UNIT_DIRECTORY_HAS_LUN)
-                       scsi_id->sbp2_lun = ORB_SET_LUN(ud->lun);
+                       lu->lun = ORB_SET_LUN(ud->lun);
        }
 }
 
@@ -1667,275 +1450,144 @@ static void sbp2_parse_unit_directory(struct scsi_id_instance_data *scsi_id,
  * the speed that it needs to use, and the max_rec the host supports, and
  * it takes care of the rest.
  */
-static int sbp2_max_speed_and_size(struct scsi_id_instance_data *scsi_id)
+static int sbp2_max_speed_and_size(struct sbp2_lu *lu)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
+       struct sbp2_fwhost_info *hi = lu->hi;
        u8 payload;
 
-       SBP2_DEBUG_ENTER();
-
-       scsi_id->speed_code =
-           hi->host->speed[NODEID_TO_NODE(scsi_id->ne->nodeid)];
+       lu->speed_code = hi->host->speed[NODEID_TO_NODE(lu->ne->nodeid)];
 
-       /* Bump down our speed if the user requested it */
-       if (scsi_id->speed_code > max_speed) {
-               scsi_id->speed_code = max_speed;
-               SBP2_ERR("Forcing SBP-2 max speed down to %s",
-                        hpsb_speedto_str[scsi_id->speed_code]);
+       if (lu->speed_code > sbp2_max_speed) {
+               lu->speed_code = sbp2_max_speed;
+               SBP2_INFO("Reducing speed to %s",
+                         hpsb_speedto_str[sbp2_max_speed]);
        }
 
        /* Payload size is the lesser of what our speed supports and what
         * our host supports.  */
-       payload = min(sbp2_speedto_max_payload[scsi_id->speed_code],
+       payload = min(sbp2_speedto_max_payload[lu->speed_code],
                      (u8) (hi->host->csr.max_rec - 1));
 
        /* If physical DMA is off, work around limitation in ohci1394:
         * packet size must not exceed PAGE_SIZE */
-       if (scsi_id->ne->host->low_addr_space < (1ULL << 32))
+       if (lu->ne->host->low_addr_space < (1ULL << 32))
                while (SBP2_PAYLOAD_TO_BYTES(payload) + 24 > PAGE_SIZE &&
                       payload)
                        payload--;
 
-       HPSB_DEBUG("Node " NODE_BUS_FMT ": Max speed [%s] - Max payload [%u]",
-                  NODE_BUS_ARGS(hi->host, scsi_id->ne->nodeid),
-                  hpsb_speedto_str[scsi_id->speed_code],
-                  SBP2_PAYLOAD_TO_BYTES(payload));
+       SBP2_INFO("Node " NODE_BUS_FMT ": Max speed [%s] - Max payload [%u]",
+                 NODE_BUS_ARGS(hi->host, lu->ne->nodeid),
+                 hpsb_speedto_str[lu->speed_code],
+                 SBP2_PAYLOAD_TO_BYTES(payload));
 
-       scsi_id->max_payload_size = payload;
+       lu->max_payload_size = payload;
        return 0;
 }
 
-/*
- * This function is called in order to perform a SBP-2 agent reset.
- */
-static int sbp2_agent_reset(struct scsi_id_instance_data *scsi_id, int wait)
+static int sbp2_agent_reset(struct sbp2_lu *lu, int wait)
 {
        quadlet_t data;
        u64 addr;
        int retval;
        unsigned long flags;
 
-       SBP2_DEBUG_ENTER();
-
-       cancel_delayed_work(&scsi_id->protocol_work);
+       /* flush lu->protocol_work */
        if (wait)
                flush_scheduled_work();
 
        data = ntohl(SBP2_AGENT_RESET_DATA);
-       addr = scsi_id->sbp2_command_block_agent_addr + SBP2_AGENT_RESET_OFFSET;
+       addr = lu->command_block_agent_addr + SBP2_AGENT_RESET_OFFSET;
 
        if (wait)
-               retval = hpsb_node_write(scsi_id->ne, addr, &data, 4);
+               retval = hpsb_node_write(lu->ne, addr, &data, 4);
        else
-               retval = sbp2util_node_write_no_wait(scsi_id->ne, addr, &data, 4);
+               retval = sbp2util_node_write_no_wait(lu->ne, addr, &data, 4);
 
        if (retval < 0) {
                SBP2_ERR("hpsb_node_write failed.\n");
                return -EIO;
        }
 
-       /*
-        * Need to make sure orb pointer is written on next command
-        */
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       scsi_id->last_orb = NULL;
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+       /* make sure that the ORB_POINTER is written on next command */
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       lu->last_orb = NULL;
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
        return 0;
 }
 
-static void sbp2_prep_command_orb_sg(struct sbp2_command_orb *orb,
-                                    struct sbp2scsi_host_info *hi,
-                                    struct sbp2_command_info *command,
-                                    unsigned int scsi_use_sg,
-                                    struct scatterlist *sgpnt,
-                                    u32 orb_direction,
-                                    enum dma_data_direction dma_dir)
+static int sbp2_prep_command_orb_sg(struct sbp2_command_orb *orb,
+                                   struct sbp2_fwhost_info *hi,
+                                   struct sbp2_command_info *cmd,
+                                   unsigned int sg_count,
+                                   struct scatterlist *sg,
+                                   u32 orb_direction,
+                                   enum dma_data_direction dma_dir)
 {
-       command->dma_dir = dma_dir;
-       orb->data_descriptor_hi = ORB_SET_NODE_ID(hi->host->node_id);
-       orb->misc |= ORB_SET_DIRECTION(orb_direction);
-
-       /* Special case if only one element (and less than 64KB in size) */
-       if ((scsi_use_sg == 1) &&
-           (sgpnt[0].length <= SBP2_MAX_SG_ELEMENT_LENGTH)) {
-
-               SBP2_DEBUG("Only one s/g element");
-               command->dma_size = sgpnt[0].length;
-               command->dma_type = CMD_DMA_PAGE;
-               command->cmd_dma = pci_map_page(hi->host->pdev,
-                                               sgpnt[0].page,
-                                               sgpnt[0].offset,
-                                               command->dma_size,
-                                               command->dma_dir);
-               SBP2_DMA_ALLOC("single page scatter element");
-
-               orb->data_descriptor_lo = command->cmd_dma;
-               orb->misc |= ORB_SET_DATA_SIZE(command->dma_size);
-
-       } else {
-               struct sbp2_unrestricted_page_table *sg_element =
-                                       &command->scatter_gather_element[0];
-               u32 sg_count, sg_len;
-               dma_addr_t sg_addr;
-               int i, count = pci_map_sg(hi->host->pdev, sgpnt, scsi_use_sg,
-                                         dma_dir);
+       struct device *dmadev = hi->host->device.parent;
+       struct sbp2_unrestricted_page_table *pt;
+       int i, n;
 
-               SBP2_DMA_ALLOC("scatter list");
-
-               command->dma_size = scsi_use_sg;
-               command->sge_buffer = sgpnt;
-
-               /* use page tables (s/g) */
-               orb->misc |= ORB_SET_PAGE_TABLE_PRESENT(0x1);
-               orb->data_descriptor_lo = command->sge_dma;
-
-               /*
-                * Loop through and fill out our sbp-2 page tables
-                * (and split up anything too large)
-                */
-               for (i = 0, sg_count = 0 ; i < count; i++, sgpnt++) {
-                       sg_len = sg_dma_len(sgpnt);
-                       sg_addr = sg_dma_address(sgpnt);
-                       while (sg_len) {
-                               sg_element[sg_count].segment_base_lo = sg_addr;
-                               if (sg_len > SBP2_MAX_SG_ELEMENT_LENGTH) {
-                                       sg_element[sg_count].length_segment_base_hi =
-                                               PAGE_TABLE_SET_SEGMENT_LENGTH(SBP2_MAX_SG_ELEMENT_LENGTH);
-                                       sg_addr += SBP2_MAX_SG_ELEMENT_LENGTH;
-                                       sg_len -= SBP2_MAX_SG_ELEMENT_LENGTH;
-                               } else {
-                                       sg_element[sg_count].length_segment_base_hi =
-                                               PAGE_TABLE_SET_SEGMENT_LENGTH(sg_len);
-                                       sg_len = 0;
-                               }
-                               sg_count++;
-                       }
-               }
-
-               /* Number of page table (s/g) elements */
-               orb->misc |= ORB_SET_DATA_SIZE(sg_count);
-
-               sbp2util_packet_dump(sg_element,
-                                    (sizeof(struct sbp2_unrestricted_page_table)) * sg_count,
-                                    "sbp2 s/g list", command->sge_dma);
-
-               /* Byte swap page tables if necessary */
-               sbp2util_cpu_to_be32_buffer(sg_element,
-                                           (sizeof(struct sbp2_unrestricted_page_table)) *
-                                           sg_count);
-       }
-}
+       n = dma_map_sg(dmadev, sg, sg_count, dma_dir);
+       if (n == 0)
+               return -ENOMEM;
 
-static void sbp2_prep_command_orb_no_sg(struct sbp2_command_orb *orb,
-                                       struct sbp2scsi_host_info *hi,
-                                       struct sbp2_command_info *command,
-                                       struct scatterlist *sgpnt,
-                                       u32 orb_direction,
-                                       unsigned int scsi_request_bufflen,
-                                       void *scsi_request_buffer,
-                                       enum dma_data_direction dma_dir)
-{
-       command->dma_dir = dma_dir;
-       command->dma_size = scsi_request_bufflen;
-       command->dma_type = CMD_DMA_SINGLE;
-       command->cmd_dma = pci_map_single(hi->host->pdev, scsi_request_buffer,
-                                         command->dma_size, command->dma_dir);
        orb->data_descriptor_hi = ORB_SET_NODE_ID(hi->host->node_id);
        orb->misc |= ORB_SET_DIRECTION(orb_direction);
 
-       SBP2_DMA_ALLOC("single bulk");
-
-       /*
-        * Handle case where we get a command w/o s/g enabled (but
-        * check for transfers larger than 64K)
-        */
-       if (scsi_request_bufflen <= SBP2_MAX_SG_ELEMENT_LENGTH) {
-
-               orb->data_descriptor_lo = command->cmd_dma;
-               orb->misc |= ORB_SET_DATA_SIZE(scsi_request_bufflen);
-
+       /* special case if only one element (and less than 64KB in size) */
+       if (n == 1) {
+               orb->misc |= ORB_SET_DATA_SIZE(sg_dma_len(sg));
+               orb->data_descriptor_lo = sg_dma_address(sg);
        } else {
-               struct sbp2_unrestricted_page_table *sg_element =
-                       &command->scatter_gather_element[0];
-               u32 sg_count, sg_len;
-               dma_addr_t sg_addr;
-
-               /*
-                * Need to turn this into page tables, since the
-                * buffer is too large.
-                */
-               orb->data_descriptor_lo = command->sge_dma;
+               pt = &cmd->scatter_gather_element[0];
 
-               /* Use page tables (s/g) */
-               orb->misc |= ORB_SET_PAGE_TABLE_PRESENT(0x1);
+               dma_sync_single_for_cpu(dmadev, cmd->sge_dma,
+                                       sizeof(cmd->scatter_gather_element),
+                                       DMA_TO_DEVICE);
 
-               /*
-                * fill out our sbp-2 page tables (and split up
-                * the large buffer)
-                */
-               sg_count = 0;
-               sg_len = scsi_request_bufflen;
-               sg_addr = command->cmd_dma;
-               while (sg_len) {
-                       sg_element[sg_count].segment_base_lo = sg_addr;
-                       if (sg_len > SBP2_MAX_SG_ELEMENT_LENGTH) {
-                               sg_element[sg_count].length_segment_base_hi =
-                                       PAGE_TABLE_SET_SEGMENT_LENGTH(SBP2_MAX_SG_ELEMENT_LENGTH);
-                               sg_addr += SBP2_MAX_SG_ELEMENT_LENGTH;
-                               sg_len -= SBP2_MAX_SG_ELEMENT_LENGTH;
-                       } else {
-                               sg_element[sg_count].length_segment_base_hi =
-                                       PAGE_TABLE_SET_SEGMENT_LENGTH(sg_len);
-                               sg_len = 0;
-                       }
-                       sg_count++;
+               for_each_sg(sg, sg, n, i) {
+                       pt[i].high = cpu_to_be32(sg_dma_len(sg) << 16);
+                       pt[i].low = cpu_to_be32(sg_dma_address(sg));
                }
 
-               /* Number of page table (s/g) elements */
-               orb->misc |= ORB_SET_DATA_SIZE(sg_count);
+               orb->misc |= ORB_SET_PAGE_TABLE_PRESENT(0x1) |
+                            ORB_SET_DATA_SIZE(n);
+               orb->data_descriptor_lo = cmd->sge_dma;
 
-               sbp2util_packet_dump(sg_element,
-                                    (sizeof(struct sbp2_unrestricted_page_table)) * sg_count,
-                                    "sbp2 s/g list", command->sge_dma);
-
-               /* Byte swap page tables if necessary */
-               sbp2util_cpu_to_be32_buffer(sg_element,
-                                           (sizeof(struct sbp2_unrestricted_page_table)) *
-                                            sg_count);
+               dma_sync_single_for_device(dmadev, cmd->sge_dma,
+                                          sizeof(cmd->scatter_gather_element),
+                                          DMA_TO_DEVICE);
        }
+       return 0;
 }
 
-/*
- * This function is called to create the actual command orb and s/g list
- * out of the scsi command itself.
- */
-static void sbp2_create_command_orb(struct scsi_id_instance_data *scsi_id,
-                                   struct sbp2_command_info *command,
-                                   unchar *scsi_cmd,
-                                   unsigned int scsi_use_sg,
-                                   unsigned int scsi_request_bufflen,
-                                   void *scsi_request_buffer,
-                                   enum dma_data_direction dma_dir)
+static int sbp2_create_command_orb(struct sbp2_lu *lu,
+                                  struct sbp2_command_info *cmd,
+                                  struct scsi_cmnd *SCpnt)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
-       struct scatterlist *sgpnt = (struct scatterlist *)scsi_request_buffer;
-       struct sbp2_command_orb *command_orb = &command->command_orb;
+       struct device *dmadev = lu->hi->host->device.parent;
+       struct sbp2_command_orb *orb = &cmd->command_orb;
+       unsigned int scsi_request_bufflen = scsi_bufflen(SCpnt);
+       enum dma_data_direction dma_dir = SCpnt->sc_data_direction;
        u32 orb_direction;
+       int ret;
 
+       dma_sync_single_for_cpu(dmadev, cmd->command_orb_dma,
+                               sizeof(struct sbp2_command_orb), DMA_TO_DEVICE);
        /*
-        * Set-up our command ORB..
+        * Set-up our command ORB.
         *
         * NOTE: We're doing unrestricted page tables (s/g), as this is
         * best performance (at least with the devices I have). This means
         * that data_size becomes the number of s/g elements, and
         * page_size should be zero (for unrestricted).
         */
-       command_orb->next_ORB_hi = ORB_SET_NULL_PTR(1);
-       command_orb->next_ORB_lo = 0x0;
-       command_orb->misc = ORB_SET_MAX_PAYLOAD(scsi_id->max_payload_size);
-       command_orb->misc |= ORB_SET_SPEED(scsi_id->speed_code);
-       command_orb->misc |= ORB_SET_NOTIFY(1); /* Notify us when complete */
+       orb->next_ORB_hi = ORB_SET_NULL_PTR(1);
+       orb->next_ORB_lo = 0x0;
+       orb->misc = ORB_SET_MAX_PAYLOAD(lu->max_payload_size);
+       orb->misc |= ORB_SET_SPEED(lu->speed_code);
+       orb->misc |= ORB_SET_NOTIFY(1);
 
        if (dma_dir == DMA_NONE)
                orb_direction = ORB_DIRECTION_NO_DATA_TRANSFER;
@@ -1944,66 +1596,47 @@ static void sbp2_create_command_orb(struct scsi_id_instance_data *scsi_id,
        else if (dma_dir == DMA_FROM_DEVICE && scsi_request_bufflen)
                orb_direction = ORB_DIRECTION_READ_FROM_MEDIA;
        else {
-               SBP2_WARN("Falling back to DMA_NONE");
+               SBP2_INFO("Falling back to DMA_NONE");
                orb_direction = ORB_DIRECTION_NO_DATA_TRANSFER;
        }
 
-       /* Set-up our pagetable stuff */
+       /* set up our page table stuff */
        if (orb_direction == ORB_DIRECTION_NO_DATA_TRANSFER) {
-               SBP2_DEBUG("No data transfer");
-               command_orb->data_descriptor_hi = 0x0;
-               command_orb->data_descriptor_lo = 0x0;
-               command_orb->misc |= ORB_SET_DIRECTION(1);
-       } else if (scsi_use_sg) {
-               SBP2_DEBUG("Use scatter/gather");
-               sbp2_prep_command_orb_sg(command_orb, hi, command, scsi_use_sg,
-                                        sgpnt, orb_direction, dma_dir);
+               orb->data_descriptor_hi = 0x0;
+               orb->data_descriptor_lo = 0x0;
+               orb->misc |= ORB_SET_DIRECTION(1);
+               ret = 0;
        } else {
-               SBP2_DEBUG("No scatter/gather");
-               sbp2_prep_command_orb_no_sg(command_orb, hi, command, sgpnt,
-                                           orb_direction, scsi_request_bufflen,
-                                           scsi_request_buffer, dma_dir);
+               ret = sbp2_prep_command_orb_sg(orb, lu->hi, cmd,
+                                              scsi_sg_count(SCpnt),
+                                              scsi_sglist(SCpnt),
+                                              orb_direction, dma_dir);
        }
+       sbp2util_cpu_to_be32_buffer(orb, sizeof(*orb));
 
-       /* Byte swap command ORB if necessary */
-       sbp2util_cpu_to_be32_buffer(command_orb, sizeof(struct sbp2_command_orb));
+       memset(orb->cdb, 0, sizeof(orb->cdb));
+       memcpy(orb->cdb, SCpnt->cmnd, SCpnt->cmd_len);
 
-       /* Put our scsi command in the command ORB */
-       memset(command_orb->cdb, 0, 12);
-       memcpy(command_orb->cdb, scsi_cmd, COMMAND_SIZE(*scsi_cmd));
+       dma_sync_single_for_device(dmadev, cmd->command_orb_dma,
+                       sizeof(struct sbp2_command_orb), DMA_TO_DEVICE);
+       return ret;
 }
 
-/*
- * This function is called in order to begin a regular SBP-2 command.
- */
-static void sbp2_link_orb_command(struct scsi_id_instance_data *scsi_id,
-                                struct sbp2_command_info *command)
+static void sbp2_link_orb_command(struct sbp2_lu *lu,
+                                 struct sbp2_command_info *cmd)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
-       struct sbp2_command_orb *command_orb = &command->command_orb;
+       struct sbp2_fwhost_info *hi = lu->hi;
        struct sbp2_command_orb *last_orb;
        dma_addr_t last_orb_dma;
-       u64 addr = scsi_id->sbp2_command_block_agent_addr;
+       u64 addr = lu->command_block_agent_addr;
        quadlet_t data[2];
        size_t length;
        unsigned long flags;
 
-       outstanding_orb_incr;
-       SBP2_ORB_DEBUG("sending command orb %p, total orbs = %x",
-                      command_orb, global_outstanding_command_orbs);
-
-       pci_dma_sync_single_for_device(hi->host->pdev, command->command_orb_dma,
-                                      sizeof(struct sbp2_command_orb),
-                                      PCI_DMA_TODEVICE);
-       pci_dma_sync_single_for_device(hi->host->pdev, command->sge_dma,
-                                      sizeof(command->scatter_gather_element),
-                                      PCI_DMA_BIDIRECTIONAL);
-       /*
-        * Check to see if there are any previous orbs to use
-        */
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       last_orb = scsi_id->last_orb;
-       last_orb_dma = scsi_id->last_orb_dma;
+       /* check to see if there are any previous orbs to use */
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       last_orb = lu->last_orb;
+       last_orb_dma = lu->last_orb_dma;
        if (!last_orb) {
                /*
                 * last_orb == NULL means: We know that the target's fetch agent
@@ -2011,7 +1644,7 @@ static void sbp2_link_orb_command(struct scsi_id_instance_data *scsi_id,
                 */
                addr += SBP2_ORB_POINTER_OFFSET;
                data[0] = ORB_SET_NODE_ID(hi->host->node_id);
-               data[1] = command->command_orb_dma;
+               data[1] = cmd->command_orb_dma;
                sbp2util_cpu_to_be32_buffer(data, 8);
                length = 8;
        } else {
@@ -2022,27 +1655,26 @@ static void sbp2_link_orb_command(struct scsi_id_instance_data *scsi_id,
                 * The target's fetch agent may or may not have read this
                 * previous ORB yet.
                 */
-               pci_dma_sync_single_for_cpu(hi->host->pdev, last_orb_dma,
-                                           sizeof(struct sbp2_command_orb),
-                                           PCI_DMA_TODEVICE);
-               last_orb->next_ORB_lo = cpu_to_be32(command->command_orb_dma);
+               dma_sync_single_for_cpu(hi->host->device.parent, last_orb_dma,
+                                       sizeof(struct sbp2_command_orb),
+                                       DMA_TO_DEVICE);
+               last_orb->next_ORB_lo = cpu_to_be32(cmd->command_orb_dma);
                wmb();
                /* Tells hardware that this pointer is valid */
                last_orb->next_ORB_hi = 0;
-               pci_dma_sync_single_for_device(hi->host->pdev, last_orb_dma,
-                                              sizeof(struct sbp2_command_orb),
-                                              PCI_DMA_TODEVICE);
+               dma_sync_single_for_device(hi->host->device.parent,
+                                          last_orb_dma,
+                                          sizeof(struct sbp2_command_orb),
+                                          DMA_TO_DEVICE);
                addr += SBP2_DOORBELL_OFFSET;
                data[0] = 0;
                length = 4;
        }
-       scsi_id->last_orb = command_orb;
-       scsi_id->last_orb_dma = command->command_orb_dma;
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+       lu->last_orb = &cmd->command_orb;
+       lu->last_orb_dma = cmd->command_orb_dma;
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
-       SBP2_ORB_DEBUG("write to %s register, command orb %p",
-                       last_orb ? "DOORBELL" : "ORB_POINTER", command_orb);
-       if (sbp2util_node_write_no_wait(scsi_id->ne, addr, data, length)) {
+       if (sbp2util_node_write_no_wait(lu->ne, addr, data, length)) {
                /*
                 * sbp2util_node_write_no_wait failed. We certainly ran out
                 * of transaction labels, perhaps just because there were no
@@ -2051,65 +1683,37 @@ static void sbp2_link_orb_command(struct scsi_id_instance_data *scsi_id,
                 * the workqueue job will sleep to guaranteedly get a tlabel.
                 * We do not accept new commands until the job is over.
                 */
-               scsi_block_requests(scsi_id->scsi_host);
-               PREPARE_DELAYED_WORK(&scsi_id->protocol_work,
+               scsi_block_requests(lu->shost);
+               PREPARE_WORK(&lu->protocol_work,
                             last_orb ? sbp2util_write_doorbell:
                                        sbp2util_write_orb_pointer);
-               schedule_delayed_work(&scsi_id->protocol_work, 0);
+               schedule_work(&lu->protocol_work);
        }
 }
 
-/*
- * This function is called in order to begin a regular SBP-2 command.
- */
-static int sbp2_send_command(struct scsi_id_instance_data *scsi_id,
-                            struct scsi_cmnd *SCpnt,
+static int sbp2_send_command(struct sbp2_lu *lu, struct scsi_cmnd *SCpnt,
                             void (*done)(struct scsi_cmnd *))
 {
-       unchar *cmd = (unchar *) SCpnt->cmnd;
-       unsigned int request_bufflen = SCpnt->request_bufflen;
-       struct sbp2_command_info *command;
-
-       SBP2_DEBUG_ENTER();
-       SBP2_DEBUG("SCSI transfer size = %x", request_bufflen);
-       SBP2_DEBUG("SCSI s/g elements = %x", (unsigned int)SCpnt->use_sg);
+       struct sbp2_command_info *cmd;
 
-       /*
-        * Allocate a command orb and s/g structure
-        */
-       command = sbp2util_allocate_command_orb(scsi_id, SCpnt, done);
-       if (!command) {
+       cmd = sbp2util_allocate_command_orb(lu, SCpnt, done);
+       if (!cmd)
                return -EIO;
-       }
-
-       /*
-        * Now actually fill in the comamnd orb and sbp2 s/g list
-        */
-       sbp2_create_command_orb(scsi_id, command, cmd, SCpnt->use_sg,
-                               request_bufflen, SCpnt->request_buffer,
-                               SCpnt->sc_data_direction);
 
-       sbp2util_packet_dump(&command->command_orb, sizeof(struct sbp2_command_orb),
-                            "sbp2 command orb", command->command_orb_dma);
-
-       /*
-        * Link up the orb, and ring the doorbell if needed
-        */
-       sbp2_link_orb_command(scsi_id, command);
+       if (sbp2_create_command_orb(lu, cmd, SCpnt))
+               return -ENOMEM;
 
+       sbp2_link_orb_command(lu, cmd);
        return 0;
 }
 
 /*
  * Translates SBP-2 status into SCSI sense data for check conditions
  */
-static unsigned int sbp2_status_to_sense_data(unchar *sbp2_status, unchar *sense_data)
+static unsigned int sbp2_status_to_sense_data(unchar *sbp2_status,
+                                             unchar *sense_data)
 {
-       SBP2_DEBUG_ENTER();
-
-       /*
-        * Ok, it's pretty ugly...   ;-)
-        */
+       /* OK, it's pretty ugly... ;-) */
        sense_data[0] = 0x70;
        sense_data[1] = 0x0;
        sense_data[2] = sbp2_status[9];
@@ -2127,28 +1731,21 @@ static unsigned int sbp2_status_to_sense_data(unchar *sbp2_status, unchar *sense
        sense_data[14] = sbp2_status[20];
        sense_data[15] = sbp2_status[21];
 
-       return sbp2_status[8] & 0x3f;   /* return scsi status */
+       return sbp2_status[8] & 0x3f;
 }
 
-/*
- * This function deals with status writes from the SBP-2 device
- */
 static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid,
                                    int destid, quadlet_t *data, u64 addr,
                                    size_t length, u16 fl)
 {
-       struct sbp2scsi_host_info *hi;
-       struct scsi_id_instance_data *scsi_id = NULL, *scsi_id_tmp;
+       struct sbp2_fwhost_info *hi;
+       struct sbp2_lu *lu = NULL, *lu_tmp;
        struct scsi_cmnd *SCpnt = NULL;
        struct sbp2_status_block *sb;
        u32 scsi_status = SBP2_SCSI_STATUS_GOOD;
-       struct sbp2_command_info *command;
+       struct sbp2_command_info *cmd;
        unsigned long flags;
 
-       SBP2_DEBUG_ENTER();
-
-       sbp2util_packet_dump(data, length, "sbp2 status write by device", (u32)addr);
-
        if (unlikely(length < 8 || length > sizeof(struct sbp2_status_block))) {
                SBP2_ERR("Wrong size of status block");
                return RCODE_ADDRESS_ERROR;
@@ -2162,131 +1759,94 @@ static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid,
                SBP2_ERR("host info is NULL - this is bad!");
                return RCODE_ADDRESS_ERROR;
        }
-       /*
-        * Find our scsi_id structure by looking at the status fifo address
-        * written to by the sbp2 device.
-        */
-       list_for_each_entry(scsi_id_tmp, &hi->scsi_ids, scsi_list) {
-               if (scsi_id_tmp->ne->nodeid == nodeid &&
-                   scsi_id_tmp->status_fifo_addr == addr) {
-                       scsi_id = scsi_id_tmp;
+
+       /* Find the unit which wrote the status. */
+       read_lock_irqsave(&sbp2_hi_logical_units_lock, flags);
+       list_for_each_entry(lu_tmp, &hi->logical_units, lu_list) {
+               if (lu_tmp->ne->nodeid == nodeid &&
+                   lu_tmp->status_fifo_addr == addr) {
+                       lu = lu_tmp;
                        break;
                }
        }
-       if (unlikely(!scsi_id)) {
-               SBP2_ERR("scsi_id is NULL - device is gone?");
+       read_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags);
+
+       if (unlikely(!lu)) {
+               SBP2_ERR("lu is NULL - device is gone?");
                return RCODE_ADDRESS_ERROR;
        }
 
-       /*
-        * Put response into scsi_id status fifo buffer. The first two bytes
+       /* Put response into lu status fifo buffer. The first two bytes
         * come in big endian bit order. Often the target writes only a
         * truncated status block, minimally the first two quadlets. The rest
-        * is implied to be zeros.
-        */
-       sb = &scsi_id->status_block;
+        * is implied to be zeros. */
+       sb = &lu->status_block;
        memset(sb->command_set_dependent, 0, sizeof(sb->command_set_dependent));
        memcpy(sb, data, length);
        sbp2util_be32_to_cpu_buffer(sb, 8);
 
-       /*
-        * Ignore unsolicited status. Handle command ORB status.
-        */
+       /* Ignore unsolicited status. Handle command ORB status. */
        if (unlikely(STATUS_GET_SRC(sb->ORB_offset_hi_misc) == 2))
-               command = NULL;
+               cmd = NULL;
        else
-               command = sbp2util_find_command_for_orb(scsi_id,
-                                                       sb->ORB_offset_lo);
-       if (command) {
-               SBP2_DEBUG("Found status for command ORB");
-               pci_dma_sync_single_for_cpu(hi->host->pdev, command->command_orb_dma,
-                                           sizeof(struct sbp2_command_orb),
-                                           PCI_DMA_TODEVICE);
-               pci_dma_sync_single_for_cpu(hi->host->pdev, command->sge_dma,
-                                           sizeof(command->scatter_gather_element),
-                                           PCI_DMA_BIDIRECTIONAL);
-
-               SBP2_ORB_DEBUG("matched command orb %p", &command->command_orb);
-               outstanding_orb_decr;
-
-               /*
-                * Matched status with command, now grab scsi command pointers
-                * and check status.
-                */
+               cmd = sbp2util_find_command_for_orb(lu, sb->ORB_offset_lo);
+       if (cmd) {
+               /* Grab SCSI command pointers and check status. */
                /*
                 * FIXME: If the src field in the status is 1, the ORB DMA must
                 * not be reused until status for a subsequent ORB is received.
                 */
-               SCpnt = command->Current_SCpnt;
-               spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-               sbp2util_mark_command_completed(scsi_id, command);
-               spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+               SCpnt = cmd->Current_SCpnt;
+               spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+               sbp2util_mark_command_completed(lu, cmd);
+               spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
                if (SCpnt) {
                        u32 h = sb->ORB_offset_hi_misc;
                        u32 r = STATUS_GET_RESP(h);
 
                        if (r != RESP_STATUS_REQUEST_COMPLETE) {
-                               SBP2_WARN("resp 0x%x, sbp_status 0x%x",
+                               SBP2_INFO("resp 0x%x, sbp_status 0x%x",
                                          r, STATUS_GET_SBP_STATUS(h));
                                scsi_status =
                                        r == RESP_STATUS_TRANSPORT_FAILURE ?
                                        SBP2_SCSI_STATUS_BUSY :
                                        SBP2_SCSI_STATUS_COMMAND_TERMINATED;
                        }
-                       /*
-                        * See if the target stored any scsi status information.
-                        */
-                       if (STATUS_GET_LEN(h) > 1) {
-                               SBP2_DEBUG("CHECK CONDITION");
+
+                       if (STATUS_GET_LEN(h) > 1)
                                scsi_status = sbp2_status_to_sense_data(
                                        (unchar *)sb, SCpnt->sense_buffer);
-                       }
-                       /*
-                        * Check to see if the dead bit is set. If so, we'll
-                        * have to initiate a fetch agent reset.
-                        */
-                       if (STATUS_TEST_DEAD(h)) {
-                               SBP2_DEBUG("Dead bit set - "
-                                          "initiating fetch agent reset");
-                                sbp2_agent_reset(scsi_id, 0);
-                       }
-                       SBP2_ORB_DEBUG("completing command orb %p", &command->command_orb);
+
+                       if (STATUS_TEST_DEAD(h))
+                                sbp2_agent_reset(lu, 0);
                }
 
-               /*
-                * Check here to see if there are no commands in-use. If there
+               /* Check here to see if there are no commands in-use. If there
                 * are none, we know that the fetch agent left the active state
                 * _and_ that we did not reactivate it yet. Therefore clear
                 * last_orb so that next time we write directly to the
                 * ORB_POINTER register. That way the fetch agent does not need
-                * to refetch the next_ORB.
-                */
-               spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-               if (list_empty(&scsi_id->sbp2_command_orb_inuse))
-                       scsi_id->last_orb = NULL;
-               spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+                * to refetch the next_ORB. */
+               spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+               if (list_empty(&lu->cmd_orb_inuse))
+                       lu->last_orb = NULL;
+               spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
        } else {
-               /*
-                * It's probably a login/logout/reconnect status.
-                */
-               if ((sb->ORB_offset_lo == scsi_id->reconnect_orb_dma) ||
-                   (sb->ORB_offset_lo == scsi_id->login_orb_dma) ||
-                   (sb->ORB_offset_lo == scsi_id->query_logins_orb_dma) ||
-                   (sb->ORB_offset_lo == scsi_id->logout_orb_dma)) {
-                       scsi_id->access_complete = 1;
-                       wake_up_interruptible(&access_wq);
+               /* It's probably status after a management request. */
+               if ((sb->ORB_offset_lo == lu->reconnect_orb_dma) ||
+                   (sb->ORB_offset_lo == lu->login_orb_dma) ||
+                   (sb->ORB_offset_lo == lu->query_logins_orb_dma) ||
+                   (sb->ORB_offset_lo == lu->logout_orb_dma)) {
+                       lu->access_complete = 1;
+                       wake_up_interruptible(&sbp2_access_wq);
                }
        }
 
-       if (SCpnt) {
-               SBP2_DEBUG("Completing SCSI command");
-               sbp2scsi_complete_command(scsi_id, scsi_status, SCpnt,
-                                         command->Current_done);
-               SBP2_ORB_DEBUG("command orb completed");
-       }
-
+       if (SCpnt)
+               sbp2scsi_complete_command(lu, scsi_status, SCpnt,
+                                         cmd->Current_done);
        return RCODE_COMPLETE;
 }
 
@@ -2294,77 +1854,47 @@ static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid,
  * SCSI interface related section
  **************************************/
 
-/*
- * This routine is the main request entry routine for doing I/O. It is
- * called from the scsi stack directly.
- */
 static int sbp2scsi_queuecommand(struct scsi_cmnd *SCpnt,
                                 void (*done)(struct scsi_cmnd *))
 {
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0];
-       struct sbp2scsi_host_info *hi;
+       struct sbp2_lu *lu = (struct sbp2_lu *)SCpnt->device->host->hostdata[0];
+       struct sbp2_fwhost_info *hi;
        int result = DID_NO_CONNECT << 16;
 
-       SBP2_DEBUG_ENTER();
-#if (CONFIG_IEEE1394_SBP2_DEBUG >= 2) || defined(CONFIG_IEEE1394_SBP2_PACKET_DUMP)
-       scsi_print_command(SCpnt);
-#endif
-
-       if (!sbp2util_node_is_available(scsi_id))
+       if (unlikely(!sbp2util_node_is_available(lu)))
                goto done;
 
-       hi = scsi_id->hi;
+       hi = lu->hi;
 
-       if (!hi) {
-               SBP2_ERR("sbp2scsi_host_info is NULL - this is bad!");
+       if (unlikely(!hi)) {
+               SBP2_ERR("sbp2_fwhost_info is NULL - this is bad!");
                goto done;
        }
 
-       /*
-        * Until we handle multiple luns, just return selection time-out
-        * to any IO directed at non-zero LUNs
-        */
-       if (SCpnt->device->lun)
+       /* Multiple units are currently represented to the SCSI core as separate
+        * targets, not as one target with multiple LUs. Therefore return
+        * selection time-out to any IO directed at non-zero LUNs. */
+       if (unlikely(SCpnt->device->lun))
                goto done;
 
-       /*
-        * Check for request sense command, and handle it here
-        * (autorequest sense)
-        */
-       if (SCpnt->cmnd[0] == REQUEST_SENSE) {
-               SBP2_DEBUG("REQUEST_SENSE");
-               memcpy(SCpnt->request_buffer, SCpnt->sense_buffer, SCpnt->request_bufflen);
-               memset(SCpnt->sense_buffer, 0, sizeof(SCpnt->sense_buffer));
-               sbp2scsi_complete_command(scsi_id, SBP2_SCSI_STATUS_GOOD, SCpnt, done);
-               return 0;
-       }
-
-       /*
-        * Check to see if we are in the middle of a bus reset.
-        */
-       if (!hpsb_node_entry_valid(scsi_id->ne)) {
+       if (unlikely(!hpsb_node_entry_valid(lu->ne))) {
                SBP2_ERR("Bus reset in progress - rejecting command");
                result = DID_BUS_BUSY << 16;
                goto done;
        }
 
-       /*
-        * Bidirectional commands are not yet implemented,
-        * and unknown transfer direction not handled.
-        */
-       if (SCpnt->sc_data_direction == DMA_BIDIRECTIONAL) {
+       /* Bidirectional commands are not yet implemented,
+        * and unknown transfer direction not handled. */
+       if (unlikely(SCpnt->sc_data_direction == DMA_BIDIRECTIONAL)) {
                SBP2_ERR("Cannot handle DMA_BIDIRECTIONAL - rejecting command");
                result = DID_ERROR << 16;
                goto done;
        }
 
-       /*
-        * Try and send our SCSI command
-        */
-       if (sbp2_send_command(scsi_id, SCpnt, done)) {
+       if (sbp2_send_command(lu, SCpnt, done)) {
                SBP2_ERR("Error sending SCSI command");
-               sbp2scsi_complete_command(scsi_id, SBP2_SCSI_STATUS_SELECTION_TIMEOUT,
+               sbp2scsi_complete_command(lu,
+                                         SBP2_SCSI_STATUS_SELECTION_TIMEOUT,
                                          SCpnt, done);
        }
        return 0;
@@ -2375,75 +1905,39 @@ done:
        return 0;
 }
 
-/*
- * This function is called in order to complete all outstanding SBP-2
- * commands (in case of resets, etc.).
- */
-static void sbp2scsi_complete_all_commands(struct scsi_id_instance_data *scsi_id,
-                                          u32 status)
+static void sbp2scsi_complete_all_commands(struct sbp2_lu *lu, u32 status)
 {
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
        struct list_head *lh;
-       struct sbp2_command_info *command;
+       struct sbp2_command_info *cmd;
        unsigned long flags;
 
-       SBP2_DEBUG_ENTER();
-
-       spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-       while (!list_empty(&scsi_id->sbp2_command_orb_inuse)) {
-               SBP2_DEBUG("Found pending command to complete");
-               lh = scsi_id->sbp2_command_orb_inuse.next;
-               command = list_entry(lh, struct sbp2_command_info, list);
-               pci_dma_sync_single_for_cpu(hi->host->pdev, command->command_orb_dma,
-                                           sizeof(struct sbp2_command_orb),
-                                           PCI_DMA_TODEVICE);
-               pci_dma_sync_single_for_cpu(hi->host->pdev, command->sge_dma,
-                                           sizeof(command->scatter_gather_element),
-                                           PCI_DMA_BIDIRECTIONAL);
-               sbp2util_mark_command_completed(scsi_id, command);
-               if (command->Current_SCpnt) {
-                       command->Current_SCpnt->result = status << 16;
-                       command->Current_done(command->Current_SCpnt);
+       spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+       while (!list_empty(&lu->cmd_orb_inuse)) {
+               lh = lu->cmd_orb_inuse.next;
+               cmd = list_entry(lh, struct sbp2_command_info, list);
+               sbp2util_mark_command_completed(lu, cmd);
+               if (cmd->Current_SCpnt) {
+                       cmd->Current_SCpnt->result = status << 16;
+                       cmd->Current_done(cmd->Current_SCpnt);
                }
        }
-       spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+       spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
        return;
 }
 
 /*
- * This function is called in order to complete a regular SBP-2 command.
- *
- * This can be called in interrupt context.
+ * Complete a regular SCSI command. Can be called in atomic context.
  */
-static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id,
-                                     u32 scsi_status, struct scsi_cmnd *SCpnt,
+static void sbp2scsi_complete_command(struct sbp2_lu *lu, u32 scsi_status,
+                                     struct scsi_cmnd *SCpnt,
                                      void (*done)(struct scsi_cmnd *))
 {
-       SBP2_DEBUG_ENTER();
-
-       /*
-        * Sanity
-        */
        if (!SCpnt) {
                SBP2_ERR("SCpnt is NULL");
                return;
        }
 
-       /*
-        * If a bus reset is in progress and there was an error, don't
-        * complete the command, just let it get retried at the end of the
-        * bus reset.
-        */
-       if (!hpsb_node_entry_valid(scsi_id->ne)
-           && (scsi_status != SBP2_SCSI_STATUS_GOOD)) {
-               SBP2_ERR("Bus reset in progress - retry command later");
-               return;
-       }
-
-       /*
-        * Switch on scsi status
-        */
        switch (scsi_status) {
        case SBP2_SCSI_STATUS_GOOD:
                SCpnt->result = DID_OK << 16;
@@ -2455,12 +1949,7 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id,
                break;
 
        case SBP2_SCSI_STATUS_CHECK_CONDITION:
-               SBP2_DEBUG("SBP2_SCSI_STATUS_CHECK_CONDITION");
                SCpnt->result = CHECK_CONDITION << 1 | DID_OK << 16;
-#if CONFIG_IEEE1394_SBP2_DEBUG >= 1
-               scsi_print_command(SCpnt);
-               scsi_print_sense(SBP2_DEVICE_NAME, SCpnt);
-#endif
                break;
 
        case SBP2_SCSI_STATUS_SELECTION_TIMEOUT:
@@ -2482,112 +1971,95 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id,
                SCpnt->result = DID_ERROR << 16;
        }
 
-       /*
-        * If a bus reset is in progress and there was an error, complete
-        * the command as busy so that it will get retried.
-        */
-       if (!hpsb_node_entry_valid(scsi_id->ne)
+       /* If a bus reset is in progress and there was an error, complete
+        * the command as busy so that it will get retried. */
+       if (!hpsb_node_entry_valid(lu->ne)
            && (scsi_status != SBP2_SCSI_STATUS_GOOD)) {
                SBP2_ERR("Completing command with busy (bus reset)");
                SCpnt->result = DID_BUS_BUSY << 16;
        }
 
-       /*
-        * If a unit attention occurs, return busy status so it gets
-        * retried... it could have happened because of a 1394 bus reset
-        * or hot-plug...
-        * XXX  DID_BUS_BUSY is actually a bad idea because it will defy
-        * the scsi layer's retry logic.
-        */
-#if 0
-       if ((scsi_status == SBP2_SCSI_STATUS_CHECK_CONDITION) &&
-           (SCpnt->sense_buffer[2] == UNIT_ATTENTION)) {
-               SBP2_DEBUG("UNIT ATTENTION - return busy");
-               SCpnt->result = DID_BUS_BUSY << 16;
-       }
-#endif
-
-       /*
-        * Tell scsi stack that we're done with this command
-        */
+       /* Tell the SCSI stack that we're done with this command. */
        done(SCpnt);
 }
 
 static int sbp2scsi_slave_alloc(struct scsi_device *sdev)
 {
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)sdev->host->hostdata[0];
+       struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0];
+
+       if (sdev->lun != 0 || sdev->id != lu->ud->id || sdev->channel != 0)
+               return -ENODEV;
 
-       scsi_id->sdev = sdev;
+       lu->sdev = sdev;
        sdev->allow_restart = 1;
 
-       if (scsi_id->workarounds & SBP2_WORKAROUND_INQUIRY_36)
+       /* SBP-2 requires quadlet alignment of the data buffers. */
+       blk_queue_update_dma_alignment(sdev->request_queue, 4 - 1);
+
+       if (lu->workarounds & SBP2_WORKAROUND_INQUIRY_36)
                sdev->inquiry_len = 36;
        return 0;
 }
 
 static int sbp2scsi_slave_configure(struct scsi_device *sdev)
 {
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)sdev->host->hostdata[0];
+       struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0];
 
-       blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
        sdev->use_10_for_rw = 1;
 
+       if (sbp2_exclusive_login)
+               sdev->manage_start_stop = 1;
+       if (sdev->type == TYPE_ROM)
+               sdev->use_10_for_ms = 1;
        if (sdev->type == TYPE_DISK &&
-           scsi_id->workarounds & SBP2_WORKAROUND_MODE_SENSE_8)
+           lu->workarounds & SBP2_WORKAROUND_MODE_SENSE_8)
                sdev->skip_ms_page_8 = 1;
-       if (scsi_id->workarounds & SBP2_WORKAROUND_FIX_CAPACITY)
+       if (lu->workarounds & SBP2_WORKAROUND_FIX_CAPACITY)
                sdev->fix_capacity = 1;
+       if (lu->workarounds & SBP2_WORKAROUND_POWER_CONDITION)
+               sdev->start_stop_pwr_cond = 1;
+       if (lu->workarounds & SBP2_WORKAROUND_128K_MAX_TRANS)
+               blk_queue_max_hw_sectors(sdev->request_queue, 128 * 1024 / 512);
+
+       blk_queue_max_segment_size(sdev->request_queue, SBP2_MAX_SEG_SIZE);
        return 0;
 }
 
 static void sbp2scsi_slave_destroy(struct scsi_device *sdev)
 {
-       ((struct scsi_id_instance_data *)sdev->host->hostdata[0])->sdev = NULL;
+       ((struct sbp2_lu *)sdev->host->hostdata[0])->sdev = NULL;
        return;
 }
 
 /*
- * Called by scsi stack when something has really gone wrong.  Usually
- * called when a command has timed-out for some reason.
+ * Called by scsi stack when something has really gone wrong.
+ * Usually called when a command has timed-out for some reason.
  */
 static int sbp2scsi_abort(struct scsi_cmnd *SCpnt)
 {
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0];
-       struct sbp2scsi_host_info *hi = scsi_id->hi;
-       struct sbp2_command_info *command;
+       struct sbp2_lu *lu = (struct sbp2_lu *)SCpnt->device->host->hostdata[0];
+       struct sbp2_command_info *cmd;
        unsigned long flags;
 
-       SBP2_ERR("aborting sbp2 command");
+       SBP2_INFO("aborting sbp2 command");
        scsi_print_command(SCpnt);
 
-       if (sbp2util_node_is_available(scsi_id)) {
-               sbp2_agent_reset(scsi_id, 1);
+       if (sbp2util_node_is_available(lu)) {
+               sbp2_agent_reset(lu, 1);
 
                /* Return a matching command structure to the free pool. */
-               spin_lock_irqsave(&scsi_id->sbp2_command_orb_lock, flags);
-               command = sbp2util_find_command_for_SCpnt(scsi_id, SCpnt);
-               if (command) {
-                       SBP2_DEBUG("Found command to abort");
-                       pci_dma_sync_single_for_cpu(hi->host->pdev,
-                                                   command->command_orb_dma,
-                                                   sizeof(struct sbp2_command_orb),
-                                                   PCI_DMA_TODEVICE);
-                       pci_dma_sync_single_for_cpu(hi->host->pdev,
-                                                   command->sge_dma,
-                                                   sizeof(command->scatter_gather_element),
-                                                   PCI_DMA_BIDIRECTIONAL);
-                       sbp2util_mark_command_completed(scsi_id, command);
-                       if (command->Current_SCpnt) {
-                               command->Current_SCpnt->result = DID_ABORT << 16;
-                               command->Current_done(command->Current_SCpnt);
+               spin_lock_irqsave(&lu->cmd_orb_lock, flags);
+               cmd = sbp2util_find_command_for_SCpnt(lu, SCpnt);
+               if (cmd) {
+                       sbp2util_mark_command_completed(lu, cmd);
+                       if (cmd->Current_SCpnt) {
+                               cmd->Current_SCpnt->result = DID_ABORT << 16;
+                               cmd->Current_done(cmd->Current_SCpnt);
                        }
                }
-               spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);
+               spin_unlock_irqrestore(&lu->cmd_orb_lock, flags);
 
-               sbp2scsi_complete_all_commands(scsi_id, DID_BUS_BUSY);
+               sbp2scsi_complete_all_commands(lu, DID_BUS_BUSY);
        }
 
        return SUCCESS;
@@ -2598,14 +2070,13 @@ static int sbp2scsi_abort(struct scsi_cmnd *SCpnt)
  */
 static int sbp2scsi_reset(struct scsi_cmnd *SCpnt)
 {
-       struct scsi_id_instance_data *scsi_id =
-               (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0];
+       struct sbp2_lu *lu = (struct sbp2_lu *)SCpnt->device->host->hostdata[0];
 
-       SBP2_ERR("reset requested");
+       SBP2_INFO("reset requested");
 
-       if (sbp2util_node_is_available(scsi_id)) {
-               SBP2_ERR("Generating sbp2 fetch agent reset");
-               sbp2_agent_reset(scsi_id, 1);
+       if (sbp2util_node_is_available(lu)) {
+               SBP2_INFO("generating sbp2 fetch agent reset");
+               sbp2_agent_reset(lu, 1);
        }
 
        return SUCCESS;
@@ -2616,88 +2087,53 @@ static ssize_t sbp2_sysfs_ieee1394_id_show(struct device *dev,
                                           char *buf)
 {
        struct scsi_device *sdev;
-       struct scsi_id_instance_data *scsi_id;
-       int lun;
+       struct sbp2_lu *lu;
 
        if (!(sdev = to_scsi_device(dev)))
                return 0;
 
-       if (!(scsi_id = (struct scsi_id_instance_data *)sdev->host->hostdata[0]))
+       if (!(lu = (struct sbp2_lu *)sdev->host->hostdata[0]))
                return 0;
 
-       lun = ORB_SET_LUN(scsi_id->sbp2_lun);
-
-       return sprintf(buf, "%016Lx:%d:%d\n", (unsigned long long)scsi_id->ne->guid,
-                      scsi_id->ud->id, lun);
+       if (sbp2_long_sysfs_ieee1394_id)
+               return sprintf(buf, "%016Lx:%06x:%04x\n",
+                               (unsigned long long)lu->ne->guid,
+                               lu->ud->directory_id, ORB_SET_LUN(lu->lun));
+       else
+               return sprintf(buf, "%016Lx:%d:%d\n",
+                               (unsigned long long)lu->ne->guid,
+                               lu->ud->id, ORB_SET_LUN(lu->lun));
 }
-static DEVICE_ATTR(ieee1394_id, S_IRUGO, sbp2_sysfs_ieee1394_id_show, NULL);
-
-static struct device_attribute *sbp2_sysfs_sdev_attrs[] = {
-       &dev_attr_ieee1394_id,
-       NULL
-};
 
 MODULE_AUTHOR("Ben Collins <bcollins@debian.org>");
 MODULE_DESCRIPTION("IEEE-1394 SBP-2 protocol driver");
 MODULE_SUPPORTED_DEVICE(SBP2_DEVICE_NAME);
 MODULE_LICENSE("GPL");
 
-/* SCSI host template */
-static struct scsi_host_template scsi_driver_template = {
-       .module =                       THIS_MODULE,
-       .name =                         "SBP-2 IEEE-1394",
-       .proc_name =                    SBP2_DEVICE_NAME,
-       .queuecommand =                 sbp2scsi_queuecommand,
-       .eh_abort_handler =             sbp2scsi_abort,
-       .eh_device_reset_handler =      sbp2scsi_reset,
-       .slave_alloc =                  sbp2scsi_slave_alloc,
-       .slave_configure =              sbp2scsi_slave_configure,
-       .slave_destroy =                sbp2scsi_slave_destroy,
-       .this_id =                      -1,
-       .sg_tablesize =                 SG_ALL,
-       .use_clustering =               ENABLE_CLUSTERING,
-       .cmd_per_lun =                  SBP2_MAX_CMDS,
-       .can_queue =                    SBP2_MAX_CMDS,
-       .emulated =                     1,
-       .sdev_attrs =                   sbp2_sysfs_sdev_attrs,
-};
-
 static int sbp2_module_init(void)
 {
        int ret;
 
-       SBP2_DEBUG_ENTER();
-
-       /* Module load debug option to force one command at a time (serializing I/O) */
-       if (serialize_io) {
-               scsi_driver_template.can_queue = 1;
-               scsi_driver_template.cmd_per_lun = 1;
+       if (sbp2_serialize_io) {
+               sbp2_shost_template.can_queue = 1;
+               sbp2_shost_template.cmd_per_lun = 1;
        }
 
-       if (sbp2_default_workarounds & SBP2_WORKAROUND_128K_MAX_TRANS &&
-           (max_sectors * 512) > (128 * 1024))
-               max_sectors = 128 * 1024 / 512;
-       scsi_driver_template.max_sectors = max_sectors;
+       sbp2_shost_template.max_sectors = sbp2_max_sectors;
 
-       /* Register our high level driver with 1394 stack */
        hpsb_register_highlevel(&sbp2_highlevel);
-
        ret = hpsb_register_protocol(&sbp2_driver);
        if (ret) {
                SBP2_ERR("Failed to register protocol");
                hpsb_unregister_highlevel(&sbp2_highlevel);
                return ret;
        }
-
        return 0;
 }
 
 static void __exit sbp2_module_exit(void)
 {
-       SBP2_DEBUG_ENTER();
-
        hpsb_unregister_protocol(&sbp2_driver);
-
        hpsb_unregister_highlevel(&sbp2_highlevel);
 }