include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit...
[safe/jmp/linux-2.6] / drivers / ide / ide-proc.c
index aa663e7..a3133d7 100644 (file)
@@ -1,8 +1,6 @@
 /*
- *  linux/drivers/ide/ide-proc.c       Version 1.05    Mar 05, 2003
- *
  *  Copyright (C) 1997-1998    Mark Lord
- *  Copyright (C) 2003         Red Hat <alan@redhat.com>
+ *  Copyright (C) 2003         Red Hat
  *
  *  Some code was moved here from ide.c, see it for original copyrights.
  */
  * "settings" files.  e.g.    "cat /proc/ide0/hda/settings"
  * To write a new value "val" into a specific setting "name", use:
  *   echo "name:val" >/proc/ide/ide0/hda/settings
- *
- * Also useful, "cat /proc/ide0/hda/[identify, smart_values,
- * smart_thresholds, capabilities]" will issue an IDENTIFY /
- * PACKET_IDENTIFY / SMART_READ_VALUES / SMART_READ_THRESHOLDS /
- * SENSE CAPABILITIES command to /dev/hda, and then dump out the
- * returned data as 256 16-bit words.  The "hdparm" utility will
- * be updated someday soon to use this mechanism.
- *
  */
 
 #include <linux/module.h>
 #include <linux/mm.h>
 #include <linux/pci.h>
 #include <linux/ctype.h>
-#include <linux/hdreg.h>
 #include <linux/ide.h>
 #include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <asm/io.h>
 
 static struct proc_dir_entry *proc_ide_root;
 
-static int proc_ide_read_imodel
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_imodel_proc_show(struct seq_file *m, void *v)
 {
-       ide_hwif_t      *hwif = (ide_hwif_t *) data;
-       int             len;
+       ide_hwif_t      *hwif = (ide_hwif_t *) m->private;
        const char      *name;
 
-       /*
-        * Neither ide_unknown nor ide_forced should be set at this point.
-        */
        switch (hwif->chipset) {
-               case ide_generic:       name = "generic";       break;
-               case ide_pci:           name = "pci";           break;
-               case ide_cmd640:        name = "cmd640";        break;
-               case ide_dtc2278:       name = "dtc2278";       break;
-               case ide_ali14xx:       name = "ali14xx";       break;
-               case ide_qd65xx:        name = "qd65xx";        break;
-               case ide_umc8672:       name = "umc8672";       break;
-               case ide_ht6560b:       name = "ht6560b";       break;
-               case ide_rz1000:        name = "rz1000";        break;
-               case ide_trm290:        name = "trm290";        break;
-               case ide_cmd646:        name = "cmd646";        break;
-               case ide_cy82c693:      name = "cy82c693";      break;
-               case ide_4drives:       name = "4drives";       break;
-               case ide_pmac:          name = "mac-io";        break;
-               case ide_au1xxx:        name = "au1xxx";        break;
-               case ide_etrax100:      name = "etrax100";      break;
-               case ide_acorn:         name = "acorn";         break;
-               default:                name = "(unknown)";     break;
+       case ide_generic:       name = "generic";       break;
+       case ide_pci:           name = "pci";           break;
+       case ide_cmd640:        name = "cmd640";        break;
+       case ide_dtc2278:       name = "dtc2278";       break;
+       case ide_ali14xx:       name = "ali14xx";       break;
+       case ide_qd65xx:        name = "qd65xx";        break;
+       case ide_umc8672:       name = "umc8672";       break;
+       case ide_ht6560b:       name = "ht6560b";       break;
+       case ide_4drives:       name = "4drives";       break;
+       case ide_pmac:          name = "mac-io";        break;
+       case ide_au1xxx:        name = "au1xxx";        break;
+       case ide_palm3710:      name = "palm3710";      break;
+       case ide_acorn:         name = "acorn";         break;
+       default:                name = "(unknown)";     break;
        }
-       len = sprintf(page, "%s\n", name);
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       seq_printf(m, "%s\n", name);
+       return 0;
 }
 
-static int proc_ide_read_mate
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_imodel_proc_open(struct inode *inode, struct file *file)
 {
-       ide_hwif_t      *hwif = (ide_hwif_t *) data;
-       int             len;
-
-       if (hwif && hwif->mate && hwif->mate->present)
-               len = sprintf(page, "%s\n", hwif->mate->name);
-       else
-               len = sprintf(page, "(none)\n");
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       return single_open(file, ide_imodel_proc_show, PDE(inode)->data);
 }
 
-static int proc_ide_read_channel
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static const struct file_operations ide_imodel_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_imodel_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+
+static int ide_mate_proc_show(struct seq_file *m, void *v)
 {
-       ide_hwif_t      *hwif = (ide_hwif_t *) data;
-       int             len;
+       ide_hwif_t      *hwif = (ide_hwif_t *) m->private;
 
-       page[0] = hwif->channel ? '1' : '0';
-       page[1] = '\n';
-       len = 2;
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       if (hwif && hwif->mate)
+               seq_printf(m, "%s\n", hwif->mate->name);
+       else
+               seq_printf(m, "(none)\n");
+       return 0;
 }
 
-static int proc_ide_read_identify
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_mate_proc_open(struct inode *inode, struct file *file)
 {
-       ide_drive_t     *drive = (ide_drive_t *)data;
-       int             len = 0, i = 0;
-       int             err = 0;
-
-       len = sprintf(page, "\n");
-
-       if (drive) {
-               unsigned short *val = (unsigned short *) page;
-
-               err = taskfile_lib_get_identify(drive, page);
-               if (!err) {
-                       char *out = ((char *)page) + (SECTOR_WORDS * 4);
-                       page = out;
-                       do {
-                               out += sprintf(out, "%04x%c",
-                                       le16_to_cpu(*val), (++i & 7) ? ' ' : '\n');
-                               val += 1;
-                       } while (i < (SECTOR_WORDS * 2));
-                       len = out - page;
-               }
-       }
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       return single_open(file, ide_mate_proc_show, PDE(inode)->data);
 }
 
-/**
- *     __ide_add_setting       -       add an ide setting option
- *     @drive: drive to use
- *     @name: setting name
- *     @rw: true if the function is read write
- *     @data_type: type of data
- *     @min: range minimum
- *     @max: range maximum
- *     @mul_factor: multiplication scale
- *     @div_factor: divison scale
- *     @data: private data field
- *     @set: setting
- *     @auto_remove: setting auto removal flag
- *
- *     Removes the setting named from the device if it is present.
- *     The function takes the settings_lock to protect against
- *     parallel changes. This function must not be called from IRQ
- *     context. Returns 0 on success or -1 on failure.
- *
- *     BUGS: This code is seriously over-engineered. There is also
- *     magic about how the driver specific features are setup. If
- *     a driver is attached we assume the driver settings are auto
- *     remove.
- */
+static const struct file_operations ide_mate_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_mate_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
 
-static int __ide_add_setting(ide_drive_t *drive, const char *name, int rw, int data_type, int min, int max, int mul_factor, int div_factor, void *data, ide_procset_t *set, int auto_remove)
+static int ide_channel_proc_show(struct seq_file *m, void *v)
 {
-       ide_settings_t **p = (ide_settings_t **) &drive->settings, *setting = NULL;
+       ide_hwif_t      *hwif = (ide_hwif_t *) m->private;
 
-       mutex_lock(&ide_setting_mtx);
-       while ((*p) && strcmp((*p)->name, name) < 0)
-               p = &((*p)->next);
-       if ((setting = kzalloc(sizeof(*setting), GFP_KERNEL)) == NULL)
-               goto abort;
-       if ((setting->name = kmalloc(strlen(name) + 1, GFP_KERNEL)) == NULL)
-               goto abort;
-       strcpy(setting->name, name);
-       setting->rw = rw;
-       setting->data_type = data_type;
-       setting->min = min;
-       setting->max = max;
-       setting->mul_factor = mul_factor;
-       setting->div_factor = div_factor;
-       setting->data = data;
-       setting->set = set;
-
-       setting->next = *p;
-       if (auto_remove)
-               setting->auto_remove = 1;
-       *p = setting;
-       mutex_unlock(&ide_setting_mtx);
+       seq_printf(m, "%c\n", hwif->channel ? '1' : '0');
        return 0;
-abort:
-       mutex_unlock(&ide_setting_mtx);
-       kfree(setting);
-       return -1;
 }
 
-int ide_add_setting(ide_drive_t *drive, const char *name, int rw, int data_type, int min, int max, int mul_factor, int div_factor, void *data, ide_procset_t *set)
+static int ide_channel_proc_open(struct inode *inode, struct file *file)
 {
-       return __ide_add_setting(drive, name, rw, data_type, min, max, mul_factor, div_factor, data, set, 1);
+       return single_open(file, ide_channel_proc_show, PDE(inode)->data);
 }
 
-EXPORT_SYMBOL(ide_add_setting);
-
-/**
- *     __ide_remove_setting    -       remove an ide setting option
- *     @drive: drive to use
- *     @name: setting name
- *
- *     Removes the setting named from the device if it is present.
- *     The caller must hold the setting semaphore.
- */
+static const struct file_operations ide_channel_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_channel_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
 
-static void __ide_remove_setting (ide_drive_t *drive, char *name)
+static int ide_identify_proc_show(struct seq_file *m, void *v)
 {
-       ide_settings_t **p, *setting;
-
-       p = (ide_settings_t **) &drive->settings;
+       ide_drive_t *drive = (ide_drive_t *)m->private;
+       u8 *buf;
 
-       while ((*p) && strcmp((*p)->name, name))
-               p = &((*p)->next);
-       if ((setting = (*p)) == NULL)
-               return;
+       if (!drive) {
+               seq_putc(m, '\n');
+               return 0;
+       }
 
-       (*p) = setting->next;
+       buf = kmalloc(SECTOR_SIZE, GFP_KERNEL);
+       if (!buf)
+               return -ENOMEM;
+       if (taskfile_lib_get_identify(drive, buf) == 0) {
+               __le16 *val = (__le16 *)buf;
+               int i;
 
-       kfree(setting->name);
-       kfree(setting);
+               for (i = 0; i < SECTOR_SIZE / 2; i++) {
+                       seq_printf(m, "%04x%c", le16_to_cpu(val[i]),
+                                       (i % 8) == 7 ? '\n' : ' ');
+               }
+       } else
+               seq_putc(m, buf[0]);
+       kfree(buf);
+       return 0;
 }
 
-/**
- *     auto_remove_settings    -       remove driver specific settings
- *     @drive: drive
- *
- *     Automatically remove all the driver specific settings for this
- *     drive. This function may not be called from IRQ context. The
- *     caller must hold ide_setting_mtx.
- */
-
-static void auto_remove_settings (ide_drive_t *drive)
+static int ide_identify_proc_open(struct inode *inode, struct file *file)
 {
-       ide_settings_t *setting;
-repeat:
-       setting = drive->settings;
-       while (setting) {
-               if (setting->auto_remove) {
-                       __ide_remove_setting(drive, setting->name);
-                       goto repeat;
-               }
-               setting = setting->next;
-       }
+       return single_open(file, ide_identify_proc_show, PDE(inode)->data);
 }
 
+static const struct file_operations ide_identify_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_identify_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+
 /**
- *     ide_find_setting_by_name        -       find a drive specific setting
- *     @drive: drive to scan
+ *     ide_find_setting        -       find a specific setting
+ *     @st: setting table pointer
  *     @name: setting name
  *
- *     Scan's the device setting table for a matching entry and returns
+ *     Scan's the setting table for a matching entry and returns
  *     this or NULL if no entry is found. The caller must hold the
  *     setting semaphore
  */
 
-static ide_settings_t *ide_find_setting_by_name(ide_drive_t *drive, char *name)
+static
+const struct ide_proc_devset *ide_find_setting(const struct ide_proc_devset *st,
+                                              char *name)
 {
-       ide_settings_t *setting = drive->settings;
-
-       while (setting) {
-               if (strcmp(setting->name, name) == 0)
+       while (st->name) {
+               if (strcmp(st->name, name) == 0)
                        break;
-               setting = setting->next;
+               st++;
        }
-       return setting;
+       return st->name ? st : NULL;
 }
 
 /**
@@ -276,26 +189,15 @@ static ide_settings_t *ide_find_setting_by_name(ide_drive_t *drive, char *name)
  *     be told apart
  */
 
-static int ide_read_setting(ide_drive_t *drive, ide_settings_t *setting)
-{
-       int             val = -EINVAL;
-       unsigned long   flags;
-
-       if ((setting->rw & SETTING_READ)) {
-               spin_lock_irqsave(&ide_lock, flags);
-               switch(setting->data_type) {
-                       case TYPE_BYTE:
-                               val = *((u8 *) setting->data);
-                               break;
-                       case TYPE_SHORT:
-                               val = *((u16 *) setting->data);
-                               break;
-                       case TYPE_INT:
-                               val = *((u32 *) setting->data);
-                               break;
-               }
-               spin_unlock_irqrestore(&ide_lock, flags);
-       }
+static int ide_read_setting(ide_drive_t *drive,
+                           const struct ide_proc_devset *setting)
+{
+       const struct ide_devset *ds = setting->setting;
+       int val = -EINVAL;
+
+       if (ds->get)
+               val = ds->get(drive);
+
        return val;
 }
 
@@ -317,137 +219,126 @@ static int ide_read_setting(ide_drive_t *drive, ide_settings_t *setting)
  *     The current scheme of polling is kludgy, though safe enough.
  */
 
-static int ide_write_setting(ide_drive_t *drive, ide_settings_t *setting, int val)
+static int ide_write_setting(ide_drive_t *drive,
+                            const struct ide_proc_devset *setting, int val)
 {
+       const struct ide_devset *ds = setting->setting;
+
        if (!capable(CAP_SYS_ADMIN))
                return -EACCES;
-       if (setting->set)
-               return setting->set(drive, val);
-       if (!(setting->rw & SETTING_WRITE))
+       if (!ds->set)
                return -EPERM;
-       if (val < setting->min || val > setting->max)
+       if ((ds->flags & DS_SYNC)
+           && (val < setting->min || val > setting->max))
                return -EINVAL;
-       if (ide_spin_wait_hwgroup(drive))
-               return -EBUSY;
-       switch (setting->data_type) {
-               case TYPE_BYTE:
-                       *((u8 *) setting->data) = val;
-                       break;
-               case TYPE_SHORT:
-                       *((u16 *) setting->data) = val;
-                       break;
-               case TYPE_INT:
-                       *((u32 *) setting->data) = val;
-                       break;
-       }
-       spin_unlock_irq(&ide_lock);
-       return 0;
+       return ide_devset_execute(drive, ds, val);
 }
 
+ide_devset_get(xfer_rate, current_speed);
+
 static int set_xfer_rate (ide_drive_t *drive, int arg)
 {
-       ide_task_t task;
-       int err;
+       struct ide_cmd cmd;
 
-       if (arg < 0 || arg > 70)
+       if (arg < XFER_PIO_0 || arg > XFER_UDMA_6)
                return -EINVAL;
 
-       memset(&task, 0, sizeof(task));
-       task.tf.command = WIN_SETFEATURES;
-       task.tf.feature = SETFEATURES_XFER;
-       task.tf.nsect   = (u8)arg;
-       task.tf_flags = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT |
-                       IDE_TFLAG_IN_NSECT;
-
-       err = ide_no_data_taskfile(drive, &task);
-
-       if (!err && arg) {
-               ide_set_xfer_rate(drive, (u8) arg);
-               ide_driveid_update(drive);
-       }
-       return err;
-}
-
-/**
- *     ide_add_generic_settings        -       generic ide settings
- *     @drive: drive being configured
- *
- *     Add the generic parts of the system settings to the /proc files.
- *     The caller must not be holding the ide_setting_mtx.
- */
-
-void ide_add_generic_settings (ide_drive_t *drive)
-{
-/*
- *                       drive         setting name            read/write access                               data type       min     max                             mul_factor      div_factor      data pointer                    set function
- */
-       __ide_add_setting(drive,        "io_32bit",             drive->no_io_32bit ? SETTING_READ : SETTING_RW, TYPE_BYTE,      0,      1 + (SUPPORT_VLB_SYNC << 1),    1,              1,              &drive->io_32bit,               set_io_32bit,   0);
-       __ide_add_setting(drive,        "keepsettings",         SETTING_RW,                                     TYPE_BYTE,      0,      1,                              1,              1,              &drive->keep_settings,          NULL,           0);
-       __ide_add_setting(drive,        "nice1",                SETTING_RW,                                     TYPE_BYTE,      0,      1,                              1,              1,              &drive->nice1,                  NULL,           0);
-       __ide_add_setting(drive,        "pio_mode",             SETTING_WRITE,                                  TYPE_BYTE,      0,      255,                            1,              1,              NULL,                           set_pio_mode,   0);
-       __ide_add_setting(drive,        "unmaskirq",            drive->no_unmask ? SETTING_READ : SETTING_RW,   TYPE_BYTE,      0,      1,                              1,              1,              &drive->unmask,                 NULL,           0);
-       __ide_add_setting(drive,        "using_dma",            SETTING_RW,                                     TYPE_BYTE,      0,      1,                              1,              1,              &drive->using_dma,              set_using_dma,  0);
-       __ide_add_setting(drive,        "init_speed",           SETTING_RW,                                     TYPE_BYTE,      0,      70,                             1,              1,              &drive->init_speed,             NULL,           0);
-       __ide_add_setting(drive,        "current_speed",        SETTING_RW,                                     TYPE_BYTE,      0,      70,                             1,              1,              &drive->current_speed,          set_xfer_rate,  0);
-       __ide_add_setting(drive,        "number",               SETTING_RW,                                     TYPE_BYTE,      0,      3,                              1,              1,              &drive->dn,                     NULL,           0);
-}
+       memset(&cmd, 0, sizeof(cmd));
+       cmd.tf.command = ATA_CMD_SET_FEATURES;
+       cmd.tf.feature = SETFEATURES_XFER;
+       cmd.tf.nsect   = (u8)arg;
+       cmd.valid.out.tf = IDE_VALID_FEATURE | IDE_VALID_NSECT;
+       cmd.valid.in.tf  = IDE_VALID_NSECT;
+       cmd.tf_flags   = IDE_TFLAG_SET_XFER;
+
+       return ide_no_data_taskfile(drive, &cmd);
+}
+
+ide_devset_rw(current_speed, xfer_rate);
+ide_devset_rw_field(init_speed, init_speed);
+ide_devset_rw_flag(nice1, IDE_DFLAG_NICE1);
+ide_devset_rw_field(number, dn);
+
+static const struct ide_proc_devset ide_generic_settings[] = {
+       IDE_PROC_DEVSET(current_speed, 0, 70),
+       IDE_PROC_DEVSET(init_speed, 0, 70),
+       IDE_PROC_DEVSET(io_32bit,  0, 1 + (SUPPORT_VLB_SYNC << 1)),
+       IDE_PROC_DEVSET(keepsettings, 0, 1),
+       IDE_PROC_DEVSET(nice1, 0, 1),
+       IDE_PROC_DEVSET(number, 0, 3),
+       IDE_PROC_DEVSET(pio_mode, 0, 255),
+       IDE_PROC_DEVSET(unmaskirq, 0, 1),
+       IDE_PROC_DEVSET(using_dma, 0, 1),
+       { NULL },
+};
 
 static void proc_ide_settings_warn(void)
 {
-       static int warned = 0;
-
-       if (warned)
-               return;
-
-       printk(KERN_WARNING "Warning: /proc/ide/hd?/settings interface is "
+       printk_once(KERN_WARNING "Warning: /proc/ide/hd?/settings interface is "
                            "obsolete, and will be removed soon!\n");
-       warned = 1;
 }
 
-static int proc_ide_read_settings
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_settings_proc_show(struct seq_file *m, void *v)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
-       ide_settings_t  *setting = (ide_settings_t *) drive->settings;
-       char            *out = page;
-       int             len, rc, mul_factor, div_factor;
+       const struct ide_proc_devset *setting, *g, *d;
+       const struct ide_devset *ds;
+       ide_drive_t     *drive = (ide_drive_t *) m->private;
+       int             rc, mul_factor, div_factor;
 
        proc_ide_settings_warn();
 
        mutex_lock(&ide_setting_mtx);
-       out += sprintf(out, "name\t\t\tvalue\t\tmin\t\tmax\t\tmode\n");
-       out += sprintf(out, "----\t\t\t-----\t\t---\t\t---\t\t----\n");
-       while(setting) {
-               mul_factor = setting->mul_factor;
-               div_factor = setting->div_factor;
-               out += sprintf(out, "%-24s", setting->name);
-               if ((rc = ide_read_setting(drive, setting)) >= 0)
-                       out += sprintf(out, "%-16d", rc * mul_factor / div_factor);
+       g = ide_generic_settings;
+       d = drive->settings;
+       seq_printf(m, "name\t\t\tvalue\t\tmin\t\tmax\t\tmode\n");
+       seq_printf(m, "----\t\t\t-----\t\t---\t\t---\t\t----\n");
+       while (g->name || (d && d->name)) {
+               /* read settings in the alphabetical order */
+               if (g->name && d && d->name) {
+                       if (strcmp(d->name, g->name) < 0)
+                               setting = d++;
+                       else
+                               setting = g++;
+               } else if (d && d->name) {
+                       setting = d++;
+               } else
+                       setting = g++;
+               mul_factor = setting->mulf ? setting->mulf(drive) : 1;
+               div_factor = setting->divf ? setting->divf(drive) : 1;
+               seq_printf(m, "%-24s", setting->name);
+               rc = ide_read_setting(drive, setting);
+               if (rc >= 0)
+                       seq_printf(m, "%-16d", rc * mul_factor / div_factor);
                else
-                       out += sprintf(out, "%-16s", "write-only");
-               out += sprintf(out, "%-16d%-16d", (setting->min * mul_factor + div_factor - 1) / div_factor, setting->max * mul_factor / div_factor);
-               if (setting->rw & SETTING_READ)
-                       out += sprintf(out, "r");
-               if (setting->rw & SETTING_WRITE)
-                       out += sprintf(out, "w");
-               out += sprintf(out, "\n");
-               setting = setting->next;
+                       seq_printf(m, "%-16s", "write-only");
+               seq_printf(m, "%-16d%-16d", (setting->min * mul_factor + div_factor - 1) / div_factor, setting->max * mul_factor / div_factor);
+               ds = setting->setting;
+               if (ds->get)
+                       seq_printf(m, "r");
+               if (ds->set)
+                       seq_printf(m, "w");
+               seq_printf(m, "\n");
        }
-       len = out - page;
        mutex_unlock(&ide_setting_mtx);
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       return 0;
+}
+
+static int ide_settings_proc_open(struct inode *inode, struct file *file)
+{
+       return single_open(file, ide_settings_proc_show, PDE(inode)->data);
 }
 
 #define MAX_LEN        30
 
-static int proc_ide_write_settings(struct file *file, const char __user *buffer,
-                                  unsigned long count, void *data)
+static ssize_t ide_settings_proc_write(struct file *file, const char __user *buffer,
+                                      size_t count, loff_t *pos)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
+       ide_drive_t     *drive = (ide_drive_t *) PDE(file->f_path.dentry->d_inode)->data;
        char            name[MAX_LEN + 1];
-       int             for_real = 0;
+       int             for_real = 0, mul_factor, div_factor;
        unsigned long   n;
-       ide_settings_t  *setting;
+
+       const struct ide_proc_devset *setting;
        char *buf, *s;
 
        if (!capable(CAP_SYS_ADMIN))
@@ -515,14 +406,21 @@ static int proc_ide_write_settings(struct file *file, const char __user *buffer,
                        }
 
                        mutex_lock(&ide_setting_mtx);
-                       setting = ide_find_setting_by_name(drive, name);
-                       if (!setting)
-                       {
-                               mutex_unlock(&ide_setting_mtx);
-                               goto parse_error;
+                       /* generic settings first, then driver specific ones */
+                       setting = ide_find_setting(ide_generic_settings, name);
+                       if (!setting) {
+                               if (drive->settings)
+                                       setting = ide_find_setting(drive->settings, name);
+                               if (!setting) {
+                                       mutex_unlock(&ide_setting_mtx);
+                                       goto parse_error;
+                               }
+                       }
+                       if (for_real) {
+                               mul_factor = setting->mulf ? setting->mulf(drive) : 1;
+                               div_factor = setting->divf ? setting->divf(drive) : 1;
+                               ide_write_setting(drive, setting, val * div_factor / mul_factor);
                        }
-                       if (for_real)
-                               ide_write_setting(drive, setting, val * setting->div_factor / setting->mul_factor);
                        mutex_unlock(&ide_setting_mtx);
                }
        } while (!for_real++);
@@ -530,64 +428,104 @@ static int proc_ide_write_settings(struct file *file, const char __user *buffer,
        return count;
 parse_error:
        free_page((unsigned long)buf);
-       printk("proc_ide_write_settings(): parse error\n");
+       printk("%s(): parse error\n", __func__);
        return -EINVAL;
 }
 
-int proc_ide_read_capacity
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static const struct file_operations ide_settings_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_settings_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+       .write          = ide_settings_proc_write,
+};
+
+static int ide_capacity_proc_show(struct seq_file *m, void *v)
+{
+       seq_printf(m, "%llu\n", (long long)0x7fffffff);
+       return 0;
+}
+
+static int ide_capacity_proc_open(struct inode *inode, struct file *file)
 {
-       int len = sprintf(page,"%llu\n", (long long)0x7fffffff);
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       return single_open(file, ide_capacity_proc_show, NULL);
 }
 
-EXPORT_SYMBOL_GPL(proc_ide_read_capacity);
+const struct file_operations ide_capacity_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_capacity_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+EXPORT_SYMBOL_GPL(ide_capacity_proc_fops);
 
-int proc_ide_read_geometry
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_geometry_proc_show(struct seq_file *m, void *v)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
-       char            *out = page;
-       int             len;
+       ide_drive_t     *drive = (ide_drive_t *) m->private;
 
-       out += sprintf(out,"physical     %d/%d/%d\n",
+       seq_printf(m, "physical     %d/%d/%d\n",
                        drive->cyl, drive->head, drive->sect);
-       out += sprintf(out,"logical      %d/%d/%d\n",
+       seq_printf(m, "logical      %d/%d/%d\n",
                        drive->bios_cyl, drive->bios_head, drive->bios_sect);
+       return 0;
+}
 
-       len = out - page;
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+static int ide_geometry_proc_open(struct inode *inode, struct file *file)
+{
+       return single_open(file, ide_geometry_proc_show, PDE(inode)->data);
 }
 
-EXPORT_SYMBOL(proc_ide_read_geometry);
+const struct file_operations ide_geometry_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_geometry_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+EXPORT_SYMBOL(ide_geometry_proc_fops);
 
-static int proc_ide_read_dmodel
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static int ide_dmodel_proc_show(struct seq_file *seq, void *v)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
-       struct hd_driveid *id = drive->id;
-       int             len;
+       ide_drive_t     *drive = (ide_drive_t *) seq->private;
+       char            *m = (char *)&drive->id[ATA_ID_PROD];
+
+       seq_printf(seq, "%.40s\n", m[0] ? m : "(none)");
+       return 0;
+}
 
-       len = sprintf(page, "%.40s\n",
-               (id && id->model[0]) ? (char *)id->model : "(none)");
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+static int ide_dmodel_proc_open(struct inode *inode, struct file *file)
+{
+       return single_open(file, ide_dmodel_proc_show, PDE(inode)->data);
 }
 
-static int proc_ide_read_driver
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static const struct file_operations ide_dmodel_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_dmodel_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+
+static int ide_driver_proc_show(struct seq_file *m, void *v)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
-       struct device   *dev = &drive->gendev;
-       ide_driver_t    *ide_drv;
-       int             len;
+       ide_drive_t             *drive = (ide_drive_t *)m->private;
+       struct device           *dev = &drive->gendev;
+       struct ide_driver       *ide_drv;
 
        if (dev->driver) {
-               ide_drv = container_of(dev->driver, ide_driver_t, gen_driver);
-               len = sprintf(page, "%s version %s\n",
+               ide_drv = to_ide_driver(dev->driver);
+               seq_printf(m, "%s version %s\n",
                                dev->driver->name, ide_drv->version);
        } else
-               len = sprintf(page, "ide-default version 0.9.newide\n");
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+               seq_printf(m, "ide-default version 0.9.newide\n");
+       return 0;
+}
+
+static int ide_driver_proc_open(struct inode *inode, struct file *file)
+{
+       return single_open(file, ide_driver_proc_show, PDE(inode)->data);
 }
 
 static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
@@ -602,14 +540,14 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
        err = device_attach(dev);
        if (err < 0)
                printk(KERN_WARNING "IDE: %s: device_attach error: %d\n",
-                       __FUNCTION__, err);
+                       __func__, err);
        drive->driver_req[0] = 0;
        if (dev->driver == NULL) {
                err = device_attach(dev);
                if (err < 0)
                        printk(KERN_WARNING
                                "IDE: %s: device_attach(2) error: %d\n",
-                               __FUNCTION__, err);
+                               __func__, err);
        }
        if (dev->driver && !strcmp(dev->driver->name, driver))
                ret = 0;
@@ -617,10 +555,10 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
        return ret;
 }
 
-static int proc_ide_write_driver
-       (struct file *file, const char __user *buffer, unsigned long count, void *data)
+static ssize_t ide_driver_proc_write(struct file *file, const char __user *buffer,
+                                    size_t count, loff_t *pos)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
+       ide_drive_t     *drive = (ide_drive_t *) PDE(file->f_path.dentry->d_inode)->data;
        char name[32];
 
        if (!capable(CAP_SYS_ADMIN))
@@ -635,39 +573,52 @@ static int proc_ide_write_driver
        return count;
 }
 
-static int proc_ide_read_media
-       (char *page, char **start, off_t off, int count, int *eof, void *data)
+static const struct file_operations ide_driver_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_driver_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+       .write          = ide_driver_proc_write,
+};
+
+static int ide_media_proc_show(struct seq_file *m, void *v)
 {
-       ide_drive_t     *drive = (ide_drive_t *) data;
+       ide_drive_t     *drive = (ide_drive_t *) m->private;
        const char      *media;
-       int             len;
 
        switch (drive->media) {
-               case ide_disk:  media = "disk\n";
-                               break;
-               case ide_cdrom: media = "cdrom\n";
-                               break;
-               case ide_tape:  media = "tape\n";
-                               break;
-               case ide_floppy:media = "floppy\n";
-                               break;
-               case ide_optical:media = "optical\n";
-                               break;
-               default:        media = "UNKNOWN\n";
-                               break;
+       case ide_disk:          media = "disk\n";       break;
+       case ide_cdrom:         media = "cdrom\n";      break;
+       case ide_tape:          media = "tape\n";       break;
+       case ide_floppy:        media = "floppy\n";     break;
+       case ide_optical:       media = "optical\n";    break;
+       default:                media = "UNKNOWN\n";    break;
        }
-       strcpy(page,media);
-       len = strlen(media);
-       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+       seq_puts(m, media);
+       return 0;
 }
 
+static int ide_media_proc_open(struct inode *inode, struct file *file)
+{
+       return single_open(file, ide_media_proc_show, PDE(inode)->data);
+}
+
+static const struct file_operations ide_media_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = ide_media_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
+
 static ide_proc_entry_t generic_drive_entries[] = {
-       { "driver",     S_IFREG|S_IRUGO,        proc_ide_read_driver,   proc_ide_write_driver },
-       { "identify",   S_IFREG|S_IRUSR,        proc_ide_read_identify, NULL },
-       { "media",      S_IFREG|S_IRUGO,        proc_ide_read_media,    NULL },
-       { "model",      S_IFREG|S_IRUGO,        proc_ide_read_dmodel,   NULL },
-       { "settings",   S_IFREG|S_IRUSR|S_IWUSR,proc_ide_read_settings, proc_ide_write_settings },
-       { NULL, 0, NULL, NULL }
+       { "driver",     S_IFREG|S_IRUGO,         &ide_driver_proc_fops  },
+       { "identify",   S_IFREG|S_IRUSR,         &ide_identify_proc_fops},
+       { "media",      S_IFREG|S_IRUGO,         &ide_media_proc_fops   },
+       { "model",      S_IFREG|S_IRUGO,         &ide_dmodel_proc_fops  },
+       { "settings",   S_IFREG|S_IRUSR|S_IWUSR, &ide_settings_proc_fops},
+       {}
 };
 
 static void ide_add_proc_entries(struct proc_dir_entry *dir, ide_proc_entry_t *p, void *data)
@@ -677,11 +628,8 @@ static void ide_add_proc_entries(struct proc_dir_entry *dir, ide_proc_entry_t *p
        if (!dir || !p)
                return;
        while (p->name != NULL) {
-               ent = create_proc_entry(p->name, p->mode, dir);
+               ent = proc_create_data(p->name, p->mode, dir, p->proc_fops, data);
                if (!ent) return;
-               ent->data = data;
-               ent->read_proc = p->read_proc;
-               ent->write_proc = p->write_proc;
                p++;
        }
 }
@@ -696,9 +644,13 @@ static void ide_remove_proc_entries(struct proc_dir_entry *dir, ide_proc_entry_t
        }
 }
 
-void ide_proc_register_driver(ide_drive_t *drive, ide_driver_t *driver)
+void ide_proc_register_driver(ide_drive_t *drive, struct ide_driver *driver)
 {
-       ide_add_proc_entries(drive->proc, driver->proc, drive);
+       mutex_lock(&ide_setting_mtx);
+       drive->settings = driver->proc_devsets(drive);
+       mutex_unlock(&ide_setting_mtx);
+
+       ide_add_proc_entries(drive->proc, driver->proc_entries(drive), drive);
 }
 
 EXPORT_SYMBOL(ide_proc_register_driver);
@@ -711,93 +663,63 @@ EXPORT_SYMBOL(ide_proc_register_driver);
  *     Clean up the driver specific /proc files and IDE settings
  *     for a given drive.
  *
- *     Takes ide_setting_mtx and ide_lock.
- *     Caller must hold none of the locks.
+ *     Takes ide_setting_mtx.
  */
 
-void ide_proc_unregister_driver(ide_drive_t *drive, ide_driver_t *driver)
+void ide_proc_unregister_driver(ide_drive_t *drive, struct ide_driver *driver)
 {
-       unsigned long flags;
-
-       ide_remove_proc_entries(drive->proc, driver->proc);
+       ide_remove_proc_entries(drive->proc, driver->proc_entries(drive));
 
        mutex_lock(&ide_setting_mtx);
-       spin_lock_irqsave(&ide_lock, flags);
        /*
-        * ide_setting_mtx protects the settings list
-        * ide_lock protects the use of settings
-        *
-        * so we need to hold both, ide_settings_sem because we want to
-        * modify the settings list, and ide_lock because we cannot take
-        * a setting out that is being used.
-        *
-        * OTOH both ide_{read,write}_setting are only ever used under
-        * ide_setting_mtx.
+        * ide_setting_mtx protects both the settings list and the use
+        * of settings (we cannot take a setting out that is being used).
         */
-       auto_remove_settings(drive);
-       spin_unlock_irqrestore(&ide_lock, flags);
+       drive->settings = NULL;
        mutex_unlock(&ide_setting_mtx);
 }
-
 EXPORT_SYMBOL(ide_proc_unregister_driver);
 
-static void create_proc_ide_drives(ide_hwif_t *hwif)
+void ide_proc_port_register_devices(ide_hwif_t *hwif)
 {
-       int     d;
        struct proc_dir_entry *ent;
        struct proc_dir_entry *parent = hwif->proc;
+       ide_drive_t *drive;
        char name[64];
+       int i;
 
-       for (d = 0; d < MAX_DRIVES; d++) {
-               ide_drive_t *drive = &hwif->drives[d];
-
-               if (!drive->present)
-                       continue;
-               if (drive->proc)
+       ide_port_for_each_dev(i, drive, hwif) {
+               if ((drive->dev_flags & IDE_DFLAG_PRESENT) == 0)
                        continue;
 
                drive->proc = proc_mkdir(drive->name, parent);
                if (drive->proc)
                        ide_add_proc_entries(drive->proc, generic_drive_entries, drive);
-               sprintf(name,"ide%d/%s", (drive->name[2]-'a')/2, drive->name);
+               sprintf(name, "ide%d/%s", (drive->name[2]-'a')/2, drive->name);
                ent = proc_symlink(drive->name, proc_ide_root, name);
                if (!ent) return;
        }
 }
 
-static void destroy_proc_ide_device(ide_hwif_t *hwif, ide_drive_t *drive)
+void ide_proc_unregister_device(ide_drive_t *drive)
 {
        if (drive->proc) {
                ide_remove_proc_entries(drive->proc, generic_drive_entries);
                remove_proc_entry(drive->name, proc_ide_root);
-               remove_proc_entry(drive->name, hwif->proc);
+               remove_proc_entry(drive->name, drive->hwif->proc);
                drive->proc = NULL;
        }
 }
 
-static void destroy_proc_ide_drives(ide_hwif_t *hwif)
-{
-       int     d;
-
-       for (d = 0; d < MAX_DRIVES; d++) {
-               ide_drive_t *drive = &hwif->drives[d];
-               if (drive->proc)
-                       destroy_proc_ide_device(hwif, drive);
-       }
-}
-
 static ide_proc_entry_t hwif_entries[] = {
-       { "channel",    S_IFREG|S_IRUGO,        proc_ide_read_channel,  NULL },
-       { "mate",       S_IFREG|S_IRUGO,        proc_ide_read_mate,     NULL },
-       { "model",      S_IFREG|S_IRUGO,        proc_ide_read_imodel,   NULL },
-       { NULL, 0, NULL, NULL }
+       { "channel",    S_IFREG|S_IRUGO,        &ide_channel_proc_fops  },
+       { "mate",       S_IFREG|S_IRUGO,        &ide_mate_proc_fops     },
+       { "model",      S_IFREG|S_IRUGO,        &ide_imodel_proc_fops   },
+       {}
 };
 
 void ide_proc_register_port(ide_hwif_t *hwif)
 {
-       if (!hwif->present)
-               return;
-
        if (!hwif->proc) {
                hwif->proc = proc_mkdir(hwif->name, proc_ide_root);
 
@@ -806,23 +728,11 @@ void ide_proc_register_port(ide_hwif_t *hwif)
 
                ide_add_proc_entries(hwif->proc, hwif_entries, hwif);
        }
-
-       create_proc_ide_drives(hwif);
 }
 
-#ifdef CONFIG_BLK_DEV_IDEPCI
-void ide_pci_create_host_proc(const char *name, get_info_t *get_info)
-{
-       create_proc_info_entry(name, 0, proc_ide_root, get_info);
-}
-
-EXPORT_SYMBOL_GPL(ide_pci_create_host_proc);
-#endif
-
 void ide_proc_unregister_port(ide_hwif_t *hwif)
 {
        if (hwif->proc) {
-               destroy_proc_ide_drives(hwif);
                ide_remove_proc_entries(hwif->proc, hwif_entries);
                remove_proc_entry(hwif->name, proc_ide_root);
                hwif->proc = NULL;
@@ -831,7 +741,7 @@ void ide_proc_unregister_port(ide_hwif_t *hwif)
 
 static int proc_print_driver(struct device_driver *drv, void *data)
 {
-       ide_driver_t *ide_drv = container_of(drv, ide_driver_t, gen_driver);
+       struct ide_driver *ide_drv = to_ide_driver(drv);
        struct seq_file *s = data;
 
        seq_printf(s, "%s version %s\n", drv->name, ide_drv->version);
@@ -846,7 +756,7 @@ static int ide_drivers_show(struct seq_file *s, void *p)
        err = bus_for_each_drv(&ide_bus_type, NULL, s, proc_print_driver);
        if (err < 0)
                printk(KERN_WARNING "IDE: %s: bus_for_each_drv error: %d\n",
-                       __FUNCTION__, err);
+                       __func__, err);
        return 0;
 }
 
@@ -856,6 +766,7 @@ static int ide_drivers_open(struct inode *inode, struct file *file)
 }
 
 static const struct file_operations ide_drivers_operations = {
+       .owner          = THIS_MODULE,
        .open           = ide_drivers_open,
        .read           = seq_read,
        .llseek         = seq_lseek,
@@ -864,16 +775,12 @@ static const struct file_operations ide_drivers_operations = {
 
 void proc_ide_create(void)
 {
-       struct proc_dir_entry *entry;
-
        proc_ide_root = proc_mkdir("ide", NULL);
 
        if (!proc_ide_root)
                return;
 
-       entry = create_proc_entry("drivers", 0, proc_ide_root);
-       if (entry)
-               entry->proc_fops = &ide_drivers_operations;
+       proc_create("drivers", 0, proc_ide_root, &ide_drivers_operations);
 }
 
 void proc_ide_destroy(void)