of: Always use 'struct device.of_node' to get device node pointer.
[safe/jmp/linux-2.6] / drivers / i2c / busses / i2c-mpc.c
index 10b9342..69473b6 100644 (file)
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
-#include <linux/platform_device.h>
+#include <linux/of_platform.h>
+#include <linux/of_i2c.h>
+#include <linux/slab.h>
 
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/fsl_devices.h>
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
 
-#define MPC_I2C_ADDR  0x00
-#define MPC_I2C_FDR    0x04
-#define MPC_I2C_CR     0x08
-#define MPC_I2C_SR     0x0c
-#define MPC_I2C_DR     0x10
+#include <asm/mpc52xx.h>
+#include <sysdev/fsl_soc.h>
+
+#define DRV_NAME "mpc-i2c"
+
+#define MPC_I2C_CLOCK_LEGACY   0
+#define MPC_I2C_CLOCK_PRESERVE (~0U)
+
+#define MPC_I2C_FDR   0x04
+#define MPC_I2C_CR    0x08
+#define MPC_I2C_SR    0x0c
+#define MPC_I2C_DR    0x10
 #define MPC_I2C_DFSRR 0x14
-#define MPC_I2C_REGION 0x20
 
 #define CCR_MEN  0x80
 #define CCR_MIEN 0x40
 #define CSR_RXAK 0x01
 
 struct mpc_i2c {
+       struct device *dev;
        void __iomem *base;
        u32 interrupt;
        wait_queue_head_t queue;
        struct i2c_adapter adap;
        int irq;
-       u32 flags;
 };
 
-static __inline__ void writeccr(struct mpc_i2c *i2c, u32 x)
+struct mpc_i2c_divider {
+       u16 divider;
+       u16 fdr;        /* including dfsrr */
+};
+
+struct mpc_i2c_data {
+       void (*setup)(struct device_node *node, struct mpc_i2c *i2c,
+                     u32 clock, u32 prescaler);
+       u32 prescaler;
+};
+
+static inline void writeccr(struct mpc_i2c *i2c, u32 x)
 {
        writeb(x, i2c->base + MPC_I2C_CR);
 }
@@ -69,7 +88,7 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
                /* Read again to allow register to stabilise */
                i2c->interrupt = readb(i2c->base + MPC_I2C_SR);
                writeb(0, i2c->base + MPC_I2C_SR);
-               wake_up_interruptible(&i2c->queue);
+               wake_up(&i2c->queue);
        }
        return IRQ_HANDLED;
 }
@@ -99,12 +118,11 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
        u32 x;
        int result = 0;
 
-       if (i2c->irq == NO_IRQ)
-       {
+       if (i2c->irq == NO_IRQ) {
                while (!(readb(i2c->base + MPC_I2C_SR) & CSR_MIF)) {
                        schedule();
                        if (time_after(jiffies, orig_jiffies + timeout)) {
-                               pr_debug("I2C: timeout\n");
+                               dev_dbg(i2c->dev, "timeout\n");
                                writeccr(i2c, 0);
                                result = -EIO;
                                break;
@@ -114,14 +132,11 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
                writeb(0, i2c->base + MPC_I2C_SR);
        } else {
                /* Interrupt mode */
-               result = wait_event_interruptible_timeout(i2c->queue,
-                       (i2c->interrupt & CSR_MIF), timeout * HZ);
+               result = wait_event_timeout(i2c->queue,
+                       (i2c->interrupt & CSR_MIF), timeout);
 
-               if (unlikely(result < 0)) {
-                       pr_debug("I2C: wait interrupted\n");
-                       writeccr(i2c, 0);
-               } else if (unlikely(!(i2c->interrupt & CSR_MIF))) {
-                       pr_debug("I2C: wait timeout\n");
+               if (unlikely(!(i2c->interrupt & CSR_MIF))) {
+                       dev_dbg(i2c->dev, "wait timeout\n");
                        writeccr(i2c, 0);
                        result = -ETIMEDOUT;
                }
@@ -134,17 +149,17 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
                return result;
 
        if (!(x & CSR_MCF)) {
-               pr_debug("I2C: unfinished\n");
+               dev_dbg(i2c->dev, "unfinished\n");
                return -EIO;
        }
 
        if (x & CSR_MAL) {
-               pr_debug("I2C: MAL\n");
+               dev_dbg(i2c->dev, "MAL\n");
                return -EIO;
        }
 
        if (writing && (x & CSR_RXAK)) {
-               pr_debug("I2C: No RXAK\n");
+               dev_dbg(i2c->dev, "No RXAK\n");
                /* generate stop */
                writeccr(i2c, CCR_MEN);
                return -EIO;
@@ -152,18 +167,238 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
        return 0;
 }
 
-static void mpc_i2c_setclock(struct mpc_i2c *i2c)
+#if defined(CONFIG_PPC_MPC52xx) || defined(CONFIG_PPC_MPC512x)
+static const struct mpc_i2c_divider mpc_i2c_dividers_52xx[] __devinitconst = {
+       {20, 0x20}, {22, 0x21}, {24, 0x22}, {26, 0x23},
+       {28, 0x24}, {30, 0x01}, {32, 0x25}, {34, 0x02},
+       {36, 0x26}, {40, 0x27}, {44, 0x04}, {48, 0x28},
+       {52, 0x63}, {56, 0x29}, {60, 0x41}, {64, 0x2a},
+       {68, 0x07}, {72, 0x2b}, {80, 0x2c}, {88, 0x09},
+       {96, 0x2d}, {104, 0x0a}, {112, 0x2e}, {120, 0x81},
+       {128, 0x2f}, {136, 0x47}, {144, 0x0c}, {160, 0x30},
+       {176, 0x49}, {192, 0x31}, {208, 0x4a}, {224, 0x32},
+       {240, 0x0f}, {256, 0x33}, {272, 0x87}, {288, 0x10},
+       {320, 0x34}, {352, 0x89}, {384, 0x35}, {416, 0x8a},
+       {448, 0x36}, {480, 0x13}, {512, 0x37}, {576, 0x14},
+       {640, 0x38}, {768, 0x39}, {896, 0x3a}, {960, 0x17},
+       {1024, 0x3b}, {1152, 0x18}, {1280, 0x3c}, {1536, 0x3d},
+       {1792, 0x3e}, {1920, 0x1b}, {2048, 0x3f}, {2304, 0x1c},
+       {2560, 0x1d}, {3072, 0x1e}, {3584, 0x7e}, {3840, 0x1f},
+       {4096, 0x7f}, {4608, 0x5c}, {5120, 0x5d}, {6144, 0x5e},
+       {7168, 0xbe}, {7680, 0x5f}, {8192, 0xbf}, {9216, 0x9c},
+       {10240, 0x9d}, {12288, 0x9e}, {15360, 0x9f}
+};
+
+static int __devinit mpc_i2c_get_fdr_52xx(struct device_node *node, u32 clock,
+                                         int prescaler)
+{
+       const struct mpc_i2c_divider *div = NULL;
+       unsigned int pvr = mfspr(SPRN_PVR);
+       u32 divider;
+       int i;
+
+       if (clock == MPC_I2C_CLOCK_LEGACY)
+               return -EINVAL;
+
+       /* Determine divider value */
+       divider = mpc5xxx_get_bus_frequency(node) / clock;
+
+       /*
+        * We want to choose an FDR/DFSR that generates an I2C bus speed that
+        * is equal to or lower than the requested speed.
+        */
+       for (i = 0; i < ARRAY_SIZE(mpc_i2c_dividers_52xx); i++) {
+               div = &mpc_i2c_dividers_52xx[i];
+               /* Old MPC5200 rev A CPUs do not support the high bits */
+               if (div->fdr & 0xc0 && pvr == 0x80822011)
+                       continue;
+               if (div->divider >= divider)
+                       break;
+       }
+
+       return div ? (int)div->fdr : -EINVAL;
+}
+
+static void __devinit mpc_i2c_setup_52xx(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
+{
+       int ret, fdr;
+
+       if (clock == MPC_I2C_CLOCK_PRESERVE) {
+               dev_dbg(i2c->dev, "using fdr %d\n",
+                       readb(i2c->base + MPC_I2C_FDR));
+               return;
+       }
+
+       ret = mpc_i2c_get_fdr_52xx(node, clock, prescaler);
+       fdr = (ret >= 0) ? ret : 0x3f; /* backward compatibility */
+
+       writeb(fdr & 0xff, i2c->base + MPC_I2C_FDR);
+
+       if (ret >= 0)
+               dev_info(i2c->dev, "clock %d Hz (fdr=%d)\n", clock, fdr);
+}
+#else /* !(CONFIG_PPC_MPC52xx || CONFIG_PPC_MPC512x) */
+static void __devinit mpc_i2c_setup_52xx(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
+{
+}
+#endif /* CONFIG_PPC_MPC52xx || CONFIG_PPC_MPC512x */
+
+#ifdef CONFIG_PPC_MPC512x
+static void __devinit mpc_i2c_setup_512x(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
+{
+       struct device_node *node_ctrl;
+       void __iomem *ctrl;
+       const u32 *pval;
+       u32 idx;
+
+       /* Enable I2C interrupts for mpc5121 */
+       node_ctrl = of_find_compatible_node(NULL, NULL,
+                                           "fsl,mpc5121-i2c-ctrl");
+       if (node_ctrl) {
+               ctrl = of_iomap(node_ctrl, 0);
+               if (ctrl) {
+                       /* Interrupt enable bits for i2c-0/1/2: bit 24/26/28 */
+                       pval = of_get_property(node, "reg", NULL);
+                       idx = (*pval & 0xff) / 0x20;
+                       setbits32(ctrl, 1 << (24 + idx * 2));
+                       iounmap(ctrl);
+               }
+               of_node_put(node_ctrl);
+       }
+
+       /* The clock setup for the 52xx works also fine for the 512x */
+       mpc_i2c_setup_52xx(node, i2c, clock, prescaler);
+}
+#else /* CONFIG_PPC_MPC512x */
+static void __devinit mpc_i2c_setup_512x(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
+{
+}
+#endif /* CONFIG_PPC_MPC512x */
+
+#ifdef CONFIG_FSL_SOC
+static const struct mpc_i2c_divider mpc_i2c_dividers_8xxx[] __devinitconst = {
+       {160, 0x0120}, {192, 0x0121}, {224, 0x0122}, {256, 0x0123},
+       {288, 0x0100}, {320, 0x0101}, {352, 0x0601}, {384, 0x0102},
+       {416, 0x0602}, {448, 0x0126}, {480, 0x0103}, {512, 0x0127},
+       {544, 0x0b03}, {576, 0x0104}, {608, 0x1603}, {640, 0x0105},
+       {672, 0x2003}, {704, 0x0b05}, {736, 0x2b03}, {768, 0x0106},
+       {800, 0x3603}, {832, 0x0b06}, {896, 0x012a}, {960, 0x0107},
+       {1024, 0x012b}, {1088, 0x1607}, {1152, 0x0108}, {1216, 0x2b07},
+       {1280, 0x0109}, {1408, 0x1609}, {1536, 0x010a}, {1664, 0x160a},
+       {1792, 0x012e}, {1920, 0x010b}, {2048, 0x012f}, {2176, 0x2b0b},
+       {2304, 0x010c}, {2560, 0x010d}, {2816, 0x2b0d}, {3072, 0x010e},
+       {3328, 0x2b0e}, {3584, 0x0132}, {3840, 0x010f}, {4096, 0x0133},
+       {4608, 0x0110}, {5120, 0x0111}, {6144, 0x0112}, {7168, 0x0136},
+       {7680, 0x0113}, {8192, 0x0137}, {9216, 0x0114}, {10240, 0x0115},
+       {12288, 0x0116}, {14336, 0x013a}, {15360, 0x0117}, {16384, 0x013b},
+       {18432, 0x0118}, {20480, 0x0119}, {24576, 0x011a}, {28672, 0x013e},
+       {30720, 0x011b}, {32768, 0x013f}, {36864, 0x011c}, {40960, 0x011d},
+       {49152, 0x011e}, {61440, 0x011f}
+};
+
+static u32 __devinit mpc_i2c_get_sec_cfg_8xxx(void)
+{
+       struct device_node *node = NULL;
+       u32 __iomem *reg;
+       u32 val = 0;
+
+       node = of_find_node_by_name(NULL, "global-utilities");
+       if (node) {
+               const u32 *prop = of_get_property(node, "reg", NULL);
+               if (prop) {
+                       /*
+                        * Map and check POR Device Status Register 2
+                        * (PORDEVSR2) at 0xE0014
+                        */
+                       reg = ioremap(get_immrbase() + *prop + 0x14, 0x4);
+                       if (!reg)
+                               printk(KERN_ERR
+                                      "Error: couldn't map PORDEVSR2\n");
+                       else
+                               val = in_be32(reg) & 0x00000080; /* sec-cfg */
+                       iounmap(reg);
+               }
+       }
+       if (node)
+               of_node_put(node);
+
+       return val;
+}
+
+static int __devinit mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock,
+                                         u32 prescaler)
+{
+       const struct mpc_i2c_divider *div = NULL;
+       u32 divider;
+       int i;
+
+       if (clock == MPC_I2C_CLOCK_LEGACY)
+               return -EINVAL;
+
+       /* Determine proper divider value */
+       if (of_device_is_compatible(node, "fsl,mpc8544-i2c"))
+               prescaler = mpc_i2c_get_sec_cfg_8xxx() ? 3 : 2;
+       if (!prescaler)
+               prescaler = 1;
+
+       divider = fsl_get_sys_freq() / clock / prescaler;
+
+       pr_debug("I2C: src_clock=%d clock=%d divider=%d\n",
+                fsl_get_sys_freq(), clock, divider);
+
+       /*
+        * We want to choose an FDR/DFSR that generates an I2C bus speed that
+        * is equal to or lower than the requested speed.
+        */
+       for (i = 0; i < ARRAY_SIZE(mpc_i2c_dividers_8xxx); i++) {
+               div = &mpc_i2c_dividers_8xxx[i];
+               if (div->divider >= divider)
+                       break;
+       }
+
+       return div ? (int)div->fdr : -EINVAL;
+}
+
+static void __devinit mpc_i2c_setup_8xxx(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
 {
-       /* Set clock and filters */
-       if (i2c->flags & FSL_I2C_DEV_SEPARATE_DFSRR) {
-               writeb(0x31, i2c->base + MPC_I2C_FDR);
-               writeb(0x10, i2c->base + MPC_I2C_DFSRR);
-       } else if (i2c->flags & FSL_I2C_DEV_CLOCK_5200)
-               writeb(0x3f, i2c->base + MPC_I2C_FDR);
-       else
-               writel(0x1031, i2c->base + MPC_I2C_FDR);
+       int ret, fdr;
+
+       if (clock == MPC_I2C_CLOCK_PRESERVE) {
+               dev_dbg(i2c->dev, "using dfsrr %d, fdr %d\n",
+                       readb(i2c->base + MPC_I2C_DFSRR),
+                       readb(i2c->base + MPC_I2C_FDR));
+               return;
+       }
+
+       ret = mpc_i2c_get_fdr_8xxx(node, clock, prescaler);
+       fdr = (ret >= 0) ? ret : 0x1031; /* backward compatibility */
+
+       writeb(fdr & 0xff, i2c->base + MPC_I2C_FDR);
+       writeb((fdr >> 8) & 0xff, i2c->base + MPC_I2C_DFSRR);
+
+       if (ret >= 0)
+               dev_info(i2c->dev, "clock %d Hz (dfsrr=%d fdr=%d)\n",
+                        clock, fdr >> 8, fdr & 0xff);
 }
 
+#else /* !CONFIG_FSL_SOC */
+static void __devinit mpc_i2c_setup_8xxx(struct device_node *node,
+                                        struct mpc_i2c *i2c,
+                                        u32 clock, u32 prescaler)
+{
+}
+#endif /* CONFIG_FSL_SOC */
+
 static void mpc_i2c_start(struct mpc_i2c *i2c)
 {
        /* Clear arbitration */
@@ -178,15 +413,12 @@ static void mpc_i2c_stop(struct mpc_i2c *i2c)
 }
 
 static int mpc_write(struct mpc_i2c *i2c, int target,
-                    const u8 * data, int length, int restart)
+                    const u8 *data, int length, int restart)
 {
        int i, result;
        unsigned timeout = i2c->adap.timeout;
        u32 flags = restart ? CCR_RSTA : 0;
 
-       /* Start with MEN */
-       if (!restart)
-               writeccr(i2c, CCR_MEN);
        /* Start as master */
        writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_MSTA | CCR_MTX | flags);
        /* Write target byte */
@@ -209,15 +441,12 @@ static int mpc_write(struct mpc_i2c *i2c, int target,
 }
 
 static int mpc_read(struct mpc_i2c *i2c, int target,
-                   u8 * data, int length, int restart)
+                   u8 *data, int length, int restart)
 {
        unsigned timeout = i2c->adap.timeout;
        int i, result;
        u32 flags = restart ? CCR_RSTA : 0;
 
-       /* Start with MEN */
-       if (!restart)
-               writeccr(i2c, CCR_MEN);
        /* Switch to read - restart */
        writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_MSTA | CCR_MTX | flags);
        /* Write target address byte - this time with the read flag set */
@@ -244,9 +473,9 @@ static int mpc_read(struct mpc_i2c *i2c, int target,
                /* Generate txack on next to last byte */
                if (i == length - 2)
                        writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_MSTA | CCR_TXAK);
-               /* Generate stop on last byte */
+               /* Do not generate stop on last byte */
                if (i == length - 1)
-                       writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_TXAK);
+                       writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_MSTA | CCR_MTX);
                data[i] = readb(i2c->base + MPC_I2C_DR);
        }
 
@@ -266,12 +495,12 @@ static int mpc_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
        /* Allow bus up to 1s to become not busy */
        while (readb(i2c->base + MPC_I2C_SR) & CSR_MBB) {
                if (signal_pending(current)) {
-                       pr_debug("I2C: Interrupted\n");
+                       dev_dbg(i2c->dev, "Interrupted\n");
                        writeccr(i2c, 0);
                        return -EINTR;
                }
                if (time_after(jiffies, orig_jiffies + HZ)) {
-                       pr_debug("I2C: timeout\n");
+                       dev_dbg(i2c->dev, "timeout\n");
                        if (readb(i2c->base + MPC_I2C_SR) ==
                            (CSR_MCF | CSR_MBB | CSR_RXAK))
                                mpc_i2c_fixup(i2c);
@@ -282,9 +511,10 @@ static int mpc_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 
        for (i = 0; ret >= 0 && i < num; i++) {
                pmsg = &msgs[i];
-               pr_debug("Doing %s %d bytes to 0x%02x - %d of %d messages\n",
-                        pmsg->flags & I2C_M_RD ? "read" : "write",
-                        pmsg->len, pmsg->addr, i + 1, num);
+               dev_dbg(i2c->dev,
+                       "Doing %s %d bytes to 0x%02x - %d of %d messages\n",
+                       pmsg->flags & I2C_M_RD ? "read" : "write",
+                       pmsg->len, pmsg->addr, i + 1, num);
                if (pmsg->flags & I2C_M_RD)
                        ret =
                            mpc_read(i2c, pmsg->addr, pmsg->buf, pmsg->len, i);
@@ -309,114 +539,171 @@ static const struct i2c_algorithm mpc_algo = {
 static struct i2c_adapter mpc_ops = {
        .owner = THIS_MODULE,
        .name = "MPC adapter",
-       .id = I2C_HW_MPC107,
        .algo = &mpc_algo,
-       .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
-       .timeout = 1,
+       .timeout = HZ,
 };
 
-static int fsl_i2c_probe(struct platform_device *pdev)
+static int __devinit fsl_i2c_probe(struct of_device *op,
+                                  const struct of_device_id *match)
 {
-       int result = 0;
        struct mpc_i2c *i2c;
-       struct fsl_i2c_platform_data *pdata;
-       struct resource *r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-       pdata = (struct fsl_i2c_platform_data *) pdev->dev.platform_data;
+       const u32 *prop;
+       u32 clock = MPC_I2C_CLOCK_LEGACY;
+       int result = 0;
+       int plen;
 
        i2c = kzalloc(sizeof(*i2c), GFP_KERNEL);
        if (!i2c)
                return -ENOMEM;
 
-       i2c->irq = platform_get_irq(pdev, 0);
-       if (i2c->irq < 0)
-               i2c->irq = NO_IRQ; /* Use polling */
+       i2c->dev = &op->dev; /* for debug and error output */
 
-       i2c->flags = pdata->device_flags;
        init_waitqueue_head(&i2c->queue);
 
-       i2c->base = ioremap((phys_addr_t)r->start, MPC_I2C_REGION);
-
+       i2c->base = of_iomap(op->dev.of_node, 0);
        if (!i2c->base) {
-               printk(KERN_ERR "i2c-mpc - failed to map controller\n");
+               dev_err(i2c->dev, "failed to map controller\n");
                result = -ENOMEM;
                goto fail_map;
        }
 
-       if (i2c->irq != NO_IRQ)
-               if ((result = request_irq(i2c->irq, mpc_i2c_isr,
-                                         IRQF_SHARED, "i2c-mpc", i2c)) < 0) {
-                       printk(KERN_ERR
-                              "i2c-mpc - failed to attach interrupt\n");
-                       goto fail_irq;
+       i2c->irq = irq_of_parse_and_map(op->dev.of_node, 0);
+       if (i2c->irq != NO_IRQ) { /* i2c->irq = NO_IRQ implies polling */
+               result = request_irq(i2c->irq, mpc_i2c_isr,
+                                    IRQF_SHARED, "i2c-mpc", i2c);
+               if (result < 0) {
+                       dev_err(i2c->dev, "failed to attach interrupt\n");
+                       goto fail_request;
                }
+       }
+
+       if (of_get_property(op->dev.of_node, "fsl,preserve-clocking", NULL)) {
+               clock = MPC_I2C_CLOCK_PRESERVE;
+       } else {
+               prop = of_get_property(op->dev.of_node, "clock-frequency",
+                                       &plen);
+               if (prop && plen == sizeof(u32))
+                       clock = *prop;
+       }
+
+       if (match->data) {
+               struct mpc_i2c_data *data = match->data;
+               data->setup(op->dev.of_node, i2c, clock, data->prescaler);
+       } else {
+               /* Backwards compatibility */
+               if (of_get_property(op->dev.of_node, "dfsrr", NULL))
+                       mpc_i2c_setup_8xxx(op->dev.of_node, i2c, clock, 0);
+       }
 
-       mpc_i2c_setclock(i2c);
-       platform_set_drvdata(pdev, i2c);
+       dev_set_drvdata(&op->dev, i2c);
 
        i2c->adap = mpc_ops;
-       i2c->adap.nr = pdev->id;
        i2c_set_adapdata(&i2c->adap, i2c);
-       i2c->adap.dev.parent = &pdev->dev;
-       if ((result = i2c_add_numbered_adapter(&i2c->adap)) < 0) {
-               printk(KERN_ERR "i2c-mpc - failed to add adapter\n");
+       i2c->adap.dev.parent = &op->dev;
+
+       result = i2c_add_adapter(&i2c->adap);
+       if (result < 0) {
+               dev_err(i2c->dev, "failed to add adapter\n");
                goto fail_add;
        }
+       of_register_i2c_devices(&i2c->adap, op->dev.of_node);
 
        return result;
 
-      fail_add:
-       if (i2c->irq != NO_IRQ)
-               free_irq(i2c->irq, i2c);
-      fail_irq:
+ fail_add:
+       dev_set_drvdata(&op->dev, NULL);
+       free_irq(i2c->irq, i2c);
+ fail_request:
+       irq_dispose_mapping(i2c->irq);
        iounmap(i2c->base);
     fail_map:
+ fail_map:
        kfree(i2c);
        return result;
 };
 
-static int fsl_i2c_remove(struct platform_device *pdev)
+static int __devexit fsl_i2c_remove(struct of_device *op)
 {
-       struct mpc_i2c *i2c = platform_get_drvdata(pdev);
+       struct mpc_i2c *i2c = dev_get_drvdata(&op->dev);
 
        i2c_del_adapter(&i2c->adap);
-       platform_set_drvdata(pdev, NULL);
+       dev_set_drvdata(&op->dev, NULL);
 
        if (i2c->irq != NO_IRQ)
                free_irq(i2c->irq, i2c);
 
+       irq_dispose_mapping(i2c->irq);
        iounmap(i2c->base);
        kfree(i2c);
        return 0;
 };
 
-/* work with hotplug and coldplug */
-MODULE_ALIAS("platform:fsl-i2c");
+static struct mpc_i2c_data mpc_i2c_data_512x __devinitdata = {
+       .setup = mpc_i2c_setup_512x,
+};
+
+static struct mpc_i2c_data mpc_i2c_data_52xx __devinitdata = {
+       .setup = mpc_i2c_setup_52xx,
+};
+
+static struct mpc_i2c_data mpc_i2c_data_8313 __devinitdata = {
+       .setup = mpc_i2c_setup_8xxx,
+};
+
+static struct mpc_i2c_data mpc_i2c_data_8543 __devinitdata = {
+       .setup = mpc_i2c_setup_8xxx,
+       .prescaler = 2,
+};
+
+static struct mpc_i2c_data mpc_i2c_data_8544 __devinitdata = {
+       .setup = mpc_i2c_setup_8xxx,
+       .prescaler = 3,
+};
+
+static const struct of_device_id mpc_i2c_of_match[] = {
+       {.compatible = "mpc5200-i2c", .data = &mpc_i2c_data_52xx, },
+       {.compatible = "fsl,mpc5200b-i2c", .data = &mpc_i2c_data_52xx, },
+       {.compatible = "fsl,mpc5200-i2c", .data = &mpc_i2c_data_52xx, },
+       {.compatible = "fsl,mpc5121-i2c", .data = &mpc_i2c_data_512x, },
+       {.compatible = "fsl,mpc8313-i2c", .data = &mpc_i2c_data_8313, },
+       {.compatible = "fsl,mpc8543-i2c", .data = &mpc_i2c_data_8543, },
+       {.compatible = "fsl,mpc8544-i2c", .data = &mpc_i2c_data_8544, },
+       /* Backward compatibility */
+       {.compatible = "fsl-i2c", },
+       {},
+};
+MODULE_DEVICE_TABLE(of, mpc_i2c_of_match);
 
 /* Structure for a device driver */
-static struct platform_driver fsl_i2c_driver = {
-       .probe = fsl_i2c_probe,
-       .remove = fsl_i2c_remove,
-       .driver = {
-               .owner = THIS_MODULE,
-               .name = "fsl-i2c",
+static struct of_platform_driver mpc_i2c_driver = {
+       .match_table    = mpc_i2c_of_match,
+       .probe          = fsl_i2c_probe,
+       .remove         = __devexit_p(fsl_i2c_remove),
+       .driver         = {
+               .owner  = THIS_MODULE,
+               .name   = DRV_NAME,
        },
 };
 
 static int __init fsl_i2c_init(void)
 {
-       return platform_driver_register(&fsl_i2c_driver);
+       int rv;
+
+       rv = of_register_platform_driver(&mpc_i2c_driver);
+       if (rv)
+               printk(KERN_ERR DRV_NAME
+                      " of_register_platform_driver failed (%i)\n", rv);
+       return rv;
 }
 
 static void __exit fsl_i2c_exit(void)
 {
-       platform_driver_unregister(&fsl_i2c_driver);
+       of_unregister_platform_driver(&mpc_i2c_driver);
 }
 
 module_init(fsl_i2c_init);
 module_exit(fsl_i2c_exit);
 
 MODULE_AUTHOR("Adrian Cox <adrian@humboldt.co.uk>");
-MODULE_DESCRIPTION
-    ("I2C-Bus adapter for MPC107 bridge and MPC824x/85xx/52xx processors");
+MODULE_DESCRIPTION("I2C-Bus adapter for MPC107 bridge and "
+                  "MPC824x/83xx/85xx/86xx/512x/52xx processors");
 MODULE_LICENSE("GPL");