tree-wide: fix assorted typos all over the place
[safe/jmp/linux-2.6] / drivers / crypto / hifn_795x.c
index 27b8af9..09ad915 100644 (file)
@@ -38,9 +38,6 @@
 
 #include <asm/kmap_types.h>
 
-#undef dprintk
-
-#define HIFN_TEST
 //#define HIFN_DEBUG
 
 #ifdef HIFN_DEBUG
@@ -363,14 +360,14 @@ static atomic_t hifn_dev_number;
 #define HIFN_NAMESIZE                  32
 #define HIFN_MAX_RESULT_ORDER          5
 
-#define        HIFN_D_CMD_RSIZE                24*4
-#define        HIFN_D_SRC_RSIZE                80*4
-#define        HIFN_D_DST_RSIZE                80*4
-#define        HIFN_D_RES_RSIZE                24*4
+#define        HIFN_D_CMD_RSIZE                24*1
+#define        HIFN_D_SRC_RSIZE                80*1
+#define        HIFN_D_DST_RSIZE                80*1
+#define        HIFN_D_RES_RSIZE                24*1
 
 #define HIFN_D_DST_DALIGN              4
 
-#define HIFN_QUEUE_LENGTH              HIFN_D_CMD_RSIZE-1
+#define HIFN_QUEUE_LENGTH              (HIFN_D_CMD_RSIZE - 1)
 
 #define AES_MIN_KEY_SIZE               16
 #define AES_MAX_KEY_SIZE               32
@@ -406,8 +403,6 @@ struct hifn_dma {
        u8                      command_bufs[HIFN_D_CMD_RSIZE][HIFN_MAX_COMMAND];
        u8                      result_bufs[HIFN_D_CMD_RSIZE][HIFN_MAX_RESULT];
 
-       u64                     test_src, test_dst;
-
        /*
         *  Our current positions for insertion and removal from the descriptor
         *  rings.
@@ -434,9 +429,6 @@ struct hifn_device
        struct pci_dev          *pdev;
        void __iomem            *bar[3];
 
-       unsigned long           result_mem;
-       dma_addr_t              dst;
-
        void                    *desc_virt;
        dma_addr_t              desc_dma;
 
@@ -446,8 +438,6 @@ struct hifn_device
 
        spinlock_t              lock;
 
-       void                    *priv;
-
        u32                     flags;
        int                     active, started;
        struct delayed_work     work;
@@ -657,9 +647,15 @@ struct ablkcipher_walk
 
 struct hifn_context
 {
-       u8                      key[HIFN_MAX_CRYPT_KEY_LENGTH], *iv;
+       u8                      key[HIFN_MAX_CRYPT_KEY_LENGTH];
        struct hifn_device      *dev;
-       unsigned int            keysize, ivsize;
+       unsigned int            keysize;
+};
+
+struct hifn_request_context
+{
+       u8                      *iv;
+       unsigned int            ivsize;
        u8                      op, type, mode, unused;
        struct ablkcipher_walk  walk;
 };
@@ -867,7 +863,7 @@ static int hifn_init_pubrng(struct hifn_device *dev)
                dev->dmareg |= HIFN_DMAIER_PUBDONE;
                hifn_write_1(dev, HIFN_1_DMA_IER, dev->dmareg);
 
-               dprintk("Chip %s: Public key engine has been sucessfully "
+               dprintk("Chip %s: Public key engine has been successfully "
                                "initialised.\n", dev->name);
        }
 
@@ -1167,7 +1163,8 @@ static int hifn_setup_crypto_command(struct hifn_device *dev,
 }
 
 static int hifn_setup_cmd_desc(struct hifn_device *dev,
-               struct hifn_context *ctx, void *priv, unsigned int nbytes)
+               struct hifn_context *ctx, struct hifn_request_context *rctx,
+               void *priv, unsigned int nbytes)
 {
        struct hifn_dma *dma = (struct hifn_dma *)dev->desc_virt;
        int cmd_len, sa_idx;
@@ -1178,7 +1175,7 @@ static int hifn_setup_cmd_desc(struct hifn_device *dev,
        buf_pos = buf = dma->command_bufs[dma->cmdi];
 
        mask = 0;
-       switch (ctx->op) {
+       switch (rctx->op) {
                case ACRYPTO_OP_DECRYPT:
                        mask = HIFN_BASE_CMD_CRYPT | HIFN_BASE_CMD_DECODE;
                        break;
@@ -1195,15 +1192,15 @@ static int hifn_setup_cmd_desc(struct hifn_device *dev,
        buf_pos += hifn_setup_base_command(dev, buf_pos, nbytes,
                        nbytes, mask, dev->snum);
 
-       if (ctx->op == ACRYPTO_OP_ENCRYPT || ctx->op == ACRYPTO_OP_DECRYPT) {
+       if (rctx->op == ACRYPTO_OP_ENCRYPT || rctx->op == ACRYPTO_OP_DECRYPT) {
                u16 md = 0;
 
                if (ctx->keysize)
                        md |= HIFN_CRYPT_CMD_NEW_KEY;
-               if (ctx->iv && ctx->mode != ACRYPTO_MODE_ECB)
+               if (rctx->iv && rctx->mode != ACRYPTO_MODE_ECB)
                        md |= HIFN_CRYPT_CMD_NEW_IV;
 
-               switch (ctx->mode) {
+               switch (rctx->mode) {
                        case ACRYPTO_MODE_ECB:
                                md |= HIFN_CRYPT_CMD_MODE_ECB;
                                break;
@@ -1220,7 +1217,7 @@ static int hifn_setup_cmd_desc(struct hifn_device *dev,
                                goto err_out;
                }
 
-               switch (ctx->type) {
+               switch (rctx->type) {
                        case ACRYPTO_TYPE_AES_128:
                                if (ctx->keysize != 16)
                                        goto err_out;
@@ -1255,17 +1252,18 @@ static int hifn_setup_cmd_desc(struct hifn_device *dev,
 
                buf_pos += hifn_setup_crypto_command(dev, buf_pos,
                                nbytes, nbytes, ctx->key, ctx->keysize,
-                               ctx->iv, ctx->ivsize, md);
+                               rctx->iv, rctx->ivsize, md);
        }
 
        dev->sa[sa_idx] = priv;
+       dev->started++;
 
        cmd_len = buf_pos - buf;
        dma->cmdr[dma->cmdi].l = __cpu_to_le32(cmd_len | HIFN_D_VALID |
                        HIFN_D_LAST | HIFN_D_MASKDONEIRQ);
 
        if (++dma->cmdi == HIFN_D_CMD_RSIZE) {
-               dma->cmdr[dma->cmdi].l = __cpu_to_le32(HIFN_MAX_COMMAND |
+               dma->cmdr[dma->cmdi].l = __cpu_to_le32(
                        HIFN_D_VALID | HIFN_D_LAST |
                        HIFN_D_MASKDONEIRQ | HIFN_D_JUMP);
                dma->cmdi = 0;
@@ -1369,7 +1367,8 @@ static void hifn_setup_dst_desc(struct hifn_device *dev, struct page *page,
        }
 }
 
-static int hifn_setup_dma(struct hifn_device *dev, struct hifn_context *ctx,
+static int hifn_setup_dma(struct hifn_device *dev,
+               struct hifn_context *ctx, struct hifn_request_context *rctx,
                struct scatterlist *src, struct scatterlist *dst,
                unsigned int nbytes, void *priv)
 {
@@ -1378,38 +1377,42 @@ static int hifn_setup_dma(struct hifn_device *dev, struct hifn_context *ctx,
        unsigned int soff, doff;
        unsigned int n, len;
 
-       t = &ctx->walk.cache[0];
        n = nbytes;
        while (n) {
-               if (t->length) {
-                       spage = dpage = sg_page(t);
-                       soff = doff = 0;
+               spage = sg_page(src);
+               soff = src->offset;
+               len = min(src->length, n);
+
+               hifn_setup_src_desc(dev, spage, soff, len, n - len == 0);
+
+               src++;
+               n -= len;
+       }
+
+       t = &rctx->walk.cache[0];
+       n = nbytes;
+       while (n) {
+               if (t->length && rctx->walk.flags & ASYNC_FLAGS_MISALIGNED) {
+                       BUG_ON(!sg_page(t));
+                       dpage = sg_page(t);
+                       doff = 0;
                        len = t->length;
                } else {
-                       spage = sg_page(src);
-                       soff = src->offset;
-
+                       BUG_ON(!sg_page(dst));
                        dpage = sg_page(dst);
                        doff = dst->offset;
-
                        len = dst->length;
                }
                len = min(len, n);
 
-               dprintk("%s: spage: %p, soffset: %u, dpage: %p, doffset: %u, "
-                       "nbytes: %u, priv: %p, ctx: %p.\n",
-                       dev->name, spage, soff, dpage, doff, nbytes, priv, ctx);
-
-               hifn_setup_src_desc(dev, spage, soff, len, n - len == 0);
                hifn_setup_dst_desc(dev, dpage, doff, len, n - len == 0);
 
-               src++;
                dst++;
                t++;
                n -= len;
        }
 
-       hifn_setup_cmd_desc(dev, ctx, priv, nbytes);
+       hifn_setup_cmd_desc(dev, ctx, rctx, priv, nbytes);
        hifn_setup_res_desc(dev);
        return 0;
 }
@@ -1454,32 +1457,26 @@ static void ablkcipher_walk_exit(struct ablkcipher_walk *w)
        w->num = 0;
 }
 
-static int ablkcipher_add(void *daddr, unsigned int *drestp, struct scatterlist *src,
+static int ablkcipher_add(unsigned int *drestp, struct scatterlist *dst,
                unsigned int size, unsigned int *nbytesp)
 {
        unsigned int copy, drest = *drestp, nbytes = *nbytesp;
        int idx = 0;
-       void *saddr;
 
        if (drest < size || size > nbytes)
                return -EINVAL;
 
        while (size) {
-               copy = min(drest, min(size, src->length));
-
-               saddr = kmap_atomic(sg_page(src), KM_SOFTIRQ1);
-               memcpy(daddr, saddr + src->offset, copy);
-               kunmap_atomic(saddr, KM_SOFTIRQ1);
+               copy = min(drest, min(size, dst->length));
 
                size -= copy;
                drest -= copy;
                nbytes -= copy;
-               daddr += copy;
 
                dprintk("%s: copy: %u, size: %u, drest: %u, nbytes: %u.\n",
                                __func__, copy, size, drest, nbytes);
 
-               src++;
+               dst++;
                idx++;
        }
 
@@ -1492,8 +1489,7 @@ static int ablkcipher_add(void *daddr, unsigned int *drestp, struct scatterlist
 static int ablkcipher_walk(struct ablkcipher_request *req,
                struct ablkcipher_walk *w)
 {
-       struct scatterlist *src, *dst, *t;
-       void *daddr;
+       struct scatterlist *dst, *t;
        unsigned int nbytes = req->nbytes, offset, copy, diff;
        int idx, tidx, err;
 
@@ -1503,26 +1499,22 @@ static int ablkcipher_walk(struct ablkcipher_request *req,
                if (idx >= w->num && (w->flags & ASYNC_FLAGS_MISALIGNED))
                        return -EINVAL;
 
-               src = &req->src[idx];
                dst = &req->dst[idx];
 
-               dprintk("\n%s: slen: %u, dlen: %u, soff: %u, doff: %u, offset: %u, "
-                               "nbytes: %u.\n",
-                               __func__, src->length, dst->length, src->offset,
-                               dst->offset, offset, nbytes);
+               dprintk("\n%s: dlen: %u, doff: %u, offset: %u, nbytes: %u.\n",
+                       __func__, dst->length, dst->offset, offset, nbytes);
 
                if (!IS_ALIGNED(dst->offset, HIFN_D_DST_DALIGN) ||
                    !IS_ALIGNED(dst->length, HIFN_D_DST_DALIGN) ||
                    offset) {
-                       unsigned slen = min(src->length - offset, nbytes);
+                       unsigned slen = min(dst->length - offset, nbytes);
                        unsigned dlen = PAGE_SIZE;
 
                        t = &w->cache[idx];
 
-                       daddr = kmap_atomic(sg_page(t), KM_SOFTIRQ0);
-                       err = ablkcipher_add(daddr, &dlen, src, slen, &nbytes);
+                       err = ablkcipher_add(&dlen, dst, slen, &nbytes);
                        if (err < 0)
-                               goto err_out_unmap;
+                               return err;
 
                        idx += err;
 
@@ -1558,21 +1550,19 @@ static int ablkcipher_walk(struct ablkcipher_request *req,
                        } else {
                                copy += diff + nbytes;
 
-                               src = &req->src[idx];
+                               dst = &req->dst[idx];
 
-                               err = ablkcipher_add(daddr + slen, &dlen, src, nbytes, &nbytes);
+                               err = ablkcipher_add(&dlen, dst, nbytes, &nbytes);
                                if (err < 0)
-                                       goto err_out_unmap;
+                                       return err;
 
                                idx += err;
                        }
 
                        t->length = copy;
                        t->offset = offset;
-
-                       kunmap_atomic(daddr, KM_SOFTIRQ0);
                } else {
-                       nbytes -= min(src->length, nbytes);
+                       nbytes -= min(dst->length, nbytes);
                        idx++;
                }
 
@@ -1580,25 +1570,22 @@ static int ablkcipher_walk(struct ablkcipher_request *req,
        }
 
        return tidx;
-
-err_out_unmap:
-       kunmap_atomic(daddr, KM_SOFTIRQ0);
-       return err;
 }
 
 static int hifn_setup_session(struct ablkcipher_request *req)
 {
        struct hifn_context *ctx = crypto_tfm_ctx(req->base.tfm);
+       struct hifn_request_context *rctx = ablkcipher_request_ctx(req);
        struct hifn_device *dev = ctx->dev;
        unsigned long dlen, flags;
        unsigned int nbytes = req->nbytes, idx = 0;
        int err = -EINVAL, sg_num;
        struct scatterlist *dst;
 
-       if (ctx->iv && !ctx->ivsize && ctx->mode != ACRYPTO_MODE_ECB)
+       if (rctx->iv && !rctx->ivsize && rctx->mode != ACRYPTO_MODE_ECB)
                goto err_out_exit;
 
-       ctx->walk.flags = 0;
+       rctx->walk.flags = 0;
 
        while (nbytes) {
                dst = &req->dst[idx];
@@ -1606,19 +1593,19 @@ static int hifn_setup_session(struct ablkcipher_request *req)
 
                if (!IS_ALIGNED(dst->offset, HIFN_D_DST_DALIGN) ||
                    !IS_ALIGNED(dlen, HIFN_D_DST_DALIGN))
-                       ctx->walk.flags |= ASYNC_FLAGS_MISALIGNED;
+                       rctx->walk.flags |= ASYNC_FLAGS_MISALIGNED;
 
                nbytes -= dlen;
                idx++;
        }
 
-       if (ctx->walk.flags & ASYNC_FLAGS_MISALIGNED) {
-               err = ablkcipher_walk_init(&ctx->walk, idx, GFP_ATOMIC);
+       if (rctx->walk.flags & ASYNC_FLAGS_MISALIGNED) {
+               err = ablkcipher_walk_init(&rctx->walk, idx, GFP_ATOMIC);
                if (err < 0)
                        return err;
        }
 
-       sg_num = ablkcipher_walk(req, &ctx->walk);
+       sg_num = ablkcipher_walk(req, &rctx->walk);
        if (sg_num < 0) {
                err = sg_num;
                goto err_out_exit;
@@ -1630,13 +1617,12 @@ static int hifn_setup_session(struct ablkcipher_request *req)
                goto err_out;
        }
 
-       dev->snum++;
-       dev->started++;
-
-       err = hifn_setup_dma(dev, ctx, req->src, req->dst, req->nbytes, req);
+       err = hifn_setup_dma(dev, ctx, rctx, req->src, req->dst, req->nbytes, req);
        if (err)
                goto err_out;
 
+       dev->snum++;
+
        dev->active = HIFN_DEFAULT_ACTIVE_NUM;
        spin_unlock_irqrestore(&dev->lock, flags);
 
@@ -1645,12 +1631,13 @@ static int hifn_setup_session(struct ablkcipher_request *req)
 err_out:
        spin_unlock_irqrestore(&dev->lock, flags);
 err_out_exit:
-       if (err)
-               dprintk("%s: iv: %p [%d], key: %p [%d], mode: %u, op: %u, "
+       if (err) {
+               printk("%s: iv: %p [%d], key: %p [%d], mode: %u, op: %u, "
                                "type: %u, err: %d.\n",
-                       dev->name, ctx->iv, ctx->ivsize,
+                       dev->name, rctx->iv, rctx->ivsize,
                        ctx->key, ctx->keysize,
-                       ctx->mode, ctx->op, ctx->type, err);
+                       rctx->mode, rctx->op, rctx->type, err);
+       }
 
        return err;
 }
@@ -1660,6 +1647,7 @@ static int hifn_test(struct hifn_device *dev, int encdec, u8 snum)
        int n, err;
        u8 src[16];
        struct hifn_context ctx;
+       struct hifn_request_context rctx;
        u8 fips_aes_ecb_from_zero[16] = {
                0x66, 0xE9, 0x4B, 0xD4,
                0xEF, 0x8A, 0x2C, 0x3B,
@@ -1672,19 +1660,20 @@ static int hifn_test(struct hifn_device *dev, int encdec, u8 snum)
 
        ctx.dev = dev;
        ctx.keysize = 16;
-       ctx.ivsize = 0;
-       ctx.iv = NULL;
-       ctx.op = (encdec)?ACRYPTO_OP_ENCRYPT:ACRYPTO_OP_DECRYPT;
-       ctx.mode = ACRYPTO_MODE_ECB;
-       ctx.type = ACRYPTO_TYPE_AES_128;
-       ctx.walk.cache[0].length = 0;
+       rctx.ivsize = 0;
+       rctx.iv = NULL;
+       rctx.op = (encdec)?ACRYPTO_OP_ENCRYPT:ACRYPTO_OP_DECRYPT;
+       rctx.mode = ACRYPTO_MODE_ECB;
+       rctx.type = ACRYPTO_TYPE_AES_128;
+       rctx.walk.cache[0].length = 0;
 
        sg_init_one(&sg, &src, sizeof(src));
 
-       err = hifn_setup_dma(dev, &ctx, &sg, &sg, sizeof(src), NULL);
+       err = hifn_setup_dma(dev, &ctx, &rctx, &sg, &sg, sizeof(src), NULL);
        if (err)
                goto err_out;
 
+       dev->started = 0;
        msleep(200);
 
        dprintk("%s: decoded: ", dev->name);
@@ -1711,6 +1700,7 @@ static int hifn_start_device(struct hifn_device *dev)
 {
        int err;
 
+       dev->started = dev->active = 0;
        hifn_reset_dma(dev, 1);
 
        err = hifn_enable_crypto(dev);
@@ -1764,27 +1754,31 @@ static int ablkcipher_get(void *saddr, unsigned int *srestp, unsigned int offset
        return idx;
 }
 
-static void hifn_process_ready(struct ablkcipher_request *req, int error)
+static inline void hifn_complete_sa(struct hifn_device *dev, int i)
 {
-       struct hifn_context *ctx = crypto_tfm_ctx(req->base.tfm);
-       struct hifn_device *dev;
-
-       dprintk("%s: req: %p, ctx: %p.\n", __func__, req, ctx);
+       unsigned long flags;
 
-       dev = ctx->dev;
-       dprintk("%s: req: %p, started: %d.\n", __func__, req, dev->started);
+       spin_lock_irqsave(&dev->lock, flags);
+       dev->sa[i] = NULL;
+       dev->started--;
+       if (dev->started < 0)
+               printk("%s: started: %d.\n", __func__, dev->started);
+       spin_unlock_irqrestore(&dev->lock, flags);
+       BUG_ON(dev->started < 0);
+}
 
-       if (--dev->started < 0)
-               BUG();
+static void hifn_process_ready(struct ablkcipher_request *req, int error)
+{
+       struct hifn_request_context *rctx = ablkcipher_request_ctx(req);
 
-       if (ctx->walk.flags & ASYNC_FLAGS_MISALIGNED) {
+       if (rctx->walk.flags & ASYNC_FLAGS_MISALIGNED) {
                unsigned int nbytes = req->nbytes;
                int idx = 0, err;
                struct scatterlist *dst, *t;
                void *saddr;
 
                while (nbytes) {
-                       t = &ctx->walk.cache[idx];
+                       t = &rctx->walk.cache[idx];
                        dst = &req->dst[idx];
 
                        dprintk("\n%s: sg_page(t): %p, t->length: %u, "
@@ -1799,52 +1793,26 @@ static void hifn_process_ready(struct ablkcipher_request *req, int error)
                                continue;
                        }
 
-                       saddr = kmap_atomic(sg_page(t), KM_IRQ1);
+                       saddr = kmap_atomic(sg_page(t), KM_SOFTIRQ0);
 
                        err = ablkcipher_get(saddr, &t->length, t->offset,
                                        dst, nbytes, &nbytes);
                        if (err < 0) {
-                               kunmap_atomic(saddr, KM_IRQ1);
+                               kunmap_atomic(saddr, KM_SOFTIRQ0);
                                break;
                        }
 
                        idx += err;
-                       kunmap_atomic(saddr, KM_IRQ1);
+                       kunmap_atomic(saddr, KM_SOFTIRQ0);
                }
 
-               ablkcipher_walk_exit(&ctx->walk);
+               ablkcipher_walk_exit(&rctx->walk);
        }
 
        req->base.complete(&req->base, error);
 }
 
-static void hifn_check_for_completion(struct hifn_device *dev, int error)
-{
-       int i;
-       struct hifn_dma *dma = (struct hifn_dma *)dev->desc_virt;
-
-       for (i=0; i<HIFN_D_RES_RSIZE; ++i) {
-               struct hifn_desc *d = &dma->resr[i];
-
-               if (!(d->l & __cpu_to_le32(HIFN_D_VALID)) && dev->sa[i]) {
-                       dev->success++;
-                       dev->reset = 0;
-                       hifn_process_ready(dev->sa[i], error);
-                       dev->sa[i] = NULL;
-               }
-
-               if (d->l & __cpu_to_le32(HIFN_D_DESTOVER | HIFN_D_OVER))
-                       if (printk_ratelimit())
-                               printk("%s: overflow detected [d: %u, o: %u] "
-                                               "at %d resr: l: %08x, p: %08x.\n",
-                                       dev->name,
-                                       !!(d->l & __cpu_to_le32(HIFN_D_DESTOVER)),
-                                       !!(d->l & __cpu_to_le32(HIFN_D_OVER)),
-                                       i, d->l, d->p);
-       }
-}
-
-static void hifn_clear_rings(struct hifn_device *dev)
+static void hifn_clear_rings(struct hifn_device *dev, int error)
 {
        struct hifn_dma *dma = (struct hifn_dma *)dev->desc_virt;
        int i, u;
@@ -1861,21 +1829,26 @@ static void hifn_clear_rings(struct hifn_device *dev)
                if (dma->resr[i].l & __cpu_to_le32(HIFN_D_VALID))
                        break;
 
-               if (i != HIFN_D_RES_RSIZE)
-                       u--;
+               if (dev->sa[i]) {
+                       dev->success++;
+                       dev->reset = 0;
+                       hifn_process_ready(dev->sa[i], error);
+                       hifn_complete_sa(dev, i);
+               }
 
-               if (++i == (HIFN_D_RES_RSIZE + 1))
+               if (++i == HIFN_D_RES_RSIZE)
                        i = 0;
+               u--;
        }
        dma->resk = i; dma->resu = u;
 
        i = dma->srck; u = dma->srcu;
        while (u != 0) {
-               if (i == HIFN_D_SRC_RSIZE)
-                       i = 0;
                if (dma->srcr[i].l & __cpu_to_le32(HIFN_D_VALID))
                        break;
-               i++, u--;
+               if (++i == HIFN_D_SRC_RSIZE)
+                       i = 0;
+               u--;
        }
        dma->srck = i; dma->srcu = u;
 
@@ -1883,20 +1856,19 @@ static void hifn_clear_rings(struct hifn_device *dev)
        while (u != 0) {
                if (dma->cmdr[i].l & __cpu_to_le32(HIFN_D_VALID))
                        break;
-               if (i != HIFN_D_CMD_RSIZE)
-                       u--;
-               if (++i == (HIFN_D_CMD_RSIZE + 1))
+               if (++i == HIFN_D_CMD_RSIZE)
                        i = 0;
+               u--;
        }
        dma->cmdk = i; dma->cmdu = u;
 
        i = dma->dstk; u = dma->dstu;
        while (u != 0) {
-               if (i == HIFN_D_DST_RSIZE)
-                       i = 0;
                if (dma->dstr[i].l & __cpu_to_le32(HIFN_D_VALID))
                        break;
-               i++, u--;
+               if (++i == HIFN_D_DST_RSIZE)
+                       i = 0;
+               u--;
        }
        dma->dstk = i; dma->dstu = u;
 
@@ -1910,7 +1882,7 @@ static void hifn_clear_rings(struct hifn_device *dev)
 
 static void hifn_work(struct work_struct *work)
 {
-       struct delayed_work *dw = container_of(work, struct delayed_work, work);
+       struct delayed_work *dw = to_delayed_work(work);
        struct hifn_device *dev = container_of(dw, struct hifn_device, work);
        unsigned long flags;
        int reset = 0;
@@ -1941,30 +1913,39 @@ static void hifn_work(struct work_struct *work)
        } else
                dev->active--;
 
-       if (dev->prev_success == dev->success && dev->started)
+       if ((dev->prev_success == dev->success) && dev->started)
                reset = 1;
        dev->prev_success = dev->success;
        spin_unlock_irqrestore(&dev->lock, flags);
 
        if (reset) {
-               dprintk("%s: r: %08x, active: %d, started: %d, "
-                               "success: %lu: reset: %d.\n",
-                       dev->name, r, dev->active, dev->started,
-                       dev->success, reset);
-
                if (++dev->reset >= 5) {
-                       dprintk("%s: really hard reset.\n", dev->name);
+                       int i;
+                       struct hifn_dma *dma = (struct hifn_dma *)dev->desc_virt;
+
+                       printk("%s: r: %08x, active: %d, started: %d, "
+                               "success: %lu: qlen: %u/%u, reset: %d.\n",
+                               dev->name, r, dev->active, dev->started,
+                               dev->success, dev->queue.qlen, dev->queue.max_qlen,
+                               reset);
+
+                       printk("%s: res: ", __func__);
+                       for (i=0; i<HIFN_D_RES_RSIZE; ++i) {
+                               printk("%x.%p ", dma->resr[i].l, dev->sa[i]);
+                               if (dev->sa[i]) {
+                                       hifn_process_ready(dev->sa[i], -ENODEV);
+                                       hifn_complete_sa(dev, i);
+                               }
+                       }
+                       printk("\n");
+
                        hifn_reset_dma(dev, 1);
                        hifn_stop_device(dev);
                        hifn_start_device(dev);
                        dev->reset = 0;
                }
 
-               spin_lock_irqsave(&dev->lock, flags);
-               hifn_check_for_completion(dev, -EBUSY);
-               hifn_clear_rings(dev);
-               dev->started = 0;
-               spin_unlock_irqrestore(&dev->lock, flags);
+               tasklet_schedule(&dev->tasklet);
        }
 
        schedule_delayed_work(&dev->work, HZ);
@@ -1981,8 +1962,8 @@ static irqreturn_t hifn_interrupt(int irq, void *data)
        dprintk("%s: 1 dmacsr: %08x, dmareg: %08x, res: %08x [%d], "
                        "i: %d.%d.%d.%d, u: %d.%d.%d.%d.\n",
                dev->name, dmacsr, dev->dmareg, dmacsr & dev->dmareg, dma->cmdi,
-               dma->cmdu, dma->srcu, dma->dstu, dma->resu,
-               dma->cmdi, dma->srci, dma->dsti, dma->resi);
+               dma->cmdi, dma->srci, dma->dsti, dma->resi,
+               dma->cmdu, dma->srcu, dma->dstu, dma->resu);
 
        if ((dmacsr & dev->dmareg) == 0)
                return IRQ_NONE;
@@ -1999,11 +1980,10 @@ static irqreturn_t hifn_interrupt(int irq, void *data)
        if (restart) {
                u32 puisr = hifn_read_0(dev, HIFN_0_PUISR);
 
-               if (printk_ratelimit())
-                       printk("%s: overflow: r: %d, d: %d, puisr: %08x, d: %u.\n",
-                               dev->name, !!(dmacsr & HIFN_DMACSR_R_OVER),
-                               !!(dmacsr & HIFN_DMACSR_D_OVER),
-                               puisr, !!(puisr & HIFN_PUISR_DSTOVER));
+               printk(KERN_WARNING "%s: overflow: r: %d, d: %d, puisr: %08x, d: %u.\n",
+                       dev->name, !!(dmacsr & HIFN_DMACSR_R_OVER),
+                       !!(dmacsr & HIFN_DMACSR_D_OVER),
+                       puisr, !!(puisr & HIFN_PUISR_DSTOVER));
                if (!!(puisr & HIFN_PUISR_DSTOVER))
                        hifn_write_0(dev, HIFN_0_PUISR, HIFN_PUISR_DSTOVER);
                hifn_write_1(dev, HIFN_1_DMA_CSR, dmacsr & (HIFN_DMACSR_R_OVER |
@@ -2013,12 +1993,11 @@ static irqreturn_t hifn_interrupt(int irq, void *data)
        restart = dmacsr & (HIFN_DMACSR_C_ABORT | HIFN_DMACSR_S_ABORT |
                        HIFN_DMACSR_D_ABORT | HIFN_DMACSR_R_ABORT);
        if (restart) {
-               if (printk_ratelimit())
-                       printk("%s: abort: c: %d, s: %d, d: %d, r: %d.\n",
-                               dev->name, !!(dmacsr & HIFN_DMACSR_C_ABORT),
-                               !!(dmacsr & HIFN_DMACSR_S_ABORT),
-                               !!(dmacsr & HIFN_DMACSR_D_ABORT),
-                               !!(dmacsr & HIFN_DMACSR_R_ABORT));
+               printk(KERN_WARNING "%s: abort: c: %d, s: %d, d: %d, r: %d.\n",
+                       dev->name, !!(dmacsr & HIFN_DMACSR_C_ABORT),
+                       !!(dmacsr & HIFN_DMACSR_S_ABORT),
+                       !!(dmacsr & HIFN_DMACSR_D_ABORT),
+                       !!(dmacsr & HIFN_DMACSR_R_ABORT));
                hifn_reset_dma(dev, 1);
                hifn_init_dma(dev);
                hifn_init_registers(dev);
@@ -2031,7 +2010,6 @@ static irqreturn_t hifn_interrupt(int irq, void *data)
        }
 
        tasklet_schedule(&dev->tasklet);
-       hifn_clear_rings(dev);
 
        return IRQ_HANDLED;
 }
@@ -2045,21 +2023,25 @@ static void hifn_flush(struct hifn_device *dev)
        struct hifn_dma *dma = (struct hifn_dma *)dev->desc_virt;
        int i;
 
-       spin_lock_irqsave(&dev->lock, flags);
        for (i=0; i<HIFN_D_RES_RSIZE; ++i) {
                struct hifn_desc *d = &dma->resr[i];
 
                if (dev->sa[i]) {
                        hifn_process_ready(dev->sa[i],
                                (d->l & __cpu_to_le32(HIFN_D_VALID))?-ENODEV:0);
+                       hifn_complete_sa(dev, i);
                }
        }
 
+       spin_lock_irqsave(&dev->lock, flags);
        while ((async_req = crypto_dequeue_request(&dev->queue))) {
                ctx = crypto_tfm_ctx(async_req->tfm);
                req = container_of(async_req, struct ablkcipher_request, base);
+               spin_unlock_irqrestore(&dev->lock, flags);
 
                hifn_process_ready(req, -ENODEV);
+
+               spin_lock_irqsave(&dev->lock, flags);
        }
        spin_unlock_irqrestore(&dev->lock, flags);
 }
@@ -2118,6 +2100,7 @@ static int hifn_setup_crypto_req(struct ablkcipher_request *req, u8 op,
                u8 type, u8 mode)
 {
        struct hifn_context *ctx = crypto_tfm_ctx(req->base.tfm);
+       struct hifn_request_context *rctx = ablkcipher_request_ctx(req);
        unsigned ivsize;
 
        ivsize = crypto_ablkcipher_ivsize(crypto_ablkcipher_reqtfm(req));
@@ -2138,11 +2121,11 @@ static int hifn_setup_crypto_req(struct ablkcipher_request *req, u8 op,
                        type = ACRYPTO_TYPE_AES_256;
        }
 
-       ctx->op = op;
-       ctx->mode = mode;
-       ctx->type = type;
-       ctx->iv = req->info;
-       ctx->ivsize = ivsize;
+       rctx->op = op;
+       rctx->mode = mode;
+       rctx->type = type;
+       rctx->iv = req->info;
+       rctx->ivsize = ivsize;
 
        /*
         * HEAVY TODO: needs to kick Herbert XU to write documentation.
@@ -2155,7 +2138,7 @@ static int hifn_setup_crypto_req(struct ablkcipher_request *req, u8 op,
 
 static int hifn_process_queue(struct hifn_device *dev)
 {
-       struct crypto_async_request *async_req;
+       struct crypto_async_request *async_req, *backlog;
        struct hifn_context *ctx;
        struct ablkcipher_request *req;
        unsigned long flags;
@@ -2163,12 +2146,16 @@ static int hifn_process_queue(struct hifn_device *dev)
 
        while (dev->started < HIFN_QUEUE_LENGTH) {
                spin_lock_irqsave(&dev->lock, flags);
+               backlog = crypto_get_backlog(&dev->queue);
                async_req = crypto_dequeue_request(&dev->queue);
                spin_unlock_irqrestore(&dev->lock, flags);
 
                if (!async_req)
                        break;
 
+               if (backlog)
+                       backlog->complete(backlog, -EINPROGRESS);
+
                ctx = crypto_tfm_ctx(async_req->tfm);
                req = container_of(async_req, struct ablkcipher_request, base);
 
@@ -2493,7 +2480,7 @@ static int hifn_cra_init(struct crypto_tfm *tfm)
        struct hifn_context *ctx = crypto_tfm_ctx(tfm);
 
        ctx->dev = ha->dev;
-
+       tfm->crt_ablkcipher.reqsize = sizeof(struct hifn_request_context);
        return 0;
 }
 
@@ -2571,10 +2558,13 @@ static void hifn_tasklet_callback(unsigned long data)
         * (like dev->success), but they are used in process
         * context or update is atomic (like setting dev->sa[i] to NULL).
         */
-       hifn_check_for_completion(dev, 0);
+       hifn_clear_rings(dev, 0);
+
+       if (dev->started < HIFN_QUEUE_LENGTH && dev->queue.qlen)
+               hifn_process_queue(dev);
 }
 
-static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
+static int __devinit hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
        int err, i;
        struct hifn_device *dev;
@@ -2585,7 +2575,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                return err;
        pci_set_master(pdev);
 
-       err = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
+       err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
        if (err)
                goto err_out_disable_pci_device;
 
@@ -2628,22 +2618,11 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                        goto err_out_unmap_bars;
        }
 
-       dev->result_mem = __get_free_pages(GFP_KERNEL, HIFN_MAX_RESULT_ORDER);
-       if (!dev->result_mem) {
-               dprintk("Failed to allocate %d pages for result_mem.\n",
-                               HIFN_MAX_RESULT_ORDER);
-               goto err_out_unmap_bars;
-       }
-       memset((void *)dev->result_mem, 0, PAGE_SIZE*(1<<HIFN_MAX_RESULT_ORDER));
-
-       dev->dst = pci_map_single(pdev, (void *)dev->result_mem,
-                       PAGE_SIZE << HIFN_MAX_RESULT_ORDER, PCI_DMA_FROMDEVICE);
-
        dev->desc_virt = pci_alloc_consistent(pdev, sizeof(struct hifn_dma),
                        &dev->desc_dma);
        if (!dev->desc_virt) {
                dprintk("Failed to allocate descriptor rings.\n");
-               goto err_out_free_result_pages;
+               goto err_out_unmap_bars;
        }
        memset(dev->desc_virt, 0, sizeof(struct hifn_dma));
 
@@ -2703,11 +2682,6 @@ err_out_free_desc:
        pci_free_consistent(pdev, sizeof(struct hifn_dma),
                        dev->desc_virt, dev->desc_dma);
 
-err_out_free_result_pages:
-       pci_unmap_single(pdev, dev->dst, PAGE_SIZE << HIFN_MAX_RESULT_ORDER,
-                       PCI_DMA_FROMDEVICE);
-       free_pages(dev->result_mem, HIFN_MAX_RESULT_ORDER);
-
 err_out_unmap_bars:
        for (i=0; i<3; ++i)
                if (dev->bar[i])
@@ -2722,7 +2696,7 @@ err_out_disable_pci_device:
        return err;
 }
 
-static void hifn_remove(struct pci_dev *pdev)
+static void __devexit hifn_remove(struct pci_dev *pdev)
 {
        int i;
        struct hifn_device *dev;
@@ -2745,10 +2719,6 @@ static void hifn_remove(struct pci_dev *pdev)
 
                pci_free_consistent(pdev, sizeof(struct hifn_dma),
                                dev->desc_virt, dev->desc_dma);
-               pci_unmap_single(pdev, dev->dst,
-                               PAGE_SIZE << HIFN_MAX_RESULT_ORDER,
-                               PCI_DMA_FROMDEVICE);
-               free_pages(dev->result_mem, HIFN_MAX_RESULT_ORDER);
                for (i=0; i<3; ++i)
                        if (dev->bar[i])
                                iounmap(dev->bar[i]);
@@ -2774,7 +2744,7 @@ static struct pci_driver hifn_pci_driver = {
        .remove   = __devexit_p(hifn_remove),
 };
 
-static int __devinit hifn_init(void)
+static int __init hifn_init(void)
 {
        unsigned int freq;
        int err;
@@ -2819,7 +2789,7 @@ static int __devinit hifn_init(void)
        return 0;
 }
 
-static void __devexit hifn_fini(void)
+static void __exit hifn_fini(void)
 {
        pci_unregister_driver(&hifn_pci_driver);