Staging: agnx: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Fri, 19 Dec 2008 17:11:01 +0000 (18:11 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 3 Apr 2009 21:53:26 +0000 (14:53 -0700)
commit6bf676723ab2a6ade05feb2cd0b5073930f72d7e
tree941a69d1674dc486e5f01ee4b3b16da6b2e0b1d9
parent4ed4f41c1b13873f4b8afd4fbe00eb8c3907bc4a
Staging: agnx: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/agnx/pci.c