From: Andre Detsch Date: Tue, 30 Jun 2009 12:46:13 +0000 (+0000) Subject: e1000: return PCI_ERS_RESULT_DISCONNECT on permanent error X-Git-Tag: v2.6.31-rc2~26^2~3 X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=eab633021c26025b34f36f79f0311d3d99f40ceb;p=safe%2Fjmp%2Flinux-2.6 e1000: return PCI_ERS_RESULT_DISCONNECT on permanent error PCI drivers that implement the io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is pci_channel_io_perm_failure. This state is not checked in many of the network drivers. The patch fixes the omission in the e1000 driver. Based on Mike Mason's similar patch for e1000e. Signed-off-by: Andre Detsch CC: Mike Mason Signed-off-by: Jeff Kirsher Signed-off-by: David S. Miller --- diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 972e06d..5b8cbdb 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -4823,6 +4823,9 @@ static pci_ers_result_t e1000_io_error_detected(struct pci_dev *pdev, netif_device_detach(netdev); + if (state == pci_channel_io_perm_failure) + return PCI_ERS_RESULT_DISCONNECT; + if (netif_running(netdev)) e1000_down(adapter); pci_disable_device(pdev);