From: Sebastian Ott Date: Thu, 26 Mar 2009 14:24:16 +0000 (+0100) Subject: [S390] cio: fix wrong buffer access in cio_ignore_write X-Git-Tag: v2.6.30-rc1~659^2~46 X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=94cbc203bee4ea87bd49ad56f6c5381bc10d8b6b;p=safe%2Fjmp%2Flinux-2.6 [S390] cio: fix wrong buffer access in cio_ignore_write Writing only spaces to /proc/cio_ignore will cause a buffer overflow since the size_t value i will not become negative and so buf[-1UL] is accessed. Change the value of i to ssize_t. Signed-off-by: Sebastian Ott Signed-off-by: Martin Schwidefsky --- diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c index fe00be3..6565f02 100644 --- a/drivers/s390/cio/blacklist.c +++ b/drivers/s390/cio/blacklist.c @@ -336,8 +336,7 @@ cio_ignore_write(struct file *file, const char __user *user_buf, size_t user_len, loff_t *offset) { char *buf; - size_t i; - ssize_t rc, ret; + ssize_t rc, ret, i; if (*offset) return -EINVAL;