From: Adrian Bunk <bunk@stusta.de>
Date: Wed, 1 Aug 2007 13:13:36 +0000 (-0300)
Subject: V4L/DVB (5965): Frontend_ioctl(): fix check-after-use
X-Git-Tag: v2.6.24-rc1~1463^2~262
X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=813ce47cee33964ff710d2c91063548773cb4cd5;p=safe%2Fjmp%2Flinux-2.6

V4L/DVB (5965): Frontend_ioctl(): fix check-after-use

The Coverity checker spotted that we have already oops'ed if "fe" was NULL.

Since "fe" being NULL seems impossible at this point this patch removes
the NULL check.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index afe797b..fd9bac5 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -748,7 +748,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
 
 	dprintk ("%s\n", __FUNCTION__);
 
-	if (!fe || fepriv->exit)
+	if (fepriv->exit)
 		return -ENODEV;
 
 	if ((file->f_flags & O_ACCMODE) == O_RDONLY &&