From: Rini van Zetten Date: Fri, 27 Feb 2009 11:18:48 +0000 (-0800) Subject: gianfar: Do right check on num_txbdfree X-Git-Tag: v2.6.29-rc7~13^2~11 X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=7958a45310519811134a5b911d863201786978ab;p=safe%2Fjmp%2Flinux-2.6 gianfar: Do right check on num_txbdfree This patch fixes a wrong check on num_txbdfree. It could lead to num_txbdfree become nagative. Result was that the gianfar stops sending data. Changes from first version : - removed a space between parens (David Millers comment) - full email address in signed off line Signed-off-by: Rini van Zetten Acked-by: Andy Fleming Signed-off-by: David S. Miller --- diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 9b12a13..9831b3f 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1284,7 +1284,7 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock_irqsave(&priv->txlock, flags); /* check if there is space to queue this packet */ - if (nr_frags > priv->num_txbdfree) { + if ((nr_frags+1) > priv->num_txbdfree) { /* no space, stop the queue */ netif_stop_queue(dev); dev->stats.tx_fifo_errors++;