From: Christian Borntraeger Date: Thu, 22 Jan 2009 13:20:27 +0000 (+0100) Subject: KVM: s390: Fix printk on SIGP set arch X-Git-Tag: v2.6.30-rc1~664^2~32 X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=2c411b48af3e3c534b9cfb6a79be1df384d1ca1a;p=safe%2Fjmp%2Flinux-2.6 KVM: s390: Fix printk on SIGP set arch KVM on s390 does not support the ESA/390 architecture. We refuse to change the architecture mode and print a warning. This patch removes the printk for several reasons: o A malicious guest can flood host dmesg o The old message had no newline o there is no connection between the message and the failing guest This patch simply removes the printk. We already set the condition code to 3 - the guest knows that something went wrong. Reported-by: Heiko Carstens Signed-off-by: Christian Borntraeger Signed-off-by: Avi Kivity --- diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c index 2a01b9e..f27dbed 100644 --- a/arch/s390/kvm/sigp.c +++ b/arch/s390/kvm/sigp.c @@ -153,8 +153,6 @@ static int __sigp_set_arch(struct kvm_vcpu *vcpu, u32 parameter) switch (parameter & 0xff) { case 0: - printk(KERN_WARNING "kvm: request to switch to ESA/390 mode" - " not supported"); rc = 3; /* not operational */ break; case 1: