From: Michael Ellerman Date: Thu, 16 Mar 2006 03:47:20 +0000 (+1100) Subject: [PATCH] powerpc: Fix bug in bug fix for bug in lmb_alloc() X-Git-Tag: v2.6.17-rc1~1117^2~28^2 X-Git-Url: http://ftp.safe.ca/?a=commitdiff_plain;h=2c276603c3e5ebf38155a9d1fbbda656d52d138e;p=safe%2Fjmp%2Flinux-2.6 [PATCH] powerpc: Fix bug in bug fix for bug in lmb_alloc() My patch (d7a5b2ffa1352f0310630934a56aecbdfb617b72) to always panic if lmb_alloc() fails is broken because it checks alloc < 0, but should be checking alloc == 0. Signed-off-by: Michael Ellerman Signed-off-by: Paul Mackerras --- diff --git a/arch/powerpc/mm/lmb.c b/arch/powerpc/mm/lmb.c index 874cd10..417d585 100644 --- a/arch/powerpc/mm/lmb.c +++ b/arch/powerpc/mm/lmb.c @@ -232,7 +232,7 @@ unsigned long __init lmb_alloc_base(unsigned long size, unsigned long align, alloc = __lmb_alloc_base(size, align, max_addr); - if (alloc < 0) + if (alloc == 0) panic("ERROR: Failed to allocate 0x%lx bytes below 0x%lx.\n", size, max_addr);