[ACPI] fix possible acpi thermal leak in failure path
authorDave Jones <davej@redhat.com>
Thu, 9 Mar 2006 03:12:00 +0000 (22:12 -0500)
committerLen Brown <len.brown@intel.com>
Fri, 31 Mar 2006 06:02:39 +0000 (01:02 -0500)
Coverity: #601

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/thermal.c

index 19f3ea4..d0b44ce 100644 (file)
@@ -942,8 +942,10 @@ acpi_thermal_write_trip_points(struct file *file,
        memset(limit_string, 0, ACPI_THERMAL_MAX_LIMIT_STR_LEN);
 
        active = kmalloc(ACPI_THERMAL_MAX_ACTIVE * sizeof(int), GFP_KERNEL);
-       if (!active)
+       if (!active) {
+               kfree(limit_string);
                return_VALUE(-ENOMEM);
+       }
 
        if (!tz || (count > ACPI_THERMAL_MAX_LIMIT_STR_LEN - 1)) {
                ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid argument\n"));