s390: use RCU to walk list of network devices
authorstephen hemminger <shemminger@vyatta.com>
Tue, 10 Nov 2009 07:54:52 +0000 (07:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Nov 2009 06:26:31 +0000 (22:26 -0800)
This is similar to other cases where for_each_netdev_rcu
can be used when gathering information.

By inspection, don't have platform or cross-build environment
to validate.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/s390/appldata/appldata_net_sum.c

index fa741f8..4ce7fa9 100644 (file)
@@ -83,8 +83,9 @@ static void appldata_get_net_sum_data(void *data)
        rx_dropped = 0;
        tx_dropped = 0;
        collisions = 0;
-       read_lock(&dev_base_lock);
-       for_each_netdev(&init_net, dev) {
+
+       rcu_read_lock();
+       for_each_netdev_rcu(&init_net, dev) {
                const struct net_device_stats *stats = dev_get_stats(dev);
 
                rx_packets += stats->rx_packets;
@@ -98,7 +99,8 @@ static void appldata_get_net_sum_data(void *data)
                collisions += stats->collisions;
                i++;
        }
-       read_unlock(&dev_base_lock);
+       rcu_read_unlock();
+
        net_data->nr_interfaces = i;
        net_data->rx_packets = rx_packets;
        net_data->tx_packets = tx_packets;