[SCSI] lpfc: don't dereference NULL
authorJiri Slaby <jirislaby@gmail.com>
Mon, 13 Jul 2009 21:25:54 +0000 (23:25 +0200)
committerJames Bottomley <James.Bottomley@suse.de>
Sat, 22 Aug 2009 22:51:55 +0000 (17:51 -0500)
When kzalloc fails in lpfc_hba_alloc, don't dereference the NULL by
lpfc_printf_log. Use dev_err instead.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-By: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/lpfc/lpfc_init.c

index fc67cc6..2452dc9 100644 (file)
@@ -4130,8 +4130,7 @@ lpfc_hba_alloc(struct pci_dev *pdev)
        /* Allocate memory for HBA structure */
        phba = kzalloc(sizeof(struct lpfc_hba), GFP_KERNEL);
        if (!phba) {
-               lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
-                               "1417 Failed to allocate hba struct.\n");
+               dev_err(&pdev->dev, "failed to allocate hba struct\n");
                return NULL;
        }