sony: fix rfkill code again
authorJohannes Berg <johannes@sipsolutions.net>
Thu, 11 Jun 2009 10:08:15 +0000 (12:08 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 15 Jun 2009 19:05:51 +0000 (15:05 -0400)
When the hard state changes, we shouldn't set the soft
state to blocked as well -- we have no such indication
from the device in that case so leave it untouched.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=13458.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/platform/x86/sony-laptop.c

index e48d9a4..dafaa4a 100644 (file)
@@ -1133,8 +1133,9 @@ static void sony_nc_rfkill_update()
                        continue;
 
                if (hwblock) {
-                       if (rfkill_set_hw_state(sony_rfkill_devices[i], true))
-                               sony_nc_rfkill_set((void *)i, true);
+                       if (rfkill_set_hw_state(sony_rfkill_devices[i], true)) {
+                               /* we already know we're blocked */
+                       }
                        continue;
                }