V4L/DVB: Fix test in copy_reg_bits()
authorRoel Kluin <roel.kluin@gmail.com>
Fri, 20 Nov 2009 18:34:13 +0000 (15:34 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 5 Dec 2009 20:41:45 +0000 (18:41 -0200)
The reg_pair2[j].reg was tested twice.

Cc: <stable@kernel.org>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/tuners/mxl5007t.c

index 2d02698..7eb1bf7 100644 (file)
@@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1,
        i = j = 0;
 
        while (reg_pair1[i].reg || reg_pair1[i].val) {
-               while (reg_pair2[j].reg || reg_pair2[j].reg) {
+               while (reg_pair2[j].reg || reg_pair2[j].val) {
                        if (reg_pair1[i].reg != reg_pair2[j].reg) {
                                j++;
                                continue;