[SCSI] hpsa: Use BUG_ON instead of an if statement.
authorStephen M. Cameron <scameron@beardog.cce.hp.com>
Thu, 4 Feb 2010 14:41:44 +0000 (08:41 -0600)
committerJames Bottomley <James.Bottomley@suse.de>
Wed, 17 Feb 2010 19:17:22 +0000 (13:17 -0600)
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/hpsa.c

index ee9db5e..2c256e3 100644 (file)
@@ -628,8 +628,7 @@ static void hpsa_scsi_remove_entry(struct ctlr_info *h, int hostno, int entry,
        int i;
        struct hpsa_scsi_dev_t *sd;
 
-       if (entry < 0 || entry >= HPSA_MAX_SCSI_DEVS_PER_HBA)
-               BUG();
+       BUG_ON(entry < 0 || entry >= HPSA_MAX_SCSI_DEVS_PER_HBA);
 
        sd = h->dev[entry];
        removed[*nremoved] = h->dev[entry];