tracing: have TRACE_EVENT macro use __flags to not shadow parameter
authorSteven Rostedt <srostedt@redhat.com>
Mon, 14 Sep 2009 15:18:02 +0000 (11:18 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Mon, 14 Sep 2009 15:18:02 +0000 (11:18 -0400)
The generated functions of TRACE_EVENT uses "flags" in one of the
sub macros which shadows a parameter in the outside macro.

Simple fix is to make the submacro use __flags instead.

Discovered by sparse.

Reported-by: Jaswinder Singh Rajput <jaswinder@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
include/trace/ftrace.h

index fa8ce03..72a3b43 100644 (file)
@@ -239,9 +239,9 @@ ftrace_format_##call(struct ftrace_event_call *unused,                      \
 #undef __print_flags
 #define __print_flags(flag, delim, flag_array...)                      \
        ({                                                              \
-               static const struct trace_print_flags flags[] =         \
+               static const struct trace_print_flags __flags[] =       \
                        { flag_array, { -1, NULL }};                    \
-               ftrace_print_flags_seq(p, delim, flag, flags);          \
+               ftrace_print_flags_seq(p, delim, flag, __flags);        \
        })
 
 #undef __print_symbolic