V4L/DVB (7660): bsbe1: Use settings recommended by the manufacturer

Reworked the BSBE1 tuner support in bsbe1.h to follow
the ALPS-recommended parameters more closely.

Tested with BSBE1-based Activy cards and TT DVB-S rev 2.3.

Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

diff --git a/drivers/media/dvb/frontends/bsbe1.h b/drivers/media/dvb/frontends/bsbe1.h
index d8f6573..5e431eb 100644 (file)
--- a/drivers/media/dvb/frontends/bsbe1.h
+++ b/drivers/media/dvb/frontends/bsbe1.h
@@ -1,5 +1,5 @@
 /*
- * bsbe1.h - ALPS BSBE1 tuner support (moved from av7110.c)
+ * bsbe1.h - ALPS BSBE1 tuner support
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -26,44 +26,24 @@
 #define BSBE1_H
 
 static u8 alps_bsbe1_inittab[] = {
-       0x01, 0x15,
-       0x02, 0x30,
-       0x03, 0x00,
+       0x01, 0x15,   /* XTAL = 4MHz, VCO = 352 MHz */
+       0x02, 0x30,   /* MCLK = 88 MHz */
+       0x03, 0x00,   /* ACR output 0 */
        0x04, 0x7d,   /* F22FR = 0x7d, F22 = f_VCO / 128 / 0x7d = 22 kHz */
-       0x05, 0x35,   /* I2CT = 0, SCLT = 1, SDAT = 1 */
-       0x06, 0x40,   /* DAC not used, set to high impendance mode */
-       0x07, 0x00,   /* DAC LSB */
+       0x05, 0x05,   /* I2CT = 0, SCLT = 1, SDAT = 1 */
+       0x06, 0x00,   /* DAC output 0 */
        0x08, 0x40,   /* DiSEqC off, LNB power on OP2/LOCK pin on */
        0x09, 0x00,   /* FIFO */
-       0x0c, 0x51,   /* OP1 ctl = Normal, OP1 val = 1 (LNB Power ON) */
-       0x0d, 0x82,   /* DC offset compensation = ON, beta_agc1 = 2 */
-       0x0e, 0x23,   /* alpha_tmg = 2, beta_tmg = 3 */
-       0x10, 0x3f,   // AGC2  0x3d
-       0x11, 0x84,
-       0x12, 0xb9,
-       0x15, 0xc9,   // lock detector threshold
-       0x16, 0x00,
-       0x17, 0x00,
-       0x18, 0x00,
-       0x19, 0x00,
-       0x1a, 0x00,
-       0x1f, 0x50,
-       0x20, 0x00,
-       0x21, 0x00,
-       0x22, 0x00,
-       0x23, 0x00,
-       0x28, 0x00,  // out imp: normal  out type: parallel FEC mode:0
-       0x29, 0x1e,  // 1/2 threshold
-       0x2a, 0x14,  // 2/3 threshold
-       0x2b, 0x0f,  // 3/4 threshold
-       0x2c, 0x09,  // 5/6 threshold
-       0x2d, 0x05,  // 7/8 threshold
-       0x2e, 0x01,
-       0x31, 0x1f,  // test all FECs
-       0x32, 0x19,  // viterbi and synchro search
-       0x33, 0xfc,  // rs control
-       0x34, 0x93,  // error control
-       0x0f, 0x92,
+       0x0c, 0x51,   /* OP1/OP0 normal, val = 1 (LNB power on) */
+       0x0d, 0x82,   /* DC offset compensation = on, beta_agc1 = 2 */
+       0x0f, 0x92,   /* AGC1R */
+       0x10, 0x34,   /* AGC2O */
+       0x11, 0x84,   /* TLSR */
+       0x12, 0xb9,   /* CFD */
+       0x15, 0xc9,   /* lock detector threshold */
+       0x28, 0x00,   /* out imp: normal, type: parallel, FEC mode: QPSK */
+       0x33, 0xfc,   /* RS control */
+       0x34, 0x93,   /* count viterbi bit errors per 2E18 bytes */
        0xff, 0xff
 };
 
@@ -100,11 +80,11 @@ static int alps_bsbe1_tuner_set_params(struct dvb_frontend* fe, struct dvb_front
        if ((params->frequency < 950000) || (params->frequency > 2150000))
                return -EINVAL;
 
-       div = (params->frequency + (125 - 1)) / 125; // round correctly
+       div = params->frequency / 1000;
        data[0] = (div >> 8) & 0x7f;
        data[1] = div & 0xff;
-       data[2] = 0x80 | ((div & 0x18000) >> 10) | 4;
-       data[3] = (params->frequency > 1530000) ? 0xE0 : 0xE4;
+       data[2] = 0x80 | ((div & 0x18000) >> 10) | 0x1;
+       data[3] = 0xe0;
 
        if (fe->ops.i2c_gate_ctrl)
                fe->ops.i2c_gate_ctrl(fe, 1);