ahci: kill leftover from enabling NCQ over PMP
authorTejun Heo <htejun@gmail.com>
Tue, 9 Oct 2007 05:59:50 +0000 (14:59 +0900)
committerJeff Garzik <jeff@garzik.org>
Fri, 12 Oct 2007 18:55:46 +0000 (14:55 -0400)
ahci had problems with NCQ over PMP and NCQ used to be disabled while
PMP was attached.  After fixing the problem, the temporary NCQ
disabling code wasn't removed completely.  Kill the remaining piece.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/ahci.c

index 24fb90f..694eabc 100644 (file)
@@ -1677,19 +1677,11 @@ static void ahci_pmp_attach(struct ata_port *ap)
 static void ahci_pmp_detach(struct ata_port *ap)
 {
        void __iomem *port_mmio = ahci_port_base(ap);
-       struct ahci_host_priv *hpriv = ap->host->private_data;
-       unsigned long flags;
        u32 cmd;
 
        cmd = readl(port_mmio + PORT_CMD);
        cmd &= ~PORT_CMD_PMP;
        writel(cmd, port_mmio + PORT_CMD);
-
-       if (hpriv->cap & HOST_CAP_NCQ) {
-               spin_lock_irqsave(ap->lock, flags);
-               ap->flags |= ATA_FLAG_NCQ;
-               spin_unlock_irqrestore(ap->lock, flags);
-       }
 }
 
 static int ahci_pmp_read(struct ata_device *dev, int pmp, int reg, u32 *r_val)