ixgbe: Remove unneeded register writes in VF VLAN setup
authorGreg Rose <gregory.v.rose@intel.com>
Wed, 5 May 2010 19:57:10 +0000 (19:57 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 May 2010 07:31:43 +0000 (00:31 -0700)
The driver is unnecessarily writing values to VLAN control registers.
These writes already done elsewhere and are superfluous here.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ixgbe/ixgbe_sriov.c

index 221b2ca..c4e5150 100644 (file)
@@ -98,17 +98,6 @@ void ixgbe_restore_vf_multicasts(struct ixgbe_adapter *adapter)
 
 int ixgbe_set_vf_vlan(struct ixgbe_adapter *adapter, int add, int vid, u32 vf)
 {
-       u32 ctrl;
-
-       /* Check if global VLAN already set, if not set it */
-       ctrl = IXGBE_READ_REG(&adapter->hw, IXGBE_VLNCTRL);
-       if (!(ctrl & IXGBE_VLNCTRL_VFE)) {
-               /* enable VLAN tag insert/strip */
-               ctrl |= IXGBE_VLNCTRL_VFE;
-               ctrl &= ~IXGBE_VLNCTRL_CFIEN;
-               IXGBE_WRITE_REG(&adapter->hw, IXGBE_VLNCTRL, ctrl);
-       }
-
        return adapter->hw.mac.ops.set_vfta(&adapter->hw, vid, vf, (bool)add);
 }