x86/ioapic.c: convert replace_pin_at_irq_node to conventional for() loop
authorJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Mon, 8 Jun 2009 10:29:26 +0000 (03:29 -0700)
committerJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Tue, 14 Jul 2009 20:32:50 +0000 (13:32 -0700)
Use a conventional for() loop in replace_pin_at_irq_node().

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
arch/x86/kernel/apic/io_apic.c

index d9e8f19..9386976 100644 (file)
@@ -515,10 +515,10 @@ static void __init replace_pin_at_irq_node(struct irq_cfg *cfg, int node,
                                      int oldapic, int oldpin,
                                      int newapic, int newpin)
 {
-       struct irq_pin_list *entry = cfg->irq_2_pin;
+       struct irq_pin_list *entry;
        int replaced = 0;
 
-       while (entry) {
+       for (entry = cfg->irq_2_pin; entry != NULL; entry = entry->next) {
                if (entry->apic == oldapic && entry->pin == oldpin) {
                        entry->apic = newapic;
                        entry->pin = newpin;
@@ -526,7 +526,6 @@ static void __init replace_pin_at_irq_node(struct irq_cfg *cfg, int node,
                        /* every one is different, right? */
                        break;
                }
-               entry = entry->next;
        }
 
        /* why? call replace before add? */