IB/ucm: Use stack variable 'base' in ib_ucm_add_one
authorAlexander Chiang <achiang@hp.com>
Tue, 2 Feb 2010 19:09:00 +0000 (19:09 +0000)
committerRoland Dreier <rolandd@cisco.com>
Wed, 24 Feb 2010 18:23:47 +0000 (10:23 -0800)
This change is not useful by itself, but sets us up for a future
change that allows us to support more than IB_UCM_MAX_DEVICES.

Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/ucm.c

index 7ff3300..06c50d8 100644 (file)
@@ -1240,6 +1240,7 @@ static DEVICE_ATTR(ibdev, S_IRUGO, show_ibdev, NULL);
 static void ib_ucm_add_one(struct ib_device *device)
 {
        int devnum;
+       dev_t base;
        struct ib_ucm_device *ucm_dev;
 
        if (!device->alloc_ucontext ||
@@ -1257,12 +1258,13 @@ static void ib_ucm_add_one(struct ib_device *device)
                goto err;
 
        ucm_dev->devnum = devnum;
+       base = devnum + IB_UCM_BASE_DEV;
        set_bit(devnum, dev_map);
 
        cdev_init(&ucm_dev->cdev, &ucm_fops);
        ucm_dev->cdev.owner = THIS_MODULE;
        kobject_set_name(&ucm_dev->cdev.kobj, "ucm%d", ucm_dev->devnum);
-       if (cdev_add(&ucm_dev->cdev, IB_UCM_BASE_DEV + devnum, 1))
+       if (cdev_add(&ucm_dev->cdev, base, 1))
                goto err;
 
        ucm_dev->dev.class = &cm_class;