ide-tape: fix potential fs requests bug
authorBorislav Petkov <petkovbb@gmail.com>
Fri, 1 May 2009 18:29:53 +0000 (20:29 +0200)
committerBorislav Petkov <petkovbb@gmail.com>
Fri, 15 May 2009 04:43:45 +0000 (06:43 +0200)
ide-tape had a potential bug for fs requests when preparing the command
packet: it was writing the transfer length as a number of fixed blocks.
However, the block layer implies 512 byte blocks and ide-tape can have
other block sizes so account for that too.

ide-floppy does this calculation properly with the block size factor
(floppy->bs_factor).

Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
drivers/ide/ide-tape.c

index e166045..fc79cf4 100644 (file)
@@ -586,7 +586,7 @@ static void ide_tape_create_rw_cmd(idetape_tape_t *tape,
                                   struct ide_atapi_pc *pc, struct request *rq,
                                   u8 opcode)
 {
-       unsigned int length = blk_rq_sectors(rq);
+       unsigned int length = blk_rq_sectors(rq) / (tape->blk_size >> 9);
 
        ide_init_pc(pc);
        put_unaligned(cpu_to_be32(length), (unsigned int *) &pc->c[1]);