ksym_tracer: Report error when failed to re-register hbp
authorLi Zefan <lizf@cn.fujitsu.com>
Tue, 7 Jul 2009 05:54:28 +0000 (13:54 +0800)
committerIngo Molnar <mingo@elte.hu>
Fri, 10 Jul 2009 09:59:43 +0000 (11:59 +0200)
When access type is changed, the hw break point will be
unregistered and then be registered again with new access
type. But the registration may fail, in this case, -errno
should be returned.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <4A52E314.7070004@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/trace_ksym.c

index 8cbed5a..891e3b8 100644 (file)
@@ -302,13 +302,13 @@ static ssize_t ksym_trace_filter_write(struct file *file,
                                ret = count;
                                goto unlock_ret_path;
                        }
-               }
+               } else
+                       ret = count;
                ksym_filter_entry_count--;
                hlist_del_rcu(&(entry->ksym_hlist));
                synchronize_rcu();
                kfree(entry->ksym_hbp);
                kfree(entry);
-               ret = count;
                goto err_ret;
        } else {
                /* Check for malformed request: (4) */