nfs: remove superfluous BUG_ON()s
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 10 Aug 2009 12:54:16 +0000 (08:54 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 10 Aug 2009 12:54:16 +0000 (08:54 -0400)
commite576e05a73bc1a00cdf56630942dbada1bf280a1
treed32f477a91b01bcdbccc272be2ebaaef287421bb
parent38c73044f5f4da2ef4339319b170e5e19f8dec87
nfs: remove superfluous BUG_ON()s
Subject: [PATCH] nfs: remove superfluous BUG_ON()s

Remove duplicated BUG_ON()s from nfs[4]_create_server()
(we make the same checks earlier in both functions).

This takes care of the following entries from Dan's list:

fs/nfs/client.c +1078 nfs_create_server(47) warning: variable derefenced before check 'server->nfs_client'
fs/nfs/client.c +1079 nfs_create_server(48) warning: variable derefenced before check 'server->nfs_client->rpc_ops'
fs/nfs/client.c +1363 nfs4_create_server(43) warning: variable derefenced before check 'server->nfs_client'
fs/nfs/client.c +1364 nfs4_create_server(44) warning: variable derefenced before check 'server->nfs_

Reported-by: Dan Carpenter <error27@gmail.com>
Cc: corbet@lwn.net
Cc: eteo@redhat.com
Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/client.c