[SCSI] aha152x: fix init suspiciously returned 1, it should follow 0/-E convention
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Sat, 10 May 2008 13:33:58 +0000 (08:33 -0500)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 11 May 2008 13:36:15 +0000 (08:36 -0500)
commitad2fa42d044b98469449880474a9662fb689f7f9
treed016ba7ce9600cb80168be9c23ee447b491fb071
parentc8611f975403dd20e6503aff8aded5dcb718f75b
[SCSI] aha152x: fix init suspiciously returned 1, it should follow 0/-E convention

Reported-by: Frank de Jong <frapex@xs4all.nl>
> [1.] One line summary of the problem:
> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
> follow 0/-E convention. The module / driver works okay. Unloading the
> module is impossible.

The driver is apparently returning 0 on failure and 1 on success.
That's a bit unfortunate.  Fix it by altering to -ENODEV and 0.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/aha152x.c