[PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()
authorJesper Juhl <juhl-lkml@dif.dk>
Thu, 16 Jun 2005 22:14:00 +0000 (15:14 -0700)
committerTony Luck <tony.luck@intel.com>
Thu, 16 Jun 2005 23:27:14 +0000 (16:27 -0700)
commit986a80d5c154808cc78170584670324a22fd8219
tree11cc27ed20f65d1693ad2883a8606fbd7822888d
parent4845f3333765b732aa2d7ea6d72fd03cfec4fbf3
[PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()

warning when building with gcc -W :

 include/linux/efi.h: In function `efi_range_is_wc':
 include/linux/efi.h:320: warning: comparison between signed and unsigned

It looks to me like a significantly large 'len' passed in could cause the
loop to never end. Isn't it safer to make 'i' an unsigned long as well?
Like this little patch below (which of course also kills the warning) :

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Tony Luck <tony.luck@intel.com>
include/linux/efi.h