git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1e8a287) | patch
dccp ccid-3: X truncated due to type conversion
authorGerrit Renker <gerrit@erg.abdn.ac.uk>
Wed, 11 Jun 2008 10:19:10 +0000 (11:19 +0100)
committerGerrit Renker <gerrit@erg.abdn.ac.uk>
Wed, 11 Jun 2008 10:19:10 +0000 (11:19 +0100)
commit7deb0f851003287d7e259bf6b33548b144c0f2d5
tree8ede694c4b6cd41224f7165d09d3f5935d889fd1tree | snapshot
parent1e8a287c79f64226541f5c44aa52d4698bb84cf5commit | diff
dccp ccid-3: X truncated due to type conversion

This fixes a bug in computing the inter-packet-interval t_ipi = s/X:

 scaled_div32(a, b) uses u32 for b, but in "scaled_div32(s, X)" the type of the
 sending rate `X' is u64. Since X is scaled by 2^6, this truncates rates greater
 than 2^26 Bps (~537 Mbps).

Using full 64-bit division now.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
net/dccp/ccids/lib/tfrc.h diff | blob | history
Full containers within linux kernel