[POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm
authorGrant Likely <grant.likely@secretlab.ca>
Fri, 25 Jan 2008 05:25:31 +0000 (22:25 -0700)
committerGrant Likely <grant.likely@secretlab.ca>
Sat, 26 Jan 2008 22:32:19 +0000 (15:32 -0700)
commit4fb4c5582475452d3bf7c5072ef2d15ee06f7723
tree9e75d2795deafb6601fb31c858874ebd554a4135
parentc8004a28186110657aa3e75135a6b96ebfa3e8f0
[POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm

It is dangerous for an mpc52xx device driver to modify the port_config
register.  If the driver is probed incorrectly, it will change the pin
IO configuration in ways which may not be compatible with the board.
port_config should be set up by the bootloader, or failing that, in
the platform setup code in arch/powerpc/platforms/52xx.

Also, modifying CDM registers directly can cause a race condition with
other drivers.  Instead call a common routine to modify CDM settings.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Dragos Carp <dragos.carp@toptica.com>
drivers/spi/mpc52xx_psc_spi.c