git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 458622f) | patch
libata: make WARN_ON conditions in ata_sff_hsm_move() more strict
authorTejun Heo <htejun@gmail.com>
Wed, 23 Apr 2008 11:48:36 +0000 (20:48 +0900)
committerJeff Garzik <jgarzik@redhat.com>
Fri, 25 Apr 2008 04:45:09 +0000 (00:45 -0400)
commit411cb3869afd91ed40e8f12df64cd9e315356305
treedde48c3147d784d6ecfee093a1e6575291d6a177tree | snapshot
parent458622fcdc5b316de8d74efd7e610803f0308c14commit | diff
libata: make WARN_ON conditions in ata_sff_hsm_move() more strict

WARN_ON()'s in ata_hsm_move() was too liberal and got triggerred when
it shouldn't (e.g. hotplug events at the right moment).  As the HSM
only deals with device errors and state machine violations, make it
check only against them.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Mark Lord <liml@rtr.ca>
Cc: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-sff.c diff | blob | history
Full containers within linux kernel