git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2dcb407) | patch
libata-core: auditting chk_status v check_status
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Tue, 23 Oct 2007 15:50:02 +0000 (16:50 +0100)
committerJeff Garzik <jeff@garzik.org>
Wed, 24 Oct 2007 01:20:02 +0000 (21:20 -0400)
commit150981b0306fc5773b929e31ab5b0590c87cc77c
treef1d76250c05026d742c2a75538977fc1a7dcf3b8tree | snapshot
parent2dcb407e61458ded17503d6bd12b8c064965368bcommit | diff
libata-core: auditting chk_status v check_status

Did a complete audit of these and found we have another error case.

ata_bus_softreset calls ata_check_status which means that it tries to do
an ioread8 on the port blindly and check versus 0xFF for an error.

It should of course be using the ap->ops method for this via chk_status,
and this bug causes a wrog status call on the NS87415 at least.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c diff | blob | history
Full containers within linux kernel