pciehp: move msleep after power off
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Tue, 27 May 2008 10:06:22 +0000 (19:06 +0900)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 27 May 2008 22:43:33 +0000 (15:43 -0700)
commit0711c70ec0e9d2c002b1e9b5fb9f21e49d77f4fd
tree3660b129fe485637baf164e7092b630e5ad3cd19
parent6592e02ae4bd7b277230aa0c5821588a13b9d8e3
pciehp: move msleep after power off

According to the PCI Express specification, we must wait for at least
1 second after turning power off before taking any action that relies
on power having been removed from the slot/adapter. For this, current
pciehp wait for 1 second after issuing the power off command in
hpc_power_off_slot() function. But waiting for 1 second in
hpc_power_off_slot() can make pciehp probing slow-down because pciehp
probe code calls hpc_power_off_slot() if the slot is not occupied just
in case. We don't need to wait for 1 second at the pciehp probe time
because there is no action on that empty slot. So move 1 second wait
from hpc_power_off_slot() to the caller of hpc_power_off_slot().

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/pciehp_ctrl.c
drivers/pci/hotplug/pciehp_hpc.c