KVM: kvm->arch.vioapic should be NULL if kvm_ioapic_init() failure
[safe/jmp/linux-2.6] / virt / kvm / iommu.c
index d46de9a..80fd3ad 100644 (file)
 #include <linux/kvm_host.h>
 #include <linux/pci.h>
 #include <linux/dmar.h>
+#include <linux/iommu.h>
 #include <linux/intel-iommu.h>
 
 static int kvm_iommu_unmap_memslots(struct kvm *kvm);
 static void kvm_iommu_put_pages(struct kvm *kvm,
                                gfn_t base_gfn, unsigned long npages);
 
-int kvm_iommu_map_pages(struct kvm *kvm,
-                       gfn_t base_gfn, unsigned long npages)
+int kvm_iommu_map_pages(struct kvm *kvm, struct kvm_memory_slot *slot)
 {
-       gfn_t gfn = base_gfn;
+       gfn_t gfn = slot->base_gfn;
+       unsigned long npages = slot->npages;
        pfn_t pfn;
        int i, r = 0;
-       struct dmar_domain *domain = kvm->arch.intel_iommu_domain;
+       struct iommu_domain *domain = kvm->arch.iommu_domain;
+       int flags;
 
        /* check if iommu exists and in use */
        if (!domain)
                return 0;
 
+       flags = IOMMU_READ | IOMMU_WRITE;
+       if (kvm->arch.iommu_flags & KVM_IOMMU_CACHE_COHERENCY)
+               flags |= IOMMU_CACHE;
+
        for (i = 0; i < npages; i++) {
                /* check if already mapped */
-               if (intel_iommu_iova_to_phys(domain,
-                                            gfn_to_gpa(gfn)))
+               if (iommu_iova_to_phys(domain, gfn_to_gpa(gfn)))
                        continue;
 
-               pfn = gfn_to_pfn(kvm, gfn);
-               r = intel_iommu_map_address(domain,
-                                           gfn_to_gpa(gfn),
-                                           pfn_to_hpa(pfn),
-                                           PAGE_SIZE,
-                                           DMA_PTE_READ | DMA_PTE_WRITE);
+               pfn = gfn_to_pfn_memslot(kvm, slot, gfn);
+               r = iommu_map_range(domain,
+                                   gfn_to_gpa(gfn),
+                                   pfn_to_hpa(pfn),
+                                   PAGE_SIZE, flags);
                if (r) {
                        printk(KERN_ERR "kvm_iommu_map_address:"
                               "iommu failed to map pfn=%lx\n", pfn);
@@ -65,22 +69,23 @@ int kvm_iommu_map_pages(struct kvm *kvm,
        return 0;
 
 unmap_pages:
-       kvm_iommu_put_pages(kvm, base_gfn, i);
+       kvm_iommu_put_pages(kvm, slot->base_gfn, i);
        return r;
 }
 
 static int kvm_iommu_map_memslots(struct kvm *kvm)
 {
-       int i, r;
+       int i, r = 0;
+       struct kvm_memslots *slots;
+
+       slots = rcu_dereference(kvm->memslots);
 
-       down_read(&kvm->slots_lock);
-       for (i = 0; i < kvm->nmemslots; i++) {
-               r = kvm_iommu_map_pages(kvm, kvm->memslots[i].base_gfn,
-                                       kvm->memslots[i].npages);
+       for (i = 0; i < slots->nmemslots; i++) {
+               r = kvm_iommu_map_pages(kvm, &slots->memslots[i]);
                if (r)
                        break;
        }
-       up_read(&kvm->slots_lock);
+
        return r;
 }
 
@@ -88,8 +93,8 @@ int kvm_assign_device(struct kvm *kvm,
                      struct kvm_assigned_dev_kernel *assigned_dev)
 {
        struct pci_dev *pdev = NULL;
-       struct dmar_domain *domain = kvm->arch.intel_iommu_domain;
-       int r;
+       struct iommu_domain *domain = kvm->arch.iommu_domain;
+       int r, last_flags;
 
        /* check if iommu exists and in use */
        if (!domain)
@@ -99,27 +104,46 @@ int kvm_assign_device(struct kvm *kvm,
        if (pdev == NULL)
                return -ENODEV;
 
-       r = intel_iommu_attach_device(domain, pdev);
+       r = iommu_attach_device(domain, &pdev->dev);
        if (r) {
-               printk(KERN_ERR "assign device %x:%x.%x failed",
+               printk(KERN_ERR "assign device %x:%x:%x.%x failed",
+                       pci_domain_nr(pdev->bus),
                        pdev->bus->number,
                        PCI_SLOT(pdev->devfn),
                        PCI_FUNC(pdev->devfn));
                return r;
        }
 
-       printk(KERN_DEBUG "assign device: host bdf = %x:%x:%x\n",
+       last_flags = kvm->arch.iommu_flags;
+       if (iommu_domain_has_cap(kvm->arch.iommu_domain,
+                                IOMMU_CAP_CACHE_COHERENCY))
+               kvm->arch.iommu_flags |= KVM_IOMMU_CACHE_COHERENCY;
+
+       /* Check if need to update IOMMU page table for guest memory */
+       if ((last_flags ^ kvm->arch.iommu_flags) ==
+                       KVM_IOMMU_CACHE_COHERENCY) {
+               kvm_iommu_unmap_memslots(kvm);
+               r = kvm_iommu_map_memslots(kvm);
+               if (r)
+                       goto out_unmap;
+       }
+
+       printk(KERN_DEBUG "assign device %x:%x:%x.%x\n",
+               assigned_dev->host_segnr,
                assigned_dev->host_busnr,
                PCI_SLOT(assigned_dev->host_devfn),
                PCI_FUNC(assigned_dev->host_devfn));
 
        return 0;
+out_unmap:
+       kvm_iommu_unmap_memslots(kvm);
+       return r;
 }
 
 int kvm_deassign_device(struct kvm *kvm,
                        struct kvm_assigned_dev_kernel *assigned_dev)
 {
-       struct dmar_domain *domain = kvm->arch.intel_iommu_domain;
+       struct iommu_domain *domain = kvm->arch.iommu_domain;
        struct pci_dev *pdev = NULL;
 
        /* check if iommu exists and in use */
@@ -130,9 +154,10 @@ int kvm_deassign_device(struct kvm *kvm,
        if (pdev == NULL)
                return -ENODEV;
 
-       intel_iommu_detach_device(domain, pdev);
+       iommu_detach_device(domain, &pdev->dev);
 
-       printk(KERN_DEBUG "deassign device: host bdf = %x:%x:%x\n",
+       printk(KERN_DEBUG "deassign device %x:%x:%x.%x\n",
+               assigned_dev->host_segnr,
                assigned_dev->host_busnr,
                PCI_SLOT(assigned_dev->host_devfn),
                PCI_FUNC(assigned_dev->host_devfn));
@@ -144,13 +169,13 @@ int kvm_iommu_map_guest(struct kvm *kvm)
 {
        int r;
 
-       if (!intel_iommu_found()) {
-               printk(KERN_ERR "%s: intel iommu not found\n", __func__);
+       if (!iommu_found()) {
+               printk(KERN_ERR "%s: iommu not found\n", __func__);
                return -ENODEV;
        }
 
-       kvm->arch.intel_iommu_domain = intel_iommu_alloc_domain();
-       if (!kvm->arch.intel_iommu_domain)
+       kvm->arch.iommu_domain = iommu_domain_alloc();
+       if (!kvm->arch.iommu_domain)
                return -ENOMEM;
 
        r = kvm_iommu_map_memslots(kvm);
@@ -169,7 +194,7 @@ static void kvm_iommu_put_pages(struct kvm *kvm,
 {
        gfn_t gfn = base_gfn;
        pfn_t pfn;
-       struct dmar_domain *domain = kvm->arch.intel_iommu_domain;
+       struct iommu_domain *domain = kvm->arch.iommu_domain;
        unsigned long i;
        u64 phys;
 
@@ -178,40 +203,39 @@ static void kvm_iommu_put_pages(struct kvm *kvm,
                return;
 
        for (i = 0; i < npages; i++) {
-               phys = intel_iommu_iova_to_phys(domain,
-                                               gfn_to_gpa(gfn));
+               phys = iommu_iova_to_phys(domain, gfn_to_gpa(gfn));
                pfn = phys >> PAGE_SHIFT;
                kvm_release_pfn_clean(pfn);
                gfn++;
        }
 
-       intel_iommu_unmap_address(domain,
-                                 gfn_to_gpa(base_gfn),
-                                 PAGE_SIZE * npages);
+       iommu_unmap_range(domain, gfn_to_gpa(base_gfn), PAGE_SIZE * npages);
 }
 
 static int kvm_iommu_unmap_memslots(struct kvm *kvm)
 {
        int i;
-       down_read(&kvm->slots_lock);
-       for (i = 0; i < kvm->nmemslots; i++) {
-               kvm_iommu_put_pages(kvm, kvm->memslots[i].base_gfn,
-                                   kvm->memslots[i].npages);
+       struct kvm_memslots *slots;
+
+       slots = rcu_dereference(kvm->memslots);
+
+       for (i = 0; i < slots->nmemslots; i++) {
+               kvm_iommu_put_pages(kvm, slots->memslots[i].base_gfn,
+                                   slots->memslots[i].npages);
        }
-       up_read(&kvm->slots_lock);
 
        return 0;
 }
 
 int kvm_iommu_unmap_guest(struct kvm *kvm)
 {
-       struct dmar_domain *domain = kvm->arch.intel_iommu_domain;
+       struct iommu_domain *domain = kvm->arch.iommu_domain;
 
        /* check if iommu exists and in use */
        if (!domain)
                return 0;
 
        kvm_iommu_unmap_memslots(kvm);
-       intel_iommu_free_domain(domain);
+       iommu_domain_free(domain);
        return 0;
 }