perf symbols: Fix inverted logic for showing kallsyms as the source of symbols
[safe/jmp/linux-2.6] / tools / perf / util / symbol.c
index 86ec6c7..1270cf8 100644 (file)
@@ -1,11 +1,14 @@
 #include "util.h"
 #include "../perf.h"
+#include "session.h"
+#include "sort.h"
 #include "string.h"
 #include "symbol.h"
 #include "thread.h"
 
 #include "debug.h"
 
+#include <asm/bug.h>
 #include <libelf.h>
 #include <gelf.h>
 #include <elf.h>
@@ -19,6 +22,7 @@
 enum dso_origin {
        DSO__ORIG_KERNEL = 0,
        DSO__ORIG_JAVA_JIT,
+       DSO__ORIG_BUILD_ID_CACHE,
        DSO__ORIG_FEDORA,
        DSO__ORIG_UBUNTU,
        DSO__ORIG_BUILDID,
@@ -27,19 +31,54 @@ enum dso_origin {
        DSO__ORIG_NOT_FOUND,
 };
 
-static void dsos__add(struct dso *dso);
-static struct dso *dsos__find(const char *name);
-static struct map *map__new2(u64 start, struct dso *dso);
-static void kernel_maps__insert(struct map *map);
+static void dsos__add(struct list_head *head, struct dso *dso);
+static struct map *map__new2(u64 start, struct dso *dso, enum map_type type);
 static int dso__load_kernel_sym(struct dso *self, struct map *map,
-                               symbol_filter_t filter);
-unsigned int symbol__priv_size;
+                               struct perf_session *session, symbol_filter_t filter);
+static int vmlinux_path__nr_entries;
+static char **vmlinux_path;
+
+struct symbol_conf symbol_conf = {
+       .exclude_other    = true,
+       .use_modules      = true,
+       .try_vmlinux_path = true,
+};
+
+bool dso__loaded(const struct dso *self, enum map_type type)
+{
+       return self->loaded & (1 << type);
+}
+
+bool dso__sorted_by_name(const struct dso *self, enum map_type type)
+{
+       return self->sorted_by_name & (1 << type);
+}
 
-static struct rb_root kernel_maps;
+static void dso__set_loaded(struct dso *self, enum map_type type)
+{
+       self->loaded |= (1 << type);
+}
 
-static void dso__fixup_sym_end(struct dso *self)
+static void dso__set_sorted_by_name(struct dso *self, enum map_type type)
 {
-       struct rb_node *nd, *prevnd = rb_first(&self->syms);
+       self->sorted_by_name |= (1 << type);
+}
+
+bool symbol_type__is_a(char symbol_type, enum map_type map_type)
+{
+       switch (map_type) {
+       case MAP__FUNCTION:
+               return symbol_type == 'T' || symbol_type == 'W';
+       case MAP__VARIABLE:
+               return symbol_type == 'D' || symbol_type == 'd';
+       default:
+               return false;
+       }
+}
+
+static void symbols__fixup_end(struct rb_root *self)
+{
+       struct rb_node *nd, *prevnd = rb_first(self);
        struct symbol *curr, *prev;
 
        if (prevnd == NULL)
@@ -60,10 +99,10 @@ static void dso__fixup_sym_end(struct dso *self)
                curr->end = roundup(curr->start, 4096);
 }
 
-static void kernel_maps__fixup_end(void)
+static void __map_groups__fixup_end(struct map_groups *self, enum map_type type)
 {
        struct map *prev, *curr;
-       struct rb_node *nd, *prevnd = rb_first(&kernel_maps);
+       struct rb_node *nd, *prevnd = rb_first(&self->maps[type]);
 
        if (prevnd == NULL)
                return;
@@ -83,18 +122,24 @@ static void kernel_maps__fixup_end(void)
        curr->end = ~0UL;
 }
 
+static void map_groups__fixup_end(struct map_groups *self)
+{
+       int i;
+       for (i = 0; i < MAP__NR_TYPES; ++i)
+               __map_groups__fixup_end(self, i);
+}
+
 static struct symbol *symbol__new(u64 start, u64 len, const char *name)
 {
        size_t namelen = strlen(name) + 1;
-       struct symbol *self = calloc(1, (symbol__priv_size +
-                                        sizeof(*self) + namelen));
-       if (!self)
+       struct symbol *self = zalloc(symbol_conf.priv_size +
+                                    sizeof(*self) + namelen);
+       if (self == NULL)
                return NULL;
 
-       if (symbol__priv_size) {
-               memset(self, 0, symbol__priv_size);
-               self = ((void *)self) + symbol__priv_size;
-       }
+       if (symbol_conf.priv_size)
+               self = ((void *)self) + symbol_conf.priv_size;
+
        self->start = start;
        self->end   = len ? start + len - 1 : start;
 
@@ -107,7 +152,7 @@ static struct symbol *symbol__new(u64 start, u64 len, const char *name)
 
 static void symbol__delete(struct symbol *self)
 {
-       free(((void *)self) - symbol__priv_size);
+       free(((void *)self) - symbol_conf.priv_size);
 }
 
 static size_t symbol__fprintf(struct symbol *self, FILE *fp)
@@ -116,7 +161,7 @@ static size_t symbol__fprintf(struct symbol *self, FILE *fp)
                       self->start, self->end, self->name);
 }
 
-static void dso__set_long_name(struct dso *self, char *name)
+void dso__set_long_name(struct dso *self, char *name)
 {
        if (name == NULL)
                return;
@@ -131,39 +176,43 @@ static void dso__set_basename(struct dso *self)
 
 struct dso *dso__new(const char *name)
 {
-       struct dso *self = malloc(sizeof(*self) + strlen(name) + 1);
+       struct dso *self = zalloc(sizeof(*self) + strlen(name) + 1);
 
        if (self != NULL) {
+               int i;
                strcpy(self->name, name);
                dso__set_long_name(self, self->name);
                self->short_name = self->name;
-               self->syms = RB_ROOT;
-               self->find_symbol = dso__find_symbol;
+               for (i = 0; i < MAP__NR_TYPES; ++i)
+                       self->symbols[i] = self->symbol_names[i] = RB_ROOT;
                self->slen_calculated = 0;
                self->origin = DSO__ORIG_NOT_FOUND;
                self->loaded = 0;
+               self->sorted_by_name = 0;
                self->has_build_id = 0;
        }
 
        return self;
 }
 
-static void dso__delete_symbols(struct dso *self)
+static void symbols__delete(struct rb_root *self)
 {
        struct symbol *pos;
-       struct rb_node *next = rb_first(&self->syms);
+       struct rb_node *next = rb_first(self);
 
        while (next) {
                pos = rb_entry(next, struct symbol, rb_node);
                next = rb_next(&pos->rb_node);
-               rb_erase(&pos->rb_node, &self->syms);
+               rb_erase(&pos->rb_node, self);
                symbol__delete(pos);
        }
 }
 
 void dso__delete(struct dso *self)
 {
-       dso__delete_symbols(self);
+       int i;
+       for (i = 0; i < MAP__NR_TYPES; ++i)
+               symbols__delete(&self->symbols[i]);
        if (self->long_name != self->name)
                free(self->long_name);
        free(self);
@@ -175,9 +224,9 @@ void dso__set_build_id(struct dso *self, void *build_id)
        self->has_build_id = 1;
 }
 
-static void dso__insert_symbol(struct dso *self, struct symbol *sym)
+static void symbols__insert(struct rb_root *self, struct symbol *sym)
 {
-       struct rb_node **p = &self->syms.rb_node;
+       struct rb_node **p = &self->rb_node;
        struct rb_node *parent = NULL;
        const u64 ip = sym->start;
        struct symbol *s;
@@ -191,17 +240,17 @@ static void dso__insert_symbol(struct dso *self, struct symbol *sym)
                        p = &(*p)->rb_right;
        }
        rb_link_node(&sym->rb_node, parent, p);
-       rb_insert_color(&sym->rb_node, &self->syms);
+       rb_insert_color(&sym->rb_node, self);
 }
 
-struct symbol *dso__find_symbol(struct dso *self, u64 ip)
+static struct symbol *symbols__find(struct rb_root *self, u64 ip)
 {
        struct rb_node *n;
 
        if (self == NULL)
                return NULL;
 
-       n = self->syms.rb_node;
+       n = self->rb_node;
 
        while (n) {
                struct symbol *s = rb_entry(n, struct symbol, rb_node);
@@ -217,10 +266,89 @@ struct symbol *dso__find_symbol(struct dso *self, u64 ip)
        return NULL;
 }
 
-int build_id__sprintf(u8 *self, int len, char *bf)
+struct symbol_name_rb_node {
+       struct rb_node  rb_node;
+       struct symbol   sym;
+};
+
+static void symbols__insert_by_name(struct rb_root *self, struct symbol *sym)
+{
+       struct rb_node **p = &self->rb_node;
+       struct rb_node *parent = NULL;
+       struct symbol_name_rb_node *symn = ((void *)sym) - sizeof(*parent), *s;
+
+       while (*p != NULL) {
+               parent = *p;
+               s = rb_entry(parent, struct symbol_name_rb_node, rb_node);
+               if (strcmp(sym->name, s->sym.name) < 0)
+                       p = &(*p)->rb_left;
+               else
+                       p = &(*p)->rb_right;
+       }
+       rb_link_node(&symn->rb_node, parent, p);
+       rb_insert_color(&symn->rb_node, self);
+}
+
+static void symbols__sort_by_name(struct rb_root *self, struct rb_root *source)
+{
+       struct rb_node *nd;
+
+       for (nd = rb_first(source); nd; nd = rb_next(nd)) {
+               struct symbol *pos = rb_entry(nd, struct symbol, rb_node);
+               symbols__insert_by_name(self, pos);
+       }
+}
+
+static struct symbol *symbols__find_by_name(struct rb_root *self, const char *name)
+{
+       struct rb_node *n;
+
+       if (self == NULL)
+               return NULL;
+
+       n = self->rb_node;
+
+       while (n) {
+               struct symbol_name_rb_node *s;
+               int cmp;
+
+               s = rb_entry(n, struct symbol_name_rb_node, rb_node);
+               cmp = strcmp(name, s->sym.name);
+
+               if (cmp < 0)
+                       n = n->rb_left;
+               else if (cmp > 0)
+                       n = n->rb_right;
+               else
+                       return &s->sym;
+       }
+
+       return NULL;
+}
+
+struct symbol *dso__find_symbol(struct dso *self,
+                               enum map_type type, u64 addr)
+{
+       return symbols__find(&self->symbols[type], addr);
+}
+
+struct symbol *dso__find_symbol_by_name(struct dso *self, enum map_type type,
+                                       const char *name)
+{
+       return symbols__find_by_name(&self->symbol_names[type], name);
+}
+
+void dso__sort_by_name(struct dso *self, enum map_type type)
+{
+       dso__set_sorted_by_name(self, type);
+       return symbols__sort_by_name(&self->symbol_names[type],
+                                    &self->symbols[type]);
+}
+
+int build_id__sprintf(const u8 *self, int len, char *bf)
 {
        char *bid = bf;
-       u8 *raw = self;
+       const u8 *raw = self;
        int i;
 
        for (i = 0; i < len; ++i) {
@@ -240,15 +368,14 @@ size_t dso__fprintf_buildid(struct dso *self, FILE *fp)
        return fprintf(fp, "%s", sbuild_id);
 }
 
-size_t dso__fprintf(struct dso *self, FILE *fp)
+size_t dso__fprintf(struct dso *self, enum map_type type, FILE *fp)
 {
        struct rb_node *nd;
        size_t ret = fprintf(fp, "dso: %s (", self->short_name);
 
        ret += dso__fprintf_buildid(self, fp);
        ret += fprintf(fp, ")\n");
-
-       for (nd = rb_first(&self->syms); nd; nd = rb_next(nd)) {
+       for (nd = rb_first(&self->symbols[type]); nd; nd = rb_next(nd)) {
                struct symbol *pos = rb_entry(nd, struct symbol, rb_node);
                ret += symbol__fprintf(pos, fp);
        }
@@ -256,23 +383,20 @@ size_t dso__fprintf(struct dso *self, FILE *fp)
        return ret;
 }
 
-/*
- * Loads the function entries in /proc/kallsyms into kernel_map->dso,
- * so that we can in the next step set the symbol ->end address and then
- * call kernel_maps__split_kallsyms.
- */
-static int kernel_maps__load_all_kallsyms(void)
+int kallsyms__parse(const char *filename, void *arg,
+                   int (*process_symbol)(void *arg, const char *name,
+                                                    char type, u64 start))
 {
        char *line = NULL;
        size_t n;
-       FILE *file = fopen("/proc/kallsyms", "r");
+       int err = 0;
+       FILE *file = fopen(filename, "r");
 
        if (file == NULL)
                goto out_failure;
 
        while (!feof(file)) {
                u64 start;
-               struct symbol *sym;
                int line_len, len;
                char symbol_type;
                char *symbol_name;
@@ -293,51 +417,76 @@ static int kernel_maps__load_all_kallsyms(void)
                        continue;
 
                symbol_type = toupper(line[len]);
-               /*
-                * We're interested only in code ('T'ext)
-                */
-               if (symbol_type != 'T' && symbol_type != 'W')
-                       continue;
-
                symbol_name = line + len + 2;
-               /*
-                * Will fix up the end later, when we have all symbols sorted.
-                */
-               sym = symbol__new(start, 0, symbol_name);
 
-               if (sym == NULL)
-                       goto out_delete_line;
-
-               /*
-                * We will pass the symbols to the filter later, in
-                * kernel_maps__split_kallsyms, when we have split the
-                * maps per module
-                */
-               dso__insert_symbol(kernel_map->dso, sym);
+               err = process_symbol(arg, symbol_name, symbol_type, start);
+               if (err)
+                       break;
        }
 
        free(line);
        fclose(file);
+       return err;
 
-       return 0;
-
-out_delete_line:
-       free(line);
 out_failure:
        return -1;
 }
 
+struct process_kallsyms_args {
+       struct map *map;
+       struct dso *dso;
+};
+
+static int map__process_kallsym_symbol(void *arg, const char *name,
+                                      char type, u64 start)
+{
+       struct symbol *sym;
+       struct process_kallsyms_args *a = arg;
+       struct rb_root *root = &a->dso->symbols[a->map->type];
+
+       if (!symbol_type__is_a(type, a->map->type))
+               return 0;
+
+       /*
+        * Will fix up the end later, when we have all symbols sorted.
+        */
+       sym = symbol__new(start, 0, name);
+
+       if (sym == NULL)
+               return -ENOMEM;
+       /*
+        * We will pass the symbols to the filter later, in
+        * map__split_kallsyms, when we have split the maps per module
+        */
+       symbols__insert(root, sym);
+       return 0;
+}
+
+/*
+ * Loads the function entries in /proc/kallsyms into kernel_map->dso,
+ * so that we can in the next step set the symbol ->end address and then
+ * call kernel_maps__split_kallsyms.
+ */
+static int dso__load_all_kallsyms(struct dso *self, const char *filename,
+                                 struct map *map)
+{
+       struct process_kallsyms_args args = { .map = map, .dso = self, };
+       return kallsyms__parse(filename, &args, map__process_kallsym_symbol);
+}
+
 /*
  * Split the symbols into maps, making sure there are no overlaps, i.e. the
  * kernel range is broken in several maps, named [kernel].N, as we don't have
  * the original ELF section names vmlinux have.
  */
-static int kernel_maps__split_kallsyms(symbol_filter_t filter)
+static int dso__split_kallsyms(struct dso *self, struct map *map,
+                              struct perf_session *session, symbol_filter_t filter)
 {
-       struct map *map = kernel_map;
+       struct map *curr_map = map;
        struct symbol *pos;
        int count = 0;
-       struct rb_node *next = rb_first(&kernel_map->dso->syms);
+       struct rb_root *root = &self->symbols[map->type];
+       struct rb_node *next = rb_first(root);
        int kernel_range = 0;
 
        while (next) {
@@ -348,23 +497,30 @@ static int kernel_maps__split_kallsyms(symbol_filter_t filter)
 
                module = strchr(pos->name, '\t');
                if (module) {
+                       if (!symbol_conf.use_modules)
+                               goto discard_symbol;
+
                        *module++ = '\0';
 
-                       if (strcmp(map->dso->name, module)) {
-                               map = kernel_maps__find_by_dso_name(module);
-                               if (!map) {
-                                       pr_err("/proc/{kallsyms,modules} "
-                                              "inconsistency!\n");
+                       if (strcmp(curr_map->dso->short_name, module)) {
+                               curr_map = map_groups__find_by_name(&session->kmaps, map->type, module);
+                               if (curr_map == NULL) {
+                                       pr_debug("/proc/{kallsyms,modules} "
+                                                "inconsistency while looking "
+                                                "for \"%s\" module!\n", module);
                                        return -1;
                                }
+
+                               if (curr_map->dso->loaded)
+                                       goto discard_symbol;
                        }
                        /*
                         * So that we look just like we get from .ko files,
                         * i.e. not prelinked, relative to map->start.
                         */
-                       pos->start = map->map_ip(map, pos->start);
-                       pos->end   = map->map_ip(map, pos->end);
-               } else if (map != kernel_map) {
+                       pos->start = curr_map->map_ip(curr_map, pos->start);
+                       pos->end   = curr_map->map_ip(curr_map, pos->end);
+               } else if (curr_map != map) {
                        char dso_name[PATH_MAX];
                        struct dso *dso;
 
@@ -375,24 +531,24 @@ static int kernel_maps__split_kallsyms(symbol_filter_t filter)
                        if (dso == NULL)
                                return -1;
 
-                       map = map__new2(pos->start, dso);
+                       curr_map = map__new2(pos->start, dso, map->type);
                        if (map == NULL) {
                                dso__delete(dso);
                                return -1;
                        }
 
-                       map->map_ip = map->unmap_ip = identity__map_ip;
-                       kernel_maps__insert(map);
+                       curr_map->map_ip = curr_map->unmap_ip = identity__map_ip;
+                       map_groups__insert(&session->kmaps, curr_map);
                        ++kernel_range;
                }
 
-               if (filter && filter(map, pos)) {
-                       rb_erase(&pos->rb_node, &kernel_map->dso->syms);
+               if (filter && filter(curr_map, pos)) {
+discard_symbol:                rb_erase(&pos->rb_node, root);
                        symbol__delete(pos);
                } else {
-                       if (map != kernel_map) {
-                               rb_erase(&pos->rb_node, &kernel_map->dso->syms);
-                               dso__insert_symbol(map->dso, pos);
+                       if (curr_map != map) {
+                               rb_erase(&pos->rb_node, root);
+                               symbols__insert(&curr_map->dso->symbols[curr_map->type], pos);
                        }
                        count++;
                }
@@ -402,34 +558,16 @@ static int kernel_maps__split_kallsyms(symbol_filter_t filter)
 }
 
 
-static int kernel_maps__load_kallsyms(symbol_filter_t filter)
+static int dso__load_kallsyms(struct dso *self, const char *filename, struct map *map,
+                             struct perf_session *session, symbol_filter_t filter)
 {
-       if (kernel_maps__load_all_kallsyms())
+       if (dso__load_all_kallsyms(self, filename, map) < 0)
                return -1;
 
-       dso__fixup_sym_end(kernel_map->dso);
-       kernel_map->dso->origin = DSO__ORIG_KERNEL;
-
-       return kernel_maps__split_kallsyms(filter);
-}
-
-size_t kernel_maps__fprintf(FILE *fp)
-{
-       size_t printed = fprintf(fp, "Kernel maps:\n");
-       struct rb_node *nd;
-
-       for (nd = rb_first(&kernel_maps); nd; nd = rb_next(nd)) {
-               struct map *pos = rb_entry(nd, struct map, rb_node);
-
-               printed += fprintf(fp, "Map:");
-               printed += map__fprintf(pos, fp);
-               if (verbose > 1) {
-                       printed += dso__fprintf(pos->dso, fp);
-                       printed += fprintf(fp, "--\n");
-               }
-       }
+       symbols__fixup_end(&self->symbols[map->type]);
+       self->origin = DSO__ORIG_KERNEL;
 
-       return printed + fprintf(fp, "END kernel maps\n");
+       return dso__split_kallsyms(self, map, session, filter);
 }
 
 static int dso__load_perf_map(struct dso *self, struct map *map,
@@ -478,7 +616,7 @@ static int dso__load_perf_map(struct dso *self, struct map *map,
                if (filter && filter(map, sym))
                        symbol__delete(sym);
                else {
-                       dso__insert_symbol(self, sym);
+                       symbols__insert(&self->symbols[map->type], sym);
                        nr_syms++;
                }
        }
@@ -518,6 +656,13 @@ static inline int elf_sym__is_function(const GElf_Sym *sym)
               sym->st_shndx != SHN_UNDEF;
 }
 
+static inline bool elf_sym__is_object(const GElf_Sym *sym)
+{
+       return elf_sym__type(sym) == STT_OBJECT &&
+               sym->st_name != 0 &&
+               sym->st_shndx != SHN_UNDEF;
+}
+
 static inline int elf_sym__is_label(const GElf_Sym *sym)
 {
        return elf_sym__type(sym) == STT_NOTYPE &&
@@ -538,6 +683,12 @@ static inline int elf_sec__is_text(const GElf_Shdr *shdr,
        return strstr(elf_sec__name(shdr, secstrs), "text") != NULL;
 }
 
+static inline bool elf_sec__is_data(const GElf_Shdr *shdr,
+                                   const Elf_Data *secstrs)
+{
+       return strstr(elf_sec__name(shdr, secstrs), "data") != NULL;
+}
+
 static inline const char *elf_sym__name(const GElf_Sym *sym,
                                        const Elf_Data *symstrs)
 {
@@ -676,7 +827,7 @@ static int dso__synthesize_plt_symbols(struct  dso *self, struct map *map,
                        if (filter && filter(map, f))
                                symbol__delete(f);
                        else {
-                               dso__insert_symbol(self, f);
+                               symbols__insert(&self->symbols[map->type], f);
                                ++nr;
                        }
                }
@@ -698,7 +849,7 @@ static int dso__synthesize_plt_symbols(struct  dso *self, struct map *map,
                        if (filter && filter(map, f))
                                symbol__delete(f);
                        else {
-                               dso__insert_symbol(self, f);
+                               symbols__insert(&self->symbols[map->type], f);
                                ++nr;
                        }
                }
@@ -718,9 +869,33 @@ out:
        return 0;
 }
 
-static int dso__load_sym(struct dso *self, struct map *map, const char *name,
-                        int fd, symbol_filter_t filter, int kernel,
-                        int kmodule)
+static bool elf_sym__is_a(GElf_Sym *self, enum map_type type)
+{
+       switch (type) {
+       case MAP__FUNCTION:
+               return elf_sym__is_function(self);
+       case MAP__VARIABLE:
+               return elf_sym__is_object(self);
+       default:
+               return false;
+       }
+}
+
+static bool elf_sec__is_a(GElf_Shdr *self, Elf_Data *secstrs, enum map_type type)
+{
+       switch (type) {
+       case MAP__FUNCTION:
+               return elf_sec__is_text(self, secstrs);
+       case MAP__VARIABLE:
+               return elf_sec__is_data(self, secstrs);
+       default:
+               return false;
+       }
+}
+
+static int dso__load_sym(struct dso *self, struct map *map,
+                        struct perf_session *session, const char *name, int fd,
+                        symbol_filter_t filter, int kernel, int kmodule)
 {
        struct map *curr_map = map;
        struct dso *curr_dso = self;
@@ -787,12 +962,16 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
 
        elf_symtab__for_each_symbol(syms, nr_syms, idx, sym) {
                struct symbol *f;
-               const char *elf_name;
+               const char *elf_name = elf_sym__name(&sym, symstrs);
                char *demangled = NULL;
                int is_label = elf_sym__is_label(&sym);
                const char *section_name;
 
-               if (!is_label && !elf_sym__is_function(&sym))
+               if (kernel && session->ref_reloc_sym.name != NULL &&
+                   strcmp(elf_name, session->ref_reloc_sym.name) == 0)
+                       perf_session__reloc_vmlinux_maps(session, sym.st_value);
+
+               if (!is_label && !elf_sym__is_a(&sym, map->type))
                        continue;
 
                sec = elf_getscn(elf, sym.st_shndx);
@@ -801,10 +980,9 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
 
                gelf_getshdr(sec, &shdr);
 
-               if (is_label && !elf_sec__is_text(&shdr, secstrs))
+               if (is_label && !elf_sec__is_a(&shdr, secstrs, map->type))
                        continue;
 
-               elf_name = elf_sym__name(&sym, symstrs);
                section_name = elf_sec__name(&shdr, secstrs);
 
                if (kernel || kmodule) {
@@ -823,7 +1001,7 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
                        snprintf(dso_name, sizeof(dso_name),
                                 "%s%s", self->short_name, section_name);
 
-                       curr_map = kernel_maps__find_by_dso_name(dso_name);
+                       curr_map = map_groups__find_by_name(&session->kmaps, map->type, dso_name);
                        if (curr_map == NULL) {
                                u64 start = sym.st_value;
 
@@ -833,7 +1011,8 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
                                curr_dso = dso__new(dso_name);
                                if (curr_dso == NULL)
                                        goto out_elf_end;
-                               curr_map = map__new2(start, curr_dso);
+                               curr_map = map__new2(start, curr_dso,
+                                                    MAP__FUNCTION);
                                if (curr_map == NULL) {
                                        dso__delete(curr_dso);
                                        goto out_elf_end;
@@ -841,8 +1020,8 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
                                curr_map->map_ip = identity__map_ip;
                                curr_map->unmap_ip = identity__map_ip;
                                curr_dso->origin = DSO__ORIG_KERNEL;
-                               kernel_maps__insert(curr_map);
-                               dsos__add(curr_dso);
+                               map_groups__insert(&session->kmaps, curr_map);
+                               dsos__add(&dsos__kernel, curr_dso);
                        } else
                                curr_dso = curr_map->dso;
 
@@ -872,7 +1051,7 @@ new_symbol:
                if (filter && filter(curr_map, f))
                        symbol__delete(f);
                else {
-                       dso__insert_symbol(curr_dso, f);
+                       symbols__insert(&curr_dso->symbols[curr_map->type], f);
                        nr++;
                }
        }
@@ -881,7 +1060,7 @@ new_symbol:
         * For misannotated, zeroed, ASM function sizes.
         */
        if (nr > 0)
-               dso__fixup_sym_end(self);
+               symbols__fixup_end(&self->symbols[map->type]);
        err = nr;
 out_elf_end:
        elf_end(elf);
@@ -894,12 +1073,12 @@ static bool dso__build_id_equal(const struct dso *self, u8 *build_id)
        return memcmp(self->build_id, build_id, sizeof(self->build_id)) == 0;
 }
 
-bool dsos__read_build_ids(void)
+static bool __dsos__read_build_ids(struct list_head *head)
 {
        bool have_build_id = false;
        struct dso *pos;
 
-       list_for_each_entry(pos, &dsos, node)
+       list_for_each_entry(pos, head, node)
                if (filename__read_build_id(pos->long_name, pos->build_id,
                                            sizeof(pos->build_id)) > 0) {
                        have_build_id     = true;
@@ -909,6 +1088,13 @@ bool dsos__read_build_ids(void)
        return have_build_id;
 }
 
+bool dsos__read_build_ids(void)
+{
+       bool kbuildids = __dsos__read_build_ids(&dsos__kernel),
+            ubuildids = __dsos__read_build_ids(&dsos__user);
+       return kbuildids || ubuildids;
+}
+
 /*
  * Align offset to 4 bytes as needed for note name and descriptor data.
  */
@@ -921,6 +1107,7 @@ int filename__read_build_id(const char *filename, void *bf, size_t size)
        GElf_Shdr shdr;
        Elf_Data *data;
        Elf_Scn *sec;
+       Elf_Kind ek;
        void *ptr;
        Elf *elf;
 
@@ -937,6 +1124,10 @@ int filename__read_build_id(const char *filename, void *bf, size_t size)
                goto out_close;
        }
 
+       ek = elf_kind(elf);
+       if (ek != ELF_K_ELF)
+               goto out_elf_end;
+
        if (gelf_getehdr(elf, &ehdr) == NULL) {
                pr_err("%s: cannot get elf header.\n", __func__);
                goto out_elf_end;
@@ -1032,6 +1223,7 @@ char dso__symtab_origin(const struct dso *self)
        static const char origin[] = {
                [DSO__ORIG_KERNEL] =   'k',
                [DSO__ORIG_JAVA_JIT] = 'j',
+               [DSO__ORIG_BUILD_ID_CACHE] = 'B',
                [DSO__ORIG_FEDORA] =   'f',
                [DSO__ORIG_UBUNTU] =   'u',
                [DSO__ORIG_BUILDID] =  'b',
@@ -1044,18 +1236,20 @@ char dso__symtab_origin(const struct dso *self)
        return origin[self->origin];
 }
 
-int dso__load(struct dso *self, struct map *map, symbol_filter_t filter)
+int dso__load(struct dso *self, struct map *map, struct perf_session *session,
+             symbol_filter_t filter)
 {
        int size = PATH_MAX;
        char *name;
        u8 build_id[BUILD_ID_SIZE];
+       char build_id_hex[BUILD_ID_SIZE * 2 + 1];
        int ret = -1;
        int fd;
 
-       self->loaded = 1;
+       dso__set_loaded(self, map->type);
 
        if (self->kernel)
-               return dso__load_kernel_sym(self, map, filter);
+               return dso__load_kernel_sym(self, map, session, filter);
 
        name = malloc(size);
        if (!name)
@@ -1070,8 +1264,16 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter)
                return ret;
        }
 
-       self->origin = DSO__ORIG_FEDORA - 1;
+       self->origin = DSO__ORIG_BUILD_ID_CACHE;
 
+       if (self->has_build_id) {
+               build_id__sprintf(self->build_id, sizeof(self->build_id),
+                                 build_id_hex);
+               snprintf(name, size, "%s/%s/.build-id/%.2s/%s",
+                        getenv("HOME"), DEBUG_CACHE_DIR,
+                        build_id_hex, build_id_hex + 2);
+               goto open_file;
+       }
 more:
        do {
                self->origin++;
@@ -1087,8 +1289,6 @@ more:
                case DSO__ORIG_BUILDID:
                        if (filename__read_build_id(self->long_name, build_id,
                                                    sizeof(build_id))) {
-                               char build_id_hex[BUILD_ID_SIZE * 2 + 1];
-
                                build_id__sprintf(build_id, sizeof(build_id),
                                                  build_id_hex);
                                snprintf(name, size,
@@ -1116,11 +1316,11 @@ compare_build_id:
                        if (!dso__build_id_equal(self, build_id))
                                goto more;
                }
-
+open_file:
                fd = open(name, O_RDONLY);
        } while (fd < 0);
 
-       ret = dso__load_sym(self, map, name, fd, filter, 0, 0);
+       ret = dso__load_sym(self, map, NULL, name, fd, filter, 0, 0);
        close(fd);
 
        /*
@@ -1141,50 +1341,48 @@ out:
        return ret;
 }
 
-struct map *kernel_map;
-
-static void kernel_maps__insert(struct map *map)
+struct map *map_groups__find_by_name(struct map_groups *self,
+                                    enum map_type type, const char *name)
 {
-       maps__insert(&kernel_maps, map);
-}
-
-struct symbol *kernel_maps__find_symbol(u64 ip, struct map **mapp,
-                                       symbol_filter_t filter)
-{
-       struct map *map = maps__find(&kernel_maps, ip);
+       struct rb_node *nd;
 
-       if (mapp)
-               *mapp = map;
+       for (nd = rb_first(&self->maps[type]); nd; nd = rb_next(nd)) {
+               struct map *map = rb_entry(nd, struct map, rb_node);
 
-       if (map) {
-               ip = map->map_ip(map, ip);
-               return map__find_symbol(map, ip, filter);
+               if (map->dso && strcmp(map->dso->short_name, name) == 0)
+                       return map;
        }
 
        return NULL;
 }
 
-struct map *kernel_maps__find_by_dso_name(const char *name)
+static int dso__kernel_module_get_build_id(struct dso *self)
 {
-       struct rb_node *nd;
+       char filename[PATH_MAX];
+       /*
+        * kernel module short names are of the form "[module]" and
+        * we need just "module" here.
+        */
+       const char *name = self->short_name + 1;
 
-       for (nd = rb_first(&kernel_maps); nd; nd = rb_next(nd)) {
-               struct map *map = rb_entry(nd, struct map, rb_node);
+       snprintf(filename, sizeof(filename),
+                "/sys/module/%.*s/notes/.note.gnu.build-id",
+                (int)strlen(name - 1), name);
 
-               if (map->dso && strcmp(map->dso->name, name) == 0)
-                       return map;
-       }
+       if (sysfs__read_build_id(filename, self->build_id,
+                                sizeof(self->build_id)) == 0)
+               self->has_build_id = true;
 
-       return NULL;
+       return 0;
 }
 
-static int dsos__set_modules_path_dir(char *dirname)
+static int perf_session__set_modules_path_dir(struct perf_session *self, char *dirname)
 {
        struct dirent *dent;
        DIR *dir = opendir(dirname);
 
        if (!dir) {
-               pr_err("%s: cannot open %s dir\n", __func__, dirname);
+               pr_debug("%s: cannot open %s dir\n", __func__, dirname);
                return -1;
        }
 
@@ -1198,7 +1396,7 @@ static int dsos__set_modules_path_dir(char *dirname)
 
                        snprintf(path, sizeof(path), "%s/%s",
                                 dirname, dent->d_name);
-                       if (dsos__set_modules_path_dir(path) < 0)
+                       if (perf_session__set_modules_path_dir(self, path) < 0)
                                goto failure;
                } else {
                        char *dot = strrchr(dent->d_name, '.'),
@@ -1212,7 +1410,7 @@ static int dsos__set_modules_path_dir(char *dirname)
                                 (int)(dot - dent->d_name), dent->d_name);
 
                        strxfrchar(dso_name, '-', '_');
-                       map = kernel_maps__find_by_dso_name(dso_name);
+                       map = map_groups__find_by_name(&self->kmaps, MAP__FUNCTION, dso_name);
                        if (map == NULL)
                                continue;
 
@@ -1223,6 +1421,7 @@ static int dsos__set_modules_path_dir(char *dirname)
                        if (long_name == NULL)
                                goto failure;
                        dso__set_long_name(map->dso, long_name);
+                       dso__kernel_module_get_build_id(map->dso);
                }
        }
 
@@ -1232,7 +1431,7 @@ failure:
        return -1;
 }
 
-static int dsos__set_modules_path(void)
+static int perf_session__set_modules_path(struct perf_session *self)
 {
        struct utsname uts;
        char modules_path[PATH_MAX];
@@ -1243,7 +1442,7 @@ static int dsos__set_modules_path(void)
        snprintf(modules_path, sizeof(modules_path), "/lib/modules/%s/kernel",
                 uts.release);
 
-       return dsos__set_modules_path_dir(modules_path);
+       return perf_session__set_modules_path_dir(self, modules_path);
 }
 
 /*
@@ -1251,7 +1450,7 @@ static int dsos__set_modules_path(void)
  * they are loaded) and for vmlinux, where only after we load all the
  * symbols we'll know where it starts and ends.
  */
-static struct map *map__new2(u64 start, struct dso *dso)
+static struct map *map__new2(u64 start, struct dso *dso, enum map_type type)
 {
        struct map *self = malloc(sizeof(*self));
 
@@ -1259,13 +1458,31 @@ static struct map *map__new2(u64 start, struct dso *dso)
                /*
                 * ->end will be filled after we load all the symbols
                 */
-               map__init(self, start, 0, 0, dso);
+               map__init(self, type, start, 0, 0, dso);
        }
 
        return self;
 }
 
-static int kernel_maps__create_module_maps(void)
+struct map *perf_session__new_module_map(struct perf_session *self, u64 start,
+                                        const char *filename)
+{
+       struct map *map;
+       struct dso *dso = __dsos__findnew(&dsos__kernel, filename);
+
+       if (dso == NULL)
+               return NULL;
+
+       map = map__new2(start, dso, MAP__FUNCTION);
+       if (map == NULL)
+               return NULL;
+
+       dso->origin = DSO__ORIG_KMODULE;
+       map_groups__insert(&self->kmaps, map);
+       return map;
+}
+
+static int perf_session__create_module_maps(struct perf_session *self)
 {
        char *line = NULL;
        size_t n;
@@ -1278,7 +1495,6 @@ static int kernel_maps__create_module_maps(void)
        while (!feof(file)) {
                char name[PATH_MAX];
                u64 start;
-               struct dso *dso;
                char *sep;
                int line_len;
 
@@ -1304,32 +1520,16 @@ static int kernel_maps__create_module_maps(void)
                *sep = '\0';
 
                snprintf(name, sizeof(name), "[%s]", line);
-               dso = dso__new(name);
-
-               if (dso == NULL)
-                       goto out_delete_line;
-
-               map = map__new2(start, dso);
-               if (map == NULL) {
-                       dso__delete(dso);
+               map = perf_session__new_module_map(self, start, name);
+               if (map == NULL)
                        goto out_delete_line;
-               }
-
-               snprintf(name, sizeof(name),
-                        "/sys/module/%s/notes/.note.gnu.build-id", line);
-               if (sysfs__read_build_id(name, dso->build_id,
-                                        sizeof(dso->build_id)) == 0)
-                       dso->has_build_id = true;
-
-               dso->origin = DSO__ORIG_KMODULE;
-               kernel_maps__insert(map);
-               dsos__add(dso);
+               dso__kernel_module_get_build_id(map->dso);
        }
 
        free(line);
        fclose(file);
 
-       return dsos__set_modules_path();
+       return perf_session__set_modules_path(self);
 
 out_delete_line:
        free(line);
@@ -1338,6 +1538,7 @@ out_failure:
 }
 
 static int dso__load_vmlinux(struct dso *self, struct map *map,
+                            struct perf_session *session,
                             const char *vmlinux, symbol_filter_t filter)
 {
        int err = -1, fd;
@@ -1370,26 +1571,108 @@ static int dso__load_vmlinux(struct dso *self, struct map *map,
        if (fd < 0)
                return -1;
 
-       self->loaded = 1;
-       err = dso__load_sym(self, map, self->long_name, fd, filter, 1, 0);
-
+       dso__set_loaded(self, map->type);
+       err = dso__load_sym(self, map, session, vmlinux, fd, filter, 1, 0);
        close(fd);
 
        return err;
 }
 
 static int dso__load_kernel_sym(struct dso *self, struct map *map,
-                               symbol_filter_t filter)
+                               struct perf_session *session, symbol_filter_t filter)
 {
-       int err = dso__load_vmlinux(self, map, self->name, filter);
+       int err;
+       const char *kallsyms_filename = NULL;
+       char *kallsyms_allocated_filename = NULL;
+       /*
+        * Step 1: if the user specified a vmlinux filename, use it and only
+        * it, reporting errors to the user if it cannot be used.
+        *
+        * For instance, try to analyse an ARM perf.data file _without_ a
+        * build-id, or if the user specifies the wrong path to the right
+        * vmlinux file, obviously we can't fallback to another vmlinux (a
+        * x86_86 one, on the machine where analysis is being performed, say),
+        * or worse, /proc/kallsyms.
+        *
+        * If the specified file _has_ a build-id and there is a build-id
+        * section in the perf.data file, we will still do the expected
+        * validation in dso__load_vmlinux and will bail out if they don't
+        * match.
+        */
+       if (symbol_conf.vmlinux_name != NULL) {
+               err = dso__load_vmlinux(self, map, session,
+                                       symbol_conf.vmlinux_name, filter);
+               goto out_try_fixup;
+       }
 
-       if (err <= 0) {
-               err = kernel_maps__load_kallsyms(filter);
-               if (err > 0)
-                        dso__set_long_name(self, strdup("[kernel.kallsyms]"));
+       if (vmlinux_path != NULL) {
+               int i;
+               pr_debug("Looking at the vmlinux_path (%d entries long)\n",
+                        vmlinux_path__nr_entries);
+               for (i = 0; i < vmlinux_path__nr_entries; ++i) {
+                       err = dso__load_vmlinux(self, map, session,
+                                               vmlinux_path[i], filter);
+                       if (err > 0) {
+                               pr_debug("Using %s for symbols\n",
+                                        vmlinux_path[i]);
+                               dso__set_long_name(self,
+                                                  strdup(vmlinux_path[i]));
+                               goto out_fixup;
+                       }
+               }
        }
 
+       /*
+        * Say the kernel DSO was created when processing the build-id header table,
+        * we have a build-id, so check if it is the same as the running kernel,
+        * using it if it is.
+        */
+       if (self->has_build_id) {
+               u8 kallsyms_build_id[BUILD_ID_SIZE];
+               char sbuild_id[BUILD_ID_SIZE * 2 + 1];
+
+               if (sysfs__read_build_id("/sys/kernel/notes", kallsyms_build_id,
+                                        sizeof(kallsyms_build_id)) == 0) {
+                       if (dso__build_id_equal(self, kallsyms_build_id)) {
+                               kallsyms_filename = "/proc/kallsyms";
+                               goto do_kallsyms;
+                       }
+               }
+               /*
+                * Now look if we have it on the build-id cache in
+                * $HOME/.debug/[kernel.kallsyms].
+                */
+               build_id__sprintf(self->build_id, sizeof(self->build_id),
+                                 sbuild_id);
+
+               if (asprintf(&kallsyms_allocated_filename,
+                            "%s/.debug/[kernel.kallsyms]/%s",
+                            getenv("HOME"), sbuild_id) == -1)
+                       return -1;
+
+               if (access(kallsyms_filename, F_OK)) {
+                       free(kallsyms_allocated_filename);
+                       return -1;
+               }
+
+               kallsyms_filename = kallsyms_allocated_filename;
+       } else {
+               /*
+                * Last resort, if we don't have a build-id and couldn't find
+                * any vmlinux file, try the running kernel kallsyms table.
+                */
+               kallsyms_filename = "/proc/kallsyms";
+       }
+
+do_kallsyms:
+       err = dso__load_kallsyms(self, kallsyms_filename, map, session, filter);
+       free(kallsyms_allocated_filename);
+
+out_try_fixup:
        if (err > 0) {
+out_fixup:
+               if (kallsyms_filename != NULL)
+                       dso__set_long_name(self, strdup("[kernel.kallsyms]"));
                map__fixup_start(map);
                map__fixup_end(map);
        }
@@ -1397,34 +1680,33 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map,
        return err;
 }
 
-LIST_HEAD(dsos);
-struct dso     *vdso;
-
-const char     *vmlinux_name = "vmlinux";
+LIST_HEAD(dsos__user);
+LIST_HEAD(dsos__kernel);
+struct dso *vdso;
 
-static void dsos__add(struct dso *dso)
+static void dsos__add(struct list_head *head, struct dso *dso)
 {
-       list_add_tail(&dso->node, &dsos);
+       list_add_tail(&dso->node, head);
 }
 
-static struct dso *dsos__find(const char *name)
+static struct dso *dsos__find(struct list_head *head, const char *name)
 {
        struct dso *pos;
 
-       list_for_each_entry(pos, &dsos, node)
-               if (strcmp(pos->name, name) == 0)
+       list_for_each_entry(pos, head, node)
+               if (strcmp(pos->long_name, name) == 0)
                        return pos;
        return NULL;
 }
 
-struct dso *dsos__findnew(const char *name)
+struct dso *__dsos__findnew(struct list_head *head, const char *name)
 {
-       struct dso *dso = dsos__find(name);
+       struct dso *dso = dsos__find(head, name);
 
        if (!dso) {
                dso = dso__new(name);
                if (dso != NULL) {
-                       dsos__add(dso);
+                       dsos__add(head, dso);
                        dso__set_basename(dso);
                }
        }
@@ -1432,80 +1714,222 @@ struct dso *dsos__findnew(const char *name)
        return dso;
 }
 
-void dsos__fprintf(FILE *fp)
+static void __dsos__fprintf(struct list_head *head, FILE *fp)
 {
        struct dso *pos;
 
-       list_for_each_entry(pos, &dsos, node)
-               dso__fprintf(pos, fp);
+       list_for_each_entry(pos, head, node) {
+               int i;
+               for (i = 0; i < MAP__NR_TYPES; ++i)
+                       dso__fprintf(pos, i, fp);
+       }
 }
 
-size_t dsos__fprintf_buildid(FILE *fp)
+void dsos__fprintf(FILE *fp)
+{
+       __dsos__fprintf(&dsos__kernel, fp);
+       __dsos__fprintf(&dsos__user, fp);
+}
+
+static size_t __dsos__fprintf_buildid(struct list_head *head, FILE *fp,
+                                     bool with_hits)
 {
        struct dso *pos;
        size_t ret = 0;
 
-       list_for_each_entry(pos, &dsos, node) {
+       list_for_each_entry(pos, head, node) {
+               if (with_hits && !pos->hit)
+                       continue;
                ret += dso__fprintf_buildid(pos, fp);
                ret += fprintf(fp, " %s\n", pos->long_name);
        }
        return ret;
 }
 
-static int kernel_maps__create_kernel_map(void)
+size_t dsos__fprintf_buildid(FILE *fp, bool with_hits)
 {
-       struct dso *kernel = dso__new(vmlinux_name);
-
-       if (kernel == NULL)
-               return -1;
+       return (__dsos__fprintf_buildid(&dsos__kernel, fp, with_hits) +
+               __dsos__fprintf_buildid(&dsos__user, fp, with_hits));
+}
 
-       kernel_map = map__new2(0, kernel);
-       if (kernel_map == NULL)
-               goto out_delete_kernel_dso;
+static struct dso *dsos__create_kernel(const char *vmlinux)
+{
+       struct dso *kernel = dso__new(vmlinux ?: "[kernel.kallsyms]");
 
-       kernel_map->map_ip = kernel_map->unmap_ip = identity__map_ip;
+       if (kernel == NULL)
+               return NULL;
 
        kernel->short_name = "[kernel]";
-       kernel->kernel = 1;
+       kernel->kernel     = 1;
+
        vdso = dso__new("[vdso]");
        if (vdso == NULL)
-               goto out_delete_kernel_map;
+               goto out_delete_kernel_dso;
+       dso__set_loaded(vdso, MAP__FUNCTION);
 
        if (sysfs__read_build_id("/sys/kernel/notes", kernel->build_id,
                                 sizeof(kernel->build_id)) == 0)
                kernel->has_build_id = true;
 
-       kernel_maps__insert(kernel_map);
-       dsos__add(kernel);
-       dsos__add(vdso);
+       dsos__add(&dsos__kernel, kernel);
+       dsos__add(&dsos__user, vdso);
 
-       return 0;
+       return kernel;
 
-out_delete_kernel_map:
-       map__delete(kernel_map);
-       kernel_map = NULL;
 out_delete_kernel_dso:
        dso__delete(kernel);
-       return -1;
+       return NULL;
 }
 
-int kernel_maps__init(bool use_modules)
+int __map_groups__create_kernel_maps(struct map_groups *self,
+                                    struct map *vmlinux_maps[MAP__NR_TYPES],
+                                    struct dso *kernel)
 {
-       if (kernel_maps__create_kernel_map() < 0)
+       enum map_type type;
+
+       for (type = 0; type < MAP__NR_TYPES; ++type) {
+               vmlinux_maps[type] = map__new2(0, kernel, type);
+               if (vmlinux_maps[type] == NULL)
+                       return -1;
+
+               vmlinux_maps[type]->map_ip =
+                       vmlinux_maps[type]->unmap_ip = identity__map_ip;
+               map_groups__insert(self, vmlinux_maps[type]);
+       }
+
+       return 0;
+}
+
+static int map_groups__create_kernel_maps(struct map_groups *self,
+                                         struct map *vmlinux_maps[MAP__NR_TYPES],
+                                         const char *vmlinux)
+{
+       struct dso *kernel = dsos__create_kernel(vmlinux);
+
+       if (kernel == NULL)
                return -1;
 
-       if (use_modules && kernel_maps__create_module_maps() < 0)
-               pr_warning("Failed to load list of modules in use, "
-                          "continuing...\n");
-       /*
-        * Now that we have all the maps created, just set the ->end of them:
-        */
-       kernel_maps__fixup_end();
+       return __map_groups__create_kernel_maps(self, vmlinux_maps, kernel);
+}
+
+static void vmlinux_path__exit(void)
+{
+       while (--vmlinux_path__nr_entries >= 0) {
+               free(vmlinux_path[vmlinux_path__nr_entries]);
+               vmlinux_path[vmlinux_path__nr_entries] = NULL;
+       }
+
+       free(vmlinux_path);
+       vmlinux_path = NULL;
+}
+
+static int vmlinux_path__init(void)
+{
+       struct utsname uts;
+       char bf[PATH_MAX];
+
+       if (uname(&uts) < 0)
+               return -1;
+
+       vmlinux_path = malloc(sizeof(char *) * 5);
+       if (vmlinux_path == NULL)
+               return -1;
+
+       vmlinux_path[vmlinux_path__nr_entries] = strdup("vmlinux");
+       if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
+               goto out_fail;
+       ++vmlinux_path__nr_entries;
+       vmlinux_path[vmlinux_path__nr_entries] = strdup("/boot/vmlinux");
+       if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
+               goto out_fail;
+       ++vmlinux_path__nr_entries;
+       snprintf(bf, sizeof(bf), "/boot/vmlinux-%s", uts.release);
+       vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
+       if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
+               goto out_fail;
+       ++vmlinux_path__nr_entries;
+       snprintf(bf, sizeof(bf), "/lib/modules/%s/build/vmlinux", uts.release);
+       vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
+       if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
+               goto out_fail;
+       ++vmlinux_path__nr_entries;
+       snprintf(bf, sizeof(bf), "/usr/lib/debug/lib/modules/%s/vmlinux",
+                uts.release);
+       vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
+       if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
+               goto out_fail;
+       ++vmlinux_path__nr_entries;
+
        return 0;
+
+out_fail:
+       vmlinux_path__exit();
+       return -1;
 }
 
-void symbol__init(unsigned int priv_size)
+static int setup_list(struct strlist **list, const char *list_str,
+                     const char *list_name)
+{
+       if (list_str == NULL)
+               return 0;
+
+       *list = strlist__new(true, list_str);
+       if (!*list) {
+               pr_err("problems parsing %s list\n", list_name);
+               return -1;
+       }
+       return 0;
+}
+
+int symbol__init(void)
 {
        elf_version(EV_CURRENT);
-       symbol__priv_size = priv_size;
+       if (symbol_conf.sort_by_name)
+               symbol_conf.priv_size += (sizeof(struct symbol_name_rb_node) -
+                                         sizeof(struct symbol));
+
+       if (symbol_conf.try_vmlinux_path && vmlinux_path__init() < 0)
+               return -1;
+
+       if (symbol_conf.field_sep && *symbol_conf.field_sep == '.') {
+               pr_err("'.' is the only non valid --field-separator argument\n");
+               return -1;
+       }
+
+       if (setup_list(&symbol_conf.dso_list,
+                      symbol_conf.dso_list_str, "dso") < 0)
+               return -1;
+
+       if (setup_list(&symbol_conf.comm_list,
+                      symbol_conf.comm_list_str, "comm") < 0)
+               goto out_free_dso_list;
+
+       if (setup_list(&symbol_conf.sym_list,
+                      symbol_conf.sym_list_str, "symbol") < 0)
+               goto out_free_comm_list;
+
+       return 0;
+
+out_free_dso_list:
+       strlist__delete(symbol_conf.dso_list);
+out_free_comm_list:
+       strlist__delete(symbol_conf.comm_list);
+       return -1;
+}
+
+int perf_session__create_kernel_maps(struct perf_session *self)
+{
+       if (map_groups__create_kernel_maps(&self->kmaps, self->vmlinux_maps,
+                                          symbol_conf.vmlinux_name) < 0)
+               return -1;
+
+       if (symbol_conf.use_modules &&
+           perf_session__create_module_maps(self) < 0)
+               pr_debug("Failed to load list of modules for session %s, "
+                        "continuing...\n", self->filename);
+       /*
+        * Now that we have all the maps created, just set the ->end of them:
+        */
+       map_groups__fixup_end(&self->kmaps);
+       return 0;
 }