perf tools: Fix accidentally preprocessed snprintf callback
[safe/jmp/linux-2.6] / tools / perf / builtin-probe.c
index 520b064..bfc47ff 100644 (file)
 #include "builtin.h"
 #include "util/util.h"
 #include "util/strlist.h"
-#include "util/event.h"
-#include "util/debug.h"
 #include "util/symbol.h"
-#include "util/thread.h"
-#include "util/session.h"
+#include "util/debug.h"
+#include "util/debugfs.h"
 #include "util/parse-options.h"
 #include "util/parse-events.h" /* For debugfs_path */
 #include "util/probe-finder.h"
 #include "util/probe-event.h"
 
 #define MAX_PATH_LEN 256
-#define MAX_PROBES 128
 
 /* Session management structure */
 static struct {
-       bool need_dwarf;
        bool list_events;
        bool force_add;
-       int nr_probe;
-       struct probe_point probes[MAX_PROBES];
+       bool show_lines;
+       int nevents;
+       struct perf_probe_event events[MAX_PROBES];
        struct strlist *dellist;
-       struct symbol_conf conf;
-       struct perf_session *psession;
-       struct map *kmap;
-} session;
+       struct line_range line_range;
+} params;
 
 
 /* Parse an event definition. Note that any error must die. */
 static void parse_probe_event(const char *str)
 {
-       struct probe_point *pp = &session.probes[session.nr_probe];
+       struct perf_probe_event *pev = &params.events[params.nevents];
 
-       pr_debug("probe-definition(%d): %s\n", session.nr_probe, str);
-       if (++session.nr_probe == MAX_PROBES)
+       pr_debug("probe-definition(%d): %s\n", params.nevents, str);
+       if (++params.nevents == MAX_PROBES)
                die("Too many probes (> %d) are specified.", MAX_PROBES);
 
-       /* Parse perf-probe event into probe_point */
-       parse_perf_probe_event(str, pp, &session.need_dwarf);
+       /* Parse a perf-probe command into event */
+       parse_perf_probe_command(str, pev);
 
-       pr_debug("%d arguments\n", pp->nr_args);
+       pr_debug("%d arguments\n", pev->nargs);
 }
 
 static void parse_probe_event_argv(int argc, const char **argv)
@@ -87,9 +82,7 @@ static void parse_probe_event_argv(int argc, const char **argv)
        len = 0;
        for (i = 0; i < argc; i++)
                len += strlen(argv[i]) + 1;
-       buf = zalloc(len + 1);
-       if (!buf)
-               die("Failed to allocate memory for binding arguments.");
+       buf = xzalloc(len + 1);
        len = 0;
        for (i = 0; i < argc; i++)
                len += sprintf(&buf[len], "%s ", argv[i]);
@@ -109,33 +102,22 @@ static int opt_del_probe_event(const struct option *opt __used,
                               const char *str, int unset __used)
 {
        if (str) {
-               if (!session.dellist)
-                       session.dellist = strlist__new(true, NULL);
-               strlist__add(session.dellist, str);
+               if (!params.dellist)
+                       params.dellist = strlist__new(true, NULL);
+               strlist__add(params.dellist, str);
        }
        return 0;
 }
 
-/* Currently just checking function name from symbol map */
-static void evaluate_probe_point(struct probe_point *pp)
-{
-       struct symbol *sym;
-       sym = map__find_symbol_by_name(session.kmap, pp->function,
-                                      session.psession, NULL);
-       if (!sym)
-               die("Kernel symbol \'%s\' not found - probe not added.",
-                   pp->function);
-}
-
-#ifndef NO_LIBDWARF
-static int open_vmlinux(void)
+#ifdef DWARF_SUPPORT
+static int opt_show_lines(const struct option *opt __used,
+                         const char *str, int unset __used)
 {
-       if (map__load(session.kmap, session.psession, NULL) < 0) {
-               pr_debug("Failed to load kernel map.\n");
-               return -EINVAL;
-       }
-       pr_debug("Try to open %s\n", session.kmap->dso->long_name);
-       return open(session.kmap->dso->long_name, O_RDONLY);
+       if (str)
+               parse_line_range_desc(str, &params.line_range);
+       INIT_LIST_HEAD(&params.line_range.line_list);
+       params.show_lines = true;
+       return 0;
 }
 #endif
 
@@ -144,55 +126,58 @@ static const char * const probe_usage[] = {
        "perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]",
        "perf probe [<options>] --del '[GROUP:]EVENT' ...",
        "perf probe --list",
+#ifdef DWARF_SUPPORT
+       "perf probe --line 'LINEDESC'",
+#endif
        NULL
 };
 
 static const struct option options[] = {
-       OPT_BOOLEAN('v', "verbose", &verbose,
+       OPT_INCR('v', "verbose", &verbose,
                    "be more verbose (show parsed arguments, etc)"),
-#ifndef NO_LIBDWARF
-       OPT_STRING('k', "vmlinux", &session.conf.vmlinux_name,
-                  "file", "vmlinux pathname"),
-#endif
-       OPT_BOOLEAN('l', "list", &session.list_events,
+       OPT_BOOLEAN('l', "list", &params.list_events,
                    "list up current probe events"),
        OPT_CALLBACK('d', "del", NULL, "[GROUP:]EVENT", "delete a probe event.",
                opt_del_probe_event),
        OPT_CALLBACK('a', "add", NULL,
-#ifdef NO_LIBDWARF
-               "[EVENT=]FUNC[+OFFS|%return] [ARG ...]",
+#ifdef DWARF_SUPPORT
+               "[EVENT=]FUNC[@SRC][+OFF|%return|:RL|;PT]|SRC:AL|SRC;PT"
+               " [ARG ...]",
 #else
-               "[EVENT=]FUNC[+OFFS|%return|:RLN][@SRC]|SRC:ALN [ARG ...]",
+               "[EVENT=]FUNC[+OFF|%return] [ARG ...]",
 #endif
                "probe point definition, where\n"
                "\t\tGROUP:\tGroup name (optional)\n"
                "\t\tEVENT:\tEvent name\n"
                "\t\tFUNC:\tFunction name\n"
-               "\t\tOFFS:\tOffset from function entry (in byte)\n"
+               "\t\tOFF:\tOffset from function entry (in byte)\n"
                "\t\t%return:\tPut the probe at function return\n"
-#ifdef NO_LIBDWARF
-               "\t\tARG:\tProbe argument (only \n"
-#else
+#ifdef DWARF_SUPPORT
                "\t\tSRC:\tSource code path\n"
-               "\t\tRLN:\tRelative line number from function entry.\n"
-               "\t\tALN:\tAbsolute line number in file.\n"
+               "\t\tRL:\tRelative line number from function entry.\n"
+               "\t\tAL:\tAbsolute line number in file.\n"
+               "\t\tPT:\tLazy expression of line code.\n"
                "\t\tARG:\tProbe argument (local variable name or\n"
-#endif
                "\t\t\tkprobe-tracer argument format.)\n",
+#else
+               "\t\tARG:\tProbe argument (kprobe-tracer argument format.)\n",
+#endif
                opt_add_probe_event),
-       OPT_BOOLEAN('f', "force", &session.force_add, "forcibly add events"
+       OPT_BOOLEAN('f', "force", &params.force_add, "forcibly add events"
                    " with existing name"),
+#ifdef DWARF_SUPPORT
+       OPT_CALLBACK('L', "line", NULL,
+                    "FUNC[:RLN[+NUM|-RLN2]]|SRC:ALN[+NUM|-ALN2]",
+                    "Show source code lines.", opt_show_lines),
+       OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name,
+                  "file", "vmlinux pathname"),
+#endif
+       OPT__DRY_RUN(&probe_event_dry_run),
        OPT_END()
 };
 
 int cmd_probe(int argc, const char **argv, const char *prefix __used)
 {
-       int i, ret;
-#ifndef NO_LIBDWARF
-       int fd;
-#endif
-       struct probe_point *pp;
-
        argc = parse_options(argc, argv, options, probe_usage,
                             PARSE_OPT_STOP_AT_NON_OPTION);
        if (argc > 0) {
@@ -203,105 +188,48 @@ int cmd_probe(int argc, const char **argv, const char *prefix __used)
                parse_probe_event_argv(argc, argv);
        }
 
-       if ((!session.nr_probe && !session.dellist && !session.list_events))
+       if ((!params.nevents && !params.dellist && !params.list_events &&
+            !params.show_lines))
                usage_with_options(probe_usage, options);
 
-       if (session.list_events) {
-               if (session.nr_probe != 0 || session.dellist) {
+       if (debugfs_valid_mountpoint(debugfs_path) < 0)
+               die("Failed to find debugfs path.");
+
+       if (params.list_events) {
+               if (params.nevents != 0 || params.dellist) {
                        pr_warning("  Error: Don't use --list with"
                                   " --add/--del.\n");
                        usage_with_options(probe_usage, options);
                }
+               if (params.show_lines) {
+                       pr_warning("  Error: Don't use --list with --line.\n");
+                       usage_with_options(probe_usage, options);
+               }
                show_perf_probe_events();
                return 0;
        }
 
-       if (session.dellist) {
-               del_trace_kprobe_events(session.dellist);
-               strlist__delete(session.dellist);
-               if (session.nr_probe == 0)
-                       return 0;
-       }
-
-       /* Initialize symbol maps for vmlinux */
-       session.conf.sort_by_name = true;
-       if (session.conf.vmlinux_name == NULL)
-               session.conf.try_vmlinux_path = true;
-       if (symbol__init(&session.conf) < 0)
-               die("Failed to init symbol map.");
-       session.psession = perf_session__new(NULL, O_WRONLY, false,
-                                            &session.conf);
-       if (session.psession == NULL)
-               die("Failed to init perf_session.");
-       session.kmap = map_groups__find_by_name(&session.psession->kmaps,
-                                               MAP__FUNCTION,
-                                               "[kernel.kallsyms]");
-       if (!session.kmap)
-               die("Could not find kernel map.\n");
-
-       if (session.need_dwarf)
-#ifdef NO_LIBDWARF
-               die("Debuginfo-analysis is not supported");
-#else  /* !NO_LIBDWARF */
-               pr_debug("Some probes require debuginfo.\n");
-
-       fd = open_vmlinux();
-       if (fd < 0) {
-               if (session.need_dwarf)
-                       die("Could not open debuginfo file.");
-
-               pr_debug("Could not open vmlinux/module file."
-                        " Try to use symbols.\n");
-               goto end_dwarf;
-       }
-
-       /* Searching probe points */
-       for (i = 0; i < session.nr_probe; i++) {
-               pp = &session.probes[i];
-               if (pp->found)
-                       continue;
-
-               lseek(fd, SEEK_SET, 0);
-               ret = find_probepoint(fd, pp);
-               if (ret > 0)
-                       continue;
-               if (ret == 0) { /* No error but failed to find probe point. */
-                       synthesize_perf_probe_point(pp);
-                       die("Probe point '%s' not found. - probe not added.",
-                           pp->probes[0]);
-               }
-               /* Error path */
-               if (session.need_dwarf) {
-                       if (ret == -ENOENT)
-                               pr_warning("No dwarf info found in the vmlinux - please rebuild with CONFIG_DEBUG_INFO=y.\n");
-                       die("Could not analyze debuginfo.");
+#ifdef DWARF_SUPPORT
+       if (params.show_lines) {
+               if (params.nevents != 0 || params.dellist) {
+                       pr_warning("  Error: Don't use --line with"
+                                  " --add/--del.\n");
+                       usage_with_options(probe_usage, options);
                }
-               pr_debug("An error occurred in debuginfo analysis."
-                        " Try to use symbols.\n");
-               break;
-       }
-       close(fd);
 
-end_dwarf:
-#endif /* !NO_LIBDWARF */
-
-       /* Synthesize probes without dwarf */
-       for (i = 0; i < session.nr_probe; i++) {
-               pp = &session.probes[i];
-               if (pp->found)  /* This probe is already found. */
-                       continue;
+               show_line_range(&params.line_range);
+               return 0;
+       }
+#endif
 
-               evaluate_probe_point(pp);
-               ret = synthesize_trace_kprobe_event(pp);
-               if (ret == -E2BIG)
-                       die("probe point definition becomes too long.");
-               else if (ret < 0)
-                       die("Failed to synthesize a probe point.");
+       if (params.dellist) {
+               del_perf_probe_events(params.dellist);
+               strlist__delete(params.dellist);
+               if (params.nevents == 0)
+                       return 0;
        }
 
-       /* Settng up probe points */
-       add_trace_kprobe_events(session.probes, session.nr_probe,
-                               session.force_add);
+       add_perf_probe_events(params.events, params.nevents, params.force_add);
        return 0;
 }