include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit...
[safe/jmp/linux-2.6] / sound / pci / rme9652 / hdsp.c
index 0db558a..b92adef 100644 (file)
  *
  */
 
-#include <sound/driver.h>
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
-#include <linux/slab.h>
 #include <linux/pci.h>
 #include <linux/firmware.h>
 #include <linux/moduleparam.h>
+#include <linux/math64.h>
 
 #include <sound/core.h>
 #include <sound/control.h>
@@ -60,6 +59,12 @@ MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
                "{RME HDSP-9652},"
                "{RME HDSP-9632}}");
+#ifdef HDSP_FW_LOADER
+MODULE_FIRMWARE("multiface_firmware.bin");
+MODULE_FIRMWARE("multiface_firmware_rev11.bin");
+MODULE_FIRMWARE("digiface_firmware.bin");
+MODULE_FIRMWARE("digiface_firmware_rev11.bin");
+#endif
 
 #define HDSP_MAX_CHANNELS        26
 #define HDSP_MAX_DS_CHANNELS     14
@@ -80,6 +85,7 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 /* Write registers. These are defined as byte-offsets from the iobase value.
  */
 #define HDSP_resetPointer               0
+#define HDSP_freqReg                   0
 #define HDSP_outputBufferAddress       32
 #define HDSP_inputBufferAddress                36
 #define HDSP_controlRegister           64
@@ -97,8 +103,6 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_statusRegister    0
 #define HDSP_timecode        128
 #define HDSP_status2Register 192
-#define HDSP_midiDataOut0    352
-#define HDSP_midiDataOut1    356
 #define HDSP_midiDataIn0     360
 #define HDSP_midiDataIn1     364
 #define HDSP_midiStatusOut0  384
@@ -109,7 +113,7 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 
 /* the meters are regular i/o-mapped registers, but offset
    considerably from the rest. the peak registers are reset
-   when read; the least-significant 4 bits are full-scale counters; 
+   when read; the least-significant 4 bits are full-scale counters;
    the actual peak value is in the most-significant 24 bits.
 */
 
@@ -127,7 +131,7 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
    26*3 values are read in ss mode
    14*3 in ds mode, with no gap between values
 */
-#define HDSP_9652_peakBase     7164    
+#define HDSP_9652_peakBase     7164
 #define HDSP_9652_rmsBase      4096
 
 /* c.f. the hdsp_9632_meters_t struct */
@@ -169,12 +173,12 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_SPDIFEmphasis        (1<<10) /* 0=none, 1=on */
 #define HDSP_SPDIFNonAudio        (1<<11) /* 0=off, 1=on */
 #define HDSP_SPDIFOpticalOut      (1<<12) /* 1=use 1st ADAT connector for SPDIF, 0=do not */
-#define HDSP_SyncRef2             (1<<13) 
-#define HDSP_SPDIFInputSelect0    (1<<14) 
-#define HDSP_SPDIFInputSelect1    (1<<15) 
-#define HDSP_SyncRef0             (1<<16) 
+#define HDSP_SyncRef2             (1<<13)
+#define HDSP_SPDIFInputSelect0    (1<<14)
+#define HDSP_SPDIFInputSelect1    (1<<15)
+#define HDSP_SyncRef0             (1<<16)
 #define HDSP_SyncRef1             (1<<17)
-#define HDSP_AnalogExtensionBoard (1<<18) /* For H9632 cards */ 
+#define HDSP_AnalogExtensionBoard (1<<18) /* For H9632 cards */
 #define HDSP_XLRBreakoutCable     (1<<20) /* For H9632 cards */
 #define HDSP_Midi0InterruptEnable (1<<22)
 #define HDSP_Midi1InterruptEnable (1<<23)
@@ -274,6 +278,11 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_Frequency128KHz   (HDSP_QuadSpeed|HDSP_DoubleSpeed|HDSP_Frequency0)
 #define HDSP_Frequency176_4KHz (HDSP_QuadSpeed|HDSP_DoubleSpeed|HDSP_Frequency1)
 #define HDSP_Frequency192KHz   (HDSP_QuadSpeed|HDSP_DoubleSpeed|HDSP_Frequency1|HDSP_Frequency0)
+/* RME says n = 104857600000000, but in the windows MADI driver, I see:
+       return 104857600000000 / rate; // 100 MHz
+       return 110100480000000 / rate; // 105 MHz
+*/
+#define DDS_NUMERATOR 104857600000000ULL;  /*  =  2^20 * 10^8 */
 
 #define hdsp_encode_latency(x)       (((x)<<1) & HDSP_LatencyMask)
 #define hdsp_decode_latency(x)       (((x) & HDSP_LatencyMask)>>1)
@@ -305,10 +314,14 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_TimecodeSync       (1<<27)
 #define HDSP_AEBO              (1<<28) /* H9632 specific Analog Extension Boards */
 #define HDSP_AEBI              (1<<29) /* 0 = present, 1 = absent */
-#define HDSP_midi0IRQPending    (1<<30) 
+#define HDSP_midi0IRQPending    (1<<30)
 #define HDSP_midi1IRQPending    (1<<31)
 
 #define HDSP_spdifFrequencyMask    (HDSP_spdifFrequency0|HDSP_spdifFrequency1|HDSP_spdifFrequency2)
+#define HDSP_spdifFrequencyMask_9632 (HDSP_spdifFrequency0|\
+                                     HDSP_spdifFrequency1|\
+                                     HDSP_spdifFrequency2|\
+                                     HDSP_spdifFrequency3)
 
 #define HDSP_spdifFrequency32KHz   (HDSP_spdifFrequency0)
 #define HDSP_spdifFrequency44_1KHz (HDSP_spdifFrequency1)
@@ -319,7 +332,9 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_spdifFrequency96KHz   (HDSP_spdifFrequency2|HDSP_spdifFrequency1)
 
 /* This is for H9632 cards */
-#define HDSP_spdifFrequency128KHz   HDSP_spdifFrequencyMask
+#define HDSP_spdifFrequency128KHz   (HDSP_spdifFrequency0|\
+                                    HDSP_spdifFrequency1|\
+                                    HDSP_spdifFrequency2)
 #define HDSP_spdifFrequency176_4KHz HDSP_spdifFrequency3
 #define HDSP_spdifFrequency192KHz   (HDSP_spdifFrequency3|HDSP_spdifFrequency0)
 
@@ -370,20 +385,13 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define UNITY_GAIN                       32768
 #define MINUS_INFINITY_GAIN              0
 
-#ifndef PCI_VENDOR_ID_XILINX
-#define PCI_VENDOR_ID_XILINX           0x10ee
-#endif
-#ifndef PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP
-#define PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP 0x3fc5
-#endif
-
 /* the size of a substream (1 mono data stream) */
 
 #define HDSP_CHANNEL_BUFFER_SAMPLES  (16*1024)
 #define HDSP_CHANNEL_BUFFER_BYTES    (4*HDSP_CHANNEL_BUFFER_SAMPLES)
 
 /* the size of the area we need to allocate for DMA transfers. the
-   size is the same regardless of the number of channels - the 
+   size is the same regardless of the number of channels - the
    Multiface still uses the same memory area.
 
    Note that we allocate 1 more channel than is apparently needed
@@ -394,18 +402,14 @@ MODULE_SUPPORTED_DEVICE("{{RME Hammerfall-DSP},"
 #define HDSP_DMA_AREA_BYTES ((HDSP_MAX_CHANNELS+1) * HDSP_CHANNEL_BUFFER_BYTES)
 #define HDSP_DMA_AREA_KILOBYTES (HDSP_DMA_AREA_BYTES/1024)
 
-/* use hotplug firmeare loader? */
+/* use hotplug firmware loader? */
 #if defined(CONFIG_FW_LOADER) || defined(CONFIG_FW_LOADER_MODULE)
-#ifndef HDSP_USE_HWDEP_LOADER
+#if !defined(HDSP_USE_HWDEP_LOADER)
 #define HDSP_FW_LOADER
 #endif
 #endif
 
-typedef struct _hdsp             hdsp_t;
-typedef struct _hdsp_midi        hdsp_midi_t;
-typedef struct _hdsp_9632_meters hdsp_9632_meters_t;
-
-struct _hdsp_9632_meters {
+struct hdsp_9632_meters {
     u32 input_peak[16];
     u32 playback_peak[16];
     u32 output_peak[16];
@@ -421,23 +425,23 @@ struct _hdsp_9632_meters {
     u32 xxx_rms_high[16];
 };
 
-struct _hdsp_midi {
-    hdsp_t                  *hdsp;
+struct hdsp_midi {
+    struct hdsp             *hdsp;
     int                      id;
-    snd_rawmidi_t           *rmidi;
-    snd_rawmidi_substream_t *input;
-    snd_rawmidi_substream_t *output;
+    struct snd_rawmidi           *rmidi;
+    struct snd_rawmidi_substream *input;
+    struct snd_rawmidi_substream *output;
     char                     istimer; /* timer in use */
     struct timer_list       timer;
     spinlock_t               lock;
     int                             pending;
 };
 
-struct _hdsp {
+struct hdsp {
        spinlock_t            lock;
-       snd_pcm_substream_t  *capture_substream;
-       snd_pcm_substream_t  *playback_substream;
-        hdsp_midi_t           midi[2];
+       struct snd_pcm_substream *capture_substream;
+       struct snd_pcm_substream *playback_substream;
+        struct hdsp_midi      midi[2];
        struct tasklet_struct midi_tasklet;
        int                   use_midi_tasklet;
        int                   precise_ptr;
@@ -447,7 +451,7 @@ struct _hdsp {
        u32                   creg_spdif_stream;
        int                   clock_source_locked;
        char                 *card_name;             /* digiface/multiface */
-       HDSP_IO_Type          io_type;               /* ditto, but for code use */
+       enum HDSP_IO_Type     io_type;               /* ditto, but for code use */
         unsigned short        firmware_rev;
        unsigned short        state;                 /* stores state bits */
        u32                   firmware_cache[24413]; /* this helps recover from accidental iobox power failure */
@@ -456,7 +460,7 @@ struct _hdsp {
        unsigned char         qs_in_channels;        /* quad speed mode for H9632 */
        unsigned char         ds_in_channels;
        unsigned char         ss_in_channels;       /* different for multiface/digiface */
-       unsigned char         qs_out_channels;      
+       unsigned char         qs_out_channels;
        unsigned char         ds_out_channels;
        unsigned char         ss_out_channels;
 
@@ -474,12 +478,13 @@ struct _hdsp {
        int                   irq;
        unsigned long         port;
         void __iomem         *iobase;
-       snd_card_t           *card;
-       snd_pcm_t            *pcm;
-       snd_hwdep_t          *hwdep;
+       struct snd_card *card;
+       struct snd_pcm *pcm;
+       struct snd_hwdep          *hwdep;
        struct pci_dev       *pci;
-       snd_kcontrol_t       *spdif_ctl;
+       struct snd_kcontrol *spdif_ctl;
         unsigned short        mixer_matrix[HDSP_MATRIX_MIXER_SIZE];
+       unsigned int          dds_value; /* last value written to freq register */
 };
 
 /* These tables map the ALSA channels 1..N to the channels that we
@@ -497,9 +502,9 @@ static char channel_map_df_ss[HDSP_MAX_CHANNELS] = {
 
 static char channel_map_mf_ss[HDSP_MAX_CHANNELS] = { /* Multiface */
        /* Analog */
-       0, 1, 2, 3, 4, 5, 6, 7, 
+       0, 1, 2, 3, 4, 5, 6, 7,
        /* ADAT 2 */
-       16, 17, 18, 19, 20, 21, 22, 23, 
+       16, 17, 18, 19, 20, 21, 22, 23,
        /* SPDIF */
        24, 25,
        -1, -1, -1, -1, -1, -1, -1, -1
@@ -520,11 +525,11 @@ static char channel_map_H9632_ss[HDSP_MAX_CHANNELS] = {
        /* SPDIF */
        8, 9,
        /* Analog */
-       10, 11, 
+       10, 11,
        /* AO4S-192 and AI4S-192 extension boards */
        12, 13, 14, 15,
        /* others don't exist */
-       -1, -1, -1, -1, -1, -1, -1, -1, 
+       -1, -1, -1, -1, -1, -1, -1, -1,
        -1, -1
 };
 
@@ -534,7 +539,7 @@ static char channel_map_H9632_ds[HDSP_MAX_CHANNELS] = {
        /* SPDIF */
        8, 9,
        /* Analog */
-       10, 11, 
+       10, 11,
        /* AO4S-192 and AI4S-192 extension boards */
        12, 13, 14, 15,
        /* others don't exist */
@@ -579,10 +584,10 @@ static void snd_hammerfall_free_buffer(struct snd_dma_buffer *dmab, struct pci_d
 }
 
 
-static struct pci_device_id snd_hdsp_ids[] = {
+static DEFINE_PCI_DEVICE_TABLE(snd_hdsp_ids) = {
        {
                .vendor = PCI_VENDOR_ID_XILINX,
-               .device = PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP, 
+               .device = PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP,
                .subvendor = PCI_ANY_ID,
                .subdevice = PCI_ANY_ID,
        }, /* RME Hammerfall-DSP */
@@ -592,55 +597,62 @@ static struct pci_device_id snd_hdsp_ids[] = {
 MODULE_DEVICE_TABLE(pci, snd_hdsp_ids);
 
 /* prototypes */
-static int snd_hdsp_create_alsa_devices(snd_card_t *card, hdsp_t *hdsp);
-static int snd_hdsp_create_pcm(snd_card_t *card, hdsp_t *hdsp);
-static int snd_hdsp_enable_io (hdsp_t *hdsp);
-static void snd_hdsp_initialize_midi_flush (hdsp_t *hdsp);
-static void snd_hdsp_initialize_channels (hdsp_t *hdsp);
-static int hdsp_fifo_wait(hdsp_t *hdsp, int count, int timeout);
-static int hdsp_autosync_ref(hdsp_t *hdsp);
-static int snd_hdsp_set_defaults(hdsp_t *hdsp);
-static void snd_hdsp_9652_enable_mixer (hdsp_t *hdsp);
-
-static int hdsp_playback_to_output_key (hdsp_t *hdsp, int in, int out)
-{
-       switch (hdsp->firmware_rev) {
-       case 0xa:
-               return (64 * out) + (32 + (in));
-       case 0x96:
-       case 0x97:
-               return (32 * out) + (16 + (in));
+static int snd_hdsp_create_alsa_devices(struct snd_card *card, struct hdsp *hdsp);
+static int snd_hdsp_create_pcm(struct snd_card *card, struct hdsp *hdsp);
+static int snd_hdsp_enable_io (struct hdsp *hdsp);
+static void snd_hdsp_initialize_midi_flush (struct hdsp *hdsp);
+static void snd_hdsp_initialize_channels (struct hdsp *hdsp);
+static int hdsp_fifo_wait(struct hdsp *hdsp, int count, int timeout);
+static int hdsp_autosync_ref(struct hdsp *hdsp);
+static int snd_hdsp_set_defaults(struct hdsp *hdsp);
+static void snd_hdsp_9652_enable_mixer (struct hdsp *hdsp);
+
+static int hdsp_playback_to_output_key (struct hdsp *hdsp, int in, int out)
+{
+       switch (hdsp->io_type) {
+       case Multiface:
+       case Digiface:
        default:
+               if (hdsp->firmware_rev == 0xa)
+                       return (64 * out) + (32 + (in));
+               else
+                       return (52 * out) + (26 + (in));
+       case H9632:
+               return (32 * out) + (16 + (in));
+       case H9652:
                return (52 * out) + (26 + (in));
        }
 }
 
-static int hdsp_input_to_output_key (hdsp_t *hdsp, int in, int out)
+static int hdsp_input_to_output_key (struct hdsp *hdsp, int in, int out)
 {
-       switch (hdsp->firmware_rev) {
-       case 0xa:
-               return (64 * out) + in;
-       case 0x96:
-       case 0x97:
-               return (32 * out) + in;
+       switch (hdsp->io_type) {
+       case Multiface:
+       case Digiface:
        default:
+               if (hdsp->firmware_rev == 0xa)
+                       return (64 * out) + in;
+               else
+                       return (52 * out) + in;
+       case H9632:
+               return (32 * out) + in;
+       case H9652:
                return (52 * out) + in;
        }
 }
 
-static void hdsp_write(hdsp_t *hdsp, int reg, int val)
+static void hdsp_write(struct hdsp *hdsp, int reg, int val)
 {
        writel(val, hdsp->iobase + reg);
 }
 
-static unsigned int hdsp_read(hdsp_t *hdsp, int reg)
+static unsigned int hdsp_read(struct hdsp *hdsp, int reg)
 {
        return readl (hdsp->iobase + reg);
 }
 
-static int hdsp_check_for_iobox (hdsp_t *hdsp)
+static int hdsp_check_for_iobox (struct hdsp *hdsp)
 {
-
        if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return 0;
        if (hdsp_read (hdsp, HDSP_statusRegister) & HDSP_ConfigError) {
                snd_printk ("Hammerfall-DSP: no Digiface or Multiface connected!\n");
@@ -648,28 +660,50 @@ static int hdsp_check_for_iobox (hdsp_t *hdsp)
                return -EIO;
        }
        return 0;
+}
 
+static int hdsp_wait_for_iobox(struct hdsp *hdsp, unsigned int loops,
+                              unsigned int delay)
+{
+       unsigned int i;
+
+       if (hdsp->io_type == H9652 || hdsp->io_type == H9632)
+               return 0;
+
+       for (i = 0; i != loops; ++i) {
+               if (hdsp_read(hdsp, HDSP_statusRegister) & HDSP_ConfigError)
+                       msleep(delay);
+               else {
+                       snd_printd("Hammerfall-DSP: iobox found after %ums!\n",
+                                  i * delay);
+                       return 0;
+               }
+       }
+
+       snd_printk("Hammerfall-DSP: no Digiface or Multiface connected!\n");
+       hdsp->state &= ~HDSP_FirmwareLoaded;
+       return -EIO;
 }
 
-static int snd_hdsp_load_firmware_from_cache(hdsp_t *hdsp) {
+static int snd_hdsp_load_firmware_from_cache(struct hdsp *hdsp) {
 
        int i;
        unsigned long flags;
 
        if ((hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DllError) != 0) {
-               
+
                snd_printk ("Hammerfall-DSP: loading firmware\n");
 
                hdsp_write (hdsp, HDSP_control2Reg, HDSP_S_PROGRAM);
                hdsp_write (hdsp, HDSP_fifoData, 0);
-               
+
                if (hdsp_fifo_wait (hdsp, 0, HDSP_LONG_WAIT)) {
                        snd_printk ("Hammerfall-DSP: timeout waiting for download preparation\n");
                        return -EIO;
                }
-               
+
                hdsp_write (hdsp, HDSP_control2Reg, HDSP_S_LOAD);
-               
+
                for (i = 0; i < 24413; ++i) {
                        hdsp_write(hdsp, HDSP_fifoData, hdsp->firmware_cache[i]);
                        if (hdsp_fifo_wait (hdsp, 127, HDSP_LONG_WAIT)) {
@@ -678,13 +712,8 @@ static int snd_hdsp_load_firmware_from_cache(hdsp_t *hdsp) {
                        }
                }
 
-               if ((1000 / HZ) < 3000) {
-                       set_current_state(TASK_UNINTERRUPTIBLE);
-                       schedule_timeout((3000 * HZ + 999) / 1000);
-               } else {
-                       mdelay(3000);
-               }
-               
+               ssleep(3);
+
                if (hdsp_fifo_wait (hdsp, 0, HDSP_LONG_WAIT)) {
                        snd_printk ("Hammerfall-DSP: timeout at end of firmware loading\n");
                        return -EIO;
@@ -697,29 +726,28 @@ static int snd_hdsp_load_firmware_from_cache(hdsp_t *hdsp) {
 #endif
                hdsp_write (hdsp, HDSP_control2Reg, hdsp->control2_register);
                snd_printk ("Hammerfall-DSP: finished firmware loading\n");
-               
+
        }
        if (hdsp->state & HDSP_InitializationComplete) {
-               snd_printk("Hammerfall-DSP: firmware loaded from cache, restoring defaults\n");
+               snd_printk(KERN_INFO "Hammerfall-DSP: firmware loaded from cache, restoring defaults\n");
                spin_lock_irqsave(&hdsp->lock, flags);
                snd_hdsp_set_defaults(hdsp);
-               spin_unlock_irqrestore(&hdsp->lock, flags); 
+               spin_unlock_irqrestore(&hdsp->lock, flags);
        }
-       
+
        hdsp->state |= HDSP_FirmwareLoaded;
 
        return 0;
 }
 
-static int hdsp_get_iobox_version (hdsp_t *hdsp)
+static int hdsp_get_iobox_version (struct hdsp *hdsp)
 {
        if ((hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DllError) != 0) {
-       
+
                hdsp_write (hdsp, HDSP_control2Reg, HDSP_PROGRAM);
                hdsp_write (hdsp, HDSP_fifoData, 0);
-               if (hdsp_fifo_wait (hdsp, 0, HDSP_SHORT_WAIT) < 0) {
+               if (hdsp_fifo_wait (hdsp, 0, HDSP_SHORT_WAIT) < 0)
                        return -EIO;
-               }
 
                hdsp_write (hdsp, HDSP_control2Reg, HDSP_S_LOAD);
                hdsp_write (hdsp, HDSP_fifoData, 0);
@@ -731,39 +759,61 @@ static int hdsp_get_iobox_version (hdsp_t *hdsp)
                        hdsp_fifo_wait (hdsp, 0, HDSP_SHORT_WAIT);
                } else {
                        hdsp->io_type = Digiface;
-               } 
+               }
        } else {
                /* firmware was already loaded, get iobox type */
-               if (hdsp_read(hdsp, HDSP_status2Register) & HDSP_version1) {
+               if (hdsp_read(hdsp, HDSP_status2Register) & HDSP_version1)
                        hdsp->io_type = Multiface;
-               } else {
+               else
                        hdsp->io_type = Digiface;
-               }
        }
        return 0;
 }
 
 
-static int hdsp_check_for_firmware (hdsp_t *hdsp)
+#ifdef HDSP_FW_LOADER
+static int hdsp_request_fw_loader(struct hdsp *hdsp);
+#endif
+
+static int hdsp_check_for_firmware (struct hdsp *hdsp, int load_on_demand)
 {
-       if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return 0;
+       if (hdsp->io_type == H9652 || hdsp->io_type == H9632)
+               return 0;
        if ((hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DllError) != 0) {
-               snd_printk("Hammerfall-DSP: firmware not present.\n");
                hdsp->state &= ~HDSP_FirmwareLoaded;
-               return -EIO;
+               if (! load_on_demand)
+                       return -EIO;
+               snd_printk(KERN_ERR "Hammerfall-DSP: firmware not present.\n");
+               /* try to load firmware */
+               if (! (hdsp->state & HDSP_FirmwareCached)) {
+#ifdef HDSP_FW_LOADER
+                       if (! hdsp_request_fw_loader(hdsp))
+                               return 0;
+#endif
+                       snd_printk(KERN_ERR
+                                  "Hammerfall-DSP: No firmware loaded nor "
+                                  "cached, please upload firmware.\n");
+                       return -EIO;
+               }
+               if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
+                       snd_printk(KERN_ERR
+                                  "Hammerfall-DSP: Firmware loading from "
+                                  "cache failed, please upload manually.\n");
+                       return -EIO;
+               }
        }
        return 0;
 }
 
 
-static int hdsp_fifo_wait(hdsp_t *hdsp, int count, int timeout)
-{    
+static int hdsp_fifo_wait(struct hdsp *hdsp, int count, int timeout)
+{
        int i;
 
        /* the fifoStatus registers reports on how many words
           are available in the command FIFO.
        */
-       
+
        for (i = 0; i < timeout; i++) {
 
                if ((int)(hdsp_read (hdsp, HDSP_fifoStatus) & 0xff) <= count)
@@ -781,25 +831,25 @@ static int hdsp_fifo_wait(hdsp_t *hdsp, int count, int timeout)
        return -1;
 }
 
-static int hdsp_read_gain (hdsp_t *hdsp, unsigned int addr)
+static int hdsp_read_gain (struct hdsp *hdsp, unsigned int addr)
 {
-       if (addr >= HDSP_MATRIX_MIXER_SIZE) {
+       if (addr >= HDSP_MATRIX_MIXER_SIZE)
                return 0;
-       }
+
        return hdsp->mixer_matrix[addr];
 }
 
-static int hdsp_write_gain(hdsp_t *hdsp, unsigned int addr, unsigned short data)
+static int hdsp_write_gain(struct hdsp *hdsp, unsigned int addr, unsigned short data)
 {
        unsigned int ad;
 
        if (addr >= HDSP_MATRIX_MIXER_SIZE)
                return -1;
-       
+
        if (hdsp->io_type == H9652 || hdsp->io_type == H9632) {
 
                /* from martin bjornsen:
-                  
+
                   "You can only write dwords to the
                   mixer memory which contain two
                   mixer values in the low and high
@@ -810,17 +860,15 @@ static int hdsp_write_gain(hdsp_t *hdsp, unsigned int addr, unsigned short data)
                   memory."
                */
 
-               if (hdsp->io_type == H9632 && addr >= 512) {
+               if (hdsp->io_type == H9632 && addr >= 512)
                        return 0;
-               }
 
-               if (hdsp->io_type == H9652 && addr >= 1352) {
+               if (hdsp->io_type == H9652 && addr >= 1352)
                        return 0;
-               }
 
                hdsp->mixer_matrix[addr] = data;
 
-               
+
                /* `addr' addresses a 16-bit wide address, but
                   the address space accessed via hdsp_write
                   uses byte offsets. put another way, addr
@@ -829,20 +877,19 @@ static int hdsp_write_gain(hdsp_t *hdsp, unsigned int addr, unsigned short data)
                   to access 0 to 2703 ...
                */
                ad = addr/2;
-       
-               hdsp_write (hdsp, 4096 + (ad*4), 
-                           (hdsp->mixer_matrix[(addr&0x7fe)+1] << 16) + 
+
+               hdsp_write (hdsp, 4096 + (ad*4),
+                           (hdsp->mixer_matrix[(addr&0x7fe)+1] << 16) +
                            hdsp->mixer_matrix[addr&0x7fe]);
-               
+
                return 0;
 
        } else {
 
                ad = (addr << 16) + data;
-               
-               if (hdsp_fifo_wait(hdsp, 127, HDSP_LONG_WAIT)) {
+
+               if (hdsp_fifo_wait(hdsp, 127, HDSP_LONG_WAIT))
                        return -1;
-               }
 
                hdsp_write (hdsp, HDSP_fifoData, ad);
                hdsp->mixer_matrix[addr] = data;
@@ -852,46 +899,31 @@ static int hdsp_write_gain(hdsp_t *hdsp, unsigned int addr, unsigned short data)
        return 0;
 }
 
-static int snd_hdsp_use_is_exclusive(hdsp_t *hdsp)
+static int snd_hdsp_use_is_exclusive(struct hdsp *hdsp)
 {
        unsigned long flags;
        int ret = 1;
 
        spin_lock_irqsave(&hdsp->lock, flags);
        if ((hdsp->playback_pid != hdsp->capture_pid) &&
-           (hdsp->playback_pid >= 0) && (hdsp->capture_pid >= 0)) {
+           (hdsp->playback_pid >= 0) && (hdsp->capture_pid >= 0))
                ret = 0;
-       }
        spin_unlock_irqrestore(&hdsp->lock, flags);
        return ret;
 }
 
-static int hdsp_external_sample_rate (hdsp_t *hdsp)
-{
-       unsigned int status2 = hdsp_read(hdsp, HDSP_status2Register);
-       unsigned int rate_bits = status2 & HDSP_systemFrequencyMask;
-
-       switch (rate_bits) {
-       case HDSP_systemFrequency32:   return 32000;
-       case HDSP_systemFrequency44_1: return 44100;
-       case HDSP_systemFrequency48:   return 48000;
-       case HDSP_systemFrequency64:   return 64000;
-       case HDSP_systemFrequency88_2: return 88200;
-       case HDSP_systemFrequency96:   return 96000;
-       default:
-               return 0;
-       }
-}
-
-static int hdsp_spdif_sample_rate(hdsp_t *hdsp)
+static int hdsp_spdif_sample_rate(struct hdsp *hdsp)
 {
        unsigned int status = hdsp_read(hdsp, HDSP_statusRegister);
        unsigned int rate_bits = (status & HDSP_spdifFrequencyMask);
 
-       if (status & HDSP_SPDIFErrorFlag) {
+       /* For the 9632, the mask is different */
+       if (hdsp->io_type == H9632)
+                rate_bits = (status & HDSP_spdifFrequencyMask_9632);
+
+       if (status & HDSP_SPDIFErrorFlag)
                return 0;
-       }
-       
+
        switch (rate_bits) {
        case HDSP_spdifFrequency32KHz: return 32000;
        case HDSP_spdifFrequency44_1KHz: return 44100;
@@ -899,13 +931,13 @@ static int hdsp_spdif_sample_rate(hdsp_t *hdsp)
        case HDSP_spdifFrequency64KHz: return 64000;
        case HDSP_spdifFrequency88_2KHz: return 88200;
        case HDSP_spdifFrequency96KHz: return 96000;
-       case HDSP_spdifFrequency128KHz: 
+       case HDSP_spdifFrequency128KHz:
                if (hdsp->io_type == H9632) return 128000;
                break;
-       case HDSP_spdifFrequency176_4KHz: 
+       case HDSP_spdifFrequency176_4KHz:
                if (hdsp->io_type == H9632) return 176400;
                break;
-       case HDSP_spdifFrequency192KHz: 
+       case HDSP_spdifFrequency192KHz:
                if (hdsp->io_type == H9632) return 192000;
                break;
        default:
@@ -915,20 +947,44 @@ static int hdsp_spdif_sample_rate(hdsp_t *hdsp)
        return 0;
 }
 
-static void hdsp_compute_period_size(hdsp_t *hdsp)
+static int hdsp_external_sample_rate(struct hdsp *hdsp)
+{
+       unsigned int status2 = hdsp_read(hdsp, HDSP_status2Register);
+       unsigned int rate_bits = status2 & HDSP_systemFrequencyMask;
+
+       /* For the 9632 card, there seems to be no bit for indicating external
+        * sample rate greater than 96kHz. The card reports the corresponding
+        * single speed. So the best means seems to get spdif rate when
+        * autosync reference is spdif */
+       if (hdsp->io_type == H9632 &&
+           hdsp_autosync_ref(hdsp) == HDSP_AUTOSYNC_FROM_SPDIF)
+                return hdsp_spdif_sample_rate(hdsp);
+
+       switch (rate_bits) {
+       case HDSP_systemFrequency32:   return 32000;
+       case HDSP_systemFrequency44_1: return 44100;
+       case HDSP_systemFrequency48:   return 48000;
+       case HDSP_systemFrequency64:   return 64000;
+       case HDSP_systemFrequency88_2: return 88200;
+       case HDSP_systemFrequency96:   return 96000;
+       default:
+               return 0;
+       }
+}
+
+static void hdsp_compute_period_size(struct hdsp *hdsp)
 {
        hdsp->period_bytes = 1 << ((hdsp_decode_latency(hdsp->control_register) + 8));
 }
 
-static snd_pcm_uframes_t hdsp_hw_pointer(hdsp_t *hdsp)
+static snd_pcm_uframes_t hdsp_hw_pointer(struct hdsp *hdsp)
 {
        int position;
 
        position = hdsp_read(hdsp, HDSP_statusRegister);
 
-       if (!hdsp->precise_ptr) {
+       if (!hdsp->precise_ptr)
                return (position & HDSP_BufferID) ? (hdsp->period_bytes / 4) : 0;
-       }
 
        position &= HDSP_BufferPositionMask;
        position /= 4;
@@ -936,29 +992,34 @@ static snd_pcm_uframes_t hdsp_hw_pointer(hdsp_t *hdsp)
        return position;
 }
 
-static void hdsp_reset_hw_pointer(hdsp_t *hdsp)
+static void hdsp_reset_hw_pointer(struct hdsp *hdsp)
 {
        hdsp_write (hdsp, HDSP_resetPointer, 0);
+       if (hdsp->io_type == H9632 && hdsp->firmware_rev >= 152)
+               /* HDSP_resetPointer = HDSP_freqReg, which is strange and
+                * requires (?) to write again DDS value after a reset pointer
+                * (at least, it works like this) */
+               hdsp_write (hdsp, HDSP_freqReg, hdsp->dds_value);
 }
 
-static void hdsp_start_audio(hdsp_t *s)
+static void hdsp_start_audio(struct hdsp *s)
 {
        s->control_register |= (HDSP_AudioInterruptEnable | HDSP_Start);
        hdsp_write(s, HDSP_controlRegister, s->control_register);
 }
 
-static void hdsp_stop_audio(hdsp_t *s)
+static void hdsp_stop_audio(struct hdsp *s)
 {
        s->control_register &= ~(HDSP_Start | HDSP_AudioInterruptEnable);
        hdsp_write(s, HDSP_controlRegister, s->control_register);
 }
 
-static void hdsp_silence_playback(hdsp_t *hdsp)
+static void hdsp_silence_playback(struct hdsp *hdsp)
 {
        memset(hdsp->playback_buffer, 0, HDSP_DMA_AREA_BYTES);
 }
 
-static int hdsp_set_interrupt_interval(hdsp_t *s, unsigned int frames)
+static int hdsp_set_interrupt_interval(struct hdsp *s, unsigned int frames)
 {
        int n;
 
@@ -983,7 +1044,26 @@ static int hdsp_set_interrupt_interval(hdsp_t *s, unsigned int frames)
        return 0;
 }
 
-static int hdsp_set_rate(hdsp_t *hdsp, int rate, int called_internally)
+static void hdsp_set_dds_value(struct hdsp *hdsp, int rate)
+{
+       u64 n;
+
+       if (rate >= 112000)
+               rate /= 4;
+       else if (rate >= 56000)
+               rate /= 2;
+
+       n = DDS_NUMERATOR;
+       n = div_u64(n, rate);
+       /* n should be less than 2^32 for being written to FREQ register */
+       snd_BUG_ON(n >> 32);
+       /* HDSP_freqReg and HDSP_resetPointer are the same, so keep the DDS
+          value to write it after a reset */
+       hdsp->dds_value = n;
+       hdsp_write(hdsp, HDSP_freqReg, hdsp->dds_value);
+}
+
+static int hdsp_set_rate(struct hdsp *hdsp, int rate, int called_internally)
 {
        int reject_if_open = 0;
        int current_rate;
@@ -993,97 +1073,87 @@ static int hdsp_set_rate(hdsp_t *hdsp, int rate, int called_internally)
           there is no need for it (e.g. during module
           initialization).
        */
-       
-       if (!(hdsp->control_register & HDSP_ClockModeMaster)) { 
+
+       if (!(hdsp->control_register & HDSP_ClockModeMaster)) {
                if (called_internally) {
                        /* request from ctl or card initialization */
-                       snd_printk("Hammerfall-DSP: device is not running as a clock master: cannot set sample rate.\n");
+                       snd_printk(KERN_ERR "Hammerfall-DSP: device is not running as a clock master: cannot set sample rate.\n");
                        return -1;
-               } else {                
+               } else {
                        /* hw_param request while in AutoSync mode */
                        int external_freq = hdsp_external_sample_rate(hdsp);
                        int spdif_freq = hdsp_spdif_sample_rate(hdsp);
-               
-                       if ((spdif_freq == external_freq*2) && (hdsp_autosync_ref(hdsp) >= HDSP_AUTOSYNC_FROM_ADAT1)) {
-                               snd_printk("Hammerfall-DSP: Detected ADAT in double speed mode\n");
-                       } else if (hdsp->io_type == H9632 && (spdif_freq == external_freq*4) && (hdsp_autosync_ref(hdsp) >= HDSP_AUTOSYNC_FROM_ADAT1)) {
-                               snd_printk("Hammerfall-DSP: Detected ADAT in quad speed mode\n");                       
-                       else if (rate != external_freq) {
-                               snd_printk("Hammerfall-DSP: No AutoSync source for requested rate\n");
+
+                       if ((spdif_freq == external_freq*2) && (hdsp_autosync_ref(hdsp) >= HDSP_AUTOSYNC_FROM_ADAT1))
+                               snd_printk(KERN_INFO "Hammerfall-DSP: Detected ADAT in double speed mode\n");
+                       else if (hdsp->io_type == H9632 && (spdif_freq == external_freq*4) && (hdsp_autosync_ref(hdsp) >= HDSP_AUTOSYNC_FROM_ADAT1))
+                               snd_printk(KERN_INFO "Hammerfall-DSP: Detected ADAT in quad speed mode\n");
+                       else if (rate != external_freq) {
+                               snd_printk(KERN_INFO "Hammerfall-DSP: No AutoSync source for requested rate\n");
                                return -1;
-                       }               
-               }       
+                       }
+               }
        }
 
        current_rate = hdsp->system_sample_rate;
 
        /* Changing from a "single speed" to a "double speed" rate is
           not allowed if any substreams are open. This is because
-          such a change causes a shift in the location of 
+          such a change causes a shift in the location of
           the DMA buffers and a reduction in the number of available
-          buffers. 
+          buffers.
 
           Note that a similar but essentially insoluble problem
           exists for externally-driven rate changes. All we can do
           is to flag rate changes in the read/write routines.  */
 
-       if (rate > 96000 && hdsp->io_type != H9632) {
+       if (rate > 96000 && hdsp->io_type != H9632)
                return -EINVAL;
-       }
-       
+
        switch (rate) {
        case 32000:
-               if (current_rate > 48000) {
+               if (current_rate > 48000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency32KHz;
                break;
        case 44100:
-               if (current_rate > 48000) {
+               if (current_rate > 48000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency44_1KHz;
                break;
        case 48000:
-               if (current_rate > 48000) {
+               if (current_rate > 48000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency48KHz;
                break;
        case 64000:
-               if (current_rate <= 48000 || current_rate > 96000) {
+               if (current_rate <= 48000 || current_rate > 96000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency64KHz;
                break;
        case 88200:
-               if (current_rate <= 48000 || current_rate > 96000) {
+               if (current_rate <= 48000 || current_rate > 96000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency88_2KHz;
                break;
        case 96000:
-               if (current_rate <= 48000 || current_rate > 96000) {
+               if (current_rate <= 48000 || current_rate > 96000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency96KHz;
                break;
        case 128000:
-               if (current_rate < 128000) {
+               if (current_rate < 128000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency128KHz;
                break;
        case 176400:
-               if (current_rate < 128000) {
+               if (current_rate < 128000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency176_4KHz;
                break;
        case 192000:
-               if (current_rate < 128000) {
+               if (current_rate < 128000)
                        reject_if_open = 1;
-               }
                rate_bits = HDSP_Frequency192KHz;
                break;
        default:
@@ -1101,14 +1171,17 @@ static int hdsp_set_rate(hdsp_t *hdsp, int rate, int called_internally)
        hdsp->control_register |= rate_bits;
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
 
+       /* For HDSP9632 rev 152, need to set DDS value in FREQ register */
+       if (hdsp->io_type == H9632 && hdsp->firmware_rev >= 152)
+               hdsp_set_dds_value(hdsp, rate);
+
        if (rate >= 128000) {
                hdsp->channel_map = channel_map_H9632_qs;
        } else if (rate > 48000) {
-               if (hdsp->io_type == H9632) {
+               if (hdsp->io_type == H9632)
                        hdsp->channel_map = channel_map_H9632_ds;
-               } else {
+               else
                        hdsp->channel_map = channel_map_ds;
-               }
        } else {
                switch (hdsp->io_type) {
                case Multiface:
@@ -1126,7 +1199,7 @@ static int hdsp_set_rate(hdsp_t *hdsp, int rate, int called_internally)
                        break;
                }
        }
-       
+
        hdsp->system_sample_rate = rate;
 
        return 0;
@@ -1136,60 +1209,54 @@ static int hdsp_set_rate(hdsp_t *hdsp, int rate, int called_internally)
    MIDI
   ----------------------------------------------------------------------------*/
 
-static unsigned char snd_hdsp_midi_read_byte (hdsp_t *hdsp, int id)
+static unsigned char snd_hdsp_midi_read_byte (struct hdsp *hdsp, int id)
 {
        /* the hardware already does the relevant bit-mask with 0xff */
-       if (id) {
+       if (id)
                return hdsp_read(hdsp, HDSP_midiDataIn1);
-       } else {
+       else
                return hdsp_read(hdsp, HDSP_midiDataIn0);
-       }
 }
 
-static void snd_hdsp_midi_write_byte (hdsp_t *hdsp, int id, int val)
+static void snd_hdsp_midi_write_byte (struct hdsp *hdsp, int id, int val)
 {
        /* the hardware already does the relevant bit-mask with 0xff */
-       if (id) {
+       if (id)
                hdsp_write(hdsp, HDSP_midiDataOut1, val);
-       } else {
+       else
                hdsp_write(hdsp, HDSP_midiDataOut0, val);
-       }
 }
 
-static int snd_hdsp_midi_input_available (hdsp_t *hdsp, int id)
+static int snd_hdsp_midi_input_available (struct hdsp *hdsp, int id)
 {
-       if (id) {
+       if (id)
                return (hdsp_read(hdsp, HDSP_midiStatusIn1) & 0xff);
-       } else {
+       else
                return (hdsp_read(hdsp, HDSP_midiStatusIn0) & 0xff);
-       }
 }
 
-static int snd_hdsp_midi_output_possible (hdsp_t *hdsp, int id)
+static int snd_hdsp_midi_output_possible (struct hdsp *hdsp, int id)
 {
        int fifo_bytes_used;
 
-       if (id) {
+       if (id)
                fifo_bytes_used = hdsp_read(hdsp, HDSP_midiStatusOut1) & 0xff;
-       } else {
+       else
                fifo_bytes_used = hdsp_read(hdsp, HDSP_midiStatusOut0) & 0xff;
-       }
 
-       if (fifo_bytes_used < 128) {
+       if (fifo_bytes_used < 128)
                return  128 - fifo_bytes_used;
-       } else {
+       else
                return 0;
-       }
 }
 
-static void snd_hdsp_flush_midi_input (hdsp_t *hdsp, int id)
+static void snd_hdsp_flush_midi_input (struct hdsp *hdsp, int id)
 {
-       while (snd_hdsp_midi_input_available (hdsp, id)) {
+       while (snd_hdsp_midi_input_available (hdsp, id))
                snd_hdsp_midi_read_byte (hdsp, id);
-       }
 }
 
-static int snd_hdsp_midi_output_write (hdsp_midi_t *hmidi)
+static int snd_hdsp_midi_output_write (struct hdsp_midi *hmidi)
 {
        unsigned long flags;
        int n_pending;
@@ -1198,16 +1265,16 @@ static int snd_hdsp_midi_output_write (hdsp_midi_t *hmidi)
        unsigned char buf[128];
 
        /* Output is not interrupt driven */
-               
+
        spin_lock_irqsave (&hmidi->lock, flags);
        if (hmidi->output) {
                if (!snd_rawmidi_transmit_empty (hmidi->output)) {
                        if ((n_pending = snd_hdsp_midi_output_possible (hmidi->hdsp, hmidi->id)) > 0) {
                                if (n_pending > (int)sizeof (buf))
                                        n_pending = sizeof (buf);
-                               
+
                                if ((to_write = snd_rawmidi_transmit (hmidi->output, buf, n_pending)) > 0) {
-                                       for (i = 0; i < to_write; ++i) 
+                                       for (i = 0; i < to_write; ++i)
                                                snd_hdsp_midi_write_byte (hmidi->hdsp, hmidi->id, buf[i]);
                                }
                        }
@@ -1217,7 +1284,7 @@ static int snd_hdsp_midi_output_write (hdsp_midi_t *hmidi)
        return 0;
 }
 
-static int snd_hdsp_midi_input_read (hdsp_midi_t *hmidi)
+static int snd_hdsp_midi_input_read (struct hdsp_midi *hmidi)
 {
        unsigned char buf[128]; /* this buffer is designed to match the MIDI input FIFO size */
        unsigned long flags;
@@ -1227,41 +1294,36 @@ static int snd_hdsp_midi_input_read (hdsp_midi_t *hmidi)
        spin_lock_irqsave (&hmidi->lock, flags);
        if ((n_pending = snd_hdsp_midi_input_available (hmidi->hdsp, hmidi->id)) > 0) {
                if (hmidi->input) {
-                       if (n_pending > (int)sizeof (buf)) {
+                       if (n_pending > (int)sizeof (buf))
                                n_pending = sizeof (buf);
-                       }
-                       for (i = 0; i < n_pending; ++i) {
+                       for (i = 0; i < n_pending; ++i)
                                buf[i] = snd_hdsp_midi_read_byte (hmidi->hdsp, hmidi->id);
-                       }
-                       if (n_pending) {
+                       if (n_pending)
                                snd_rawmidi_receive (hmidi->input, buf, n_pending);
-                       }
                } else {
                        /* flush the MIDI input FIFO */
-                       while (--n_pending) {
+                       while (--n_pending)
                                snd_hdsp_midi_read_byte (hmidi->hdsp, hmidi->id);
-                       }
                }
        }
        hmidi->pending = 0;
-       if (hmidi->id) {
+       if (hmidi->id)
                hmidi->hdsp->control_register |= HDSP_Midi1InterruptEnable;
-       } else {
+       else
                hmidi->hdsp->control_register |= HDSP_Midi0InterruptEnable;
-       }
        hdsp_write(hmidi->hdsp, HDSP_controlRegister, hmidi->hdsp->control_register);
        spin_unlock_irqrestore (&hmidi->lock, flags);
        return snd_hdsp_midi_output_write (hmidi);
 }
 
-static void snd_hdsp_midi_input_trigger(snd_rawmidi_substream_t * substream, int up)
+static void snd_hdsp_midi_input_trigger(struct snd_rawmidi_substream *substream, int up)
 {
-       hdsp_t *hdsp;
-       hdsp_midi_t *hmidi;
+       struct hdsp *hdsp;
+       struct hdsp_midi *hmidi;
        unsigned long flags;
        u32 ie;
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        hdsp = hmidi->hdsp;
        ie = hmidi->id ? HDSP_Midi1InterruptEnable : HDSP_Midi0InterruptEnable;
        spin_lock_irqsave (&hdsp->lock, flags);
@@ -1281,16 +1343,16 @@ static void snd_hdsp_midi_input_trigger(snd_rawmidi_substream_t * substream, int
 
 static void snd_hdsp_midi_output_timer(unsigned long data)
 {
-       hdsp_midi_t *hmidi = (hdsp_midi_t *) data;
+       struct hdsp_midi *hmidi = (struct hdsp_midi *) data;
        unsigned long flags;
-       
+
        snd_hdsp_midi_output_write(hmidi);
        spin_lock_irqsave (&hmidi->lock, flags);
 
        /* this does not bump hmidi->istimer, because the
           kernel automatically removed the timer when it
           expired, and we are now adding it back, thus
-          leaving istimer wherever it was set before.  
+          leaving istimer wherever it was set before.
        */
 
        if (hmidi->istimer) {
@@ -1301,12 +1363,12 @@ static void snd_hdsp_midi_output_timer(unsigned long data)
        spin_unlock_irqrestore (&hmidi->lock, flags);
 }
 
-static void snd_hdsp_midi_output_trigger(snd_rawmidi_substream_t * substream, int up)
+static void snd_hdsp_midi_output_trigger(struct snd_rawmidi_substream *substream, int up)
 {
-       hdsp_midi_t *hmidi;
+       struct hdsp_midi *hmidi;
        unsigned long flags;
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        spin_lock_irqsave (&hmidi->lock, flags);
        if (up) {
                if (!hmidi->istimer) {
@@ -1318,20 +1380,19 @@ static void snd_hdsp_midi_output_trigger(snd_rawmidi_substream_t * substream, in
                        hmidi->istimer++;
                }
        } else {
-               if (hmidi->istimer && --hmidi->istimer <= 0) {
+               if (hmidi->istimer && --hmidi->istimer <= 0)
                        del_timer (&hmidi->timer);
-               }
        }
        spin_unlock_irqrestore (&hmidi->lock, flags);
        if (up)
                snd_hdsp_midi_output_write(hmidi);
 }
 
-static int snd_hdsp_midi_input_open(snd_rawmidi_substream_t * substream)
+static int snd_hdsp_midi_input_open(struct snd_rawmidi_substream *substream)
 {
-       hdsp_midi_t *hmidi;
+       struct hdsp_midi *hmidi;
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        spin_lock_irq (&hmidi->lock);
        snd_hdsp_flush_midi_input (hmidi->hdsp, hmidi->id);
        hmidi->input = substream;
@@ -1340,11 +1401,11 @@ static int snd_hdsp_midi_input_open(snd_rawmidi_substream_t * substream)
        return 0;
 }
 
-static int snd_hdsp_midi_output_open(snd_rawmidi_substream_t * substream)
+static int snd_hdsp_midi_output_open(struct snd_rawmidi_substream *substream)
 {
-       hdsp_midi_t *hmidi;
+       struct hdsp_midi *hmidi;
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        spin_lock_irq (&hmidi->lock);
        hmidi->output = substream;
        spin_unlock_irq (&hmidi->lock);
@@ -1352,13 +1413,13 @@ static int snd_hdsp_midi_output_open(snd_rawmidi_substream_t * substream)
        return 0;
 }
 
-static int snd_hdsp_midi_input_close(snd_rawmidi_substream_t * substream)
+static int snd_hdsp_midi_input_close(struct snd_rawmidi_substream *substream)
 {
-       hdsp_midi_t *hmidi;
+       struct hdsp_midi *hmidi;
 
        snd_hdsp_midi_input_trigger (substream, 0);
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        spin_lock_irq (&hmidi->lock);
        hmidi->input = NULL;
        spin_unlock_irq (&hmidi->lock);
@@ -1366,13 +1427,13 @@ static int snd_hdsp_midi_input_close(snd_rawmidi_substream_t * substream)
        return 0;
 }
 
-static int snd_hdsp_midi_output_close(snd_rawmidi_substream_t * substream)
+static int snd_hdsp_midi_output_close(struct snd_rawmidi_substream *substream)
 {
-       hdsp_midi_t *hmidi;
+       struct hdsp_midi *hmidi;
 
        snd_hdsp_midi_output_trigger (substream, 0);
 
-       hmidi = (hdsp_midi_t *) substream->rmidi->private_data;
+       hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
        spin_lock_irq (&hmidi->lock);
        hmidi->output = NULL;
        spin_unlock_irq (&hmidi->lock);
@@ -1380,21 +1441,21 @@ static int snd_hdsp_midi_output_close(snd_rawmidi_substream_t * substream)
        return 0;
 }
 
-static snd_rawmidi_ops_t snd_hdsp_midi_output =
+static struct snd_rawmidi_ops snd_hdsp_midi_output =
 {
        .open =         snd_hdsp_midi_output_open,
        .close =        snd_hdsp_midi_output_close,
        .trigger =      snd_hdsp_midi_output_trigger,
 };
 
-static snd_rawmidi_ops_t snd_hdsp_midi_input =
+static struct snd_rawmidi_ops snd_hdsp_midi_input =
 {
        .open =         snd_hdsp_midi_input_open,
        .close =        snd_hdsp_midi_input_close,
        .trigger =      snd_hdsp_midi_input_trigger,
 };
 
-static int __devinit snd_hdsp_create_midi (snd_card_t *card, hdsp_t *hdsp, int id)
+static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int id)
 {
        char buf[32];
 
@@ -1408,11 +1469,10 @@ static int __devinit snd_hdsp_create_midi (snd_card_t *card, hdsp_t *hdsp, int i
        spin_lock_init (&hdsp->midi[id].lock);
 
        sprintf (buf, "%s MIDI %d", card->shortname, id+1);
-       if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0) {
+       if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0)
                return -1;
-       }
 
-       sprintf (hdsp->midi[id].rmidi->name, "%s MIDI %d", card->id, id+1);
+       sprintf(hdsp->midi[id].rmidi->name, "HDSP MIDI %d", id+1);
        hdsp->midi[id].rmidi->private_data = &hdsp->midi[id];
 
        snd_rawmidi_set_ops (hdsp->midi[id].rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT, &snd_hdsp_midi_output);
@@ -1429,7 +1489,7 @@ static int __devinit snd_hdsp_create_midi (snd_card_t *card, hdsp_t *hdsp, int i
   Control Interface
   ----------------------------------------------------------------------------*/
 
-static u32 snd_hdsp_convert_from_aes(snd_aes_iec958_t *aes)
+static u32 snd_hdsp_convert_from_aes(struct snd_aes_iec958 *aes)
 {
        u32 val = 0;
        val |= (aes->status[0] & IEC958_AES0_PROFESSIONAL) ? HDSP_SPDIFProfessional : 0;
@@ -1441,7 +1501,7 @@ static u32 snd_hdsp_convert_from_aes(snd_aes_iec958_t *aes)
        return val;
 }
 
-static void snd_hdsp_convert_to_aes(snd_aes_iec958_t *aes, u32 val)
+static void snd_hdsp_convert_to_aes(struct snd_aes_iec958 *aes, u32 val)
 {
        aes->status[0] = ((val & HDSP_SPDIFProfessional) ? IEC958_AES0_PROFESSIONAL : 0) |
                         ((val & HDSP_SPDIFNonAudio) ? IEC958_AES0_NONAUDIO : 0);
@@ -1451,27 +1511,27 @@ static void snd_hdsp_convert_to_aes(snd_aes_iec958_t *aes, u32 val)
                aes->status[0] |= (val & HDSP_SPDIFEmphasis) ? IEC958_AES0_CON_EMPHASIS_5015 : 0;
 }
 
-static int snd_hdsp_control_spdif_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_control_spdif_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
        uinfo->count = 1;
        return 0;
 }
 
-static int snd_hdsp_control_spdif_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_control_spdif_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        snd_hdsp_convert_to_aes(&ucontrol->value.iec958, hdsp->creg_spdif);
        return 0;
 }
 
-static int snd_hdsp_control_spdif_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_control_spdif_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        u32 val;
-       
+
        val = snd_hdsp_convert_from_aes(&ucontrol->value.iec958);
        spin_lock_irq(&hdsp->lock);
        change = val != hdsp->creg_spdif;
@@ -1480,27 +1540,27 @@ static int snd_hdsp_control_spdif_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_va
        return change;
 }
 
-static int snd_hdsp_control_spdif_stream_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_control_spdif_stream_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
        uinfo->count = 1;
        return 0;
 }
 
-static int snd_hdsp_control_spdif_stream_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_control_spdif_stream_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        snd_hdsp_convert_to_aes(&ucontrol->value.iec958, hdsp->creg_spdif_stream);
        return 0;
 }
 
-static int snd_hdsp_control_spdif_stream_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_control_spdif_stream_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        u32 val;
-       
+
        val = snd_hdsp_convert_from_aes(&ucontrol->value.iec958);
        spin_lock_irq(&hdsp->lock);
        change = val != hdsp->creg_spdif_stream;
@@ -1511,33 +1571,33 @@ static int snd_hdsp_control_spdif_stream_put(snd_kcontrol_t * kcontrol, snd_ctl_
        return change;
 }
 
-static int snd_hdsp_control_spdif_mask_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_control_spdif_mask_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
        uinfo->count = 1;
        return 0;
 }
 
-static int snd_hdsp_control_spdif_mask_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_control_spdif_mask_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        ucontrol->value.iec958.status[0] = kcontrol->private_value;
        return 0;
 }
 
 #define HDSP_SPDIF_IN(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_PCM,  \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_spdif_in, \
   .get = snd_hdsp_get_spdif_in, \
   .put = snd_hdsp_put_spdif_in }
 
-static unsigned int hdsp_spdif_in(hdsp_t *hdsp)
+static unsigned int hdsp_spdif_in(struct hdsp *hdsp)
 {
        return hdsp_decode_spdif_in(hdsp->control_register & HDSP_SPDIFInputMask);
 }
 
-static int hdsp_set_spdif_input(hdsp_t *hdsp, int in)
+static int hdsp_set_spdif_input(struct hdsp *hdsp, int in)
 {
        hdsp->control_register &= ~HDSP_SPDIFInputMask;
        hdsp->control_register |= hdsp_encode_spdif_in(in);
@@ -1545,10 +1605,10 @@ static int hdsp_set_spdif_input(hdsp_t *hdsp, int in)
        return 0;
 }
 
-static int snd_hdsp_info_spdif_in(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_spdif_in(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[4] = {"Optical", "Coaxial", "Internal", "AES"};
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
@@ -1559,20 +1619,20 @@ static int snd_hdsp_info_spdif_in(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t
        return 0;
 }
 
-static int snd_hdsp_get_spdif_in(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_in(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_spdif_in(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_spdif_in(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_spdif_in(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.enumerated.item[0] % ((hdsp->io_type == H9632) ? 4 : 3);
@@ -1585,49 +1645,41 @@ static int snd_hdsp_put_spdif_in(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
 }
 
 #define HDSP_SPDIF_OUT(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, .name = xname, .index = xindex, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
   .info = snd_hdsp_info_spdif_bits, \
   .get = snd_hdsp_get_spdif_out, .put = snd_hdsp_put_spdif_out }
 
-static int hdsp_spdif_out(hdsp_t *hdsp)
+static int hdsp_spdif_out(struct hdsp *hdsp)
 {
        return (hdsp->control_register & HDSP_SPDIFOpticalOut) ? 1 : 0;
 }
 
-static int hdsp_set_spdif_output(hdsp_t *hdsp, int out)
+static int hdsp_set_spdif_output(struct hdsp *hdsp, int out)
 {
-       if (out) {
+       if (out)
                hdsp->control_register |= HDSP_SPDIFOpticalOut;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_SPDIFOpticalOut;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_info_spdif_bits(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_spdif_bits       snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_spdif_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_out(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.integer.value[0] = hdsp_spdif_out(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_spdif_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_spdif_out(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -1639,40 +1691,39 @@ static int snd_hdsp_put_spdif_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
 }
 
 #define HDSP_SPDIF_PROFESSIONAL(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, .name = xname, .index = xindex, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
   .info = snd_hdsp_info_spdif_bits, \
   .get = snd_hdsp_get_spdif_professional, .put = snd_hdsp_put_spdif_professional }
 
-static int hdsp_spdif_professional(hdsp_t *hdsp)
+static int hdsp_spdif_professional(struct hdsp *hdsp)
 {
        return (hdsp->control_register & HDSP_SPDIFProfessional) ? 1 : 0;
 }
 
-static int hdsp_set_spdif_professional(hdsp_t *hdsp, int val)
+static int hdsp_set_spdif_professional(struct hdsp *hdsp, int val)
 {
-       if (val) {
+       if (val)
                hdsp->control_register |= HDSP_SPDIFProfessional;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_SPDIFProfessional;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_get_spdif_professional(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_professional(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.integer.value[0] = hdsp_spdif_professional(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_spdif_professional(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_spdif_professional(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -1684,40 +1735,39 @@ static int snd_hdsp_put_spdif_professional(snd_kcontrol_t * kcontrol, snd_ctl_el
 }
 
 #define HDSP_SPDIF_EMPHASIS(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, .name = xname, .index = xindex, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
   .info = snd_hdsp_info_spdif_bits, \
   .get = snd_hdsp_get_spdif_emphasis, .put = snd_hdsp_put_spdif_emphasis }
 
-static int hdsp_spdif_emphasis(hdsp_t *hdsp)
+static int hdsp_spdif_emphasis(struct hdsp *hdsp)
 {
        return (hdsp->control_register & HDSP_SPDIFEmphasis) ? 1 : 0;
 }
 
-static int hdsp_set_spdif_emphasis(hdsp_t *hdsp, int val)
+static int hdsp_set_spdif_emphasis(struct hdsp *hdsp, int val)
 {
-       if (val) {
+       if (val)
                hdsp->control_register |= HDSP_SPDIFEmphasis;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_SPDIFEmphasis;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_get_spdif_emphasis(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_emphasis(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.integer.value[0] = hdsp_spdif_emphasis(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_spdif_emphasis(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_spdif_emphasis(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -1729,40 +1779,39 @@ static int snd_hdsp_put_spdif_emphasis(snd_kcontrol_t * kcontrol, snd_ctl_elem_v
 }
 
 #define HDSP_SPDIF_NON_AUDIO(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, .name = xname, .index = xindex, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
   .info = snd_hdsp_info_spdif_bits, \
   .get = snd_hdsp_get_spdif_nonaudio, .put = snd_hdsp_put_spdif_nonaudio }
 
-static int hdsp_spdif_nonaudio(hdsp_t *hdsp)
+static int hdsp_spdif_nonaudio(struct hdsp *hdsp)
 {
        return (hdsp->control_register & HDSP_SPDIFNonAudio) ? 1 : 0;
 }
 
-static int hdsp_set_spdif_nonaudio(hdsp_t *hdsp, int val)
+static int hdsp_set_spdif_nonaudio(struct hdsp *hdsp, int val)
 {
-       if (val) {
+       if (val)
                hdsp->control_register |= HDSP_SPDIFNonAudio;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_SPDIFNonAudio;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_get_spdif_nonaudio(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_nonaudio(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.integer.value[0] = hdsp_spdif_nonaudio(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_spdif_nonaudio(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_spdif_nonaudio(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -1774,7 +1823,7 @@ static int snd_hdsp_put_spdif_nonaudio(snd_kcontrol_t * kcontrol, snd_ctl_elem_v
 }
 
 #define HDSP_SPDIF_SAMPLE_RATE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ, \
@@ -1782,10 +1831,10 @@ static int snd_hdsp_put_spdif_nonaudio(snd_kcontrol_t * kcontrol, snd_ctl_elem_v
   .get = snd_hdsp_get_spdif_sample_rate \
 }
 
-static int snd_hdsp_info_spdif_sample_rate(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_spdif_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"32000", "44100", "48000", "64000", "88200", "96000", "None", "128000", "176400", "192000"};
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
@@ -1796,10 +1845,10 @@ static int snd_hdsp_info_spdif_sample_rate(snd_kcontrol_t *kcontrol, snd_ctl_ele
        return 0;
 }
 
-static int snd_hdsp_get_spdif_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        switch (hdsp_spdif_sample_rate(hdsp)) {
        case 32000:
                ucontrol->value.enumerated.item[0] = 0;
@@ -1829,13 +1878,13 @@ static int snd_hdsp_get_spdif_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_ele
                ucontrol->value.enumerated.item[0] = 9;
                break;
        default:
-               ucontrol->value.enumerated.item[0] = 6;         
+               ucontrol->value.enumerated.item[0] = 6;
        }
        return 0;
 }
 
 #define HDSP_SYSTEM_SAMPLE_RATE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ, \
@@ -1843,23 +1892,23 @@ static int snd_hdsp_get_spdif_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_ele
   .get = snd_hdsp_get_system_sample_rate \
 }
 
-static int snd_hdsp_info_system_sample_rate(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_system_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
        uinfo->count = 1;
        return 0;
 }
 
-static int snd_hdsp_get_system_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_system_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp->system_sample_rate;
        return 0;
 }
 
 #define HDSP_AUTOSYNC_SAMPLE_RATE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_PCM, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ, \
@@ -1867,10 +1916,10 @@ static int snd_hdsp_get_system_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_el
   .get = snd_hdsp_get_autosync_sample_rate \
 }
 
-static int snd_hdsp_info_autosync_sample_rate(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_autosync_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       static char *texts[] = {"32000", "44100", "48000", "64000", "88200", "96000", "None", "128000", "176400", "192000"};    
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+       static char *texts[] = {"32000", "44100", "48000", "64000", "88200", "96000", "None", "128000", "176400", "192000"};
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = (hdsp->io_type == H9632) ? 10 : 7 ;
@@ -1880,10 +1929,10 @@ static int snd_hdsp_info_autosync_sample_rate(snd_kcontrol_t *kcontrol, snd_ctl_
        return 0;
 }
 
-static int snd_hdsp_get_autosync_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_autosync_sample_rate(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        switch (hdsp_external_sample_rate(hdsp)) {
        case 32000:
                ucontrol->value.enumerated.item[0] = 0;
@@ -1911,15 +1960,15 @@ static int snd_hdsp_get_autosync_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_
                break;
        case 192000:
                ucontrol->value.enumerated.item[0] = 9;
-               break;  
+               break;
        default:
-               ucontrol->value.enumerated.item[0] = 6;         
+               ucontrol->value.enumerated.item[0] = 6;
        }
        return 0;
 }
 
 #define HDSP_SYSTEM_CLOCK_MODE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ, \
@@ -1927,20 +1976,19 @@ static int snd_hdsp_get_autosync_sample_rate(snd_kcontrol_t * kcontrol, snd_ctl_
   .get = snd_hdsp_get_system_clock_mode \
 }
 
-static int hdsp_system_clock_mode(hdsp_t *hdsp)
+static int hdsp_system_clock_mode(struct hdsp *hdsp)
 {
-       if (hdsp->control_register & HDSP_ClockModeMaster) {
+       if (hdsp->control_register & HDSP_ClockModeMaster)
                return 0;
-       } else if (hdsp_external_sample_rate(hdsp) != hdsp->system_sample_rate) {
+       else if (hdsp_external_sample_rate(hdsp) != hdsp->system_sample_rate)
                        return 0;
-       }
        return 1;
 }
 
-static int snd_hdsp_info_system_clock_mode(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_system_clock_mode(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"Master", "Slave" };
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 2;
@@ -1950,16 +1998,16 @@ static int snd_hdsp_info_system_clock_mode(snd_kcontrol_t *kcontrol, snd_ctl_ele
        return 0;
 }
 
-static int snd_hdsp_get_system_clock_mode(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_system_clock_mode(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_system_clock_mode(hdsp);
        return 0;
 }
 
 #define HDSP_CLOCK_SOURCE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_PCM, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_clock_source, \
@@ -1967,7 +2015,7 @@ static int snd_hdsp_get_system_clock_mode(snd_kcontrol_t * kcontrol, snd_ctl_ele
   .put = snd_hdsp_put_clock_source \
 }
 
-static int hdsp_clock_source(hdsp_t *hdsp)
+static int hdsp_clock_source(struct hdsp *hdsp)
 {
        if (hdsp->control_register & HDSP_ClockModeMaster) {
                switch (hdsp->system_sample_rate) {
@@ -1990,21 +2038,21 @@ static int hdsp_clock_source(hdsp_t *hdsp)
                case 192000:
                        return 9;
                default:
-                       return 3;       
+                       return 3;
                }
        } else {
                return 0;
        }
 }
 
-static int hdsp_set_clock_source(hdsp_t *hdsp, int mode)
+static int hdsp_set_clock_source(struct hdsp *hdsp, int mode)
 {
        int rate;
        switch (mode) {
        case HDSP_CLOCK_SOURCE_AUTOSYNC:
                if (hdsp_external_sample_rate(hdsp) != 0) {
                    if (!hdsp_set_rate(hdsp, hdsp_external_sample_rate(hdsp), 1)) {
-                       hdsp->control_register &= ~HDSP_ClockModeMaster;                
+                       hdsp->control_register &= ~HDSP_ClockModeMaster;
                        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
                        return 0;
                    }
@@ -2015,7 +2063,7 @@ static int hdsp_set_clock_source(hdsp_t *hdsp, int mode)
                break;
        case HDSP_CLOCK_SOURCE_INTERNAL_44_1KHZ:
                rate = 44100;
-               break;      
+               break;
        case HDSP_CLOCK_SOURCE_INTERNAL_48KHZ:
                rate = 48000;
                break;
@@ -2046,86 +2094,80 @@ static int hdsp_set_clock_source(hdsp_t *hdsp, int mode)
        return 0;
 }
 
-static int snd_hdsp_info_clock_source(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_clock_source(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"AutoSync", "Internal 32.0 kHz", "Internal 44.1 kHz", "Internal 48.0 kHz", "Internal 64.0 kHz", "Internal 88.2 kHz", "Internal 96.0 kHz", "Internal 128 kHz", "Internal 176.4 kHz", "Internal 192.0 KHz" };
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        if (hdsp->io_type == H9632)
            uinfo->value.enumerated.items = 10;
        else
-           uinfo->value.enumerated.items = 7;  
+           uinfo->value.enumerated.items = 7;
        if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
                uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
        strcpy(uinfo->value.enumerated.name, texts[uinfo->value.enumerated.item]);
        return 0;
 }
 
-static int snd_hdsp_get_clock_source(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_clock_source(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_clock_source(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_clock_source(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_clock_source(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.enumerated.item[0];
        if (val < 0) val = 0;
        if (hdsp->io_type == H9632) {
-           if (val > 9) val = 9;
+               if (val > 9)
+                       val = 9;
        } else {
-           if (val > 6) val = 6;
+               if (val > 6)
+                       val = 6;
        }
        spin_lock_irq(&hdsp->lock);
-       if (val != hdsp_clock_source(hdsp)) {
+       if (val != hdsp_clock_source(hdsp))
                change = (hdsp_set_clock_source(hdsp, val) == 0) ? 1 : 0;
-       } else {
+       else
                change = 0;
-       }
        spin_unlock_irq(&hdsp->lock);
        return change;
 }
 
-static int snd_hdsp_info_clock_source_lock(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_clock_source_lock                snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_clock_source_lock(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_clock_source_lock(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.integer.value[0] = hdsp->clock_source_locked;
        return 0;
 }
 
-static int snd_hdsp_put_clock_source_lock(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_clock_source_lock(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
 
        change = (int)ucontrol->value.integer.value[0] != hdsp->clock_source_locked;
        if (change)
-               hdsp->clock_source_locked = ucontrol->value.integer.value[0];
+               hdsp->clock_source_locked = !!ucontrol->value.integer.value[0];
        return change;
 }
 
 #define HDSP_DA_GAIN(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_da_gain, \
@@ -2133,7 +2175,7 @@ static int snd_hdsp_put_clock_source_lock(snd_kcontrol_t * kcontrol, snd_ctl_ele
   .put = snd_hdsp_put_da_gain \
 }
 
-static int hdsp_da_gain(hdsp_t *hdsp)
+static int hdsp_da_gain(struct hdsp *hdsp)
 {
        switch (hdsp->control_register & HDSP_DAGainMask) {
        case HDSP_DAGainHighGain:
@@ -2143,11 +2185,11 @@ static int hdsp_da_gain(hdsp_t *hdsp)
        case HDSP_DAGainMinus10dBV:
                return 2;
        default:
-               return 1;       
+               return 1;
        }
 }
 
-static int hdsp_set_da_gain(hdsp_t *hdsp, int mode)
+static int hdsp_set_da_gain(struct hdsp *hdsp, int mode)
 {
        hdsp->control_register &= ~HDSP_DAGainMask;
        switch (mode) {
@@ -2158,8 +2200,8 @@ static int hdsp_set_da_gain(hdsp_t *hdsp, int mode)
                hdsp->control_register |= HDSP_DAGainPlus4dBu;
                break;
        case 2:
-               hdsp->control_register |= HDSP_DAGainMinus10dBV;                
-               break;      
+               hdsp->control_register |= HDSP_DAGainMinus10dBV;
+               break;
        default:
                return -1;
 
@@ -2168,10 +2210,10 @@ static int hdsp_set_da_gain(hdsp_t *hdsp, int mode)
        return 0;
 }
 
-static int snd_hdsp_info_da_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_da_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"Hi Gain", "+4 dBu", "-10 dbV"};
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 3;
@@ -2181,37 +2223,36 @@ static int snd_hdsp_info_da_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *
        return 0;
 }
 
-static int snd_hdsp_get_da_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_da_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_da_gain(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_da_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_da_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.enumerated.item[0];
        if (val < 0) val = 0;
        if (val > 2) val = 2;
        spin_lock_irq(&hdsp->lock);
-       if (val != hdsp_da_gain(hdsp)) {
+       if (val != hdsp_da_gain(hdsp))
                change = (hdsp_set_da_gain(hdsp, val) == 0) ? 1 : 0;
-       } else {
+       else
                change = 0;
-       }
        spin_unlock_irq(&hdsp->lock);
        return change;
 }
 
 #define HDSP_AD_GAIN(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_ad_gain, \
@@ -2219,7 +2260,7 @@ static int snd_hdsp_put_da_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
   .put = snd_hdsp_put_ad_gain \
 }
 
-static int hdsp_ad_gain(hdsp_t *hdsp)
+static int hdsp_ad_gain(struct hdsp *hdsp)
 {
        switch (hdsp->control_register & HDSP_ADGainMask) {
        case HDSP_ADGainMinus10dBV:
@@ -2229,11 +2270,11 @@ static int hdsp_ad_gain(hdsp_t *hdsp)
        case HDSP_ADGainLowGain:
                return 2;
        default:
-               return 1;       
+               return 1;
        }
 }
 
-static int hdsp_set_ad_gain(hdsp_t *hdsp, int mode)
+static int hdsp_set_ad_gain(struct hdsp *hdsp, int mode)
 {
        hdsp->control_register &= ~HDSP_ADGainMask;
        switch (mode) {
@@ -2241,11 +2282,11 @@ static int hdsp_set_ad_gain(hdsp_t *hdsp, int mode)
                hdsp->control_register |= HDSP_ADGainMinus10dBV;
                break;
        case 1:
-               hdsp->control_register |= HDSP_ADGainPlus4dBu;          
+               hdsp->control_register |= HDSP_ADGainPlus4dBu;
                break;
        case 2:
-               hdsp->control_register |= HDSP_ADGainLowGain;           
-               break;      
+               hdsp->control_register |= HDSP_ADGainLowGain;
+               break;
        default:
                return -1;
 
@@ -2254,10 +2295,10 @@ static int hdsp_set_ad_gain(hdsp_t *hdsp, int mode)
        return 0;
 }
 
-static int snd_hdsp_info_ad_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_ad_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"-10 dBV", "+4 dBu", "Lo Gain"};
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 3;
@@ -2267,37 +2308,36 @@ static int snd_hdsp_info_ad_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *
        return 0;
 }
 
-static int snd_hdsp_get_ad_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_ad_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_ad_gain(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_ad_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_ad_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.enumerated.item[0];
        if (val < 0) val = 0;
        if (val > 2) val = 2;
        spin_lock_irq(&hdsp->lock);
-       if (val != hdsp_ad_gain(hdsp)) {
+       if (val != hdsp_ad_gain(hdsp))
                change = (hdsp_set_ad_gain(hdsp, val) == 0) ? 1 : 0;
-       } else {
+       else
                change = 0;
-       }
        spin_unlock_irq(&hdsp->lock);
        return change;
 }
 
 #define HDSP_PHONE_GAIN(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_phone_gain, \
@@ -2305,7 +2345,7 @@ static int snd_hdsp_put_ad_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
   .put = snd_hdsp_put_phone_gain \
 }
 
-static int hdsp_phone_gain(hdsp_t *hdsp)
+static int hdsp_phone_gain(struct hdsp *hdsp)
 {
        switch (hdsp->control_register & HDSP_PhoneGainMask) {
        case HDSP_PhoneGain0dB:
@@ -2315,11 +2355,11 @@ static int hdsp_phone_gain(hdsp_t *hdsp)
        case HDSP_PhoneGainMinus12dB:
                return 2;
        default:
-               return 0;       
+               return 0;
        }
 }
 
-static int hdsp_set_phone_gain(hdsp_t *hdsp, int mode)
+static int hdsp_set_phone_gain(struct hdsp *hdsp, int mode)
 {
        hdsp->control_register &= ~HDSP_PhoneGainMask;
        switch (mode) {
@@ -2327,11 +2367,11 @@ static int hdsp_set_phone_gain(hdsp_t *hdsp, int mode)
                hdsp->control_register |= HDSP_PhoneGain0dB;
                break;
        case 1:
-               hdsp->control_register |= HDSP_PhoneGainMinus6dB;               
+               hdsp->control_register |= HDSP_PhoneGainMinus6dB;
                break;
        case 2:
-               hdsp->control_register |= HDSP_PhoneGainMinus12dB;              
-               break;      
+               hdsp->control_register |= HDSP_PhoneGainMinus12dB;
+               break;
        default:
                return -1;
 
@@ -2340,10 +2380,10 @@ static int hdsp_set_phone_gain(hdsp_t *hdsp, int mode)
        return 0;
 }
 
-static int snd_hdsp_info_phone_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_phone_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"0 dB", "-6 dB", "-12 dB"};
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 3;
@@ -2353,37 +2393,36 @@ static int snd_hdsp_info_phone_gain(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_
        return 0;
 }
 
-static int snd_hdsp_get_phone_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_phone_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_phone_gain(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_phone_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_phone_gain(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.enumerated.item[0];
        if (val < 0) val = 0;
        if (val > 2) val = 2;
        spin_lock_irq(&hdsp->lock);
-       if (val != hdsp_phone_gain(hdsp)) {
+       if (val != hdsp_phone_gain(hdsp))
                change = (hdsp_set_phone_gain(hdsp, val) == 0) ? 1 : 0;
-       } else {
+       else
                change = 0;
-       }
        spin_unlock_irq(&hdsp->lock);
        return change;
 }
 
 #define HDSP_XLR_BREAKOUT_CABLE(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_xlr_breakout_cable, \
@@ -2391,48 +2430,39 @@ static int snd_hdsp_put_phone_gain(snd_kcontrol_t * kcontrol, snd_ctl_elem_value
   .put = snd_hdsp_put_xlr_breakout_cable \
 }
 
-static int hdsp_xlr_breakout_cable(hdsp_t *hdsp)
+static int hdsp_xlr_breakout_cable(struct hdsp *hdsp)
 {
-       if (hdsp->control_register & HDSP_XLRBreakoutCable) {
+       if (hdsp->control_register & HDSP_XLRBreakoutCable)
                return 1;
-       }
        return 0;
 }
 
-static int hdsp_set_xlr_breakout_cable(hdsp_t *hdsp, int mode)
+static int hdsp_set_xlr_breakout_cable(struct hdsp *hdsp, int mode)
 {
-       if (mode) {
+       if (mode)
                hdsp->control_register |= HDSP_XLRBreakoutCable;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_XLRBreakoutCable;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_info_xlr_breakout_cable(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_xlr_breakout_cable       snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_xlr_breakout_cable(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_xlr_breakout_cable(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_xlr_breakout_cable(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_xlr_breakout_cable(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_xlr_breakout_cable(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -2448,7 +2478,7 @@ static int snd_hdsp_put_xlr_breakout_cable(snd_kcontrol_t * kcontrol, snd_ctl_el
    Switching this on desactivates external ADAT
 */
 #define HDSP_AEB(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_aeb, \
@@ -2456,48 +2486,39 @@ static int snd_hdsp_put_xlr_breakout_cable(snd_kcontrol_t * kcontrol, snd_ctl_el
   .put = snd_hdsp_put_aeb \
 }
 
-static int hdsp_aeb(hdsp_t *hdsp)
+static int hdsp_aeb(struct hdsp *hdsp)
 {
-       if (hdsp->control_register & HDSP_AnalogExtensionBoard) {
+       if (hdsp->control_register & HDSP_AnalogExtensionBoard)
                return 1;
-       }
        return 0;
 }
 
-static int hdsp_set_aeb(hdsp_t *hdsp, int mode)
+static int hdsp_set_aeb(struct hdsp *hdsp, int mode)
 {
-       if (mode) {
+       if (mode)
                hdsp->control_register |= HDSP_AnalogExtensionBoard;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_AnalogExtensionBoard;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_info_aeb(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_aeb              snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_aeb(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_aeb(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_aeb(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_aeb(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_aeb(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -2509,7 +2530,7 @@ static int snd_hdsp_put_aeb(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * uc
 }
 
 #define HDSP_PREF_SYNC_REF(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_pref_sync_ref, \
@@ -2517,7 +2538,7 @@ static int snd_hdsp_put_aeb(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * uc
   .put = snd_hdsp_put_pref_sync_ref \
 }
 
-static int hdsp_pref_sync_ref(hdsp_t *hdsp)
+static int hdsp_pref_sync_ref(struct hdsp *hdsp)
 {
        /* Notice that this looks at the requested sync source,
           not the one actually in use.
@@ -2542,7 +2563,7 @@ static int hdsp_pref_sync_ref(hdsp_t *hdsp)
        return 0;
 }
 
-static int hdsp_set_pref_sync_ref(hdsp_t *hdsp, int pref)
+static int hdsp_set_pref_sync_ref(struct hdsp *hdsp, int pref)
 {
        hdsp->control_register &= ~HDSP_SyncRefMask;
        switch (pref) {
@@ -2571,11 +2592,11 @@ static int hdsp_set_pref_sync_ref(hdsp_t *hdsp, int pref)
        return 0;
 }
 
-static int snd_hdsp_info_pref_sync_ref(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_pref_sync_ref(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"Word", "IEC958", "ADAT1", "ADAT Sync", "ADAT2", "ADAT3" };
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
 
@@ -2594,27 +2615,27 @@ static int snd_hdsp_info_pref_sync_ref(snd_kcontrol_t *kcontrol, snd_ctl_elem_in
                uinfo->value.enumerated.items = 0;
                break;
        }
-               
+
        if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
                uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
        strcpy(uinfo->value.enumerated.name, texts[uinfo->value.enumerated.item]);
        return 0;
 }
 
-static int snd_hdsp_get_pref_sync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_pref_sync_ref(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_pref_sync_ref(hdsp);
        return 0;
 }
 
-static int snd_hdsp_put_pref_sync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_pref_sync_ref(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change, max;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
 
@@ -2642,7 +2663,7 @@ static int snd_hdsp_put_pref_sync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_va
 }
 
 #define HDSP_AUTOSYNC_REF(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ, \
@@ -2650,7 +2671,7 @@ static int snd_hdsp_put_pref_sync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_va
   .get = snd_hdsp_get_autosync_ref, \
 }
 
-static int hdsp_autosync_ref(hdsp_t *hdsp)
+static int hdsp_autosync_ref(struct hdsp *hdsp)
 {
        /* This looks at the autosync selected sync reference */
        unsigned int status2 = hdsp_read(hdsp, HDSP_status2Register);
@@ -2663,7 +2684,7 @@ static int hdsp_autosync_ref(hdsp_t *hdsp)
        case HDSP_SelSyncRef_SPDIF:
                return HDSP_AUTOSYNC_FROM_SPDIF;
        case HDSP_SelSyncRefMask:
-               return HDSP_AUTOSYNC_FROM_NONE; 
+               return HDSP_AUTOSYNC_FROM_NONE;
        case HDSP_SelSyncRef_ADAT1:
                return HDSP_AUTOSYNC_FROM_ADAT1;
        case HDSP_SelSyncRef_ADAT2:
@@ -2676,10 +2697,10 @@ static int hdsp_autosync_ref(hdsp_t *hdsp)
        return 0;
 }
 
-static int snd_hdsp_info_autosync_ref(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_autosync_ref(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {"Word", "ADAT Sync", "IEC958", "None", "ADAT1", "ADAT2", "ADAT3" };
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 7;
@@ -2689,16 +2710,16 @@ static int snd_hdsp_info_autosync_ref(snd_kcontrol_t *kcontrol, snd_ctl_elem_inf
        return 0;
 }
 
-static int snd_hdsp_get_autosync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_autosync_ref(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        ucontrol->value.enumerated.item[0] = hdsp_autosync_ref(hdsp);
        return 0;
 }
 
 #define HDSP_LINE_OUT(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_line_out, \
@@ -2706,47 +2727,39 @@ static int snd_hdsp_get_autosync_ref(snd_kcontrol_t * kcontrol, snd_ctl_elem_val
   .put = snd_hdsp_put_line_out \
 }
 
-static int hdsp_line_out(hdsp_t *hdsp)
+static int hdsp_line_out(struct hdsp *hdsp)
 {
        return (hdsp->control_register & HDSP_LineOut) ? 1 : 0;
 }
 
-static int hdsp_set_line_output(hdsp_t *hdsp, int out)
+static int hdsp_set_line_output(struct hdsp *hdsp, int out)
 {
-       if (out) {
+       if (out)
                hdsp->control_register |= HDSP_LineOut;
-       } else {
+       else
                hdsp->control_register &= ~HDSP_LineOut;
-       }
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
        return 0;
 }
 
-static int snd_hdsp_info_line_out(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_line_out         snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_line_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_line_out(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        spin_lock_irq(&hdsp->lock);
        ucontrol->value.integer.value[0] = hdsp_line_out(hdsp);
        spin_unlock_irq(&hdsp->lock);
        return 0;
 }
 
-static int snd_hdsp_put_line_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_line_out(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -2758,7 +2771,7 @@ static int snd_hdsp_put_line_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
 }
 
 #define HDSP_PRECISE_POINTER(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_CARD, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_precise_pointer, \
@@ -2766,41 +2779,33 @@ static int snd_hdsp_put_line_out(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
   .put = snd_hdsp_put_precise_pointer \
 }
 
-static int hdsp_set_precise_pointer(hdsp_t *hdsp, int precise)
+static int hdsp_set_precise_pointer(struct hdsp *hdsp, int precise)
 {
-       if (precise) {
+       if (precise)
                hdsp->precise_ptr = 1;
-       } else {
+       else
                hdsp->precise_ptr = 0;
-       }
        return 0;
 }
 
-static int snd_hdsp_info_precise_pointer(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_precise_pointer          snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_precise_pointer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_precise_pointer(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        spin_lock_irq(&hdsp->lock);
        ucontrol->value.integer.value[0] = hdsp->precise_ptr;
        spin_unlock_irq(&hdsp->lock);
        return 0;
 }
 
-static int snd_hdsp_put_precise_pointer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_precise_pointer(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -2812,7 +2817,7 @@ static int snd_hdsp_put_precise_pointer(snd_kcontrol_t * kcontrol, snd_ctl_elem_
 }
 
 #define HDSP_USE_MIDI_TASKLET(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_CARD, \
   .name = xname, \
   .index = xindex, \
   .info = snd_hdsp_info_use_midi_tasklet, \
@@ -2820,41 +2825,33 @@ static int snd_hdsp_put_precise_pointer(snd_kcontrol_t * kcontrol, snd_ctl_elem_
   .put = snd_hdsp_put_use_midi_tasklet \
 }
 
-static int hdsp_set_use_midi_tasklet(hdsp_t *hdsp, int use_tasklet)
+static int hdsp_set_use_midi_tasklet(struct hdsp *hdsp, int use_tasklet)
 {
-       if (use_tasklet) {
+       if (use_tasklet)
                hdsp->use_midi_tasklet = 1;
-       } else {
+       else
                hdsp->use_midi_tasklet = 0;
-       }
        return 0;
 }
 
-static int snd_hdsp_info_use_midi_tasklet(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = 1;
-       return 0;
-}
+#define snd_hdsp_info_use_midi_tasklet         snd_ctl_boolean_mono_info
 
-static int snd_hdsp_get_use_midi_tasklet(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_use_midi_tasklet(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
-       
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
        spin_lock_irq(&hdsp->lock);
        ucontrol->value.integer.value[0] = hdsp->use_midi_tasklet;
        spin_unlock_irq(&hdsp->lock);
        return 0;
 }
 
-static int snd_hdsp_put_use_midi_tasklet(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_use_midi_tasklet(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        unsigned int val;
-       
+
        if (!snd_hdsp_use_is_exclusive(hdsp))
                return -EBUSY;
        val = ucontrol->value.integer.value[0] & 1;
@@ -2869,6 +2866,7 @@ static int snd_hdsp_put_use_midi_tasklet(snd_kcontrol_t * kcontrol, snd_ctl_elem
 { .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
   .name = xname, \
   .index = xindex, \
+  .device = 0, \
   .access = SNDRV_CTL_ELEM_ACCESS_READWRITE | \
                 SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
   .info = snd_hdsp_info_mixer, \
@@ -2876,7 +2874,7 @@ static int snd_hdsp_put_use_midi_tasklet(snd_kcontrol_t * kcontrol, snd_ctl_elem
   .put = snd_hdsp_put_mixer \
 }
 
-static int snd_hdsp_info_mixer(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_mixer(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
        uinfo->count = 3;
@@ -2886,31 +2884,30 @@ static int snd_hdsp_info_mixer(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * u
        return 0;
 }
 
-static int snd_hdsp_get_mixer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_mixer(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int source;
        int destination;
        int addr;
 
        source = ucontrol->value.integer.value[0];
        destination = ucontrol->value.integer.value[1];
-       
-       if (source >= hdsp->max_channels) {
+
+       if (source >= hdsp->max_channels)
                addr = hdsp_playback_to_output_key(hdsp,source-hdsp->max_channels,destination);
-       } else {
+       else
                addr = hdsp_input_to_output_key(hdsp,source, destination);
-       }
-       
+
        spin_lock_irq(&hdsp->lock);
        ucontrol->value.integer.value[2] = hdsp_read_gain (hdsp, addr);
        spin_unlock_irq(&hdsp->lock);
        return 0;
 }
 
-static int snd_hdsp_put_mixer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_put_mixer(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
        int change;
        int source;
        int destination;
@@ -2923,11 +2920,10 @@ static int snd_hdsp_put_mixer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *
        source = ucontrol->value.integer.value[0];
        destination = ucontrol->value.integer.value[1];
 
-       if (source >= hdsp->max_channels) {
+       if (source >= hdsp->max_channels)
                addr = hdsp_playback_to_output_key(hdsp,source-hdsp->max_channels, destination);
-       } else {
+       else
                addr = hdsp_input_to_output_key(hdsp,source, destination);
-       }
 
        gain = ucontrol->value.integer.value[2];
 
@@ -2940,7 +2936,7 @@ static int snd_hdsp_put_mixer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *
 }
 
 #define HDSP_WC_SYNC_CHECK(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
@@ -2948,9 +2944,9 @@ static int snd_hdsp_put_mixer(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *
   .get = snd_hdsp_get_wc_sync_check \
 }
 
-static int snd_hdsp_info_sync_check(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_hdsp_info_sync_check(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
-       static char *texts[] = {"No Lock", "Lock", "Sync" };    
+       static char *texts[] = {"No Lock", "Lock", "Sync" };
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 3;
@@ -2960,31 +2956,29 @@ static int snd_hdsp_info_sync_check(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_
        return 0;
 }
 
-static int hdsp_wc_sync_check(hdsp_t *hdsp)
+static int hdsp_wc_sync_check(struct hdsp *hdsp)
 {
        int status2 = hdsp_read(hdsp, HDSP_status2Register);
        if (status2 & HDSP_wc_lock) {
-               if (status2 & HDSP_wc_sync) {
+               if (status2 & HDSP_wc_sync)
                        return 2;
-               } else {
+               else
                         return 1;
-               }
-       } else {                
+       } else
                return 0;
-       }
        return 0;
 }
 
-static int snd_hdsp_get_wc_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_wc_sync_check(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        ucontrol->value.enumerated.item[0] = hdsp_wc_sync_check(hdsp);
        return 0;
 }
 
 #define HDSP_SPDIF_SYNC_CHECK(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
@@ -2992,31 +2986,30 @@ static int snd_hdsp_get_wc_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_va
   .get = snd_hdsp_get_spdif_sync_check \
 }
 
-static int hdsp_spdif_sync_check(hdsp_t *hdsp)
+static int hdsp_spdif_sync_check(struct hdsp *hdsp)
 {
        int status = hdsp_read(hdsp, HDSP_statusRegister);
-       if (status & HDSP_SPDIFErrorFlag) {
+       if (status & HDSP_SPDIFErrorFlag)
                return 0;
-       } else {        
-               if (status & HDSP_SPDIFSync) {
+       else {
+               if (status & HDSP_SPDIFSync)
                        return 2;
-               } else {
+               else
                        return 1;
-               }
        }
        return 0;
 }
 
-static int snd_hdsp_get_spdif_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_spdif_sync_check(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        ucontrol->value.enumerated.item[0] = hdsp_spdif_sync_check(hdsp);
        return 0;
 }
 
 #define HDSP_ADATSYNC_SYNC_CHECK(xname, xindex) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .name = xname, \
   .index = xindex, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
@@ -3024,57 +3017,53 @@ static int snd_hdsp_get_spdif_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem
   .get = snd_hdsp_get_adatsync_sync_check \
 }
 
-static int hdsp_adatsync_sync_check(hdsp_t *hdsp)
+static int hdsp_adatsync_sync_check(struct hdsp *hdsp)
 {
        int status = hdsp_read(hdsp, HDSP_statusRegister);
        if (status & HDSP_TimecodeLock) {
-               if (status & HDSP_TimecodeSync) {
+               if (status & HDSP_TimecodeSync)
                        return 2;
-               } else {
+               else
                        return 1;
-               }
-       } else {
+       } else
                return 0;
-       }
-}      
+}
 
-static int snd_hdsp_get_adatsync_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_adatsync_sync_check(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        ucontrol->value.enumerated.item[0] = hdsp_adatsync_sync_check(hdsp);
        return 0;
 }
 
 #define HDSP_ADAT_SYNC_CHECK \
-{ .iface = SNDRV_CTL_ELEM_IFACE_HWDEP, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
   .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
   .info = snd_hdsp_info_sync_check, \
   .get = snd_hdsp_get_adat_sync_check \
 }
 
-static int hdsp_adat_sync_check(hdsp_t *hdsp, int idx)
-{      
+static int hdsp_adat_sync_check(struct hdsp *hdsp, int idx)
+{
        int status = hdsp_read(hdsp, HDSP_statusRegister);
-       
+
        if (status & (HDSP_Lock0>>idx)) {
-               if (status & (HDSP_Sync0>>idx)) {
+               if (status & (HDSP_Sync0>>idx))
                        return 2;
-               } else {
-                       return 1;               
-               }
-       } else {
+               else
+                       return 1;
+       } else
                return 0;
-       }               
-} 
+}
 
-static int snd_hdsp_get_adat_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_hdsp_get_adat_sync_check(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        int offset;
-       hdsp_t *hdsp = snd_kcontrol_chip(kcontrol);
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
 
        offset = ucontrol->id.index - 1;
-       snd_assert(offset >= 0);
+       snd_BUG_ON(offset < 0);
 
        switch (hdsp->io_type) {
        case Digiface:
@@ -3084,7 +3073,7 @@ static int snd_hdsp_get_adat_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_
                break;
        case Multiface:
        case H9632:
-               if (offset >= 1) 
+               if (offset >= 1)
                        return -EINVAL;
                break;
        default:
@@ -3095,14 +3084,88 @@ static int snd_hdsp_get_adat_sync_check(snd_kcontrol_t * kcontrol, snd_ctl_elem_
        return 0;
 }
 
-static snd_kcontrol_new_t snd_hdsp_9632_controls[] = {
+#define HDSP_DDS_OFFSET(xname, xindex) \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
+  .name = xname, \
+  .index = xindex, \
+  .info = snd_hdsp_info_dds_offset, \
+  .get = snd_hdsp_get_dds_offset, \
+  .put = snd_hdsp_put_dds_offset \
+}
+
+static int hdsp_dds_offset(struct hdsp *hdsp)
+{
+       u64 n;
+       unsigned int dds_value = hdsp->dds_value;
+       int system_sample_rate = hdsp->system_sample_rate;
+
+       if (!dds_value)
+               return 0;
+
+       n = DDS_NUMERATOR;
+       /*
+        * dds_value = n / rate
+        * rate = n / dds_value
+        */
+       n = div_u64(n, dds_value);
+       if (system_sample_rate >= 112000)
+               n *= 4;
+       else if (system_sample_rate >= 56000)
+               n *= 2;
+       return ((int)n) - system_sample_rate;
+}
+
+static int hdsp_set_dds_offset(struct hdsp *hdsp, int offset_hz)
+{
+       int rate = hdsp->system_sample_rate + offset_hz;
+       hdsp_set_dds_value(hdsp, rate);
+       return 0;
+}
+
+static int snd_hdsp_info_dds_offset(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
+{
+       uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
+       uinfo->count = 1;
+       uinfo->value.integer.min = -5000;
+       uinfo->value.integer.max = 5000;
+       return 0;
+}
+
+static int snd_hdsp_get_dds_offset(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
+{
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+
+       ucontrol->value.enumerated.item[0] = hdsp_dds_offset(hdsp);
+       return 0;
+}
+
+static int snd_hdsp_put_dds_offset(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
+{
+       struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
+       int change;
+       int val;
+
+       if (!snd_hdsp_use_is_exclusive(hdsp))
+               return -EBUSY;
+       val = ucontrol->value.enumerated.item[0];
+       spin_lock_irq(&hdsp->lock);
+       if (val != hdsp_dds_offset(hdsp))
+               change = (hdsp_set_dds_offset(hdsp, val) == 0) ? 1 : 0;
+       else
+               change = 0;
+       spin_unlock_irq(&hdsp->lock);
+       return change;
+}
+
+static struct snd_kcontrol_new snd_hdsp_9632_controls[] = {
 HDSP_DA_GAIN("DA Gain", 0),
 HDSP_AD_GAIN("AD Gain", 0),
 HDSP_PHONE_GAIN("Phones Gain", 0),
-HDSP_XLR_BREAKOUT_CABLE("XLR Breakout Cable", 0)
+HDSP_XLR_BREAKOUT_CABLE("XLR Breakout Cable", 0),
+HDSP_DDS_OFFSET("DDS Sample Rate Offset", 0)
 };
 
-static snd_kcontrol_new_t snd_hdsp_controls[] = {
+static struct snd_kcontrol_new snd_hdsp_controls[] = {
 {
        .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,DEFAULT),
@@ -3120,17 +3183,17 @@ static snd_kcontrol_new_t snd_hdsp_controls[] = {
 },
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
-       .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
+       .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,CON_MASK),
        .info =         snd_hdsp_control_spdif_mask_info,
        .get =          snd_hdsp_control_spdif_mask_get,
        .private_value = IEC958_AES0_NONAUDIO |
                         IEC958_AES0_PROFESSIONAL |
-                        IEC958_AES0_CON_EMPHASIS,                                                                                            
+                        IEC958_AES0_CON_EMPHASIS,
 },
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
-       .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
+       .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,PRO_MASK),
        .info =         snd_hdsp_control_spdif_mask_info,
        .get =          snd_hdsp_control_spdif_mask_get,
@@ -3144,11 +3207,9 @@ HDSP_SPDIF_OUT("IEC958 Output also on ADAT1", 0),
 HDSP_SPDIF_PROFESSIONAL("IEC958 Professional Bit", 0),
 HDSP_SPDIF_EMPHASIS("IEC958 Emphasis Bit", 0),
 HDSP_SPDIF_NON_AUDIO("IEC958 Non-audio Bit", 0),
-/* 'Sample Clock Source' complies with the alsa control naming scheme */ 
+/* 'Sample Clock Source' complies with the alsa control naming scheme */
 HDSP_CLOCK_SOURCE("Sample Clock Source", 0),
 {
-       /* FIXME: should be PCM or MIXER? */
-       /* .iface = SNDRV_CTL_ELEM_IFACE_PCM, */
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Sample Clock Source Locking",
        .info = snd_hdsp_info_clock_source_lock,
@@ -3170,19 +3231,18 @@ HDSP_PRECISE_POINTER("Precise Pointer", 0),
 HDSP_USE_MIDI_TASKLET("Use Midi Tasklet", 0),
 };
 
-static snd_kcontrol_new_t snd_hdsp_96xx_aeb = HDSP_AEB("Analog Extension Board", 0);
-static snd_kcontrol_new_t snd_hdsp_adat_sync_check = HDSP_ADAT_SYNC_CHECK;
+static struct snd_kcontrol_new snd_hdsp_96xx_aeb = HDSP_AEB("Analog Extension Board", 0);
+static struct snd_kcontrol_new snd_hdsp_adat_sync_check = HDSP_ADAT_SYNC_CHECK;
 
-static int snd_hdsp_create_controls(snd_card_t *card, hdsp_t *hdsp)
+static int snd_hdsp_create_controls(struct snd_card *card, struct hdsp *hdsp)
 {
        unsigned int idx;
        int err;
-       snd_kcontrol_t *kctl;
+       struct snd_kcontrol *kctl;
 
        for (idx = 0; idx < ARRAY_SIZE(snd_hdsp_controls); idx++) {
-               if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_controls[idx], hdsp))) < 0) {
+               if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_controls[idx], hdsp))) < 0)
                        return err;
-               }
                if (idx == 1)   /* IEC958 (S/PDIF) Stream */
                        hdsp->spdif_ctl = kctl;
        }
@@ -3190,45 +3250,41 @@ static int snd_hdsp_create_controls(snd_card_t *card, hdsp_t *hdsp)
        /* ADAT SyncCheck status */
        snd_hdsp_adat_sync_check.name = "ADAT Lock Status";
        snd_hdsp_adat_sync_check.index = 1;
-       if ((err = snd_ctl_add (card, kctl = snd_ctl_new1(&snd_hdsp_adat_sync_check, hdsp)))) {
+       if ((err = snd_ctl_add (card, kctl = snd_ctl_new1(&snd_hdsp_adat_sync_check, hdsp))))
                return err;
-       }       
        if (hdsp->io_type == Digiface || hdsp->io_type == H9652) {
                for (idx = 1; idx < 3; ++idx) {
                        snd_hdsp_adat_sync_check.index = idx+1;
-                       if ((err = snd_ctl_add (card, kctl = snd_ctl_new1(&snd_hdsp_adat_sync_check, hdsp)))) {
+                       if ((err = snd_ctl_add (card, kctl = snd_ctl_new1(&snd_hdsp_adat_sync_check, hdsp))))
                                return err;
-                       }
                }
        }
-       
+
        /* DA, AD and Phone gain and XLR breakout cable controls for H9632 cards */
        if (hdsp->io_type == H9632) {
                for (idx = 0; idx < ARRAY_SIZE(snd_hdsp_9632_controls); idx++) {
-                       if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_9632_controls[idx], hdsp))) < 0) {
+                       if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_9632_controls[idx], hdsp))) < 0)
                                return err;
-                       }
                }
        }
 
        /* AEB control for H96xx card */
        if (hdsp->io_type == H9632 || hdsp->io_type == H9652) {
-               if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_96xx_aeb, hdsp))) < 0) {
+               if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_96xx_aeb, hdsp))) < 0)
                                return err;
-               }       
        }
 
        return 0;
 }
 
 /*------------------------------------------------------------
-   /proc interface 
+   /proc interface
  ------------------------------------------------------------*/
 
 static void
-snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
+snd_hdsp_proc_read(struct snd_info_entry *entry, struct snd_info_buffer *buffer)
 {
-       hdsp_t *hdsp = (hdsp_t *) entry->private_data;
+       struct hdsp *hdsp = (struct hdsp *) entry->private_data;
        unsigned int status;
        unsigned int status2;
        char *pref_sync_ref;
@@ -3237,35 +3293,49 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
        char *clock_source;
        int x;
 
-       if (hdsp_check_for_iobox (hdsp)) {
-               snd_iprintf(buffer, "No I/O box connected.\nPlease connect one and upload firmware.\n");
+       status = hdsp_read(hdsp, HDSP_statusRegister);
+       status2 = hdsp_read(hdsp, HDSP_status2Register);
+
+       snd_iprintf(buffer, "%s (Card #%d)\n", hdsp->card_name,
+                   hdsp->card->number + 1);
+       snd_iprintf(buffer, "Buffers: capture %p playback %p\n",
+                   hdsp->capture_buffer, hdsp->playback_buffer);
+       snd_iprintf(buffer, "IRQ: %d Registers bus: 0x%lx VM: 0x%lx\n",
+                   hdsp->irq, hdsp->port, (unsigned long)hdsp->iobase);
+       snd_iprintf(buffer, "Control register: 0x%x\n", hdsp->control_register);
+       snd_iprintf(buffer, "Control2 register: 0x%x\n",
+                   hdsp->control2_register);
+       snd_iprintf(buffer, "Status register: 0x%x\n", status);
+       snd_iprintf(buffer, "Status2 register: 0x%x\n", status2);
+
+       if (hdsp_check_for_iobox(hdsp)) {
+               snd_iprintf(buffer, "No I/O box connected.\n"
+                           "Please connect one and upload firmware.\n");
                return;
        }
 
-       if (hdsp_check_for_firmware(hdsp)) {
+       if (hdsp_check_for_firmware(hdsp, 0)) {
                if (hdsp->state & HDSP_FirmwareCached) {
                        if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_iprintf(buffer, "Firmware loading from cache failed, please upload manually.\n");
+                               snd_iprintf(buffer, "Firmware loading from "
+                                           "cache failed, "
+                                           "please upload manually.\n");
                                return;
                        }
                } else {
-                       snd_iprintf(buffer, "No firmware loaded nor cached, please upload firmware.\n");
-                       return;
+                       int err = -EINVAL;
+#ifdef HDSP_FW_LOADER
+                       err = hdsp_request_fw_loader(hdsp);
+#endif
+                       if (err < 0) {
+                               snd_iprintf(buffer,
+                                           "No firmware loaded nor cached, "
+                                           "please upload firmware.\n");
+                               return;
+                       }
                }
        }
-       
-       status = hdsp_read(hdsp, HDSP_statusRegister);
-       status2 = hdsp_read(hdsp, HDSP_status2Register);
 
-       snd_iprintf(buffer, "%s (Card #%d)\n", hdsp->card_name, hdsp->card->number + 1);
-       snd_iprintf(buffer, "Buffers: capture %p playback %p\n",
-                   hdsp->capture_buffer, hdsp->playback_buffer);
-       snd_iprintf(buffer, "IRQ: %d Registers bus: 0x%lx VM: 0x%lx\n",
-                   hdsp->irq, hdsp->port, (unsigned long)hdsp->iobase);
-       snd_iprintf(buffer, "Control register: 0x%x\n", hdsp->control_register);
-       snd_iprintf(buffer, "Control2 register: 0x%x\n", hdsp->control2_register);
-       snd_iprintf(buffer, "Status register: 0x%x\n", status);
-       snd_iprintf(buffer, "Status2 register: 0x%x\n", status2);
        snd_iprintf(buffer, "FIFO status: %d\n", hdsp_read(hdsp, HDSP_fifoStatus) & 0xff);
        snd_iprintf(buffer, "MIDI1 Output status: 0x%x\n", hdsp_read(hdsp, HDSP_midiStatusOut0));
        snd_iprintf(buffer, "MIDI1 Input status: 0x%x\n", hdsp_read(hdsp, HDSP_midiStatusIn0));
@@ -3286,7 +3356,6 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
 
        snd_iprintf(buffer, "\n");
 
-
        switch (hdsp_clock_source(hdsp)) {
        case HDSP_CLOCK_SOURCE_AUTOSYNC:
                clock_source = "AutoSync";
@@ -3317,18 +3386,17 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                break;
                case HDSP_CLOCK_SOURCE_INTERNAL_192KHZ:
                clock_source = "Internal 192 kHz";
-               break;  
+               break;
        default:
-               clock_source = "Error";         
+               clock_source = "Error";
        }
        snd_iprintf (buffer, "Sample Clock Source: %s\n", clock_source);
-                       
-       if (hdsp_system_clock_mode(hdsp)) {
+
+       if (hdsp_system_clock_mode(hdsp))
                system_clock_mode = "Slave";
-       } else {
+       else
                system_clock_mode = "Master";
-       }
-       
+
        switch (hdsp_pref_sync_ref (hdsp)) {
        case HDSP_SYNC_FROM_WORD:
                pref_sync_ref = "Word Clock";
@@ -3353,7 +3421,7 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                break;
        }
        snd_iprintf (buffer, "Preferred Sync Reference: %s\n", pref_sync_ref);
-       
+
        switch (hdsp_autosync_ref (hdsp)) {
        case HDSP_AUTOSYNC_FROM_WORD:
                autosync_ref = "Word Clock";
@@ -3366,7 +3434,7 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                break;
        case HDSP_AUTOSYNC_FROM_NONE:
                autosync_ref = "None";
-               break;  
+               break;
        case HDSP_AUTOSYNC_FROM_ADAT1:
                autosync_ref = "ADAT1";
                break;
@@ -3381,14 +3449,14 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                break;
        }
        snd_iprintf (buffer, "AutoSync Reference: %s\n", autosync_ref);
-       
+
        snd_iprintf (buffer, "AutoSync Frequency: %d\n", hdsp_external_sample_rate(hdsp));
-       
+
        snd_iprintf (buffer, "System Clock Mode: %s\n", system_clock_mode);
 
        snd_iprintf (buffer, "System Clock Frequency: %d\n", hdsp->system_sample_rate);
        snd_iprintf (buffer, "System Clock Locked: %s\n", hdsp->clock_source_locked ? "Yes" : "No");
-               
+
        snd_iprintf(buffer, "\n");
 
        switch (hdsp_spdif_in(hdsp)) {
@@ -3408,93 +3476,83 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                snd_iprintf(buffer, "IEC958 input: ???\n");
                break;
        }
-       
-       if (hdsp->control_register & HDSP_SPDIFOpticalOut) {
+
+       if (hdsp->control_register & HDSP_SPDIFOpticalOut)
                snd_iprintf(buffer, "IEC958 output: Coaxial & ADAT1\n");
-       } else {
+       else
                snd_iprintf(buffer, "IEC958 output: Coaxial only\n");
-       }
 
-       if (hdsp->control_register & HDSP_SPDIFProfessional) {
+       if (hdsp->control_register & HDSP_SPDIFProfessional)
                snd_iprintf(buffer, "IEC958 quality: Professional\n");
-       } else {
+       else
                snd_iprintf(buffer, "IEC958 quality: Consumer\n");
-       }
 
-       if (hdsp->control_register & HDSP_SPDIFEmphasis) {
+       if (hdsp->control_register & HDSP_SPDIFEmphasis)
                snd_iprintf(buffer, "IEC958 emphasis: on\n");
-       } else {
+       else
                snd_iprintf(buffer, "IEC958 emphasis: off\n");
-       }
 
-       if (hdsp->control_register & HDSP_SPDIFNonAudio) {
+       if (hdsp->control_register & HDSP_SPDIFNonAudio)
                snd_iprintf(buffer, "IEC958 NonAudio: on\n");
-       } else {
+       else
                snd_iprintf(buffer, "IEC958 NonAudio: off\n");
-       }
-       if ((x = hdsp_spdif_sample_rate (hdsp)) != 0) {
+       if ((x = hdsp_spdif_sample_rate (hdsp)) != 0)
                snd_iprintf (buffer, "IEC958 sample rate: %d\n", x);
-       } else {
+       else
                snd_iprintf (buffer, "IEC958 sample rate: Error flag set\n");
-       }
 
        snd_iprintf(buffer, "\n");
 
        /* Sync Check */
        x = status & HDSP_Sync0;
-       if (status & HDSP_Lock0) {
+       if (status & HDSP_Lock0)
                snd_iprintf(buffer, "ADAT1: %s\n", x ? "Sync" : "Lock");
-       } else {
+       else
                snd_iprintf(buffer, "ADAT1: No Lock\n");
-       }
 
        switch (hdsp->io_type) {
        case Digiface:
        case H9652:
                x = status & HDSP_Sync1;
-               if (status & HDSP_Lock1) {
+               if (status & HDSP_Lock1)
                        snd_iprintf(buffer, "ADAT2: %s\n", x ? "Sync" : "Lock");
-               } else {
+               else
                        snd_iprintf(buffer, "ADAT2: No Lock\n");
-               }
                x = status & HDSP_Sync2;
-               if (status & HDSP_Lock2) {
+               if (status & HDSP_Lock2)
                        snd_iprintf(buffer, "ADAT3: %s\n", x ? "Sync" : "Lock");
-               } else {
+               else
                        snd_iprintf(buffer, "ADAT3: No Lock\n");
-               }
+               break;
        default:
                /* relax */
                break;
        }
 
        x = status & HDSP_SPDIFSync;
-       if (status & HDSP_SPDIFErrorFlag) {
+       if (status & HDSP_SPDIFErrorFlag)
                snd_iprintf (buffer, "SPDIF: No Lock\n");
-       } else {
+       else
                snd_iprintf (buffer, "SPDIF: %s\n", x ? "Sync" : "Lock");
-       }
-       
+
        x = status2 & HDSP_wc_sync;
-       if (status2 & HDSP_wc_lock) {
+       if (status2 & HDSP_wc_lock)
                snd_iprintf (buffer, "Word Clock: %s\n", x ? "Sync" : "Lock");
-       } else {
+       else
                snd_iprintf (buffer, "Word Clock: No Lock\n");
-       }
-       
+
        x = status & HDSP_TimecodeSync;
-       if (status & HDSP_TimecodeLock) {
+       if (status & HDSP_TimecodeLock)
                snd_iprintf(buffer, "ADAT Sync: %s\n", x ? "Sync" : "Lock");
-       } else {
+       else
                snd_iprintf(buffer, "ADAT Sync: No Lock\n");
-       }
 
        snd_iprintf(buffer, "\n");
-       
+
        /* Informations about H9632 specific controls */
        if (hdsp->io_type == H9632) {
                char *tmp;
-       
+
                switch (hdsp_ad_gain(hdsp)) {
                case 0:
                        tmp = "-10 dBV";
@@ -3520,7 +3578,7 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                        break;
                }
                snd_iprintf(buffer, "DA Gain : %s\n", tmp);
-               
+
                switch (hdsp_phone_gain(hdsp)) {
                case 0:
                        tmp = "0 dB";
@@ -3534,33 +3592,32 @@ snd_hdsp_proc_read(snd_info_entry_t *entry, snd_info_buffer_t *buffer)
                }
                snd_iprintf(buffer, "Phones Gain : %s\n", tmp);
 
-               snd_iprintf(buffer, "XLR Breakout Cable : %s\n", hdsp_xlr_breakout_cable(hdsp) ? "yes" : "no"); 
-               
-               if (hdsp->control_register & HDSP_AnalogExtensionBoard) {
+               snd_iprintf(buffer, "XLR Breakout Cable : %s\n", hdsp_xlr_breakout_cable(hdsp) ? "yes" : "no");
+
+               if (hdsp->control_register & HDSP_AnalogExtensionBoard)
                        snd_iprintf(buffer, "AEB : on (ADAT1 internal)\n");
-               } else {
+               else
                        snd_iprintf(buffer, "AEB : off (ADAT1 external)\n");
-               }
                snd_iprintf(buffer, "\n");
        }
 
 }
 
-static void __devinit snd_hdsp_proc_init(hdsp_t *hdsp)
+static void snd_hdsp_proc_init(struct hdsp *hdsp)
 {
-       snd_info_entry_t *entry;
+       struct snd_info_entry *entry;
 
        if (! snd_card_proc_new(hdsp->card, "hdsp", &entry))
-               snd_info_set_text_ops(entry, hdsp, 1024, snd_hdsp_proc_read);
+               snd_info_set_text_ops(entry, hdsp, snd_hdsp_proc_read);
 }
 
-static void snd_hdsp_free_buffers(hdsp_t *hdsp)
+static void snd_hdsp_free_buffers(struct hdsp *hdsp)
 {
        snd_hammerfall_free_buffer(&hdsp->capture_dma_buf, hdsp->pci);
        snd_hammerfall_free_buffer(&hdsp->playback_dma_buf, hdsp->pci);
 }
 
-static int __devinit snd_hdsp_initialize_memory(hdsp_t *hdsp)
+static int __devinit snd_hdsp_initialize_memory(struct hdsp *hdsp)
 {
        unsigned long pb_bus, cb_bus;
 
@@ -3574,8 +3631,8 @@ static int __devinit snd_hdsp_initialize_memory(hdsp_t *hdsp)
 
        /* Align to bus-space 64K boundary */
 
-       cb_bus = (hdsp->capture_dma_buf.addr + 0xFFFF) & ~0xFFFFl;
-       pb_bus = (hdsp->playback_dma_buf.addr + 0xFFFF) & ~0xFFFFl;
+       cb_bus = ALIGN(hdsp->capture_dma_buf.addr, 0x10000ul);
+       pb_bus = ALIGN(hdsp->playback_dma_buf.addr, 0x10000ul);
 
        /* Tell the card where it is */
 
@@ -3588,29 +3645,29 @@ static int __devinit snd_hdsp_initialize_memory(hdsp_t *hdsp)
        return 0;
 }
 
-static int snd_hdsp_set_defaults(hdsp_t *hdsp)
+static int snd_hdsp_set_defaults(struct hdsp *hdsp)
 {
        unsigned int i;
 
        /* ASSUMPTION: hdsp->lock is either held, or
           there is no need to hold it (e.g. during module
-          initalization).
+          initialization).
         */
 
        /* set defaults:
 
-          SPDIF Input via Coax 
+          SPDIF Input via Coax
           Master clock mode
           maximum latency (7 => 2^7 = 8192 samples, 64Kbyte buffer,
                            which implies 2 4096 sample, 32Kbyte periods).
-           Enable line out.                        
+           Enable line out.
         */
 
-       hdsp->control_register = HDSP_ClockModeMaster | 
-                                HDSP_SPDIFInputCoaxial | 
-                                hdsp_encode_latency(7) | 
+       hdsp->control_register = HDSP_ClockModeMaster |
+                                HDSP_SPDIFInputCoaxial |
+                                hdsp_encode_latency(7) |
                                 HDSP_LineOut;
-       
+
 
        hdsp_write(hdsp, HDSP_controlRegister, hdsp->control_register);
 
@@ -3619,27 +3676,24 @@ static int snd_hdsp_set_defaults(hdsp_t *hdsp)
 #else
        hdsp->control2_register = 0;
 #endif
-       if (hdsp->io_type == H9652) {
+       if (hdsp->io_type == H9652)
                snd_hdsp_9652_enable_mixer (hdsp);
-       } else {
-           hdsp_write (hdsp, HDSP_control2Reg, hdsp->control2_register);
-       } 
+       else
+               hdsp_write (hdsp, HDSP_control2Reg, hdsp->control2_register);
 
        hdsp_reset_hw_pointer(hdsp);
        hdsp_compute_period_size(hdsp);
 
        /* silence everything */
-       
-       for (i = 0; i < HDSP_MATRIX_MIXER_SIZE; ++i) {
+
+       for (i = 0; i < HDSP_MATRIX_MIXER_SIZE; ++i)
                hdsp->mixer_matrix[i] = MINUS_INFINITY_GAIN;
-       }
 
        for (i = 0; i < ((hdsp->io_type == H9652 || hdsp->io_type == H9632) ? 1352 : HDSP_MATRIX_MIXER_SIZE); ++i) {
-               if (hdsp_write_gain (hdsp, i, MINUS_INFINITY_GAIN)) {
+               if (hdsp_write_gain (hdsp, i, MINUS_INFINITY_GAIN))
                        return -EIO;
-               }
        }
-       
+
        /* H9632 specific defaults */
        if (hdsp->io_type == H9632) {
                hdsp->control_register |= (HDSP_DAGainPlus4dBu | HDSP_ADGainPlus4dBu | HDSP_PhoneGain0dB);
@@ -3656,19 +3710,17 @@ static int snd_hdsp_set_defaults(hdsp_t *hdsp)
 
 static void hdsp_midi_tasklet(unsigned long arg)
 {
-       hdsp_t *hdsp = (hdsp_t *)arg;
-       
-       if (hdsp->midi[0].pending) {
+       struct hdsp *hdsp = (struct hdsp *)arg;
+
+       if (hdsp->midi[0].pending)
                snd_hdsp_midi_input_read (&hdsp->midi[0]);
-       }
-       if (hdsp->midi[1].pending) {
+       if (hdsp->midi[1].pending)
                snd_hdsp_midi_input_read (&hdsp->midi[1]);
-       }
-} 
+}
 
-static irqreturn_t snd_hdsp_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t snd_hdsp_interrupt(int irq, void *dev_id)
 {
-       hdsp_t *hdsp = (hdsp_t *) dev_id;
+       struct hdsp *hdsp = (struct hdsp *) dev_id;
        unsigned int status;
        int audio;
        int midi0;
@@ -3676,32 +3728,32 @@ static irqreturn_t snd_hdsp_interrupt(int irq, void *dev_id, struct pt_regs *reg
        unsigned int midi0status;
        unsigned int midi1status;
        int schedule = 0;
-       
+
        status = hdsp_read(hdsp, HDSP_statusRegister);
 
        audio = status & HDSP_audioIRQPending;
        midi0 = status & HDSP_midi0IRQPending;
        midi1 = status & HDSP_midi1IRQPending;
 
-       if (!audio && !midi0 && !midi1) {
+       if (!audio && !midi0 && !midi1)
                return IRQ_NONE;
-       }
 
        hdsp_write(hdsp, HDSP_interruptConfirmation, 0);
 
        midi0status = hdsp_read (hdsp, HDSP_midiStatusIn0) & 0xff;
        midi1status = hdsp_read (hdsp, HDSP_midiStatusIn1) & 0xff;
-       
+
+       if (!(hdsp->state & HDSP_InitializationComplete))
+               return IRQ_HANDLED;
+
        if (audio) {
-               if (hdsp->capture_substream) {
+               if (hdsp->capture_substream)
                        snd_pcm_period_elapsed(hdsp->pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream);
-               }
-               
-               if (hdsp->playback_substream) {
+
+               if (hdsp->playback_substream)
                        snd_pcm_period_elapsed(hdsp->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream);
-               }
        }
-       
+
        if (midi0 && midi0status) {
                if (hdsp->use_midi_tasklet) {
                        /* we disable interrupts for this input until processing is done */
@@ -3725,83 +3777,87 @@ static irqreturn_t snd_hdsp_interrupt(int irq, void *dev_id, struct pt_regs *reg
                }
        }
        if (hdsp->use_midi_tasklet && schedule)
-               tasklet_hi_schedule(&hdsp->midi_tasklet);
+               tasklet_schedule(&hdsp->midi_tasklet);
        return IRQ_HANDLED;
 }
 
-static snd_pcm_uframes_t snd_hdsp_hw_pointer(snd_pcm_substream_t *substream)
+static snd_pcm_uframes_t snd_hdsp_hw_pointer(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        return hdsp_hw_pointer(hdsp);
 }
 
-static char *hdsp_channel_buffer_location(hdsp_t *hdsp,
+static char *hdsp_channel_buffer_location(struct hdsp *hdsp,
                                             int stream,
                                             int channel)
 
 {
        int mapped_channel;
 
-        snd_assert(channel >= 0 && channel < hdsp->max_channels, return NULL);
-        
-       if ((mapped_channel = hdsp->channel_map[channel]) < 0) {
+        if (snd_BUG_ON(channel < 0 || channel >= hdsp->max_channels))
                return NULL;
-       }
-       
-       if (stream == SNDRV_PCM_STREAM_CAPTURE) {
+
+       if ((mapped_channel = hdsp->channel_map[channel]) < 0)
+               return NULL;
+
+       if (stream == SNDRV_PCM_STREAM_CAPTURE)
                return hdsp->capture_buffer + (mapped_channel * HDSP_CHANNEL_BUFFER_BYTES);
-       } else {
+       else
                return hdsp->playback_buffer + (mapped_channel * HDSP_CHANNEL_BUFFER_BYTES);
-       }
 }
 
-static int snd_hdsp_playback_copy(snd_pcm_substream_t *substream, int channel,
+static int snd_hdsp_playback_copy(struct snd_pcm_substream *substream, int channel,
                                  snd_pcm_uframes_t pos, void __user *src, snd_pcm_uframes_t count)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        char *channel_buf;
 
-       snd_assert(pos + count <= HDSP_CHANNEL_BUFFER_BYTES / 4, return -EINVAL);
+       if (snd_BUG_ON(pos + count > HDSP_CHANNEL_BUFFER_BYTES / 4))
+               return -EINVAL;
 
        channel_buf = hdsp_channel_buffer_location (hdsp, substream->pstr->stream, channel);
-       snd_assert(channel_buf != NULL, return -EIO);
+       if (snd_BUG_ON(!channel_buf))
+               return -EIO;
        if (copy_from_user(channel_buf + pos * 4, src, count * 4))
                return -EFAULT;
        return count;
 }
 
-static int snd_hdsp_capture_copy(snd_pcm_substream_t *substream, int channel,
+static int snd_hdsp_capture_copy(struct snd_pcm_substream *substream, int channel,
                                 snd_pcm_uframes_t pos, void __user *dst, snd_pcm_uframes_t count)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        char *channel_buf;
 
-       snd_assert(pos + count <= HDSP_CHANNEL_BUFFER_BYTES / 4, return -EINVAL);
+       if (snd_BUG_ON(pos + count > HDSP_CHANNEL_BUFFER_BYTES / 4))
+               return -EINVAL;
 
        channel_buf = hdsp_channel_buffer_location (hdsp, substream->pstr->stream, channel);
-       snd_assert(channel_buf != NULL, return -EIO);
+       if (snd_BUG_ON(!channel_buf))
+               return -EIO;
        if (copy_to_user(dst, channel_buf + pos * 4, count * 4))
                return -EFAULT;
        return count;
 }
 
-static int snd_hdsp_hw_silence(snd_pcm_substream_t *substream, int channel,
+static int snd_hdsp_hw_silence(struct snd_pcm_substream *substream, int channel,
                                  snd_pcm_uframes_t pos, snd_pcm_uframes_t count)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        char *channel_buf;
 
        channel_buf = hdsp_channel_buffer_location (hdsp, substream->pstr->stream, channel);
-       snd_assert(channel_buf != NULL, return -EIO);
+       if (snd_BUG_ON(!channel_buf))
+               return -EIO;
        memset(channel_buf + pos * 4, 0, count * 4);
        return count;
 }
 
-static int snd_hdsp_reset(snd_pcm_substream_t *substream)
+static int snd_hdsp_reset(struct snd_pcm_substream *substream)
 {
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
-       snd_pcm_substream_t *other;
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
+       struct snd_pcm_substream *other;
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
                other = hdsp->capture_substream;
        else
@@ -3811,11 +3867,9 @@ static int snd_hdsp_reset(snd_pcm_substream_t *substream)
        else
                runtime->status->hw_ptr = 0;
        if (other) {
-               struct list_head *pos;
-               snd_pcm_substream_t *s;
-               snd_pcm_runtime_t *oruntime = other->runtime;
-               snd_pcm_group_for_each(pos, substream) {
-                       s = snd_pcm_group_substream_entry(pos);
+               struct snd_pcm_substream *s;
+               struct snd_pcm_runtime *oruntime = other->runtime;
+               snd_pcm_group_for_each_entry(s, substream) {
                        if (s == other) {
                                oruntime->status->hw_ptr = runtime->status->hw_ptr;
                                break;
@@ -3825,28 +3879,19 @@ static int snd_hdsp_reset(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_hdsp_hw_params(snd_pcm_substream_t *substream,
-                                snd_pcm_hw_params_t *params)
+static int snd_hdsp_hw_params(struct snd_pcm_substream *substream,
+                                struct snd_pcm_hw_params *params)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        int err;
        pid_t this_pid;
        pid_t other_pid;
 
-       if (hdsp_check_for_iobox (hdsp)) {
+       if (hdsp_check_for_iobox (hdsp))
                return -EIO;
-       }
 
-       if (hdsp_check_for_firmware(hdsp)) {
-               if (hdsp->state & HDSP_FirmwareCached) {
-                       if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_printk("Hammerfall-DSP: Firmware loading from cache failed, please upload manually.\n");
-                       }
-               } else {
-                       snd_printk("Hammerfall-DSP: No firmware loaded nor cached, please upload firmware.\n");
-               }
+       if (hdsp_check_for_firmware(hdsp, 1))
                return -EIO;
-       }
 
        spin_lock_irq(&hdsp->lock);
 
@@ -3909,17 +3954,17 @@ static int snd_hdsp_hw_params(snd_pcm_substream_t *substream,
        return 0;
 }
 
-static int snd_hdsp_channel_info(snd_pcm_substream_t *substream,
-                                   snd_pcm_channel_info_t *info)
+static int snd_hdsp_channel_info(struct snd_pcm_substream *substream,
+                                   struct snd_pcm_channel_info *info)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        int mapped_channel;
 
-       snd_assert(info->channel < hdsp->max_channels, return -EINVAL);
+       if (snd_BUG_ON(info->channel >= hdsp->max_channels))
+               return -EINVAL;
 
-       if ((mapped_channel = hdsp->channel_map[info->channel]) < 0) {
+       if ((mapped_channel = hdsp->channel_map[info->channel]) < 0)
                return -EINVAL;
-       }
 
        info->offset = mapped_channel * HDSP_CHANNEL_BUFFER_BYTES;
        info->first = 0;
@@ -3927,19 +3972,14 @@ static int snd_hdsp_channel_info(snd_pcm_substream_t *substream,
        return 0;
 }
 
-static int snd_hdsp_ioctl(snd_pcm_substream_t *substream,
+static int snd_hdsp_ioctl(struct snd_pcm_substream *substream,
                             unsigned int cmd, void *arg)
 {
        switch (cmd) {
        case SNDRV_PCM_IOCTL1_RESET:
-       {
                return snd_hdsp_reset(substream);
-       }
        case SNDRV_PCM_IOCTL1_CHANNEL_INFO:
-       {
-               snd_pcm_channel_info_t *info = arg;
-               return snd_hdsp_channel_info(substream, info);
-       }
+               return snd_hdsp_channel_info(substream, arg);
        default:
                break;
        }
@@ -3947,26 +3987,17 @@ static int snd_hdsp_ioctl(snd_pcm_substream_t *substream,
        return snd_pcm_lib_ioctl(substream, cmd, arg);
 }
 
-static int snd_hdsp_trigger(snd_pcm_substream_t *substream, int cmd)
+static int snd_hdsp_trigger(struct snd_pcm_substream *substream, int cmd)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
-       snd_pcm_substream_t *other;
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
+       struct snd_pcm_substream *other;
        int running;
-       
-       if (hdsp_check_for_iobox (hdsp)) {
+
+       if (hdsp_check_for_iobox (hdsp))
                return -EIO;
-       }
 
-       if (hdsp_check_for_firmware(hdsp)) {
-               if (hdsp->state & HDSP_FirmwareCached) {
-                       if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_printk("Hammerfall-DSP: Firmware loading from cache failed, please upload manually.\n");
-                       }
-               } else {
-                       snd_printk("Hammerfall-DSP: No firmware loaded nor cached, please upload firmware.\n");
-               }
+       if (hdsp_check_for_firmware(hdsp, 0)) /* no auto-loading in trigger */
                return -EIO;
-       }
 
        spin_lock(&hdsp->lock);
        running = hdsp->running;
@@ -3988,10 +4019,8 @@ static int snd_hdsp_trigger(snd_pcm_substream_t *substream, int cmd)
                other = hdsp->playback_substream;
 
        if (other) {
-               struct list_head *pos;
-               snd_pcm_substream_t *s;
-               snd_pcm_group_for_each(pos, substream) {
-                       s = snd_pcm_group_substream_entry(pos);
+               struct snd_pcm_substream *s;
+               snd_pcm_group_for_each_entry(s, substream) {
                        if (s == other) {
                                snd_pcm_trigger_done(s, substream);
                                if (cmd == SNDRV_PCM_TRIGGER_START)
@@ -4026,25 +4055,16 @@ static int snd_hdsp_trigger(snd_pcm_substream_t *substream, int cmd)
        return 0;
 }
 
-static int snd_hdsp_prepare(snd_pcm_substream_t *substream)
+static int snd_hdsp_prepare(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
        int result = 0;
 
-       if (hdsp_check_for_iobox (hdsp)) {
+       if (hdsp_check_for_iobox (hdsp))
                return -EIO;
-       }
 
-       if (hdsp_check_for_firmware(hdsp)) {
-               if (hdsp->state & HDSP_FirmwareCached) {
-                       if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_printk("Hammerfall-DSP: Firmware loading from cache failed, please upload manually.\n");
-                       }
-               } else {
-                       snd_printk("Hammerfall-DSP: No firmware loaded nor cached, please upload firmware.\n");
-               }
+       if (hdsp_check_for_firmware(hdsp, 1))
                return -EIO;
-       }
 
        spin_lock_irq(&hdsp->lock);
        if (!hdsp->running)
@@ -4053,7 +4073,7 @@ static int snd_hdsp_prepare(snd_pcm_substream_t *substream)
        return result;
 }
 
-static snd_pcm_hardware_t snd_hdsp_playback_subinfo =
+static struct snd_pcm_hardware snd_hdsp_playback_subinfo =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -4066,10 +4086,10 @@ static snd_pcm_hardware_t snd_hdsp_playback_subinfo =
        .formats =              SNDRV_PCM_FMTBIT_S32_LE,
 #endif
        .rates =                (SNDRV_PCM_RATE_32000 |
-                                SNDRV_PCM_RATE_44100 | 
-                                SNDRV_PCM_RATE_48000 | 
-                                SNDRV_PCM_RATE_64000 | 
-                                SNDRV_PCM_RATE_88200 | 
+                                SNDRV_PCM_RATE_44100 |
+                                SNDRV_PCM_RATE_48000 |
+                                SNDRV_PCM_RATE_64000 |
+                                SNDRV_PCM_RATE_88200 |
                                 SNDRV_PCM_RATE_96000),
        .rate_min =             32000,
        .rate_max =             96000,
@@ -4083,7 +4103,7 @@ static snd_pcm_hardware_t snd_hdsp_playback_subinfo =
        .fifo_size =            0
 };
 
-static snd_pcm_hardware_t snd_hdsp_capture_subinfo =
+static struct snd_pcm_hardware snd_hdsp_capture_subinfo =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -4095,10 +4115,10 @@ static snd_pcm_hardware_t snd_hdsp_capture_subinfo =
        .formats =              SNDRV_PCM_FMTBIT_S32_LE,
 #endif
        .rates =                (SNDRV_PCM_RATE_32000 |
-                                SNDRV_PCM_RATE_44100 | 
-                                SNDRV_PCM_RATE_48000 | 
-                                SNDRV_PCM_RATE_64000 | 
-                                SNDRV_PCM_RATE_88200 | 
+                                SNDRV_PCM_RATE_44100 |
+                                SNDRV_PCM_RATE_48000 |
+                                SNDRV_PCM_RATE_64000 |
+                                SNDRV_PCM_RATE_88200 |
                                 SNDRV_PCM_RATE_96000),
        .rate_min =             32000,
        .rate_max =             96000,
@@ -4114,7 +4134,7 @@ static snd_pcm_hardware_t snd_hdsp_capture_subinfo =
 
 static unsigned int hdsp_period_sizes[] = { 64, 128, 256, 512, 1024, 2048, 4096, 8192 };
 
-static snd_pcm_hw_constraint_list_t hdsp_hw_constraints_period_sizes = {
+static struct snd_pcm_hw_constraint_list hdsp_hw_constraints_period_sizes = {
        .count = ARRAY_SIZE(hdsp_period_sizes),
        .list = hdsp_period_sizes,
        .mask = 0
@@ -4122,17 +4142,17 @@ static snd_pcm_hw_constraint_list_t hdsp_hw_constraints_period_sizes = {
 
 static unsigned int hdsp_9632_sample_rates[] = { 32000, 44100, 48000, 64000, 88200, 96000, 128000, 176400, 192000 };
 
-static snd_pcm_hw_constraint_list_t hdsp_hw_constraints_9632_sample_rates = {
+static struct snd_pcm_hw_constraint_list hdsp_hw_constraints_9632_sample_rates = {
        .count = ARRAY_SIZE(hdsp_9632_sample_rates),
        .list = hdsp_9632_sample_rates,
        .mask = 0
 };
 
-static int snd_hdsp_hw_rule_in_channels(snd_pcm_hw_params_t *params,
-                                       snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_in_channels(struct snd_pcm_hw_params *params,
+                                       struct snd_pcm_hw_rule *rule)
 {
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
        if (hdsp->io_type == H9632) {
                unsigned int list[3];
                list[0] = hdsp->qs_in_channels;
@@ -4147,12 +4167,12 @@ static int snd_hdsp_hw_rule_in_channels(snd_pcm_hw_params_t *params,
        }
 }
 
-static int snd_hdsp_hw_rule_out_channels(snd_pcm_hw_params_t *params,
-                                       snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_out_channels(struct snd_pcm_hw_params *params,
+                                       struct snd_pcm_hw_rule *rule)
 {
        unsigned int list[3];
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
        if (hdsp->io_type == H9632) {
                list[0] = hdsp->qs_out_channels;
                list[1] = hdsp->ds_out_channels;
@@ -4165,28 +4185,28 @@ static int snd_hdsp_hw_rule_out_channels(snd_pcm_hw_params_t *params,
        return snd_interval_list(c, 2, list, 0);
 }
 
-static int snd_hdsp_hw_rule_in_channels_rate(snd_pcm_hw_params_t *params,
-                                            snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_in_channels_rate(struct snd_pcm_hw_params *params,
+                                            struct snd_pcm_hw_rule *rule)
 {
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
-       snd_interval_t *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct snd_interval *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
        if (r->min > 96000 && hdsp->io_type == H9632) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->qs_in_channels,
                        .max = hdsp->qs_in_channels,
                        .integer = 1,
                };
-               return snd_interval_refine(c, &t);      
+               return snd_interval_refine(c, &t);
        } else if (r->min > 48000 && r->max <= 96000) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->ds_in_channels,
                        .max = hdsp->ds_in_channels,
                        .integer = 1,
                };
                return snd_interval_refine(c, &t);
        } else if (r->max < 64000) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->ss_in_channels,
                        .max = hdsp->ss_in_channels,
                        .integer = 1,
@@ -4196,28 +4216,28 @@ static int snd_hdsp_hw_rule_in_channels_rate(snd_pcm_hw_params_t *params,
        return 0;
 }
 
-static int snd_hdsp_hw_rule_out_channels_rate(snd_pcm_hw_params_t *params,
-                                            snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_out_channels_rate(struct snd_pcm_hw_params *params,
+                                            struct snd_pcm_hw_rule *rule)
 {
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
-       snd_interval_t *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct snd_interval *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
        if (r->min > 96000 && hdsp->io_type == H9632) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->qs_out_channels,
                        .max = hdsp->qs_out_channels,
                        .integer = 1,
                };
-               return snd_interval_refine(c, &t);      
+               return snd_interval_refine(c, &t);
        } else if (r->min > 48000 && r->max <= 96000) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->ds_out_channels,
                        .max = hdsp->ds_out_channels,
                        .integer = 1,
                };
                return snd_interval_refine(c, &t);
        } else if (r->max < 64000) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = hdsp->ss_out_channels,
                        .max = hdsp->ss_out_channels,
                        .integer = 1,
@@ -4227,28 +4247,28 @@ static int snd_hdsp_hw_rule_out_channels_rate(snd_pcm_hw_params_t *params,
        return 0;
 }
 
-static int snd_hdsp_hw_rule_rate_out_channels(snd_pcm_hw_params_t *params,
-                                            snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_rate_out_channels(struct snd_pcm_hw_params *params,
+                                            struct snd_pcm_hw_rule *rule)
 {
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
-       snd_interval_t *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct snd_interval *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
        if (c->min >= hdsp->ss_out_channels) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 32000,
                        .max = 48000,
                        .integer = 1,
                };
                return snd_interval_refine(r, &t);
        } else if (c->max <= hdsp->qs_out_channels && hdsp->io_type == H9632) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 128000,
                        .max = 192000,
                        .integer = 1,
                };
                return snd_interval_refine(r, &t);
        } else if (c->max <= hdsp->ds_out_channels) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 64000,
                        .max = 96000,
                        .integer = 1,
@@ -4258,28 +4278,28 @@ static int snd_hdsp_hw_rule_rate_out_channels(snd_pcm_hw_params_t *params,
        return 0;
 }
 
-static int snd_hdsp_hw_rule_rate_in_channels(snd_pcm_hw_params_t *params,
-                                            snd_pcm_hw_rule_t *rule)
+static int snd_hdsp_hw_rule_rate_in_channels(struct snd_pcm_hw_params *params,
+                                            struct snd_pcm_hw_rule *rule)
 {
-       hdsp_t *hdsp = rule->private;
-       snd_interval_t *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
-       snd_interval_t *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
+       struct hdsp *hdsp = rule->private;
+       struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
+       struct snd_interval *r = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
        if (c->min >= hdsp->ss_in_channels) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 32000,
                        .max = 48000,
                        .integer = 1,
                };
                return snd_interval_refine(r, &t);
        } else if (c->max <= hdsp->qs_in_channels && hdsp->io_type == H9632) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 128000,
                        .max = 192000,
                        .integer = 1,
                };
                return snd_interval_refine(r, &t);
        } else if (c->max <= hdsp->ds_in_channels) {
-               snd_interval_t t = {
+               struct snd_interval t = {
                        .min = 64000,
                        .max = 96000,
                        .integer = 1,
@@ -4289,25 +4309,16 @@ static int snd_hdsp_hw_rule_rate_in_channels(snd_pcm_hw_params_t *params,
        return 0;
 }
 
-static int snd_hdsp_playback_open(snd_pcm_substream_t *substream)
+static int snd_hdsp_playback_open(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       if (hdsp_check_for_iobox (hdsp)) {
+       if (hdsp_check_for_iobox (hdsp))
                return -EIO;
-       }
 
-       if (hdsp_check_for_firmware(hdsp)) {
-               if (hdsp->state & HDSP_FirmwareCached) {
-                       if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_printk("Hammerfall-DSP: Firmware loading from cache failed, please upload manually.\n");
-                       }
-               } else {
-                       snd_printk("Hammerfall-DSP: No firmware loaded nor cached, please upload firmware.\n");
-               }
+       if (hdsp_check_for_firmware(hdsp, 1))
                return -EIO;
-       }
 
        spin_lock_irq(&hdsp->lock);
 
@@ -4334,8 +4345,8 @@ static int snd_hdsp_playback_open(snd_pcm_substream_t *substream)
        if (hdsp->io_type == H9632) {
                runtime->hw.channels_min = hdsp->qs_out_channels;
                runtime->hw.channels_max = hdsp->ss_out_channels;
-       }       
-       
+       }
+
        snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
                             snd_hdsp_hw_rule_out_channels, hdsp,
                             SNDRV_PCM_HW_PARAM_CHANNELS, -1);
@@ -4353,9 +4364,9 @@ static int snd_hdsp_playback_open(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_hdsp_playback_release(snd_pcm_substream_t *substream)
+static int snd_hdsp_playback_release(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
 
        spin_lock_irq(&hdsp->lock);
 
@@ -4371,25 +4382,16 @@ static int snd_hdsp_playback_release(snd_pcm_substream_t *substream)
 }
 
 
-static int snd_hdsp_capture_open(snd_pcm_substream_t *substream)
+static int snd_hdsp_capture_open(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       if (hdsp_check_for_iobox (hdsp)) {
+       if (hdsp_check_for_iobox (hdsp))
                return -EIO;
-       }
 
-       if (hdsp_check_for_firmware(hdsp)) {
-               if (hdsp->state & HDSP_FirmwareCached) {
-                       if (snd_hdsp_load_firmware_from_cache(hdsp) != 0) {
-                               snd_printk("Hammerfall-DSP: Firmware loading from cache failed, please upload manually.\n");
-                       }
-               } else {
-                       snd_printk("Hammerfall-DSP: No firmware loaded nor cached, please upload firmware.\n");
-               }
+       if (hdsp_check_for_firmware(hdsp, 1))
                return -EIO;
-       }
 
        spin_lock_irq(&hdsp->lock);
 
@@ -4425,9 +4427,9 @@ static int snd_hdsp_capture_open(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_hdsp_capture_release(snd_pcm_substream_t *substream)
+static int snd_hdsp_capture_release(struct snd_pcm_substream *substream)
 {
-       hdsp_t *hdsp = snd_pcm_substream_chip(substream);
+       struct hdsp *hdsp = snd_pcm_substream_chip(substream);
 
        spin_lock_irq(&hdsp->lock);
 
@@ -4438,13 +4440,6 @@ static int snd_hdsp_capture_release(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_hdsp_hwdep_dummy_op(snd_hwdep_t *hw, struct file *file)
-{
-       /* we have nothing to initialize but the call is required */
-       return 0;
-}
-
-
 /* helper functions for copying meter values */
 static inline int copy_u32_le(void __user *dest, void __iomem *src)
 {
@@ -4472,7 +4467,7 @@ static inline int copy_u48_le(void __user *dest, void __iomem *src_low, void __i
        return copy_to_user(dest, &rms, 8);
 }
 
-static int hdsp_9652_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
+static int hdsp_9652_get_peak(struct hdsp *hdsp, struct hdsp_peak_rms __user *peak_rms)
 {
        int doublespeed = 0;
        int i, j, channels, ofs;
@@ -4509,15 +4504,15 @@ static int hdsp_9652_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
        return 0;
 }
 
-static int hdsp_9632_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
+static int hdsp_9632_get_peak(struct hdsp *hdsp, struct hdsp_peak_rms __user *peak_rms)
 {
        int i, j;
-       hdsp_9632_meters_t __iomem *m;
+       struct hdsp_9632_meters __iomem *m;
        int doublespeed = 0;
 
        if (hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DoubleSpeedStatus)
                doublespeed = 1;
-       m = (hdsp_9632_meters_t __iomem *)(hdsp->iobase+HDSP_9632_metersBase);
+       m = (struct hdsp_9632_meters __iomem *)(hdsp->iobase+HDSP_9632_metersBase);
        for (i = 0, j = 0; i < 16; ++i, ++j) {
                if (copy_u32_le(&peak_rms->input_peaks[i], &m->input_peak[j]))
                        return -EFAULT;
@@ -4539,7 +4534,7 @@ static int hdsp_9632_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
        return 0;
 }
 
-static int hdsp_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
+static int hdsp_get_peak(struct hdsp *hdsp, struct hdsp_peak_rms __user *peak_rms)
 {
        int i;
 
@@ -4561,7 +4556,7 @@ static int hdsp_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
                                hdsp->iobase + HDSP_playbackRmsLevel + i * 8 + 4,
                                hdsp->iobase + HDSP_playbackRmsLevel + i * 8))
                        return -EFAULT;
-               if (copy_u64_le(&peak_rms->input_rms[i], 
+               if (copy_u64_le(&peak_rms->input_rms[i],
                                hdsp->iobase + HDSP_inputRmsLevel + i * 8 + 4,
                                hdsp->iobase + HDSP_inputRmsLevel + i * 8))
                        return -EFAULT;
@@ -4569,14 +4564,23 @@ static int hdsp_get_peak(hdsp_t *hdsp, hdsp_peak_rms_t __user *peak_rms)
        return 0;
 }
 
-static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int cmd, unsigned long arg)
+static int snd_hdsp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, unsigned int cmd, unsigned long arg)
 {
-       hdsp_t *hdsp = (hdsp_t *)hw->private_data;      
+       struct hdsp *hdsp = (struct hdsp *)hw->private_data;
        void __user *argp = (void __user *)arg;
+       int err;
 
        switch (cmd) {
        case SNDRV_HDSP_IOCTL_GET_PEAK_RMS: {
-               hdsp_peak_rms_t __user *peak_rms = (hdsp_peak_rms_t __user *)arg;
+               struct hdsp_peak_rms __user *peak_rms = (struct hdsp_peak_rms __user *)arg;
+
+               err = hdsp_check_for_iobox(hdsp);
+               if (err < 0)
+                       return err;
+
+               err = hdsp_check_for_firmware(hdsp, 1);
+               if (err < 0)
+                       return err;
 
                if (!(hdsp->state & HDSP_FirmwareLoaded)) {
                        snd_printk(KERN_ERR "Hammerfall-DSP: firmware needs to be uploaded to the card.\n");
@@ -4593,24 +4597,26 @@ static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int
                }
        }
        case SNDRV_HDSP_IOCTL_GET_CONFIG_INFO: {
-               hdsp_config_info_t info;
+               struct hdsp_config_info info;
                unsigned long flags;
                int i;
-               
-               if (!(hdsp->state & HDSP_FirmwareLoaded)) {
-                       snd_printk("Hammerfall-DSP: Firmware needs to be uploaded to the card.\n");     
-                       return -EINVAL;
-               }
+
+               err = hdsp_check_for_iobox(hdsp);
+               if (err < 0)
+                       return err;
+
+               err = hdsp_check_for_firmware(hdsp, 1);
+               if (err < 0)
+                       return err;
+
                spin_lock_irqsave(&hdsp->lock, flags);
                info.pref_sync_ref = (unsigned char)hdsp_pref_sync_ref(hdsp);
                info.wordclock_sync_check = (unsigned char)hdsp_wc_sync_check(hdsp);
-               if (hdsp->io_type != H9632) {
+               if (hdsp->io_type != H9632)
                    info.adatsync_sync_check = (unsigned char)hdsp_adatsync_sync_check(hdsp);
-               }
                info.spdif_sync_check = (unsigned char)hdsp_spdif_sync_check(hdsp);
-               for (i = 0; i < ((hdsp->io_type != Multiface && hdsp->io_type != H9632) ? 3 : 1); ++i) {
+               for (i = 0; i < ((hdsp->io_type != Multiface && hdsp->io_type != H9632) ? 3 : 1); ++i)
                        info.adat_sync_check[i] = (unsigned char)hdsp_adat_sync_check(hdsp, i);
-               }
                info.spdif_in = (unsigned char)hdsp_spdif_in(hdsp);
                info.spdif_out = (unsigned char)hdsp_spdif_out(hdsp);
                info.spdif_professional = (unsigned char)hdsp_spdif_professional(hdsp);
@@ -4628,19 +4634,18 @@ static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int
                        info.ad_gain = (unsigned char)hdsp_ad_gain(hdsp);
                        info.phone_gain = (unsigned char)hdsp_phone_gain(hdsp);
                        info.xlr_breakout_cable = (unsigned char)hdsp_xlr_breakout_cable(hdsp);
-               
+
                }
-               if (hdsp->io_type == H9632 || hdsp->io_type == H9652) {
+               if (hdsp->io_type == H9632 || hdsp->io_type == H9652)
                        info.analog_extension_board = (unsigned char)hdsp_aeb(hdsp);
-               }
                spin_unlock_irqrestore(&hdsp->lock, flags);
                if (copy_to_user(argp, &info, sizeof(info)))
                        return -EFAULT;
                break;
        }
        case SNDRV_HDSP_IOCTL_GET_9632_AEB: {
-               hdsp_9632_aeb_t h9632_aeb;
-               
+               struct hdsp_9632_aeb h9632_aeb;
+
                if (hdsp->io_type != H9632) return -EINVAL;
                h9632_aeb.aebi = hdsp->ss_in_channels - H9632_SS_CHANNELS;
                h9632_aeb.aebo = hdsp->ss_out_channels - H9632_SS_CHANNELS;
@@ -4649,27 +4654,25 @@ static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int
                break;
        }
        case SNDRV_HDSP_IOCTL_GET_VERSION: {
-               hdsp_version_t hdsp_version;
+               struct hdsp_version hdsp_version;
                int err;
-               
+
                if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return -EINVAL;
                if (hdsp->io_type == Undefined) {
-                       if ((err = hdsp_get_iobox_version(hdsp)) < 0) {
+                       if ((err = hdsp_get_iobox_version(hdsp)) < 0)
                                return err;
-                       }
                }
                hdsp_version.io_type = hdsp->io_type;
                hdsp_version.firmware_rev = hdsp->firmware_rev;
-               if ((err = copy_to_user(argp, &hdsp_version, sizeof(hdsp_version)))) {
+               if ((err = copy_to_user(argp, &hdsp_version, sizeof(hdsp_version))))
                        return -EFAULT;
-               }
                break;
        }
        case SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE: {
-               hdsp_firmware_t __user *firmware;
+               struct hdsp_firmware __user *firmware;
                u32 __user *firmware_data;
                int err;
-               
+
                if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return -EINVAL;
                /* SNDRV_HDSP_IOCTL_GET_VERSION must have been called */
                if (hdsp->io_type == Undefined) return -EINVAL;
@@ -4677,44 +4680,39 @@ static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int
                if (hdsp->state & (HDSP_FirmwareCached | HDSP_FirmwareLoaded))
                        return -EBUSY;
 
-               snd_printk("Hammerfall-DSP: initializing firmware upload\n");
-               firmware = (hdsp_firmware_t __user *)argp;
+               snd_printk(KERN_INFO "Hammerfall-DSP: initializing firmware upload\n");
+               firmware = (struct hdsp_firmware __user *)argp;
 
-               if (get_user(firmware_data, &firmware->firmware_data)) {
+               if (get_user(firmware_data, &firmware->firmware_data))
                        return -EFAULT;
-               }
-               
-               if (hdsp_check_for_iobox (hdsp)) {
+
+               if (hdsp_check_for_iobox (hdsp))
                        return -EIO;
-               }
 
-               if (copy_from_user(hdsp->firmware_cache, firmware_data, sizeof(hdsp->firmware_cache)) != 0) {
+               if (copy_from_user(hdsp->firmware_cache, firmware_data, sizeof(hdsp->firmware_cache)) != 0)
                        return -EFAULT;
-               }
-               
+
                hdsp->state |= HDSP_FirmwareCached;
 
-               if ((err = snd_hdsp_load_firmware_from_cache(hdsp)) < 0) {
+               if ((err = snd_hdsp_load_firmware_from_cache(hdsp)) < 0)
                        return err;
-               }
-               
+
                if (!(hdsp->state & HDSP_InitializationComplete)) {
-                       if ((err = snd_hdsp_enable_io(hdsp)) < 0) {
+                       if ((err = snd_hdsp_enable_io(hdsp)) < 0)
                                return err;
-                       }
-                       
-                       snd_hdsp_initialize_channels(hdsp);             
+
+                       snd_hdsp_initialize_channels(hdsp);
                        snd_hdsp_initialize_midi_flush(hdsp);
-           
+
                        if ((err = snd_hdsp_create_alsa_devices(hdsp->card, hdsp)) < 0) {
-                               snd_printk("Hammerfall-DSP: error creating alsa devices\n");
-                           return err;
+                               snd_printk(KERN_ERR "Hammerfall-DSP: error creating alsa devices\n");
+                               return err;
                        }
                }
                break;
        }
        case SNDRV_HDSP_IOCTL_GET_MIXER: {
-               hdsp_mixer_t __user *mixer = (hdsp_mixer_t __user *)argp;
+               struct hdsp_mixer __user *mixer = (struct hdsp_mixer __user *)argp;
                if (copy_to_user(mixer->matrix, hdsp->mixer_matrix, sizeof(unsigned short)*HDSP_MATRIX_MIXER_SIZE))
                        return -EFAULT;
                break;
@@ -4725,7 +4723,7 @@ static int snd_hdsp_hwdep_ioctl(snd_hwdep_t *hw, struct file *file, unsigned int
        return 0;
 }
 
-static snd_pcm_ops_t snd_hdsp_playback_ops = {
+static struct snd_pcm_ops snd_hdsp_playback_ops = {
        .open =         snd_hdsp_playback_open,
        .close =        snd_hdsp_playback_release,
        .ioctl =        snd_hdsp_ioctl,
@@ -4737,7 +4735,7 @@ static snd_pcm_ops_t snd_hdsp_playback_ops = {
        .silence =      snd_hdsp_hw_silence,
 };
 
-static snd_pcm_ops_t snd_hdsp_capture_ops = {
+static struct snd_pcm_ops snd_hdsp_capture_ops = {
        .open =         snd_hdsp_capture_open,
        .close =        snd_hdsp_capture_release,
        .ioctl =        snd_hdsp_ioctl,
@@ -4748,29 +4746,26 @@ static snd_pcm_ops_t snd_hdsp_capture_ops = {
        .copy =         snd_hdsp_capture_copy,
 };
 
-static int __devinit snd_hdsp_create_hwdep(snd_card_t *card,
-                                          hdsp_t *hdsp)
+static int snd_hdsp_create_hwdep(struct snd_card *card, struct hdsp *hdsp)
 {
-       snd_hwdep_t *hw;
+       struct snd_hwdep *hw;
        int err;
-       
+
        if ((err = snd_hwdep_new(card, "HDSP hwdep", 0, &hw)) < 0)
                return err;
-               
+
        hdsp->hwdep = hw;
        hw->private_data = hdsp;
        strcpy(hw->name, "HDSP hwdep interface");
 
-       hw->ops.open = snd_hdsp_hwdep_dummy_op;
        hw->ops.ioctl = snd_hdsp_hwdep_ioctl;
-       hw->ops.release = snd_hdsp_hwdep_dummy_op;
-               
+
        return 0;
 }
 
-static int snd_hdsp_create_pcm(snd_card_t *card, hdsp_t *hdsp)
+static int snd_hdsp_create_pcm(struct snd_card *card, struct hdsp *hdsp)
 {
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int err;
 
        if ((err = snd_pcm_new(card, hdsp->card_name, 0, 1, 1, &pcm)) < 0)
@@ -4788,33 +4783,33 @@ static int snd_hdsp_create_pcm(snd_card_t *card, hdsp_t *hdsp)
        return 0;
 }
 
-static void snd_hdsp_9652_enable_mixer (hdsp_t *hdsp)
+static void snd_hdsp_9652_enable_mixer (struct hdsp *hdsp)
 {
         hdsp->control2_register |= HDSP_9652_ENABLE_MIXER;
        hdsp_write (hdsp, HDSP_control2Reg, hdsp->control2_register);
 }
 
-static int snd_hdsp_enable_io (hdsp_t *hdsp)
+static int snd_hdsp_enable_io (struct hdsp *hdsp)
 {
        int i;
-       
+
        if (hdsp_fifo_wait (hdsp, 0, 100)) {
-               snd_printk("Hammerfall-DSP: enable_io fifo_wait failed\n");
+               snd_printk(KERN_ERR "Hammerfall-DSP: enable_io fifo_wait failed\n");
                return -EIO;
        }
-       
+
        for (i = 0; i < hdsp->max_channels; ++i) {
                hdsp_write (hdsp, HDSP_inputEnable + (4 * i), 1);
                hdsp_write (hdsp, HDSP_outputEnable + (4 * i), 1);
        }
-       
+
        return 0;
 }
 
-static void snd_hdsp_initialize_channels(hdsp_t *hdsp)
+static void snd_hdsp_initialize_channels(struct hdsp *hdsp)
 {
        int status, aebi_channels, aebo_channels;
-       
+
        switch (hdsp->io_type) {
        case Digiface:
                hdsp->card_name = "RME Hammerfall DSP + Digiface";
@@ -4827,7 +4822,7 @@ static void snd_hdsp_initialize_channels(hdsp_t *hdsp)
                hdsp->ss_in_channels = hdsp->ss_out_channels = H9652_SS_CHANNELS;
                hdsp->ds_in_channels = hdsp->ds_out_channels = H9652_DS_CHANNELS;
                break;
-       
+
        case H9632:
                status = hdsp_read(hdsp, HDSP_statusRegister);
                /* HDSP_AEBx bits are low when AEB are connected */
@@ -4847,43 +4842,43 @@ static void snd_hdsp_initialize_channels(hdsp_t *hdsp)
                hdsp->ss_in_channels = hdsp->ss_out_channels = MULTIFACE_SS_CHANNELS;
                hdsp->ds_in_channels = hdsp->ds_out_channels = MULTIFACE_DS_CHANNELS;
                break;
-               
+
        default:
                /* should never get here */
                break;
        }
 }
 
-static void snd_hdsp_initialize_midi_flush (hdsp_t *hdsp)
+static void snd_hdsp_initialize_midi_flush (struct hdsp *hdsp)
 {
        snd_hdsp_flush_midi_input (hdsp, 0);
        snd_hdsp_flush_midi_input (hdsp, 1);
 }
 
-static int snd_hdsp_create_alsa_devices(snd_card_t *card, hdsp_t *hdsp)
+static int snd_hdsp_create_alsa_devices(struct snd_card *card, struct hdsp *hdsp)
 {
        int err;
-       
+
        if ((err = snd_hdsp_create_pcm(card, hdsp)) < 0) {
-               snd_printk("Hammerfall-DSP: Error creating pcm interface\n");
+               snd_printk(KERN_ERR "Hammerfall-DSP: Error creating pcm interface\n");
                return err;
        }
-       
+
 
        if ((err = snd_hdsp_create_midi(card, hdsp, 0)) < 0) {
-               snd_printk("Hammerfall-DSP: Error creating first midi interface\n");
+               snd_printk(KERN_ERR "Hammerfall-DSP: Error creating first midi interface\n");
                return err;
        }
 
        if (hdsp->io_type == Digiface || hdsp->io_type == H9652) {
                if ((err = snd_hdsp_create_midi(card, hdsp, 1)) < 0) {
-                       snd_printk("Hammerfall-DSP: Error creating second midi interface\n");
+                       snd_printk(KERN_ERR "Hammerfall-DSP: Error creating second midi interface\n");
                        return err;
                }
        }
 
        if ((err = snd_hdsp_create_controls(card, hdsp)) < 0) {
-               snd_printk("Hammerfall-DSP: Error creating ctl interface\n");
+               snd_printk(KERN_ERR "Hammerfall-DSP: Error creating ctl interface\n");
                return err;
        }
 
@@ -4896,32 +4891,33 @@ static int snd_hdsp_create_alsa_devices(snd_card_t *card, hdsp_t *hdsp)
        hdsp->playback_substream = NULL;
 
        if ((err = snd_hdsp_set_defaults(hdsp)) < 0) {
-               snd_printk("Hammerfall-DSP: Error setting default values\n");
+               snd_printk(KERN_ERR "Hammerfall-DSP: Error setting default values\n");
                return err;
        }
-       
+
        if (!(hdsp->state & HDSP_InitializationComplete)) {
-               sprintf(card->longname, "%s at 0x%lx, irq %d", hdsp->card_name, 
+               strcpy(card->shortname, "Hammerfall DSP");
+               sprintf(card->longname, "%s at 0x%lx, irq %d", hdsp->card_name,
                        hdsp->port, hdsp->irq);
-           
+
                if ((err = snd_card_register(card)) < 0) {
-                       snd_printk("Hammerfall-DSP: error registering card\n");
+                       snd_printk(KERN_ERR "Hammerfall-DSP: error registering card\n");
                        return err;
                }
                hdsp->state |= HDSP_InitializationComplete;
        }
-       
+
        return 0;
 }
 
 #ifdef HDSP_FW_LOADER
 /* load firmware via hotplug fw loader */
-static int __devinit hdsp_request_fw_loader(hdsp_t *hdsp)
+static int hdsp_request_fw_loader(struct hdsp *hdsp)
 {
        const char *fwfile;
        const struct firmware *fw;
        int err;
-               
+
        if (hdsp->io_type == H9652 || hdsp->io_type == H9632)
                return 0;
        if (hdsp->io_type == Undefined) {
@@ -4930,7 +4926,7 @@ static int __devinit hdsp_request_fw_loader(hdsp_t *hdsp)
                if (hdsp->io_type == H9652 || hdsp->io_type == H9632)
                        return 0;
        }
-       
+
        /* caution: max length of firmware filename is 30! */
        switch (hdsp->io_type) {
        case Multiface:
@@ -4964,25 +4960,24 @@ static int __devinit hdsp_request_fw_loader(hdsp_t *hdsp)
        memcpy(hdsp->firmware_cache, fw->data, sizeof(hdsp->firmware_cache));
 
        release_firmware(fw);
-               
+
        hdsp->state |= HDSP_FirmwareCached;
 
        if ((err = snd_hdsp_load_firmware_from_cache(hdsp)) < 0)
                return err;
-               
+
        if (!(hdsp->state & HDSP_InitializationComplete)) {
-               if ((err = snd_hdsp_enable_io(hdsp)) < 0) {
+               if ((err = snd_hdsp_enable_io(hdsp)) < 0)
                        return err;
-               }
 
                if ((err = snd_hdsp_create_hwdep(hdsp->card, hdsp)) < 0) {
-                       snd_printk("Hammerfall-DSP: error creating hwdep device\n");
+                       snd_printk(KERN_ERR "Hammerfall-DSP: error creating hwdep device\n");
                        return err;
                }
                snd_hdsp_initialize_channels(hdsp);
                snd_hdsp_initialize_midi_flush(hdsp);
                if ((err = snd_hdsp_create_alsa_devices(hdsp->card, hdsp)) < 0) {
-                       snd_printk("Hammerfall-DSP: error creating alsa devices\n");
+                       snd_printk(KERN_ERR "Hammerfall-DSP: error creating alsa devices\n");
                        return err;
                }
        }
@@ -4990,8 +4985,8 @@ static int __devinit hdsp_request_fw_loader(hdsp_t *hdsp)
 }
 #endif
 
-static int __devinit snd_hdsp_create(snd_card_t *card,
-                                    hdsp_t *hdsp)
+static int __devinit snd_hdsp_create(struct snd_card *card,
+                                    struct hdsp *hdsp)
 {
        struct pci_dev *pci = hdsp->pci;
        int err;
@@ -5017,14 +5012,14 @@ static int __devinit snd_hdsp_create(snd_card_t *card,
        hdsp->max_channels = 26;
 
        hdsp->card = card;
-       
+
        spin_lock_init(&hdsp->lock);
 
        tasklet_init(&hdsp->midi_tasklet, hdsp_midi_tasklet, (unsigned long)hdsp);
-       
+
        pci_read_config_word(hdsp->pci, PCI_CLASS_REVISION, &hdsp->firmware_rev);
        hdsp->firmware_rev &= 0xff;
-       
+
        /* From Martin Bjoernsen :
            "It is important that the card's latency timer register in
            the PCI configuration space is set to a value much larger
@@ -5033,26 +5028,25 @@ static int __devinit snd_hdsp_create(snd_card_t *card,
            to its maximum 255 to avoid problems with some computers."
        */
        pci_write_config_byte(hdsp->pci, PCI_LATENCY_TIMER, 0xFF);
-       
+
        strcpy(card->driver, "H-DSP");
        strcpy(card->mixername, "Xilinx FPGA");
 
-       if (hdsp->firmware_rev < 0xa) {
+       if (hdsp->firmware_rev < 0xa)
                return -ENODEV;
-       } else if (hdsp->firmware_rev < 0x64) {
+       else if (hdsp->firmware_rev < 0x64)
                hdsp->card_name = "RME Hammerfall DSP";
-       else if (hdsp->firmware_rev < 0x96) {
+       else if (hdsp->firmware_rev < 0x96) {
                hdsp->card_name = "RME HDSP 9652";
                is_9652 = 1;
        } else {
                hdsp->card_name = "RME HDSP 9632";
                hdsp->max_channels = 16;
-               is_9632 = 1;    
+               is_9632 = 1;
        }
 
-       if ((err = pci_enable_device(pci)) < 0) {
+       if ((err = pci_enable_device(pci)) < 0)
                return err;
-       }
 
        pci_set_master(hdsp->pci);
 
@@ -5060,90 +5054,82 @@ static int __devinit snd_hdsp_create(snd_card_t *card,
                return err;
        hdsp->port = pci_resource_start(pci, 0);
        if ((hdsp->iobase = ioremap_nocache(hdsp->port, HDSP_IO_EXTENT)) == NULL) {
-               snd_printk("Hammerfall-DSP: unable to remap region 0x%lx-0x%lx\n", hdsp->port, hdsp->port + HDSP_IO_EXTENT - 1);
+               snd_printk(KERN_ERR "Hammerfall-DSP: unable to remap region 0x%lx-0x%lx\n", hdsp->port, hdsp->port + HDSP_IO_EXTENT - 1);
                return -EBUSY;
        }
 
-       if (request_irq(pci->irq, snd_hdsp_interrupt, SA_INTERRUPT|SA_SHIRQ, "hdsp", (void *)hdsp)) {
-               snd_printk("Hammerfall-DSP: unable to use IRQ %d\n", pci->irq);
+       if (request_irq(pci->irq, snd_hdsp_interrupt, IRQF_SHARED,
+                       "hdsp", hdsp)) {
+               snd_printk(KERN_ERR "Hammerfall-DSP: unable to use IRQ %d\n", pci->irq);
                return -EBUSY;
        }
 
        hdsp->irq = pci->irq;
-       hdsp->precise_ptr = 1;
+       hdsp->precise_ptr = 0;
        hdsp->use_midi_tasklet = 1;
+       hdsp->dds_value = 0;
 
-       if ((err = snd_hdsp_initialize_memory(hdsp)) < 0) {
+       if ((err = snd_hdsp_initialize_memory(hdsp)) < 0)
                return err;
-       }
-       
+
        if (!is_9652 && !is_9632) {
-               /* we wait 2 seconds to let freshly inserted cardbus cards do their hardware init */
-               if ((1000 / HZ) < 2000) {
-                       set_current_state(TASK_UNINTERRUPTIBLE);
-                       schedule_timeout((2000 * HZ + 999) / 1000);
-               } else {
-                       mdelay(2000);
-               }
+               /* we wait a maximum of 10 seconds to let freshly
+                * inserted cardbus cards do their hardware init */
+               err = hdsp_wait_for_iobox(hdsp, 1000, 10);
+
+               if (err < 0)
+                       return err;
 
                if ((hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DllError) != 0) {
 #ifdef HDSP_FW_LOADER
-                       if ((err = hdsp_request_fw_loader(hdsp)) < 0) {
+                       if ((err = hdsp_request_fw_loader(hdsp)) < 0)
                                /* we don't fail as this can happen
                                   if userspace is not ready for
                                   firmware upload
                                */
-                               snd_printk("Hammerfall-DSP: couldn't get firmware from userspace. try using hdsploader\n");
-                       } else {
+                               snd_printk(KERN_ERR "Hammerfall-DSP: couldn't get firmware from userspace. try using hdsploader\n");
+                       else
                                /* init is complete, we return */
                                return 0;
-                       }
 #endif
-                       /* no iobox connected, we defer initialization */
-                       snd_printk("Hammerfall-DSP: card initialization pending : waiting for firmware\n");
-                       if ((err = snd_hdsp_create_hwdep(card, hdsp)) < 0) {
+                       /* we defer initialization */
+                       snd_printk(KERN_INFO "Hammerfall-DSP: card initialization pending : waiting for firmware\n");
+                       if ((err = snd_hdsp_create_hwdep(card, hdsp)) < 0)
                                return err;
-                       }
                        return 0;
                } else {
-                       snd_printk("Hammerfall-DSP: Firmware already present, initializing card.\n");       
-                       if (hdsp_read(hdsp, HDSP_status2Register) & HDSP_version1) {
+                       snd_printk(KERN_INFO "Hammerfall-DSP: Firmware already present, initializing card.\n");
+                       if (hdsp_read(hdsp, HDSP_status2Register) & HDSP_version1)
                                hdsp->io_type = Multiface;
-                       } else {
+                       else
                                hdsp->io_type = Digiface;
-                       }
                }
        }
-       
-       if ((err = snd_hdsp_enable_io(hdsp)) != 0) {
+
+       if ((err = snd_hdsp_enable_io(hdsp)) != 0)
                return err;
-       }
-       
-       if (is_9652) {
+
+       if (is_9652)
                hdsp->io_type = H9652;
-       }
-       
-       if (is_9632) {
+
+       if (is_9632)
                hdsp->io_type = H9632;
-       }
 
-       if ((err = snd_hdsp_create_hwdep(card, hdsp)) < 0) {
+       if ((err = snd_hdsp_create_hwdep(card, hdsp)) < 0)
                return err;
-       }
-       
+
        snd_hdsp_initialize_channels(hdsp);
        snd_hdsp_initialize_midi_flush(hdsp);
 
-       hdsp->state |= HDSP_FirmwareLoaded;     
+       hdsp->state |= HDSP_FirmwareLoaded;
 
-       if ((err = snd_hdsp_create_alsa_devices(card, hdsp)) < 0) {
+       if ((err = snd_hdsp_create_alsa_devices(card, hdsp)) < 0)
                return err;
-       }
 
-       return 0;       
+       return 0;
 }
 
-static int snd_hdsp_free(hdsp_t *hdsp)
+static int snd_hdsp_free(struct hdsp *hdsp)
 {
        if (hdsp->port) {
                /* stop the audio, and cancel all interrupts */
@@ -5156,20 +5142,20 @@ static int snd_hdsp_free(hdsp_t *hdsp)
                free_irq(hdsp->irq, (void *)hdsp);
 
        snd_hdsp_free_buffers(hdsp);
-       
+
        if (hdsp->iobase)
                iounmap(hdsp->iobase);
 
        if (hdsp->port)
                pci_release_regions(hdsp->pci);
-               
+
        pci_disable_device(hdsp->pci);
        return 0;
 }
 
-static void snd_hdsp_card_free(snd_card_t *card)
+static void snd_hdsp_card_free(struct snd_card *card)
 {
-       hdsp_t *hdsp = (hdsp_t *) card->private_data;
+       struct hdsp *hdsp = (struct hdsp *) card->private_data;
 
        if (hdsp)
                snd_hdsp_free(hdsp);
@@ -5179,8 +5165,8 @@ static int __devinit snd_hdsp_probe(struct pci_dev *pci,
                                    const struct pci_device_id *pci_id)
 {
        static int dev;
-       hdsp_t *hdsp;
-       snd_card_t *card;
+       struct hdsp *hdsp;
+       struct snd_card *card;
        int err;
 
        if (dev >= SNDRV_CARDS)
@@ -5190,10 +5176,12 @@ static int __devinit snd_hdsp_probe(struct pci_dev *pci,
                return -ENOENT;
        }
 
-       if (!(card = snd_card_new(index[dev], id[dev], THIS_MODULE, sizeof(hdsp_t))))
-               return -ENOMEM;
+       err = snd_card_create(index[dev], id[dev], THIS_MODULE,
+                             sizeof(struct hdsp), &card);
+       if (err < 0)
+               return err;
 
-       hdsp = (hdsp_t *) card->private_data;
+       hdsp = (struct hdsp *) card->private_data;
        card->private_free = snd_hdsp_card_free;
        hdsp->dev = dev;
        hdsp->pci = pci;
@@ -5205,7 +5193,7 @@ static int __devinit snd_hdsp_probe(struct pci_dev *pci,
        }
 
        strcpy(card->shortname, "Hammerfall DSP");
-       sprintf(card->longname, "%s at 0x%lx, irq %d", hdsp->card_name, 
+       sprintf(card->longname, "%s at 0x%lx, irq %d", hdsp->card_name,
                hdsp->port, hdsp->irq);
 
        if ((err = snd_card_register(card)) < 0) {