Merge branch 'topic/ice' into for-linus
[safe/jmp/linux-2.6] / sound / pci / ice1712 / ice1724.c
index 32560cf..128510e 100644 (file)
@@ -2,7 +2,7 @@
  *   ALSA driver for VT1724 ICEnsemble ICE1724 / VIA VT1724 (Envy24HT)
  *                   VIA VT1720 (Envy24PT)
  *
- *     Copyright (c) 2000 Jaroslav Kysela <perex@suse.cz>
+ *     Copyright (c) 2000 Jaroslav Kysela <perex@perex.cz>
  *                    2002 James Stafford <jstafford@ampltd.com>
  *                    2003 Takashi Iwai <tiwai@suse.de>
  *
  *   along with this program; if not, write to the Free Software
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
  *
- */      
+ */
 
-#include <sound/driver.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/init.h>
@@ -33,7 +32,7 @@
 #include <linux/mutex.h>
 #include <sound/core.h>
 #include <sound/info.h>
-#include <sound/mpu401.h>
+#include <sound/rawmidi.h>
 #include <sound/initval.h>
 
 #include <sound/asoundef.h>
 #include "vt1720_mobo.h"
 #include "pontis.h"
 #include "prodigy192.h"
+#include "prodigy_hifi.h"
 #include "juli.h"
 #include "phase.h"
 #include "wtm.h"
+#include "se.h"
 
-MODULE_AUTHOR("Jaroslav Kysela <perex@suse.cz>");
+MODULE_AUTHOR("Jaroslav Kysela <perex@perex.cz>");
 MODULE_DESCRIPTION("VIA ICEnsemble ICE1724/1720 (Envy24HT/PT)");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{"
@@ -62,9 +63,11 @@ MODULE_SUPPORTED_DEVICE("{"
               VT1720_MOBO_DEVICE_DESC
               PONTIS_DEVICE_DESC
               PRODIGY192_DEVICE_DESC
+              PRODIGY_HIFI_DEVICE_DESC
               JULI_DEVICE_DESC
               PHASE_DEVICE_DESC
               WTM_DEVICE_DESC
+              SE_DEVICE_DESC
                "{VIA,VT1720},"
                "{VIA,VT1724},"
                "{ICEnsemble,Generic ICE1724},"
@@ -102,16 +105,20 @@ static unsigned int PRO_RATE_DEFAULT = 44100;
 /*
  *  Basic I/O
  */
+
+/*
+ *  default rates, default clock routines
+ */
+
 /* check whether the clock mode is spdif-in */
-static inline int is_spdif_master(struct snd_ice1712 *ice)
+static inline int stdclock_is_spdif_master(struct snd_ice1712 *ice)
 {
        return (inb(ICEMT1724(ice, RATE)) & VT1724_SPDIF_MASTER) ? 1 : 0;
 }
 
 static inline int is_pro_rate_locked(struct snd_ice1712 *ice)
 {
-       return is_spdif_master(ice) || PRO_RATE_LOCKED;
+       return ice->is_spdif_master(ice) || PRO_RATE_LOCKED;
 }
 
 /*
@@ -191,7 +198,7 @@ static void snd_vt1724_set_gpio_dir(struct snd_ice1712 *ice, unsigned int data)
 static void snd_vt1724_set_gpio_mask(struct snd_ice1712 *ice, unsigned int data)
 {
        outw(data, ICEREG1724(ice, GPIO_WRITE_MASK));
-       if (! ice->vt1720) /* VT1720 supports only 16 GPIO bits */
+       if (!ice->vt1720) /* VT1720 supports only 16 GPIO bits */
                outb((data >> 16) & 0xff, ICEREG1724(ice, GPIO_WRITE_MASK_22));
        inw(ICEREG1724(ice, GPIO_WRITE_MASK)); /* dummy read for pci-posting */
 }
@@ -199,7 +206,7 @@ static void snd_vt1724_set_gpio_mask(struct snd_ice1712 *ice, unsigned int data)
 static void snd_vt1724_set_gpio_data(struct snd_ice1712 *ice, unsigned int data)
 {
        outw(data, ICEREG1724(ice, GPIO_DATA));
-       if (! ice->vt1720)
+       if (!ice->vt1720)
                outb(data >> 16, ICEREG1724(ice, GPIO_DATA_22));
        inw(ICEREG1724(ice, GPIO_DATA)); /* dummy read for pci-posting */
 }
@@ -207,7 +214,7 @@ static void snd_vt1724_set_gpio_data(struct snd_ice1712 *ice, unsigned int data)
 static unsigned int snd_vt1724_get_gpio_data(struct snd_ice1712 *ice)
 {
        unsigned int data;
-       if (! ice->vt1720)
+       if (!ice->vt1720)
                data = (unsigned int)inb(ICEREG1724(ice, GPIO_DATA_22));
        else
                data = 0;
@@ -216,6 +223,167 @@ static unsigned int snd_vt1724_get_gpio_data(struct snd_ice1712 *ice)
 }
 
 /*
+ * MIDI
+ */
+
+static void vt1724_midi_clear_rx(struct snd_ice1712 *ice)
+{
+       unsigned int count;
+
+       for (count = inb(ICEREG1724(ice, MPU_RXFIFO)); count > 0; --count)
+               inb(ICEREG1724(ice, MPU_DATA));
+}
+
+static inline struct snd_rawmidi_substream *
+get_rawmidi_substream(struct snd_ice1712 *ice, unsigned int stream)
+{
+       return list_first_entry(&ice->rmidi[0]->streams[stream].substreams,
+                               struct snd_rawmidi_substream, list);
+}
+
+static void enable_midi_irq(struct snd_ice1712 *ice, u8 flag, int enable);
+
+static void vt1724_midi_write(struct snd_ice1712 *ice)
+{
+       struct snd_rawmidi_substream *s;
+       int count, i;
+       u8 buffer[32];
+
+       s = get_rawmidi_substream(ice, SNDRV_RAWMIDI_STREAM_OUTPUT);
+       count = 31 - inb(ICEREG1724(ice, MPU_TXFIFO));
+       if (count > 0) {
+               count = snd_rawmidi_transmit(s, buffer, count);
+               for (i = 0; i < count; ++i)
+                       outb(buffer[i], ICEREG1724(ice, MPU_DATA));
+       }
+       /* mask irq when all bytes have been transmitted.
+        * enabled again in output_trigger when the new data comes in.
+        */
+       enable_midi_irq(ice, VT1724_IRQ_MPU_TX,
+                       !snd_rawmidi_transmit_empty(s));
+}
+
+static void vt1724_midi_read(struct snd_ice1712 *ice)
+{
+       struct snd_rawmidi_substream *s;
+       int count, i;
+       u8 buffer[32];
+
+       s = get_rawmidi_substream(ice, SNDRV_RAWMIDI_STREAM_INPUT);
+       count = inb(ICEREG1724(ice, MPU_RXFIFO));
+       if (count > 0) {
+               count = min(count, 32);
+               for (i = 0; i < count; ++i)
+                       buffer[i] = inb(ICEREG1724(ice, MPU_DATA));
+               snd_rawmidi_receive(s, buffer, count);
+       }
+}
+
+/* call with ice->reg_lock */
+static void enable_midi_irq(struct snd_ice1712 *ice, u8 flag, int enable)
+{
+       u8 mask = inb(ICEREG1724(ice, IRQMASK));
+       if (enable)
+               mask &= ~flag;
+       else
+               mask |= flag;
+       outb(mask, ICEREG1724(ice, IRQMASK));
+}
+
+static void vt1724_enable_midi_irq(struct snd_rawmidi_substream *substream,
+                                  u8 flag, int enable)
+{
+       struct snd_ice1712 *ice = substream->rmidi->private_data;
+
+       spin_lock_irq(&ice->reg_lock);
+       enable_midi_irq(ice, flag, enable);
+       spin_unlock_irq(&ice->reg_lock);
+}
+
+static int vt1724_midi_output_open(struct snd_rawmidi_substream *s)
+{
+       return 0;
+}
+
+static int vt1724_midi_output_close(struct snd_rawmidi_substream *s)
+{
+       return 0;
+}
+
+static void vt1724_midi_output_trigger(struct snd_rawmidi_substream *s, int up)
+{
+       struct snd_ice1712 *ice = s->rmidi->private_data;
+       unsigned long flags;
+
+       spin_lock_irqsave(&ice->reg_lock, flags);
+       if (up) {
+               ice->midi_output = 1;
+               vt1724_midi_write(ice);
+       } else {
+               ice->midi_output = 0;
+               enable_midi_irq(ice, VT1724_IRQ_MPU_TX, 0);
+       }
+       spin_unlock_irqrestore(&ice->reg_lock, flags);
+}
+
+static void vt1724_midi_output_drain(struct snd_rawmidi_substream *s)
+{
+       struct snd_ice1712 *ice = s->rmidi->private_data;
+       unsigned long timeout;
+
+       vt1724_enable_midi_irq(s, VT1724_IRQ_MPU_TX, 0);
+       /* 32 bytes should be transmitted in less than about 12 ms */
+       timeout = jiffies + msecs_to_jiffies(15);
+       do {
+               if (inb(ICEREG1724(ice, MPU_CTRL)) & VT1724_MPU_TX_EMPTY)
+                       break;
+               schedule_timeout_uninterruptible(1);
+       } while (time_after(timeout, jiffies));
+}
+
+static struct snd_rawmidi_ops vt1724_midi_output_ops = {
+       .open = vt1724_midi_output_open,
+       .close = vt1724_midi_output_close,
+       .trigger = vt1724_midi_output_trigger,
+       .drain = vt1724_midi_output_drain,
+};
+
+static int vt1724_midi_input_open(struct snd_rawmidi_substream *s)
+{
+       vt1724_midi_clear_rx(s->rmidi->private_data);
+       vt1724_enable_midi_irq(s, VT1724_IRQ_MPU_RX, 1);
+       return 0;
+}
+
+static int vt1724_midi_input_close(struct snd_rawmidi_substream *s)
+{
+       vt1724_enable_midi_irq(s, VT1724_IRQ_MPU_RX, 0);
+       return 0;
+}
+
+static void vt1724_midi_input_trigger(struct snd_rawmidi_substream *s, int up)
+{
+       struct snd_ice1712 *ice = s->rmidi->private_data;
+       unsigned long flags;
+
+       spin_lock_irqsave(&ice->reg_lock, flags);
+       if (up) {
+               ice->midi_input = 1;
+               vt1724_midi_read(ice);
+       } else {
+               ice->midi_input = 0;
+       }
+       spin_unlock_irqrestore(&ice->reg_lock, flags);
+}
+
+static struct snd_rawmidi_ops vt1724_midi_input_ops = {
+       .open = vt1724_midi_input_open,
+       .close = vt1724_midi_input_close,
+       .trigger = vt1724_midi_input_trigger,
+};
+
+
+/*
  *  Interrupt handler
  */
 
@@ -223,24 +391,50 @@ static irqreturn_t snd_vt1724_interrupt(int irq, void *dev_id)
 {
        struct snd_ice1712 *ice = dev_id;
        unsigned char status;
+       unsigned char status_mask =
+               VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX | VT1724_IRQ_MTPCM;
        int handled = 0;
+       int timeout = 0;
 
        while (1) {
                status = inb(ICEREG1724(ice, IRQSTAT));
+               status &= status_mask;
                if (status == 0)
                        break;
-
-               handled = 1;            
-               /* these should probably be separated at some point, 
-                * but as we don't currently have MPU support on the board
-                * I will leave it
-                */
-               if ((status & VT1724_IRQ_MPU_RX)||(status & VT1724_IRQ_MPU_TX)) {
-                       if (ice->rmidi[0])
-                               snd_mpu401_uart_interrupt(irq, ice->rmidi[0]->private_data);
-                       outb(status & (VT1724_IRQ_MPU_RX|VT1724_IRQ_MPU_TX), ICEREG1724(ice, IRQSTAT));
-                       status &= ~(VT1724_IRQ_MPU_RX|VT1724_IRQ_MPU_TX);
+               spin_lock(&ice->reg_lock);
+               if (++timeout > 10) {
+                       status = inb(ICEREG1724(ice, IRQSTAT));
+                       printk(KERN_ERR "ice1724: Too long irq loop, "
+                              "status = 0x%x\n", status);
+                       if (status & VT1724_IRQ_MPU_TX) {
+                               printk(KERN_ERR "ice1724: Disabling MPU_TX\n");
+                               enable_midi_irq(ice, VT1724_IRQ_MPU_TX, 0);
+                       }
+                       spin_unlock(&ice->reg_lock);
+                       break;
+               }
+               handled = 1;
+               if (status & VT1724_IRQ_MPU_TX) {
+                       if (ice->midi_output)
+                               vt1724_midi_write(ice);
+                       else
+                               enable_midi_irq(ice, VT1724_IRQ_MPU_TX, 0);
+                       /* Due to mysterical reasons, MPU_TX is always
+                        * generated (and can't be cleared) when a PCM
+                        * playback is going.  So let's ignore at the
+                        * next loop.
+                        */
+                       status_mask &= ~VT1724_IRQ_MPU_TX;
                }
+               if (status & VT1724_IRQ_MPU_RX) {
+                       if (ice->midi_input)
+                               vt1724_midi_read(ice);
+                       else
+                               vt1724_midi_clear_rx(ice);
+               }
+               /* ack MPU irq */
+               outb(status, ICEREG1724(ice, IRQSTAT));
+               spin_unlock(&ice->reg_lock);
                if (status & VT1724_IRQ_MTPCM) {
                        /*
                         * Multi-track PCM
@@ -287,8 +481,8 @@ static irqreturn_t snd_vt1724_interrupt(int irq, void *dev_id)
                        /* ought to really handle this properly */
                        if (mtstat & VT1724_MULTI_FIFO_ERR) {
                                unsigned char fstat = inb(ICEMT1724(ice, DMA_FIFO_ERR));
-                               outb(fstat, ICEMT1724(ice, DMA_FIFO_ERR));      
-                               outb(VT1724_MULTI_FIFO_ERR | inb(ICEMT1724(ice, DMA_INT_MASK)), ICEMT1724(ice, DMA_INT_MASK));  
+                               outb(fstat, ICEMT1724(ice, DMA_FIFO_ERR));
+                               outb(VT1724_MULTI_FIFO_ERR | inb(ICEMT1724(ice, DMA_INT_MASK)), ICEMT1724(ice, DMA_INT_MASK));
                                /* If I don't do this, I get machine lockup due to continual interrupts */
                        }
 
@@ -341,10 +535,12 @@ static int snd_vt1724_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 
        what = 0;
        snd_pcm_group_for_each_entry(s, substream) {
-               const struct vt1724_pcm_reg *reg;
-               reg = s->runtime->private_data;
-               what |= reg->start;
-               snd_pcm_trigger_done(s, substream);
+               if (snd_pcm_substream_chip(s) == ice) {
+                       const struct vt1724_pcm_reg *reg;
+                       reg = s->runtime->private_data;
+                       what |= reg->start;
+                       snd_pcm_trigger_done(s, substream);
+               }
        }
 
        switch (cmd) {
@@ -386,51 +582,61 @@ static int snd_vt1724_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 #define DMA_PAUSES     (VT1724_RDMA0_PAUSE|VT1724_PDMA0_PAUSE|VT1724_RDMA1_PAUSE|\
        VT1724_PDMA1_PAUSE|VT1724_PDMA2_PAUSE|VT1724_PDMA3_PAUSE|VT1724_PDMA4_PAUSE)
 
-static int get_max_rate(struct snd_ice1712 *ice)
+static const unsigned int stdclock_rate_list[16] = {
+       48000, 24000, 12000, 9600, 32000, 16000, 8000, 96000, 44100,
+       22050, 11025, 88200, 176400, 0, 192000, 64000
+};
+
+static unsigned int stdclock_get_rate(struct snd_ice1712 *ice)
+{
+       unsigned int rate;
+       rate = stdclock_rate_list[inb(ICEMT1724(ice, RATE)) & 15];
+       return rate;
+}
+
+static void stdclock_set_rate(struct snd_ice1712 *ice, unsigned int rate)
+{
+       int i;
+       for (i = 0; i < ARRAY_SIZE(stdclock_rate_list); i++) {
+               if (stdclock_rate_list[i] == rate) {
+                       outb(i, ICEMT1724(ice, RATE));
+                       return;
+               }
+       }
+}
+
+static unsigned char stdclock_set_mclk(struct snd_ice1712 *ice,
+                                      unsigned int rate)
 {
+       unsigned char val, old;
+       /* check MT02 */
        if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
-               if ((ice->eeprom.data[ICE_EEP2_I2S] & 0x08) && !ice->vt1720)
-                       return 192000;
+               val = old = inb(ICEMT1724(ice, I2S_FORMAT));
+               if (rate > 96000)
+                       val |= VT1724_MT_I2S_MCLK_128X; /* 128x MCLK */
                else
-                       return 96000;
-       } else
-               return 48000;
+                       val &= ~VT1724_MT_I2S_MCLK_128X; /* 256x MCLK */
+               if (val != old) {
+                       outb(val, ICEMT1724(ice, I2S_FORMAT));
+                       /* master clock changed */
+                       return 1;
+               }
+       }
+       /* no change in master clock */
+       return 0;
 }
 
 static void snd_vt1724_set_pro_rate(struct snd_ice1712 *ice, unsigned int rate,
                                    int force)
 {
        unsigned long flags;
-       unsigned char val, old;
-       unsigned int i, mclk_change;
+       unsigned char mclk_change;
+       unsigned int i, old_rate;
 
-       if (rate > get_max_rate(ice))
+       if (rate > ice->hw_rates->list[ice->hw_rates->count - 1])
                return;
-
-       switch (rate) {
-       case 8000: val = 6; break;
-       case 9600: val = 3; break;
-       case 11025: val = 10; break;
-       case 12000: val = 2; break;
-       case 16000: val = 5; break;
-       case 22050: val = 9; break;
-       case 24000: val = 1; break;
-       case 32000: val = 4; break;
-       case 44100: val = 8; break;
-       case 48000: val = 0; break;
-       case 64000: val = 15; break;
-       case 88200: val = 11; break;
-       case 96000: val = 7; break;
-       case 176400: val = 12; break;
-       case 192000: val = 14; break;
-       default:
-               snd_BUG();
-               val = 0;
-               break;
-       }
-
        spin_lock_irqsave(&ice->reg_lock, flags);
-       if ((inb(ICEMT1724(ice, DMA_CONTROL)) & DMA_STARTS) || 
+       if ((inb(ICEMT1724(ice, DMA_CONTROL)) & DMA_STARTS) ||
            (inb(ICEMT1724(ice, DMA_PAUSE)) & DMA_PAUSES)) {
                /* running? we cannot change the rate now... */
                spin_unlock_irqrestore(&ice->reg_lock, flags);
@@ -441,9 +647,9 @@ static void snd_vt1724_set_pro_rate(struct snd_ice1712 *ice, unsigned int rate,
                return;
        }
 
-       old = inb(ICEMT1724(ice, RATE));
-       if (force || old != val)
-               outb(val, ICEMT1724(ice, RATE));
+       old_rate = ice->get_rate(ice);
+       if (force || (old_rate != rate))
+               ice->set_rate(ice, rate);
        else if (rate == ice->cur_rate) {
                spin_unlock_irqrestore(&ice->reg_lock, flags);
                return;
@@ -451,19 +657,9 @@ static void snd_vt1724_set_pro_rate(struct snd_ice1712 *ice, unsigned int rate,
 
        ice->cur_rate = rate;
 
-       /* check MT02 */
-       mclk_change = 0;
-       if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
-               val = old = inb(ICEMT1724(ice, I2S_FORMAT));
-               if (rate > 96000)
-                       val |= VT1724_MT_I2S_MCLK_128X; /* 128x MCLK */
-               else
-                       val &= ~VT1724_MT_I2S_MCLK_128X; /* 256x MCLK */
-               if (val != old) {
-                       outb(val, ICEMT1724(ice, I2S_FORMAT));
-                       mclk_change = 1;
-               }
-       }
+       /* setting master clock */
+       mclk_change = ice->set_mclk(ice, rate);
+
        spin_unlock_irqrestore(&ice->reg_lock, flags);
 
        if (mclk_change && ice->gpio.i2s_mclk_changed)
@@ -550,17 +746,24 @@ static int snd_vt1724_playback_pro_prepare(struct snd_pcm_substream *substream)
        outl(substream->runtime->dma_addr, ICEMT1724(ice, PLAYBACK_ADDR));
 
        size = (snd_pcm_lib_buffer_bytes(substream) >> 2) - 1;
-       // outl(size, ICEMT1724(ice, PLAYBACK_SIZE));
+       /* outl(size, ICEMT1724(ice, PLAYBACK_SIZE)); */
        outw(size, ICEMT1724(ice, PLAYBACK_SIZE));
        outb(size >> 16, ICEMT1724(ice, PLAYBACK_SIZE) + 2);
        size = (snd_pcm_lib_period_bytes(substream) >> 2) - 1;
-       // outl(size, ICEMT1724(ice, PLAYBACK_COUNT));
+       /* outl(size, ICEMT1724(ice, PLAYBACK_COUNT)); */
        outw(size, ICEMT1724(ice, PLAYBACK_COUNT));
        outb(size >> 16, ICEMT1724(ice, PLAYBACK_COUNT) + 2);
 
        spin_unlock_irq(&ice->reg_lock);
 
-       // printk("pro prepare: ch = %d, addr = 0x%x, buffer = 0x%x, period = 0x%x\n", substream->runtime->channels, (unsigned int)substream->runtime->dma_addr, snd_pcm_lib_buffer_bytes(substream), snd_pcm_lib_period_bytes(substream));
+       /*
+       printk(KERN_DEBUG "pro prepare: ch = %d, addr = 0x%x, "
+              "buffer = 0x%x, period = 0x%x\n",
+              substream->runtime->channels,
+              (unsigned int)substream->runtime->dma_addr,
+              snd_pcm_lib_buffer_bytes(substream),
+              snd_pcm_lib_period_bytes(substream));
+       */
        return 0;
 }
 
@@ -588,7 +791,7 @@ static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(struct snd_pcm_substrea
        ptr = inl(ICEMT1724(ice, PLAYBACK_SIZE)) & 0xffffff;
        ptr = (ptr + 1) << 2;
        ptr = bytes_to_frames(substream->runtime, ptr);
-       if (! ptr)
+       if (!ptr)
                ;
        else if (ptr <= substream->runtime->buffer_size)
                ptr = substream->runtime->buffer_size - ptr;
@@ -632,7 +835,7 @@ static snd_pcm_uframes_t snd_vt1724_pcm_pointer(struct snd_pcm_substream *substr
        ptr = inw(ice->profi_port + reg->size);
        ptr = (ptr + 1) << 2;
        ptr = bytes_to_frames(substream->runtime, ptr);
-       if (! ptr)
+       if (!ptr)
                ;
        else if (ptr <= substream->runtime->buffer_size)
                ptr = substream->runtime->buffer_size - ptr;
@@ -659,8 +862,7 @@ static const struct vt1724_pcm_reg vt1724_capture_pro_reg = {
        .start = VT1724_RDMA0_START,
 };
 
-static const struct snd_pcm_hardware snd_vt1724_playback_pro =
-{
+static const struct snd_pcm_hardware snd_vt1724_playback_pro = {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -678,8 +880,7 @@ static const struct snd_pcm_hardware snd_vt1724_playback_pro =
        .periods_max =          1024,
 };
 
-static const struct snd_pcm_hardware snd_vt1724_spdif =
-{
+static const struct snd_pcm_hardware snd_vt1724_spdif = {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -700,8 +901,7 @@ static const struct snd_pcm_hardware snd_vt1724_spdif =
        .periods_max =          1024,
 };
 
-static const struct snd_pcm_hardware snd_vt1724_2ch_stereo =
-{
+static const struct snd_pcm_hardware snd_vt1724_2ch_stereo = {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -722,43 +922,32 @@ static const struct snd_pcm_hardware snd_vt1724_2ch_stereo =
 /*
  * set rate constraints
  */
-static int set_rate_constraints(struct snd_ice1712 *ice,
-                               struct snd_pcm_substream *substream)
+static void set_std_hw_rates(struct snd_ice1712 *ice)
 {
-       struct snd_pcm_runtime *runtime = substream->runtime;
-       if (ice->hw_rates) {
-               /* hardware specific */
-               runtime->hw.rate_min = ice->hw_rates->list[0];
-               runtime->hw.rate_max = ice->hw_rates->list[ice->hw_rates->count - 1];
-               runtime->hw.rates = SNDRV_PCM_RATE_KNOT;
-               return snd_pcm_hw_constraint_list(runtime, 0,
-                                                 SNDRV_PCM_HW_PARAM_RATE,
-                                                 ice->hw_rates);
-       }
        if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
                /* I2S */
                /* VT1720 doesn't support more than 96kHz */
                if ((ice->eeprom.data[ICE_EEP2_I2S] & 0x08) && !ice->vt1720)
-                       return snd_pcm_hw_constraint_list(runtime, 0,
-                                                         SNDRV_PCM_HW_PARAM_RATE,
-                                                         &hw_constraints_rates_192);
-               else {
-                       runtime->hw.rates = SNDRV_PCM_RATE_KNOT |
-                               SNDRV_PCM_RATE_8000_96000;
-                       runtime->hw.rate_max = 96000;
-                       return snd_pcm_hw_constraint_list(runtime, 0,
-                                                         SNDRV_PCM_HW_PARAM_RATE,
-                                                         &hw_constraints_rates_96);
-               }
-       } else if (ice->ac97) {
+                       ice->hw_rates = &hw_constraints_rates_192;
+               else
+                       ice->hw_rates = &hw_constraints_rates_96;
+       } else {
                /* ACLINK */
-               runtime->hw.rate_max = 48000;
-               runtime->hw.rates = SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_8000_48000;
-               return snd_pcm_hw_constraint_list(runtime, 0,
-                                                 SNDRV_PCM_HW_PARAM_RATE,
-                                                 &hw_constraints_rates_48);
+               ice->hw_rates = &hw_constraints_rates_48;
        }
-       return 0;
+}
+
+static int set_rate_constraints(struct snd_ice1712 *ice,
+                               struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+
+       runtime->hw.rate_min = ice->hw_rates->list[0];
+       runtime->hw.rate_max = ice->hw_rates->list[ice->hw_rates->count - 1];
+       runtime->hw.rates = SNDRV_PCM_RATE_KNOT;
+       return snd_pcm_hw_constraint_list(runtime, 0,
+                                         SNDRV_PCM_HW_PARAM_RATE,
+                                         ice->hw_rates);
 }
 
 /* multi-channel playback needs alignment 8x32bit regardless of the channels
@@ -770,7 +959,7 @@ static int snd_vt1724_playback_pro_open(struct snd_pcm_substream *substream)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
-       int chs;
+       int chs, num_indeps;
 
        runtime->private_data = (void *)&vt1724_playback_pro_reg;
        ice->playback_pro_substream = substream;
@@ -780,7 +969,8 @@ static int snd_vt1724_playback_pro_open(struct snd_pcm_substream *substream)
        set_rate_constraints(ice, substream);
        mutex_lock(&ice->open_mutex);
        /* calculate the currently available channels */
-       for (chs = 0; chs < 3; chs++) {
+       num_indeps = ice->num_total_dacs / 2 - 1;
+       for (chs = 0; chs < num_indeps; chs++) {
                if (ice->pcm_reserved[chs])
                        break;
        }
@@ -819,7 +1009,7 @@ static int snd_vt1724_playback_pro_close(struct snd_pcm_substream *substream)
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 0);
        ice->playback_pro_substream = NULL;
 
        return 0;
@@ -830,7 +1020,7 @@ static int snd_vt1724_capture_pro_close(struct snd_pcm_substream *substream)
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 0);
        ice->capture_pro_substream = NULL;
        return 0;
 }
@@ -857,7 +1047,7 @@ static struct snd_pcm_ops snd_vt1724_capture_pro_ops = {
        .pointer =      snd_vt1724_pcm_pointer,
 };
 
-static int __devinit snd_vt1724_pcm_profi(struct snd_ice1712 * ice, int device)
+static int __devinit snd_vt1724_pcm_profi(struct snd_ice1712 *ice, int device)
 {
        struct snd_pcm *pcm;
        int err;
@@ -942,7 +1132,7 @@ static void update_spdif_rate(struct snd_ice1712 *ice, unsigned int rate)
 static int snd_vt1724_playback_spdif_prepare(struct snd_pcm_substream *substream)
 {
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
-       if (! ice->force_pdma4)
+       if (!ice->force_pdma4)
                update_spdif_rate(ice, substream->runtime->rate);
        return snd_vt1724_pcm_prepare(substream);
 }
@@ -965,6 +1155,8 @@ static int snd_vt1724_playback_spdif_open(struct snd_pcm_substream *substream)
                                   VT1724_BUFFER_ALIGN);
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
                                   VT1724_BUFFER_ALIGN);
+       if (ice->spdif.ops.open)
+               ice->spdif.ops.open(ice, substream);
        return 0;
 }
 
@@ -973,8 +1165,10 @@ static int snd_vt1724_playback_spdif_close(struct snd_pcm_substream *substream)
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 0);
        ice->playback_con_substream = NULL;
+       if (ice->spdif.ops.close)
+               ice->spdif.ops.close(ice, substream);
 
        return 0;
 }
@@ -997,6 +1191,8 @@ static int snd_vt1724_capture_spdif_open(struct snd_pcm_substream *substream)
                                   VT1724_BUFFER_ALIGN);
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
                                   VT1724_BUFFER_ALIGN);
+       if (ice->spdif.ops.open)
+               ice->spdif.ops.open(ice, substream);
        return 0;
 }
 
@@ -1005,8 +1201,10 @@ static int snd_vt1724_capture_spdif_close(struct snd_pcm_substream *substream)
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 0);
        ice->capture_con_substream = NULL;
+       if (ice->spdif.ops.close)
+               ice->spdif.ops.close(ice, substream);
 
        return 0;
 }
@@ -1034,7 +1232,7 @@ static struct snd_pcm_ops snd_vt1724_capture_spdif_ops = {
 };
 
 
-static int __devinit snd_vt1724_pcm_spdif(struct snd_ice1712 * ice, int device)
+static int __devinit snd_vt1724_pcm_spdif(struct snd_ice1712 *ice, int device)
 {
        char *name;
        struct snd_pcm *pcm;
@@ -1053,13 +1251,13 @@ static int __devinit snd_vt1724_pcm_spdif(struct snd_ice1712 * ice, int device)
                ice->has_spdif = 1;
        } else
                capt = 0;
-       if (! play && ! capt)
+       if (!play && !capt)
                return 0; /* no spdif device */
 
        if (ice->force_pdma4 || ice->force_rdma1)
                name = "ICE1724 Secondary";
        else
-               name = "IEC1724 IEC958";
+               name = "ICE1724 IEC958";
        err = snd_pcm_new(ice->card, name, device, play, capt, &pcm);
        if (err < 0)
                return err;
@@ -1149,7 +1347,7 @@ static int snd_vt1724_playback_indep_close(struct snd_pcm_substream *substream)
        struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 0);
        ice->playback_con_substream_ds[substream->number] = NULL;
        ice->pcm_reserved[substream->number] = NULL;
 
@@ -1168,7 +1366,7 @@ static struct snd_pcm_ops snd_vt1724_playback_indep_ops = {
 };
 
 
-static int __devinit snd_vt1724_pcm_indep(struct snd_ice1712 * ice, int device)
+static int __devinit snd_vt1724_pcm_indep(struct snd_ice1712 *ice, int device)
 {
        struct snd_pcm *pcm;
        int play;
@@ -1203,11 +1401,11 @@ static int __devinit snd_vt1724_pcm_indep(struct snd_ice1712 * ice, int device)
  *  Mixer section
  */
 
-static int __devinit snd_vt1724_ac97_mixer(struct snd_ice1712 * ice)
+static int __devinit snd_vt1724_ac97_mixer(struct snd_ice1712 *ice)
 {
        int err;
 
-       if (! (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S)) {
+       if (!(ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S)) {
                struct snd_ac97_bus *pbus;
                struct snd_ac97_template ac97;
                static struct snd_ac97_bus_ops ops = {
@@ -1220,11 +1418,13 @@ static int __devinit snd_vt1724_ac97_mixer(struct snd_ice1712 * ice)
                mdelay(5); /* FIXME */
                outb(inb(ICEMT1724(ice, AC97_CMD)) & ~0x80, ICEMT1724(ice, AC97_CMD));
 
-               if ((err = snd_ac97_bus(ice->card, 0, &ops, NULL, &pbus)) < 0)
+               err = snd_ac97_bus(ice->card, 0, &ops, NULL, &pbus);
+               if (err < 0)
                        return err;
                memset(&ac97, 0, sizeof(ac97));
                ac97.private_data = ice;
-               if ((err = snd_ac97_mixer(pbus, &ac97, &ice->ac97)) < 0)
+               err = snd_ac97_mixer(pbus, &ac97, &ice->ac97);
+               if (err < 0)
                        printk(KERN_WARNING "ice1712: cannot initialize pro ac97, skipped\n");
                else
                        return 0;
@@ -1245,7 +1445,7 @@ static inline unsigned int eeprom_triple(struct snd_ice1712 *ice, int idx)
                ((unsigned int)ice->eeprom.data[idx + 2] << 16);
 }
 
-static void snd_vt1724_proc_read(struct snd_info_entry *entry, 
+static void snd_vt1724_proc_read(struct snd_info_entry *entry,
                                 struct snd_info_buffer *buffer)
 {
        struct snd_ice1712 *ice = entry->private_data;
@@ -1287,11 +1487,11 @@ static void snd_vt1724_proc_read(struct snd_info_entry *entry,
                            idx, inb(ice->profi_port+idx));
 }
 
-static void __devinit snd_vt1724_proc_init(struct snd_ice1712 * ice)
+static void __devinit snd_vt1724_proc_init(struct snd_ice1712 *ice)
 {
        struct snd_info_entry *entry;
 
-       if (! snd_card_proc_new(ice->card, "ice1724", &entry))
+       if (!snd_card_proc_new(ice->card, "ice1724", &entry))
                snd_info_set_text_ops(entry, ice, snd_vt1724_proc_read);
 }
 
@@ -1311,7 +1511,7 @@ static int snd_vt1724_eeprom_get(struct snd_kcontrol *kcontrol,
                                 struct snd_ctl_elem_value *ucontrol)
 {
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
-       
+
        memcpy(ucontrol->value.bytes.data, &ice->eeprom, sizeof(ice->eeprom));
        return 0;
 }
@@ -1426,13 +1626,13 @@ static int snd_vt1724_spdif_default_put(struct snd_kcontrol *kcontrol,
        if (val != old)
                update_spdif_bits(ice, val);
        spin_unlock_irq(&ice->reg_lock);
-       return (val != old);
+       return val != old;
 }
 
 static struct snd_kcontrol_new snd_vt1724_spdif_default __devinitdata =
 {
        .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
-       .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,DEFAULT),
+       .name =         SNDRV_CTL_NAME_IEC958("", PLAYBACK, DEFAULT),
        .info =         snd_vt1724_spdif_info,
        .get =          snd_vt1724_spdif_default_get,
        .put =          snd_vt1724_spdif_default_put
@@ -1465,7 +1665,7 @@ static struct snd_kcontrol_new snd_vt1724_spdif_maskc __devinitdata =
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
        .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
-       .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,CON_MASK),
+       .name =         SNDRV_CTL_NAME_IEC958("", PLAYBACK, CON_MASK),
        .info =         snd_vt1724_spdif_info,
        .get =          snd_vt1724_spdif_maskc_get,
 };
@@ -1474,7 +1674,7 @@ static struct snd_kcontrol_new snd_vt1724_spdif_maskp __devinitdata =
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
        .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
-       .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,PRO_MASK),
+       .name =         SNDRV_CTL_NAME_IEC958("", PLAYBACK, PRO_MASK),
        .info =         snd_vt1724_spdif_info,
        .get =          snd_vt1724_spdif_maskp_get,
 };
@@ -1511,8 +1711,8 @@ static struct snd_kcontrol_new snd_vt1724_spdif_switch __devinitdata =
 {
        .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
        /* FIXME: the following conflict with IEC958 Playback Route */
-       // .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,SWITCH),
-       .name =         SNDRV_CTL_NAME_IEC958("Output ",NONE,SWITCH),
+       /* .name =         SNDRV_CTL_NAME_IEC958("", PLAYBACK, SWITCH), */
+       .name =         SNDRV_CTL_NAME_IEC958("Output ", NONE, SWITCH),
        .info =         snd_vt1724_spdif_sw_info,
        .get =          snd_vt1724_spdif_sw_get,
        .put =          snd_vt1724_spdif_sw_put
@@ -1532,7 +1732,7 @@ int snd_vt1724_gpio_get(struct snd_kcontrol *kcontrol,
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int shift = kcontrol->private_value & 0xff;
        int invert = (kcontrol->private_value & (1<<24)) ? 1 : 0;
-       
+
        snd_ice1712_save_gpio_status(ice);
        ucontrol->value.integer.value[0] =
                (snd_ice1712_gpio_read(ice) & (1 << shift) ? 1 : 0) ^ invert;
@@ -1567,50 +1767,18 @@ int snd_ice1712_gpio_put(struct snd_kcontrol *kcontrol,
 static int snd_vt1724_pro_internal_clock_info(struct snd_kcontrol *kcontrol,
                                              struct snd_ctl_elem_info *uinfo)
 {
-       static const char * const texts_1724[] = {
-               "8000",         /* 0: 6 */
-               "9600",         /* 1: 3 */
-               "11025",        /* 2: 10 */
-               "12000",        /* 3: 2 */
-               "16000",        /* 4: 5 */
-               "22050",        /* 5: 9 */
-               "24000",        /* 6: 1 */
-               "32000",        /* 7: 4 */
-               "44100",        /* 8: 8 */
-               "48000",        /* 9: 0 */
-               "64000",        /* 10: 15 */
-               "88200",        /* 11: 11 */
-               "96000",        /* 12: 7 */
-               "176400",       /* 13: 12 */
-               "192000",       /* 14: 14 */
-               "IEC958 Input", /* 15: -- */
-       };
-       static const char * const texts_1720[] = {
-               "8000",         /* 0: 6 */
-               "9600",         /* 1: 3 */
-               "11025",        /* 2: 10 */
-               "12000",        /* 3: 2 */
-               "16000",        /* 4: 5 */
-               "22050",        /* 5: 9 */
-               "24000",        /* 6: 1 */
-               "32000",        /* 7: 4 */
-               "44100",        /* 8: 8 */
-               "48000",        /* 9: 0 */
-               "64000",        /* 10: 15 */
-               "88200",        /* 11: 11 */
-               "96000",        /* 12: 7 */
-               "IEC958 Input", /* 13: -- */
-       };
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
 
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
-       uinfo->value.enumerated.items = ice->vt1720 ? 14 : 16;
+       uinfo->value.enumerated.items = ice->hw_rates->count + 1;
        if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
                uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
-       strcpy(uinfo->value.enumerated.name,
-              ice->vt1720 ? texts_1720[uinfo->value.enumerated.item] :
-              texts_1724[uinfo->value.enumerated.item]);
+       if (uinfo->value.enumerated.item == uinfo->value.enumerated.items - 1)
+               strcpy(uinfo->value.enumerated.name, "IEC958 Input");
+       else
+               sprintf(uinfo->value.enumerated.name, "%d",
+                       ice->hw_rates->list[uinfo->value.enumerated.item]);
        return 0;
 }
 
@@ -1618,68 +1786,79 @@ static int snd_vt1724_pro_internal_clock_get(struct snd_kcontrol *kcontrol,
                                             struct snd_ctl_elem_value *ucontrol)
 {
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
-       static const unsigned char xlate[16] = {
-               9, 6, 3, 1, 7, 4, 0, 12, 8, 5, 2, 11, 13, 255, 14, 10
-       };
-       unsigned char val;
-       
+       unsigned int i, rate;
+
        spin_lock_irq(&ice->reg_lock);
-       if (is_spdif_master(ice)) {
-               ucontrol->value.enumerated.item[0] = ice->vt1720 ? 13 : 15;
+       if (ice->is_spdif_master(ice)) {
+               ucontrol->value.enumerated.item[0] = ice->hw_rates->count;
        } else {
-               val = xlate[inb(ICEMT1724(ice, RATE)) & 15];
-               if (val == 255) {
-                       snd_BUG();
-                       val = 0;
+               rate = ice->get_rate(ice);
+               ucontrol->value.enumerated.item[0] = 0;
+               for (i = 0; i < ice->hw_rates->count; i++) {
+                       if (ice->hw_rates->list[i] == rate) {
+                               ucontrol->value.enumerated.item[0] = i;
+                               break;
+                       }
                }
-               ucontrol->value.enumerated.item[0] = val;
        }
        spin_unlock_irq(&ice->reg_lock);
        return 0;
 }
 
+/* setting clock to external - SPDIF */
+static void stdclock_set_spdif_clock(struct snd_ice1712 *ice)
+{
+       unsigned char oval;
+       unsigned char i2s_oval;
+       oval = inb(ICEMT1724(ice, RATE));
+       outb(oval | VT1724_SPDIF_MASTER, ICEMT1724(ice, RATE));
+       /* setting 256fs */
+       i2s_oval = inb(ICEMT1724(ice, I2S_FORMAT));
+       outb(i2s_oval & ~VT1724_MT_I2S_MCLK_128X, ICEMT1724(ice, I2S_FORMAT));
+}
+
 static int snd_vt1724_pro_internal_clock_put(struct snd_kcontrol *kcontrol,
                                             struct snd_ctl_elem_value *ucontrol)
 {
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
-       unsigned char oval;
-       int rate;
-       int change = 0;
-       int spdif = ice->vt1720 ? 13 : 15;
+       unsigned int old_rate, new_rate;
+       unsigned int item = ucontrol->value.enumerated.item[0];
+       unsigned int spdif = ice->hw_rates->count;
+
+       if (item > spdif)
+               return -EINVAL;
 
        spin_lock_irq(&ice->reg_lock);
-       oval = inb(ICEMT1724(ice, RATE));
-       if (ucontrol->value.enumerated.item[0] == spdif) {
-               unsigned char i2s_oval;
-               outb(oval | VT1724_SPDIF_MASTER, ICEMT1724(ice, RATE));
-               /* setting 256fs */
-               i2s_oval = inb(ICEMT1724(ice, I2S_FORMAT));
-               outb(i2s_oval & ~VT1724_MT_I2S_MCLK_128X,
-                    ICEMT1724(ice, I2S_FORMAT));
+       if (ice->is_spdif_master(ice))
+               old_rate = 0;
+       else
+               old_rate = ice->get_rate(ice);
+       if (item == spdif) {
+               /* switching to external clock via SPDIF */
+               ice->set_spdif_clock(ice);
+               new_rate = 0;
        } else {
-               rate = rates[ucontrol->value.integer.value[0] % 15];
-               if (rate <= get_max_rate(ice)) {
-                       PRO_RATE_DEFAULT = rate;
-                       spin_unlock_irq(&ice->reg_lock);
-                       snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 1);
-                       spin_lock_irq(&ice->reg_lock);
-               }
+               /* internal on-card clock */
+               new_rate = ice->hw_rates->list[item];
+               ice->pro_rate_default = new_rate;
+               spin_unlock_irq(&ice->reg_lock);
+               snd_vt1724_set_pro_rate(ice, ice->pro_rate_default, 1);
+               spin_lock_irq(&ice->reg_lock);
        }
-       change = inb(ICEMT1724(ice, RATE)) != oval;
        spin_unlock_irq(&ice->reg_lock);
 
-       if ((oval & VT1724_SPDIF_MASTER) !=
-           (inb(ICEMT1724(ice, RATE)) & VT1724_SPDIF_MASTER)) {
+       /* the first reset to the SPDIF master mode? */
+       if (old_rate != new_rate && !new_rate) {
                /* notify akm chips as well */
-               if (is_spdif_master(ice)) {
-                       unsigned int i;
-                       for (i = 0; i < ice->akm_codecs; i++) {
-                               if (ice->akm[i].ops.set_rate_val)
-                                       ice->akm[i].ops.set_rate_val(&ice->akm[i], 0);
-                       }
+               unsigned int i;
+               if (ice->gpio.set_pro_rate)
+                       ice->gpio.set_pro_rate(ice, 0);
+               for (i = 0; i < ice->akm_codecs; i++) {
+                       if (ice->akm[i].ops.set_rate_val)
+                               ice->akm[i].ops.set_rate_val(&ice->akm[i], 0);
                }
        }
-       return change;
+       return old_rate != new_rate;
 }
 
 static struct snd_kcontrol_new snd_vt1724_pro_internal_clock __devinitdata = {
@@ -1764,7 +1943,7 @@ static int snd_vt1724_pro_route_info(struct snd_kcontrol *kcontrol,
                "H/W In 0", "H/W In 1", /* 1-2 */
                "IEC958 In L", "IEC958 In R", /* 3-4 */
        };
-       
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = 5;
@@ -1794,7 +1973,7 @@ static int get_route_val(struct snd_ice1712 *ice, int shift)
 
        val = inl(ICEMT1724(ice, ROUTE_PLAYBACK));
        val >>= shift;
-       val &= 7;       //we now have 3 bits per output
+       val &= 7; /* we now have 3 bits per output */
        eitem = xlate[val];
        if (eitem == 255) {
                snd_BUG();
@@ -1873,7 +2052,7 @@ static struct snd_kcontrol_new snd_vt1724_mixer_pro_analog_route __devinitdata =
 
 static struct snd_kcontrol_new snd_vt1724_mixer_pro_spdif_route __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
-       .name = SNDRV_CTL_NAME_IEC958("",PLAYBACK,NONE) "Route",
+       .name = SNDRV_CTL_NAME_IEC958("", PLAYBACK, NONE) "Route",
        .info = snd_vt1724_pro_route_info,
        .get = snd_vt1724_pro_route_spdif_get,
        .put = snd_vt1724_pro_route_spdif_put,
@@ -1896,7 +2075,7 @@ static int snd_vt1724_pro_peak_get(struct snd_kcontrol *kcontrol,
 {
        struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx;
-       
+
        spin_lock_irq(&ice->reg_lock);
        for (idx = 0; idx < 22; idx++) {
                outb(idx, ICEMT1724(ice, MONITOR_PEAKINDEX));
@@ -1923,14 +2102,16 @@ static struct snd_ice1712_card_info no_matched __devinitdata;
 
 static struct snd_ice1712_card_info *card_tables[] __devinitdata = {
        snd_vt1724_revo_cards,
-       snd_vt1724_amp_cards, 
+       snd_vt1724_amp_cards,
        snd_vt1724_aureon_cards,
        snd_vt1720_mobo_cards,
        snd_vt1720_pontis_cards,
+       snd_vt1724_prodigy_hifi_cards,
        snd_vt1724_prodigy192_cards,
        snd_vt1724_juli_cards,
        snd_vt1724_phase_cards,
        snd_vt1724_wtm_cards,
+       snd_vt1724_se_cards,
        NULL,
 };
 
@@ -1953,12 +2134,15 @@ unsigned char snd_vt1724_read_i2c(struct snd_ice1712 *ice,
        unsigned char val;
 
        mutex_lock(&ice->i2c_mutex);
+       wait_i2c_busy(ice);
        outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
        outb(dev & ~VT1724_I2C_WRITE, ICEREG1724(ice, I2C_DEV_ADDR));
        wait_i2c_busy(ice);
        val = inb(ICEREG1724(ice, I2C_DATA));
        mutex_unlock(&ice->i2c_mutex);
-       //printk("i2c_read: [0x%x,0x%x] = 0x%x\n", dev, addr, val);
+       /*
+       printk(KERN_DEBUG "i2c_read: [0x%x,0x%x] = 0x%x\n", dev, addr, val);
+       */
        return val;
 }
 
@@ -1967,7 +2151,9 @@ void snd_vt1724_write_i2c(struct snd_ice1712 *ice,
 {
        mutex_lock(&ice->i2c_mutex);
        wait_i2c_busy(ice);
-       //printk("i2c_write: [0x%x,0x%x] = 0x%x\n", dev, addr, data);
+       /*
+       printk(KERN_DEBUG "i2c_write: [0x%x,0x%x] = 0x%x\n", dev, addr, data);
+       */
        outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
        outb(data, ICEREG1724(ice, I2C_DATA));
        outb(dev | VT1724_I2C_WRITE, ICEREG1724(ice, I2C_DEV_ADDR));
@@ -1982,13 +2168,13 @@ static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
        unsigned int i, size;
        struct snd_ice1712_card_info * const *tbl, *c;
 
-       if (! modelname || ! *modelname) {
+       if (!modelname || !*modelname) {
                ice->eeprom.subvendor = 0;
                if ((inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_EEPROM) != 0)
                        ice->eeprom.subvendor =
                                (snd_vt1724_read_i2c(ice, dev, 0x00) << 0) |
-                               (snd_vt1724_read_i2c(ice, dev, 0x01) << 8) | 
-                               (snd_vt1724_read_i2c(ice, dev, 0x02) << 16) | 
+                               (snd_vt1724_read_i2c(ice, dev, 0x01) << 8) |
+                               (snd_vt1724_read_i2c(ice, dev, 0x02) << 16) |
                                (snd_vt1724_read_i2c(ice, dev, 0x03) << 24);
                if (ice->eeprom.subvendor == 0 ||
                    ice->eeprom.subvendor == (unsigned int)-1) {
@@ -2011,13 +2197,13 @@ static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
        for (tbl = card_tables; *tbl; tbl++) {
                for (c = *tbl; c->subvendor; c++) {
                        if (modelname && c->model &&
-                           ! strcmp(modelname, c->model)) {
+                           !strcmp(modelname, c->model)) {
                                printk(KERN_INFO "ice1724: Using board model %s\n",
                                       c->name);
                                ice->eeprom.subvendor = c->subvendor;
                        } else if (c->subvendor != ice->eeprom.subvendor)
                                continue;
-                       if (! c->eeprom_size || ! c->eeprom_data)
+                       if (!c->eeprom_size || !c->eeprom_data)
                                goto found;
                        /* if the EEPROM is given by the driver, use it */
                        snd_printdd("using the defined eeprom..\n");
@@ -2057,12 +2243,16 @@ static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
 
 
 
-static int __devinit snd_vt1724_chip_init(struct snd_ice1712 *ice)
+static void __devinit snd_vt1724_chip_reset(struct snd_ice1712 *ice)
 {
        outb(VT1724_RESET , ICEREG1724(ice, CONTROL));
-       udelay(200);
+       msleep(10);
        outb(0, ICEREG1724(ice, CONTROL));
-       udelay(200);
+       msleep(10);
+}
+
+static int __devinit snd_vt1724_chip_init(struct snd_ice1712 *ice)
+{
        outb(ice->eeprom.data[ICE_EEP2_SYSCONF], ICEREG1724(ice, SYS_CFG));
        outb(ice->eeprom.data[ICE_EEP2_ACLINK], ICEREG1724(ice, AC97_CFG));
        outb(ice->eeprom.data[ICE_EEP2_I2S], ICEREG1724(ice, I2S_FEATURES));
@@ -2084,7 +2274,8 @@ static int __devinit snd_vt1724_spdif_build_controls(struct snd_ice1712 *ice)
        int err;
        struct snd_kcontrol *kctl;
 
-       snd_assert(ice->pcm != NULL, return -EIO);
+       if (snd_BUG_ON(!ice->pcm))
+               return -EIO;
 
        err = snd_ctl_add(ice->card, snd_ctl_new1(&snd_vt1724_mixer_pro_spdif_route, ice));
        if (err < 0)
@@ -2154,20 +2345,19 @@ static int __devinit snd_vt1724_build_controls(struct snd_ice1712 *ice)
 
 static int snd_vt1724_free(struct snd_ice1712 *ice)
 {
-       if (! ice->port)
+       if (!ice->port)
                goto __hw_end;
        /* mask all interrupts */
        outb(0xff, ICEMT1724(ice, DMA_INT_MASK));
        outb(0xff, ICEREG1724(ice, IRQMASK));
        /* --- */
-      __hw_end:
-       if (ice->irq >= 0) {
-               synchronize_irq(ice->irq);
+__hw_end:
+       if (ice->irq >= 0)
                free_irq(ice->irq, ice);
-       }
        pci_release_regions(ice->pci);
        snd_ice1712_akm4xxx_free(ice);
        pci_disable_device(ice->pci);
+       kfree(ice->spec);
        kfree(ice);
        return 0;
 }
@@ -2181,19 +2371,19 @@ static int snd_vt1724_dev_free(struct snd_device *device)
 static int __devinit snd_vt1724_create(struct snd_card *card,
                                       struct pci_dev *pci,
                                       const char *modelname,
-                                      struct snd_ice1712 ** r_ice1712)
+                                      struct snd_ice1712 **r_ice1712)
 {
        struct snd_ice1712 *ice;
        int err;
-       unsigned char mask;
        static struct snd_device_ops ops = {
                .dev_free =     snd_vt1724_dev_free,
        };
 
        *r_ice1712 = NULL;
 
-        /* enable PCI device */
-       if ((err = pci_enable_device(pci)) < 0)
+       /* enable PCI device */
+       err = pci_enable_device(pci);
+       if (err < 0)
                return err;
 
        ice = kzalloc(sizeof(*ice), GFP_KERNEL);
@@ -2217,7 +2407,8 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
        snd_vt1724_proc_init(ice);
        synchronize_irq(pci->irq);
 
-       if ((err = pci_request_regions(pci, "ICE1724")) < 0) {
+       err = pci_request_regions(pci, "ICE1724");
+       if (err < 0) {
                kfree(ice);
                pci_disable_device(pci);
                return err;
@@ -2234,6 +2425,7 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
 
        ice->irq = pci->irq;
 
+       snd_vt1724_chip_reset(ice);
        if (snd_vt1724_read_eeprom(ice, modelname) < 0) {
                snd_vt1724_free(ice);
                return -EIO;
@@ -2243,20 +2435,18 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
                return -EIO;
        }
 
-       /* unmask used interrupts */
-       if (! (ice->eeprom.data[ICE_EEP2_SYSCONF] & VT1724_CFG_MPU401))
-               mask = VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX;
-       else
-               mask = 0;
-       outb(mask, ICEREG1724(ice, IRQMASK));
+       /* MPU_RX and TX irq masks are cleared later dynamically */
+       outb(VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX , ICEREG1724(ice, IRQMASK));
+
        /* don't handle FIFO overrun/underruns (just yet),
         * since they cause machine lockups
         */
        outb(VT1724_MULTI_FIFO_ERR, ICEMT1724(ice, DMA_INT_MASK));
 
-       if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, ice, &ops)) < 0) {
+       err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, ice, &ops);
+       if (err < 0) {
                snd_vt1724_free(ice);
-               return err;
+               return err;
        }
 
        snd_card_set_dev(card, &pci->dev);
@@ -2288,14 +2478,15 @@ static int __devinit snd_vt1724_probe(struct pci_dev *pci,
                return -ENOENT;
        }
 
-       card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
-       if (card == NULL)
-               return -ENOMEM;
+       err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
+       if (err < 0)
+               return err;
 
        strcpy(card->driver, "ICE1724");
        strcpy(card->shortname, "ICEnsemble ICE1724");
-       
-       if ((err = snd_vt1724_create(card, pci, model[dev], &ice)) < 0) {
+
+       err = snd_vt1724_create(card, pci, model[dev], &ice);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
@@ -2307,7 +2498,8 @@ static int __devinit snd_vt1724_probe(struct pci_dev *pci,
                                if (c->driver) /* specific driver? */
                                        strcpy(card->driver, c->driver);
                                if (c->chip_init) {
-                                       if ((err = c->chip_init(ice)) < 0) {
+                                       err = c->chip_init(ice);
+                                       if (err < 0) {
                                                snd_card_free(card);
                                                return err;
                                        }
@@ -2317,72 +2509,109 @@ static int __devinit snd_vt1724_probe(struct pci_dev *pci,
                }
        }
        c = &no_matched;
- __found:
-       /*
-        * VT1724 has separate DMAs for the analog and the SPDIF streams while
-        * ICE1712 has only one for both (mixed up).
-        *
-        * Confusingly the analog PCM is named "professional" here because it
-        * was called so in ice1712 driver, and vt1724 driver is derived from
-        * ice1712 driver.
-        */
-
-       if ((err = snd_vt1724_pcm_profi(ice, pcm_dev++)) < 0) {
+__found:
+       /*
+       * VT1724 has separate DMAs for the analog and the SPDIF streams while
+       * ICE1712 has only one for both (mixed up).
+       *
+       * Confusingly the analog PCM is named "professional" here because it
+       * was called so in ice1712 driver, and vt1724 driver is derived from
+       * ice1712 driver.
+       */
+       ice->pro_rate_default = PRO_RATE_DEFAULT;
+       if (!ice->is_spdif_master)
+               ice->is_spdif_master = stdclock_is_spdif_master;
+       if (!ice->get_rate)
+               ice->get_rate = stdclock_get_rate;
+       if (!ice->set_rate)
+               ice->set_rate = stdclock_set_rate;
+       if (!ice->set_mclk)
+               ice->set_mclk = stdclock_set_mclk;
+       if (!ice->set_spdif_clock)
+               ice->set_spdif_clock = stdclock_set_spdif_clock;
+       if (!ice->hw_rates)
+               set_std_hw_rates(ice);
+
+       err = snd_vt1724_pcm_profi(ice, pcm_dev++);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
-       
-       if ((err = snd_vt1724_pcm_spdif(ice, pcm_dev++)) < 0) {
+
+       err = snd_vt1724_pcm_spdif(ice, pcm_dev++);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
-       
-       if ((err = snd_vt1724_pcm_indep(ice, pcm_dev++)) < 0) {
+
+       err = snd_vt1724_pcm_indep(ice, pcm_dev++);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
 
-       if ((err = snd_vt1724_ac97_mixer(ice)) < 0) {
+       err = snd_vt1724_ac97_mixer(ice);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
 
-       if ((err = snd_vt1724_build_controls(ice)) < 0) {
+       err = snd_vt1724_build_controls(ice);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }
 
        if (ice->pcm && ice->has_spdif) { /* has SPDIF I/O */
-               if ((err = snd_vt1724_spdif_build_controls(ice)) < 0) {
+               err = snd_vt1724_spdif_build_controls(ice);
+               if (err < 0) {
                        snd_card_free(card);
                        return err;
                }
        }
 
        if (c->build_controls) {
-               if ((err = c->build_controls(ice)) < 0) {
+               err = c->build_controls(ice);
+               if (err < 0) {
                        snd_card_free(card);
                        return err;
                }
        }
 
-       if (! c->no_mpu401) {
+       if (!c->no_mpu401) {
                if (ice->eeprom.data[ICE_EEP2_SYSCONF] & VT1724_CFG_MPU401) {
-                       if ((err = snd_mpu401_uart_new(card, 0, MPU401_HW_ICE1712,
-                                                      ICEREG1724(ice, MPU_CTRL),
-                                                      MPU401_INFO_INTEGRATED,
-                                                      ice->irq, 0,
-                                                      &ice->rmidi[0])) < 0) {
+                       struct snd_rawmidi *rmidi;
+
+                       err = snd_rawmidi_new(card, "MIDI", 0, 1, 1, &rmidi);
+                       if (err < 0) {
                                snd_card_free(card);
                                return err;
                        }
+                       ice->rmidi[0] = rmidi;
+                       rmidi->private_data = ice;
+                       strcpy(rmidi->name, "ICE1724 MIDI");
+                       rmidi->info_flags = SNDRV_RAWMIDI_INFO_OUTPUT |
+                                           SNDRV_RAWMIDI_INFO_INPUT |
+                                           SNDRV_RAWMIDI_INFO_DUPLEX;
+                       snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT,
+                                           &vt1724_midi_output_ops);
+                       snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_INPUT,
+                                           &vt1724_midi_input_ops);
+
+                       /* set watermarks */
+                       outb(VT1724_MPU_RX_FIFO | 0x1,
+                            ICEREG1724(ice, MPU_FIFO_WM));
+                       outb(0x1, ICEREG1724(ice, MPU_FIFO_WM));
+                       /* set UART mode */
+                       outb(VT1724_MPU_UART, ICEREG1724(ice, MPU_CTRL));
                }
        }
 
        sprintf(card->longname, "%s at 0x%lx, irq %i",
                card->shortname, ice->port, ice->irq);
 
-       if ((err = snd_card_register(card)) < 0) {
+       err = snd_card_register(card);
+       if (err < 0) {
                snd_card_free(card);
                return err;
        }