vsprintf: use TOLOWER whenever possible
[safe/jmp/linux-2.6] / sound / isa / opl3sa2.c
index e2d615b..0481a55 100644 (file)
@@ -1,6 +1,6 @@
 /*
  *  Driver for Yamaha OPL3-SA[2,3] soundcards
- *  Copyright (c) by Jaroslav Kysela <perex@suse.cz>
+ *  Copyright (c) by Jaroslav Kysela <perex@perex.cz>
  *
  *
  *   This program is free software; you can redistribute it and/or modify
  *
  */
 
-#include <sound/driver.h>
 #include <linux/init.h>
+#include <linux/err.h>
+#include <linux/isa.h>
 #include <linux/interrupt.h>
 #include <linux/pm.h>
 #include <linux/slab.h>
 #include <linux/pnp.h>
 #include <linux/moduleparam.h>
 #include <sound/core.h>
-#include <sound/cs4231.h>
+#include <sound/wss.h>
 #include <sound/mpu401.h>
 #include <sound/opl3.h>
 #include <sound/initval.h>
+#include <sound/tlv.h>
 
 #include <asm/io.h>
 
-MODULE_AUTHOR("Jaroslav Kysela <perex@suse.cz>");
+MODULE_AUTHOR("Jaroslav Kysela <perex@perex.cz>");
 MODULE_DESCRIPTION("Yamaha OPL3SA2+");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{Yamaha,YMF719E-S},"
@@ -57,7 +59,7 @@ static long midi_port[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;/* 0x330,0x300 */
 static int irq[SNDRV_CARDS] = SNDRV_DEFAULT_IRQ;       /* 0,1,3,5,9,11,12,15 */
 static int dma1[SNDRV_CARDS] = SNDRV_DEFAULT_DMA;      /* 1,3,5,6,7 */
 static int dma2[SNDRV_CARDS] = SNDRV_DEFAULT_DMA;      /* 1,3,5,6,7 */
-static int opl3sa3_ymode[SNDRV_CARDS] = { [0 ... (SNDRV_CARDS-1)] = 0 };   /* 0,1,2,3 */ /*SL Added*/
+static int opl3sa3_ymode[SNDRV_CARDS];   /* 0,1,2,3 */ /*SL Added*/
 
 module_param_array(index, int, NULL, 0444);
 MODULE_PARM_DESC(index, "Index value for OPL3-SA soundcard.");
@@ -88,6 +90,12 @@ MODULE_PARM_DESC(dma2, "DMA2 # for OPL3-SA driver.");
 module_param_array(opl3sa3_ymode, int, NULL, 0444);
 MODULE_PARM_DESC(opl3sa3_ymode, "Speaker size selection for 3D Enhancement mode: Desktop/Large Notebook/Small Notebook/HiFi.");
 
+#ifdef CONFIG_PNP
+static int isa_registered;
+static int pnp_registered;
+static int pnpc_registered;
+#endif
+
 /* control ports */
 #define OPL3SA2_PM_CTRL                0x01
 #define OPL3SA2_SYS_CTRL               0x02
@@ -115,34 +123,22 @@ MODULE_PARM_DESC(opl3sa3_ymode, "Speaker size selection for 3D Enhancement mode:
 #define OPL3SA2_PM_D0  0x00
 #define OPL3SA2_PM_D3  (OPL3SA2_PM_ADOWN|OPL3SA2_PM_PSV|OPL3SA2_PM_PDN|OPL3SA2_PM_PDX)
 
-typedef struct snd_opl3sa2 opl3sa2_t;
-
 struct snd_opl3sa2 {
-       snd_card_t *card;
        int version;            /* 2 or 3 */
        unsigned long port;     /* control port */
        struct resource *res_port; /* control port resource */
        int irq;
        int single_dma;
        spinlock_t reg_lock;
-       snd_hwdep_t *synth;
-       snd_rawmidi_t *rmidi;
-       cs4231_t *cs4231;
-#ifdef CONFIG_PNP
-       struct pnp_dev *dev;
-#endif
+       struct snd_hwdep *synth;
+       struct snd_rawmidi *rmidi;
+       struct snd_wss *wss;
        unsigned char ctlregs[0x20];
        int ymode;              /* SL added */
-       snd_kcontrol_t *master_switch;
-       snd_kcontrol_t *master_volume;
-#ifdef CONFIG_PM
-       void (*cs4231_suspend)(cs4231_t *);
-       void (*cs4231_resume)(cs4231_t *);
-#endif
+       struct snd_kcontrol *master_switch;
+       struct snd_kcontrol *master_volume;
 };
 
-static snd_card_t *snd_opl3sa2_legacy[SNDRV_CARDS] = SNDRV_DEFAULT_PTR;
-
 #define PFX    "opl3sa2: "
 
 #ifdef CONFIG_PNP
@@ -166,6 +162,8 @@ static struct pnp_card_device_id snd_opl3sa2_pnpids[] = {
        { .id = "YMH0801", .devs = { { "YMH0021" } } },
        /* NeoMagic MagicWave 3DX */
        { .id = "NMX2200", .devs = { { "YMH2210" } } },
+       /* NeoMagic MagicWave 3D */
+       { .id = "NMX2200", .devs = { { "NMX2210" } } },
        /* --- */
        { .id = "" }    /* end */
 };
@@ -176,23 +174,24 @@ MODULE_DEVICE_TABLE(pnp_card, snd_opl3sa2_pnpids);
 
 
 /* read control port (w/o spinlock) */
-static unsigned char __snd_opl3sa2_read(opl3sa2_t *chip, unsigned char reg)
+static unsigned char __snd_opl3sa2_read(struct snd_opl3sa2 *chip, unsigned char reg)
 {
        unsigned char result;
 #if 0
        outb(0x1d, port);       /* password */
-       printk("read [0x%lx] = 0x%x\n", port, inb(port));
+       printk(KERN_DEBUG "read [0x%lx] = 0x%x\n", port, inb(port));
 #endif
        outb(reg, chip->port);  /* register */
        result = inb(chip->port + 1);
 #if 0
-       printk("read [0x%lx] = 0x%x [0x%x]\n", port, result, inb(port));
+       printk(KERN_DEBUG "read [0x%lx] = 0x%x [0x%x]\n",
+              port, result, inb(port));
 #endif
        return result;
 }
 
 /* read control port (with spinlock) */
-static unsigned char snd_opl3sa2_read(opl3sa2_t *chip, unsigned char reg)
+static unsigned char snd_opl3sa2_read(struct snd_opl3sa2 *chip, unsigned char reg)
 {
        unsigned long flags;
        unsigned char result;
@@ -204,7 +203,7 @@ static unsigned char snd_opl3sa2_read(opl3sa2_t *chip, unsigned char reg)
 }
 
 /* write control port (w/o spinlock) */
-static void __snd_opl3sa2_write(opl3sa2_t *chip, unsigned char reg, unsigned char value)
+static void __snd_opl3sa2_write(struct snd_opl3sa2 *chip, unsigned char reg, unsigned char value)
 {
 #if 0
        outb(0x1d, port);       /* password */
@@ -215,7 +214,7 @@ static void __snd_opl3sa2_write(opl3sa2_t *chip, unsigned char reg, unsigned cha
 }
 
 /* write control port (with spinlock) */
-static void snd_opl3sa2_write(opl3sa2_t *chip, unsigned char reg, unsigned char value)
+static void snd_opl3sa2_write(struct snd_opl3sa2 *chip, unsigned char reg, unsigned char value)
 {
        unsigned long flags;
        spin_lock_irqsave(&chip->reg_lock, flags);
@@ -223,20 +222,22 @@ static void snd_opl3sa2_write(opl3sa2_t *chip, unsigned char reg, unsigned char
        spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
-static int __init snd_opl3sa2_detect(opl3sa2_t *chip)
+static int __devinit snd_opl3sa2_detect(struct snd_card *card)
 {
-       snd_card_t *card;
+       struct snd_opl3sa2 *chip = card->private_data;
        unsigned long port;
        unsigned char tmp, tmp1;
        char str[2];
 
-       card = chip->card;
        port = chip->port;
        if ((chip->res_port = request_region(port, 2, "OPL3-SA control")) == NULL) {
                snd_printk(KERN_ERR PFX "can't grab port 0x%lx\n", port);
                return -EBUSY;
        }
-       // snd_printk("REG 0A = 0x%x\n", snd_opl3sa2_read(chip, 0x0a));
+       /*
+       snd_printk(KERN_DEBUG "REG 0A = 0x%x\n",
+                  snd_opl3sa2_read(chip, 0x0a));
+       */
        chip->version = 0;
        tmp = snd_opl3sa2_read(chip, OPL3SA2_MISC);
        if (tmp == 0xff) {
@@ -253,6 +254,7 @@ static int __init snd_opl3sa2_detect(opl3sa2_t *chip)
                /* 0x03 - YM715B */
                /* 0x04 - YM719 - OPL-SA4? */
                /* 0x05 - OPL3-SA3 - Libretto 100 */
+               /* 0x07 - unknown - Neomagic MagicWave 3D */
                break;
        }
        str[0] = chip->version + '0';
@@ -295,15 +297,17 @@ static int __init snd_opl3sa2_detect(opl3sa2_t *chip)
        return 0;
 }
 
-static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id)
 {
        unsigned short status;
-       opl3sa2_t *chip = dev_id;
+       struct snd_card *card = dev_id;
+       struct snd_opl3sa2 *chip;
        int handled = 0;
 
-       if (chip == NULL || chip->card == NULL)
+       if (card == NULL)
                return IRQ_NONE;
 
+       chip = card->private_data;
        status = snd_opl3sa2_read(chip, OPL3SA2_IRQ_STATUS);
 
        if (status & 0x20) {
@@ -313,12 +317,12 @@ static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id, struct pt_regs *
 
        if ((status & 0x10) && chip->rmidi != NULL) {
                handled = 1;
-               snd_mpu401_uart_interrupt(irq, chip->rmidi->private_data, regs);
+               snd_mpu401_uart_interrupt(irq, chip->rmidi->private_data);
        }
 
        if (status & 0x07) {    /* TI,CI,PI */
                handled = 1;
-               snd_cs4231_interrupt(irq, chip->cs4231, regs);
+               snd_wss_interrupt(irq, chip->wss);
        }
 
        if (status & 0x40) { /* hardware volume change */
@@ -327,8 +331,10 @@ static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id, struct pt_regs *
                snd_opl3sa2_read(chip, OPL3SA2_MASTER_RIGHT);
                snd_opl3sa2_read(chip, OPL3SA2_MASTER_LEFT);
                if (chip->master_switch && chip->master_volume) {
-                       snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE, &chip->master_switch->id);
-                       snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE, &chip->master_volume->id);
+                       snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE,
+                                       &chip->master_switch->id);
+                       snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE,
+                                       &chip->master_volume->id);
                }
        }
        return IRQ_RETVAL(handled);
@@ -336,24 +342,21 @@ static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id, struct pt_regs *
 
 #define OPL3SA2_SINGLE(xname, xindex, reg, shift, mask, invert) \
 { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
-  .info = snd_opl3sa2_info_single, \
+  .info = snd_wss_info_single, \
   .get = snd_opl3sa2_get_single, .put = snd_opl3sa2_put_single, \
   .private_value = reg | (shift << 8) | (mask << 16) | (invert << 24) }
+#define OPL3SA2_SINGLE_TLV(xname, xindex, reg, shift, mask, invert, xtlv) \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
+  .access = SNDRV_CTL_ELEM_ACCESS_READWRITE | SNDRV_CTL_ELEM_ACCESS_TLV_READ, \
+  .name = xname, .index = xindex, \
+  .info = snd_wss_info_single, \
+  .get = snd_opl3sa2_get_single, .put = snd_opl3sa2_put_single, \
+  .private_value = reg | (shift << 8) | (mask << 16) | (invert << 24), \
+  .tlv = { .p = (xtlv) } }
 
-static int snd_opl3sa2_info_single(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       int mask = (kcontrol->private_value >> 16) & 0xff;
-
-       uinfo->type = mask == 1 ? SNDRV_CTL_ELEM_TYPE_BOOLEAN : SNDRV_CTL_ELEM_TYPE_INTEGER;
-       uinfo->count = 1;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = mask;
-       return 0;
-}
-
-static int snd_opl3sa2_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_opl3sa2_get_single(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       opl3sa2_t *chip = snd_kcontrol_chip(kcontrol);
+       struct snd_opl3sa2 *chip = snd_kcontrol_chip(kcontrol);
        unsigned long flags;
        int reg = kcontrol->private_value & 0xff;
        int shift = (kcontrol->private_value >> 8) & 0xff;
@@ -368,9 +371,9 @@ static int snd_opl3sa2_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
        return 0;
 }
 
-static int snd_opl3sa2_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_opl3sa2_put_single(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       opl3sa2_t *chip = snd_kcontrol_chip(kcontrol);
+       struct snd_opl3sa2 *chip = snd_kcontrol_chip(kcontrol);
        unsigned long flags;
        int reg = kcontrol->private_value & 0xff;
        int shift = (kcontrol->private_value >> 8) & 0xff;
@@ -394,24 +397,21 @@ static int snd_opl3sa2_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
 
 #define OPL3SA2_DOUBLE(xname, xindex, left_reg, right_reg, shift_left, shift_right, mask, invert) \
 { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .index = xindex, \
-  .info = snd_opl3sa2_info_double, \
+  .info = snd_wss_info_double, \
   .get = snd_opl3sa2_get_double, .put = snd_opl3sa2_put_double, \
   .private_value = left_reg | (right_reg << 8) | (shift_left << 16) | (shift_right << 19) | (mask << 24) | (invert << 22) }
+#define OPL3SA2_DOUBLE_TLV(xname, xindex, left_reg, right_reg, shift_left, shift_right, mask, invert, xtlv) \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, \
+  .access = SNDRV_CTL_ELEM_ACCESS_READWRITE | SNDRV_CTL_ELEM_ACCESS_TLV_READ, \
+  .name = xname, .index = xindex, \
+  .info = snd_wss_info_double, \
+  .get = snd_opl3sa2_get_double, .put = snd_opl3sa2_put_double, \
+  .private_value = left_reg | (right_reg << 8) | (shift_left << 16) | (shift_right << 19) | (mask << 24) | (invert << 22), \
+  .tlv = { .p = (xtlv) } }
 
-static int snd_opl3sa2_info_double(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       int mask = (kcontrol->private_value >> 24) & 0xff;
-
-       uinfo->type = mask == 1 ? SNDRV_CTL_ELEM_TYPE_BOOLEAN : SNDRV_CTL_ELEM_TYPE_INTEGER;
-       uinfo->count = 2;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = mask;
-       return 0;
-}
-
-static int snd_opl3sa2_get_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_opl3sa2_get_double(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       opl3sa2_t *chip = snd_kcontrol_chip(kcontrol);
+       struct snd_opl3sa2 *chip = snd_kcontrol_chip(kcontrol);
        unsigned long flags;
        int left_reg = kcontrol->private_value & 0xff;
        int right_reg = (kcontrol->private_value >> 8) & 0xff;
@@ -431,9 +431,9 @@ static int snd_opl3sa2_get_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
        return 0;
 }
 
-static int snd_opl3sa2_put_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_opl3sa2_put_double(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       opl3sa2_t *chip = snd_kcontrol_chip(kcontrol);
+       struct snd_opl3sa2 *chip = snd_kcontrol_chip(kcontrol);
        unsigned long flags;
        int left_reg = kcontrol->private_value & 0xff;
        int right_reg = (kcontrol->private_value >> 8) & 0xff;
@@ -471,31 +471,37 @@ static int snd_opl3sa2_put_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
        return change;
 }
 
-static snd_kcontrol_new_t snd_opl3sa2_controls[] = {
+static const DECLARE_TLV_DB_SCALE(db_scale_master, -3000, 200, 0);
+static const DECLARE_TLV_DB_SCALE(db_scale_5bit_12db_max, -3450, 150, 0);
+
+static struct snd_kcontrol_new snd_opl3sa2_controls[] = {
 OPL3SA2_DOUBLE("Master Playback Switch", 0, 0x07, 0x08, 7, 7, 1, 1),
-OPL3SA2_DOUBLE("Master Playback Volume", 0, 0x07, 0x08, 0, 0, 15, 1),
+OPL3SA2_DOUBLE_TLV("Master Playback Volume", 0, 0x07, 0x08, 0, 0, 15, 1,
+                  db_scale_master),
 OPL3SA2_SINGLE("Mic Playback Switch", 0, 0x09, 7, 1, 1),
-OPL3SA2_SINGLE("Mic Playback Volume", 0, 0x09, 0, 31, 1)
+OPL3SA2_SINGLE_TLV("Mic Playback Volume", 0, 0x09, 0, 31, 1,
+                  db_scale_5bit_12db_max),
+OPL3SA2_SINGLE("ZV Port Switch", 0, 0x02, 0, 1, 0),
 };
 
-static snd_kcontrol_new_t snd_opl3sa2_tone_controls[] = {
+static struct snd_kcontrol_new snd_opl3sa2_tone_controls[] = {
 OPL3SA2_DOUBLE("3D Control - Wide", 0, 0x14, 0x14, 4, 0, 7, 0),
 OPL3SA2_DOUBLE("Tone Control - Bass", 0, 0x15, 0x15, 4, 0, 7, 0),
 OPL3SA2_DOUBLE("Tone Control - Treble", 0, 0x16, 0x16, 4, 0, 7, 0)
 };
 
-static void snd_opl3sa2_master_free(snd_kcontrol_t *kcontrol)
+static void snd_opl3sa2_master_free(struct snd_kcontrol *kcontrol)
 {
-       opl3sa2_t *chip = snd_kcontrol_chip(kcontrol);
+       struct snd_opl3sa2 *chip = snd_kcontrol_chip(kcontrol);
        chip->master_switch = NULL;
        chip->master_volume = NULL;
 }
 
-static int __init snd_opl3sa2_mixer(opl3sa2_t *chip)
+static int __devinit snd_opl3sa2_mixer(struct snd_card *card)
 {
-       snd_card_t *card = chip->card;
-       snd_ctl_elem_id_t id1, id2;
-       snd_kcontrol_t *kctl;
+       struct snd_opl3sa2 *chip = card->private_data;
+       struct snd_ctl_elem_id id1, id2;
+       struct snd_kcontrol *kctl;
        unsigned int idx;
        int err;
 
@@ -505,21 +511,29 @@ static int __init snd_opl3sa2_mixer(opl3sa2_t *chip)
        /* reassign AUX0 to CD */
         strcpy(id1.name, "Aux Playback Switch");
         strcpy(id2.name, "CD Playback Switch");
-        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0)
+        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0) {
+               snd_printk(KERN_ERR "Cannot rename opl3sa2 control\n");
                 return err;
+       }
         strcpy(id1.name, "Aux Playback Volume");
         strcpy(id2.name, "CD Playback Volume");
-        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0)
+        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0) {
+               snd_printk(KERN_ERR "Cannot rename opl3sa2 control\n");
                 return err;
+       }
        /* reassign AUX1 to FM */
         strcpy(id1.name, "Aux Playback Switch"); id1.index = 1;
         strcpy(id2.name, "FM Playback Switch");
-        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0)
+        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0) {
+               snd_printk(KERN_ERR "Cannot rename opl3sa2 control\n");
                 return err;
+       }
         strcpy(id1.name, "Aux Playback Volume");
         strcpy(id2.name, "FM Playback Volume");
-        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0)
+        if ((err = snd_ctl_rename_id(card, &id1, &id2)) < 0) {
+               snd_printk(KERN_ERR "Cannot rename opl3sa2 control\n");
                 return err;
+       }
        /* add OPL3SA2 controls */
        for (idx = 0; idx < ARRAY_SIZE(snd_opl3sa2_controls); idx++) {
                if ((err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_opl3sa2_controls[idx], chip))) < 0)
@@ -539,24 +553,29 @@ static int __init snd_opl3sa2_mixer(opl3sa2_t *chip)
 
 /* Power Management support functions */
 #ifdef CONFIG_PM
-static int snd_opl3sa2_suspend(snd_card_t *card, pm_message_t state)
+static int snd_opl3sa2_suspend(struct snd_card *card, pm_message_t state)
 {
-       opl3sa2_t *chip = card->pm_private_data;
-
-       snd_pcm_suspend_all(chip->cs4231->pcm); /* stop before saving regs */
-       chip->cs4231_suspend(chip->cs4231);
+       if (card) {
+               struct snd_opl3sa2 *chip = card->private_data;
 
-       /* power down */
-       snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D3);
+               snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+               chip->wss->suspend(chip->wss);
+               /* power down */
+               snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D3);
+       }
 
        return 0;
 }
 
-static int snd_opl3sa2_resume(snd_card_t *card)
+static int snd_opl3sa2_resume(struct snd_card *card)
 {
-       opl3sa2_t *chip = card->pm_private_data;
+       struct snd_opl3sa2 *chip;
        int i;
 
+       if (!card)
+               return 0;
+
+       chip = card->private_data;
        /* power up */
        snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D0);
 
@@ -569,52 +588,20 @@ static int snd_opl3sa2_resume(snd_card_t *card)
                for (i = 0x12; i <= 0x16; i++)
                        snd_opl3sa2_write(chip, i, chip->ctlregs[i]);
        }
-       /* restore cs4231 */
-       chip->cs4231_resume(chip->cs4231);
+       /* restore wss */
+       chip->wss->resume(chip->wss);
 
+       snd_power_change_state(card, SNDRV_CTL_POWER_D0);
        return 0;
 }
 #endif /* CONFIG_PM */
 
 #ifdef CONFIG_PNP
-static int __init snd_opl3sa2_pnp(int dev, opl3sa2_t *chip,
-                                 struct pnp_dev *pdev,
-                                 int isapnp)
+static int __devinit snd_opl3sa2_pnp(int dev, struct snd_opl3sa2 *chip,
+                                    struct pnp_dev *pdev)
 {
-       struct pnp_resource_table * cfg;
-       int err;
-
-       if (!isapnp && pnp_device_is_isapnp(pdev))
-               return -ENOENT; /* we have another procedure - card */
-
-       cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
-       if (!cfg)
-               return -ENOMEM;
-       /* PnP initialization */
-       pnp_init_resource_table(cfg);
-       if (sb_port[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[0], sb_port[dev], 16);
-       if (wss_port[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[1], wss_port[dev], 8);
-       if (fm_port[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[2], fm_port[dev], 4);
-       if (midi_port[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[3], midi_port[dev], 2);
-       if (port[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[4], port[dev], 2);
-       if (dma1[dev] != SNDRV_AUTO_DMA)
-               pnp_resource_change(&cfg->dma_resource[0], dma1[dev], 1);
-       if (dma2[dev] != SNDRV_AUTO_DMA)
-               pnp_resource_change(&cfg->dma_resource[1], dma2[dev], 1);
-       if (irq[dev] != SNDRV_AUTO_IRQ)
-               pnp_resource_change(&cfg->irq_resource[0], irq[dev], 1);
-       err = pnp_manual_config_dev(pdev, cfg, 0);
-       if (err < 0 && isapnp)
-               snd_printk(KERN_ERR "PnP manual resources are invalid, using auto config\n");
-       err = pnp_activate_dev(pdev);
-       if (err < 0) {
-               kfree(cfg);
-               snd_printk(KERN_ERR "PnP configure failure (out of resources?) err = %d\n", err);
+       if (pnp_activate_dev(pdev) < 0) {
+               snd_printk(KERN_ERR "PnP configure failure (out of resources?)\n");
                return -EBUSY;
        }
        sb_port[dev] = pnp_port_start(pdev, 0);
@@ -629,307 +616,355 @@ static int __init snd_opl3sa2_pnp(int dev, opl3sa2_t *chip,
                pnp_device_is_pnpbios(pdev) ? "BIOS" : "ISA", sb_port[dev], wss_port[dev], fm_port[dev], midi_port[dev]);
        snd_printdd("%sPnP OPL3-SA: control port=0x%lx, dma1=%i, dma2=%i, irq=%i\n",
                pnp_device_is_pnpbios(pdev) ? "BIOS" : "ISA", port[dev], dma1[dev], dma2[dev], irq[dev]);
-       kfree(cfg);
-       chip->dev = pdev;
        return 0;
 }
-
-static int __init snd_opl3sa2_cpnp(int dev, opl3sa2_t *chip,
-                                  struct pnp_card_link *card,
-                                  const struct pnp_card_device_id *id)
-{
-       struct pnp_dev *pdev;
-       struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
-
-       if (!cfg)
-               return -ENOMEM;
-       pdev = pnp_request_card_device(card, id->devs[0].id, NULL);
-       if (pdev == NULL) {
-               kfree(cfg);
-               return -EBUSY;
-       }
-       return snd_opl3sa2_pnp(dev, chip, pdev, 1);
-}
 #endif /* CONFIG_PNP */
 
-static int snd_opl3sa2_free(opl3sa2_t *chip)
+static void snd_opl3sa2_free(struct snd_card *card)
 {
+       struct snd_opl3sa2 *chip = card->private_data;
        if (chip->irq >= 0)
-               free_irq(chip->irq, (void *)chip);
-       if (chip->res_port) {
-               release_resource(chip->res_port);
-               kfree_nocheck(chip->res_port);
-       }
-       kfree(chip);
-       return 0;
+               free_irq(chip->irq, card);
+       release_and_free_resource(chip->res_port);
 }
 
-static int snd_opl3sa2_dev_free(snd_device_t *device)
+static int snd_opl3sa2_card_new(int dev, struct snd_card **cardp)
 {
-       opl3sa2_t *chip = device->device_data;
-       return snd_opl3sa2_free(chip);
-}
+       struct snd_card *card;
+       struct snd_opl3sa2 *chip;
+       int err;
 
-#ifdef CONFIG_PNP
-#define is_isapnp_selected(dev)                isapnp[dev]
-#else
-#define is_isapnp_selected(dev)                0
-#endif
+       err = snd_card_create(index[dev], id[dev], THIS_MODULE,
+                             sizeof(struct snd_opl3sa2), &card);
+       if (err < 0)
+               return err;
+       strcpy(card->driver, "OPL3SA2");
+       strcpy(card->shortname, "Yamaha OPL3-SA");
+       chip = card->private_data;
+       spin_lock_init(&chip->reg_lock);
+       chip->irq = -1;
+       card->private_free = snd_opl3sa2_free;
+       *cardp = card;
+       return 0;
+}
 
-static int __devinit snd_opl3sa2_probe(int dev,
-                                      struct pnp_dev *pdev,
-                                      struct pnp_card_link *pcard,
-                                      const struct pnp_card_device_id *pid)
+static int __devinit snd_opl3sa2_probe(struct snd_card *card, int dev)
 {
        int xirq, xdma1, xdma2;
-       snd_card_t *card;
        struct snd_opl3sa2 *chip;
-       cs4231_t *cs4231;
-       opl3_t *opl3;
-       static snd_device_ops_t ops = {
-               .dev_free =     snd_opl3sa2_dev_free,
-       };
+       struct snd_wss *wss;
+       struct snd_opl3 *opl3;
        int err;
 
-       if (! is_isapnp_selected(dev)) {
-               if (port[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify port\n");
-                       return -EINVAL;
-               }
-               if (wss_port[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify wss_port\n");
-                       return -EINVAL;
-               }
-               if (fm_port[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify fm_port\n");
-                       return -EINVAL;
-               }
-               if (midi_port[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify midi_port\n");
-                       return -EINVAL;
-               }
-       }
-
-       card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
-       if (card == NULL)
-               return -ENOMEM;
-       strcpy(card->driver, "OPL3SA2");
-       strcpy(card->shortname, "Yamaha OPL3-SA2");
-       chip = kcalloc(1, sizeof(*chip), GFP_KERNEL);
-       if (chip == NULL) {
-               err = -ENOMEM;
-               goto __error;
-       }
-       spin_lock_init(&chip->reg_lock);
-       chip->irq = -1;
-       if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0)
-               goto __error;
-#ifdef CONFIG_PNP
-       if (pdev) {
-               if ((err = snd_opl3sa2_pnp(dev, chip, pdev, 0)) < 0)
-                       goto __error;
-               snd_card_set_dev(card, &pdev->dev);
-       }
-       if (pcard) {
-               if ((err = snd_opl3sa2_cpnp(dev, chip, pcard, pid)) < 0)
-                       goto __error;
-               snd_card_set_dev(card, &pcard->card->dev);
-       }
-#endif
-       chip->ymode = opl3sa3_ymode[dev] & 0x03 ; /* initialise this card from supplied (or default) parameter*/ 
-       chip->card = card;
+       /* initialise this card from supplied (or default) parameter*/ 
+       chip = card->private_data;
+       chip->ymode = opl3sa3_ymode[dev] & 0x03 ;
        chip->port = port[dev];
        xirq = irq[dev];
        xdma1 = dma1[dev];
        xdma2 = dma2[dev];
        if (xdma2 < 0)
                chip->single_dma = 1;
-       if ((err = snd_opl3sa2_detect(chip)) < 0)
-               goto __error;
-       if (request_irq(xirq, snd_opl3sa2_interrupt, SA_INTERRUPT, "OPL3-SA2", (void *)chip)) {
+       err = snd_opl3sa2_detect(card);
+       if (err < 0)
+               return err;
+       err = request_irq(xirq, snd_opl3sa2_interrupt, IRQF_DISABLED,
+                         "OPL3-SA2", card);
+       if (err) {
                snd_printk(KERN_ERR PFX "can't grab IRQ %d\n", xirq);
-               err = -ENODEV;
-               goto __error;
+               return -ENODEV;
        }
        chip->irq = xirq;
-       if ((err = snd_cs4231_create(card,
-                                    wss_port[dev] + 4, -1,
-                                    xirq, xdma1, xdma2,
-                                    CS4231_HW_OPL3SA2,
-                                    CS4231_HWSHARE_IRQ,
-                                    &cs4231)) < 0) {
+       err = snd_wss_create(card,
+                            wss_port[dev] + 4, -1,
+                            xirq, xdma1, xdma2,
+                            WSS_HW_OPL3SA2, WSS_HWSHARE_IRQ, &wss);
+       if (err < 0) {
                snd_printd("Oops, WSS not detected at 0x%lx\n", wss_port[dev] + 4);
-               goto __error;
-       }
-       chip->cs4231 = cs4231;
-       if ((err = snd_cs4231_pcm(cs4231, 0, NULL)) < 0)
-               goto __error;
-       if ((err = snd_cs4231_mixer(cs4231)) < 0)
-               goto __error;
-       if ((err = snd_opl3sa2_mixer(chip)) < 0)
-               goto __error;
-       if ((err = snd_cs4231_timer(cs4231, 0, NULL)) < 0)
-               goto __error;
+               return err;
+       }
+       chip->wss = wss;
+       err = snd_wss_pcm(wss, 0, NULL);
+       if (err < 0)
+               return err;
+       err = snd_wss_mixer(wss);
+       if (err < 0)
+               return err;
+       err = snd_opl3sa2_mixer(card);
+       if (err < 0)
+               return err;
+       err = snd_wss_timer(wss, 0, NULL);
+       if (err < 0)
+               return err;
        if (fm_port[dev] >= 0x340 && fm_port[dev] < 0x400) {
                if ((err = snd_opl3_create(card, fm_port[dev],
                                           fm_port[dev] + 2,
                                           OPL3_HW_OPL3, 0, &opl3)) < 0)
-                       goto __error;
+                       return err;
                if ((err = snd_opl3_timer_new(opl3, 1, 2)) < 0)
-                       goto __error;
+                       return err;
                if ((err = snd_opl3_hwdep_new(opl3, 0, 1, &chip->synth)) < 0)
-                       goto __error;
+                       return err;
        }
        if (midi_port[dev] >= 0x300 && midi_port[dev] < 0x340) {
                if ((err = snd_mpu401_uart_new(card, 0, MPU401_HW_OPL3SA2,
                                               midi_port[dev], 0,
                                               xirq, 0, &chip->rmidi)) < 0)
-                       goto __error;
+                       return err;
        }
-#ifdef CONFIG_PM
-       chip->cs4231_suspend = chip->cs4231->suspend;
-       chip->cs4231_resume = chip->cs4231->resume;
-       /* now clear callbacks for cs4231 */
-       chip->cs4231->suspend = NULL;
-       chip->cs4231->resume = NULL;
-       snd_card_set_isa_pm_callback(card, snd_opl3sa2_suspend, snd_opl3sa2_resume, chip);
-#endif
-
        sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d",
                card->shortname, chip->port, xirq, xdma1);
-       if (dma2 >= 0)
+       if (xdma2 >= 0)
                sprintf(card->longname + strlen(card->longname), "&%d", xdma2);
 
-       if ((err = snd_card_set_generic_dev(card)) < 0)
-               goto __error;
-
-       if ((err = snd_card_register(card)) < 0)
-               goto __error;
-
-       if (pdev)
-               pnp_set_drvdata(pdev, card);
-       else if (pcard)
-               pnp_set_card_drvdata(pcard, card);
-       else
-               snd_opl3sa2_legacy[dev] = card;
-       return 0;
-
- __error:
-       snd_card_free(card);
-       return err;
+       return snd_card_register(card);
 }
 
 #ifdef CONFIG_PNP
 static int __devinit snd_opl3sa2_pnp_detect(struct pnp_dev *pdev,
                                            const struct pnp_device_id *id)
 {
-        static int dev;
-        int res;
+       static int dev;
+       int err;
+       struct snd_card *card;
 
-        for ( ; dev < SNDRV_CARDS; dev++) {
-                if (!enable[dev] || !isapnp[dev])
-                        continue;
-                res = snd_opl3sa2_probe(dev, pdev, NULL, NULL);
-                if (res < 0)
-                        return res;
-                dev++;
-                return 0;
-        }
-        return -ENODEV;
+       if (pnp_device_is_isapnp(pdev))
+               return -ENOENT; /* we have another procedure - card */
+       for (; dev < SNDRV_CARDS; dev++) {
+               if (enable[dev] && isapnp[dev])
+                       break;
+       }
+       if (dev >= SNDRV_CARDS)
+               return -ENODEV;
+
+       err = snd_opl3sa2_card_new(dev, &card);
+       if (err < 0)
+               return err;
+       if ((err = snd_opl3sa2_pnp(dev, card->private_data, pdev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       snd_card_set_dev(card, &pdev->dev);
+       if ((err = snd_opl3sa2_probe(card, dev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       pnp_set_drvdata(pdev, card);
+       dev++;
+       return 0;
 }
 
 static void __devexit snd_opl3sa2_pnp_remove(struct pnp_dev * pdev)
 {
-       snd_card_t *card = (snd_card_t *) pnp_get_drvdata(pdev);
-        
-       snd_card_disconnect(card);
-       snd_card_free_in_thread(card);
+       snd_card_free(pnp_get_drvdata(pdev));
+       pnp_set_drvdata(pdev, NULL);
 }
 
+#ifdef CONFIG_PM
+static int snd_opl3sa2_pnp_suspend(struct pnp_dev *pdev, pm_message_t state)
+{
+       return snd_opl3sa2_suspend(pnp_get_drvdata(pdev), state);
+}
+static int snd_opl3sa2_pnp_resume(struct pnp_dev *pdev)
+{
+       return snd_opl3sa2_resume(pnp_get_drvdata(pdev));
+}
+#endif
+
 static struct pnp_driver opl3sa2_pnp_driver = {
-       .name = "opl3sa2-pnpbios",
+       .name = "snd-opl3sa2-pnpbios",
        .id_table = snd_opl3sa2_pnpbiosids,
        .probe = snd_opl3sa2_pnp_detect,
        .remove = __devexit_p(snd_opl3sa2_pnp_remove),
+#ifdef CONFIG_PM
+       .suspend = snd_opl3sa2_pnp_suspend,
+       .resume = snd_opl3sa2_pnp_resume,
+#endif
 };
 
-static int __devinit snd_opl3sa2_pnp_cdetect(struct pnp_card_link *card,
+static int __devinit snd_opl3sa2_pnp_cdetect(struct pnp_card_link *pcard,
                                             const struct pnp_card_device_id *id)
 {
-        static int dev;
-        int res;
+       static int dev;
+       struct pnp_dev *pdev;
+       int err;
+       struct snd_card *card;
 
-        for ( ; dev < SNDRV_CARDS; dev++) {
-               if (!enable[dev])
-                       continue;
-               if (is_isapnp_selected(dev))
-                       continue;
-                res = snd_opl3sa2_probe(dev, NULL, card, id);
-                if (res < 0)
-                        return res;
-                dev++;
-                return 0;
-        }
-        return -ENODEV;
+       pdev = pnp_request_card_device(pcard, id->devs[0].id, NULL);
+       if (pdev == NULL) {
+               snd_printk(KERN_ERR PFX "can't get pnp device from id '%s'\n",
+                          id->devs[0].id);
+               return -EBUSY;
+       }
+       for (; dev < SNDRV_CARDS; dev++) {
+               if (enable[dev] && isapnp[dev])
+                       break;
+       }
+       if (dev >= SNDRV_CARDS)
+               return -ENODEV;
+
+       err = snd_opl3sa2_card_new(dev, &card);
+       if (err < 0)
+               return err;
+       if ((err = snd_opl3sa2_pnp(dev, card->private_data, pdev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       snd_card_set_dev(card, &pdev->dev);
+       if ((err = snd_opl3sa2_probe(card, dev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       pnp_set_card_drvdata(pcard, card);
+       dev++;
+       return 0;
 }
 
 static void __devexit snd_opl3sa2_pnp_cremove(struct pnp_card_link * pcard)
 {
-       snd_card_t *card = (snd_card_t *) pnp_get_card_drvdata(pcard);
-        
-       snd_card_disconnect(card);
-       snd_card_free_in_thread(card);
+       snd_card_free(pnp_get_card_drvdata(pcard));
+       pnp_set_card_drvdata(pcard, NULL);
 }
 
+#ifdef CONFIG_PM
+static int snd_opl3sa2_pnp_csuspend(struct pnp_card_link *pcard, pm_message_t state)
+{
+       return snd_opl3sa2_suspend(pnp_get_card_drvdata(pcard), state);
+}
+static int snd_opl3sa2_pnp_cresume(struct pnp_card_link *pcard)
+{
+       return snd_opl3sa2_resume(pnp_get_card_drvdata(pcard));
+}
+#endif
+
 static struct pnp_card_driver opl3sa2_pnpc_driver = {
        .flags = PNP_DRIVER_RES_DISABLE,
-       .name = "opl3sa2",
+       .name = "snd-opl3sa2-cpnp",
        .id_table = snd_opl3sa2_pnpids,
        .probe = snd_opl3sa2_pnp_cdetect,
        .remove = __devexit_p(snd_opl3sa2_pnp_cremove),
+#ifdef CONFIG_PM
+       .suspend = snd_opl3sa2_pnp_csuspend,
+       .resume = snd_opl3sa2_pnp_cresume,
+#endif
 };
 #endif /* CONFIG_PNP */
 
-static int __init alsa_card_opl3sa2_init(void)
+static int __devinit snd_opl3sa2_isa_match(struct device *pdev,
+                                          unsigned int dev)
 {
-       int dev, cards = 0;
-
-       for (dev = 0; dev < SNDRV_CARDS; dev++) {
-               if (!enable[dev])
-                       continue;
+       if (!enable[dev])
+               return 0;
 #ifdef CONFIG_PNP
-               if (isapnp[dev])
-                       continue;
+       if (isapnp[dev])
+               return 0;
 #endif
-               if (snd_opl3sa2_probe(dev, NULL, NULL, NULL) >= 0)
-                       cards++;
+       if (port[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify port\n");
+               return 0;
        }
-#ifdef CONFIG_PNP
-       cards += pnp_register_driver(&opl3sa2_pnp_driver);
-       cards += pnp_register_card_driver(&opl3sa2_pnpc_driver);
+       if (wss_port[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify wss_port\n");
+               return 0;
+       }
+       if (fm_port[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify fm_port\n");
+               return 0;
+       }
+       if (midi_port[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify midi_port\n");
+               return 0;
+       }
+       return 1;
+}
+
+static int __devinit snd_opl3sa2_isa_probe(struct device *pdev,
+                                          unsigned int dev)
+{
+       struct snd_card *card;
+       int err;
+
+       err = snd_opl3sa2_card_new(dev, &card);
+       if (err < 0)
+               return err;
+       snd_card_set_dev(card, pdev);
+       if ((err = snd_opl3sa2_probe(card, dev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       dev_set_drvdata(pdev, card);
+       return 0;
+}
+
+static int __devexit snd_opl3sa2_isa_remove(struct device *devptr,
+                                           unsigned int dev)
+{
+       snd_card_free(dev_get_drvdata(devptr));
+       dev_set_drvdata(devptr, NULL);
+       return 0;
+}
+
+#ifdef CONFIG_PM
+static int snd_opl3sa2_isa_suspend(struct device *dev, unsigned int n,
+                                  pm_message_t state)
+{
+       return snd_opl3sa2_suspend(dev_get_drvdata(dev), state);
+}
+
+static int snd_opl3sa2_isa_resume(struct device *dev, unsigned int n)
+{
+       return snd_opl3sa2_resume(dev_get_drvdata(dev));
+}
 #endif
-       if (!cards) {
-#ifdef MODULE
-               snd_printk(KERN_ERR "Yamaha OPL3-SA soundcard not found or device busy\n");
+
+#define DEV_NAME "opl3sa2"
+
+static struct isa_driver snd_opl3sa2_isa_driver = {
+       .match          = snd_opl3sa2_isa_match,
+       .probe          = snd_opl3sa2_isa_probe,
+       .remove         = __devexit_p(snd_opl3sa2_isa_remove),
+#ifdef CONFIG_PM
+       .suspend        = snd_opl3sa2_isa_suspend,
+       .resume         = snd_opl3sa2_isa_resume,
 #endif
+       .driver         = {
+               .name   = DEV_NAME
+       },
+};
+
+static int __init alsa_card_opl3sa2_init(void)
+{
+       int err;
+
+       err = isa_register_driver(&snd_opl3sa2_isa_driver, SNDRV_CARDS);
 #ifdef CONFIG_PNP
-               pnp_unregister_card_driver(&opl3sa2_pnpc_driver);
+       if (!err)
+               isa_registered = 1;
+
+       err = pnp_register_driver(&opl3sa2_pnp_driver);
+       if (!err)
+               pnp_registered = 1;
+
+       err = pnp_register_card_driver(&opl3sa2_pnpc_driver);
+       if (!err)
+               pnpc_registered = 1;
+
+       if (isa_registered || pnp_registered)
+               err = 0;
 #endif
-               return -ENODEV;
-       }
-       return 0;
+       return err;
 }
 
 static void __exit alsa_card_opl3sa2_exit(void)
 {
-       int idx;
-
 #ifdef CONFIG_PNP
-       /* PnP cards first */
-       pnp_unregister_card_driver(&opl3sa2_pnpc_driver);
+       if (pnpc_registered)
+               pnp_unregister_card_driver(&opl3sa2_pnpc_driver);
+       if (pnp_registered)
+               pnp_unregister_driver(&opl3sa2_pnp_driver);
+       if (isa_registered)
 #endif
-       for (idx = 0; idx < SNDRV_CARDS; idx++)
-               snd_card_free(snd_opl3sa2_legacy[idx]);
+               isa_unregister_driver(&snd_opl3sa2_isa_driver);
 }
 
 module_init(alsa_card_opl3sa2_init)