Merge branch 'fix/hda' into for-linus
[safe/jmp/linux-2.6] / sound / isa / cmi8330.c
index 5252206..de83608 100644 (file)
  *  To quickly load the module,
  *
  *  modprobe -a snd-cmi8330 sbport=0x220 sbirq=5 sbdma8=1
- *    sbdma16=5 wssport=0x530 wssirq=11 wssdma=0
+ *    sbdma16=5 wssport=0x530 wssirq=11 wssdma=0 fmport=0x388
  *
  *  This card has two mixers and two PCM devices.  I've cheesed it such
  *  that recording and playback can be done through the same device.
- *  The driver "magically" routes the capturing to the AD1848 codec,
+ *  The driver "magically" routes the capturing to the CMI8330 codec,
  *  and playback to the SB16 codec.  This allows for full-duplex mode
  *  to some extent.
  *  The utilities in alsa-utils are aware of both devices, so passing
  *  full control over both mixers.
  */
 
-#include <sound/driver.h>
 #include <linux/init.h>
+#include <linux/err.h>
+#include <linux/isa.h>
 #include <linux/slab.h>
 #include <linux/pnp.h>
 #include <linux/moduleparam.h>
 #include <sound/core.h>
-#include <sound/ad1848.h>
+#include <sound/wss.h>
+#include <sound/opl3.h>
+#include <sound/mpu401.h>
 #include <sound/sb.h>
 #include <sound/initval.h>
 
@@ -78,6 +81,9 @@ static int sbdma16[SNDRV_CARDS] = SNDRV_DEFAULT_DMA;
 static long wssport[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;
 static int wssirq[SNDRV_CARDS] = SNDRV_DEFAULT_IRQ;
 static int wssdma[SNDRV_CARDS] = SNDRV_DEFAULT_DMA;
+static long fmport[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;
+static long mpuport[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;
+static int mpuirq[SNDRV_CARDS] = SNDRV_DEFAULT_IRQ;
 
 module_param_array(index, int, NULL, 0444);
 MODULE_PARM_DESC(index, "Index value for CMI8330 soundcard.");
@@ -106,6 +112,17 @@ MODULE_PARM_DESC(wssirq, "IRQ # for CMI8330 WSS driver.");
 module_param_array(wssdma, int, NULL, 0444);
 MODULE_PARM_DESC(wssdma, "DMA for CMI8330 WSS driver.");
 
+module_param_array(fmport, long, NULL, 0444);
+MODULE_PARM_DESC(fmport, "FM port # for CMI8330 driver.");
+module_param_array(mpuport, long, NULL, 0444);
+MODULE_PARM_DESC(mpuport, "MPU-401 port # for CMI8330 driver.");
+module_param_array(mpuirq, int, NULL, 0444);
+MODULE_PARM_DESC(mpuirq, "IRQ # for CMI8330 MPU-401 port.");
+#ifdef CONFIG_PNP
+static int isa_registered;
+static int pnp_registered;
+#endif
+
 #define CMI8330_RMUX3D    16
 #define CMI8330_MUTEMUX   17
 #define CMI8330_OUTPUTVOL 18
@@ -137,31 +154,30 @@ static unsigned char snd_cmi8330_image[((CMI8330_CDINGAIN)-16) + 1] =
        0x0                     /* 26 - cd-in rec gain */
 };
 
-typedef int (*snd_pcm_open_callback_t)(snd_pcm_substream_t *);
+typedef int (*snd_pcm_open_callback_t)(struct snd_pcm_substream *);
 
 struct snd_cmi8330 {
 #ifdef CONFIG_PNP
        struct pnp_dev *cap;
        struct pnp_dev *play;
+       struct pnp_dev *mpu;
 #endif
-       snd_card_t *card;
-       ad1848_t *wss;
-       sb_t *sb;
+       struct snd_card *card;
+       struct snd_wss *wss;
+       struct snd_sb *sb;
 
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        struct snd_cmi8330_stream {
-               snd_pcm_ops_t ops;
+               struct snd_pcm_ops ops;
                snd_pcm_open_callback_t open;
                void *private_data; /* sb or wss */
        } streams[2];
 };
 
-static snd_card_t *snd_cmi8330_legacy[SNDRV_CARDS] = SNDRV_DEFAULT_PTR;
-
 #ifdef CONFIG_PNP
 
 static struct pnp_card_device_id snd_cmi8330_pnpids[] = {
-       { .id = "CMI0001", .devs = { { "@@@0001" }, { "@X@0001" } } },
+       { .id = "CMI0001", .devs = { { "@@@0001" }, { "@X@0001" }, { "@H@0001" } } },
        { .id = "" }
 };
 
@@ -170,36 +186,63 @@ MODULE_DEVICE_TABLE(pnp_card, snd_cmi8330_pnpids);
 #endif
 
 
-static struct ad1848_mix_elem snd_cmi8330_controls[] __initdata = {
-AD1848_DOUBLE("Master Playback Volume", 0, CMI8330_MASTVOL, CMI8330_MASTVOL, 4, 0, 15, 0),
-AD1848_SINGLE("Loud Playback Switch", 0, CMI8330_MUTEMUX, 6, 1, 1),
-AD1848_DOUBLE("PCM Playback Switch", 0, AD1848_LEFT_OUTPUT, AD1848_RIGHT_OUTPUT, 7, 7, 1, 1),
-AD1848_DOUBLE("PCM Playback Volume", 0, AD1848_LEFT_OUTPUT, AD1848_RIGHT_OUTPUT, 0, 0, 63, 1),
-AD1848_DOUBLE("Line Playback Switch", 0, CMI8330_MUTEMUX, CMI8330_MUTEMUX, 4, 3, 1, 0),
-AD1848_DOUBLE("Line Playback Volume", 0, CMI8330_LINVOL, CMI8330_LINVOL, 4, 0, 15, 0),
-AD1848_DOUBLE("Line Capture Switch", 0, CMI8330_RMUX3D, CMI8330_RMUX3D, 2, 1, 1, 0),
-AD1848_DOUBLE("Line Capture Volume", 0, CMI8330_LINGAIN, CMI8330_LINGAIN, 4, 0, 15, 0),
-AD1848_DOUBLE("CD Playback Switch", 0, CMI8330_MUTEMUX, CMI8330_MUTEMUX, 2, 1, 1, 0),
-AD1848_DOUBLE("CD Capture Switch", 0, CMI8330_RMUX3D, CMI8330_RMUX3D, 4, 3, 1, 0),
-AD1848_DOUBLE("CD Playback Volume", 0, CMI8330_CDINVOL, CMI8330_CDINVOL, 4, 0, 15, 0),
-AD1848_DOUBLE("CD Capture Volume", 0, CMI8330_CDINGAIN, CMI8330_CDINGAIN, 4, 0, 15, 0),
-AD1848_SINGLE("Mic Playback Switch", 0, CMI8330_MUTEMUX, 0, 1, 0),
-AD1848_SINGLE("Mic Playback Volume", 0, CMI8330_OUTPUTVOL, 0, 7, 0),
-AD1848_SINGLE("Mic Capture Switch", 0, CMI8330_RMUX3D, 0, 1, 0),
-AD1848_SINGLE("Mic Capture Volume", 0, CMI8330_OUTPUTVOL, 5, 7, 0),
-AD1848_DOUBLE("Wavetable Playback Switch", 0, CMI8330_RECMUX, CMI8330_RECMUX, 1, 0, 1, 0),
-AD1848_DOUBLE("Wavetable Playback Volume", 0, CMI8330_WAVVOL, CMI8330_WAVVOL, 4, 0, 15, 0),
-AD1848_DOUBLE("Wavetable Capture Switch", 0, CMI8330_RECMUX, CMI8330_RECMUX, 5, 4, 1, 0),
-AD1848_DOUBLE("Wavetable Capture Volume", 0, CMI8330_WAVGAIN, CMI8330_WAVGAIN, 4, 0, 15, 0),
-AD1848_SINGLE("3D Control - Switch", 0, CMI8330_RMUX3D, 5, 1, 1),
-AD1848_SINGLE("PC Speaker Playback Volume", 0, CMI8330_OUTPUTVOL, 3, 3, 0),
-AD1848_SINGLE("FM Playback Switch", 0, CMI8330_RECMUX, 3, 1, 1),
-AD1848_SINGLE(SNDRV_CTL_NAME_IEC958("Input ",CAPTURE,SWITCH), 0, CMI8330_RMUX3D, 7, 1, 1),
-AD1848_SINGLE(SNDRV_CTL_NAME_IEC958("Input ",PLAYBACK,SWITCH), 0, CMI8330_MUTEMUX, 7, 1, 1),
+static struct snd_kcontrol_new snd_cmi8330_controls[] __devinitdata = {
+WSS_DOUBLE("Master Playback Volume", 0,
+               CMI8330_MASTVOL, CMI8330_MASTVOL, 4, 0, 15, 0),
+WSS_SINGLE("Loud Playback Switch", 0,
+               CMI8330_MUTEMUX, 6, 1, 1),
+WSS_DOUBLE("PCM Playback Switch", 0,
+               CS4231_LEFT_OUTPUT, CS4231_RIGHT_OUTPUT, 7, 7, 1, 1),
+WSS_DOUBLE("PCM Playback Volume", 0,
+               CS4231_LEFT_OUTPUT, CS4231_RIGHT_OUTPUT, 0, 0, 63, 1),
+WSS_DOUBLE("Line Playback Switch", 0,
+               CMI8330_MUTEMUX, CMI8330_MUTEMUX, 4, 3, 1, 0),
+WSS_DOUBLE("Line Playback Volume", 0,
+               CMI8330_LINVOL, CMI8330_LINVOL, 4, 0, 15, 0),
+WSS_DOUBLE("Line Capture Switch", 0,
+               CMI8330_RMUX3D, CMI8330_RMUX3D, 2, 1, 1, 0),
+WSS_DOUBLE("Line Capture Volume", 0,
+               CMI8330_LINGAIN, CMI8330_LINGAIN, 4, 0, 15, 0),
+WSS_DOUBLE("CD Playback Switch", 0,
+               CMI8330_MUTEMUX, CMI8330_MUTEMUX, 2, 1, 1, 0),
+WSS_DOUBLE("CD Capture Switch", 0,
+               CMI8330_RMUX3D, CMI8330_RMUX3D, 4, 3, 1, 0),
+WSS_DOUBLE("CD Playback Volume", 0,
+               CMI8330_CDINVOL, CMI8330_CDINVOL, 4, 0, 15, 0),
+WSS_DOUBLE("CD Capture Volume", 0,
+               CMI8330_CDINGAIN, CMI8330_CDINGAIN, 4, 0, 15, 0),
+WSS_SINGLE("Mic Playback Switch", 0,
+               CMI8330_MUTEMUX, 0, 1, 0),
+WSS_SINGLE("Mic Playback Volume", 0,
+               CMI8330_OUTPUTVOL, 0, 7, 0),
+WSS_SINGLE("Mic Capture Switch", 0,
+               CMI8330_RMUX3D, 0, 1, 0),
+WSS_SINGLE("Mic Capture Volume", 0,
+               CMI8330_OUTPUTVOL, 5, 7, 0),
+WSS_DOUBLE("Wavetable Playback Switch", 0,
+               CMI8330_RECMUX, CMI8330_RECMUX, 1, 0, 1, 0),
+WSS_DOUBLE("Wavetable Playback Volume", 0,
+               CMI8330_WAVVOL, CMI8330_WAVVOL, 4, 0, 15, 0),
+WSS_DOUBLE("Wavetable Capture Switch", 0,
+               CMI8330_RECMUX, CMI8330_RECMUX, 5, 4, 1, 0),
+WSS_DOUBLE("Wavetable Capture Volume", 0,
+               CMI8330_WAVGAIN, CMI8330_WAVGAIN, 4, 0, 15, 0),
+WSS_SINGLE("3D Control - Switch", 0,
+               CMI8330_RMUX3D, 5, 1, 1),
+WSS_SINGLE("PC Speaker Playback Volume", 0,
+               CMI8330_OUTPUTVOL, 3, 3, 0),
+WSS_DOUBLE("FM Playback Switch", 0,
+               CS4231_AUX2_LEFT_INPUT, CS4231_AUX2_RIGHT_INPUT, 7, 7, 1, 1),
+WSS_DOUBLE("FM Playback Volume", 0,
+               CS4231_AUX2_LEFT_INPUT, CS4231_AUX2_RIGHT_INPUT, 0, 0, 31, 1),
+WSS_SINGLE(SNDRV_CTL_NAME_IEC958("Input ", CAPTURE, SWITCH), 0,
+               CMI8330_RMUX3D, 7, 1, 1),
+WSS_SINGLE(SNDRV_CTL_NAME_IEC958("Input ", PLAYBACK, SWITCH), 0,
+               CMI8330_MUTEMUX, 7, 1, 1),
 };
 
 #ifdef ENABLE_SB_MIXER
-static struct sbmix_elem cmi8330_sb_mixers[] __initdata = {
+static struct sbmix_elem cmi8330_sb_mixers[] __devinitdata = {
 SB_DOUBLE("SB Master Playback Volume", SB_DSP4_MASTER_DEV, (SB_DSP4_MASTER_DEV + 1), 3, 3, 31),
 SB_DOUBLE("Tone Control - Bass", SB_DSP4_BASS_DEV, (SB_DSP4_BASS_DEV + 1), 4, 4, 15),
 SB_DOUBLE("Tone Control - Treble", SB_DSP4_TREBLE_DEV, (SB_DSP4_TREBLE_DEV + 1), 4, 4, 15),
@@ -217,7 +260,7 @@ SB_DOUBLE("SB Playback Volume", SB_DSP4_OGAIN_DEV, (SB_DSP4_OGAIN_DEV + 1), 6, 6
 SB_SINGLE("SB Mic Auto Gain", SB_DSP4_MIC_AGC, 0, 1),
 };
 
-static unsigned char cmi8330_sb_init_values[][2] __initdata = {
+static unsigned char cmi8330_sb_init_values[][2] __devinitdata = {
        { SB_DSP4_MASTER_DEV + 0, 0 },
        { SB_DSP4_MASTER_DEV + 1, 0 },
        { SB_DSP4_PCM_DEV + 0, 0 },
@@ -231,7 +274,7 @@ static unsigned char cmi8330_sb_init_values[][2] __initdata = {
 };
 
 
-static int __devinit cmi8330_add_sb_mixers(sb_t *chip)
+static int __devinit cmi8330_add_sb_mixers(struct snd_sb *chip)
 {
        int idx, err;
        unsigned long flags;
@@ -256,7 +299,7 @@ static int __devinit cmi8330_add_sb_mixers(sb_t *chip)
 }
 #endif
 
-static int __devinit snd_cmi8330_mixer(snd_card_t *card, struct snd_cmi8330 *acard)
+static int __devinit snd_cmi8330_mixer(struct snd_card *card, struct snd_cmi8330 *acard)
 {
        unsigned int idx;
        int err;
@@ -264,7 +307,10 @@ static int __devinit snd_cmi8330_mixer(snd_card_t *card, struct snd_cmi8330 *aca
        strcpy(card->mixername, "CMI8330/C3D");
 
        for (idx = 0; idx < ARRAY_SIZE(snd_cmi8330_controls); idx++) {
-               if ((err = snd_ad1848_add_ctl_elem(acard->wss, &snd_cmi8330_controls[idx])) < 0)
+               err = snd_ctl_add(card,
+                               snd_ctl_new1(&snd_cmi8330_controls[idx],
+                                            acard->wss));
+               if (err < 0)
                        return err;
        }
 
@@ -281,62 +327,38 @@ static int __devinit snd_cmi8330_pnp(int dev, struct snd_cmi8330 *acard,
                                     const struct pnp_card_device_id *id)
 {
        struct pnp_dev *pdev;
-       struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
        int err;
 
        acard->cap = pnp_request_card_device(card, id->devs[0].id, NULL);
-       if (acard->cap == NULL) {
-               kfree(cfg);
+       if (acard->cap == NULL)
                return -EBUSY;
-       }
+
        acard->play = pnp_request_card_device(card, id->devs[1].id, NULL);
-       if (acard->play == NULL) {
-               kfree(cfg);
+       if (acard->play == NULL)
+               return -EBUSY;
+
+       acard->mpu = pnp_request_card_device(card, id->devs[2].id, NULL);
+       if (acard->play == NULL)
                return -EBUSY;
-       }
 
        pdev = acard->cap;
-       pnp_init_resource_table(cfg);
-       /* allocate AD1848 resources */
-       if (wssport[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[0], wssport[dev], 8);
-       if (wssdma[dev] != SNDRV_AUTO_DMA)
-               pnp_resource_change(&cfg->dma_resource[0], wssdma[dev], 1);
-       if (wssirq[dev] != SNDRV_AUTO_IRQ)
-               pnp_resource_change(&cfg->irq_resource[0], wssirq[dev], 1);
-
-       err = pnp_manual_config_dev(pdev, cfg, 0);
-       if (err < 0)
-               snd_printk(KERN_ERR "CMI8330/C3D (AD1848) PnP manual resources are invalid, using auto config\n");
+
        err = pnp_activate_dev(pdev);
        if (err < 0) {
-               snd_printk(KERN_ERR "CMI8330/C3D (AD1848) PnP configure failure\n");
-               kfree(cfg);
+               snd_printk(KERN_ERR "CMI8330/C3D PnP configure failure\n");
                return -EBUSY;
        }
        wssport[dev] = pnp_port_start(pdev, 0);
        wssdma[dev] = pnp_dma(pdev, 0);
        wssirq[dev] = pnp_irq(pdev, 0);
+       fmport[dev] = pnp_port_start(pdev, 1);
 
        /* allocate SB16 resources */
        pdev = acard->play;
-       pnp_init_resource_table(cfg);
-       if (sbport[dev] != SNDRV_AUTO_PORT)
-               pnp_resource_change(&cfg->port_resource[0], sbport[dev], 16);
-       if (sbdma8[dev] != SNDRV_AUTO_DMA)
-               pnp_resource_change(&cfg->dma_resource[0], sbdma8[dev], 1);
-       if (sbdma16[dev] != SNDRV_AUTO_DMA)
-               pnp_resource_change(&cfg->dma_resource[1], sbdma16[dev], 1);
-       if (sbirq[dev] != SNDRV_AUTO_IRQ)
-               pnp_resource_change(&cfg->irq_resource[0], sbirq[dev], 1);
-
-       err = pnp_manual_config_dev(pdev, cfg, 0);
-       if (err < 0)
-               snd_printk(KERN_ERR "CMI8330/C3D (SB16) PnP manual resources are invalid, using auto config\n");
+
        err = pnp_activate_dev(pdev);
        if (err < 0) {
                snd_printk(KERN_ERR "CMI8330/C3D (SB16) PnP configure failure\n");
-               kfree(cfg);
                return -EBUSY;
        }
        sbport[dev] = pnp_port_start(pdev, 0);
@@ -344,7 +366,17 @@ static int __devinit snd_cmi8330_pnp(int dev, struct snd_cmi8330 *acard,
        sbdma16[dev] = pnp_dma(pdev, 1);
        sbirq[dev] = pnp_irq(pdev, 0);
 
-       kfree(cfg);
+       /* allocate MPU-401 resources */
+       pdev = acard->mpu;
+
+       err = pnp_activate_dev(pdev);
+       if (err < 0) {
+               snd_printk(KERN_ERR
+                          "CMI8330/C3D (MPU-401) PnP configure failure\n");
+               return -EBUSY;
+       }
+       mpuport[dev] = pnp_port_start(pdev, 0);
+       mpuirq[dev] = pnp_irq(pdev, 0);
        return 0;
 }
 #endif
@@ -370,7 +402,7 @@ static int __devinit snd_cmi8330_pnp(int dev, struct snd_cmi8330 *acard,
 #define CMI_AD_STREAM  SNDRV_PCM_STREAM_PLAYBACK
 #endif
 
-static int snd_cmi8330_playback_open(snd_pcm_substream_t * substream)
+static int snd_cmi8330_playback_open(struct snd_pcm_substream *substream)
 {
        struct snd_cmi8330 *chip = snd_pcm_substream_chip(substream);
 
@@ -379,7 +411,7 @@ static int snd_cmi8330_playback_open(snd_pcm_substream_t * substream)
        return chip->streams[SNDRV_PCM_STREAM_PLAYBACK].open(substream);
 }
 
-static int snd_cmi8330_capture_open(snd_pcm_substream_t * substream)
+static int snd_cmi8330_capture_open(struct snd_pcm_substream *substream)
 {
        struct snd_cmi8330 *chip = snd_pcm_substream_chip(substream);
 
@@ -388,15 +420,10 @@ static int snd_cmi8330_capture_open(snd_pcm_substream_t * substream)
        return chip->streams[SNDRV_PCM_STREAM_CAPTURE].open(substream);
 }
 
-static void snd_cmi8330_pcm_free(snd_pcm_t *pcm)
-{
-       snd_pcm_lib_preallocate_free_for_all(pcm);
-}
-
-static int __devinit snd_cmi8330_pcm(snd_card_t *card, struct snd_cmi8330 *chip)
+static int __devinit snd_cmi8330_pcm(struct snd_card *card, struct snd_cmi8330 *chip)
 {
-       snd_pcm_t *pcm;
-       const snd_pcm_ops_t *ops;
+       struct snd_pcm *pcm;
+       const struct snd_pcm_ops *ops;
        int err;
        static snd_pcm_open_callback_t cmi_open_callbacks[2] = {
                snd_cmi8330_playback_open,
@@ -407,7 +434,6 @@ static int __devinit snd_cmi8330_pcm(snd_card_t *card, struct snd_cmi8330 *chip)
                return err;
        strcpy(pcm->name, "CMI8330");
        pcm->private_data = chip;
-       pcm->private_free = snd_cmi8330_pcm_free;
        
        /* SB16 */
        ops = snd_sb16dsp_get_pcm_ops(CMI_SB_STREAM);
@@ -417,7 +443,7 @@ static int __devinit snd_cmi8330_pcm(snd_card_t *card, struct snd_cmi8330 *chip)
        chip->streams[CMI_SB_STREAM].private_data = chip->sb;
 
        /* AD1848 */
-       ops = snd_ad1848_get_pcm_ops(CMI_AD_STREAM);
+       ops = snd_wss_get_pcm_ops(CMI_AD_STREAM);
        chip->streams[CMI_AD_STREAM].ops = *ops;
        chip->streams[CMI_AD_STREAM].open = ops->open;
        chip->streams[CMI_AD_STREAM].ops.open = cmi_open_callbacks[CMI_AD_STREAM];
@@ -435,6 +461,31 @@ static int __devinit snd_cmi8330_pcm(snd_card_t *card, struct snd_cmi8330 *chip)
 }
 
 
+#ifdef CONFIG_PM
+static int snd_cmi8330_suspend(struct snd_card *card)
+{
+       struct snd_cmi8330 *acard = card->private_data;
+
+       snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+       snd_pcm_suspend_all(acard->pcm);
+       acard->wss->suspend(acard->wss);
+       snd_sbmixer_suspend(acard->sb);
+       return 0;
+}
+
+static int snd_cmi8330_resume(struct snd_card *card)
+{
+       struct snd_cmi8330 *acard = card->private_data;
+
+       snd_sbdsp_reset(acard->sb);
+       snd_sbmixer_suspend(acard->sb);
+       acard->wss->resume(acard->wss);
+       snd_power_change_state(card, SNDRV_CTL_POWER_D0);
+       return 0;
+}
+#endif
+
+
 /*
  */
 
@@ -446,57 +497,42 @@ static int __devinit snd_cmi8330_pcm(snd_card_t *card, struct snd_cmi8330 *chip)
 
 #define PFX    "cmi8330: "
 
-static int __devinit snd_cmi8330_probe(int dev,
-                                      struct pnp_card_link *pcard,
-                                      const struct pnp_card_device_id *pid)
+static int snd_cmi8330_card_new(int dev, struct snd_card **cardp)
 {
-       snd_card_t *card;
+       struct snd_card *card;
        struct snd_cmi8330 *acard;
-       int i, err;
-
-       if (! is_isapnp_selected(dev)) {
-               if (wssport[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify wssport\n");
-                       return -EINVAL;
-               }
-               if (sbport[dev] == SNDRV_AUTO_PORT) {
-                       snd_printk(KERN_ERR PFX "specify sbport\n");
-                       return -EINVAL;
-               }
-       }
+       int err;
 
-       card = snd_card_new(index[dev], id[dev], THIS_MODULE,
-                           sizeof(struct snd_cmi8330));
-       if (card == NULL) {
+       err = snd_card_create(index[dev], id[dev], THIS_MODULE,
+                             sizeof(struct snd_cmi8330), &card);
+       if (err < 0) {
                snd_printk(KERN_ERR PFX "could not get a new card\n");
-               return -ENOMEM;
+               return err;
        }
-       acard = (struct snd_cmi8330 *)card->private_data;
+       acard = card->private_data;
        acard->card = card;
+       *cardp = card;
+       return 0;
+}
 
-#ifdef CONFIG_PNP
-       if (isapnp[dev]) {
-               if ((err = snd_cmi8330_pnp(dev, acard, pcard, pid)) < 0) {
-                       snd_printk(KERN_ERR PFX "PnP detection failed\n");
-                       goto _err;
-               }
-               snd_card_set_dev(card, &pcard->card->dev);
-       }
-#endif
+static int __devinit snd_cmi8330_probe(struct snd_card *card, int dev)
+{
+       struct snd_cmi8330 *acard;
+       int i, err;
+       struct snd_opl3 *opl3;
 
-       if ((err = snd_ad1848_create(card,
-                                    wssport[dev] + 4,
-                                    wssirq[dev],
-                                    wssdma[dev],
-                                    AD1848_HW_DETECT,
-                                    &acard->wss)) < 0) {
-               snd_printk(KERN_ERR PFX "(AD1848) device busy??\n");
-               goto _err;
+       acard = card->private_data;
+       err = snd_wss_create(card, wssport[dev] + 4, -1,
+                            wssirq[dev],
+                            wssdma[dev], -1,
+                            WSS_HW_DETECT, 0, &acard->wss);
+       if (err < 0) {
+               snd_printk(KERN_ERR PFX "(CMI8330) device busy??\n");
+               return err;
        }
-       if (acard->wss->hardware != AD1848_HW_CMI8330) {
-               snd_printk(KERN_ERR PFX "(AD1848) not found during probe\n");
-               err = -ENODEV;
-               goto _err;
+       if (acard->wss->hardware != WSS_HW_CMI8330) {
+               snd_printk(KERN_ERR PFX "(CMI8330) not found during probe\n");
+               return -ENODEV;
        }
 
        if ((err = snd_sbdsp_create(card, sbport[dev],
@@ -506,25 +542,47 @@ static int __devinit snd_cmi8330_probe(int dev,
                                    sbdma16[dev],
                                    SB_HW_AUTO, &acard->sb)) < 0) {
                snd_printk(KERN_ERR PFX "(SB16) device busy??\n");
-               goto _err;
+               return err;
        }
        if (acard->sb->hardware != SB_HW_16) {
                snd_printk(KERN_ERR PFX "(SB16) not found during probe\n");
-               goto _err;
+               return err;
        }
 
-       snd_ad1848_out(acard->wss, AD1848_MISC_INFO, 0x40); /* switch on MODE2 */
+       snd_wss_out(acard->wss, CS4231_MISC_INFO, 0x40); /* switch on MODE2 */
        for (i = CMI8330_RMUX3D; i <= CMI8330_CDINGAIN; i++)
-               snd_ad1848_out(acard->wss, i, snd_cmi8330_image[i - CMI8330_RMUX3D]);
+               snd_wss_out(acard->wss, i,
+                           snd_cmi8330_image[i - CMI8330_RMUX3D]);
 
        if ((err = snd_cmi8330_mixer(card, acard)) < 0) {
                snd_printk(KERN_ERR PFX "failed to create mixers\n");
-               goto _err;
+               return err;
        }
 
        if ((err = snd_cmi8330_pcm(card, acard)) < 0) {
                snd_printk(KERN_ERR PFX "failed to create pcms\n");
-               goto _err;
+               return err;
+       }
+       if (fmport[dev] != SNDRV_AUTO_PORT) {
+               if (snd_opl3_create(card,
+                                   fmport[dev], fmport[dev] + 2,
+                                   OPL3_HW_AUTO, 0, &opl3) < 0) {
+                       snd_printk(KERN_ERR PFX
+                                  "no OPL device at 0x%lx-0x%lx ?\n",
+                                  fmport[dev], fmport[dev] + 2);
+               } else {
+                       err = snd_opl3_hwdep_new(opl3, 0, 1, NULL);
+                       if (err < 0)
+                               return err;
+               }
+       }
+
+       if (mpuport[dev] != SNDRV_AUTO_PORT) {
+               if (snd_mpu401_uart_new(card, 0, MPU401_HW_MPU401,
+                                       mpuport[dev], 0, mpuirq[dev],
+                                       IRQF_DISABLED, NULL) < 0)
+                       printk(KERN_ERR PFX "no MPU-401 device at 0x%lx.\n",
+                               mpuport[dev]);
        }
 
        strcpy(card->driver, "CMI8330/C3D");
@@ -535,97 +593,172 @@ static int __devinit snd_cmi8330_probe(int dev,
                wssirq[dev],
                wssdma[dev]);
 
-       if ((err = snd_card_set_generic_dev(card)) < 0)
-               goto _err;
+       return snd_card_register(card);
+}
 
-       if ((err = snd_card_register(card)) < 0)
-               goto _err;
+static int __devinit snd_cmi8330_isa_match(struct device *pdev,
+                                          unsigned int dev)
+{
+       if (!enable[dev] || is_isapnp_selected(dev))
+               return 0;
+       if (wssport[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify wssport\n");
+               return 0;
+       }
+       if (sbport[dev] == SNDRV_AUTO_PORT) {
+               snd_printk(KERN_ERR PFX "specify sbport\n");
+               return 0;
+       }
+       return 1;
+}
+
+static int __devinit snd_cmi8330_isa_probe(struct device *pdev,
+                                          unsigned int dev)
+{
+       struct snd_card *card;
+       int err;
+
+       err = snd_cmi8330_card_new(dev, &card);
+       if (err < 0)
+               return err;
+       snd_card_set_dev(card, pdev);
+       if ((err = snd_cmi8330_probe(card, dev)) < 0) {
+               snd_card_free(card);
+               return err;
+       }
+       dev_set_drvdata(pdev, card);
+       return 0;
+}
 
-       if (pcard)
-               pnp_set_card_drvdata(pcard, card);
-       else
-               snd_cmi8330_legacy[dev] = card;
+static int __devexit snd_cmi8330_isa_remove(struct device *devptr,
+                                           unsigned int dev)
+{
+       snd_card_free(dev_get_drvdata(devptr));
+       dev_set_drvdata(devptr, NULL);
        return 0;
+}
 
- _err:
-       snd_card_free(card);
-       return err;
+#ifdef CONFIG_PM
+static int snd_cmi8330_isa_suspend(struct device *dev, unsigned int n,
+                                  pm_message_t state)
+{
+       return snd_cmi8330_suspend(dev_get_drvdata(dev));
 }
 
+static int snd_cmi8330_isa_resume(struct device *dev, unsigned int n)
+{
+       return snd_cmi8330_resume(dev_get_drvdata(dev));
+}
+#endif
+
+#define DEV_NAME       "cmi8330"
+
+static struct isa_driver snd_cmi8330_driver = {
+       .match          = snd_cmi8330_isa_match,
+       .probe          = snd_cmi8330_isa_probe,
+       .remove         = __devexit_p(snd_cmi8330_isa_remove),
+#ifdef CONFIG_PM
+       .suspend        = snd_cmi8330_isa_suspend,
+       .resume         = snd_cmi8330_isa_resume,
+#endif
+       .driver         = {
+               .name   = DEV_NAME
+       },
+};
+
+
 #ifdef CONFIG_PNP
-static int __devinit snd_cmi8330_pnp_detect(struct pnp_card_link *card,
-                                           const struct pnp_card_device_id *id)
+static int __devinit snd_cmi8330_pnp_detect(struct pnp_card_link *pcard,
+                                           const struct pnp_card_device_id *pid)
 {
        static int dev;
+       struct snd_card *card;
        int res;
 
        for ( ; dev < SNDRV_CARDS; dev++) {
-               if (!enable[dev] || !isapnp[dev])
-                       continue;
-               res = snd_cmi8330_probe(dev, card, id);
-               if (res < 0)
-                       return res;
-               dev++;
-               return 0;
+               if (enable[dev] && isapnp[dev])
+                       break;
+       }
+       if (dev >= SNDRV_CARDS)
+               return -ENODEV;
+                              
+       res = snd_cmi8330_card_new(dev, &card);
+       if (res < 0)
+               return res;
+       if ((res = snd_cmi8330_pnp(dev, card->private_data, pcard, pid)) < 0) {
+               snd_printk(KERN_ERR PFX "PnP detection failed\n");
+               snd_card_free(card);
+               return res;
+       }
+       snd_card_set_dev(card, &pcard->card->dev);
+       if ((res = snd_cmi8330_probe(card, dev)) < 0) {
+               snd_card_free(card);
+               return res;
        }
-       return -ENODEV;
+       pnp_set_card_drvdata(pcard, card);
+       dev++;
+       return 0;
 }
 
 static void __devexit snd_cmi8330_pnp_remove(struct pnp_card_link * pcard)
 {
-       snd_card_t *card = (snd_card_t *) pnp_get_card_drvdata(pcard);
+       snd_card_free(pnp_get_card_drvdata(pcard));
+       pnp_set_card_drvdata(pcard, NULL);
+}
 
-       snd_card_disconnect(card);
-       snd_card_free_in_thread(card);
+#ifdef CONFIG_PM
+static int snd_cmi8330_pnp_suspend(struct pnp_card_link *pcard, pm_message_t state)
+{
+       return snd_cmi8330_suspend(pnp_get_card_drvdata(pcard));
 }
 
+static int snd_cmi8330_pnp_resume(struct pnp_card_link *pcard)
+{
+       return snd_cmi8330_resume(pnp_get_card_drvdata(pcard));
+}
+#endif
+
 static struct pnp_card_driver cmi8330_pnpc_driver = {
        .flags = PNP_DRIVER_RES_DISABLE,
        .name = "cmi8330",
        .id_table = snd_cmi8330_pnpids,
        .probe = snd_cmi8330_pnp_detect,
        .remove = __devexit_p(snd_cmi8330_pnp_remove),
+#ifdef CONFIG_PM
+       .suspend        = snd_cmi8330_pnp_suspend,
+       .resume         = snd_cmi8330_pnp_resume,
+#endif
 };
 #endif /* CONFIG_PNP */
 
 static int __init alsa_card_cmi8330_init(void)
 {
-       int dev, cards = 0;
-
-       for (dev = 0; dev < SNDRV_CARDS; dev++) {
-               if (!enable[dev])
-                       continue;
-               if (is_isapnp_selected(dev))
-                       continue;
-               if (snd_cmi8330_probe(dev, NULL, NULL) >= 0)
-                       cards++;
-       }
-#ifdef CONFIG_PNP
-       cards += pnp_register_card_driver(&cmi8330_pnpc_driver);
-#endif
+       int err;
 
-       if (!cards) {
+       err = isa_register_driver(&snd_cmi8330_driver, SNDRV_CARDS);
 #ifdef CONFIG_PNP
-               pnp_unregister_card_driver(&cmi8330_pnpc_driver);
-#endif
-#ifdef MODULE
-               snd_printk(KERN_ERR "CMI8330 not found or device busy\n");
+       if (!err)
+               isa_registered = 1;
+
+       err = pnp_register_card_driver(&cmi8330_pnpc_driver);
+       if (!err)
+               pnp_registered = 1;
+
+       if (isa_registered)
+               err = 0;
 #endif
-               return -ENODEV;
-       }
-       return 0;
+       return err;
 }
 
 static void __exit alsa_card_cmi8330_exit(void)
 {
-       int i;
-
 #ifdef CONFIG_PNP
-       /* PnP cards first */
-       pnp_unregister_card_driver(&cmi8330_pnpc_driver);
+       if (pnp_registered)
+               pnp_unregister_card_driver(&cmi8330_pnpc_driver);
+
+       if (isa_registered)
 #endif
-       for (i = 0; i < SNDRV_CARDS; i++)
-               snd_card_free(snd_cmi8330_legacy[i]);
+               isa_unregister_driver(&snd_cmi8330_driver);
 }
 
 module_init(alsa_card_cmi8330_init)