pkt_sched: pedit use proper struct

[safe/jmp/linux-2.6] / net / sched / act_api.c

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 87818d7..2dfb3e7 100644 (file)
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -41,7 +41,7 @@ void tcf_hash_destroy(struct tcf_common *p, struct tcf_hashinfo *hinfo)
                        return;
                }
        }
-       BUG_TRAP(0);
+       WARN_ON(1);
 }
 EXPORT_SYMBOL(tcf_hash_destroy);
 
@@ -69,7 +69,7 @@ static int tcf_dump_walker(struct sk_buff *skb, struct netlink_callback *cb,
 {
        struct tcf_common *p;
        int err = 0, index = -1,i = 0, s_i = 0, n_i = 0;
-       struct nlattr *r ;
+       struct nlattr *nest;
 
        read_lock_bh(hinfo->lock);
 
@@ -84,15 +84,17 @@ static int tcf_dump_walker(struct sk_buff *skb, struct netlink_callback *cb,
                                continue;
                        a->priv = p;
                        a->order = n_i;
-                       r = (struct nlattr *)skb_tail_pointer(skb);
-                       NLA_PUT(skb, a->order, 0, NULL);
+
+                       nest = nla_nest_start(skb, a->order);
+                       if (nest == NULL)
+                               goto nla_put_failure;
                        err = tcf_action_dump_1(skb, a, 0, 0);
                        if (err < 0) {
                                index--;
-                               nlmsg_trim(skb, r);
+                               nlmsg_trim(skb, nest);
                                goto done;
                        }
-                       r->nla_len = skb_tail_pointer(skb) - (u8 *)r;
+                       nla_nest_end(skb, nest);
                        n_i++;
                        if (n_i >= TCA_ACT_MAX_PRIO)
                                goto done;
@@ -105,7 +107,7 @@ done:
        return n_i;
 
 nla_put_failure:
-       nlmsg_trim(skb, r);
+       nla_nest_cancel(skb, nest);
        goto done;
 }
 
@@ -113,12 +115,13 @@ static int tcf_del_walker(struct sk_buff *skb, struct tc_action *a,
                          struct tcf_hashinfo *hinfo)
 {
        struct tcf_common *p, *s_p;
-       struct nlattr *r ;
+       struct nlattr *nest;
        int i= 0, n_i = 0;
 
-       r = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, a->order, 0, NULL);
-       NLA_PUT(skb, TCA_KIND, IFNAMSIZ, a->ops->kind);
+       nest = nla_nest_start(skb, a->order);
+       if (nest == NULL)
+               goto nla_put_failure;
+       NLA_PUT_STRING(skb, TCA_KIND, a->ops->kind);
        for (i = 0; i < (hinfo->hmask + 1); i++) {
                p = hinfo->htab[tcf_hash(i, hinfo->hmask)];
 
@@ -130,12 +133,12 @@ static int tcf_del_walker(struct sk_buff *skb, struct tc_action *a,
                        p = s_p;
                }
        }
-       NLA_PUT(skb, TCA_FCNT, 4, &n_i);
-       r->nla_len = skb_tail_pointer(skb) - (u8 *)r;
+       NLA_PUT_U32(skb, TCA_FCNT, n_i);
+       nla_nest_end(skb, nest);
 
        return n_i;
 nla_put_failure:
-       nlmsg_trim(skb, r);
+       nla_nest_cancel(skb, nest);
        return -EINVAL;
 }
 
@@ -202,22 +205,23 @@ struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a, int bind,
 {
        struct tcf_common *p = NULL;
        if (index && (p = tcf_hash_lookup(index, hinfo)) != NULL) {
-               if (bind) {
+               if (bind)
                        p->tcfc_bindcnt++;
-                       p->tcfc_refcnt++;
-               }
+               p->tcfc_refcnt++;
                a->priv = p;
        }
        return p;
 }
 EXPORT_SYMBOL(tcf_hash_check);
 
-struct tcf_common *tcf_hash_create(u32 index, struct nlattr *est, struct tc_action *a, int size, int bind, u32 *idx_gen, struct tcf_hashinfo *hinfo)
+struct tcf_common *tcf_hash_create(u32 index, struct nlattr *est,
+                                  struct tc_action *a, int size, int bind,
+                                  u32 *idx_gen, struct tcf_hashinfo *hinfo)
 {
        struct tcf_common *p = kzalloc(size, GFP_KERNEL);
 
        if (unlikely(!p))
-               return p;
+               return ERR_PTR(-ENOMEM);
        p->tcfc_refcnt = 1;
        if (bind)
                p->tcfc_bindcnt = 1;
@@ -226,9 +230,15 @@ struct tcf_common *tcf_hash_create(u32 index, struct nlattr *est, struct tc_acti
        p->tcfc_index = index ? index : tcf_hash_new_index(idx_gen, hinfo);
        p->tcfc_tm.install = jiffies;
        p->tcfc_tm.lastuse = jiffies;
-       if (est)
-               gen_new_estimator(&p->tcfc_bstats, &p->tcfc_rate_est,
-                                 &p->tcfc_lock, est);
+       if (est) {
+               int err = gen_new_estimator(&p->tcfc_bstats, &p->tcfc_rate_est,
+                                           &p->tcfc_lock, est);
+               if (err) {
+                       kfree(p);
+                       return ERR_PTR(err);
+               }
+       }
+
        a->priv = (void *) p;
        return p;
 }
@@ -415,18 +425,19 @@ tcf_action_dump_1(struct sk_buff *skb, struct tc_action *a, int bind, int ref)
 {
        int err = -EINVAL;
        unsigned char *b = skb_tail_pointer(skb);
-       struct nlattr *r;
+       struct nlattr *nest;
 
        if (a->ops == NULL || a->ops->dump == NULL)
                return err;
 
-       NLA_PUT(skb, TCA_KIND, IFNAMSIZ, a->ops->kind);
+       NLA_PUT_STRING(skb, TCA_KIND, a->ops->kind);
        if (tcf_action_copy_stats(skb, a, 0))
                goto nla_put_failure;
-       r = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, TCA_OPTIONS, 0, NULL);
+       nest = nla_nest_start(skb, TCA_OPTIONS);
+       if (nest == NULL)
+               goto nla_put_failure;
        if ((err = tcf_action_dump_old(skb, a, bind, ref)) > 0) {
-               r->nla_len = skb_tail_pointer(skb) - (u8 *)r;
+               nla_nest_end(skb, nest);
                return err;
        }
 
@@ -441,17 +452,17 @@ tcf_action_dump(struct sk_buff *skb, struct tc_action *act, int bind, int ref)
 {
        struct tc_action *a;
        int err = -EINVAL;
-       unsigned char *b = skb_tail_pointer(skb);
-       struct nlattr *r ;
+       struct nlattr *nest;
 
        while ((a = act) != NULL) {
-               r = (struct nlattr *)skb_tail_pointer(skb);
                act = a->next;
-               NLA_PUT(skb, a->order, 0, NULL);
+               nest = nla_nest_start(skb, a->order);
+               if (nest == NULL)
+                       goto nla_put_failure;
                err = tcf_action_dump_1(skb, a, bind, ref);
                if (err < 0)
                        goto errout;
-               r->nla_len = skb_tail_pointer(skb) - (u8 *)r;
+               nla_nest_end(skb, nest);
        }
 
        return 0;
@@ -459,7 +470,7 @@ tcf_action_dump(struct sk_buff *skb, struct tc_action *act, int bind, int ref)
 nla_put_failure:
        err = -EINVAL;
 errout:
-       nlmsg_trim(skb, b);
+       nla_nest_cancel(skb, nest);
        return err;
 }
 
@@ -491,7 +502,7 @@ struct tc_action *tcf_action_init_1(struct nlattr *nla, struct nlattr *est,
 
        a_o = tc_lookup_action_n(act_name);
        if (a_o == NULL) {
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
                rtnl_unlock();
                request_module("act_%s", act_name);
                rtnl_lock();
@@ -627,7 +638,7 @@ tca_get_fill(struct sk_buff *skb, struct tc_action *a, u32 pid, u32 seq,
        struct tcamsg *t;
        struct nlmsghdr *nlh;
        unsigned char *b = skb_tail_pointer(skb);
-       struct nlattr *x;
+       struct nlattr *nest;
 
        nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*t), flags);
 
@@ -636,13 +647,14 @@ tca_get_fill(struct sk_buff *skb, struct tc_action *a, u32 pid, u32 seq,
        t->tca__pad1 = 0;
        t->tca__pad2 = 0;
 
-       x = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, TCA_ACT_TAB, 0, NULL);
+       nest = nla_nest_start(skb, TCA_ACT_TAB);
+       if (nest == NULL)
+               goto nla_put_failure;
 
        if (tcf_action_dump(skb, a, bind, ref) < 0)
                goto nla_put_failure;
 
-       x->nla_len = skb_tail_pointer(skb) - (u8 *)x;
+       nla_nest_end(skb, nest);
 
        nlh->nlmsg_len = skb_tail_pointer(skb) - b;
        return skb->len;
@@ -685,7 +697,7 @@ tcf_action_get_1(struct nlattr *nla, struct nlmsghdr *n, u32 pid)
        if (tb[TCA_ACT_INDEX] == NULL ||
            nla_len(tb[TCA_ACT_INDEX]) < sizeof(index))
                goto err_out;
-       index = *(int *)nla_data(tb[TCA_ACT_INDEX]);
+       index = nla_get_u32(tb[TCA_ACT_INDEX]);
 
        err = -ENOMEM;
        a = kzalloc(sizeof(struct tc_action), GFP_KERNEL);
@@ -743,11 +755,11 @@ static int tca_action_flush(struct nlattr *nla, struct nlmsghdr *n, u32 pid)
        struct nlmsghdr *nlh;
        struct tcamsg *t;
        struct netlink_callback dcb;
-       struct nlattr *x;
+       struct nlattr *nest;
        struct nlattr *tb[TCA_ACT_MAX+1];
        struct nlattr *kind;
        struct tc_action *a = create_a(0);
-       int err = -EINVAL;
+       int err = -ENOMEM;
 
        if (a == NULL) {
                printk("tca_action_flush: couldnt create tc_action\n");
@@ -758,7 +770,7 @@ static int tca_action_flush(struct nlattr *nla, struct nlmsghdr *n, u32 pid)
        if (!skb) {
                printk("tca_action_flush: failed skb alloc\n");
                kfree(a);
-               return -ENOBUFS;
+               return err;
        }
 
        b = skb_tail_pointer(skb);
@@ -779,14 +791,17 @@ static int tca_action_flush(struct nlattr *nla, struct nlmsghdr *n, u32 pid)
        t->tca__pad1 = 0;
        t->tca__pad2 = 0;
 
-       x = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, TCA_ACT_TAB, 0, NULL);
+       nest = nla_nest_start(skb, TCA_ACT_TAB);
+       if (nest == NULL)
+               goto nla_put_failure;
 
        err = a->ops->walk(skb, &dcb, RTM_DELACTION, a);
        if (err < 0)
                goto nla_put_failure;
+       if (err == 0)
+               goto noflush_out;
 
-       x->nla_len = skb_tail_pointer(skb) - (u8 *)x;
+       nla_nest_end(skb, nest);
 
        nlh->nlmsg_len = skb_tail_pointer(skb) - b;
        nlh->nlmsg_flags |= NLM_F_ROOT;
@@ -802,6 +817,7 @@ nla_put_failure:
 nlmsg_failure:
        module_put(a->ops->owner);
 err_out:
+noflush_out:
        kfree_skb(skb);
        kfree(a);
        return err;
@@ -819,8 +835,10 @@ tca_action_gd(struct nlattr *nla, struct nlmsghdr *n, u32 pid, int event)
                return ret;
 
        if (event == RTM_DELACTION && n->nlmsg_flags&NLM_F_ROOT) {
-               if (tb[0] != NULL && tb[1] == NULL)
-                       return tca_action_flush(tb[0], n, pid);
+               if (tb[1] != NULL)
+                       return tca_action_flush(tb[1], n, pid);
+               else
+                       return -EINVAL;
        }
 
        for (i = 1; i <= TCA_ACT_MAX_PRIO && tb[i]; i++) {
@@ -875,7 +893,7 @@ static int tcf_add_notify(struct tc_action *a, u32 pid, u32 seq, int event,
        struct tcamsg *t;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       struct nlattr *x;
+       struct nlattr *nest;
        unsigned char *b;
        int err = 0;
 
@@ -891,13 +909,14 @@ static int tcf_add_notify(struct tc_action *a, u32 pid, u32 seq, int event,
        t->tca__pad1 = 0;
        t->tca__pad2 = 0;
 
-       x = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, TCA_ACT_TAB, 0, NULL);
+       nest = nla_nest_start(skb, TCA_ACT_TAB);
+       if (nest == NULL)
+               goto nla_put_failure;
 
        if (tcf_action_dump(skb, a, 0, 0) < 0)
                goto nla_put_failure;
 
-       x->nla_len = skb_tail_pointer(skb) - (u8 *)x;
+       nla_nest_end(skb, nest);
 
        nlh->nlmsg_len = skb_tail_pointer(skb) - b;
        NETLINK_CB(skb).dst_group = RTNLGRP_TC;
@@ -944,7 +963,7 @@ done:
 
 static int tc_ctl_action(struct sk_buff *skb, struct nlmsghdr *n, void *arg)
 {
-       struct net *net = skb->sk->sk_net;
+       struct net *net = sock_net(skb->sk);
        struct nlattr *tca[TCA_ACT_MAX + 1];
        u32 pid = skb ? NETLINK_CB(skb).pid : 0;
        int ret = 0, ovr = 0;
@@ -992,7 +1011,7 @@ replay:
 }
 
 static struct nlattr *
-find_dump_kind(struct nlmsghdr *n)
+find_dump_kind(const struct nlmsghdr *n)
 {
        struct nlattr *tb1, *tb2[TCA_ACT_MAX+1];
        struct nlattr *tb[TCA_ACT_MAX_PRIO + 1];
@@ -1022,10 +1041,10 @@ find_dump_kind(struct nlmsghdr *n)
 static int
 tc_dump_action(struct sk_buff *skb, struct netlink_callback *cb)
 {
-       struct net *net = skb->sk->sk_net;
+       struct net *net = sock_net(skb->sk);
        struct nlmsghdr *nlh;
        unsigned char *b = skb_tail_pointer(skb);
-       struct nlattr *x;
+       struct nlattr *nest;
        struct tc_action_ops *a_o;
        struct tc_action a;
        int ret = 0;
@@ -1060,18 +1079,19 @@ tc_dump_action(struct sk_buff *skb, struct netlink_callback *cb)
        t->tca__pad1 = 0;
        t->tca__pad2 = 0;
 
-       x = (struct nlattr *)skb_tail_pointer(skb);
-       NLA_PUT(skb, TCA_ACT_TAB, 0, NULL);
+       nest = nla_nest_start(skb, TCA_ACT_TAB);
+       if (nest == NULL)
+               goto nla_put_failure;
 
        ret = a_o->walk(skb, cb, RTM_GETACTION, &a);
        if (ret < 0)
                goto nla_put_failure;
 
        if (ret > 0) {
-               x->nla_len = skb_tail_pointer(skb) - (u8 *)x;
+               nla_nest_end(skb, nest);
                ret = skb->len;
        } else
-               nlmsg_trim(skb, x);
+               nla_nest_cancel(skb, nest);
 
        nlh->nlmsg_len = skb_tail_pointer(skb) - b;
        if (NETLINK_CB(cb->skb).pid && ret)